url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/3760 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3760/labels{/name} | https://api.github.com/repos/psf/requests/issues/3760/comments | https://api.github.com/repos/psf/requests/issues/3760/events | https://github.com/psf/requests/pull/3760 | 194,612,069 | MDExOlB1bGxSZXF1ZXN0OTczMjAxMTc= | 3,760 | Add deprecation warnings for 3.0 | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-12-09T14:41:16Z | 2021-09-08T01:21:30Z | 2016-12-09T14:48:42Z | CONTRIBUTOR | resolved | Add extra test parameter for basic auth encoding | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3760/reactions"
} | https://api.github.com/repos/psf/requests/issues/3760/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3760.diff",
"html_url": "https://github.com/psf/requests/pull/3760",
"merged_at": "2016-12-09T14:48:42Z",
"patch_url": "https://github.com/psf/requests/pull/3760.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3760"
} | true | [
"Don't merge yet, I think I swapped the warning message and class",
"r4r @Lukasa @nateprewitt ",
"@Lukasa when you get another second to merge master into Proposed/3.0.0, I'll throw up the other patch.",
"Already done. ;)",
"hell yeah!",
"Looks like we might be hitting a problem in 2.6 with zero length va... |
https://api.github.com/repos/psf/requests/issues/3759 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3759/labels{/name} | https://api.github.com/repos/psf/requests/issues/3759/comments | https://api.github.com/repos/psf/requests/issues/3759/events | https://github.com/psf/requests/issues/3759 | 194,476,114 | MDU6SXNzdWUxOTQ0NzYxMTQ= | 3,759 | cookies.py why replace escaped quote with nothing? | {
"avatar_url": "https://avatars.githubusercontent.com/u/664265?v=4",
"events_url": "https://api.github.com/users/saft/events{/privacy}",
"followers_url": "https://api.github.com/users/saft/followers",
"following_url": "https://api.github.com/users/saft/following{/other_user}",
"gists_url": "https://api.github.com/users/saft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/saft",
"id": 664265,
"login": "saft",
"node_id": "MDQ6VXNlcjY2NDI2NQ==",
"organizations_url": "https://api.github.com/users/saft/orgs",
"received_events_url": "https://api.github.com/users/saft/received_events",
"repos_url": "https://api.github.com/users/saft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/saft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/saft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/saft",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 21 | 2016-12-08T23:47:56Z | 2023-11-27T13:30:27Z | null | NONE | null | https://github.com/kennethreitz/requests/blob/master/requests/cookies.py#L346
Why do this? An escaped quote can be sent in the case of sending json in the cookie and this code mangles that json. I'm raising this because the http library seems to think that formatting the json this way on the server is the right way to do it. See http/cookies.py function _quote line 225 in my 3.4 version. | null | {
"+1": 3,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 3,
"url": "https://api.github.com/repos/psf/requests/issues/3759/reactions"
} | https://api.github.com/repos/psf/requests/issues/3759/timeline | null | null | null | null | false | [
"Can you provide an example of a server sending JSON in the cookie header? The RFCs ([6265](https://tools.ietf.org/html/rfc6265)) for Cookies are explicit and JSON really doesn't fit into the cookie header appropriately.",
"The following library does it quite explicitly. I'm not sure how stable it is but it is re... |
https://api.github.com/repos/psf/requests/issues/3758 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3758/labels{/name} | https://api.github.com/repos/psf/requests/issues/3758/comments | https://api.github.com/repos/psf/requests/issues/3758/events | https://github.com/psf/requests/pull/3758 | 194,456,400 | MDExOlB1bGxSZXF1ZXN0OTcyMDk3MjY= | 3,758 | adding string casting for non-bytes values | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-12-08T22:01:52Z | 2021-09-08T01:21:34Z | 2016-12-09T08:45:14Z | MEMBER | resolved | This addresses #3753, I'll open a PR for 3.0.0 removing this when we merge master. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3758/reactions"
} | https://api.github.com/repos/psf/requests/issues/3758/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3758.diff",
"html_url": "https://github.com/psf/requests/pull/3758",
"merged_at": "2016-12-09T08:45:14Z",
"patch_url": "https://github.com/psf/requests/pull/3758.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3758"
} | true | [
"i support this",
"it's stupid, but no reason not to ",
"LGTM. Thanks for this @nateprewitt! :sparkles:",
"And I've just caught the 3.0.0 branch up, so you can go ahead and open the second PR now.",
"@sigmavirus24 you're suggesting using `warnings.warn` to actively notify the user about the deprecation, cor... |
https://api.github.com/repos/psf/requests/issues/3757 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3757/labels{/name} | https://api.github.com/repos/psf/requests/issues/3757/comments | https://api.github.com/repos/psf/requests/issues/3757/events | https://github.com/psf/requests/pull/3757 | 194,408,161 | MDExOlB1bGxSZXF1ZXN0OTcxNzQzMTc= | 3,757 | 301/302 redirects for non-POST with body | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-12-08T18:23:36Z | 2021-09-08T01:21:32Z | 2016-12-12T15:54:17Z | MEMBER | resolved | This patch is an attempt to address #2590 by relaxing the way Requests handles redirects.
Taking a look at how we’re handling stripping bodies, I modified the conditional to avoid an overly complicated check. The only requests we want to strip bodies off of are ones that have been modified from the redirect. That means the method will have already been changed to GET in `rebuild_method` and we can perform a uniform stripping for only GET requests. Personally, I'd like to have `rebuild_method` return a value, either a boolean or the new method, and use that as the parameter for the check. Then move the code inside the conditional into it's own function. This will help a bit with the overall size of `resolve_redirects`.
I also removed the 302 catch-all which was put in place in #1704 when RFC 2616 was still the standard. The previous mandates for 302 aren’t included in [RFC 7231 6.4.3](https://tools.ietf.org/html/rfc7231#section-6.4.3) and don’t appear to be reproducible in Chrome or Firefox with any tools supporting PUT, PATCH, or DELETE. (Note: if there’s a repro for this that I’m missing please let me know and I’ll gladly revert this. I’m just going off of the information available.)
The "test all methods" tests may be a bit overboard, I added them primarily for my own assurance to make sure I wasn't missing edge cases. I can remove those if they're deemed unnecessary. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3757/reactions"
} | https://api.github.com/repos/psf/requests/issues/3757/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3757.diff",
"html_url": "https://github.com/psf/requests/pull/3757",
"merged_at": "2016-12-12T15:54:17Z",
"patch_url": "https://github.com/psf/requests/pull/3757.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3757"
} | true | [
"Alright, comments updated.\r\n\r\n> Personally, I'd like to have rebuild_method return a value, either a boolean or the new method, and use that as the parameter for the check. Then move the code inside the conditional into it's own function. This will help a bit with the overall size of resolve_redirects.\r\n\r\n... |
https://api.github.com/repos/psf/requests/issues/3756 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3756/labels{/name} | https://api.github.com/repos/psf/requests/issues/3756/comments | https://api.github.com/repos/psf/requests/issues/3756/events | https://github.com/psf/requests/issues/3756 | 194,406,787 | MDU6SXNzdWUxOTQ0MDY3ODc= | 3,756 | ImportError: No module named urllib3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/3091956?v=4",
"events_url": "https://api.github.com/users/mperino/events{/privacy}",
"followers_url": "https://api.github.com/users/mperino/followers",
"following_url": "https://api.github.com/users/mperino/following{/other_user}",
"gists_url": "https://api.github.com/users/mperino/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mperino",
"id": 3091956,
"login": "mperino",
"node_id": "MDQ6VXNlcjMwOTE5NTY=",
"organizations_url": "https://api.github.com/users/mperino/orgs",
"received_events_url": "https://api.github.com/users/mperino/received_events",
"repos_url": "https://api.github.com/users/mperino/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mperino/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mperino/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mperino",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-12-08T18:17:12Z | 2021-09-08T06:00:34Z | 2016-12-08T18:21:39Z | NONE | resolved | On Python 2.6 on Solaris
Did a pip install requests, and simple example code produces:
the version is requests-2.12.3
Traceback (most recent call last):
File "/www/htdocs/cgi-bin/scrapetest.py", line 7, in <module>
from requests.auth import HTTPBasicAuth
File "/opt/csw/lib/python2.6/site-packages/requests/__init__.py", line 60, in <module>
from .packages.urllib3.exceptions import DependencyWarning
File "/opt/csw/lib/python2.6/site-packages/requests/packages/__init__.py", line 29, in <module>
import urllib3
ImportError: No module named urllib3
Tried Un-install, re-install neither fixes it.
Tried installing urllib3 (urllib3-1.19.1) which produces a different traceback message:
Traceback (most recent call last):
File "/www/htdocs/cgi-bin/scrapetest.py", line 7, in <module>
from requests.auth import HTTPBasicAuth
File "/opt/csw/lib/python2.6/site-packages/requests/__init__.py", line 60, in <module>
from .packages.urllib3.exceptions import DependencyWarning
File "/opt/csw/lib/python2.6/site-packages/requests/packages/__init__.py", line 29, in <module>
import urllib3
File "/opt/csw/lib/python2.6/site-packages/urllib3/__init__.py", line 8, in <module>
from .connectionpool import (
File "/opt/csw/lib/python2.6/site-packages/urllib3/connectionpool.py", line 11, in <module>
from .exceptions import (
File "/opt/csw/lib/python2.6/site-packages/urllib3/exceptions.py", line 2, in <module>
from .packages.six.moves.http_client import (
File "/opt/csw/lib/python2.6/site-packages/urllib3/packages/six.py", line 27, in <module>
import operator
ImportError: ld.so.1: python2.6: fatal: relocation error: file /opt/csw/lib/python2.6/lib-dynload/operator.so: symbol _PyUnicodeUCS4_AsDefaultEncodedString: referenced symbol not found
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3756/reactions"
} | https://api.github.com/repos/psf/requests/issues/3756/timeline | null | completed | null | null | false | [
"Your Python install seems extremely broken. Your Python is somehow unable to find files that pip should have installed in the same directory as Requests and as well seems to be unable to import six, which should be very simple, due to a symbol problem inside Python itself.\r\n\r\nYou will need to fix your Python b... |
https://api.github.com/repos/psf/requests/issues/3755 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3755/labels{/name} | https://api.github.com/repos/psf/requests/issues/3755/comments | https://api.github.com/repos/psf/requests/issues/3755/events | https://github.com/psf/requests/issues/3755 | 194,246,481 | MDU6SXNzdWUxOTQyNDY0ODE= | 3,755 | extensions issue with requests-2.12.3-py3.5.egg | {
"avatar_url": "https://avatars.githubusercontent.com/u/9314150?v=4",
"events_url": "https://api.github.com/users/luwm001/events{/privacy}",
"followers_url": "https://api.github.com/users/luwm001/followers",
"following_url": "https://api.github.com/users/luwm001/following{/other_user}",
"gists_url": "https://api.github.com/users/luwm001/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/luwm001",
"id": 9314150,
"login": "luwm001",
"node_id": "MDQ6VXNlcjkzMTQxNTA=",
"organizations_url": "https://api.github.com/users/luwm001/orgs",
"received_events_url": "https://api.github.com/users/luwm001/received_events",
"repos_url": "https://api.github.com/users/luwm001/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/luwm001/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/luwm001/subscriptions",
"type": "User",
"url": "https://api.github.com/users/luwm001",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-12-08T04:48:20Z | 2021-09-08T13:05:42Z | 2016-12-08T06:09:53Z | NONE | resolved | after upgarde to 2.12.3 under win10, below issue is encountered, any suggestion?
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\sessions.py", line 535, in post
return self.request('POST', url, data=data, json=json, **kwargs)
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\sessions.py", line 488, in request
resp = self.send(prep, **send_kwargs)
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\sessions.py", line 609, in send
r = adapter.send(request, **kwargs)
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\adapters.py", line 423, in send
timeout=timeout
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\packages\urllib3\connectionpool.py", line 594, in urlopen
chunked=chunked)
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\packages\urllib3\connectionpool.py", line 350, in _make_request
self._validate_conn(conn)
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\packages\urllib3\connectionpool.py", line 835, in _validate_conn
conn.connect()
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\packages\urllib3\connection.py", line 330, in connect
cert = self.sock.getpeercert()
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\packages\urllib3\contrib\pyopenssl.py", line 324, in getpeercert
'subjectAltName': get_subj_alt_name(x509)
File "d:\Anaconda3\lib\site-packages\requests-2.12.3-py3.5.egg\requests\packages\urllib3\contrib\pyopenssl.py", line 171, in get_subj_alt_name
ext = cert.extensions.get_extension_for_class(
AttributeError: 'Extensions' object has no attribute 'get_extension_for_class' | {
"avatar_url": "https://avatars.githubusercontent.com/u/9314150?v=4",
"events_url": "https://api.github.com/users/luwm001/events{/privacy}",
"followers_url": "https://api.github.com/users/luwm001/followers",
"following_url": "https://api.github.com/users/luwm001/following{/other_user}",
"gists_url": "https://api.github.com/users/luwm001/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/luwm001",
"id": 9314150,
"login": "luwm001",
"node_id": "MDQ6VXNlcjkzMTQxNTA=",
"organizations_url": "https://api.github.com/users/luwm001/orgs",
"received_events_url": "https://api.github.com/users/luwm001/received_events",
"repos_url": "https://api.github.com/users/luwm001/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/luwm001/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/luwm001/subscriptions",
"type": "User",
"url": "https://api.github.com/users/luwm001",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3755/reactions"
} | https://api.github.com/repos/psf/requests/issues/3755/timeline | null | completed | null | null | false | [
"Hey @luwm001, this appears to be a duplicate of #3710. I believe you'll be able to solve this issue by updating your `cryptography` module version.",
"Thanks."
] |
https://api.github.com/repos/psf/requests/issues/3754 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3754/labels{/name} | https://api.github.com/repos/psf/requests/issues/3754/comments | https://api.github.com/repos/psf/requests/issues/3754/events | https://github.com/psf/requests/pull/3754 | 194,243,782 | MDExOlB1bGxSZXF1ZXN0OTcwNTY5MjQ= | 3,754 | test auth doesn't generate incorrect http headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-12-08T04:21:45Z | 2021-09-08T01:21:35Z | 2016-12-08T09:05:13Z | MEMBER | resolved | These are a few tests from #3338 which is slated for Proposed/3.0.0. #3066 is the issue #3338 was originally opened to fix, but has since been resolved on master with #3082 and #3535. Adding these tests will allow us to confirm #3066 is indeed resolved and help prevent regressions until 3.0.0 is released. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3754/reactions"
} | https://api.github.com/repos/psf/requests/issues/3754/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3754.diff",
"html_url": "https://github.com/psf/requests/pull/3754",
"merged_at": "2016-12-08T09:05:13Z",
"patch_url": "https://github.com/psf/requests/pull/3754.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3754"
} | true | [
"Is the plan for this to land in 3.0.0 or master? Your summary isn't entirely clear.",
"Based on some of the other issues you linked I *think* you did want these tests in master.",
"Yep, master was the goal here. Thanks!"
] |
https://api.github.com/repos/psf/requests/issues/3753 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3753/labels{/name} | https://api.github.com/repos/psf/requests/issues/3753/comments | https://api.github.com/repos/psf/requests/issues/3753/events | https://github.com/psf/requests/issues/3753 | 194,227,851 | MDU6SXNzdWUxOTQyMjc4NTE= | 3,753 | Basic auth with integer username broken in 2.12.2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/278835?v=4",
"events_url": "https://api.github.com/users/oschwald/events{/privacy}",
"followers_url": "https://api.github.com/users/oschwald/followers",
"following_url": "https://api.github.com/users/oschwald/following{/other_user}",
"gists_url": "https://api.github.com/users/oschwald/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/oschwald",
"id": 278835,
"login": "oschwald",
"node_id": "MDQ6VXNlcjI3ODgzNQ==",
"organizations_url": "https://api.github.com/users/oschwald/orgs",
"received_events_url": "https://api.github.com/users/oschwald/received_events",
"repos_url": "https://api.github.com/users/oschwald/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/oschwald/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oschwald/subscriptions",
"type": "User",
"url": "https://api.github.com/users/oschwald",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2016-12-08T02:01:25Z | 2021-09-08T13:05:41Z | 2016-12-09T17:17:48Z | NONE | resolved | Previously, it was possible to set `auth` to something like `(42,'password')`. This has worked fine since before requests hit 1.0. 2.12.2, a patch release, broke this, causing failures such as the ones seen in this [Travis build](https://travis-ci.org/maxmind/GeoIP2-python/jobs/181427000).
I am not saying the new behavior is incorrect, but this is a breaking change.
This is similar but not the same as #3750, #3736, and #3751. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3753/reactions"
} | https://api.github.com/repos/psf/requests/issues/3753/timeline | null | completed | null | null | false | [
"This is different to the other three issues. Those three issues are all passing `None` type to `auth()` - You're passing an `int` object instead.\r\n\r\nIt would appear that they were all caused by 329a5cf though. \r\n\r\nWhat decisions those that maintain requests want to make is up to them though, just thought I... |
https://api.github.com/repos/psf/requests/issues/3752 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3752/labels{/name} | https://api.github.com/repos/psf/requests/issues/3752/comments | https://api.github.com/repos/psf/requests/issues/3752/events | https://github.com/psf/requests/issues/3752 | 194,161,171 | MDU6SXNzdWUxOTQxNjExNzE= | 3,752 | https:// does not work with Python 3.6 | {
"avatar_url": "https://avatars.githubusercontent.com/u/157597?v=4",
"events_url": "https://api.github.com/users/juokaz/events{/privacy}",
"followers_url": "https://api.github.com/users/juokaz/followers",
"following_url": "https://api.github.com/users/juokaz/following{/other_user}",
"gists_url": "https://api.github.com/users/juokaz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/juokaz",
"id": 157597,
"login": "juokaz",
"node_id": "MDQ6VXNlcjE1NzU5Nw==",
"organizations_url": "https://api.github.com/users/juokaz/orgs",
"received_events_url": "https://api.github.com/users/juokaz/received_events",
"repos_url": "https://api.github.com/users/juokaz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/juokaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/juokaz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/juokaz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 16 | 2016-12-07T20:32:44Z | 2021-09-08T01:21:11Z | 2016-12-07T21:14:42Z | NONE | resolved | When requesting a https:// url, `request` method falls into an infinite recursion.
The issue is this method in `python/ssl.py`.
```
@options.setter
def options(self, value):
super(SSLContext, SSLContext).options.__set__(self, value)
```
The commit which introduced this line to python is this https://hg.python.org/cpython/rev/c32e9f9b00f7.
The actual error looks like this:
```
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 501, in get
return self.request('GET', url, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 488, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 609, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 423, in send
timeout=timeout
File "/usr/local/lib/python3.6/site-packages/requests/packages/urllib3/connectionpool.py", line 594, in urlopen
chunked=chunked)
File "/usr/local/lib/python3.6/site-packages/requests/packages/urllib3/connectionpool.py", line 350, in _make_request
self._validate_conn(conn)
File "/usr/local/lib/python3.6/site-packages/requests/packages/urllib3/connectionpool.py", line 835, in _validate_conn
conn.connect()
File "/usr/local/lib/python3.6/site-packages/requests/packages/urllib3/connection.py", line 311, in connect
cert_reqs=resolve_cert_reqs(self.cert_reqs),
File "/usr/local/lib/python3.6/site-packages/requests/packages/urllib3/util/ssl_.py", line 264, in create_urllib3_context
context.options |= options
File "/usr/local/lib/python3.6/ssl.py", line 459, in options
super(SSLContext, SSLContext).options.__set__(self, value)
File "/usr/local/lib/python3.6/ssl.py", line 459, in options
super(SSLContext, SSLContext).options.__set__(self, value)
File "/usr/local/lib/python3.6/ssl.py", line 459, in options
super(SSLContext, SSLContext).options.__set__(self, value)
[Previous line repeated 316 more times]
RecursionError: maximum recursion depth exceeded while calling a Python object
```
Tested using `python 3.6.0b4`. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3752/reactions"
} | https://api.github.com/repos/psf/requests/issues/3752/timeline | null | completed | null | null | false | [
"This sounds like this is a bug in the standard library, actually: it seems like they introduced an infinite recursion when setting options directly. @tiran?",
"I can't reproduce the issue on my machine (Python from latest hg 3.6 branch)\r\n\r\n```\r\n$ ./python \r\nPython 3.6.0+ (3.6:c4f39b6f3176, Dec 7 2016, 2... |
https://api.github.com/repos/psf/requests/issues/3751 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3751/labels{/name} | https://api.github.com/repos/psf/requests/issues/3751/comments | https://api.github.com/repos/psf/requests/issues/3751/events | https://github.com/psf/requests/issues/3751 | 193,807,907 | MDU6SXNzdWUxOTM4MDc5MDc= | 3,751 | Error Auth Basic (since 2.12.2) | {
"avatar_url": "https://avatars.githubusercontent.com/u/5459596?v=4",
"events_url": "https://api.github.com/users/johaven/events{/privacy}",
"followers_url": "https://api.github.com/users/johaven/followers",
"following_url": "https://api.github.com/users/johaven/following{/other_user}",
"gists_url": "https://api.github.com/users/johaven/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/johaven",
"id": 5459596,
"login": "johaven",
"node_id": "MDQ6VXNlcjU0NTk1OTY=",
"organizations_url": "https://api.github.com/users/johaven/orgs",
"received_events_url": "https://api.github.com/users/johaven/received_events",
"repos_url": "https://api.github.com/users/johaven/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/johaven/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/johaven/subscriptions",
"type": "User",
"url": "https://api.github.com/users/johaven",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-12-06T15:50:46Z | 2021-09-08T13:05:42Z | 2016-12-06T15:59:20Z | NONE | resolved | This error appears since last version (my code works with 2.11, 2.9 etc...)
```python
File "C:\Users\vqmg0203\Desktop\app\core\models\database.py", line 211, in update_infos
r = self.request_get(self.user_url)
File "C:\Users\vqmg0203\Desktop\app\core\handlers\http.py", line 30, in wrapped
return f(self, *args, **kwargs)
File "C:\Users\vqmg0203\Desktop\app\core\handlers\http.py", line 130, in request_get
allow_redirects=False)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 501, in get
return self.request('GET', url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 474, in request
prep = self.prepare_request(req)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 407, in prepare_request
hooks=merge_hooks(request.hooks, self.hooks),
File "C:\Python27\lib\site-packages\requests\models.py", line 306, in prepare
self.prepare_auth(auth, url)
File "C:\Python27\lib\site-packages\requests\models.py", line 527, in prepare_auth
r = auth(self)
File "C:\Python27\lib\site-packages\requests\auth.py", line 68, in __call__
r.headers['Authorization'] = _basic_auth_str(self.username, self.password)
File "C:\Python27\lib\site-packages\requests\auth.py", line 38, in _basic_auth_str
b64encode(b':'.join((username, password))).strip()
TypeError: sequence item 1: expected string, NoneType found
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3751/reactions"
} | https://api.github.com/repos/psf/requests/issues/3751/timeline | null | completed | null | null | false | [
"You cannot pass `None` as an entry to basic auth. This never worked sensibly: we ended up just putting the literal string `\"None\"` into the basic auth header.",
"In the future, please search **closed and** open issues before creating new ones that are duplicates.\r\n\r\nThis is a duplicate of **two** other iss... |
https://api.github.com/repos/psf/requests/issues/3750 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3750/labels{/name} | https://api.github.com/repos/psf/requests/issues/3750/comments | https://api.github.com/repos/psf/requests/issues/3750/events | https://github.com/psf/requests/issues/3750 | 193,507,656 | MDU6SXNzdWUxOTM1MDc2NTY= | 3,750 | Basic Auth broken when username / password is None | {
"avatar_url": "https://avatars.githubusercontent.com/u/209263?v=4",
"events_url": "https://api.github.com/users/kirichkov/events{/privacy}",
"followers_url": "https://api.github.com/users/kirichkov/followers",
"following_url": "https://api.github.com/users/kirichkov/following{/other_user}",
"gists_url": "https://api.github.com/users/kirichkov/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kirichkov",
"id": 209263,
"login": "kirichkov",
"node_id": "MDQ6VXNlcjIwOTI2Mw==",
"organizations_url": "https://api.github.com/users/kirichkov/orgs",
"received_events_url": "https://api.github.com/users/kirichkov/received_events",
"repos_url": "https://api.github.com/users/kirichkov/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kirichkov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kirichkov/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kirichkov",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-12-05T14:15:25Z | 2021-09-08T13:05:44Z | 2016-12-05T14:24:38Z | NONE | resolved | It appears commit 329a5cfdd4500fb1ce405a3242ef95f9197d24ba has broken `_basic_auth_str` and it now throws an exception `TypeError` (see below) when the supplied username and password is `None`.
Befor this commit, in requests 2.1.1, it was possible to supply None values for username and password when authentication is optional - in this particular case Home Assistant writing to InfluxDB with default configuration.
Exception thrown:
```python
TypeError: sequence item 0: expected a bytes-like object, NoneType found
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3750/reactions"
} | https://api.github.com/repos/psf/requests/issues/3750/timeline | null | completed | null | null | false | [
"This is a duplicate of #3736",
"In the future, please search closed and open issues before creating new ones that are duplicates.",
"Sorry. I looked at the open tickets only!"
] |
https://api.github.com/repos/psf/requests/issues/3749 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3749/labels{/name} | https://api.github.com/repos/psf/requests/issues/3749/comments | https://api.github.com/repos/psf/requests/issues/3749/events | https://github.com/psf/requests/issues/3749 | 193,342,323 | MDU6SXNzdWUxOTMzNDIzMjM= | 3,749 | cmd | {
"avatar_url": "https://avatars.githubusercontent.com/u/12379211?v=4",
"events_url": "https://api.github.com/users/FlyToTomorrow/events{/privacy}",
"followers_url": "https://api.github.com/users/FlyToTomorrow/followers",
"following_url": "https://api.github.com/users/FlyToTomorrow/following{/other_user}",
"gists_url": "https://api.github.com/users/FlyToTomorrow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/FlyToTomorrow",
"id": 12379211,
"login": "FlyToTomorrow",
"node_id": "MDQ6VXNlcjEyMzc5MjEx",
"organizations_url": "https://api.github.com/users/FlyToTomorrow/orgs",
"received_events_url": "https://api.github.com/users/FlyToTomorrow/received_events",
"repos_url": "https://api.github.com/users/FlyToTomorrow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/FlyToTomorrow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FlyToTomorrow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/FlyToTomorrow",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-12-04T09:55:51Z | 2021-09-08T13:05:45Z | 2016-12-04T09:56:21Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/12379211?v=4",
"events_url": "https://api.github.com/users/FlyToTomorrow/events{/privacy}",
"followers_url": "https://api.github.com/users/FlyToTomorrow/followers",
"following_url": "https://api.github.com/users/FlyToTomorrow/following{/other_user}",
"gists_url": "https://api.github.com/users/FlyToTomorrow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/FlyToTomorrow",
"id": 12379211,
"login": "FlyToTomorrow",
"node_id": "MDQ6VXNlcjEyMzc5MjEx",
"organizations_url": "https://api.github.com/users/FlyToTomorrow/orgs",
"received_events_url": "https://api.github.com/users/FlyToTomorrow/received_events",
"repos_url": "https://api.github.com/users/FlyToTomorrow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/FlyToTomorrow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FlyToTomorrow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/FlyToTomorrow",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3749/reactions"
} | https://api.github.com/repos/psf/requests/issues/3749/timeline | null | completed | null | null | false | [] | |
https://api.github.com/repos/psf/requests/issues/3748 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3748/labels{/name} | https://api.github.com/repos/psf/requests/issues/3748/comments | https://api.github.com/repos/psf/requests/issues/3748/events | https://github.com/psf/requests/issues/3748 | 193,300,851 | MDU6SXNzdWUxOTMzMDA4NTE= | 3,748 | requests get(URL) never returns, even with Proxy! | {
"avatar_url": "https://avatars.githubusercontent.com/u/18625267?v=4",
"events_url": "https://api.github.com/users/arunchandramouli/events{/privacy}",
"followers_url": "https://api.github.com/users/arunchandramouli/followers",
"following_url": "https://api.github.com/users/arunchandramouli/following{/other_user}",
"gists_url": "https://api.github.com/users/arunchandramouli/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/arunchandramouli",
"id": 18625267,
"login": "arunchandramouli",
"node_id": "MDQ6VXNlcjE4NjI1MjY3",
"organizations_url": "https://api.github.com/users/arunchandramouli/orgs",
"received_events_url": "https://api.github.com/users/arunchandramouli/received_events",
"repos_url": "https://api.github.com/users/arunchandramouli/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/arunchandramouli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arunchandramouli/subscriptions",
"type": "User",
"url": "https://api.github.com/users/arunchandramouli",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 37 | 2016-12-03T16:59:31Z | 2016-12-05T14:34:26Z | 2016-12-03T20:36:49Z | NONE | null | 99% of the times I use .get() i get responses in ms... but there are certain URLs that I work on, both http and https, they are available globally too(but can't be shared for some reason). What I found is that some of these .get() never actually returns a value instead .get() command never ends, it keeps running infinitely. What could be the reason?Is there any alternate, such as using Proxy or anything as such? Please suggest. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3748/reactions"
} | https://api.github.com/repos/psf/requests/issues/3748/timeline | null | completed | null | null | false | [
"@arunchandramouli have you considered setting a `timeout`?\r\n\r\nBeyond that, I'd advise you to not ask questions on a defect (issue) tracker. Instead, ask questions on [StackOverflow](stackoverflow.com).",
"Yes I did timeout and it returns as 403/404 but not 200. I did see through SO, but didnt get similar qu... |
https://api.github.com/repos/psf/requests/issues/3747 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3747/labels{/name} | https://api.github.com/repos/psf/requests/issues/3747/comments | https://api.github.com/repos/psf/requests/issues/3747/events | https://github.com/psf/requests/issues/3747 | 193,232,667 | MDU6SXNzdWUxOTMyMzI2Njc= | 3,747 | Max_redirect = 0; Location header missing | {
"avatar_url": "https://avatars.githubusercontent.com/u/13772695?v=4",
"events_url": "https://api.github.com/users/arao-nnl/events{/privacy}",
"followers_url": "https://api.github.com/users/arao-nnl/followers",
"following_url": "https://api.github.com/users/arao-nnl/following{/other_user}",
"gists_url": "https://api.github.com/users/arao-nnl/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/arao-nnl",
"id": 13772695,
"login": "arao-nnl",
"node_id": "MDQ6VXNlcjEzNzcyNjk1",
"organizations_url": "https://api.github.com/users/arao-nnl/orgs",
"received_events_url": "https://api.github.com/users/arao-nnl/received_events",
"repos_url": "https://api.github.com/users/arao-nnl/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/arao-nnl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arao-nnl/subscriptions",
"type": "User",
"url": "https://api.github.com/users/arao-nnl",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-12-02T22:24:29Z | 2021-09-08T13:05:46Z | 2016-12-02T22:40:06Z | NONE | resolved | Hi,
Requests ver: 2.11.1
I'm using a session object (s) to make a POST to a specific URL:
r=s.send(prepared)
I expect this to return 302, which is happening.
I set s.max_redirects=0 because I don't want Requests to automatically visit the new URL.
So, I promptly receive a TooManyRedirects exception, which is good.
However, in the exception handler, I'm unable to get hold of the header 'Location'.
The response object itself is empty.
I debugged it and saw that the Location header was captured correctly. But, when the exception is thrown, it's all gone.
(Pdb) n
> /Library/Python/2.7/site-packages/requests/adapters.py(275)build_response()
-> return response
(Pdb) response
<Response [302]>
(Pdb) response.__dict__
{'cookies': <RequestsCookieJar[]>, '_content': False, 'headers': {'Date': 'Fri, 02 Dec 2016 22:27:44 GMT', 'Content-Length': '0', 'Location': 'http://XXX:8080/openam?goto=https:YYY', 'Server': 'Apache-Coyote/1.1'}, 'url': u'https://XXX:8443/proxyplus/nnl/reg', 'status_code': 302, '_content_consumed': False, 'encoding': None, 'request': <PreparedRequest [POST]>, 'connection': <requests.adapters.HTTPAdapter object at 0x1053ae1d0>, 'elapsed': datetime.timedelta(0), 'raw': <requests.packages.urllib3.response.HTTPResponse object at 0x1055e3550>, 'reason': 'Found', 'history': []}
As you can see, 'Location' is found at this stage in 'response', but when the exception is thrown, response becomes empty.
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/13772695?v=4",
"events_url": "https://api.github.com/users/arao-nnl/events{/privacy}",
"followers_url": "https://api.github.com/users/arao-nnl/followers",
"following_url": "https://api.github.com/users/arao-nnl/following{/other_user}",
"gists_url": "https://api.github.com/users/arao-nnl/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/arao-nnl",
"id": 13772695,
"login": "arao-nnl",
"node_id": "MDQ6VXNlcjEzNzcyNjk1",
"organizations_url": "https://api.github.com/users/arao-nnl/orgs",
"received_events_url": "https://api.github.com/users/arao-nnl/received_events",
"repos_url": "https://api.github.com/users/arao-nnl/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/arao-nnl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arao-nnl/subscriptions",
"type": "User",
"url": "https://api.github.com/users/arao-nnl",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3747/reactions"
} | https://api.github.com/repos/psf/requests/issues/3747/timeline | null | completed | null | null | false | [
"Hey @arao-nnl, in order to get the behaviour you're looking for, you'll need to use a slightly different mechanism. `max_redirects` is intended to raise an exception halting the request in the event of a redirection loop, or excessive redirects.\r\n\r\nFor your issue of trying to simply halt before a redirect is p... |
https://api.github.com/repos/psf/requests/issues/3746 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3746/labels{/name} | https://api.github.com/repos/psf/requests/issues/3746/comments | https://api.github.com/repos/psf/requests/issues/3746/events | https://github.com/psf/requests/issues/3746 | 193,200,053 | MDU6SXNzdWUxOTMyMDAwNTM= | 3,746 | No tests being run in CI against new pull requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/301220?v=4",
"events_url": "https://api.github.com/users/alexwlchan/events{/privacy}",
"followers_url": "https://api.github.com/users/alexwlchan/followers",
"following_url": "https://api.github.com/users/alexwlchan/following{/other_user}",
"gists_url": "https://api.github.com/users/alexwlchan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexwlchan",
"id": 301220,
"login": "alexwlchan",
"node_id": "MDQ6VXNlcjMwMTIyMA==",
"organizations_url": "https://api.github.com/users/alexwlchan/orgs",
"received_events_url": "https://api.github.com/users/alexwlchan/received_events",
"repos_url": "https://api.github.com/users/alexwlchan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexwlchan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexwlchan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexwlchan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-12-02T19:39:02Z | 2021-09-08T13:05:46Z | 2016-12-02T19:39:54Z | CONTRIBUTOR | resolved | It looks like there aren’t any tests being run in CI against pull requests, so there’s a bit of extra work for reviewers to get the patch locally and run the tests themselves. And running tests locally is more susceptible to environment-specific test quirks.
It looks like there used to be CI on older pull requests from <http://ci.kennethreitz.org>, but that seems to be unresponsive now. 😢
Would you be interested in a patch that adds some config for Travis CI (and/or another CI service of your choice)? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3746/reactions"
} | https://api.github.com/repos/psf/requests/issues/3746/timeline | null | completed | null | null | false | [
"Sorry Alex, but this happens to all of us:\r\n\r\nClosing as a dupe of #3739.",
"And not even an old issue either! Wow, I’m really not with it today.",
":wink: We all have off days, nothing to be worried about there. Just thought it was funny."
] |
https://api.github.com/repos/psf/requests/issues/3745 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3745/labels{/name} | https://api.github.com/repos/psf/requests/issues/3745/comments | https://api.github.com/repos/psf/requests/issues/3745/events | https://github.com/psf/requests/pull/3745 | 193,198,520 | MDExOlB1bGxSZXF1ZXN0OTYzMzg2MjE= | 3,745 | Rebase #2431 against proposed/3.0.0 | {
"avatar_url": "https://avatars.githubusercontent.com/u/301220?v=4",
"events_url": "https://api.github.com/users/alexwlchan/events{/privacy}",
"followers_url": "https://api.github.com/users/alexwlchan/followers",
"following_url": "https://api.github.com/users/alexwlchan/following{/other_user}",
"gists_url": "https://api.github.com/users/alexwlchan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexwlchan",
"id": 301220,
"login": "alexwlchan",
"node_id": "MDQ6VXNlcjMwMTIyMA==",
"organizations_url": "https://api.github.com/users/alexwlchan/orgs",
"received_events_url": "https://api.github.com/users/alexwlchan/received_events",
"repos_url": "https://api.github.com/users/alexwlchan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexwlchan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexwlchan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexwlchan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-12-02T19:31:54Z | 2021-09-07T00:06:38Z | 2017-02-10T17:11:37Z | CONTRIBUTOR | resolved | This is really quite unexciting: #2431 had a tentative +1 from @Lukasa, pending a rebase and retargeting against 3.0.0, but it’s been sat unloved for nearly eight months. 😢
This patch does the required rebase and targets the 3.0.0 branch. | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3745/reactions"
} | https://api.github.com/repos/psf/requests/issues/3745/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3745.diff",
"html_url": "https://github.com/psf/requests/pull/3745",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3745.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3745"
} | true | [
"Woah, zombie PR back from the dead! I haven't worked in Python for over a year now, but I'll see if I can address the suggestions this weekend.",
"I had a go at addressing the review markups, but I feel like more testing is required.\r\n\r\nI feel like there’s enough subtle behaviour here that we’d be better of... |
https://api.github.com/repos/psf/requests/issues/3744 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3744/labels{/name} | https://api.github.com/repos/psf/requests/issues/3744/comments | https://api.github.com/repos/psf/requests/issues/3744/events | https://github.com/psf/requests/issues/3744 | 193,035,285 | MDU6SXNzdWUxOTMwMzUyODU= | 3,744 | python requests post mp3 and data error | {
"avatar_url": "https://avatars.githubusercontent.com/u/11746057?v=4",
"events_url": "https://api.github.com/users/467754239/events{/privacy}",
"followers_url": "https://api.github.com/users/467754239/followers",
"following_url": "https://api.github.com/users/467754239/following{/other_user}",
"gists_url": "https://api.github.com/users/467754239/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/467754239",
"id": 11746057,
"login": "467754239",
"node_id": "MDQ6VXNlcjExNzQ2MDU3",
"organizations_url": "https://api.github.com/users/467754239/orgs",
"received_events_url": "https://api.github.com/users/467754239/received_events",
"repos_url": "https://api.github.com/users/467754239/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/467754239/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/467754239/subscriptions",
"type": "User",
"url": "https://api.github.com/users/467754239",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-12-02T05:05:12Z | 2021-09-08T13:05:46Z | 2016-12-02T08:28:09Z | NONE | resolved | #### coding
```python
url = ""
data = {'uuid':'-jx-1', 'alarmType':1, 'timeDuration':10}
headers = {'Content-type': 'multipart/form-data'}
mp3_fd = open('/home/ec2-user/voice/123.mp3', 'rb')
files = {'messageFile': mp3_fd}
req = requests.post(url, files=files, json=data, headers=headers)
print req.status_code
print req.content
```
### error
```
500
<html><head><title>Apache Tomcat/6.0.43 - Error report</title><style><!--H1 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;} H2 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:16px;} H3 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;} BODY {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;} B {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;} P {font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}A {color : black;}A.name {color : black;}HR {color : #525D76;}--></style> </head><body><h1>HTTP Status 500 - Request processing failed; nested exception is org.springframework.web.multipart.MultipartException: Could not parse multipart servlet request; nested exception is org.apache.commons.fileupload.FileUploadException: the request was rejected because no multipart boundary was found</h1><HR size="1" noshade="noshade"><p><b>type</b> Exception report</p><p><b>message</b> <u>Request processing failed; nested exception is org.springframework.web.multipart.MultipartException: Could not parse multipart servlet request; nested exception is org.apache.commons.fileupload.FileUploadException: the request was rejected because no multipart boundary was found</u></p><p><b>description</b> <u>The server encountered an internal error that prevented it from fulfilling this request.</u></p><p><b>exception</b> <pre>org.springframework.web.util.NestedServletException: Request processing failed; nested exception is org.springframework.web.multipart.MultipartException: Could not parse multipart servlet request; nested exception is org.apache.commons.fileupload.FileUploadException: the request was rejected because no multipart boundary was found
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:979)
org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:869)
javax.servlet.http.HttpServlet.service(HttpServlet.java:643)
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:843)
javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
com.sengled.cloud.voice.common.filter.CheckLoginStatusFilter.doFilter(CheckLoginStatusFilter.java:54)
com.sengled.cloud.voice.common.filter.EncodingFilter.doFilter(EncodingFilter.java:56)
</pre></p><p><b>root cause</b> <pre>org.springframework.web.multipart.MultipartException: Could not parse multipart servlet request; nested exception is org.apache.commons.fileupload.FileUploadException: the request was rejected because no multipart boundary was found
org.springframework.web.multipart.commons.CommonsMultipartResolver.parseRequest(CommonsMultipartResolver.java:165)
org.springframework.web.multipart.commons.CommonsMultipartResolver.resolveMultipart(CommonsMultipartResolver.java:142)
org.springframework.web.servlet.DispatcherServlet.checkMultipart(DispatcherServlet.java:1089)
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:928)
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:893)
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:967)
org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:869)
javax.servlet.http.HttpServlet.service(HttpServlet.java:643)
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:843)
javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
com.sengled.cloud.voice.common.filter.CheckLoginStatusFilter.doFilter(CheckLoginStatusFilter.java:54)
com.sengled.cloud.voice.common.filter.EncodingFilter.doFilter(EncodingFilter.java:56)
</pre></p><p><b>root cause</b> <pre>org.apache.commons.fileupload.FileUploadException: the request was rejected because no multipart boundary was found
org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl.<init>(FileUploadBase.java:954)
org.apache.commons.fileupload.FileUploadBase.getItemIterator(FileUploadBase.java:331)
org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:351)
org.apache.commons.fileupload.servlet.ServletFileUpload.parseRequest(ServletFileUpload.java:126)
org.springframework.web.multipart.commons.CommonsMultipartResolver.parseRequest(CommonsMultipartResolver.java:158)
org.springframework.web.multipart.commons.CommonsMultipartResolver.resolveMultipart(CommonsMultipartResolver.java:142)
org.springframework.web.servlet.DispatcherServlet.checkMultipart(DispatcherServlet.java:1089)
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:928)
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:893)
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:967)
org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:869)
javax.servlet.http.HttpServlet.service(HttpServlet.java:643)
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:843)
javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
com.sengled.cloud.voice.common.filter.CheckLoginStatusFilter.doFilter(CheckLoginStatusFilter.java:54)
com.sengled.cloud.voice.common.filter.EncodingFilter.doFilter(EncodingFilter.java:56)
</pre></p><p><b>note</b> <u>The full stack trace of the root cause is available in the Apache Tomcat/6.0.43 logs.</u></p><HR size="1" noshade="noshade"><h3>Apache Tomcat/6.0.43</h3></body></html>
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3744/reactions"
} | https://api.github.com/repos/psf/requests/issues/3744/timeline | null | completed | null | null | false | [
"Please don't set the `Content-Type` header. You set it incorrectly, which is what broke your server. If you remove `headers=headers` from your command, you'll find it works."
] |
https://api.github.com/repos/psf/requests/issues/3743 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3743/labels{/name} | https://api.github.com/repos/psf/requests/issues/3743/comments | https://api.github.com/repos/psf/requests/issues/3743/events | https://github.com/psf/requests/issues/3743 | 192,977,428 | MDU6SXNzdWUxOTI5Nzc0Mjg= | 3,743 | Requests won't follow some redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/2000204?v=4",
"events_url": "https://api.github.com/users/timothyjlaurent/events{/privacy}",
"followers_url": "https://api.github.com/users/timothyjlaurent/followers",
"following_url": "https://api.github.com/users/timothyjlaurent/following{/other_user}",
"gists_url": "https://api.github.com/users/timothyjlaurent/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/timothyjlaurent",
"id": 2000204,
"login": "timothyjlaurent",
"node_id": "MDQ6VXNlcjIwMDAyMDQ=",
"organizations_url": "https://api.github.com/users/timothyjlaurent/orgs",
"received_events_url": "https://api.github.com/users/timothyjlaurent/received_events",
"repos_url": "https://api.github.com/users/timothyjlaurent/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/timothyjlaurent/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timothyjlaurent/subscriptions",
"type": "User",
"url": "https://api.github.com/users/timothyjlaurent",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-12-01T22:13:37Z | 2021-09-08T13:05:47Z | 2016-12-02T00:49:55Z | NONE | resolved | for example:
```
requests.get('http://archopht.jamanetwork.com/article.aspx?doi=10.1001/archopht.125.1.128')
```
Won't work ^
however you can do it with urllib, urllib2
```
urllib2.urlopen('http://archopht.jamanetwork.com/article.aspx?doi=10.1001/archopht.125.1.128')
```
or with urllib3
```
http = urllib3.PoolManager()
http.request('GET', 'http://archopht.jamanetwork.com/article.aspx?doi=10.1001/archopht.125.1.128')
```
Is there any way to accomplish this with requests? | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3743/reactions"
} | https://api.github.com/repos/psf/requests/issues/3743/timeline | null | completed | null | null | false | [
"Hey @timothyjlaurent, the issue you're hitting is with the server rather than Requests. It looks like the base domain jamanetwork.com (where the redirect points you) may not want it crawled. The server has blacklisted any request with a User-Agent containing the word \"python\" or \"curl\".\r\n\r\nGiven their robo... |
https://api.github.com/repos/psf/requests/issues/3742 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3742/labels{/name} | https://api.github.com/repos/psf/requests/issues/3742/comments | https://api.github.com/repos/psf/requests/issues/3742/events | https://github.com/psf/requests/issues/3742 | 192,808,018 | MDU6SXNzdWUxOTI4MDgwMTg= | 3,742 | Problems with requests version 2.12 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1842780?v=4",
"events_url": "https://api.github.com/users/megies/events{/privacy}",
"followers_url": "https://api.github.com/users/megies/followers",
"following_url": "https://api.github.com/users/megies/following{/other_user}",
"gists_url": "https://api.github.com/users/megies/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/megies",
"id": 1842780,
"login": "megies",
"node_id": "MDQ6VXNlcjE4NDI3ODA=",
"organizations_url": "https://api.github.com/users/megies/orgs",
"received_events_url": "https://api.github.com/users/megies/received_events",
"repos_url": "https://api.github.com/users/megies/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/megies/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/megies/subscriptions",
"type": "User",
"url": "https://api.github.com/users/megies",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 20 | 2016-12-01T10:33:54Z | 2021-09-08T13:05:43Z | 2016-12-06T09:06:28Z | NONE | resolved | We're currently seeing problems with requests version 2.12.0 and 2.12.1, see obspy/obspy#1599.
I don't have much time to investigate right now, unfortunately, but wanted to quickly report this here.
This might be an interaction with `future` package, as we are using it for Python 2/3 compatibility.
Steps to reproduce with anaconda:
```bash
$ conda create -n requests_bug python=2.7 requests=2.12.1 obspy
$ source activate requests_bug
$ obspy-runtests core
```
```
Traceback (most recent call last):
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/obspy/core/tests/test_stream.py", line 1720, in test_read
tr = read('https://examples.obspy.org/test.sac', dtype=np.int32)[0]
File "<decorator-gen-31>", line 2, in read
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/obspy/core/util/decorator.py", line 294, in _map_example_filename
return func(*args, **kwargs)
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/obspy/core/stream.py", line 225, in read
download_to_file(url=pathname_or_url, filename_or_buffer=fh)
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/obspy/core/util/base.py", line 602, in download_to_file
r = requests.get(url, stream=True)
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/api.py", line 70, in get
return request('get', url, params=params, **kwargs)
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/api.py", line 56, in request
return session.request(method=method, url=url, **kwargs)
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/sessions.py", line 369, in __exit__
self.close()
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/sessions.py", line 690, in close
v.close()
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/adapters.py", line 306, in close
self.poolmanager.clear()
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/packages/urllib3/poolmanager.py", line 156, in clear
self.pools.clear()
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/packages/urllib3/_collections.py", line 94, in clear
self.dispose_func(value)
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/packages/urllib3/poolmanager.py", line 117, in <lambda>
dispose_func=lambda p: p.close())
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 423, in close
conn = old_pool.get(block=False)
File "/home/travis/miniconda/envs/test-environment/lib/python2.7/Queue.py", line 165, in get
raise Empty
Empty
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3742/reactions"
} | https://api.github.com/repos/psf/requests/issues/3742/timeline | null | completed | null | null | false | [
"Can you check #2935, and in particular the solution linked by the solver of that issue [here](https://github.com/kennethreitz/requests/issues/2935)?",
"The debugging like described [here](http://kronuz.io/nasty-bugs-crawling-in-some-python-libraries.html) indeed works, however if I do it, I don't get any excepti... |
https://api.github.com/repos/psf/requests/issues/3741 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3741/labels{/name} | https://api.github.com/repos/psf/requests/issues/3741/comments | https://api.github.com/repos/psf/requests/issues/3741/events | https://github.com/psf/requests/issues/3741 | 192,753,445 | MDU6SXNzdWUxOTI3NTM0NDU= | 3,741 | The new 2.12.2 breaks certain docker-py's build's argument | {
"avatar_url": "https://avatars.githubusercontent.com/u/463631?v=4",
"events_url": "https://api.github.com/users/huikang/events{/privacy}",
"followers_url": "https://api.github.com/users/huikang/followers",
"following_url": "https://api.github.com/users/huikang/following{/other_user}",
"gists_url": "https://api.github.com/users/huikang/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/huikang",
"id": 463631,
"login": "huikang",
"node_id": "MDQ6VXNlcjQ2MzYzMQ==",
"organizations_url": "https://api.github.com/users/huikang/orgs",
"received_events_url": "https://api.github.com/users/huikang/received_events",
"repos_url": "https://api.github.com/users/huikang/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/huikang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huikang/subscriptions",
"type": "User",
"url": "https://api.github.com/users/huikang",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-12-01T04:44:36Z | 2021-09-08T14:00:24Z | 2016-12-01T08:08:37Z | NONE | resolved | see the issue in https://github.com/docker/docker-py/issues/1325, although I am not sure this is a right place to post. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3741/reactions"
} | https://api.github.com/repos/psf/requests/issues/3741/timeline | null | completed | null | null | false | [
"As per #3734 this is already getting worked on. The relevant issue to follow in Requests is #3735 \r\n\r\nAlso - If you had locked in docker/docker-py you'd see that they had already been talking about this over there in [docker/docker-py/#1321](https://github.com/docker/docker-py/issues/1321)",
"Yup, this is a ... |
https://api.github.com/repos/psf/requests/issues/3740 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3740/labels{/name} | https://api.github.com/repos/psf/requests/issues/3740/comments | https://api.github.com/repos/psf/requests/issues/3740/events | https://github.com/psf/requests/issues/3740 | 192,747,179 | MDU6SXNzdWUxOTI3NDcxNzk= | 3,740 | File download weirdness | {
"avatar_url": "https://avatars.githubusercontent.com/u/10678620?v=4",
"events_url": "https://api.github.com/users/groutr/events{/privacy}",
"followers_url": "https://api.github.com/users/groutr/followers",
"following_url": "https://api.github.com/users/groutr/following{/other_user}",
"gists_url": "https://api.github.com/users/groutr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/groutr",
"id": 10678620,
"login": "groutr",
"node_id": "MDQ6VXNlcjEwNjc4NjIw",
"organizations_url": "https://api.github.com/users/groutr/orgs",
"received_events_url": "https://api.github.com/users/groutr/received_events",
"repos_url": "https://api.github.com/users/groutr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/groutr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/groutr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/groutr",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-12-01T03:40:04Z | 2021-09-08T13:05:47Z | 2016-12-01T15:05:30Z | NONE | resolved | I noticed this issue building conda recipes. Conda uses requests to download files from the internet.
The file that is being fetched is: https://dakota.sandia.gov/sites/default/files/distributions/public/dakota-6.5-public.src.tar.gz
(link found here: https://dakota.sandia.gov/download.html)
Downloading with curl -O
filesize: 78MB
md5: 02c46e904d40bba6b308065db34c1ad7
Downloading with urllib2 (from the standard library):
filesize: 78MB
md5: 02c46e904d40bba6b308065db34c1ad7
Downloading with requests-2.12.1 (supplied with conda)
filesize: 248MB
md5: 41e4268140d850756812510512d8eee8
tar -tf doesn't indicate any corruption.
I'm not sure what is different with this particular URL, but the other files I tried with requests worked. I don't know where the extra 170MB is coming from?
code used to download files:
```python
def download_file(url, fn):
r = requests.get(url, stream=True)
with open(fn, 'wb') as f:
for chunk in r.iter_content(chunk_size=1024):
if chunk:
f.write(chunk)
def download_urllib2(url, fn):
f = urllib2.urlopen(url)
with open(fn, 'wb') as fh:
for x in iter(lambda: f.read(1024), b''):
fh.write(x)
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3740/reactions"
} | https://api.github.com/repos/psf/requests/issues/3740/timeline | null | completed | null | null | false | [
"My best guess is that this is related to compression. Can you print the response headers from curl and from Requests please?",
"curl\r\n```\r\nHTTP/1.1 200 OK\r\nDate: Thu, 01 Dec 2016 14:44:30 GMT\r\nServer: Apache/2.2.15 (Red Hat)\r\nX-Frame-Options: SAMEORIGIN\r\nX-Content-Type-Options: nosniff\r\nLast-Modifi... |
https://api.github.com/repos/psf/requests/issues/3739 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3739/labels{/name} | https://api.github.com/repos/psf/requests/issues/3739/comments | https://api.github.com/repos/psf/requests/issues/3739/events | https://github.com/psf/requests/issues/3739 | 192,697,230 | MDU6SXNzdWUxOTI2OTcyMzA= | 3,739 | Is there a specific reason why there is no CI (Travis/Appveyor)? | {
"avatar_url": "https://avatars.githubusercontent.com/u/263007?v=4",
"events_url": "https://api.github.com/users/obestwalter/events{/privacy}",
"followers_url": "https://api.github.com/users/obestwalter/followers",
"following_url": "https://api.github.com/users/obestwalter/following{/other_user}",
"gists_url": "https://api.github.com/users/obestwalter/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/obestwalter",
"id": 263007,
"login": "obestwalter",
"node_id": "MDQ6VXNlcjI2MzAwNw==",
"organizations_url": "https://api.github.com/users/obestwalter/orgs",
"received_events_url": "https://api.github.com/users/obestwalter/received_events",
"repos_url": "https://api.github.com/users/obestwalter/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/obestwalter/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/obestwalter/subscriptions",
"type": "User",
"url": "https://api.github.com/users/obestwalter",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-11-30T22:22:49Z | 2021-09-08T13:05:48Z | 2016-12-01T13:14:18Z | NONE | resolved | I was surprised to see that requests is not making use of Travis/Appveyor CI. Is there a specific reason for that?
I would be willing to send a PR implementing it, if the only reason is that no one got around to it yet.
I also saw that `tox.ini` is in the .gitignore file - so is tox used locally by some devs but not part of the project? If so: what are the reasons for not having a `tox.ini` as part of the project? I would use tox.ini to integrate the project with the CI systems and also add a convenient way to run the tests on different interpreters. | {
"avatar_url": "https://avatars.githubusercontent.com/u/263007?v=4",
"events_url": "https://api.github.com/users/obestwalter/events{/privacy}",
"followers_url": "https://api.github.com/users/obestwalter/followers",
"following_url": "https://api.github.com/users/obestwalter/following{/other_user}",
"gists_url": "https://api.github.com/users/obestwalter/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/obestwalter",
"id": 263007,
"login": "obestwalter",
"node_id": "MDQ6VXNlcjI2MzAwNw==",
"organizations_url": "https://api.github.com/users/obestwalter/orgs",
"received_events_url": "https://api.github.com/users/obestwalter/received_events",
"repos_url": "https://api.github.com/users/obestwalter/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/obestwalter/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/obestwalter/subscriptions",
"type": "User",
"url": "https://api.github.com/users/obestwalter",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3739/reactions"
} | https://api.github.com/repos/psf/requests/issues/3739/timeline | null | completed | null | null | false | [
"Hey @obestwalter, I talked to @Lukasa about this a few weeks ago. To quote a bit of his response:\r\n\r\n>Requests moved away from Travis because it made a lot of live network requests in its test suite and Travis had frequent network outages that caused real problems with the test run. \r\n\r\nWhile a lot of thes... |
https://api.github.com/repos/psf/requests/issues/3738 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3738/labels{/name} | https://api.github.com/repos/psf/requests/issues/3738/comments | https://api.github.com/repos/psf/requests/issues/3738/events | https://github.com/psf/requests/pull/3738 | 192,682,996 | MDExOlB1bGxSZXF1ZXN0OTU5NzYyNzU= | 3,738 | Revert "Restrict URL preparation to HTTP/HTTPS" | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 27 | 2016-11-30T21:22:10Z | 2021-09-08T01:21:27Z | 2016-12-01T10:45:25Z | MEMBER | resolved | This reverts commit 34af72c87d79bd8852e8564c050dd7711c6a08d6.
This commit was added by @tiran to try to avoid the IDNA-encoding logic that we added in v2.12.0. I believe that the *other* workarounds we merged for that are sufficient, and this change broke docker-py and probably broke others.
@tiran, can you confirm that your code continues to function with this change reverted? I'd like to be able to merge this and ship a v2.12.3 if at all possible.
Resolves #3735. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3738/reactions"
} | https://api.github.com/repos/psf/requests/issues/3738/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3738.diff",
"html_url": "https://github.com/psf/requests/pull/3738",
"merged_at": "2016-12-01T10:45:25Z",
"patch_url": "https://github.com/psf/requests/pull/3738.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3738"
} | true | [
"@Lukasa, I think it would be beneficial readding the test after this reversion. It still provides a useful check going forward and will pass regardless of the tightened scheme check.",
"Heh, I just noticed that that test never actually tested the relevant function. WHAT IDIOT REVIEWED THIS CODE THE LAST TIME? :w... |
https://api.github.com/repos/psf/requests/issues/3737 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3737/labels{/name} | https://api.github.com/repos/psf/requests/issues/3737/comments | https://api.github.com/repos/psf/requests/issues/3737/events | https://github.com/psf/requests/issues/3737 | 192,639,786 | MDU6SXNzdWUxOTI2Mzk3ODY= | 3,737 | Requests 2.12.2 and PyInstaller not compatible? | {
"avatar_url": "https://avatars.githubusercontent.com/u/19777948?v=4",
"events_url": "https://api.github.com/users/b0g3r/events{/privacy}",
"followers_url": "https://api.github.com/users/b0g3r/followers",
"following_url": "https://api.github.com/users/b0g3r/following{/other_user}",
"gists_url": "https://api.github.com/users/b0g3r/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/b0g3r",
"id": 19777948,
"login": "b0g3r",
"node_id": "MDQ6VXNlcjE5Nzc3OTQ4",
"organizations_url": "https://api.github.com/users/b0g3r/orgs",
"received_events_url": "https://api.github.com/users/b0g3r/received_events",
"repos_url": "https://api.github.com/users/b0g3r/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/b0g3r/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/b0g3r/subscriptions",
"type": "User",
"url": "https://api.github.com/users/b0g3r",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-30T18:15:37Z | 2021-09-08T14:00:25Z | 2016-11-30T18:16:51Z | NONE | resolved | Windows 10 64b
python 3.5 32b
PyInstaller 3.3dev
requests 1.12.2
problem:
```
test.py
--------------
import requests
print(requests.get('http://google.com').status_code)
> python -m PyInstaller test.py
...
> dist\test\test.exe
Traceback (most recent call last):
File "C:\Python35-32\lib\site-packages\requests\packages\__init__.py", line 27, in <module>
from . import urllib3
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\requests\packages\urllib3\__init__.py", line 8, in <module>
from .connectionpool import (
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 28, in <module>
from .packages.six.moves.queue import LifoQueue, Empty, Full
File "C:\Python35-32\lib\site-packages\requests\packages\urllib3\packages\six.py", line 203, in load_module
mod = mod._resolve()
File "C:\Python35-32\lib\site-packages\requests\packages\urllib3\packages\six.py", line 115, in _resolve
return _import_module(self.mod)
File "C:\Python35-32\lib\site-packages\requests\packages\urllib3\packages\six.py", line 82, in _import_module
__import__(name)
ImportError: No module named 'queue'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\TEMP\test.py", line 1, in <module>
import requests
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\requests\__init__.py", line 63, in <module>
from . import utils
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\requests\utils.py", line 24, in <module>
from ._internal_utils import to_native_string
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\requests\_internal_utils.py", line 11, in <module>
from .compat import is_py2, builtin_str
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\requests\compat.py", line 11, in <module>
from .packages import chardet
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\requests\packages\__init__.py", line 29, in <module>
import urllib3
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\urllib3\__init__.py", line 8, in <module>
from .connectionpool import (
File "C:\Python35-32\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 389, in load_module
exec(bytecode, module.__dict__)
File "C:\Python35-32\lib\site-packages\urllib3\connectionpool.py", line 28, in <module>
from .packages.six.moves.queue import LifoQueue, Empty, Full
File "C:\Python35-32\lib\site-packages\urllib3\packages\six.py", line 203, in load_module
mod = mod._resolve()
File "C:\Python35-32\lib\site-packages\urllib3\packages\six.py", line 115, in _resolve
return _import_module(self.mod)
File "C:\Python35-32\lib\site-packages\urllib3\packages\six.py", line 82, in _import_module
__import__(name)
ImportError: No module named 'queue'
Failed to execute script test
```
The problem disappeared after the installation request 1.11.0 and rebuild | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3737/reactions"
} | https://api.github.com/repos/psf/requests/issues/3737/timeline | null | completed | null | null | false | [
"This is a problem with pyinstaller. The `queue` module is part of the standard library, there is no reason for it not to be present."
] |
https://api.github.com/repos/psf/requests/issues/3736 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3736/labels{/name} | https://api.github.com/repos/psf/requests/issues/3736/comments | https://api.github.com/repos/psf/requests/issues/3736/events | https://github.com/psf/requests/issues/3736 | 192,635,737 | MDU6SXNzdWUxOTI2MzU3Mzc= | 3,736 | empty username and password no longer generate basicauth authstring | {
"avatar_url": "https://avatars.githubusercontent.com/u/1172004?v=4",
"events_url": "https://api.github.com/users/hummus/events{/privacy}",
"followers_url": "https://api.github.com/users/hummus/followers",
"following_url": "https://api.github.com/users/hummus/following{/other_user}",
"gists_url": "https://api.github.com/users/hummus/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hummus",
"id": 1172004,
"login": "hummus",
"node_id": "MDQ6VXNlcjExNzIwMDQ=",
"organizations_url": "https://api.github.com/users/hummus/orgs",
"received_events_url": "https://api.github.com/users/hummus/received_events",
"repos_url": "https://api.github.com/users/hummus/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hummus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hummus/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hummus",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-11-30T17:57:22Z | 2021-09-08T14:00:24Z | 2016-11-30T18:04:46Z | NONE | resolved | Possibly just a previously quirkly behavior that intentionally no longer works.
For `requests<2.12.2` having `None` for username and password still resulted in a BasicAuth authstr being created. Starting in `2.12.2` it will raise an exception.
```Traceback (most recent call last):
...
File "/blah/lib/python2.7/site-packages/requests/auth.py", line 38, in _basic_auth_str
b64encode(b':'.join((username, password))).strip()
TypeError: sequence item 0: expected string, NoneType found
```
here's the change, (which certainly seems desirable), but caused our upstream (`python-gitlab`) to break.
https://github.com/kennethreitz/requests/commit/329a5cfdd4500fb1ce405a3242ef95f9197d24ba | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3736/reactions"
} | https://api.github.com/repos/psf/requests/issues/3736/timeline | null | completed | null | null | false | [
"Uh...what basic auth string did it generate?",
"```\r\n(Pdb) username is None\r\nTrue\r\n(Pdb) password is None\r\nTrue\r\n(Pdb) authstr\r\n'Basic Tm9uZTpOb25l'\r\n```\r\nyea i'm fully aware that this doesn't make much sense and closing wontfix seems entirely reasonable. Just figured I'd call it out in case anyo... |
https://api.github.com/repos/psf/requests/issues/3735 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3735/labels{/name} | https://api.github.com/repos/psf/requests/issues/3735/comments | https://api.github.com/repos/psf/requests/issues/3735/events | https://github.com/psf/requests/issues/3735 | 192,612,604 | MDU6SXNzdWUxOTI2MTI2MDQ= | 3,735 | Requests v2.12.2 does not add parameters to URLs with schemes it does not understand. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | closed | true | null | [] | null | 4 | 2016-11-30T16:28:44Z | 2021-09-08T13:05:48Z | 2016-12-01T10:45:25Z | MEMBER | resolved | Follows from #3734.
When we patched to ignore all unrecognised schemes instead of just those that didn't begin `http`, we stopped handling parameters for those URLs. This may break some more benign uses such as `http+unix`, which wanted to add parameters to their URLs.
While this is inline with our intended policies (we do not understand URLs that have schemes we don't know anything about), this, along with the IDNA behaviour in v2.12.{0,1} will probably have broken a whole bunch of people using these non-standard URL schemes.
We should consider whether Session objects should have a registry of places to look for URL preparation based on scheme. This will allow people to opt-in to the HTTP-like processing of URLs, as well as to register their own. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3735/reactions"
} | https://api.github.com/repos/psf/requests/issues/3735/timeline | null | completed | null | null | false | [
"I should note that we have had this conversation with the docker-py folks before: see #1879.\r\n\r\nUltimately, there is a problem with how much people want us to understand URLs for non-standard HTTP schemes. People would like us to understand them enough to add query parameters, but not so much that we look for ... |
https://api.github.com/repos/psf/requests/issues/3734 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3734/labels{/name} | https://api.github.com/repos/psf/requests/issues/3734/comments | https://api.github.com/repos/psf/requests/issues/3734/events | https://github.com/psf/requests/issues/3734 | 192,590,208 | MDU6SXNzdWUxOTI1OTAyMDg= | 3,734 | docker-py breaks with some configurations of Requests v2.12.2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 19 | 2016-11-30T15:10:21Z | 2021-09-08T14:00:26Z | 2016-11-30T16:29:09Z | MEMBER | resolved | Reported by @graingert.
The patch filed by @tiran in #3713 seems to have broken docker-py. They're using a custom URL scheme (`http+docker`), which we previously applied URL preparation to but now do not. This has therefore busted what they were up to in v2.12.2.
I'm not immediately sure that we have a good way out of this. Prior to this patch docker-py users were *probably* at risk of encountering issues because the HTTP requests to the Docker API can be routed across unix domain sockets, which may entirely fail to contain hostnames and also fail to IDNA-encode. So I'm not sure that we don't need docker-py to route around this a different way. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3734/reactions"
} | https://api.github.com/repos/psf/requests/issues/3734/timeline | null | completed | null | null | false | [
"Corresponding docker-py issue is docker/docker-py#1321.",
"What is unclear to me is exactly *why* this skip is happening. @graingert, if you can run your example under pdb can you set a breakpoint at `requests.sessions.Session.request` and run `print url` when it breaks?",
"@Lukasa can do",
"@Lukasa it's 'ht... |
https://api.github.com/repos/psf/requests/issues/3733 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3733/labels{/name} | https://api.github.com/repos/psf/requests/issues/3733/comments | https://api.github.com/repos/psf/requests/issues/3733/events | https://github.com/psf/requests/pull/3733 | 192,224,170 | MDExOlB1bGxSZXF1ZXN0OTU2NTA2ODA= | 3,733 | remove weird characters from README.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/14212780?v=4",
"events_url": "https://api.github.com/users/jorgesumle/events{/privacy}",
"followers_url": "https://api.github.com/users/jorgesumle/followers",
"following_url": "https://api.github.com/users/jorgesumle/following{/other_user}",
"gists_url": "https://api.github.com/users/jorgesumle/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jorgesumle",
"id": 14212780,
"login": "jorgesumle",
"node_id": "MDQ6VXNlcjE0MjEyNzgw",
"organizations_url": "https://api.github.com/users/jorgesumle/orgs",
"received_events_url": "https://api.github.com/users/jorgesumle/received_events",
"repos_url": "https://api.github.com/users/jorgesumle/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jorgesumle/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jorgesumle/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jorgesumle",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-11-29T09:02:57Z | 2021-09-08T01:21:36Z | 2016-11-29T09:06:33Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3733/reactions"
} | https://api.github.com/repos/psf/requests/issues/3733/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3733.diff",
"html_url": "https://github.com/psf/requests/pull/3733",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3733.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3733"
} | true | [
"There's no reason to remove these. What are you trying to achieve here?",
"What are they? And what are they for? They are not displayed well in my computer.\r\n\r\nFrom Readme in GitHub\r\n![captura de pantalla de 2016-11-29 10 05 31](https://cloud.githubusercontent.com/assets/14212780/20703284/76a287dc-b61b-11e... | |
https://api.github.com/repos/psf/requests/issues/3732 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3732/labels{/name} | https://api.github.com/repos/psf/requests/issues/3732/comments | https://api.github.com/repos/psf/requests/issues/3732/events | https://github.com/psf/requests/issues/3732 | 192,159,995 | MDU6SXNzdWUxOTIxNTk5OTU= | 3,732 | Mutual TLS failing for requests > 2.11.1 | {
"avatar_url": "https://avatars.githubusercontent.com/u/2262214?v=4",
"events_url": "https://api.github.com/users/kevgliss/events{/privacy}",
"followers_url": "https://api.github.com/users/kevgliss/followers",
"following_url": "https://api.github.com/users/kevgliss/following{/other_user}",
"gists_url": "https://api.github.com/users/kevgliss/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevgliss",
"id": 2262214,
"login": "kevgliss",
"node_id": "MDQ6VXNlcjIyNjIyMTQ=",
"organizations_url": "https://api.github.com/users/kevgliss/orgs",
"received_events_url": "https://api.github.com/users/kevgliss/received_events",
"repos_url": "https://api.github.com/users/kevgliss/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevgliss/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevgliss/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevgliss",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2016-11-29T00:59:04Z | 2021-09-08T14:00:25Z | 2016-11-30T17:28:47Z | NONE | resolved | Seeing the following errors when attempting to upgrade to 2.12.1. This most likely has to do with the underlying upgrade to urllib3. If that is deemed the case I can move this issue.
2.11.1 does not exhibit any issues. Requests was installed with pip and running under python3.5.
Stacktrace:
```
Traceback (most recent call last):
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 417, in wrap_socket
cnx.do_handshake()
File "/apps/lemur/lib/python3.5/site-packages/OpenSSL/SSL.py", line 1424, in do_handshake
self._raise_ssl_error(self._ssl, result)
File "/apps/lemur/lib/python3.5/site-packages/OpenSSL/SSL.py", line 1172, in _raise_ssl_error
_raise_current_error()
File "/apps/lemur/lib/python3.5/site-packages/OpenSSL/_util.py", line 48, in exception_from_error_queue
raise exception_type(errors)
OpenSSL.SSL.Error: [('SSL routines', 'SSL3_READ_BYTES', 'tlsv1 alert unknown ca')]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 594, in urlopen
chunked=chunked)
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 350, in _make_request
self._validate_conn(conn)
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 835, in _validate_conn
conn.connect()
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connection.py", line 323, in connect
ssl_context=context)
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/util/ssl_.py", line 324, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 424, in wrap_socket
raise ssl.SSLError('bad handshake: %r' % e)
ssl.SSLError: ("bad handshake: Error([('SSL routines', 'SSL3_READ_BYTES', 'tlsv1 alert unknown ca')],)",)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/apps/lemur/lib/python3.5/site-packages/requests/adapters.py", line 423, in send
timeout=timeout
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 624, in urlopen
raise SSLError(e)
requests.packages.urllib3.exceptions.SSLError: ("bad handshake: Error([('SSL routines', 'SSL3_READ_BYTES', 'tlsv1 alert unknown ca')],)",)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/apps/lemur/lemur/common/schema.py", line 147, in decorated_function
resp = f(*args, **kwargs)
File "/apps/lemur/lemur/certificates/views.py", line 271, in post
return service.create(**data)
File "/apps/lemur/lemur/certificates/service.py", line 218, in create
cert_body, private_key, cert_chain = mint(**kwargs)
File "/apps/lemur/lemur/certificates/service.py", line 167, in mint
cert_body, cert_chain = issuer.create_certificate(csr, kwargs)
File "/apps/lemur/lemur-cloudca/lemur_cloudca/plugin.py", line 332, in create_certificate
response = self.post(endpoint, cloudca_options)
File "/apps/lemur/lemur-cloudca/lemur_cloudca/plugin.py", line 163, in post
response = self.session.post(self.url + endpoint, data=dumps(data), timeout=10, verify=self.ca_bundle)
File "/apps/lemur/lib/python3.5/site-packages/requests/sessions.py", line 535, in post
return self.request('POST', url, data=data, json=json, **kwargs)
File "/apps/lemur/lib/python3.5/site-packages/requests/sessions.py", line 488, in request
resp = self.send(prep, **send_kwargs)
File "/apps/lemur/lib/python3.5/site-packages/requests/sessions.py", line 609, in send
r = adapter.send(request, **kwargs)
File "/apps/lemur/lib/python3.5/site-packages/requests/adapters.py", line 497, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: ("bad handshake: Error([('SSL routines', 'SSL3_READ_BYTES', 'tlsv1 alert unknown ca')],)",)
Traceback (most recent call last):
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 594, in urlopen
chunked=chunked)
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 350, in _make_request
self._validate_conn(conn)
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 835, in _validate_conn
conn.connect()
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/connection.py", line 323, in connect
ssl_context=context)
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/util/ssl_.py", line 324, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "/apps/lemur/lib/python3.5/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 424, in wrap_socket
raise ssl.SSLError('bad handshake: %r' % e)
ssl.SSLError: ("bad handshake: Error([('SSL routines', 'SSL3_READ_BYTES', 'tlsv1 alert unknown ca')],)",)
```
Reproduce with:
```
import requests
class HostNameCheckingAdapter(HTTPAdapter):
def cert_verify(self, conn, url, verify, cert):
super(HostNameCheckingAdapter, self).cert_verify(conn, url, verify, cert)
conn.assert_hostname = False
s = requests.Session()
s.mount('https://', HostNameCheckingAdapter())
s.cert = 'path-to-pem'
s.get('https://example.com', verify='path-to-ca-bundle')
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3732/reactions"
} | https://api.github.com/repos/psf/requests/issues/3732/timeline | null | completed | null | null | false | [
"Is your CA bundle a directory or a single file?",
"The short explanation of this problem right now is that the server seems to be rejecting your certificate. My best guess on this is that the 2.11.1 Requests had a urllib3 that didn't work with PyOpenSSL, but now does, so you're bumping into a code problem with P... |
https://api.github.com/repos/psf/requests/issues/3731 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3731/labels{/name} | https://api.github.com/repos/psf/requests/issues/3731/comments | https://api.github.com/repos/psf/requests/issues/3731/events | https://github.com/psf/requests/issues/3731 | 191,959,378 | MDU6SXNzdWUxOTE5NTkzNzg= | 3,731 | __bool__() and __nonzero__() of Response | {
"avatar_url": "https://avatars.githubusercontent.com/u/414336?v=4",
"events_url": "https://api.github.com/users/guettli/events{/privacy}",
"followers_url": "https://api.github.com/users/guettli/followers",
"following_url": "https://api.github.com/users/guettli/following{/other_user}",
"gists_url": "https://api.github.com/users/guettli/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/guettli",
"id": 414336,
"login": "guettli",
"node_id": "MDQ6VXNlcjQxNDMzNg==",
"organizations_url": "https://api.github.com/users/guettli/orgs",
"received_events_url": "https://api.github.com/users/guettli/received_events",
"repos_url": "https://api.github.com/users/guettli/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/guettli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guettli/subscriptions",
"type": "User",
"url": "https://api.github.com/users/guettli",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-11-28T09:43:24Z | 2021-09-08T14:00:27Z | 2016-11-28T09:55:09Z | NONE | resolved | Do you really like this?
```
class Response(...):
def __bool__(self):
"""Returns true if :attr:`status_code` is 'OK'."""
return self.ok
def __nonzero__(self):
"""Returns true if :attr:`status_code` is 'OK'."""
return self.ok
```
I had this code:
```
def foo(request, response=None):
....
if response:
do_something_with_response
```
It took some time to understand why this did not work like the way I wanted.
I guess you don't want to change the current behaviour since it could break a lot of existing code.
Question: Do you really like this? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3731/reactions"
} | https://api.github.com/repos/psf/requests/issues/3731/timeline | null | completed | null | null | false | [
"Thanks for this report!\r\n\r\nIn the future, before filing issues against open source projects, please take the time to investigate whether they have seen an issue before. If you had searched \"bool\" in our issue tracker the first result you'd have seen would have been for #2002, which already tracks this issue.... |
https://api.github.com/repos/psf/requests/issues/3730 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3730/labels{/name} | https://api.github.com/repos/psf/requests/issues/3730/comments | https://api.github.com/repos/psf/requests/issues/3730/events | https://github.com/psf/requests/issues/3730 | 191,843,805 | MDU6SXNzdWUxOTE4NDM4MDU= | 3,730 | CLOSE_WAIT Issue | {
"avatar_url": "https://avatars.githubusercontent.com/u/5680206?v=4",
"events_url": "https://api.github.com/users/venkat2111987/events{/privacy}",
"followers_url": "https://api.github.com/users/venkat2111987/followers",
"following_url": "https://api.github.com/users/venkat2111987/following{/other_user}",
"gists_url": "https://api.github.com/users/venkat2111987/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/venkat2111987",
"id": 5680206,
"login": "venkat2111987",
"node_id": "MDQ6VXNlcjU2ODAyMDY=",
"organizations_url": "https://api.github.com/users/venkat2111987/orgs",
"received_events_url": "https://api.github.com/users/venkat2111987/received_events",
"repos_url": "https://api.github.com/users/venkat2111987/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/venkat2111987/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/venkat2111987/subscriptions",
"type": "User",
"url": "https://api.github.com/users/venkat2111987",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-11-27T05:42:48Z | 2021-09-08T14:00:28Z | 2016-11-27T08:36:02Z | NONE | resolved | Hi,
We are developing a python application using tornado framework. The application consumes a REST end point exposed by splunk system to get some metrics data. A scheduled background process runs and populates our application local data-store. While tornado serves data to third party using the local data-store.
We are using Requests==2.9.1 to communicate with Splunk
Code snippet using which we are communicating to Splunk:
------------------------------------------------------------------
try:
resp = requests.get(splunkapi,params = params, verify = False, headers = header )
if resp.status_code == 200 and (resp.content not in ['""','"None"']) :
results = json.loads(resp.json())
with open("outfile.json" , 'w') as outfile:
json.dump(results, outfile,indent=4)
else:
with open("outfile.json" , 'w') as outfile:
json.dump(dict(), outfile,indent=4)
except Exception,e:
with open("outfile.json" as outfile:
json.dump(dict(), outfile,indent=4)
CLOSE_WAIT Issue:
---------------------
Step 1: I bring up Tornado Application.
Step 2: I bring up splunk system.
Everything works fine
Step 3: For some reason, the sys admins have to reboot the machine where tornado application is running.
Lot of connections in CLOSE_WAIT status at splunk side.
Step 4: Restart Splunk.
Everything is cleaned up. The system continues to run smoothly.
Step 5: Reboot the system where tornado application is running.
Again same issue. Lot of CLOSE_WAIT connections at splunk side.
Are the CLOSE_WAIT connections a result of "Requests" not communicating properly with splunk? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3730/reactions"
} | https://api.github.com/repos/psf/requests/issues/3730/timeline | null | completed | null | null | false | [
"No. \r\n\r\nCLOSE_WAIT is the TCP state that is entered by the TCP peer that initiates a connection close. It cannot be avoided: it exists to ensure that delayed or retransmitted packets belonging to a TCP connection are not lost.\r\n\r\nWhen the Tornado application is closed down, Requests' pooled sockets all get... |
https://api.github.com/repos/psf/requests/issues/3729 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3729/labels{/name} | https://api.github.com/repos/psf/requests/issues/3729/comments | https://api.github.com/repos/psf/requests/issues/3729/events | https://github.com/psf/requests/issues/3729 | 191,606,444 | MDU6SXNzdWUxOTE2MDY0NDQ= | 3,729 | iter_content slow with large chunk size on HTTPS connection | {
"avatar_url": "https://avatars.githubusercontent.com/u/1097609?v=4",
"events_url": "https://api.github.com/users/pdknsk/events{/privacy}",
"followers_url": "https://api.github.com/users/pdknsk/followers",
"following_url": "https://api.github.com/users/pdknsk/following{/other_user}",
"gists_url": "https://api.github.com/users/pdknsk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pdknsk",
"id": 1097609,
"login": "pdknsk",
"node_id": "MDQ6VXNlcjEwOTc2MDk=",
"organizations_url": "https://api.github.com/users/pdknsk/orgs",
"received_events_url": "https://api.github.com/users/pdknsk/received_events",
"repos_url": "https://api.github.com/users/pdknsk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pdknsk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pdknsk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pdknsk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 22 | 2016-11-25T00:40:08Z | 2021-09-08T13:05:44Z | 2016-11-28T12:32:10Z | NONE | resolved | ```Python
https = requests.get(url, stream=True)
for content in https.iter_content(100 * 2 ** 20): # 100MB
pass
```
This causes `100%` CPU and slows down throughput to less than `1MB/s`. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3729/reactions"
} | https://api.github.com/repos/psf/requests/issues/3729/timeline | null | completed | null | null | false | [
"Sorry, but right now you haven't given us anything like enough to go on. Please answer all of the following questions:\r\n\r\n- How does this behave on smaller chunk sizes?\r\n- What about larger ones?\r\n- What version of Requests are you using?\r\n- What version of Python are you using? \r\n- Can you share the U... |
https://api.github.com/repos/psf/requests/issues/3718 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3718/labels{/name} | https://api.github.com/repos/psf/requests/issues/3718/comments | https://api.github.com/repos/psf/requests/issues/3718/events | https://github.com/psf/requests/pull/3718 | 191,383,270 | MDExOlB1bGxSZXF1ZXN0OTUwODE5ODQ= | 3,718 | Make Response.content() return None for an empty response | {
"avatar_url": "https://avatars.githubusercontent.com/u/4924623?v=4",
"events_url": "https://api.github.com/users/nsoranzo/events{/privacy}",
"followers_url": "https://api.github.com/users/nsoranzo/followers",
"following_url": "https://api.github.com/users/nsoranzo/following{/other_user}",
"gists_url": "https://api.github.com/users/nsoranzo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nsoranzo",
"id": 4924623,
"login": "nsoranzo",
"node_id": "MDQ6VXNlcjQ5MjQ2MjM=",
"organizations_url": "https://api.github.com/users/nsoranzo/orgs",
"received_events_url": "https://api.github.com/users/nsoranzo/received_events",
"repos_url": "https://api.github.com/users/nsoranzo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nsoranzo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nsoranzo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nsoranzo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2016-11-23T21:26:30Z | 2022-05-09T15:12:17Z | 2016-11-24T13:35:37Z | CONTRIBUTOR | resolved | Fix #3698.
This fixes also a traceback in https://github.com/galaxyproject/bioblend/blob/master/bioblend/galaxy/client.py#L135 where the `text` attribute of an empty `requests.Response()` object is used:
```
Traceback (most recent call last):
File "/usr/users/ga002/soranzon/software/galaxyproject_bioblend/tests/TestGalaxyInstance.py", line 37, in test_get_retry
self.gi.libraries.get_libraries()
File "/usr/users/ga002/soranzon/software/galaxyproject_bioblend/bioblend/galaxy/libraries/__init__.py", line 218, in get_libraries
libraries = self._get(deleted=deleted)
File "/usr/users/ga002/soranzon/software/galaxyproject_bioblend/bioblend/galaxy/client.py", line 135, in _get
raise ConnectionError(msg, body=r.text,
File "/usr/users/ga002/soranzon/software/galaxyproject_bioblend/.tox/py27/local/lib/python2.7/site-packages/requests/models.py", line 796, in text
if not self.content:
File "/usr/users/ga002/soranzon/software/galaxyproject_bioblend/.tox/py27/local/lib/python2.7/site-packages/requests/models.py", line 772, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "/usr/users/ga002/soranzon/software/galaxyproject_bioblend/.tox/py27/local/lib/python2.7/site-packages/requests/models.py", line 705, in generate
chunk = self.raw.read(chunk_size)
AttributeError: 'NoneType' object has no attribute 'read'
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3718/reactions"
} | https://api.github.com/repos/psf/requests/issues/3718/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3718.diff",
"html_url": "https://github.com/psf/requests/pull/3718",
"merged_at": "2016-11-24T13:35:37Z",
"patch_url": "https://github.com/psf/requests/pull/3718.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3718"
} | true | [
"Heh, I was going to say that we shouldn't tolerate silly status codes until I saw that we already tolerate `0`. That's really quite odd, but fair enough, I guess this is a logical extension of what we already do.",
"However, before we merge this, can I ask you to please add a test for this logic?",
"@Lukasa Do... |
https://api.github.com/repos/psf/requests/issues/3717 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3717/labels{/name} | https://api.github.com/repos/psf/requests/issues/3717/comments | https://api.github.com/repos/psf/requests/issues/3717/events | https://github.com/psf/requests/pull/3717 | 191,183,331 | MDExOlB1bGxSZXF1ZXN0OTQ5NDE1MTI= | 3,717 | streaming doc clarification | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-11-23T03:48:05Z | 2021-09-08T01:21:35Z | 2016-11-23T10:17:32Z | MEMBER | resolved | Minor example update and rewording in response to the continued discussion after merging #3704. @afeld, if you're inclined to comment, does this change still address your original concerns? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3717/reactions"
} | https://api.github.com/repos/psf/requests/issues/3717/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3717.diff",
"html_url": "https://github.com/psf/requests/pull/3717",
"merged_at": "2016-11-23T10:17:32Z",
"patch_url": "https://github.com/psf/requests/pull/3717.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3717"
} | true | [
":+1:",
"Thanks @afeld and @nateprewitt!"
] |
https://api.github.com/repos/psf/requests/issues/3716 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3716/labels{/name} | https://api.github.com/repos/psf/requests/issues/3716/comments | https://api.github.com/repos/psf/requests/issues/3716/events | https://github.com/psf/requests/issues/3716 | 191,107,106 | MDU6SXNzdWUxOTExMDcxMDY= | 3,716 | Can't Get Version 2.2.1 | {
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 16 | 2016-11-22T19:50:03Z | 2021-09-08T14:00:28Z | 2016-11-22T20:25:24Z | NONE | resolved | I have a program that won't run without version 2.2.0 or higher.
However, each time I try to install this with pip or easy_install, it only does 2.12.1 and even the --upgrade option says this is up to date.
I know this exists, since it's listed [here](https://pypi.python.org/pypi/requests/2.2.1), not to mention that this program requires it. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3716/reactions"
} | https://api.github.com/repos/psf/requests/issues/3716/timeline | null | completed | null | null | false | [
"@PatriotRDX have you tried using `pip install requests==2.2.1`?\r\n\r\nEdit: Sorry, let me clarify for a moment. Are you looking for a version that is lower than 2.12 but higher than 2.2.0? The minor version number is linear, so 2.2.0 is an older version than 2.12.1.",
"@nateprewitt thanks this helped. However, ... |
https://api.github.com/repos/psf/requests/issues/3715 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3715/labels{/name} | https://api.github.com/repos/psf/requests/issues/3715/comments | https://api.github.com/repos/psf/requests/issues/3715/events | https://github.com/psf/requests/issues/3715 | 190,974,287 | MDU6SXNzdWUxOTA5NzQyODc= | 3,715 | URL has an invalid label when requesting https://r8---sn-q4f7snss.googlevideo.com | {
"avatar_url": "https://avatars.githubusercontent.com/u/15957250?v=4",
"events_url": "https://api.github.com/users/aploium/events{/privacy}",
"followers_url": "https://api.github.com/users/aploium/followers",
"following_url": "https://api.github.com/users/aploium/following{/other_user}",
"gists_url": "https://api.github.com/users/aploium/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aploium",
"id": 15957250,
"login": "aploium",
"node_id": "MDQ6VXNlcjE1OTU3MjUw",
"organizations_url": "https://api.github.com/users/aploium/orgs",
"received_events_url": "https://api.github.com/users/aploium/received_events",
"repos_url": "https://api.github.com/users/aploium/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aploium/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aploium/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aploium",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-22T11:26:42Z | 2021-09-08T14:00:29Z | 2016-11-22T11:53:29Z | NONE | resolved | ```python
>>> import requests
>>> requests.get("https://r8---sn-q4f7snss.googlevideo.com")
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/requests/models.py", line 370, in prepare_url
host = idna.encode(host, uts46=True).decode('utf-8')
File "/usr/local/lib/python3.4/dist-packages/requests/packages/idna/core.py", line 355, in encode
result.append(alabel(label))
File "/usr/local/lib/python3.4/dist-packages/requests/packages/idna/core.py", line 276, in alabel
check_label(label)
File "/usr/local/lib/python3.4/dist-packages/requests/packages/idna/core.py", line 253, in check_label
raise InvalidCodepoint('Codepoint {0} at position {1} of {2} not allowed'.format(_unot(cp_value), pos+1, repr(label)))
requests.packages.idna.core.InvalidCodepoint: Codepoint U+0027 at position 2 of "b'r8---sn-q4f7snss'" not allowed
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.4/dist-packages/requests/api.py", line 70, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python3.4/dist-packages/requests/api.py", line 56, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.4/dist-packages/requests/sessions.py", line 474, in request
prep = self.prepare_request(req)
File "/usr/local/lib/python3.4/dist-packages/requests/sessions.py", line 407, in prepare_request
hooks=merge_hooks(request.hooks, self.hooks),
File "/usr/local/lib/python3.4/dist-packages/requests/models.py", line 302, in prepare
self.prepare_url(url, params)
File "/usr/local/lib/python3.4/dist-packages/requests/models.py", line 372, in prepare_url
raise InvalidURL('URL has an invalid label.')
requests.exceptions.InvalidURL: URL has an invalid label.
```
requests 2.12.0 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3715/reactions"
} | https://api.github.com/repos/psf/requests/issues/3715/timeline | null | completed | null | null | false | [
"When reporting bugs in open source projects *please* check the open issues first before opening a new one. If you had done that you'd have found literally the text \"URL has an invalid label\" next to the word \"Bug\" four entries down.\r\n\r\nDuplicate of #3683, closing accordingly."
] |
https://api.github.com/repos/psf/requests/issues/3714 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3714/labels{/name} | https://api.github.com/repos/psf/requests/issues/3714/comments | https://api.github.com/repos/psf/requests/issues/3714/events | https://github.com/psf/requests/issues/3714 | 190,812,422 | MDU6SXNzdWUxOTA4MTI0MjI= | 3,714 | Old "cryptography" package causes crash | {
"avatar_url": "https://avatars.githubusercontent.com/u/363982?v=4",
"events_url": "https://api.github.com/users/aseering/events{/privacy}",
"followers_url": "https://api.github.com/users/aseering/followers",
"following_url": "https://api.github.com/users/aseering/following{/other_user}",
"gists_url": "https://api.github.com/users/aseering/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aseering",
"id": 363982,
"login": "aseering",
"node_id": "MDQ6VXNlcjM2Mzk4Mg==",
"organizations_url": "https://api.github.com/users/aseering/orgs",
"received_events_url": "https://api.github.com/users/aseering/received_events",
"repos_url": "https://api.github.com/users/aseering/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aseering/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aseering/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aseering",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-11-21T19:28:17Z | 2021-09-08T14:00:26Z | 2016-11-21T19:29:49Z | NONE | resolved | As of `requests==2.12.1`, `requests[security]` depends on `cryptography>=1.3.4`. That's fine. However, `requests` (without `[security]`) crashes if `cryptography==1.0.2` is installed. This is a perfectly valid configuration of packages according to `pip`; as a user, I would expect it to behave as if I had not specified `[security]` (because I didn't specify it).
The specific failure is discussed a bit more here:
http://discuss.flexget.com/t/unhandled-error-in-plugin-configure-series-solved/2900
The crash was resolved, also as described at the above link, by running:
```
pip install --upgrade cryptography
```
Uninstalling `cryptography` would probably have worked fine too.
The crash appears to be caused because `requests` internally tests for `[security]` by importing a thing which imports its bundled `pyopenssl` which imports `cryptography`; if that succeeds, the extra is used. But with a too-old version of `cryptography`, it imports just fine but it constructs objects that are missing required fields.
I can think of a couple approaches here:
* Catch this failure and print an error message that more-helpfully explains that your `cryptography` package needs updating
* Validate the version/functionality of the `cryptography`package more carefully, and don't enable the `[security]` extra's features if an old version happens to be installed
I'd be happy to post a PR for either approach. Right now I'm looking for feedback on whether it's worth addressing this (I'd certainly appreciate it) and on what approach you'd prefer. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3714/reactions"
} | https://api.github.com/repos/psf/requests/issues/3714/timeline | null | completed | null | null | false | [
"Thanks for this!\r\n\r\nI think this is actually fundamentally a problem with urllib3: urllib3's contrib module should be more aggressively checking for whether it possesses a suitable cryptography module before injecting itself. If you open an issue on that repository, we can take it forward from there.\r\n\r\nTh... |
https://api.github.com/repos/psf/requests/issues/3713 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3713/labels{/name} | https://api.github.com/repos/psf/requests/issues/3713/comments | https://api.github.com/repos/psf/requests/issues/3713/events | https://github.com/psf/requests/pull/3713 | 190,778,731 | MDExOlB1bGxSZXF1ZXN0OTQ2NTYwMDY= | 3,713 | Restrict URL preparation to HTTP/HTTPS | {
"avatar_url": "https://avatars.githubusercontent.com/u/444071?v=4",
"events_url": "https://api.github.com/users/tiran/events{/privacy}",
"followers_url": "https://api.github.com/users/tiran/followers",
"following_url": "https://api.github.com/users/tiran/following{/other_user}",
"gists_url": "https://api.github.com/users/tiran/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tiran",
"id": 444071,
"login": "tiran",
"node_id": "MDQ6VXNlcjQ0NDA3MQ==",
"organizations_url": "https://api.github.com/users/tiran/orgs",
"received_events_url": "https://api.github.com/users/tiran/received_events",
"repos_url": "https://api.github.com/users/tiran/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tiran/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tiran/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tiran",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-11-21T17:05:12Z | 2021-09-08T01:21:38Z | 2016-11-21T19:13:56Z | CONTRIBUTOR | resolved | Requests treats all URLs starting with the string 'http' as HTTP URLs.
Preparation with IDNA breaks non-standard URIs like http+unix. Requests
now prepares only URLs with prefix http:// and https://.
Signed-off-by: Christian Heimes <christian@python.org> | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3713/reactions"
} | https://api.github.com/repos/psf/requests/issues/3713/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3713.diff",
"html_url": "https://github.com/psf/requests/pull/3713",
"merged_at": "2016-11-21T19:13:56Z",
"patch_url": "https://github.com/psf/requests/pull/3713.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3713"
} | true | [
"http+unix is used in Docker, Custodia and SSSD, e.g. https://github.com/latchset/custodia/blob/master/custodia/client.py#L60 with URI like ```http+unix://%2Fvar%2Frun%2Fcustodia.socket/secrets``` for HTTP over Unix sockets on socket file ```/var/run/custodia.socket```.",
"This looks entirely reasonable to me, th... |
https://api.github.com/repos/psf/requests/issues/3712 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3712/labels{/name} | https://api.github.com/repos/psf/requests/issues/3712/comments | https://api.github.com/repos/psf/requests/issues/3712/events | https://github.com/psf/requests/issues/3712 | 190,689,249 | MDU6SXNzdWUxOTA2ODkyNDk= | 3,712 | Older changelog entries don't specify urllib3 versions | {
"avatar_url": "https://avatars.githubusercontent.com/u/301220?v=4",
"events_url": "https://api.github.com/users/alexwlchan/events{/privacy}",
"followers_url": "https://api.github.com/users/alexwlchan/followers",
"following_url": "https://api.github.com/users/alexwlchan/following{/other_user}",
"gists_url": "https://api.github.com/users/alexwlchan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexwlchan",
"id": 301220,
"login": "alexwlchan",
"node_id": "MDQ6VXNlcjMwMTIyMA==",
"organizations_url": "https://api.github.com/users/alexwlchan/orgs",
"received_events_url": "https://api.github.com/users/alexwlchan/received_events",
"repos_url": "https://api.github.com/users/alexwlchan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexwlchan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexwlchan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexwlchan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-11-21T11:25:57Z | 2021-09-08T14:00:30Z | 2016-11-21T23:10:52Z | CONTRIBUTOR | resolved | Some of the older changelog entries, starting at 2.4.0 and working backward, mention that the urllib3 version was bumped but don't say what version it was bumped to.
This can cause mildly annoying dependency resolution problems, especially if you partake in unsavory activities such as:
* Installing requests from an RPM source that doesn't vendor urllib3
* Running extremely outdated versions of requests/urllib3
It would be useful if the changelog included these details (as newer changelog entries do).
I'm happy to put in the time to do this, but probably not immediately. | {
"avatar_url": "https://avatars.githubusercontent.com/u/301220?v=4",
"events_url": "https://api.github.com/users/alexwlchan/events{/privacy}",
"followers_url": "https://api.github.com/users/alexwlchan/followers",
"following_url": "https://api.github.com/users/alexwlchan/following{/other_user}",
"gists_url": "https://api.github.com/users/alexwlchan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexwlchan",
"id": 301220,
"login": "alexwlchan",
"node_id": "MDQ6VXNlcjMwMTIyMA==",
"organizations_url": "https://api.github.com/users/alexwlchan/orgs",
"received_events_url": "https://api.github.com/users/alexwlchan/received_events",
"repos_url": "https://api.github.com/users/alexwlchan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexwlchan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexwlchan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexwlchan",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3712/reactions"
} | https://api.github.com/repos/psf/requests/issues/3712/timeline | null | completed | null | null | false | [
"So, uh, this won't work as well as you think.\r\n\r\nPrior to v2.6.2 the Requests team didn't necessarily update to specific urllib3 versions but instead updated to the state of the urllib3 master branch. That means there often *is no* urllib3 version that directly matches what Requests was using. So my question i... |
https://api.github.com/repos/psf/requests/issues/3711 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3711/labels{/name} | https://api.github.com/repos/psf/requests/issues/3711/comments | https://api.github.com/repos/psf/requests/issues/3711/events | https://github.com/psf/requests/issues/3711 | 190,548,208 | MDU6SXNzdWUxOTA1NDgyMDg= | 3,711 | Indna causes issues with Jython due to uts46data.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/12439039?v=4",
"events_url": "https://api.github.com/users/johnabooth/events{/privacy}",
"followers_url": "https://api.github.com/users/johnabooth/followers",
"following_url": "https://api.github.com/users/johnabooth/following{/other_user}",
"gists_url": "https://api.github.com/users/johnabooth/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/johnabooth",
"id": 12439039,
"login": "johnabooth",
"node_id": "MDQ6VXNlcjEyNDM5MDM5",
"organizations_url": "https://api.github.com/users/johnabooth/orgs",
"received_events_url": "https://api.github.com/users/johnabooth/received_events",
"repos_url": "https://api.github.com/users/johnabooth/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/johnabooth/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/johnabooth/subscriptions",
"type": "User",
"url": "https://api.github.com/users/johnabooth",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2016-11-20T09:25:15Z | 2021-09-08T13:05:37Z | 2016-12-21T13:26:13Z | NONE | resolved | Unable to use requests in Jython 2.7 without some patches to Indna. I've made these at https://github.com/METAVERO/idna and notified main repo owners. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3711/reactions"
} | https://api.github.com/repos/psf/requests/issues/3711/timeline | null | completed | null | null | false | [
"Thanks for letting us know. You should strongly consider opening a pull request on the idna repository instead of just an issue.\n",
"Hi Lukasa, I did open a pull request on my repository and then closed it. A little new to Github -- do I need to open another pull request or are you able to review the history i... |
https://api.github.com/repos/psf/requests/issues/3710 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3710/labels{/name} | https://api.github.com/repos/psf/requests/issues/3710/comments | https://api.github.com/repos/psf/requests/issues/3710/events | https://github.com/psf/requests/issues/3710 | 190,543,530 | MDU6SXNzdWUxOTA1NDM1MzA= | 3,710 | 'Extensions' object has no attribute 'get_extension_for_class' | {
"avatar_url": "https://avatars.githubusercontent.com/u/1267035?v=4",
"events_url": "https://api.github.com/users/youyanggu/events{/privacy}",
"followers_url": "https://api.github.com/users/youyanggu/followers",
"following_url": "https://api.github.com/users/youyanggu/following{/other_user}",
"gists_url": "https://api.github.com/users/youyanggu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/youyanggu",
"id": 1267035,
"login": "youyanggu",
"node_id": "MDQ6VXNlcjEyNjcwMzU=",
"organizations_url": "https://api.github.com/users/youyanggu/orgs",
"received_events_url": "https://api.github.com/users/youyanggu/received_events",
"repos_url": "https://api.github.com/users/youyanggu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/youyanggu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/youyanggu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/youyanggu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-11-20T07:02:50Z | 2021-09-08T14:00:27Z | 2016-11-20T09:53:33Z | NONE | resolved | This occurred after I upgraded form 2.11.1 to 2.12.1. The error occurs arbitrarily for the URLs I tried.
> requests.get('http://google.com') # works
> requests.get('http://www.google.com') # works
> requests.get('https://google.com') # does not work
> requests.get('https://www.google.com') # does not work
> requests.get('http://amazon.com') # sometimes works
> requests.get('http://www.amazon.com') # does not work
> requests.get('https://amazon.com') # does not work
> requests.get('https://www.amazon.com') # does not work
Below is the error:
```python
/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.pyc in _make_request(self, conn, method, url, timeout, chunked, **httplib_request_kw)
348 # Trigger any extra validation we need to do.
349 try:
--> 350 self._validate_conn(conn)
351 except (SocketTimeout, BaseSSLError) as e:
352 # Py2 raises this as a BaseSSLError, Py3 raises it as socket timeout.
/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.pyc in _validate_conn(self, conn)
833 # Force connect early to allow us to validate the connection.
834 if not getattr(conn, 'sock', None): # AppEngine might not have `.sock`
--> 835 conn.connect()
836
837 if not conn.is_verified:
/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connection.pyc in connect(self)
328 elif context.verify_mode != ssl.CERT_NONE \
329 and self.assert_hostname is not False:
--> 330 cert = self.sock.getpeercert()
331 if not cert.get('subjectAltName', ()):
332 warnings.warn((
/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/contrib/pyopenssl.pyc in getpeercert(self, binary_form)
322 (('commonName', x509.get_subject().CN),),
323 ),
--> 324 'subjectAltName': get_subj_alt_name(x509)
325 }
326
/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/contrib/pyopenssl.pyc in get_subj_alt_name(peer_cert)
169 # faster than looping in Python)
170 try:
--> 171 ext = cert.extensions.get_extension_for_class(
172 x509.SubjectAlternativeName
173 ).value
AttributeError: 'Extensions' object has no attribute 'get_extension_for_class'
```
Tried it on Ubuntu/Python 2.7.10 and macOS/Python 2.7.11. I have OpenSSL 1.0.2 for both. Same error on both. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3710/reactions"
} | https://api.github.com/repos/psf/requests/issues/3710/timeline | null | completed | null | null | false | [
"What version of `cryptography` do you have installed please?\n",
"I have cryptography 1.0.2. Upgrading to the latest 1.5.3 solved the problem. Thanks!\n",
"No problem! For anyone looking at this issue in future, our minimum cryptography version is currently 1.3.4, and that is expressed in the `'security'` extr... |
https://api.github.com/repos/psf/requests/issues/3709 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3709/labels{/name} | https://api.github.com/repos/psf/requests/issues/3709/comments | https://api.github.com/repos/psf/requests/issues/3709/events | https://github.com/psf/requests/pull/3709 | 190,536,005 | MDExOlB1bGxSZXF1ZXN0OTQ1MDUwOTA= | 3,709 | Added new function that returns json output in a pretty printed string form. | {
"avatar_url": "https://avatars.githubusercontent.com/u/3707038?v=4",
"events_url": "https://api.github.com/users/rmhasan/events{/privacy}",
"followers_url": "https://api.github.com/users/rmhasan/followers",
"following_url": "https://api.github.com/users/rmhasan/following{/other_user}",
"gists_url": "https://api.github.com/users/rmhasan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rmhasan",
"id": 3707038,
"login": "rmhasan",
"node_id": "MDQ6VXNlcjM3MDcwMzg=",
"organizations_url": "https://api.github.com/users/rmhasan/orgs",
"received_events_url": "https://api.github.com/users/rmhasan/received_events",
"repos_url": "https://api.github.com/users/rmhasan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rmhasan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rmhasan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rmhasan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-11-20T03:03:26Z | 2021-09-08T01:21:39Z | 2016-11-20T07:45:36Z | CONTRIBUTOR | resolved | The function sjson in the Response class will return a json object in string form. Unless provided arguments, it will return a pretty printed string, when printed is human readable. You can look at the docs for the json module's dumps object to know which arguments to send to the sjson function for custom output. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3709/reactions"
} | https://api.github.com/repos/psf/requests/issues/3709/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3709.diff",
"html_url": "https://github.com/psf/requests/pull/3709",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3709.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3709"
} | true | [
"\nThis is what the output should look like.\n",
"I believe requests is in an API freeze at this point, especially when user code could do the same thing with `r.content` and their preferred indentation lev... |
https://api.github.com/repos/psf/requests/issues/3708 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3708/labels{/name} | https://api.github.com/repos/psf/requests/issues/3708/comments | https://api.github.com/repos/psf/requests/issues/3708/events | https://github.com/psf/requests/issues/3708 | 190,438,200 | MDU6SXNzdWUxOTA0MzgyMDA= | 3,708 | Allow domains instead urls | {
"avatar_url": "https://avatars.githubusercontent.com/u/20229528?v=4",
"events_url": "https://api.github.com/users/sihaelov/events{/privacy}",
"followers_url": "https://api.github.com/users/sihaelov/followers",
"following_url": "https://api.github.com/users/sihaelov/following{/other_user}",
"gists_url": "https://api.github.com/users/sihaelov/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sihaelov",
"id": 20229528,
"login": "sihaelov",
"node_id": "MDQ6VXNlcjIwMjI5NTI4",
"organizations_url": "https://api.github.com/users/sihaelov/orgs",
"received_events_url": "https://api.github.com/users/sihaelov/received_events",
"repos_url": "https://api.github.com/users/sihaelov/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sihaelov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sihaelov/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sihaelov",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-18T22:34:14Z | 2021-09-08T14:00:31Z | 2016-11-18T22:40:24Z | NONE | resolved | ```
requests.get('google.com')
requests.exceptions.MissingSchema: Invalid URL 'google.com': No schema supplied. Perhaps you meant http://google.com?
```
Why does it not allow use domains? It looks as the simple task and I can do it. What do you think? I searched similar issues but did not find. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3708/reactions"
} | https://api.github.com/repos/psf/requests/issues/3708/timeline | null | completed | null | null | false | [
"It's impossible to know whether you wanted us to use HTTP or HTTPs, and in the face of uncertainty (especially when privacy is concerned) it's significantly more correct to not guess.\n\nYou can absolutely implement whatever behaviour you're thinking of in a wrapper. There's no need and no desire for it to live in... |
https://api.github.com/repos/psf/requests/issues/3707 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3707/labels{/name} | https://api.github.com/repos/psf/requests/issues/3707/comments | https://api.github.com/repos/psf/requests/issues/3707/events | https://github.com/psf/requests/issues/3707 | 190,200,325 | MDU6SXNzdWUxOTAyMDAzMjU= | 3,707 | r=request.put(url,json={...}), put doesn't accept json as argument while post does? | {
"avatar_url": "https://avatars.githubusercontent.com/u/8951837?v=4",
"events_url": "https://api.github.com/users/gladwig2/events{/privacy}",
"followers_url": "https://api.github.com/users/gladwig2/followers",
"following_url": "https://api.github.com/users/gladwig2/following{/other_user}",
"gists_url": "https://api.github.com/users/gladwig2/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gladwig2",
"id": 8951837,
"login": "gladwig2",
"node_id": "MDQ6VXNlcjg5NTE4Mzc=",
"organizations_url": "https://api.github.com/users/gladwig2/orgs",
"received_events_url": "https://api.github.com/users/gladwig2/received_events",
"repos_url": "https://api.github.com/users/gladwig2/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gladwig2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gladwig2/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gladwig2",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-11-17T23:59:49Z | 2021-09-08T14:00:32Z | 2016-11-18T08:34:18Z | NONE | resolved | http://stackoverflow.com/questions/9733638/post-json-using-python-requests
shows
r = requests.post('http://httpbin.org/post', json={"key": "value"})
but trying the same thing with put did not seem to work.
had to
#r = session.put(url, json=schema) (should work!)
headers = {'Content-type': 'application/json'}
r = session.put(url,data=json.dumps(jsonschema),headers=headers) | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3707/reactions"
} | https://api.github.com/repos/psf/requests/issues/3707/timeline | null | completed | null | null | false | [
"Hey @githubnovice, I'm unfortunately unable to reproduce this issue with the current information. Could you please provide the version of Requests you're using, the exact request (with parameters), and possibly the traceback you're seeing?\n\nThese are the examples I tried.\n\n``` python\n>>> import requests\n>>> ... |
https://api.github.com/repos/psf/requests/issues/3706 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3706/labels{/name} | https://api.github.com/repos/psf/requests/issues/3706/comments | https://api.github.com/repos/psf/requests/issues/3706/events | https://github.com/psf/requests/issues/3706 | 190,180,090 | MDU6SXNzdWUxOTAxODAwOTA= | 3,706 | requests not able to validate the self signed certificate but i can use it using curl | {
"avatar_url": "https://avatars.githubusercontent.com/u/12552530?v=4",
"events_url": "https://api.github.com/users/kmala/events{/privacy}",
"followers_url": "https://api.github.com/users/kmala/followers",
"following_url": "https://api.github.com/users/kmala/following{/other_user}",
"gists_url": "https://api.github.com/users/kmala/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kmala",
"id": 12552530,
"login": "kmala",
"node_id": "MDQ6VXNlcjEyNTUyNTMw",
"organizations_url": "https://api.github.com/users/kmala/orgs",
"received_events_url": "https://api.github.com/users/kmala/received_events",
"repos_url": "https://api.github.com/users/kmala/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kmala/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kmala/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kmala",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 13 | 2016-11-17T22:15:30Z | 2021-09-08T14:00:30Z | 2016-11-21T17:29:20Z | NONE | resolved | ```
>>> requests.get('https://10.0.0.1:443/api', verify='/run/secrets/kubernetes.io/serviceaccount/ca.crt')
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 417, in wrap_socket
cnx.do_handshake()
File "/usr/local/lib/python3.5/dist-packages/OpenSSL/SSL.py", line 1426, in do_handshake
self._raise_ssl_error(self._ssl, result)
File "/usr/local/lib/python3.5/dist-packages/OpenSSL/SSL.py", line 1174, in _raise_ssl_error
_raise_current_error()
File "/usr/local/lib/python3.5/dist-packages/OpenSSL/_util.py", line 48, in exception_from_error_queue
raise exception_type(errors)
OpenSSL.SSL.Error: [('SSL routines', 'ssl3_get_server_certificate', 'certificate verify failed')]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/connectionpool.py", line 594, in urlopen
chunked=chunked)
File "/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/connectionpool.py", line 350, in _make_request
self._validate_conn(conn)
File "/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/connectionpool.py", line 835, in _validate_conn
conn.connect()
File "/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/connection.py", line 323, in connect
ssl_context=context)
File "/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/util/ssl_.py", line 324, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 424, in wrap_socket
raise ssl.SSLError('bad handshake: %r' % e)
ssl.SSLError: ("bad handshake: Error([('SSL routines', 'ssl3_get_server_certificate', 'certificate verify failed')],)",)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/requests/adapters.py", line 423, in send
timeout=timeout
File "/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/connectionpool.py", line 624, in urlopen
raise SSLError(e)
requests.packages.urllib3.exceptions.SSLError: ("bad handshake: Error([('SSL routines', 'ssl3_get_server_certificate', 'certificate verify failed')],)",)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.5/dist-packages/requests/api.py", line 70, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/requests/api.py", line 56, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/requests/sessions.py", line 488, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.5/dist-packages/requests/sessions.py", line 609, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/requests/adapters.py", line 497, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: ("bad handshake: Error([('SSL routines', 'ssl3_get_server_certificate', 'certificate verify failed')],)",)
```
Python 3.5.2
pyOpenSSL==16.2.0
requests==2.12.1
```
$ openssl verify /var/run/secrets/kubernetes.io/serviceaccount/ca.crt
/var/run/secrets/kubernetes.io/serviceaccount/ca.crt: CN = acsk8sca
error 18 at 0 depth lookup:self signed certificate
OK
```
with curl
```
curl -I -X GET https://10.0.0.1:443/api --header "Authorization: Bearer $TOKEN" --cacert /run/secrets/kubernetes.io/serviceaccount/ca.crt
HTTP/1.1 200 OK
Content-Type: application/json
Date: Thu, 17 Nov 2016 21:57:41 GMT
Content-Length: 183
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/12552530?v=4",
"events_url": "https://api.github.com/users/kmala/events{/privacy}",
"followers_url": "https://api.github.com/users/kmala/followers",
"following_url": "https://api.github.com/users/kmala/following{/other_user}",
"gists_url": "https://api.github.com/users/kmala/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kmala",
"id": 12552530,
"login": "kmala",
"node_id": "MDQ6VXNlcjEyNTUyNTMw",
"organizations_url": "https://api.github.com/users/kmala/orgs",
"received_events_url": "https://api.github.com/users/kmala/received_events",
"repos_url": "https://api.github.com/users/kmala/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kmala/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kmala/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kmala",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3706/reactions"
} | https://api.github.com/repos/psf/requests/issues/3706/timeline | null | completed | null | null | false | [
"Can you show me the output of `openssl x509 -in /var/run/secrets/kubernetes.io/serviceaccount/ca.crt -noout -text` and the equivalent command run on the certificate being offered by 10.0.0.1 please?\n",
"Client:\n\n```\nroot@deis-controller-1217413231-almny:/app# openssl x509 -in /var/run/secrets/kubernetes.io/s... |
https://api.github.com/repos/psf/requests/issues/3705 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3705/labels{/name} | https://api.github.com/repos/psf/requests/issues/3705/comments | https://api.github.com/repos/psf/requests/issues/3705/events | https://github.com/psf/requests/issues/3705 | 190,129,276 | MDU6SXNzdWUxOTAxMjkyNzY= | 3,705 | bug in PreparedRequests without simplejson library (under jython 2.7 only?) | {
"avatar_url": "https://avatars.githubusercontent.com/u/20236262?v=4",
"events_url": "https://api.github.com/users/j-christ/events{/privacy}",
"followers_url": "https://api.github.com/users/j-christ/followers",
"following_url": "https://api.github.com/users/j-christ/following{/other_user}",
"gists_url": "https://api.github.com/users/j-christ/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/j-christ",
"id": 20236262,
"login": "j-christ",
"node_id": "MDQ6VXNlcjIwMjM2MjYy",
"organizations_url": "https://api.github.com/users/j-christ/orgs",
"received_events_url": "https://api.github.com/users/j-christ/received_events",
"repos_url": "https://api.github.com/users/j-christ/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/j-christ/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j-christ/subscriptions",
"type": "User",
"url": "https://api.github.com/users/j-christ",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-11-17T18:42:32Z | 2021-09-08T14:00:32Z | 2016-11-17T19:17:26Z | NONE | resolved | I noticed the following bug when running requests under jython 2.7 where I had not yet installed simplejson:
In requests/models.py, the method PreparedRequest.prepare_body has the following code:
````
if not data and json is not None:
# urllib3 requires a bytes-like body. Python 2's json.dumps
# provides this natively, but Python 3 gives a Unicode string.
content_type = 'application/json'
body = complexjson.dumps(json)
if not isinstance(body, bytes):
body = body.encode('utf-8')
````
`json` in this case, is defined from the .compat file:
````
try:
import simplejson as json
except (ImportError, SyntaxError):
# simplejson does not support Python 3.2, it throws a SyntaxError
# because of u'...' Unicode literals.
import json
````
If simplejson is not installed under jython, the code in models.py throws an exception because dumps is not defined in the json module.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3705/reactions"
} | https://api.github.com/repos/psf/requests/issues/3705/timeline | null | completed | null | null | false | [
"In this instance, I think I'm inclined to suggest that this is a JSON problem, not a Requests problem. json.dumps is not a new interface. And without it, our json parameter cannot possibly work anyway.\n",
"@j-Christ, Jython 2.7 should support dumps without issue. I'd suggest checking your local directory or pyt... |
https://api.github.com/repos/psf/requests/issues/3704 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3704/labels{/name} | https://api.github.com/repos/psf/requests/issues/3704/comments | https://api.github.com/repos/psf/requests/issues/3704/events | https://github.com/psf/requests/pull/3704 | 190,110,115 | MDExOlB1bGxSZXF1ZXN0OTQyMTE5ODc= | 3,704 | clarify that the `chunk_size` is optional when streaming to a file | {
"avatar_url": "https://avatars.githubusercontent.com/u/86842?v=4",
"events_url": "https://api.github.com/users/afeld/events{/privacy}",
"followers_url": "https://api.github.com/users/afeld/followers",
"following_url": "https://api.github.com/users/afeld/following{/other_user}",
"gists_url": "https://api.github.com/users/afeld/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/afeld",
"id": 86842,
"login": "afeld",
"node_id": "MDQ6VXNlcjg2ODQy",
"organizations_url": "https://api.github.com/users/afeld/orgs",
"received_events_url": "https://api.github.com/users/afeld/received_events",
"repos_url": "https://api.github.com/users/afeld/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/afeld/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/afeld/subscriptions",
"type": "User",
"url": "https://api.github.com/users/afeld",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-11-17T17:22:24Z | 2021-09-08T01:21:39Z | 2016-11-17T17:27:47Z | CONTRIBUTOR | resolved | Tripped me up briefly...figured others might run into the same thing. Thanks! | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3704/reactions"
} | https://api.github.com/repos/psf/requests/issues/3704/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3704.diff",
"html_url": "https://github.com/psf/requests/pull/3704",
"merged_at": "2016-11-17T17:27:47Z",
"patch_url": "https://github.com/psf/requests/pull/3704.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3704"
} | true | [
"It's probably important to note that you _should_ provide a chunk_size here despite it being optional. The default of 1 is likely not what the user wants for any non-trivial file.\n",
"@nateprewitt Yeah, thought about that...might make sense to give a value of `128` or something reasonable in the example, and ju... |
https://api.github.com/repos/psf/requests/issues/3703 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3703/labels{/name} | https://api.github.com/repos/psf/requests/issues/3703/comments | https://api.github.com/repos/psf/requests/issues/3703/events | https://github.com/psf/requests/pull/3703 | 190,085,458 | MDExOlB1bGxSZXF1ZXN0OTQxOTQxMjQ= | 3,703 | Revert "Adding 'import requests' to readme code snippet." | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-11-17T15:53:35Z | 2021-09-06T00:06:52Z | 2016-11-17T15:53:38Z | CONTRIBUTOR | resolved | Reverts kennethreitz/requests#3700 | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3703/reactions"
} | https://api.github.com/repos/psf/requests/issues/3703/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3703.diff",
"html_url": "https://github.com/psf/requests/pull/3703",
"merged_at": "2016-11-17T15:53:38Z",
"patch_url": "https://github.com/psf/requests/pull/3703.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3703"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/3702 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3702/labels{/name} | https://api.github.com/repos/psf/requests/issues/3702/comments | https://api.github.com/repos/psf/requests/issues/3702/events | https://github.com/psf/requests/issues/3702 | 190,063,412 | MDU6SXNzdWUxOTAwNjM0MTI= | 3,702 | SSLError: [SSL] PEM lib (_ssl.c:2603) when I want to connect to a server with TLS | {
"avatar_url": "https://avatars.githubusercontent.com/u/4517525?v=4",
"events_url": "https://api.github.com/users/darakt/events{/privacy}",
"followers_url": "https://api.github.com/users/darakt/followers",
"following_url": "https://api.github.com/users/darakt/following{/other_user}",
"gists_url": "https://api.github.com/users/darakt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/darakt",
"id": 4517525,
"login": "darakt",
"node_id": "MDQ6VXNlcjQ1MTc1MjU=",
"organizations_url": "https://api.github.com/users/darakt/orgs",
"received_events_url": "https://api.github.com/users/darakt/received_events",
"repos_url": "https://api.github.com/users/darakt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/darakt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darakt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/darakt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-11-17T14:33:40Z | 2021-09-08T03:00:21Z | 2016-11-17T14:34:16Z | NONE | resolved | Hi,
I can't connect myself to an Apple server using requests.
I can connect myself to this same server using openssl directly or using socket directly
For instance, I'm doing that in such way with openssl
`openssl s_client -CAfile GeoTrust_Global_CA.pem -connect api.push.apple.com:443
`
My code is pretty basic:
`s = requests.session()
s.cert = "GeoTrust_Global_CA.pem"
s.port = 443
url = 'https://api.push.apple.com'
r = s.get(url)` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3702/reactions"
} | https://api.github.com/repos/psf/requests/issues/3702/timeline | null | completed | null | null | false | [
"@darakt You're using the `cert` argument, but you want to be using the `verify` argument.\n",
"`requests.get('url', verify=True)` is causing this issue for me."
] |
https://api.github.com/repos/psf/requests/issues/3701 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3701/labels{/name} | https://api.github.com/repos/psf/requests/issues/3701/comments | https://api.github.com/repos/psf/requests/issues/3701/events | https://github.com/psf/requests/issues/3701 | 190,039,361 | MDU6SXNzdWUxOTAwMzkzNjE= | 3,701 | AttributeError: 'X509' object has no attribute '_x509' | {
"avatar_url": "https://avatars.githubusercontent.com/u/633520?v=4",
"events_url": "https://api.github.com/users/sapran/events{/privacy}",
"followers_url": "https://api.github.com/users/sapran/followers",
"following_url": "https://api.github.com/users/sapran/following{/other_user}",
"gists_url": "https://api.github.com/users/sapran/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sapran",
"id": 633520,
"login": "sapran",
"node_id": "MDQ6VXNlcjYzMzUyMA==",
"organizations_url": "https://api.github.com/users/sapran/orgs",
"received_events_url": "https://api.github.com/users/sapran/received_events",
"repos_url": "https://api.github.com/users/sapran/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sapran/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sapran/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sapran",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 37 | 2016-11-17T12:54:24Z | 2021-09-03T00:10:46Z | 2016-11-25T10:09:22Z | NONE | resolved | While trying to use Slack API using slacker module that is based on Requests, I receive this SSL-related error:
```
Python 2.7.12 (default, Oct 11 2016, 05:24:00)
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.38)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from slacker import Slacker
>>> s=Slacker('<SLACK BOT API KEY>')
>>> s.chat.post_message('#general', 'test')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/site-packages/slacker/__init__.py", line 287, in post_message
'icon_emoji': icon_emoji
File "/usr/local/lib/python2.7/site-packages/slacker/__init__.py", line 71, in post
return self._request(requests.post, api, **kwargs)
File "/usr/local/lib/python2.7/site-packages/slacker/__init__.py", line 57, in _request
**kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 110, in post
return request('post', url, data=data, json=json, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 56, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 488, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 609, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/adapters.py", line 423, in send
timeout=timeout
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 594, in urlopen
chunked=chunked)
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 350, in _make_request
self._validate_conn(conn)
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 835, in _validate_conn
conn.connect()
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/connection.py", line 330, in connect
cert = self.sock.getpeercert()
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 324, in getpeercert
'subjectAltName': get_subj_alt_name(x509)
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 166, in get_subj_alt_name
cert = _Certificate(openssl_backend, peer_cert._x509)
AttributeError: 'X509' object has no attribute '_x509'
```
I see that other users experience this too: http://stackoverflow.com/questions/40628315/python-requests-and-streaming-attributeerror-x509-object-has-no-attribute
Downgrading from 2.12.1 to 2.11.1 removes the issue. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3701/reactions"
} | https://api.github.com/repos/psf/requests/issues/3701/timeline | null | completed | null | null | false | [
"What version of PyOpenSSL do you have installed?\n",
"Also could you include the version of cryptography you have installed?\n",
"```\nName: pyOpenSSL\nVersion: 16.2.0\nSummary: Python wrapper module around the OpenSSL library\nHome-page: https://pyopenssl.readthedocs.io/\nAuthor: Hynek Schlawack\nAuthor-email... |
https://api.github.com/repos/psf/requests/issues/3700 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3700/labels{/name} | https://api.github.com/repos/psf/requests/issues/3700/comments | https://api.github.com/repos/psf/requests/issues/3700/events | https://github.com/psf/requests/pull/3700 | 189,954,132 | MDExOlB1bGxSZXF1ZXN0OTQxMTA0MjU= | 3,700 | Adding 'import requests' to readme code snippet. | {
"avatar_url": "https://avatars.githubusercontent.com/u/3707038?v=4",
"events_url": "https://api.github.com/users/rmhasan/events{/privacy}",
"followers_url": "https://api.github.com/users/rmhasan/followers",
"following_url": "https://api.github.com/users/rmhasan/following{/other_user}",
"gists_url": "https://api.github.com/users/rmhasan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rmhasan",
"id": 3707038,
"login": "rmhasan",
"node_id": "MDQ6VXNlcjM3MDcwMzg=",
"organizations_url": "https://api.github.com/users/rmhasan/orgs",
"received_events_url": "https://api.github.com/users/rmhasan/received_events",
"repos_url": "https://api.github.com/users/rmhasan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rmhasan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rmhasan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rmhasan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-11-17T06:40:03Z | 2021-09-08T01:21:40Z | 2016-11-17T08:23:57Z | CONTRIBUTOR | resolved | The interpreter snippet at the top of the readme.rst is the first snippet of code that users will see for using requests. I think an import statement should be shown at the top of the code snippet, so a novice or even intermediate python user will know to import the module first before attempting to use it. It makes the snippet more complete. I've seen other github projects include the import statement in snippets like the one in the readme. I changed the doc/index.rst file for consistency, since they are the same code snippet. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3700/reactions"
} | https://api.github.com/repos/psf/requests/issues/3700/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3700.diff",
"html_url": "https://github.com/psf/requests/pull/3700",
"merged_at": "2016-11-17T08:23:57Z",
"patch_url": "https://github.com/psf/requests/pull/3700.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3700"
} | true | [
"For instance [tensorflow](https://github.com/tensorflow/tensorflow)'s readme has a similar code snippet and it has the import statement at the top of the code snippet. \n",
"Thanks for this!\n",
"undo\n",
"Hi @kennethreitz , I was wondering why my pull request got reverted.\n",
"I prefer it the way it is, ... |
https://api.github.com/repos/psf/requests/issues/3699 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3699/labels{/name} | https://api.github.com/repos/psf/requests/issues/3699/comments | https://api.github.com/repos/psf/requests/issues/3699/events | https://github.com/psf/requests/issues/3699 | 189,915,270 | MDU6SXNzdWUxODk5MTUyNzA= | 3,699 | Buggy servers with SNI give unrecognized_name | {
"avatar_url": "https://avatars.githubusercontent.com/u/13907452?v=4",
"events_url": "https://api.github.com/users/rudolphi/events{/privacy}",
"followers_url": "https://api.github.com/users/rudolphi/followers",
"following_url": "https://api.github.com/users/rudolphi/following{/other_user}",
"gists_url": "https://api.github.com/users/rudolphi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rudolphi",
"id": 13907452,
"login": "rudolphi",
"node_id": "MDQ6VXNlcjEzOTA3NDUy",
"organizations_url": "https://api.github.com/users/rudolphi/orgs",
"received_events_url": "https://api.github.com/users/rudolphi/received_events",
"repos_url": "https://api.github.com/users/rudolphi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rudolphi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rudolphi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rudolphi",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-11-17T02:20:11Z | 2021-09-08T14:00:33Z | 2016-11-17T08:34:58Z | NONE | resolved | When trying to open https://www.scbt.com with requests, an SSLError is raised, even though verify=False. Apache HttpClient has the same problem, but browsers open the page without any complaint. I was hoping requests would be more tolerant with such flawed servers, especially if the caller indicates that security is not of importance.
[stacktrace.txt](https://github.com/kennethreitz/requests/files/596393/stacktrace.txt)
Thanks!
Felix | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3699/reactions"
} | https://api.github.com/repos/psf/requests/issues/3699/timeline | null | completed | null | null | false | [
"Requests cannot be more tolerant of that server in the default configuration. The `unrecognized name` error you're seeing is an alert sent by the _remote server_: that is, our inability to set SNI means that the remote server is simply refusing to negotiate TLS with us. That means we cannot possibly be \"tolerant\... |
https://api.github.com/repos/psf/requests/issues/3698 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3698/labels{/name} | https://api.github.com/repos/psf/requests/issues/3698/comments | https://api.github.com/repos/psf/requests/issues/3698/events | https://github.com/psf/requests/issues/3698 | 189,821,447 | MDU6SXNzdWUxODk4MjE0NDc= | 3,698 | AttributeError: 'NoneType' object has no attribute 'read' | {
"avatar_url": "https://avatars.githubusercontent.com/u/6023916?v=4",
"events_url": "https://api.github.com/users/Makman2/events{/privacy}",
"followers_url": "https://api.github.com/users/Makman2/followers",
"following_url": "https://api.github.com/users/Makman2/following{/other_user}",
"gists_url": "https://api.github.com/users/Makman2/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Makman2",
"id": 6023916,
"login": "Makman2",
"node_id": "MDQ6VXNlcjYwMjM5MTY=",
"organizations_url": "https://api.github.com/users/Makman2/orgs",
"received_events_url": "https://api.github.com/users/Makman2/received_events",
"repos_url": "https://api.github.com/users/Makman2/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Makman2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Makman2/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Makman2",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2016-11-16T19:44:20Z | 2021-09-08T14:00:33Z | 2016-11-16T20:59:22Z | NONE | resolved | Hello :)
After a recent upgrade for our [coala](https://github.com/coala/coala) project to `requests` 2.12.1 we encounter an exception in our test suites which seems to be caused by `requests`.
Build: https://ci.appveyor.com/project/coala/coala-bears/build/1.0.3537/job/1wm7b4u9yhgkxkgn
Relevant part:
```
================================== FAILURES ===================================
_________________ InvalidLinkBearTest.test_redirect_threshold _________________
self = <tests.general.InvalidLinkBearTest.InvalidLinkBearTest testMethod=test_redirect_threshold>
def test_redirect_threshold(self):
long_url_redirect = """
https://bitbucket.org/api/301
https://bitbucket.org/api/302
""".splitlines()
short_url_redirect = """
http://httpbin.org/status/301
""".splitlines()
self.assertResult(valid_file=long_url_redirect,
invalid_file=short_url_redirect,
> settings={'follow_redirects': 'yeah'})
tests\general\InvalidLinkBearTest.py:157:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests\general\InvalidLinkBearTest.py:75: in assertResult
out = list(uut.run("valid", valid_file, **settings))
bears\general\InvalidLinkBear.py:80: in run
file, timeout, link_ignore_regex):
bears\general\InvalidLinkBear.py:53: in find_links_in_file
code = InvalidLinkBear.get_status_code(link, timeout)
bears\general\InvalidLinkBear.py:37: in get_status_code
timeout=timeout).status_code
C:\Python34\lib\site-packages\requests\api.py:96: in head
return request('head', url, **kwargs)
C:\Python34\lib\site-packages\requests\api.py:56: in request
return session.request(method=method, url=url, **kwargs)
C:\Python34\lib\site-packages\requests\sessions.py:488: in request
resp = self.send(prep, **send_kwargs)
C:\Python34\lib\site-packages\requests_mock\mocker.py:69: in _fake_send
return self._real_send(session, request, **kwargs)
C:\Python34\lib\site-packages\requests\sessions.py:641: in send
r.content
C:\Python34\lib\site-packages\requests\models.py:772: in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
def generate():
# Special case for urllib3.
if hasattr(self.raw, 'stream'):
try:
for chunk in self.raw.stream(chunk_size, decode_content=True):
yield chunk
except ProtocolError as e:
raise ChunkedEncodingError(e)
except DecodeError as e:
raise ContentDecodingError(e)
except ReadTimeoutError as e:
raise ConnectionError(e)
else:
# Standard file-like object.
while True:
> chunk = self.raw.read(chunk_size)
E AttributeError: 'NoneType' object has no attribute 'read'
C:\Python34\lib\site-packages\requests\models.py:705: AttributeError
```
happens on Windows and Linux.
Thanks in advance :) | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3698/reactions"
} | https://api.github.com/repos/psf/requests/issues/3698/timeline | null | completed | null | null | false | [
"@Makman2 it's not immediately obvious where the issue lies here. The specific traceback you're hitting is because the response value is None. I don't see any changes in the critical path for Requests since 2.11.1 that would affect this.\n\nI think it's possibly a gap in requests_mock that's not returning a valid r... |
https://api.github.com/repos/psf/requests/issues/3697 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3697/labels{/name} | https://api.github.com/repos/psf/requests/issues/3697/comments | https://api.github.com/repos/psf/requests/issues/3697/events | https://github.com/psf/requests/pull/3697 | 189,778,916 | MDExOlB1bGxSZXF1ZXN0OTQwMTEzNDE= | 3,697 | Fixed issue #3696. Added a test for it as well. | {
"avatar_url": "https://avatars.githubusercontent.com/u/2324958?v=4",
"events_url": "https://api.github.com/users/hussaintamboli/events{/privacy}",
"followers_url": "https://api.github.com/users/hussaintamboli/followers",
"following_url": "https://api.github.com/users/hussaintamboli/following{/other_user}",
"gists_url": "https://api.github.com/users/hussaintamboli/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hussaintamboli",
"id": 2324958,
"login": "hussaintamboli",
"node_id": "MDQ6VXNlcjIzMjQ5NTg=",
"organizations_url": "https://api.github.com/users/hussaintamboli/orgs",
"received_events_url": "https://api.github.com/users/hussaintamboli/received_events",
"repos_url": "https://api.github.com/users/hussaintamboli/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hussaintamboli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hussaintamboli/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hussaintamboli",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-11-16T17:23:30Z | 2021-09-08T01:21:41Z | 2016-11-16T18:32:59Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3697/reactions"
} | https://api.github.com/repos/psf/requests/issues/3697/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3697.diff",
"html_url": "https://github.com/psf/requests/pull/3697",
"merged_at": "2016-11-16T18:32:59Z",
"patch_url": "https://github.com/psf/requests/pull/3697.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3697"
} | true | [] | |
https://api.github.com/repos/psf/requests/issues/3696 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3696/labels{/name} | https://api.github.com/repos/psf/requests/issues/3696/comments | https://api.github.com/repos/psf/requests/issues/3696/events | https://github.com/psf/requests/issues/3696 | 189,751,036 | MDU6SXNzdWUxODk3NTEwMzY= | 3,696 | A whitespace at the start of Url causes error on request | {
"avatar_url": "https://avatars.githubusercontent.com/u/2324958?v=4",
"events_url": "https://api.github.com/users/hussaintamboli/events{/privacy}",
"followers_url": "https://api.github.com/users/hussaintamboli/followers",
"following_url": "https://api.github.com/users/hussaintamboli/following{/other_user}",
"gists_url": "https://api.github.com/users/hussaintamboli/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hussaintamboli",
"id": 2324958,
"login": "hussaintamboli",
"node_id": "MDQ6VXNlcjIzMjQ5NTg=",
"organizations_url": "https://api.github.com/users/hussaintamboli/orgs",
"received_events_url": "https://api.github.com/users/hussaintamboli/received_events",
"repos_url": "https://api.github.com/users/hussaintamboli/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hussaintamboli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hussaintamboli/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hussaintamboli",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"... | closed | true | null | [] | null | 4 | 2016-11-16T16:05:10Z | 2021-09-08T14:00:34Z | 2016-11-16T18:38:12Z | NONE | resolved | In [1]: import requests
In [2]: requests.get("http://stackoverflow.com/")
Out[2]: <Response [200]>
In [3]: requests.get(" http://stackoverflow.com/")
# ... stacktrace skipped ...
InvalidSchema: No connection adapters were found for ' http://stackoverflow.com/'
Url should have been stripped. But I may be missing something here. | {
"avatar_url": "https://avatars.githubusercontent.com/u/2324958?v=4",
"events_url": "https://api.github.com/users/hussaintamboli/events{/privacy}",
"followers_url": "https://api.github.com/users/hussaintamboli/followers",
"following_url": "https://api.github.com/users/hussaintamboli/following{/other_user}",
"gists_url": "https://api.github.com/users/hussaintamboli/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hussaintamboli",
"id": 2324958,
"login": "hussaintamboli",
"node_id": "MDQ6VXNlcjIzMjQ5NTg=",
"organizations_url": "https://api.github.com/users/hussaintamboli/orgs",
"received_events_url": "https://api.github.com/users/hussaintamboli/received_events",
"repos_url": "https://api.github.com/users/hussaintamboli/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hussaintamboli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hussaintamboli/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hussaintamboli",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3696/reactions"
} | https://api.github.com/repos/psf/requests/issues/3696/timeline | null | completed | null | null | false | [
"I'm open to a PR that will cause us to strip URLs, that seems reasonable enough to me.\n",
"Sure.\n",
"I have created a pull request #3697. Please have a look.\n",
"PR is merged. Closing it as it's fixed.\n"
] |
https://api.github.com/repos/psf/requests/issues/3695 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3695/labels{/name} | https://api.github.com/repos/psf/requests/issues/3695/comments | https://api.github.com/repos/psf/requests/issues/3695/events | https://github.com/psf/requests/pull/3695 | 189,702,776 | MDExOlB1bGxSZXF1ZXN0OTM5NjQ4MzA= | 3,695 | idna bypass | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2016-11-16T13:24:32Z | 2021-09-08T01:21:37Z | 2016-11-25T13:18:01Z | MEMBER | resolved | This addresses #3687 allowing URLs that are already idna encoded to pass through while everything else is still properly encoded. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3695/reactions"
} | https://api.github.com/repos/psf/requests/issues/3695/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3695.diff",
"html_url": "https://github.com/psf/requests/pull/3695",
"merged_at": "2016-11-25T13:18:01Z",
"patch_url": "https://github.com/psf/requests/pull/3695.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3695"
} | true | [
"Alright, all systems are nominal. 🚀\n",
"Comment updated, hopefully that's a bit closer.\n",
"Alright, ASCII check updated 😃 \n",
"OK, we're all moved over to _internal_utils.\n",
"> An alternative solution to this is to say that if the idna module fails to encode we'll just go ahead and try to encode as... |
https://api.github.com/repos/psf/requests/issues/3694 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3694/labels{/name} | https://api.github.com/repos/psf/requests/issues/3694/comments | https://api.github.com/repos/psf/requests/issues/3694/events | https://github.com/psf/requests/pull/3694 | 189,661,018 | MDExOlB1bGxSZXF1ZXN0OTM5Mzk5OTE= | 3,694 | Prepare 2.12.1 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-11-16T10:35:41Z | 2021-09-08T01:21:42Z | 2016-11-16T10:44:02Z | MEMBER | resolved | Let's ship a bugfix. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3694/reactions"
} | https://api.github.com/repos/psf/requests/issues/3694/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3694.diff",
"html_url": "https://github.com/psf/requests/pull/3694",
"merged_at": "2016-11-16T10:44:02Z",
"patch_url": "https://github.com/psf/requests/pull/3694.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3694"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/3693 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3693/labels{/name} | https://api.github.com/repos/psf/requests/issues/3693/comments | https://api.github.com/repos/psf/requests/issues/3693/events | https://github.com/psf/requests/pull/3693 | 189,660,216 | MDExOlB1bGxSZXF1ZXN0OTM5Mzk0NzQ= | 3,693 | Change setuptools extra for secure extra. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-16T10:32:25Z | 2021-09-08T01:21:42Z | 2016-11-16T10:33:48Z | MEMBER | resolved | Resolves #3689. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3693/reactions"
} | https://api.github.com/repos/psf/requests/issues/3693/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3693.diff",
"html_url": "https://github.com/psf/requests/pull/3693",
"merged_at": "2016-11-16T10:33:47Z",
"patch_url": "https://github.com/psf/requests/pull/3693.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3693"
} | true | [
"I took this version count from urllib3, which seems like a sensible lead to follow here.\n"
] |
https://api.github.com/repos/psf/requests/issues/3692 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3692/labels{/name} | https://api.github.com/repos/psf/requests/issues/3692/comments | https://api.github.com/repos/psf/requests/issues/3692/events | https://github.com/psf/requests/issues/3692 | 189,579,747 | MDU6SXNzdWUxODk1Nzk3NDc= | 3,692 | Long timeout | {
"avatar_url": "https://avatars.githubusercontent.com/u/1137549?v=4",
"events_url": "https://api.github.com/users/looping84/events{/privacy}",
"followers_url": "https://api.github.com/users/looping84/followers",
"following_url": "https://api.github.com/users/looping84/following{/other_user}",
"gists_url": "https://api.github.com/users/looping84/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/looping84",
"id": 1137549,
"login": "looping84",
"node_id": "MDQ6VXNlcjExMzc1NDk=",
"organizations_url": "https://api.github.com/users/looping84/orgs",
"received_events_url": "https://api.github.com/users/looping84/received_events",
"repos_url": "https://api.github.com/users/looping84/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/looping84/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/looping84/subscriptions",
"type": "User",
"url": "https://api.github.com/users/looping84",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-16T04:00:55Z | 2021-09-08T14:00:35Z | 2016-11-16T08:43:49Z | NONE | resolved | I need check my service is ok or not。 sometimes it will breakdown.
### how to reproduce the issue
```
try:
r = requests.get("http://xxx.com/",timeout=1)
print(r.status_code)
except requests.exceptions.Timeout:
print 'timeout'
except requests.exceptions.RequestException as e:
print(e)
```
it always let me wait for 30 seconds
`I hope it only waits one second, if server doesn't response or the link is unreachable, throw exception`
below are exception message
> Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x3d344d0>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',))
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3692/reactions"
} | https://api.github.com/repos/psf/requests/issues/3692/timeline | null | completed | null | null | false | [
"The requests timeout parameter is _per connection_, and Requests will make as many connection attempts as there are domain names. However, Requests cannot control the timeout of the DNS lookup, which is the problem here. Unfortunately, Python doesn't allow us any way around this problem: there is just no cross-pla... |
https://api.github.com/repos/psf/requests/issues/3691 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3691/labels{/name} | https://api.github.com/repos/psf/requests/issues/3691/comments | https://api.github.com/repos/psf/requests/issues/3691/events | https://github.com/psf/requests/pull/3691 | 189,574,777 | MDExOlB1bGxSZXF1ZXN0OTM4OTU3MDM= | 3,691 | Fixes small readme typo - site => domain | {
"avatar_url": "https://avatars.githubusercontent.com/u/3649914?v=4",
"events_url": "https://api.github.com/users/Cleod9/events{/privacy}",
"followers_url": "https://api.github.com/users/Cleod9/followers",
"following_url": "https://api.github.com/users/Cleod9/following{/other_user}",
"gists_url": "https://api.github.com/users/Cleod9/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Cleod9",
"id": 3649914,
"login": "Cleod9",
"node_id": "MDQ6VXNlcjM2NDk5MTQ=",
"organizations_url": "https://api.github.com/users/Cleod9/orgs",
"received_events_url": "https://api.github.com/users/Cleod9/received_events",
"repos_url": "https://api.github.com/users/Cleod9/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Cleod9/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Cleod9/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Cleod9",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-11-16T03:32:19Z | 2021-09-08T01:21:42Z | 2016-11-16T08:39:06Z | CONTRIBUTOR | resolved | Fixed readme typo - 'site' should be 'domain' | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3691/reactions"
} | https://api.github.com/repos/psf/requests/issues/3691/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3691.diff",
"html_url": "https://github.com/psf/requests/pull/3691",
"merged_at": "2016-11-16T08:39:06Z",
"patch_url": "https://github.com/psf/requests/pull/3691.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3691"
} | true | [
"Referencing: https://github.com/kennethreitz/requests/issues/3672\n",
"Thanks @Cleod9! :sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/3690 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3690/labels{/name} | https://api.github.com/repos/psf/requests/issues/3690/comments | https://api.github.com/repos/psf/requests/issues/3690/events | https://github.com/psf/requests/pull/3690 | 189,570,357 | MDExOlB1bGxSZXF1ZXN0OTM4OTM1ODE= | 3,690 | Clarify allow_redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/3253863?v=4",
"events_url": "https://api.github.com/users/galgeek/events{/privacy}",
"followers_url": "https://api.github.com/users/galgeek/followers",
"following_url": "https://api.github.com/users/galgeek/following{/other_user}",
"gists_url": "https://api.github.com/users/galgeek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/galgeek",
"id": 3253863,
"login": "galgeek",
"node_id": "MDQ6VXNlcjMyNTM4NjM=",
"organizations_url": "https://api.github.com/users/galgeek/orgs",
"received_events_url": "https://api.github.com/users/galgeek/received_events",
"repos_url": "https://api.github.com/users/galgeek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/galgeek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galgeek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/galgeek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-11-16T03:05:08Z | 2021-09-08T01:21:43Z | 2016-11-16T08:38:33Z | CONTRIBUTOR | resolved | Make consistent with quickstart doc.
_If_ true, this would be better:
:param allow_redirects: (optional) Boolean. Whether redirects will be followed. Defaults to False for HEAD requests, True for all other methods. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3690/reactions"
} | https://api.github.com/repos/psf/requests/issues/3690/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3690.diff",
"html_url": "https://github.com/psf/requests/pull/3690",
"merged_at": "2016-11-16T08:38:33Z",
"patch_url": "https://github.com/psf/requests/pull/3690.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3690"
} | true | [
"Thanks @galgeek!\n",
":sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/3689 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3689/labels{/name} | https://api.github.com/repos/psf/requests/issues/3689/comments | https://api.github.com/repos/psf/requests/issues/3689/events | https://github.com/psf/requests/issues/3689 | 189,553,499 | MDU6SXNzdWUxODk1NTM0OTk= | 3,689 | security extras need to be updated | {
"avatar_url": "https://avatars.githubusercontent.com/u/6504915?v=4",
"events_url": "https://api.github.com/users/bmw/events{/privacy}",
"followers_url": "https://api.github.com/users/bmw/followers",
"following_url": "https://api.github.com/users/bmw/following{/other_user}",
"gists_url": "https://api.github.com/users/bmw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bmw",
"id": 6504915,
"login": "bmw",
"node_id": "MDQ6VXNlcjY1MDQ5MTU=",
"organizations_url": "https://api.github.com/users/bmw/orgs",
"received_events_url": "https://api.github.com/users/bmw/received_events",
"repos_url": "https://api.github.com/users/bmw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bmw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bmw",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"... | closed | true | null | [] | null | 2 | 2016-11-16T01:03:01Z | 2021-09-08T14:00:35Z | 2016-11-16T10:33:47Z | NONE | resolved | Starting with `urllib3` 1.17, `ndg-httpsclient` and `pyasn1` are no longer required to inject `pyopenssl` into `urllib3`. `cryptography` and `idna` are required instead. The result of this is if an older version of `pyopenssl` is installed and you run `pip install requests[security]`, you will see import errors when trying to inject `pyopenssl`. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3689/reactions"
} | https://api.github.com/repos/psf/requests/issues/3689/timeline | null | completed | null | null | false | [
"Yup, you're entirely correct.\n",
"Given that we're shipping a patch release, I may just fix this myself and ship it today.\n"
] |
https://api.github.com/repos/psf/requests/issues/3688 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3688/labels{/name} | https://api.github.com/repos/psf/requests/issues/3688/comments | https://api.github.com/repos/psf/requests/issues/3688/events | https://github.com/psf/requests/pull/3688 | 189,495,375 | MDExOlB1bGxSZXF1ZXN0OTM4Mzk5Mjg= | 3,688 | spelling fix for release-process.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-15T20:16:59Z | 2021-09-08T01:21:43Z | 2016-11-15T20:30:21Z | MEMBER | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3688/reactions"
} | https://api.github.com/repos/psf/requests/issues/3688/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3688.diff",
"html_url": "https://github.com/psf/requests/pull/3688",
"merged_at": "2016-11-15T20:30:21Z",
"patch_url": "https://github.com/psf/requests/pull/3688.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3688"
} | true | [
"Thanks @nateprewitt! :sparkles: :cake: :sparkles:\n"
] | |
https://api.github.com/repos/psf/requests/issues/3687 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3687/labels{/name} | https://api.github.com/repos/psf/requests/issues/3687/comments | https://api.github.com/repos/psf/requests/issues/3687/events | https://github.com/psf/requests/issues/3687 | 189,487,689 | MDU6SXNzdWUxODk0ODc2ODk= | 3,687 | because of idna2008 enforcement some real urls that work in the browser are now broken | {
"avatar_url": "https://avatars.githubusercontent.com/u/423176?v=4",
"events_url": "https://api.github.com/users/nlevitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nlevitt/followers",
"following_url": "https://api.github.com/users/nlevitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nlevitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nlevitt",
"id": 423176,
"login": "nlevitt",
"node_id": "MDQ6VXNlcjQyMzE3Ng==",
"organizations_url": "https://api.github.com/users/nlevitt/orgs",
"received_events_url": "https://api.github.com/users/nlevitt/received_events",
"repos_url": "https://api.github.com/users/nlevitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nlevitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nlevitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nlevitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 13 | 2016-11-15T19:46:09Z | 2021-09-25T06:00:18Z | 2016-11-30T15:07:36Z | NONE | resolved | Because of idna2008 enforcement 2.12.0 some real urls that work in the browser are now broken.
For example:
http://☃.net/
http://xn--n3h.net/
My suggestion would be to try idna2008 first, catch exception, then try idna2003.
```
>>> requests.get('http://xn--n3h.net/')
Traceback (most recent call last):
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/models.py", line 370, in prepare_url
host = idna.encode(host, uts46=True).decode('utf-8')
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/packages/idna/core.py", line 355, in encode
result.append(alabel(label))
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/packages/idna/core.py", line 276, in alabel
check_label(label)
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/packages/idna/core.py", line 253, in check_label
raise InvalidCodepoint('Codepoint {0} at position {1} of {2} not allowed'.format(_unot(cp_value), pos+1, repr(label)))
requests.packages.idna.core.InvalidCodepoint: Codepoint U+0027 at position 2 of "b'xn--n3h'" not allowed
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/api.py", line 70, in get
return request('get', url, params=params, **kwargs)
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/api.py", line 56, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/sessions.py", line 474, in request
prep = self.prepare_request(req)
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/sessions.py", line 407, in prepare_request
hooks=merge_hooks(request.hooks, self.hooks),
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/models.py", line 302, in prepare
self.prepare_url(url, params)
File "/Users/nlevitt/workspace/warcprox/warcprox-ve35/lib/python3.5/site-packages/requests/models.py", line 372, in prepare_url
raise InvalidURL('URL has an invalid label.')
requests.exceptions.InvalidURL: URL has an invalid label.
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 4,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 4,
"url": "https://api.github.com/repos/psf/requests/issues/3687/reactions"
} | https://api.github.com/repos/psf/requests/issues/3687/timeline | null | completed | null | null | false | [
"Thanks for this report!\n\nUltimately, I'm not sure I agree. Fundamentally, those URIs will stop working at some point as browsers move over to IDNA 2008. They _will_ have to move over time in at least some cases, because the `.de` domain mandates it, so there's no alternative there. So I have no objection to havi... |
https://api.github.com/repos/psf/requests/issues/3686 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3686/labels{/name} | https://api.github.com/repos/psf/requests/issues/3686/comments | https://api.github.com/repos/psf/requests/issues/3686/events | https://github.com/psf/requests/issues/3686 | 189,475,881 | MDU6SXNzdWUxODk0NzU4ODE= | 3,686 | v2.12.0: URL has an invalid label error | {
"avatar_url": "https://avatars.githubusercontent.com/u/4811329?v=4",
"events_url": "https://api.github.com/users/sfedr/events{/privacy}",
"followers_url": "https://api.github.com/users/sfedr/followers",
"following_url": "https://api.github.com/users/sfedr/following{/other_user}",
"gists_url": "https://api.github.com/users/sfedr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sfedr",
"id": 4811329,
"login": "sfedr",
"node_id": "MDQ6VXNlcjQ4MTEzMjk=",
"organizations_url": "https://api.github.com/users/sfedr/orgs",
"received_events_url": "https://api.github.com/users/sfedr/received_events",
"repos_url": "https://api.github.com/users/sfedr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sfedr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sfedr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sfedr",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-11-15T18:55:40Z | 2021-09-08T14:00:36Z | 2016-11-15T19:06:40Z | NONE | resolved | When url contains an underscore the request fails with 'URL has an invalid label error'
Seems like a result of updating to urllib3 to 1.19.
While underscores in the hostname would not meet strict RFC requirements it would still work in many scenarios, so I would propose to remove the check
Example:
```
requests.get('http://test_t')
*** InvalidURL: URL has an invalid label.
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3686/reactions"
} | https://api.github.com/repos/psf/requests/issues/3686/timeline | null | completed | null | null | false | [
"Thanks for opening this issue, @afaicode. This is currently being tracked in #3683 which will be the official issue for further discussion. I believe @Lukasa has stated underscores in host names are not behaviour we likely want to support, but you're welcome to raise objections in the appropriate issue.\n",
"Yup... |
https://api.github.com/repos/psf/requests/issues/3685 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3685/labels{/name} | https://api.github.com/repos/psf/requests/issues/3685/comments | https://api.github.com/repos/psf/requests/issues/3685/events | https://github.com/psf/requests/issues/3685 | 189,470,909 | MDU6SXNzdWUxODk0NzA5MDk= | 3,685 | ImportError no module named urlparse | {
"avatar_url": "https://avatars.githubusercontent.com/u/308610?v=4",
"events_url": "https://api.github.com/users/jaraco/events{/privacy}",
"followers_url": "https://api.github.com/users/jaraco/followers",
"following_url": "https://api.github.com/users/jaraco/following{/other_user}",
"gists_url": "https://api.github.com/users/jaraco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaraco",
"id": 308610,
"login": "jaraco",
"node_id": "MDQ6VXNlcjMwODYxMA==",
"organizations_url": "https://api.github.com/users/jaraco/orgs",
"received_events_url": "https://api.github.com/users/jaraco/received_events",
"repos_url": "https://api.github.com/users/jaraco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaraco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaraco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaraco",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2016-11-15T18:33:58Z | 2021-09-08T14:00:34Z | 2016-11-15T19:08:51Z | CONTRIBUTOR | resolved | In #3682, @leth reported an error which I've just encountered:
```
$ python -m rwt requests -- -c "from requests.packages.urllib3.contrib import appengine as gaecontrib"
Collecting requests
Using cached requests-2.12.0-py2.py3-none-any.whl
Installing collected packages: requests
Successfully installed requests-2.12.0
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/var/folders/c6/v7hnmq453xb6p2dbz1gqc6rr0000gn/T/rwt-pu44a5vi/requests/packages/urllib3/contrib/appengine.py", line 45, in <module>
from urlparse import urljoin
ModuleNotFoundError: No module named 'urlparse'
```
Because the source of #3682 appears to be unrelated to this Python 3 only bug, I'm opening a new issue.
I have the same issue as leth, and requests_toolbelt is unusable due to this bug. I don't think I can wait for due time to pass. Should requests_toolbelt be trapping this exception? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3685/reactions"
} | https://api.github.com/repos/psf/requests/issues/3685/timeline | null | completed | null | null | false | [
"@jaraco I believe what you're seeing is shazow/urllib3#1025. It has been patched on master for urllib3 but was caught after 1.19 released. This may be enough of an issue to warrant bumping urllib3 to 1.19.1 and adding it to a 2.12.1 release? Until then, you'll likely need to use 2.11.1 unless @sigmavirus24 has a s... |
https://api.github.com/repos/psf/requests/issues/3684 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3684/labels{/name} | https://api.github.com/repos/psf/requests/issues/3684/comments | https://api.github.com/repos/psf/requests/issues/3684/events | https://github.com/psf/requests/pull/3684 | 189,460,707 | MDExOlB1bGxSZXF1ZXN0OTM4MTQ5NzM= | 3,684 | Add method to url tests | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-15T17:50:02Z | 2021-09-08T01:21:44Z | 2016-11-15T17:51:42Z | MEMBER | resolved | Looks like we forgot methods in the tests for #3620 😉
Proposed/3.0.0 is having a tantrum because we started checking for a non-None method there. We should probably get ahead of that and just patch it on master now though. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3684/reactions"
} | https://api.github.com/repos/psf/requests/issues/3684/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3684.diff",
"html_url": "https://github.com/psf/requests/pull/3684",
"merged_at": "2016-11-15T17:51:42Z",
"patch_url": "https://github.com/psf/requests/pull/3684.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3684"
} | true | [
"Thanks @nateprewitt!\n"
] |
https://api.github.com/repos/psf/requests/issues/3683 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3683/labels{/name} | https://api.github.com/repos/psf/requests/issues/3683/comments | https://api.github.com/repos/psf/requests/issues/3683/events | https://github.com/psf/requests/issues/3683 | 189,411,935 | MDU6SXNzdWUxODk0MTE5MzU= | 3,683 | URL has an invalid label. | {
"avatar_url": "https://avatars.githubusercontent.com/u/118285?v=4",
"events_url": "https://api.github.com/users/MikeVL/events{/privacy}",
"followers_url": "https://api.github.com/users/MikeVL/followers",
"following_url": "https://api.github.com/users/MikeVL/following{/other_user}",
"gists_url": "https://api.github.com/users/MikeVL/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/MikeVL",
"id": 118285,
"login": "MikeVL",
"node_id": "MDQ6VXNlcjExODI4NQ==",
"organizations_url": "https://api.github.com/users/MikeVL/orgs",
"received_events_url": "https://api.github.com/users/MikeVL/received_events",
"repos_url": "https://api.github.com/users/MikeVL/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/MikeVL/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MikeVL/subscriptions",
"type": "User",
"url": "https://api.github.com/users/MikeVL",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
}
] | closed | true | null | [] | null | 29 | 2016-11-15T14:50:57Z | 2016-11-30T15:07:22Z | 2016-11-30T15:07:22Z | NONE | null | requests v2.12.0
```python
>>> import requests
>>> requests.get('http://vluki_develop_624_solr:8983/solr/vluki')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 70, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 56, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 474, in request
prep = self.prepare_request(req)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 407, in prepare_request
hooks=merge_hooks(request.hooks, self.hooks),
File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 302, in prepare
self.prepare_url(url, params)
File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 372, in prepare_url
raise InvalidURL('URL has an invalid label.')
requests.exceptions.InvalidURL: URL has an invalid label.
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3683/reactions"
} | https://api.github.com/repos/psf/requests/issues/3683/timeline | null | completed | null | null | false | [
"So this is arguably an increase in strictness thanks to our new idna library, but underscores are _not_ allowed in hostnames. See kjd/idna#17 for more. While this previously worked, I suspect that really it shouldn't have. Underscores are perfectly allowed in _DNS_, which is why this never encountered a problem pr... |
https://api.github.com/repos/psf/requests/issues/3682 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3682/labels{/name} | https://api.github.com/repos/psf/requests/issues/3682/comments | https://api.github.com/repos/psf/requests/issues/3682/events | https://github.com/psf/requests/issues/3682 | 189,298,636 | MDU6SXNzdWUxODkyOTg2MzY= | 3,682 | ImportError | {
"avatar_url": "https://avatars.githubusercontent.com/u/22092607?v=4",
"events_url": "https://api.github.com/users/moyotar/events{/privacy}",
"followers_url": "https://api.github.com/users/moyotar/followers",
"following_url": "https://api.github.com/users/moyotar/following{/other_user}",
"gists_url": "https://api.github.com/users/moyotar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/moyotar",
"id": 22092607,
"login": "moyotar",
"node_id": "MDQ6VXNlcjIyMDkyNjA3",
"organizations_url": "https://api.github.com/users/moyotar/orgs",
"received_events_url": "https://api.github.com/users/moyotar/received_events",
"repos_url": "https://api.github.com/users/moyotar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/moyotar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/moyotar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/moyotar",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 21 | 2016-11-15T04:42:02Z | 2021-09-08T14:00:31Z | 2016-11-16T18:35:44Z | NONE | resolved | 
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3682/reactions"
} | https://api.github.com/repos/psf/requests/issues/3682/timeline | null | completed | null | null | false | [
"This looks like you have had a problem with your installation. Where did you install requests from?\n",
"I'm seeing a potentially similar error on python 3; I believe it comes from https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/contrib/appengine.py#L45\n\nNote the double traceback... |
https://api.github.com/repos/psf/requests/issues/3681 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3681/labels{/name} | https://api.github.com/repos/psf/requests/issues/3681/comments | https://api.github.com/repos/psf/requests/issues/3681/events | https://github.com/psf/requests/issues/3681 | 189,278,493 | MDU6SXNzdWUxODkyNzg0OTM= | 3,681 | NewConnectionError [Errno 10060] | {
"avatar_url": "https://avatars.githubusercontent.com/u/15278783?v=4",
"events_url": "https://api.github.com/users/LancelotHolmes/events{/privacy}",
"followers_url": "https://api.github.com/users/LancelotHolmes/followers",
"following_url": "https://api.github.com/users/LancelotHolmes/following{/other_user}",
"gists_url": "https://api.github.com/users/LancelotHolmes/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/LancelotHolmes",
"id": 15278783,
"login": "LancelotHolmes",
"node_id": "MDQ6VXNlcjE1Mjc4Nzgz",
"organizations_url": "https://api.github.com/users/LancelotHolmes/orgs",
"received_events_url": "https://api.github.com/users/LancelotHolmes/received_events",
"repos_url": "https://api.github.com/users/LancelotHolmes/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/LancelotHolmes/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/LancelotHolmes/subscriptions",
"type": "User",
"url": "https://api.github.com/users/LancelotHolmes",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-11-15T01:54:52Z | 2021-09-08T11:00:30Z | 2016-11-30T15:07:45Z | NONE | resolved | I tried to use the `Geocoding API` of goole maps to convert the address to coordinates, but it failed which seems to be related to `requests` when I tried the sample code like:
```
gmaps=googlemaps.Client(key='MY_KEY')
geocode_result=gmaps.geocode('1600 Amphitheatre Parkway, Mountain View, CA')
print geocode_result
```
but I got an exception like
```
googlemaps.exceptions.TransportError: HTTPSConnectionPool(host='maps.googleapis.com', port=443): Max retries exceeded with url: /maps/api/geocode/json?address=1600+Amphitheatre+Parkway%2C+Mountain+View%2C+CA&key=AIzaSyBYdEWfcUNHUP3zLtc17nX-3aE4uPUkFnY (Caused by NewConnectionError('<requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x0000000016239278>: Failed to establish a new connection: [Errno 10060] ',))
```
BTW, I am work on PyCharm with python version 2.7.12 and I am using a VPN, I wonder if it's related to this.
Any help is appreciated, thanks in advance.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3681/reactions"
} | https://api.github.com/repos/psf/requests/issues/3681/timeline | null | completed | null | null | false | [
"This is almost certainly related to your networking setup. Essentially, \"failed to establish a new connection\" is telling you that we weren't able to connect to `maps.googleapis.com`. Exactly why and how to fix it is a different matter: there are lots of possible problems here.\n\nWhat kind of VPN are you using?... |
https://api.github.com/repos/psf/requests/issues/3680 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3680/labels{/name} | https://api.github.com/repos/psf/requests/issues/3680/comments | https://api.github.com/repos/psf/requests/issues/3680/events | https://github.com/psf/requests/pull/3680 | 189,245,462 | MDExOlB1bGxSZXF1ZXN0OTM2NjIxNjU= | 3,680 | Create companies adresses Google + | {
"avatar_url": "https://avatars.githubusercontent.com/u/20781829?v=4",
"events_url": "https://api.github.com/users/ClemHermann/events{/privacy}",
"followers_url": "https://api.github.com/users/ClemHermann/followers",
"following_url": "https://api.github.com/users/ClemHermann/following{/other_user}",
"gists_url": "https://api.github.com/users/ClemHermann/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ClemHermann",
"id": 20781829,
"login": "ClemHermann",
"node_id": "MDQ6VXNlcjIwNzgxODI5",
"organizations_url": "https://api.github.com/users/ClemHermann/orgs",
"received_events_url": "https://api.github.com/users/ClemHermann/received_events",
"repos_url": "https://api.github.com/users/ClemHermann/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ClemHermann/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ClemHermann/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ClemHermann",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-14T22:32:18Z | 2021-09-08T01:21:45Z | 2016-11-14T22:50:13Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3680/reactions"
} | https://api.github.com/repos/psf/requests/issues/3680/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3680.diff",
"html_url": "https://github.com/psf/requests/pull/3680",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3680.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3680"
} | true | [
"No thank you\n"
] | |
https://api.github.com/repos/psf/requests/issues/3679 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3679/labels{/name} | https://api.github.com/repos/psf/requests/issues/3679/comments | https://api.github.com/repos/psf/requests/issues/3679/events | https://github.com/psf/requests/pull/3679 | 189,181,213 | MDExOlB1bGxSZXF1ZXN0OTM2MTU3MTY= | 3,679 | Amplifies the timeout warning in the docs. | {
"avatar_url": "https://avatars.githubusercontent.com/u/236970?v=4",
"events_url": "https://api.github.com/users/mlissner/events{/privacy}",
"followers_url": "https://api.github.com/users/mlissner/followers",
"following_url": "https://api.github.com/users/mlissner/following{/other_user}",
"gists_url": "https://api.github.com/users/mlissner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mlissner",
"id": 236970,
"login": "mlissner",
"node_id": "MDQ6VXNlcjIzNjk3MA==",
"organizations_url": "https://api.github.com/users/mlissner/orgs",
"received_events_url": "https://api.github.com/users/mlissner/received_events",
"repos_url": "https://api.github.com/users/mlissner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mlissner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mlissner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mlissner",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-11-14T17:57:40Z | 2021-09-08T01:21:46Z | 2016-11-14T17:58:13Z | CONTRIBUTOR | resolved | Partially addresses #3070 until a fix can come in the next major version. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3679/reactions"
} | https://api.github.com/repos/psf/requests/issues/3679/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3679.diff",
"html_url": "https://github.com/psf/requests/pull/3679",
"merged_at": "2016-11-14T17:58:13Z",
"patch_url": "https://github.com/psf/requests/pull/3679.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3679"
} | true | [
"Thanks @mlissner! :sparkles:\n",
"Sorry, I don't mean to be a squeaky wheel. Isn't this already stated two sentences later? We may want to delete one so we're not saying the same thing twice.\n\n> If no timeout is specified explicitly, requests do not time out.\n",
"I don't think I mind the duplication here: t... |
https://api.github.com/repos/psf/requests/issues/3678 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3678/labels{/name} | https://api.github.com/repos/psf/requests/issues/3678/comments | https://api.github.com/repos/psf/requests/issues/3678/events | https://github.com/psf/requests/pull/3678 | 189,165,209 | MDExOlB1bGxSZXF1ZXN0OTM2MDQwMjQ= | 3,678 | decoding fix for Streaming Requests docs | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-14T16:54:19Z | 2021-09-08T01:21:46Z | 2016-11-14T16:55:33Z | MEMBER | resolved | This will address #3675 with 71b8941. I've added an additional commit (d81ad06) noting a suggested best practice of providing an encoding fallback when using the `decode_unicode` parameter. This is an optional improvement that I can strip if we only want the bare bones fix. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3678/reactions"
} | https://api.github.com/repos/psf/requests/issues/3678/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3678.diff",
"html_url": "https://github.com/psf/requests/pull/3678",
"merged_at": "2016-11-14T16:55:33Z",
"patch_url": "https://github.com/psf/requests/pull/3678.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3678"
} | true | [
"LGTM, let's do this! Thanks @nateprewitt! :sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/3677 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3677/labels{/name} | https://api.github.com/repos/psf/requests/issues/3677/comments | https://api.github.com/repos/psf/requests/issues/3677/events | https://github.com/psf/requests/issues/3677 | 189,142,113 | MDU6SXNzdWUxODkxNDIxMTM= | 3,677 | [Errno -3] Temporary failure in name resolution | {
"avatar_url": "https://avatars.githubusercontent.com/u/10743049?v=4",
"events_url": "https://api.github.com/users/kalyanakannan/events{/privacy}",
"followers_url": "https://api.github.com/users/kalyanakannan/followers",
"following_url": "https://api.github.com/users/kalyanakannan/following{/other_user}",
"gists_url": "https://api.github.com/users/kalyanakannan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kalyanakannan",
"id": 10743049,
"login": "kalyanakannan",
"node_id": "MDQ6VXNlcjEwNzQzMDQ5",
"organizations_url": "https://api.github.com/users/kalyanakannan/orgs",
"received_events_url": "https://api.github.com/users/kalyanakannan/received_events",
"repos_url": "https://api.github.com/users/kalyanakannan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kalyanakannan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kalyanakannan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kalyanakannan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 13 | 2016-11-14T15:31:19Z | 2018-10-06T23:25:16Z | 2016-11-14T15:31:57Z | NONE | resolved | While trying to get access token from api I getting the follwoing error,
ConnectionError: HTTPSConnectionPool(host='', port=443): Max retries exceeded with url: /oauth2/access_token/ (Caused by <class 'socket.gaierror'>: [Errno -3] Temporary failure in name resolution)
Is there any way I can resolve this error?
Thanks.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3677/reactions"
} | https://api.github.com/repos/psf/requests/issues/3677/timeline | null | completed | null | null | false | [
"This error means that a DNS problem occurred and we couldn't resolve the IP address. If you see this problem you should simply retry the request.\n",
"Already I have tried that, but it's not working for me. Shall I try with IP address Or is there any other solution for this?\n",
"Can you print the URL you're t... |
https://api.github.com/repos/psf/requests/issues/3676 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3676/labels{/name} | https://api.github.com/repos/psf/requests/issues/3676/comments | https://api.github.com/repos/psf/requests/issues/3676/events | https://github.com/psf/requests/issues/3676 | 189,112,748 | MDU6SXNzdWUxODkxMTI3NDg= | 3,676 | SOCKS DNS lookup isn't through proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/1687787?v=4",
"events_url": "https://api.github.com/users/owenson/events{/privacy}",
"followers_url": "https://api.github.com/users/owenson/followers",
"following_url": "https://api.github.com/users/owenson/following{/other_user}",
"gists_url": "https://api.github.com/users/owenson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/owenson",
"id": 1687787,
"login": "owenson",
"node_id": "MDQ6VXNlcjE2ODc3ODc=",
"organizations_url": "https://api.github.com/users/owenson/orgs",
"received_events_url": "https://api.github.com/users/owenson/received_events",
"repos_url": "https://api.github.com/users/owenson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/owenson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/owenson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/owenson",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-14T13:31:04Z | 2021-09-08T14:00:38Z | 2016-11-14T13:31:43Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1687787?v=4",
"events_url": "https://api.github.com/users/owenson/events{/privacy}",
"followers_url": "https://api.github.com/users/owenson/followers",
"following_url": "https://api.github.com/users/owenson/following{/other_user}",
"gists_url": "https://api.github.com/users/owenson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/owenson",
"id": 1687787,
"login": "owenson",
"node_id": "MDQ6VXNlcjE2ODc3ODc=",
"organizations_url": "https://api.github.com/users/owenson/orgs",
"received_events_url": "https://api.github.com/users/owenson/received_events",
"repos_url": "https://api.github.com/users/owenson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/owenson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/owenson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/owenson",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3676/reactions"
} | https://api.github.com/repos/psf/requests/issues/3676/timeline | null | completed | null | null | false | [
"closed\n"
] | |
https://api.github.com/repos/psf/requests/issues/3675 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3675/labels{/name} | https://api.github.com/repos/psf/requests/issues/3675/comments | https://api.github.com/repos/psf/requests/issues/3675/events | https://github.com/psf/requests/issues/3675 | 188,939,913 | MDU6SXNzdWUxODg5Mzk5MTM= | 3,675 | Streaming Requests documentation error for Python 3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-11-12T22:59:34Z | 2021-09-08T14:00:37Z | 2016-11-14T16:56:48Z | MEMBER | resolved | The [documentation](http://docs.python-requests.org/en/master/user/advanced/#streaming-requests) for streaming requests supplies a code snippet (below) that hits #3359 which is also experienced in `iter_lines` due to its use of `iter_content`.
```python
r = requests.get('http://httpbin.org/stream/20', stream=True)
for line in r.iter_lines():
if line:
print(json.loads(line))
```
Since `iter_lines` default is `decode_unicode=False`, it returns bytes causing Python 3 to barf on `json.loads(lines)`. Unfortunately, `decode_unicode=True` doesn't work either because httpbin.org doesn't provide a charset in the Content-Type header.
As for fixing the example, we can manually decode `line` before passing it into json.loads. This exposes some of our dirty laundry though, and may give the user the wrong idea that they need to manually decode their strings in all cases.
Alternatively, we update httpbin to pass a charset with the Content-Type and change the example to use `decode_unicode=True`.
Edit: Moving semi-related comment to appropriate issue. (#3359) | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3675/reactions"
} | https://api.github.com/repos/psf/requests/issues/3675/timeline | null | completed | null | null | false | [
"I view this as strictly a Python 2 vs Python 3 problem, rather than a problem with `iter_lines`. `iter_lines` returns bytes by default, that's a good sensible default, so we should just decode those bytes ourselves.\n",
"Alright, I'll update the example accordingly.\n",
"Resolved with #3678.\n"
] |
https://api.github.com/repos/psf/requests/issues/3674 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3674/labels{/name} | https://api.github.com/repos/psf/requests/issues/3674/comments | https://api.github.com/repos/psf/requests/issues/3674/events | https://github.com/psf/requests/issues/3674 | 188,913,080 | MDU6SXNzdWUxODg5MTMwODA= | 3,674 | Requests does not support session key logging | {
"avatar_url": "https://avatars.githubusercontent.com/u/5154337?v=4",
"events_url": "https://api.github.com/users/wittrup/events{/privacy}",
"followers_url": "https://api.github.com/users/wittrup/followers",
"following_url": "https://api.github.com/users/wittrup/following{/other_user}",
"gists_url": "https://api.github.com/users/wittrup/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wittrup",
"id": 5154337,
"login": "wittrup",
"node_id": "MDQ6VXNlcjUxNTQzMzc=",
"organizations_url": "https://api.github.com/users/wittrup/orgs",
"received_events_url": "https://api.github.com/users/wittrup/received_events",
"repos_url": "https://api.github.com/users/wittrup/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wittrup/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wittrup/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wittrup",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2016-11-12T14:00:38Z | 2021-09-04T00:06:22Z | 2016-11-12T14:12:15Z | NONE | resolved | I would really like requests to support session key logging. Firefox and Chrome both support logging the symmetric session key used to encrypt TLS traffic. This makes it easy to analyze traffic with Wireshark.
Requests should write symmetric session keys to the file set in user variable “SSLKEYLOGFILE”. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3674/reactions"
} | https://api.github.com/repos/psf/requests/issues/3674/timeline | null | completed | null | null | false | [
"Requests cannot do this in normal operation because OpenSSL does not expose appropriate APIs to extract this keying information. Both Chrome and Firefox use other TLS implementations (BoringSSL and NSS) which do have the appropriate APIs.\n\nI am currently working on a patch to enable this functionality in openssl... |
https://api.github.com/repos/psf/requests/issues/3673 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3673/labels{/name} | https://api.github.com/repos/psf/requests/issues/3673/comments | https://api.github.com/repos/psf/requests/issues/3673/events | https://github.com/psf/requests/pull/3673 | 188,901,413 | MDExOlB1bGxSZXF1ZXN0OTM0MzMyMTc= | 3,673 | Enable unicode in basic http auth | {
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-11-12T09:02:26Z | 2021-09-08T01:21:39Z | 2016-11-21T19:27:39Z | NONE | resolved | Fixed the issue with unicode characters in basic http auth | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3673/reactions"
} | https://api.github.com/repos/psf/requests/issues/3673/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3673.diff",
"html_url": "https://github.com/psf/requests/pull/3673",
"merged_at": "2016-11-21T19:27:39Z",
"patch_url": "https://github.com/psf/requests/pull/3673.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3673"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/3672 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3672/labels{/name} | https://api.github.com/repos/psf/requests/issues/3672/comments | https://api.github.com/repos/psf/requests/issues/3672/events | https://github.com/psf/requests/issues/3672 | 188,891,188 | MDU6SXNzdWUxODg4OTExODg= | 3,672 | Typo in Quickstart Guide? | {
"avatar_url": "https://avatars.githubusercontent.com/u/3649914?v=4",
"events_url": "https://api.github.com/users/Cleod9/events{/privacy}",
"followers_url": "https://api.github.com/users/Cleod9/followers",
"following_url": "https://api.github.com/users/Cleod9/following{/other_user}",
"gists_url": "https://api.github.com/users/Cleod9/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Cleod9",
"id": 3649914,
"login": "Cleod9",
"node_id": "MDQ6VXNlcjM2NDk5MTQ=",
"organizations_url": "https://api.github.com/users/Cleod9/orgs",
"received_events_url": "https://api.github.com/users/Cleod9/received_events",
"repos_url": "https://api.github.com/users/Cleod9/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Cleod9/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Cleod9/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Cleod9",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-11-12T04:14:45Z | 2021-09-08T14:00:36Z | 2016-11-16T08:39:26Z | CONTRIBUTOR | resolved | Reference: https://github.com/kennethreitz/requests/blob/master/docs/user/quickstart.rst#cookies
```
>>> jar.set('tasty_cookie', 'yum', site='httpbin.org', path='/cookies')
>>> jar.set('gross_cookie', 'blech', site='httpbin.org', path='/elsewhere')
```
Running this example I get the following error:
`TypeError: create_cookie() got unexpected keyword arguments: ['site']`
Shouldn't `site=` be `domain=`? The error goes away if I try that. If so I'll be glad to make a PR, I just want to make sure I'm not missing something | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3672/reactions"
} | https://api.github.com/repos/psf/requests/issues/3672/timeline | null | completed | null | null | false | [
"Good spot, @Cleod9! `domain` is definitely the keyword we want here. A PR for this would be very welcome.\n",
"No problem, I should be able to get a PR up within the next couple days\n",
"PR is up :)\n",
"Resolved by #3691.\n"
] |
https://api.github.com/repos/psf/requests/issues/3671 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3671/labels{/name} | https://api.github.com/repos/psf/requests/issues/3671/comments | https://api.github.com/repos/psf/requests/issues/3671/events | https://github.com/psf/requests/pull/3671 | 188,623,237 | MDExOlB1bGxSZXF1ZXN0OTMyMzQyMjU= | 3,671 | Document that Response.json() may raise ValueError | {
"avatar_url": "https://avatars.githubusercontent.com/u/399718?v=4",
"events_url": "https://api.github.com/users/chris-martin/events{/privacy}",
"followers_url": "https://api.github.com/users/chris-martin/followers",
"following_url": "https://api.github.com/users/chris-martin/following{/other_user}",
"gists_url": "https://api.github.com/users/chris-martin/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/chris-martin",
"id": 399718,
"login": "chris-martin",
"node_id": "MDQ6VXNlcjM5OTcxOA==",
"organizations_url": "https://api.github.com/users/chris-martin/orgs",
"received_events_url": "https://api.github.com/users/chris-martin/received_events",
"repos_url": "https://api.github.com/users/chris-martin/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/chris-martin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chris-martin/subscriptions",
"type": "User",
"url": "https://api.github.com/users/chris-martin",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-10T21:29:14Z | 2021-09-08T02:10:12Z | 2016-11-10T23:18:16Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3671/reactions"
} | https://api.github.com/repos/psf/requests/issues/3671/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3671.diff",
"html_url": "https://github.com/psf/requests/pull/3671",
"merged_at": "2016-11-10T23:18:16Z",
"patch_url": "https://github.com/psf/requests/pull/3671.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3671"
} | true | [
"Thanks!\n"
] | |
https://api.github.com/repos/psf/requests/issues/3670 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3670/labels{/name} | https://api.github.com/repos/psf/requests/issues/3670/comments | https://api.github.com/repos/psf/requests/issues/3670/events | https://github.com/psf/requests/issues/3670 | 188,584,780 | MDU6SXNzdWUxODg1ODQ3ODA= | 3,670 | Requests library becomes broken, forcing reinstallation solves the problem | {
"avatar_url": "https://avatars.githubusercontent.com/u/102495?v=4",
"events_url": "https://api.github.com/users/ssbarnea/events{/privacy}",
"followers_url": "https://api.github.com/users/ssbarnea/followers",
"following_url": "https://api.github.com/users/ssbarnea/following{/other_user}",
"gists_url": "https://api.github.com/users/ssbarnea/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ssbarnea",
"id": 102495,
"login": "ssbarnea",
"node_id": "MDQ6VXNlcjEwMjQ5NQ==",
"organizations_url": "https://api.github.com/users/ssbarnea/orgs",
"received_events_url": "https://api.github.com/users/ssbarnea/received_events",
"repos_url": "https://api.github.com/users/ssbarnea/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ssbarnea/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssbarnea/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ssbarnea",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-11-10T18:35:56Z | 2021-09-08T12:01:10Z | 2016-11-10T19:05:30Z | CONTRIBUTOR | resolved | It seems that I am not the only one that discovered that his python-requests library is in a broken state.
```
import requests
File "/usr/lib/python2.7/site-packages/requests/__init__.py", line 64, in <module>
from . import utils
File "/usr/lib/python2.7/site-packages/requests/utils.py", line 29, in <module>
from .exceptions import InvalidURL, InvalidHeader, FileModeWarning
ImportError: cannot import name InvalidHeader
```
See https://bugzilla.redhat.com/show_bug.cgi?id=1393979 and http://stackoverflow.com/questions/32986626/python-requests-importerror-cannot-import-name-headerparsingerror which are two unrelated occurences that are fixed by the same workaround:
`pip install --upgrade --force-reinstall requestsexceptions requests requests-toolbelt`
#### pip freeze
I mention that the forced reinstallation did not change the reported versions but fixed the import error.
```
requests==2.11.1
requests-toolbelt==0.7.0
requestsexceptions==1.1.3
urllib3==1.15.1
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3670/reactions"
} | https://api.github.com/repos/psf/requests/issues/3670/timeline | null | completed | null | null | false | [
"This is unequivocally not a Requests issue. Requests defines `InvalidHeader` in the `exceptions` module, that import has to work. If it doesn't work, it's the result of something messing with the requests exceptions heirarchy. Given that you have installed a package called `requestsexceptions` you should strongly ... |
https://api.github.com/repos/psf/requests/issues/3669 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3669/labels{/name} | https://api.github.com/repos/psf/requests/issues/3669/comments | https://api.github.com/repos/psf/requests/issues/3669/events | https://github.com/psf/requests/issues/3669 | 188,539,424 | MDU6SXNzdWUxODg1Mzk0MjQ= | 3,669 | Setting Session Cookies | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2016-11-10T15:33:34Z | 2016-11-10T15:33:34Z | null | MEMBER | null | This is a continuation of the original PR (#3595) to address how we set Session cookies in Requests. The PR had enough disagreement on how this should be addressed that I felt it was better to move this into a discussion.
As noted in #3595, Requests currently allows the user to provide cookies as a dictionary. While we've allowed this for individual requests, because their domain is (mostly) scoped, there are some real security concerns for supporting this for Sessions.
The issues
=========
1. If the user sets Session's `cookies` attribute to a `dict`, it will happily accept it, but crashes when you try to send anything. To correct this issue, the cookies need to be supplied as a `CookieJar` instance as noted in the [documentation](http://docs.python-requests.org/en/master/user/advanced/#session-objects). This is unideal because we allow users to use an idiom supported everywhere else in the API, and then fail later with a fairly unhelpful exception.
2. #3595 automated this suggested process from the documentation, as we do elsewhere in Requests, but it allows you to easily set session-wide cookies that aren't bounded by a domain. This means it's easy to unintentionally send sensitive cookie information to unintended recipients.
3. The currently proposed solution of using `add_dict_to_cookiejar` or `cookiejar_from_dict` provides no extra protection against the security issues raised in #3595.
Solutions(?)
==========
1. I think this is a two step process. For Requests 2.x, I'm suggesting we add a warning to the user when they set Session `cookies` attribute to a `dict`. This points them at the documentation so they can at least *try* to do the right things. Otherwise, they're none the wiser until their program crashes with an error in a separate module and only minor clues on the cause. In 3.0.0, I think this warning should be raised an actual exception since we don't support cookies as dicts for Sessions.
2. (and also 3.) If we're going to require the extra step of making the user explicitly use `add_dict_to_cookiejar` or `cookie_from_dict`, then let's make them useful. They currently don't provide any benefit over the dictionary approach in #3595. We can emulate some of the functionality of how a browser handles cookies by allowing users to supply cookie parameters on a per-dictionary basis. This is similar to cookies set by individual page requests.
```python
cookies = {'SessionID': '1234',
'SecretToken': 'efe077444d17b2de7feee356601d'}
s = Session()
add_dict_to_cookiejar(
s.cookies, cookies, domain='auth.myauthsite.com',
secure=True, expires='123456789'
)
```
This is a relatively simple changed as shown in an initial mockup in e2a4f9f & 4454849. This would need to be accompanied by a documentation update (something like 3e4e5b7) to explain how to do this properly.
----
@sigmavirus24, when you've got a moment, could you confirm this issue properly encapsulates your concerns and I didn't leave anything out? As for the possible solutions, are any of these amenable? I know your work in #2714 will help this a little bit with the default cookie policy change, but we still need to provide a way for the user to easily adhere to the safeguards we're putting in place. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 1,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3669/reactions"
} | https://api.github.com/repos/psf/requests/issues/3669/timeline | null | null | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/3668 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3668/labels{/name} | https://api.github.com/repos/psf/requests/issues/3668/comments | https://api.github.com/repos/psf/requests/issues/3668/events | https://github.com/psf/requests/issues/3668 | 188,345,183 | MDU6SXNzdWUxODgzNDUxODM= | 3,668 | If-Modified-Since is a "special" header? | {
"avatar_url": "https://avatars.githubusercontent.com/u/10715803?v=4",
"events_url": "https://api.github.com/users/miscellainiac/events{/privacy}",
"followers_url": "https://api.github.com/users/miscellainiac/followers",
"following_url": "https://api.github.com/users/miscellainiac/following{/other_user}",
"gists_url": "https://api.github.com/users/miscellainiac/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/miscellainiac",
"id": 10715803,
"login": "miscellainiac",
"node_id": "MDQ6VXNlcjEwNzE1ODAz",
"organizations_url": "https://api.github.com/users/miscellainiac/orgs",
"received_events_url": "https://api.github.com/users/miscellainiac/received_events",
"repos_url": "https://api.github.com/users/miscellainiac/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/miscellainiac/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/miscellainiac/subscriptions",
"type": "User",
"url": "https://api.github.com/users/miscellainiac",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-09T20:31:28Z | 2021-09-08T14:00:39Z | 2016-11-09T21:22:03Z | NONE | resolved | I am using requests (2.10.0) in Python 2.7.11 and I just ran across some very strange behavior with respect to this header. I would like to send along different formats than 'Tue, 08 Nov 2016 05:00:00 GMT' which seems to be passed along just fine, but if I try a string like '2016-11-08T00:00:00-05:00' something is munging that value, fails to parse it (but does not raise an error) and my services on the other side get a completely different date (Thu, 31 Dec 2015 00:00:00 GMT).
So something is going on here, I'm just not sure where or even why. I am wondering if there is a way to simply pass along the string as-is... | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3668/reactions"
} | https://api.github.com/repos/psf/requests/issues/3668/timeline | null | completed | null | null | false | [
"@miscellainiac we do not (nor does anything between us and the socket) munge that header. My guess is that there's something infront of the server (e.g., a proxy or load balancer) that does this to your request header. Either way, the correct format is like your first example. See\n- https://tools.ietf.org/html/rf... |
https://api.github.com/repos/psf/requests/issues/3667 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3667/labels{/name} | https://api.github.com/repos/psf/requests/issues/3667/comments | https://api.github.com/repos/psf/requests/issues/3667/events | https://github.com/psf/requests/pull/3667 | 187,929,870 | MDExOlB1bGxSZXF1ZXN0OTI3MzQxMDA= | 3,667 | Upgrade urllib3 to version 1.19 | {
"avatar_url": "https://avatars.githubusercontent.com/u/299380?v=4",
"events_url": "https://api.github.com/users/frankier/events{/privacy}",
"followers_url": "https://api.github.com/users/frankier/followers",
"following_url": "https://api.github.com/users/frankier/following{/other_user}",
"gists_url": "https://api.github.com/users/frankier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/frankier",
"id": 299380,
"login": "frankier",
"node_id": "MDQ6VXNlcjI5OTM4MA==",
"organizations_url": "https://api.github.com/users/frankier/orgs",
"received_events_url": "https://api.github.com/users/frankier/received_events",
"repos_url": "https://api.github.com/users/frankier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/frankier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/frankier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/frankier",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-08T08:28:55Z | 2021-09-08T02:10:13Z | 2016-11-08T08:30:32Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3667/reactions"
} | https://api.github.com/repos/psf/requests/issues/3667/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3667.diff",
"html_url": "https://github.com/psf/requests/pull/3667",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3667.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3667"
} | true | [
"Thanks for opening this, but this is usually done by maintainers as part of the release and maintenance process. In particular, it requires some care around handling the packaging side of things. Sorry, but that means we're not going to merge this.\n\nThanks for the work though!\n"
] | |
https://api.github.com/repos/psf/requests/issues/3666 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3666/labels{/name} | https://api.github.com/repos/psf/requests/issues/3666/comments | https://api.github.com/repos/psf/requests/issues/3666/events | https://github.com/psf/requests/pull/3666 | 187,020,804 | MDExOlB1bGxSZXF1ZXN0OTIxMjQ5NTI= | 3,666 | documentation line added for consistency with the post method | {
"avatar_url": "https://avatars.githubusercontent.com/u/8665709?v=4",
"events_url": "https://api.github.com/users/hootnot/events{/privacy}",
"followers_url": "https://api.github.com/users/hootnot/followers",
"following_url": "https://api.github.com/users/hootnot/following{/other_user}",
"gists_url": "https://api.github.com/users/hootnot/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hootnot",
"id": 8665709,
"login": "hootnot",
"node_id": "MDQ6VXNlcjg2NjU3MDk=",
"organizations_url": "https://api.github.com/users/hootnot/orgs",
"received_events_url": "https://api.github.com/users/hootnot/received_events",
"repos_url": "https://api.github.com/users/hootnot/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hootnot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hootnot/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hootnot",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-03T10:20:19Z | 2021-09-08T02:10:22Z | 2016-11-03T10:39:47Z | CONTRIBUTOR | resolved | Docs PR regarding #3664 and #2979 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3666/reactions"
} | https://api.github.com/repos/psf/requests/issues/3666/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3666.diff",
"html_url": "https://github.com/psf/requests/pull/3666",
"merged_at": "2016-11-03T10:39:47Z",
"patch_url": "https://github.com/psf/requests/pull/3666.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3666"
} | true | [
"Thanks @hootnot! :sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/3665 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3665/labels{/name} | https://api.github.com/repos/psf/requests/issues/3665/comments | https://api.github.com/repos/psf/requests/issues/3665/events | https://github.com/psf/requests/issues/3665 | 186,980,976 | MDU6SXNzdWUxODY5ODA5NzY= | 3,665 | connection pool exceed issue | {
"avatar_url": "https://avatars.githubusercontent.com/u/553215?v=4",
"events_url": "https://api.github.com/users/KiritoStudio/events{/privacy}",
"followers_url": "https://api.github.com/users/KiritoStudio/followers",
"following_url": "https://api.github.com/users/KiritoStudio/following{/other_user}",
"gists_url": "https://api.github.com/users/KiritoStudio/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/KiritoStudio",
"id": 553215,
"login": "KiritoStudio",
"node_id": "MDQ6VXNlcjU1MzIxNQ==",
"organizations_url": "https://api.github.com/users/KiritoStudio/orgs",
"received_events_url": "https://api.github.com/users/KiritoStudio/received_events",
"repos_url": "https://api.github.com/users/KiritoStudio/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/KiritoStudio/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KiritoStudio/subscriptions",
"type": "User",
"url": "https://api.github.com/users/KiritoStudio",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-03T05:24:35Z | 2021-09-08T14:00:40Z | 2016-11-04T01:30:23Z | NONE | resolved | The issue like https://github.com/kennethreitz/requests/issues/3090, but socks5:// protocol seems has the same issue. After requesting a lot of urls, the connection pool will be exceeded. | {
"avatar_url": "https://avatars.githubusercontent.com/u/553215?v=4",
"events_url": "https://api.github.com/users/KiritoStudio/events{/privacy}",
"followers_url": "https://api.github.com/users/KiritoStudio/followers",
"following_url": "https://api.github.com/users/KiritoStudio/following{/other_user}",
"gists_url": "https://api.github.com/users/KiritoStudio/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/KiritoStudio",
"id": 553215,
"login": "KiritoStudio",
"node_id": "MDQ6VXNlcjU1MzIxNQ==",
"organizations_url": "https://api.github.com/users/KiritoStudio/orgs",
"received_events_url": "https://api.github.com/users/KiritoStudio/received_events",
"repos_url": "https://api.github.com/users/KiritoStudio/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/KiritoStudio/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KiritoStudio/subscriptions",
"type": "User",
"url": "https://api.github.com/users/KiritoStudio",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3665/reactions"
} | https://api.github.com/repos/psf/requests/issues/3665/timeline | null | completed | null | null | false | [
"Are you sure? Can you provide some example of what exception you're hitting, and maybe some sample code to trigger it?\n"
] |
https://api.github.com/repos/psf/requests/issues/3664 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3664/labels{/name} | https://api.github.com/repos/psf/requests/issues/3664/comments | https://api.github.com/repos/psf/requests/issues/3664/events | https://github.com/psf/requests/pull/3664 | 186,936,516 | MDExOlB1bGxSZXF1ZXN0OTIwNjczOTg= | 3,664 | json parameter added to patch and put methods | {
"avatar_url": "https://avatars.githubusercontent.com/u/8665709?v=4",
"events_url": "https://api.github.com/users/hootnot/events{/privacy}",
"followers_url": "https://api.github.com/users/hootnot/followers",
"following_url": "https://api.github.com/users/hootnot/following{/other_user}",
"gists_url": "https://api.github.com/users/hootnot/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hootnot",
"id": 8665709,
"login": "hootnot",
"node_id": "MDQ6VXNlcjg2NjU3MDk=",
"organizations_url": "https://api.github.com/users/hootnot/orgs",
"received_events_url": "https://api.github.com/users/hootnot/received_events",
"repos_url": "https://api.github.com/users/hootnot/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hootnot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hootnot/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hootnot",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-11-02T22:24:13Z | 2021-09-08T02:10:23Z | 2016-11-03T10:03:59Z | CONTRIBUTOR | resolved | referring to #2979 ...
this is answered that this can be done with **kwargs, which is true. But wouldn't that would go for **post** too ?
It would make consistent use of parameters possible if **put** and **patch** would support the _json_ parameter also, so then there is no need for additional logic to distinguish between the different methods, take for example:
```python
...
self.client = requests.Session()
...
request_args = {}
if method == 'get':
request_args['params'] = params
elif hasattr(endpoint, "data") and endpoint.data:
request_args['json'] = endpoint.data
....
func = getattr(self.client, method)
response = func(url, stream=stream, headers=headers, **request_args)
...
```
post, put and patch can all be handled the same this way. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3664/reactions"
} | https://api.github.com/repos/psf/requests/issues/3664/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3664.diff",
"html_url": "https://github.com/psf/requests/pull/3664",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3664.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3664"
} | true | [
"> if put and patch would support the json parameter also\n\nThey already do. \n",
"Yup, you are right. \n\nSomehow reading the docs one gets a direction because the **post** method explicit names the **json** parameter in it's documentation. While the **put** and **post** don't, they indirectly refer to the pa... |
https://api.github.com/repos/psf/requests/issues/3663 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3663/labels{/name} | https://api.github.com/repos/psf/requests/issues/3663/comments | https://api.github.com/repos/psf/requests/issues/3663/events | https://github.com/psf/requests/pull/3663 | 186,922,866 | MDExOlB1bGxSZXF1ZXN0OTIwNTc0MTg= | 3,663 | fix path for cookiejar_from_dict in api.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-11-02T21:18:18Z | 2021-09-08T02:10:21Z | 2016-11-03T10:06:53Z | MEMBER | resolved | Right now the `cookiejar_from_dict` path provided to autofunction in api.rst is incorrect. It happens to work though because Sphinx is smart enough to correct the source url for us. This will make the display string consistent with the correct path. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3663/reactions"
} | https://api.github.com/repos/psf/requests/issues/3663/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3663.diff",
"html_url": "https://github.com/psf/requests/pull/3663",
"merged_at": "2016-11-03T10:06:53Z",
"patch_url": "https://github.com/psf/requests/pull/3663.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3663"
} | true | [
"Thanks @nateprewitt! :sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/3662 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3662/labels{/name} | https://api.github.com/repos/psf/requests/issues/3662/comments | https://api.github.com/repos/psf/requests/issues/3662/events | https://github.com/psf/requests/issues/3662 | 186,834,701 | MDU6SXNzdWUxODY4MzQ3MDE= | 3,662 | Basic http auth + unicode = error | {
"avatar_url": "https://avatars.githubusercontent.com/u/240594?v=4",
"events_url": "https://api.github.com/users/sztomi/events{/privacy}",
"followers_url": "https://api.github.com/users/sztomi/followers",
"following_url": "https://api.github.com/users/sztomi/following{/other_user}",
"gists_url": "https://api.github.com/users/sztomi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sztomi",
"id": 240594,
"login": "sztomi",
"node_id": "MDQ6VXNlcjI0MDU5NA==",
"organizations_url": "https://api.github.com/users/sztomi/orgs",
"received_events_url": "https://api.github.com/users/sztomi/received_events",
"repos_url": "https://api.github.com/users/sztomi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sztomi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sztomi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sztomi",
"user_view_type": "public"
} | [
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
}
] | closed | true | null | [] | null | 10 | 2016-11-02T15:32:03Z | 2021-09-07T00:06:19Z | 2016-11-23T10:17:55Z | NONE | resolved | ## Description
It is not possible to send a basic http authentication using a username or password that contains Unicode data.
### What happens
`UnicodeEncodeError` is thrown. Traceback:
```
File "(my code)", line 163, in _get
auth=(self.user, self.password))
File "/usr/local/lib/python3.5/site-packages/requests/api.py", line 67, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python3.5/site-packages/requests/api.py", line 53, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.5/site-packages/requests/sessions.py", line 454, in request
prep = self.prepare_request(req)
File "/usr/local/lib/python3.5/site-packages/requests/sessions.py", line 388, in prepare_request
hooks=merge_hooks(request.hooks, self.hooks),
File "/usr/local/lib/python3.5/site-packages/requests/models.py", line 297, in prepare
self.prepare_auth(auth, url)
File "/usr/local/lib/python3.5/site-packages/requests/models.py", line 490, in prepare_auth
r = auth(self)
File "/usr/local/lib/python3.5/site-packages/requests/auth.py", line 51, in __call__
r.headers['Authorization'] = _basic_auth_str(self.username, self.password)
File "/usr/local/lib/python3.5/site-packages/requests/auth.py", line 31, in _basic_auth_str
b64encode(('%s:%s' % (username, password)).encode('latin1')).strip()
UnicodeEncodeError: 'latin-1' codec can't encode character '\u0171' in position 7: ordinal not in range(256)
```
### Expected behavior
The authentication is encoded as utf-8 (at least if charset=utf-8 is provided in the header).
## How to reproduce
Consider the following request:
```python
user = 'űser'
password = 'páéáésswőrd'
response = requests.get(
url='http://example.com'
headers={'Content-Type': 'application/xml; charset=utf-8'},
auth=(user, password))
```
I think that the culprit is this line (https://github.com/kennethreitz/requests/blob/master/requests/auth.py#L32), which assumes latin-1 encoding regardless of the charset header:
```python
def _basic_auth_str(username, password):
"""Returns a Basic Auth string."""
authstr = 'Basic ' + to_native_string(
b64encode(('%s:%s' % (username, password)).encode('latin1')).strip()
)
return authstr
```
## Workaround
This seems to work:
```python
from requests.auth import to_native_string
# ... snip ...
auth = 'Basic ' + to_native_string(b64encode('{}:{}'.format(self.user, self.password).encode('utf-8')).strip())
response = requests.get(
url=self.base_url + uri,
headers={
'Content-Type': 'application/xml; charset=utf-8',
'Authorization': auth
})
```
## Version info
```
$ pip show requests
---
Metadata-Version: 2.0
Name: requests
Version: 2.9.1
Summary: Python HTTP for Humans.
Home-page: http://python-requests.org
Author: Kenneth Reitz
Author-email: me@kennethreitz.com
Installer: pip
License: Apache 2.0
Location: /usr/local/lib/python3.5/site-packages
Requires:
Classifiers:
Development Status :: 5 - Production/Stable
Intended Audience :: Developers
Natural Language :: English
License :: OSI Approved :: Apache Software License
Programming Language :: Python
Programming Language :: Python :: 2.7
Programming Language :: Python :: 3
Programming Language :: Python :: 3.3
Programming Language :: Python :: 3.4
Programming Language :: Python :: 3.5
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3662/reactions"
} | https://api.github.com/repos/psf/requests/issues/3662/timeline | null | completed | null | null | false | [
"Yeah, that looks like a bug.\n\nI think in this case the best fix is to allow the user to provide bytestrings for the username and password, and if they do that to simply use the bytestring directly rather than to try to encode.\n\nAre you interested in providing a test and patch for this?\n",
"@Lukasa Gladly, b... |
https://api.github.com/repos/psf/requests/issues/3661 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3661/labels{/name} | https://api.github.com/repos/psf/requests/issues/3661/comments | https://api.github.com/repos/psf/requests/issues/3661/events | https://github.com/psf/requests/issues/3661 | 186,323,367 | MDU6SXNzdWUxODYzMjMzNjc= | 3,661 | Close keep-alive connections after configurable period (aka keep-alive timeout) | {
"avatar_url": "https://avatars.githubusercontent.com/u/94327?v=4",
"events_url": "https://api.github.com/users/tuukkamustonen/events{/privacy}",
"followers_url": "https://api.github.com/users/tuukkamustonen/followers",
"following_url": "https://api.github.com/users/tuukkamustonen/following{/other_user}",
"gists_url": "https://api.github.com/users/tuukkamustonen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tuukkamustonen",
"id": 94327,
"login": "tuukkamustonen",
"node_id": "MDQ6VXNlcjk0MzI3",
"organizations_url": "https://api.github.com/users/tuukkamustonen/orgs",
"received_events_url": "https://api.github.com/users/tuukkamustonen/received_events",
"repos_url": "https://api.github.com/users/tuukkamustonen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tuukkamustonen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tuukkamustonen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tuukkamustonen",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2016-10-31T16:02:55Z | 2021-09-05T00:06:48Z | 2016-10-31T16:25:19Z | NONE | resolved | I am experiencing a race condition with a (Squid) proxy server, best described by @rdharrison2 in https://github.com/kennethreitz/requests/issues/2364#issuecomment-186214402:
> In my case I'm making a large number of periodic https requests to a apache2 server with connection keep-alive timeout 5s. There is a race between the server closing a timed out persistent connection and the client making a request on the same connection. Given a bit of network latency the client can often attempt to send a request on the socket before it gets notified it as been closed.
Rather than implementing a retry logic, I would like to ensure that my requests `Session` keep-alive "timeout" is lower than that of proxy's. But I cannot seem to find out how.
Either I'm blind or it's just not supported? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3661/reactions"
} | https://api.github.com/repos/psf/requests/issues/3661/timeline | null | completed | null | null | false | [
"Requests doesn't have a keep-alive timeout, because such a notion doesn't make sense. HTTP \"keep-alive\" doesn't involve any socket activity: it just involves each end of the connection promising to keep it open as long as they can.\n\nIn this case, what happens is that when you go to make a request, Requests che... |
https://api.github.com/repos/psf/requests/issues/3660 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3660/labels{/name} | https://api.github.com/repos/psf/requests/issues/3660/comments | https://api.github.com/repos/psf/requests/issues/3660/events | https://github.com/psf/requests/pull/3660 | 186,286,848 | MDExOlB1bGxSZXF1ZXN0OTE2MTExNjU= | 3,660 | [httpAdapter] allow empty password in proxy credentials | {
"avatar_url": "https://avatars.githubusercontent.com/u/2700942?v=4",
"events_url": "https://api.github.com/users/pawelmhm/events{/privacy}",
"followers_url": "https://api.github.com/users/pawelmhm/followers",
"following_url": "https://api.github.com/users/pawelmhm/following{/other_user}",
"gists_url": "https://api.github.com/users/pawelmhm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pawelmhm",
"id": 2700942,
"login": "pawelmhm",
"node_id": "MDQ6VXNlcjI3MDA5NDI=",
"organizations_url": "https://api.github.com/users/pawelmhm/orgs",
"received_events_url": "https://api.github.com/users/pawelmhm/received_events",
"repos_url": "https://api.github.com/users/pawelmhm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pawelmhm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pawelmhm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pawelmhm",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-10-31T13:45:59Z | 2021-09-08T02:10:23Z | 2016-10-31T13:59:16Z | CONTRIBUTOR | resolved | fixes #3659 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3660/reactions"
} | https://api.github.com/repos/psf/requests/issues/3660/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3660.diff",
"html_url": "https://github.com/psf/requests/pull/3660",
"merged_at": "2016-10-31T13:59:16Z",
"patch_url": "https://github.com/psf/requests/pull/3660.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3660"
} | true | [
"Some things that could be improved in future:\n- add some unit test using real proxy, e.g. MITM-proxy, something along the lines of Scrapy: https://github.com/scrapy/scrapy/blob/129421c7e31b89b9b0f9c5f7d8ae59e47df36091/tests/test_proxy_connect.py#L35 where there is fake proxy started and all tests for proxy reques... |
https://api.github.com/repos/psf/requests/issues/3659 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3659/labels{/name} | https://api.github.com/repos/psf/requests/issues/3659/comments | https://api.github.com/repos/psf/requests/issues/3659/events | https://github.com/psf/requests/issues/3659 | 186,263,437 | MDU6SXNzdWUxODYyNjM0Mzc= | 3,659 | URL proxy auth with empty passwords doesn't emit auth header. | {
"avatar_url": "https://avatars.githubusercontent.com/u/2700942?v=4",
"events_url": "https://api.github.com/users/pawelmhm/events{/privacy}",
"followers_url": "https://api.github.com/users/pawelmhm/followers",
"following_url": "https://api.github.com/users/pawelmhm/following{/other_user}",
"gists_url": "https://api.github.com/users/pawelmhm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pawelmhm",
"id": 2700942,
"login": "pawelmhm",
"node_id": "MDQ6VXNlcjI3MDA5NDI=",
"organizations_url": "https://api.github.com/users/pawelmhm/orgs",
"received_events_url": "https://api.github.com/users/pawelmhm/received_events",
"repos_url": "https://api.github.com/users/pawelmhm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pawelmhm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pawelmhm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pawelmhm",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2016-10-31T11:40:37Z | 2021-09-08T14:00:41Z | 2016-10-31T13:59:16Z | CONTRIBUTOR | resolved | I'm using a proxy that requires authentication to send request that receives 302 response with Location header. I would like python.requests to follow this redirect and make request via proxy with specified credentials. But it seems like this doesn't happen, if I provide credentials in HTTPProxyAuth they will work ok for 200 responses but will fail for 302. See below code sample:
```python
import requests
from requests.auth import HTTPProxyAuth
sess = requests.Session()
url1 = 'http://httpbin.org/'
url2 = 'http://httpbin.org/redirect/2'
auth = HTTPProxyAuth('frank', 'hunter2')
proxies = {
"http": "http://localhost:9000"
}
response1 = sess.get(url1, proxies=proxies, auth=auth)
response1.raise_for_status()
response2 = sess.get(url2, proxies=proxies, auth=auth)
response2.raise_for_status()
```
Now launch MITM proxy on localhost
```
> mitmproxy -p 9000 --singleuser=frank:hunter2
```
This fails with 407 for me, and proxy logs only two requests
```
response2.raise_for_status()
File "----------", line 862, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 407 Client Error: Proxy Authentication Required for url: http://httpbin.org/relative-redirect/1
```
```
>> GET http://httpbin.org/
← 200 text/html 11.87kB 3.57MB/s
GET http://httpbin.org/redirect/2
← 302 text/html 247B 76.59kB/s
```
it does not log request to `Location`.
I see that putting credentials in proxies dictionary somehow fixes this issue when I use MITM proxy but it doesn't fix it for my production proxy (can't share code or proxy details here, need to check closer why it doesn't work for my proxy). I guess some details in setup of proxies might vary.
Is this a bug? I see some issues for proxy auth but they are mostly about HTTPS, not sure if someone reported this thing I describe here. Should this be fixed?
EDIT:
It looks like this always fails if proxy password is empty string.
change auth to
```python
auth = HTTPProxyAuth('frank', '')
proxies = {
"http": "http://frank:@localhost:9000"
}
```
will now always fail on redirect.
```python
auth = HTTPProxyAuth('frank', 'hunter2')
proxies = {
"http": "http://frank:hunter2@localhost:9000"
}
```
works fine on redirects, but seems somewhat duplicated.
I noticed this on Ubuntu 14.04, requests 2.11.1, python 2.7.6, mitmproxy 0.10.1 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3659/reactions"
} | https://api.github.com/repos/psf/requests/issues/3659/timeline | null | completed | null | null | false | [
"Ok, let's tightly restrict the scope of this bug.\n\nFirstly, HTTPProxyAuth is a backward compatibility auth. It does not integrate well with httplib's handling of proxies, especially for CONNECT HTTPS proxying. We don't want you to use it. Please put the auth into the proxy URL, as you have discovered.\n\nSo the ... |
https://api.github.com/repos/psf/requests/issues/3658 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3658/labels{/name} | https://api.github.com/repos/psf/requests/issues/3658/comments | https://api.github.com/repos/psf/requests/issues/3658/events | https://github.com/psf/requests/pull/3658 | 186,226,139 | MDExOlB1bGxSZXF1ZXN0OTE1NzAxMDI= | 3,658 | Formatted the example to fix the color highlighting | {
"avatar_url": "https://avatars.githubusercontent.com/u/973362?v=4",
"events_url": "https://api.github.com/users/elzapp/events{/privacy}",
"followers_url": "https://api.github.com/users/elzapp/followers",
"following_url": "https://api.github.com/users/elzapp/following{/other_user}",
"gists_url": "https://api.github.com/users/elzapp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/elzapp",
"id": 973362,
"login": "elzapp",
"node_id": "MDQ6VXNlcjk3MzM2Mg==",
"organizations_url": "https://api.github.com/users/elzapp/orgs",
"received_events_url": "https://api.github.com/users/elzapp/received_events",
"repos_url": "https://api.github.com/users/elzapp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/elzapp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/elzapp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/elzapp",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-10-31T08:09:47Z | 2021-09-08T02:10:24Z | 2016-10-31T08:53:04Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3658/reactions"
} | https://api.github.com/repos/psf/requests/issues/3658/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3658.diff",
"html_url": "https://github.com/psf/requests/pull/3658",
"merged_at": "2016-10-31T08:53:04Z",
"patch_url": "https://github.com/psf/requests/pull/3658.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3658"
} | true | [
"Thanks! :sparkles: :cake: :sparkles:\n"
] | |
https://api.github.com/repos/psf/requests/issues/3657 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3657/labels{/name} | https://api.github.com/repos/psf/requests/issues/3657/comments | https://api.github.com/repos/psf/requests/issues/3657/events | https://github.com/psf/requests/issues/3657 | 186,176,805 | MDU6SXNzdWUxODYxNzY4MDU= | 3,657 | Empty/whitespace-only values in requests.post data | {
"avatar_url": "https://avatars.githubusercontent.com/u/2373726?v=4",
"events_url": "https://api.github.com/users/scubbo/events{/privacy}",
"followers_url": "https://api.github.com/users/scubbo/followers",
"following_url": "https://api.github.com/users/scubbo/following{/other_user}",
"gists_url": "https://api.github.com/users/scubbo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/scubbo",
"id": 2373726,
"login": "scubbo",
"node_id": "MDQ6VXNlcjIzNzM3MjY=",
"organizations_url": "https://api.github.com/users/scubbo/orgs",
"received_events_url": "https://api.github.com/users/scubbo/received_events",
"repos_url": "https://api.github.com/users/scubbo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/scubbo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/scubbo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/scubbo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-10-31T00:27:52Z | 2021-09-08T14:00:41Z | 2016-10-31T09:02:41Z | NONE | resolved | Either one or two issues here, but probably related (please let me know if you'd rather have them raised separately):
1. Entries in requests.post data that have empty values are not transmitted
2. Entries in requests.post data that have whitespace-only values are not transmitted when entered as a json string, but are when entered as a dictionary
See the following demonstration code:
```
#!/usr/bin/env python
from BaseHTTPServer import BaseHTTPRequestHandler, HTTPServer
from threading import Thread
import cgi
import requests
class Handler(BaseHTTPRequestHandler):
def do_POST(self):
print 'Got a post request'
self.send_response(200)
self.send_header('Content-type', 'application/json')
self.end_headers()
form = cgi.FieldStorage(
fp=self.rfile,
headers=self.headers,
environ={
'REQUEST_METHOD':'POST',
'CONTENT_TYPE':'application/json',
})
print 'Data is:' + str(form)
for key in form:
print 'Key: ' + key + ', Value: ' + form[key].value
return
if __name__ == '__main__':
server_address=('',8080)
httpd = HTTPServer(server_address, Handler)
Thread(target=httpd.serve_forever).start()
requests.post('http://localhost:8080', data='{"key1":""}')
requests.post('http://localhost:8080', data={'key2':''})
requests.post('http://localhost:8080', data='{"key3":" "}')
requests.post('http://localhost:8080', data={'key4':' '})
httpd.shutdown()
```
Expected output:
```
Got a post request
127.0.0.1 - - [30/Oct/2016 17:24:20] "POST / HTTP/1.1" 200 -
Data is:FieldStorage(None, None, [MiniFieldStorage('key1', '')])
Got a post request
127.0.0.1 - - [30/Oct/2016 17:24:20] "POST / HTTP/1.1" 200 -
Data is:FieldStorage(None, None, [MiniFieldStorage('key2', '')])
Got a post request
127.0.0.1 - - [30/Oct/2016 17:24:20] "POST / HTTP/1.1" 200 -
Data is:FieldStorage(None, None, [MiniFieldStorage('key3', ' ')])
Got a post request
127.0.0.1 - - [30/Oct/2016 17:24:20] "POST / HTTP/1.1" 200 -
Data is:FieldStorage(None, None, [MiniFieldStorage('key4', ' ')])
Key: key4, Value:
```
Actual output:
```
Got a post request
127.0.0.1 - - [30/Oct/2016 17:24:20] "POST / HTTP/1.1" 200 -
Data is:FieldStorage(None, None, [])
Got a post request
127.0.0.1 - - [30/Oct/2016 17:24:20] "POST / HTTP/1.1" 200 -
Data is:FieldStorage(None, None, [])
Got a post request
127.0.0.1 - - [30/Oct/2016 17:24:20] "POST / HTTP/1.1" 200 -
Data is:FieldStorage(None, None, [])
Got a post request
127.0.0.1 - - [30/Oct/2016 17:24:20] "POST / HTTP/1.1" 200 -
Data is:FieldStorage(None, None, [MiniFieldStorage('key4', ' ')])
Key: key4, Value:
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3657/reactions"
} | https://api.github.com/repos/psf/requests/issues/3657/timeline | null | completed | null | null | false | [
"When you pass a string the `data` kwarg, we don't process it at all: we just send it on. That means that, for at least key1 and key3, the error in behaviour is with your server.\n\nNow, I suspect that's because you aren't sending a JSON content-type header, which means that the remote server has no idea what the c... |
https://api.github.com/repos/psf/requests/issues/3656 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3656/labels{/name} | https://api.github.com/repos/psf/requests/issues/3656/comments | https://api.github.com/repos/psf/requests/issues/3656/events | https://github.com/psf/requests/pull/3656 | 186,156,911 | MDExOlB1bGxSZXF1ZXN0OTE1MzI4NjM= | 3,656 | Drop Python 2.6 support | {
"avatar_url": "https://avatars.githubusercontent.com/u/294415?v=4",
"events_url": "https://api.github.com/users/di/events{/privacy}",
"followers_url": "https://api.github.com/users/di/followers",
"following_url": "https://api.github.com/users/di/following{/other_user}",
"gists_url": "https://api.github.com/users/di/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/di",
"id": 294415,
"login": "di",
"node_id": "MDQ6VXNlcjI5NDQxNQ==",
"organizations_url": "https://api.github.com/users/di/orgs",
"received_events_url": "https://api.github.com/users/di/received_events",
"repos_url": "https://api.github.com/users/di/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/di/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/di/subscriptions",
"type": "User",
"url": "https://api.github.com/users/di",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-10-30T19:27:57Z | 2021-09-04T00:06:48Z | 2016-10-30T20:08:22Z | MEMBER | resolved | Yesterday marks 3 years since the last release of Python 2.6! 🎉
To celebrate, I'm attempting to drop support for it from 156 prominent Python packages (one for every week it's past end-of-life)--including this one!
I've tried my best to remove as much 2.6-specific cruft as I can, but at the very least, this PR will remove the `'Programming Language :: Python :: 2.6'` trove classifier from this projects `setup.py`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3656/reactions"
} | https://api.github.com/repos/psf/requests/issues/3656/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3656.diff",
"html_url": "https://github.com/psf/requests/pull/3656",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3656.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3656"
} | true | [
"No.\n",
"Double no.\n",
"One year on, any thoughts on dropping 2.6?\r\n\r\nIf not now, what are the reasons for keeping it and when might it be droppable?\r\n\r\nI see it's no longer being tested: https://github.com/requests/requests/commit/c3ecb825c41f90fb6bec28c282c70c84398e08c0.",
"This was eventually don... |
https://api.github.com/repos/psf/requests/issues/3655 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3655/labels{/name} | https://api.github.com/repos/psf/requests/issues/3655/comments | https://api.github.com/repos/psf/requests/issues/3655/events | https://github.com/psf/requests/pull/3655 | 186,047,502 | MDExOlB1bGxSZXF1ZXN0OTE0NzExODE= | 3,655 | Rewind readable body before POST redirect | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2016-10-29T00:18:10Z | 2021-09-08T02:10:21Z | 2016-11-03T10:31:04Z | MEMBER | resolved | This addresses the issue (#3079) of Requests hanging when a POST with a file-like body encounters a temporary redirect. This currently has the unmerged tests from #3536, so I'll need to remove those if we reach a point where we're ready to merge this.
This approach has a couple of things that I'm not especially happy with but couldn't come up with a nicer alternative. I've added a few outstanding questions below.
1.) I feel like `body_position` should probably be `_body_position`, but we need to use it in the `Session` module. Making it a private var would require an additional getter method for `PreparedRequest` to expose the data to `Session`, but I wanted to run that by before adding more code. It just seems problematic to provide any encouragement to manually set `body_position` since it will lead to fairly unintuitive behaviour.
2.) As I noted in the comment [here](https://github.com/nateprewitt/requests/commit/b84d71461e238b123a39ce91a48a99e3eb03717c#commitcomment-19619276), this still allows for the possibility that a request with a file-like object, that has tell but no seek, to hang. I feel like we should raise an `IOError` if we can't rewind, at least allowing the user to manually recreate the body and POST it to the new URL. Does that seem reasonable?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3655/reactions"
} | https://api.github.com/repos/psf/requests/issues/3655/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3655.diff",
"html_url": "https://github.com/psf/requests/pull/3655",
"merged_at": "2016-11-03T10:31:04Z",
"patch_url": "https://github.com/psf/requests/pull/3655.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3655"
} | true | [
"Alright @Lukasa, I think everything in that last round should be addressed. A couple of notes on some decisions I made in these tweaks.\n\nPython 2.7 decided it needs to return a long from `tell` instead of an int like every other version. I've adjusted for that by casting it to int because we can't test for long ... |
https://api.github.com/repos/psf/requests/issues/3654 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3654/labels{/name} | https://api.github.com/repos/psf/requests/issues/3654/comments | https://api.github.com/repos/psf/requests/issues/3654/events | https://github.com/psf/requests/pull/3654 | 185,920,009 | MDExOlB1bGxSZXF1ZXN0OTEzNzkyOTk= | 3,654 | Accept integers in header | {
"avatar_url": "https://avatars.githubusercontent.com/u/7986123?v=4",
"events_url": "https://api.github.com/users/ploth/events{/privacy}",
"followers_url": "https://api.github.com/users/ploth/followers",
"following_url": "https://api.github.com/users/ploth/following{/other_user}",
"gists_url": "https://api.github.com/users/ploth/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ploth",
"id": 7986123,
"login": "ploth",
"node_id": "MDQ6VXNlcjc5ODYxMjM=",
"organizations_url": "https://api.github.com/users/ploth/orgs",
"received_events_url": "https://api.github.com/users/ploth/received_events",
"repos_url": "https://api.github.com/users/ploth/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ploth/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ploth/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ploth",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-10-28T13:13:48Z | 2021-09-08T02:10:24Z | 2016-10-28T13:15:00Z | NONE | resolved | This is a fix for the following crash of the utils.py I've encountered when syncing with vdirsyncer.
Traceback (most recent call last):
File "/usr/lib/python3.5/site-packages/vdirsyncer/cli/tasks.py", line 58, in sync_collection
force_delete=force_delete
File "/usr/lib/python3.5/site-packages/vdirsyncer/sync.py", line 169, in sync
b_info.prepare_idents(storage_a.read_only)
File "/usr/lib/python3.5/site-packages/vdirsyncer/sync.py", line 104, in prepare_idents
for href, etag in self.storage.list():
File "/usr/lib/python3.5/site-packages/vdirsyncer/storage/dav.py", line 565, in list
headers=headers)
File "/usr/lib/python3.5/site-packages/vdirsyncer/storage/dav.py", line 322, in request
return utils.http.request(method, url, session=self._session, *_more)
File "/usr/lib/python3.5/site-packages/vdirsyncer/utils/http.py", line 79, in request
r = func(method, url, *_kwargs)
File "/usr/lib/python3.5/site-packages/requests/sessions.py", line 462, in request
prep = self.prepare_request(req)
File "/usr/lib/python3.5/site-packages/requests/sessions.py", line 395, in prepare_request
hooks=merge_hooks(request.hooks, self.hooks),
File "/usr/lib/python3.5/site-packages/requests/models.py", line 301, in prepare
self.prepare_headers(headers)
File "/usr/lib/python3.5/site-packages/requests/models.py", line 415, in prepare_headers
check_header_validity(header)
File "/usr/lib/python3.5/site-packages/requests/utils.py", line 794, in check_header_validity
"not %s" % (value, type(value)))
requests.exceptions.InvalidHeader: Header value 1 must be of type str or bytes, not <class 'int'>
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3654/reactions"
} | https://api.github.com/repos/psf/requests/issues/3654/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3654.diff",
"html_url": "https://github.com/psf/requests/pull/3654",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3654.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3654"
} | true | [
"Thanks! However, this is not considered a bug. See #3477 for more.\n"
] |
https://api.github.com/repos/psf/requests/issues/3653 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3653/labels{/name} | https://api.github.com/repos/psf/requests/issues/3653/comments | https://api.github.com/repos/psf/requests/issues/3653/events | https://github.com/psf/requests/issues/3653 | 185,862,484 | MDU6SXNzdWUxODU4NjI0ODQ= | 3,653 | Chunked transfer encoding for SSE heartbeats failing | {
"avatar_url": "https://avatars.githubusercontent.com/u/694893?v=4",
"events_url": "https://api.github.com/users/huntc/events{/privacy}",
"followers_url": "https://api.github.com/users/huntc/followers",
"following_url": "https://api.github.com/users/huntc/following{/other_user}",
"gists_url": "https://api.github.com/users/huntc/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/huntc",
"id": 694893,
"login": "huntc",
"node_id": "MDQ6VXNlcjY5NDg5Mw==",
"organizations_url": "https://api.github.com/users/huntc/orgs",
"received_events_url": "https://api.github.com/users/huntc/received_events",
"repos_url": "https://api.github.com/users/huntc/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/huntc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huntc/subscriptions",
"type": "User",
"url": "https://api.github.com/users/huntc",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2016-10-28T08:05:58Z | 2021-09-08T14:00:43Z | 2016-10-28T08:18:11Z | NONE | resolved | When subscribing to a Server Sent Events endpoint, I notice an error given the processing of a heartbeat. Heartbeats in SSE can be sent as an empty line. Consider the following SSE reply for chunked transfer encoding:
```
00000000 48 54 54 50 2f 31 2e 31 20 32 30 30 20 4f 4b 0d HTTP/1.1 200 OK.
00000010 0a 53 65 72 76 65 72 3a 20 6f 70 65 6e 72 65 73 .Server: openres
00000020 74 79 2f 31 2e 39 2e 31 35 2e 31 0d 0a 44 61 74 ty/1.9.1 5.1..Dat
00000030 65 3a 20 46 72 69 2c 20 32 38 20 4f 63 74 20 32 e: Fri, 28 Oct 2
00000040 30 31 36 20 30 32 3a 33 39 3a 35 34 20 47 4d 54 016 02:3 9:54 GMT
00000050 0d 0a 43 6f 6e 74 65 6e 74 2d 54 79 70 65 3a 20 ..Conten t-Type:
00000060 74 65 78 74 2f 65 76 65 6e 74 2d 73 74 72 65 61 text/eve nt-strea
00000070 6d 0d 0a 54 72 61 6e 73 66 65 72 2d 45 6e 63 6f m..Trans fer-Enco
00000080 64 69 6e 67 3a 20 63 68 75 6e 6b 65 64 0d 0a 43 ding: ch unked..C
00000090 6f 6e 6e 65 63 74 69 6f 6e 3a 20 6b 65 65 70 2d onnectio n: keep-
000000A0 61 6c 69 76 65 0d 0a 0d 0a alive... .
000000A9 31 0d 0a 0a 0d 0a 1.....
```
With the last line, the `31` indicates that there is just one byte to receive (ASCII `1`). The chunked size is then followed by a CRLF and then the empty line (`LF`), followed again by a CRLF.
This appears to cause the following stacktrace:
```
...
File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/utils.py", line 377, in stream_decode_response_unicode
for chunk in iterator:
File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/models.py", line 676, in generate
for chunk in self.raw.stream(chunk_size, decode_content=True):
File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/response.py", line 353, in stream
for line in self.read_chunked(amt, decode_content=decode_content):
File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/response.py", line 502, in read_chunked
self._update_chunk_length()
File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/response.py", line 448, in _update_chunk_length
line = self._fp.fp.readline()
AttributeError: 'NoneType' object has no attribute 'readline'
```
What I'm left wondering is whether chunked responses that only contain a newline cause the requests library a problem.
I'm using requests 2.11.1.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3653/reactions"
} | https://api.github.com/repos/psf/requests/issues/3653/timeline | null | completed | null | null | false | [
"I can't reproduce a problem on my system by duplicating that output. Is it possible for you to provide the code you're using?\n",
"I appreciate the situation, however a reproducer isn't immediately available. I'll try and work on something for you, but can't promise anything. Thanks for any further insights.\n",... |
https://api.github.com/repos/psf/requests/issues/3652 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3652/labels{/name} | https://api.github.com/repos/psf/requests/issues/3652/comments | https://api.github.com/repos/psf/requests/issues/3652/events | https://github.com/psf/requests/pull/3652 | 185,711,977 | MDExOlB1bGxSZXF1ZXN0OTEyMzE1NDg= | 3,652 | The data= parameter barfs on all dictionary-like objects that don't subclass dict itself #3649 | {
"avatar_url": "https://avatars.githubusercontent.com/u/4481232?v=4",
"events_url": "https://api.github.com/users/lejkos/events{/privacy}",
"followers_url": "https://api.github.com/users/lejkos/followers",
"following_url": "https://api.github.com/users/lejkos/following{/other_user}",
"gists_url": "https://api.github.com/users/lejkos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lejkos",
"id": 4481232,
"login": "lejkos",
"node_id": "MDQ6VXNlcjQ0ODEyMzI=",
"organizations_url": "https://api.github.com/users/lejkos/orgs",
"received_events_url": "https://api.github.com/users/lejkos/received_events",
"repos_url": "https://api.github.com/users/lejkos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lejkos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lejkos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lejkos",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-10-27T16:03:44Z | 2021-09-08T02:10:24Z | 2016-10-27T16:51:29Z | CONTRIBUTOR | resolved | requests.post does not accept custom mappings as
data parameters. I changed the type check to Mapping.
Original bug report can be found at #3649:
The data= parameter barfs on all dictionary-like objects that don't subclass dict itself #3649
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3652/reactions"
} | https://api.github.com/repos/psf/requests/issues/3652/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3652.diff",
"html_url": "https://github.com/psf/requests/pull/3652",
"merged_at": "2016-10-27T16:51:29Z",
"patch_url": "https://github.com/psf/requests/pull/3652.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3652"
} | true | [
"✨🍰✨\n"
] |
https://api.github.com/repos/psf/requests/issues/3651 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3651/labels{/name} | https://api.github.com/repos/psf/requests/issues/3651/comments | https://api.github.com/repos/psf/requests/issues/3651/events | https://github.com/psf/requests/issues/3651 | 185,554,840 | MDU6SXNzdWUxODU1NTQ4NDA= | 3,651 | requests can't properly handle 'WWW-Authenticate' response header | {
"avatar_url": "https://avatars.githubusercontent.com/u/7598892?v=4",
"events_url": "https://api.github.com/users/beruhan/events{/privacy}",
"followers_url": "https://api.github.com/users/beruhan/followers",
"following_url": "https://api.github.com/users/beruhan/following{/other_user}",
"gists_url": "https://api.github.com/users/beruhan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/beruhan",
"id": 7598892,
"login": "beruhan",
"node_id": "MDQ6VXNlcjc1OTg4OTI=",
"organizations_url": "https://api.github.com/users/beruhan/orgs",
"received_events_url": "https://api.github.com/users/beruhan/received_events",
"repos_url": "https://api.github.com/users/beruhan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/beruhan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/beruhan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/beruhan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-10-27T01:58:38Z | 2021-09-08T14:00:43Z | 2016-10-27T03:04:24Z | NONE | resolved | when the http response like this:
`HTTP/1.1 401 Unauthorized\r\n
Server: DNVRS-Webs\r\n
Content-Type: text/html\r\n
WWW-Authenticate: Basic realm="DVRNVRDVS"\r\n
WWW-Authenticate: Digest realm="DVRNVRDVS", domain="::", qop="auth", nonce="2c4158c9159934737e69aa698494ae04", opaque="", algorithm="MD5", stale="FALSE"\r\n`
I have print the response headers ,`{'Server': 'DNVRS-Webs', 'Content-Type': 'text/html', 'WWW-Authenticate': 'Basic realm="DVRNVRDVS", Digest realm="DVRNVRDVS", domain="::", qop="auth", nonce="2c4158c9159934737e69aa698494ae04", opaque="", algorithm="MD5", stale="FALSE"'}`,is this a bug? @nakajima @alex @mkomitee @thedaniel
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3651/reactions"
} | https://api.github.com/repos/psf/requests/issues/3651/timeline | null | completed | null | null | false | [
"This isn't a bug in Requests. You're getting a 401, which means you're using or were provided the wrong credentials for the server you're attempting to authenticate to.\n",
"@drpoggi is likely correct. Further, without extra information, it's hard for any of the people you tagged in this bug to help you (let alo... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.