url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/828 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/828/labels{/name} | https://api.github.com/repos/psf/requests/issues/828/comments | https://api.github.com/repos/psf/requests/issues/828/events | https://github.com/psf/requests/pull/828 | 6,590,080 | MDExOlB1bGxSZXF1ZXN0MjIyMjg0OA== | 828 | Develop | {
"avatar_url": "https://avatars.githubusercontent.com/u/1146703?v=4",
"events_url": "https://api.github.com/users/SecurityForUs/events{/privacy}",
"followers_url": "https://api.github.com/users/SecurityForUs/followers",
"following_url": "https://api.github.com/users/SecurityForUs/following{/other_user}",
"gists_url": "https://api.github.com/users/SecurityForUs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/SecurityForUs",
"id": 1146703,
"login": "SecurityForUs",
"node_id": "MDQ6VXNlcjExNDY3MDM=",
"organizations_url": "https://api.github.com/users/SecurityForUs/orgs",
"received_events_url": "https://api.github.com/users/SecurityForUs/received_events",
"repos_url": "https://api.github.com/users/SecurityForUs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/SecurityForUs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SecurityForUs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/SecurityForUs",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2012-08-31T22:10:35Z | 2021-09-08T23:07:26Z | 2012-08-31T23:49:18Z | CONTRIBUTOR | resolved | When prefetch = True (by default in 0.13.9) it causes iter_\* functions (i.e.: iter_content() & iter_lines()) to fail with the raised error stating the content has already been consumed.
I specified it as 'False' for default so such functions can work. There is not a lot of information on how to fix the issue (with the GitHub links stating the issue is fixed when it really isn't). For people who don't know the inner workings of Request it can be very discouraging.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/828/reactions"
} | https://api.github.com/repos/psf/requests/issues/828/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/828.diff",
"html_url": "https://github.com/psf/requests/pull/828",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/828.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/828"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2299035) (merged 4704c771 into 81897dd1).\n",
"The adding of \"README\" is an accident which I apologize for you. Was not intended to have that pushed as well.\n",
"No worries (about README) :)\n",
"Unfortunately, this was a major ... |
https://api.github.com/repos/psf/requests/issues/827 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/827/labels{/name} | https://api.github.com/repos/psf/requests/issues/827/comments | https://api.github.com/repos/psf/requests/issues/827/events | https://github.com/psf/requests/issues/827 | 6,572,971 | MDU6SXNzdWU2NTcyOTcx | 827 | SSLError on Windows 7, 64-bit. Appeared in version 0.13.8 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1415093?v=4",
"events_url": "https://api.github.com/users/stebunovd/events{/privacy}",
"followers_url": "https://api.github.com/users/stebunovd/followers",
"following_url": "https://api.github.com/users/stebunovd/following{/other_user}",
"gists_url": "https://api.github.com/users/stebunovd/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stebunovd",
"id": 1415093,
"login": "stebunovd",
"node_id": "MDQ6VXNlcjE0MTUwOTM=",
"organizations_url": "https://api.github.com/users/stebunovd/orgs",
"received_events_url": "https://api.github.com/users/stebunovd/received_events",
"repos_url": "https://api.github.com/users/stebunovd/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stebunovd/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stebunovd/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stebunovd",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-31T07:48:22Z | 2021-09-09T05:30:53Z | 2012-11-17T11:07:57Z | NONE | resolved | ```
C:\Users\stebunovd>pip install requests==0.13.7
Downloading/unpacking requests==0.13.7
Downloading requests-0.13.7.tar.gz (521Kb): 521Kb downloaded
Running setup.py egg_info for package requests
warning: no files found matching 'tests\*.'
Installing collected packages: requests
Found existing installation: requests 0.13.8
Uninstalling requests:
Successfully uninstalled requests
Running setup.py install for requests
warning: no files found matching 'tests\*.'
Successfully installed requests
Cleaning up...
C:\Users\stebunovd>python
Python 2.7.3 (default, Apr 10 2012, 23:31:26) [MSC v.1500 32 bit (Intel)] on win
32
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.get('https://web3ds.masterbank.ru/cgi-bin/cgi_link')
<Response [200]>
>>> quit()
C:\Users\stebunovd>pip install requests==0.13.8
Downloading/unpacking requests==0.13.8
Downloading requests-0.13.8.tar.gz (522Kb): 522Kb downloaded
Running setup.py egg_info for package requests
warning: no files found matching 'tests\*.'
Installing collected packages: requests
Found existing installation: requests 0.13.7
Uninstalling requests:
Successfully uninstalled requests
Running setup.py install for requests
warning: no files found matching 'tests\*.'
Successfully installed requests
Cleaning up...
C:\Users\stebunovd>python
Python 2.7.3 (default, Apr 10 2012, 23:31:26) [MSC v.1500 32 bit (Intel)] on win
32
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.get('https://web3ds.masterbank.ru/cgi-bin/cgi_link')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Python27\lib\site-packages\requests\api.py", line 65, in get
return request('get', url, **kwargs)
File "C:\Python27\lib\site-packages\requests\safe_mode.py", line 39, in wrappe
d
return function(method, url, **kwargs)
File "C:\Python27\lib\site-packages\requests\api.py", line 51, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 243, in reques
t
r.send(prefetch=prefetch)
File "C:\Python27\lib\site-packages\requests\models.py", line 631, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 8] _ssl.c:504: EOF occurred in violation of
protocol
>>>
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/827/reactions"
} | https://api.github.com/repos/psf/requests/issues/827/timeline | null | completed | null | null | false | [
"The bug appears only when using this URL https://web3ds.masterbank.ru/cgi-bin/cgi_link and only on Windows machines (tested on 3 workstations on Win7-64 and one Win8). I was unable to reproduce it on Mac OS X 10.8.1 or Amazon Linux.\n",
"This actually looks like it may be related: https://bugs.launchpad.net/ubun... |
https://api.github.com/repos/psf/requests/issues/826 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/826/labels{/name} | https://api.github.com/repos/psf/requests/issues/826/comments | https://api.github.com/repos/psf/requests/issues/826/events | https://github.com/psf/requests/pull/826 | 6,559,734 | MDExOlB1bGxSZXF1ZXN0MjIwODI2Nw== | 826 | Updated content workflow section of the advanced user docs | {
"avatar_url": "https://avatars.githubusercontent.com/u/128561?v=4",
"events_url": "https://api.github.com/users/hazzadous/events{/privacy}",
"followers_url": "https://api.github.com/users/hazzadous/followers",
"following_url": "https://api.github.com/users/hazzadous/following{/other_user}",
"gists_url": "https://api.github.com/users/hazzadous/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hazzadous",
"id": 128561,
"login": "hazzadous",
"node_id": "MDQ6VXNlcjEyODU2MQ==",
"organizations_url": "https://api.github.com/users/hazzadous/orgs",
"received_events_url": "https://api.github.com/users/hazzadous/received_events",
"repos_url": "https://api.github.com/users/hazzadous/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hazzadous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hazzadous/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hazzadous",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-30T17:33:54Z | 2021-09-08T16:01:00Z | 2012-08-31T23:49:47Z | NONE | resolved | The default for prefetch changed in 0.13.6 so have updated the relevant section in the docs. Anything amis? Not sure if you'd rather alter the default instead although I'd say defaulting to True sounds sensible.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/826/reactions"
} | https://api.github.com/repos/psf/requests/issues/826/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/826.diff",
"html_url": "https://github.com/psf/requests/pull/826",
"merged_at": "2012-08-31T23:49:47Z",
"patch_url": "https://github.com/psf/requests/pull/826.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/826"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2286020) (merged 991b853b into 0ad44565).\n",
":cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/825 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/825/labels{/name} | https://api.github.com/repos/psf/requests/issues/825/comments | https://api.github.com/repos/psf/requests/issues/825/events | https://github.com/psf/requests/issues/825 | 6,550,361 | MDU6SXNzdWU2NTUwMzYx | 825 | response.raw broken in >= 0.13.6 | {
"avatar_url": "https://avatars.githubusercontent.com/u/128561?v=4",
"events_url": "https://api.github.com/users/hazzadous/events{/privacy}",
"followers_url": "https://api.github.com/users/hazzadous/followers",
"following_url": "https://api.github.com/users/hazzadous/following{/other_user}",
"gists_url": "https://api.github.com/users/hazzadous/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hazzadous",
"id": 128561,
"login": "hazzadous",
"node_id": "MDQ6VXNlcjEyODU2MQ==",
"organizations_url": "https://api.github.com/users/hazzadous/orgs",
"received_events_url": "https://api.github.com/users/hazzadous/received_events",
"repos_url": "https://api.github.com/users/hazzadous/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hazzadous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hazzadous/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hazzadous",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-30T10:51:07Z | 2021-09-09T06:00:45Z | 2012-08-30T15:16:28Z | NONE | resolved | Reading from raw in 0.13.5 gives me the raw content, however in 0.13.6 and above I get an empty string.
In 0.13.5:
```
>>> requests.get('http://www.google.com').raw.read()
'...' # the correct content
```
In 0.13.6:
```
>>> requests.get('http://www.google.com').raw.read()
''
```
I presume somewhere in requests raw is being mistakenly read from?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/128561?v=4",
"events_url": "https://api.github.com/users/hazzadous/events{/privacy}",
"followers_url": "https://api.github.com/users/hazzadous/followers",
"following_url": "https://api.github.com/users/hazzadous/following{/other_user}",
"gists_url": "https://api.github.com/users/hazzadous/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hazzadous",
"id": 128561,
"login": "hazzadous",
"node_id": "MDQ6VXNlcjEyODU2MQ==",
"organizations_url": "https://api.github.com/users/hazzadous/orgs",
"received_events_url": "https://api.github.com/users/hazzadous/received_events",
"repos_url": "https://api.github.com/users/hazzadous/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hazzadous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hazzadous/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hazzadous",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/825/reactions"
} | https://api.github.com/repos/psf/requests/issues/825/timeline | null | completed | null | null | false | [
"I'm not familiar with the changes made between 0.13.5 and 0.13.6 but for your example to work you must pass `prefetch=False`, e.g.,:\n\n```\n>>> from requests import get\n>>> r = get('http://httpbin.org/get', prefetch=False)\n>>> r\n<Response [200]>\n>>> r.raw\n<requests.packages.urllib3.response.HTTPResponse obje... |
https://api.github.com/repos/psf/requests/issues/824 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/824/labels{/name} | https://api.github.com/repos/psf/requests/issues/824/comments | https://api.github.com/repos/psf/requests/issues/824/events | https://github.com/psf/requests/pull/824 | 6,548,231 | MDExOlB1bGxSZXF1ZXN0MjIwMjc1Nw== | 824 | save_as(filename) | {
"avatar_url": "https://avatars.githubusercontent.com/u/621306?v=4",
"events_url": "https://api.github.com/users/alicebob/events{/privacy}",
"followers_url": "https://api.github.com/users/alicebob/followers",
"following_url": "https://api.github.com/users/alicebob/following{/other_user}",
"gists_url": "https://api.github.com/users/alicebob/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alicebob",
"id": 621306,
"login": "alicebob",
"node_id": "MDQ6VXNlcjYyMTMwNg==",
"organizations_url": "https://api.github.com/users/alicebob/orgs",
"received_events_url": "https://api.github.com/users/alicebob/received_events",
"repos_url": "https://api.github.com/users/alicebob/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alicebob/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alicebob/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alicebob",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-30T08:50:11Z | 2021-09-08T23:07:25Z | 2012-08-30T12:45:56Z | NONE | resolved | So one can do: requests.get("http://foobar.com", prefetch=False).save_as("/tmp/foobar.com.html")
Will add it to the 'advanced docs' if this is accepted.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/824/reactions"
} | https://api.github.com/repos/psf/requests/issues/824/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/824.diff",
"html_url": "https://github.com/psf/requests/pull/824",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/824.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/824"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2281143) (merged 520e9836 into 0ad44565).\n",
"The content in this Pull Request is duplicated by #823. Additionally, the name and description in this PR actually belong to #823 and vice-versa. I'm going to close this one, and centralise ... |
https://api.github.com/repos/psf/requests/issues/823 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/823/labels{/name} | https://api.github.com/repos/psf/requests/issues/823/comments | https://api.github.com/repos/psf/requests/issues/823/events | https://github.com/psf/requests/pull/823 | 6,548,186 | MDExOlB1bGxSZXF1ZXN0MjIwMjczNQ== | 823 | A warning for iter_content() for prefetch=True requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/621306?v=4",
"events_url": "https://api.github.com/users/alicebob/events{/privacy}",
"followers_url": "https://api.github.com/users/alicebob/followers",
"following_url": "https://api.github.com/users/alicebob/following{/other_user}",
"gists_url": "https://api.github.com/users/alicebob/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alicebob",
"id": 621306,
"login": "alicebob",
"node_id": "MDQ6VXNlcjYyMTMwNg==",
"organizations_url": "https://api.github.com/users/alicebob/orgs",
"received_events_url": "https://api.github.com/users/alicebob/received_events",
"repos_url": "https://api.github.com/users/alicebob/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alicebob/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alicebob/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alicebob",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2012-08-30T08:48:40Z | 2021-09-08T23:07:25Z | 2012-08-31T23:51:25Z | NONE | resolved | iter_content() doesn't work with requests with prefetch=True, which makes sense, but a warning might help.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/823/reactions"
} | https://api.github.com/repos/psf/requests/issues/823/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/823.diff",
"html_url": "https://github.com/psf/requests/pull/823",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/823.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/823"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2281118) (merged 40c813b9 into 0ad44565).\n",
"This PR contains the commits from PRs #824 and #822. I've closed those PRs to centralise the discussion here. The messages for each commit are as follows:\n- 4b99498: #822, There was no test... |
https://api.github.com/repos/psf/requests/issues/822 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/822/labels{/name} | https://api.github.com/repos/psf/requests/issues/822/comments | https://api.github.com/repos/psf/requests/issues/822/events | https://github.com/psf/requests/pull/822 | 6,548,167 | MDExOlB1bGxSZXF1ZXN0MjIwMjcyMw== | 822 | A simple test for iter_content | {
"avatar_url": "https://avatars.githubusercontent.com/u/621306?v=4",
"events_url": "https://api.github.com/users/alicebob/events{/privacy}",
"followers_url": "https://api.github.com/users/alicebob/followers",
"following_url": "https://api.github.com/users/alicebob/following{/other_user}",
"gists_url": "https://api.github.com/users/alicebob/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alicebob",
"id": 621306,
"login": "alicebob",
"node_id": "MDQ6VXNlcjYyMTMwNg==",
"organizations_url": "https://api.github.com/users/alicebob/orgs",
"received_events_url": "https://api.github.com/users/alicebob/received_events",
"repos_url": "https://api.github.com/users/alicebob/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alicebob/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alicebob/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alicebob",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-30T08:47:14Z | 2021-09-08T16:00:59Z | 2012-08-30T12:46:39Z | NONE | resolved | There was no test for iter_content.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/822/reactions"
} | https://api.github.com/repos/psf/requests/issues/822/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/822.diff",
"html_url": "https://github.com/psf/requests/pull/822",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/822.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/822"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2281110) (merged 4b994982 into 0ad44565).\n",
"The commit here is duplicated in #823. To ease merging, I'm going to centralise the discussion on these PRs to there.\n"
] |
https://api.github.com/repos/psf/requests/issues/821 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/821/labels{/name} | https://api.github.com/repos/psf/requests/issues/821/comments | https://api.github.com/repos/psf/requests/issues/821/events | https://github.com/psf/requests/issues/821 | 6,544,396 | MDU6SXNzdWU2NTQ0Mzk2 | 821 | When proxy is used, Accept header is overwritten | {
"avatar_url": "https://avatars.githubusercontent.com/u/1514856?v=4",
"events_url": "https://api.github.com/users/jiangk/events{/privacy}",
"followers_url": "https://api.github.com/users/jiangk/followers",
"following_url": "https://api.github.com/users/jiangk/following{/other_user}",
"gists_url": "https://api.github.com/users/jiangk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jiangk",
"id": 1514856,
"login": "jiangk",
"node_id": "MDQ6VXNlcjE1MTQ4NTY=",
"organizations_url": "https://api.github.com/users/jiangk/orgs",
"received_events_url": "https://api.github.com/users/jiangk/received_events",
"repos_url": "https://api.github.com/users/jiangk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jiangk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jiangk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jiangk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2012-08-30T03:33:04Z | 2021-09-09T03:00:40Z | 2012-08-30T12:38:08Z | NONE | resolved | When a request specifies both an `Accept` header and a proxy server, the `Accept` header value is overwritten with `*/*`. The provided `Accept` header should not be overwritten.
```
proxy = {'http' : 'http://localhost:8888'}
headers = {'Accept' : 'application/json'}
r = requests.get('http://www.yahoo.com', proxies=proxy, headers=headers)
```
Raw request from proxy:
```
GET / HTTP/ 1.1
Host: www.yahoo.com
Accept-Encoding: identity, deflate, compress, gzip
Accept: */*
User-Agent: python-requests/0.13.6 CPython/2.7.2 Darwin/12.1.0
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/821/reactions"
} | https://api.github.com/repos/psf/requests/issues/821/timeline | null | completed | null | null | false | [
"This is probably due to urllib3's logic here: https://github.com/shazow/urllib3/blob/master/urllib3/poolmanager.py#L131\n\nI'm happy to accept a pull request for urllib3 to invert the logic (set default headers and overwrite if provided).\n",
"Thanks, just sent the pull request\n",
"Hi, this issue is still in ... |
https://api.github.com/repos/psf/requests/issues/820 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/820/labels{/name} | https://api.github.com/repos/psf/requests/issues/820/comments | https://api.github.com/repos/psf/requests/issues/820/events | https://github.com/psf/requests/pull/820 | 6,536,292 | MDExOlB1bGxSZXF1ZXN0MjE5NzIwOQ== | 820 | Data encoding should take place after calling into auth provider | {
"avatar_url": "https://avatars.githubusercontent.com/u/155396?v=4",
"events_url": "https://api.github.com/users/dergraf/events{/privacy}",
"followers_url": "https://api.github.com/users/dergraf/followers",
"following_url": "https://api.github.com/users/dergraf/following{/other_user}",
"gists_url": "https://api.github.com/users/dergraf/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dergraf",
"id": 155396,
"login": "dergraf",
"node_id": "MDQ6VXNlcjE1NTM5Ng==",
"organizations_url": "https://api.github.com/users/dergraf/orgs",
"received_events_url": "https://api.github.com/users/dergraf/received_events",
"repos_url": "https://api.github.com/users/dergraf/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dergraf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dergraf/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dergraf",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-29T19:29:28Z | 2021-09-08T22:01:16Z | 2012-09-11T03:06:53Z | CONTRIBUTOR | resolved | I discovered this bug when using the auth.OAuth1 auth provider. If I did a simple
``` python
oauth = OAuth1(key,secret,signature_type=SIGNATURE_TYPE_BODY)
requests.post(url, data={'some':'param'}, auth=oauth)
```
only the data <code>{'some':'param'}</code> gets transmitted, all the OAuth specific parameters aren't packed into the body.
My patch moves the data encoding after the calling into the auth provider.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/820/reactions"
} | https://api.github.com/repos/psf/requests/issues/820/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/820.diff",
"html_url": "https://github.com/psf/requests/pull/820",
"merged_at": "2012-09-11T03:06:53Z",
"patch_url": "https://github.com/psf/requests/pull/820.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/820"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2276322) (merged 52d2e2ee into 0ad44565).\n",
"@idan?\n",
"just as a short note: the problem is not only related to OAuth , OAuth is just the only auth provider available at the moment that might change the body data and therefore gen... |
https://api.github.com/repos/psf/requests/issues/819 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/819/labels{/name} | https://api.github.com/repos/psf/requests/issues/819/comments | https://api.github.com/repos/psf/requests/issues/819/events | https://github.com/psf/requests/pull/819 | 6,490,861 | MDExOlB1bGxSZXF1ZXN0MjE3NjU0Mg== | 819 | Correct OAuth1 with query or data. | {
"avatar_url": "https://avatars.githubusercontent.com/u/406779?v=4",
"events_url": "https://api.github.com/users/ayanamist/events{/privacy}",
"followers_url": "https://api.github.com/users/ayanamist/followers",
"following_url": "https://api.github.com/users/ayanamist/following{/other_user}",
"gists_url": "https://api.github.com/users/ayanamist/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ayanamist",
"id": 406779,
"login": "ayanamist",
"node_id": "MDQ6VXNlcjQwNjc3OQ==",
"organizations_url": "https://api.github.com/users/ayanamist/orgs",
"received_events_url": "https://api.github.com/users/ayanamist/received_events",
"repos_url": "https://api.github.com/users/ayanamist/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ayanamist/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ayanamist/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ayanamist",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2012-08-28T04:55:03Z | 2021-09-08T23:07:27Z | 2012-08-29T11:29:42Z | CONTRIBUTOR | resolved | Sorry, it's me again.
auth.py still have problems. POST with data can't be signed correctly. So i dive into the code and rewrite it.
And in fact, there's no "multipart/form-encoded" but only "multipart/form-data".
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/819/reactions"
} | https://api.github.com/repos/psf/requests/issues/819/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/819.diff",
"html_url": "https://github.com/psf/requests/pull/819",
"merged_at": "2012-08-29T11:29:42Z",
"patch_url": "https://github.com/psf/requests/pull/819.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/819"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2257949) (merged 8a1d53eb into b9ecf456).\n",
"@idan @dgouldin @gulopine code review? :)\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2258667) (merged 46ff4b38 into b9ecf456).\n",
"This pull requ... |
https://api.github.com/repos/psf/requests/issues/818 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/818/labels{/name} | https://api.github.com/repos/psf/requests/issues/818/comments | https://api.github.com/repos/psf/requests/issues/818/events | https://github.com/psf/requests/pull/818 | 6,487,564 | MDExOlB1bGxSZXF1ZXN0MjE3NTAxOA== | 818 | improve top-level docstring | {
"avatar_url": "https://avatars.githubusercontent.com/u/663366?v=4",
"events_url": "https://api.github.com/users/r1chardj0n3s/events{/privacy}",
"followers_url": "https://api.github.com/users/r1chardj0n3s/followers",
"following_url": "https://api.github.com/users/r1chardj0n3s/following{/other_user}",
"gists_url": "https://api.github.com/users/r1chardj0n3s/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/r1chardj0n3s",
"id": 663366,
"login": "r1chardj0n3s",
"node_id": "MDQ6VXNlcjY2MzM2Ng==",
"organizations_url": "https://api.github.com/users/r1chardj0n3s/orgs",
"received_events_url": "https://api.github.com/users/r1chardj0n3s/received_events",
"repos_url": "https://api.github.com/users/r1chardj0n3s/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/r1chardj0n3s/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/r1chardj0n3s/subscriptions",
"type": "User",
"url": "https://api.github.com/users/r1chardj0n3s",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-27T23:36:56Z | 2021-09-08T16:00:59Z | 2012-08-28T05:38:47Z | CONTRIBUTOR | resolved | Yay, I had to nuke my branch to get here, but here's the improved docstring :-)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/818/reactions"
} | https://api.github.com/repos/psf/requests/issues/818/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/818.diff",
"html_url": "https://github.com/psf/requests/pull/818",
"merged_at": "2012-08-28T05:38:47Z",
"patch_url": "https://github.com/psf/requests/pull/818.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/818"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2256330) (merged f4311269 into b9ecf456).\n",
"Thank you sir :)\n"
] |
https://api.github.com/repos/psf/requests/issues/817 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/817/labels{/name} | https://api.github.com/repos/psf/requests/issues/817/comments | https://api.github.com/repos/psf/requests/issues/817/events | https://github.com/psf/requests/pull/817 | 6,485,118 | MDExOlB1bGxSZXF1ZXN0MjE3MzcyNw== | 817 | Add a `add_params` method to the `Session` class. | {
"avatar_url": "https://avatars.githubusercontent.com/u/305268?v=4",
"events_url": "https://api.github.com/users/msabramo/events{/privacy}",
"followers_url": "https://api.github.com/users/msabramo/followers",
"following_url": "https://api.github.com/users/msabramo/following{/other_user}",
"gists_url": "https://api.github.com/users/msabramo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/msabramo",
"id": 305268,
"login": "msabramo",
"node_id": "MDQ6VXNlcjMwNTI2OA==",
"organizations_url": "https://api.github.com/users/msabramo/orgs",
"received_events_url": "https://api.github.com/users/msabramo/received_events",
"repos_url": "https://api.github.com/users/msabramo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/msabramo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/msabramo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/msabramo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 13 | 2012-08-27T21:26:03Z | 2021-09-08T23:05:21Z | 2012-08-28T05:45:46Z | CONTRIBUTOR | resolved | Otherwise, it's tricky for clients to write code that adds params without them poking inside the innards of `Session`, which can be problematic when the implementation changes.
This was motivated by the fact that I just ran some code of mine that depends on requests and it failed, because my virtualenv had a newer version of requests (0.13.9) and the code was written against 0.13.1 and had code that looked like this:
``` python
self.session.params['access_token'] = response_obj['access_token']
```
I do this to add an `access_token` parameter after the user logs in and obtains an access token, because this parameter is needed on subsequent requests after the login.
This worked in 0.13.1, because in 0.13.1, `session.params` was a dict, but it is now a list of tuples. The problem arises because there was no public interface for setting params and because this is Python, one can manipulate the attributes of the class whenever they desire. When the implementation changes, this breaks code that relies on that implementation.
So I propose to add a `add_params` method to `Session`, which is the official interface for clients to use to add parameters and it can change in the future if the implementation changes and clients code will still work.
I guess this is all a really long way of saying...abstraction :-)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/817/reactions"
} | https://api.github.com/repos/psf/requests/issues/817/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/817.diff",
"html_url": "https://github.com/psf/requests/pull/817",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/817.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/817"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2255072) (merged aef7b65e into b9ecf456).\n",
"Thanks for the contribution, but I don't really see how modifying the very simple dictionary is difficult at all.\n",
"My changes towards #179 store parameters as a list of key-value tupl... |
https://api.github.com/repos/psf/requests/issues/816 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/816/labels{/name} | https://api.github.com/repos/psf/requests/issues/816/comments | https://api.github.com/repos/psf/requests/issues/816/events | https://github.com/psf/requests/pull/816 | 6,464,274 | MDExOlB1bGxSZXF1ZXN0MjE2NDY0OA== | 816 | We should try to convert the variable first but not to raise an unnecessary exception. | {
"avatar_url": "https://avatars.githubusercontent.com/u/406779?v=4",
"events_url": "https://api.github.com/users/ayanamist/events{/privacy}",
"followers_url": "https://api.github.com/users/ayanamist/followers",
"following_url": "https://api.github.com/users/ayanamist/following{/other_user}",
"gists_url": "https://api.github.com/users/ayanamist/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ayanamist",
"id": 406779,
"login": "ayanamist",
"node_id": "MDQ6VXNlcjQwNjc3OQ==",
"organizations_url": "https://api.github.com/users/ayanamist/orgs",
"received_events_url": "https://api.github.com/users/ayanamist/received_events",
"repos_url": "https://api.github.com/users/ayanamist/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ayanamist/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ayanamist/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ayanamist",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-27T00:15:12Z | 2021-09-08T23:01:02Z | 2012-08-27T00:16:57Z | CONTRIBUTOR | resolved | Since i pass the dict object with str and int object, an exception will be raised.
> Exception on /post [POST]
> Traceback (most recent call last):
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/Flask-0.9-py2.7.zip/flask/app.py", line 1687, in wsgi_app
> response = self.full_dispatch_request()
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/Flask-0.9-py2.7.zip/flask/app.py", line 1360, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/Flask-0.9-py2.7.zip/flask/app.py", line 1358, in full_dispatch_request
> rv = self.dispatch_request()
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/Flask-0.9-py2.7.zip/flask/app.py", line 1344, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/application/utils/decorators.py", line 10, in decorated_view
> return func(_args, *_kwargs)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/application/views/status.py", line 19, in status_post
> result = flask.g.api.reTweet(id=retweet_id, include_entities=1)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/twython-2.3.3.zip/twython/twython.py", line 138, in <lambda>
> return lambda *_kwargs: self._constructFunc(key, *_kwargs)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/twython-2.3.3.zip/twython/twython.py", line 155, in _constructFunc
> content = self._request(url, method=fn['method'], params=kwargs)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/twython-2.3.3.zip/twython/twython.py", line 175, in _request
> response = func(url, data=params, files=files)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/requests-0.13.9.zip/requests/sessions.py", line 295, in post
> return self.request('post', url, data=data, **kwargs)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/requests-0.13.9.zip/requests/sessions.py", line 252, in request
> r.send(prefetch=prefetch)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/requests-0.13.9.zip/requests/models.py", line 532, in send
> r = self.auth(self)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/requests-0.13.9.zip/requests/auth.py", line 103, in __call__
> unicode(r.full_url), unicode(r.method), r.data, r.headers)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/requests-0.13.9.zip/requests/packages/oauthlib/oauth1/rfc5849/**init**.py", line 211, in sign
> request.oauth_params.append((u'oauth_signature', self.get_oauth_signature(request)))
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/requests-0.13.9.zip/requests/packages/oauthlib/oauth1/rfc5849/**init**.py", line 71, in get_oauth_signature
> normalized_params = signature.normalize_parameters(collected_params)
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/requests-0.13.9.zip/requests/packages/oauthlib/oauth1/rfc5849/signature.py", line 373, in normalize_parameters
> key_values = [(utils.escape(k), utils.escape(v)) for k, v in params]
> File "/base/data/home/apps/s~dabr-gae/1.361315839962791826/lib/requests-0.13.9.zip/requests/packages/oauthlib/oauth1/rfc5849/utils.py", line 52, in escape
> raise ValueError('Only unicode objects are escapable.')
> ValueError: Only unicode objects are escapable.
The related code is here: https://code.google.com/p/gabr/source/browse/application/views/status.py?r=c67d65b90bdf78d07d4fe92cc1e8f9827cb5eaf8#22
So i must unicode the parameters first: https://code.google.com/p/gabr/source/browse/application/views/status.py?r=7eb65d488db14fb1ced0c848c0334f894191ab7b#20
It's caused by https://github.com/kennethreitz/requests/blob/9576518d69b819b25cd036397d2624daa6ae088c/requests/packages/oauthlib/oauth1/rfc5849/utils.py#L52 which will check the type of the parameters.
But i think it's not necessary, because what common.quote do is that it encode the unicode string to utf8, call urllib.quote and decode it. I think even this unicode intermediate object is unnecessary, because the only calling is from https://github.com/kennethreitz/requests/blob/9576518d69b819b25cd036397d2624daa6ae088c/requests/packages/oauthlib/oauth1/rfc5849/signature.py#L373 which convert the object to unicode string again in the next statement.
And i think common.quote is unncessary, because the only calling is from oauth1/rfc5849/utils.py , the rest in this package is directly calling urllib.quote.
So i think, we should just encoding it if it's a unicode object or do nothing else.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/816/reactions"
} | https://api.github.com/repos/psf/requests/issues/816/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/816.diff",
"html_url": "https://github.com/psf/requests/pull/816",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/816.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/816"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2245717) (merged c4ad0fa5 into b9ecf456).\n",
"This issue should be opened against oauthlib, not requests.\n\nhttps://github.com/idan/oauthlib\n",
"I'm, also getting \"ValueError: Only unicode objects are unescapable\" with latest quo... |
https://api.github.com/repos/psf/requests/issues/815 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/815/labels{/name} | https://api.github.com/repos/psf/requests/issues/815/comments | https://api.github.com/repos/psf/requests/issues/815/events | https://github.com/psf/requests/pull/815 | 6,459,949 | MDExOlB1bGxSZXF1ZXN0MjE2MzY2OA== | 815 | Use logger instead of direct logging call. | {
"avatar_url": "https://avatars.githubusercontent.com/u/406779?v=4",
"events_url": "https://api.github.com/users/ayanamist/events{/privacy}",
"followers_url": "https://api.github.com/users/ayanamist/followers",
"following_url": "https://api.github.com/users/ayanamist/following{/other_user}",
"gists_url": "https://api.github.com/users/ayanamist/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ayanamist",
"id": 406779,
"login": "ayanamist",
"node_id": "MDQ6VXNlcjQwNjc3OQ==",
"organizations_url": "https://api.github.com/users/ayanamist/orgs",
"received_events_url": "https://api.github.com/users/ayanamist/received_events",
"repos_url": "https://api.github.com/users/ayanamist/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ayanamist/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ayanamist/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ayanamist",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-26T16:45:22Z | 2021-09-08T16:00:58Z | 2012-08-26T16:46:18Z | CONTRIBUTOR | resolved | Direct call can't be muted by getLogger().setLevel()
Also, logger is better for global management of logging.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/815/reactions"
} | https://api.github.com/repos/psf/requests/issues/815/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/815.diff",
"html_url": "https://github.com/psf/requests/pull/815",
"merged_at": "2012-08-26T16:46:18Z",
"patch_url": "https://github.com/psf/requests/pull/815.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/815"
} | true | [
"Thanks!\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2242841) (merged 913ef867 into 1be2a55a).\n",
"@kennethreitz So fast!!!!!\n"
] |
https://api.github.com/repos/psf/requests/issues/814 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/814/labels{/name} | https://api.github.com/repos/psf/requests/issues/814/comments | https://api.github.com/repos/psf/requests/issues/814/events | https://github.com/psf/requests/pull/814 | 6,459,857 | MDExOlB1bGxSZXF1ZXN0MjE2MzY0Mw== | 814 | import cchardet if available | {
"avatar_url": "https://avatars.githubusercontent.com/u/1910945?v=4",
"events_url": "https://api.github.com/users/asapo/events{/privacy}",
"followers_url": "https://api.github.com/users/asapo/followers",
"following_url": "https://api.github.com/users/asapo/following{/other_user}",
"gists_url": "https://api.github.com/users/asapo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asapo",
"id": 1910945,
"login": "asapo",
"node_id": "MDQ6VXNlcjE5MTA5NDU=",
"organizations_url": "https://api.github.com/users/asapo/orgs",
"received_events_url": "https://api.github.com/users/asapo/received_events",
"repos_url": "https://api.github.com/users/asapo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asapo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asapo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asapo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-26T16:30:41Z | 2021-09-08T10:01:06Z | 2012-08-26T16:47:10Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/814/reactions"
} | https://api.github.com/repos/psf/requests/issues/814/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/814.diff",
"html_url": "https://github.com/psf/requests/pull/814",
"merged_at": "2012-08-26T16:47:10Z",
"patch_url": "https://github.com/psf/requests/pull/814.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/814"
} | true | [
"I'll consider this in the future, but chardet doesn't seem to be causing any problems for anyone. :)\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2242765) (merged fc9b8a02 into 1be2a55a).\n",
"OK\nBut chardet has some problem.\n\nExample: http://m-p.sakura.ne.jp/Html/anime.... | |
https://api.github.com/repos/psf/requests/issues/813 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/813/labels{/name} | https://api.github.com/repos/psf/requests/issues/813/comments | https://api.github.com/repos/psf/requests/issues/813/events | https://github.com/psf/requests/pull/813 | 6,459,793 | MDExOlB1bGxSZXF1ZXN0MjE2MzYyMA== | 813 | import cchardet if available | {
"avatar_url": "https://avatars.githubusercontent.com/u/1910945?v=4",
"events_url": "https://api.github.com/users/asapo/events{/privacy}",
"followers_url": "https://api.github.com/users/asapo/followers",
"following_url": "https://api.github.com/users/asapo/following{/other_user}",
"gists_url": "https://api.github.com/users/asapo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asapo",
"id": 1910945,
"login": "asapo",
"node_id": "MDQ6VXNlcjE5MTA5NDU=",
"organizations_url": "https://api.github.com/users/asapo/orgs",
"received_events_url": "https://api.github.com/users/asapo/received_events",
"repos_url": "https://api.github.com/users/asapo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asapo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asapo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asapo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-26T16:22:22Z | 2021-09-08T16:00:58Z | 2012-08-26T16:25:54Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1910945?v=4",
"events_url": "https://api.github.com/users/asapo/events{/privacy}",
"followers_url": "https://api.github.com/users/asapo/followers",
"following_url": "https://api.github.com/users/asapo/following{/other_user}",
"gists_url": "https://api.github.com/users/asapo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asapo",
"id": 1910945,
"login": "asapo",
"node_id": "MDQ6VXNlcjE5MTA5NDU=",
"organizations_url": "https://api.github.com/users/asapo/orgs",
"received_events_url": "https://api.github.com/users/asapo/received_events",
"repos_url": "https://api.github.com/users/asapo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asapo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asapo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asapo",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/813/reactions"
} | https://api.github.com/repos/psf/requests/issues/813/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/813.diff",
"html_url": "https://github.com/psf/requests/pull/813",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/813.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/813"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2242726) (merged 9143def7 into 1be2a55a).\n",
"I'll consider this in the future, but chardet doesn't seem to be causing any problems for anyone.\n"
] | |
https://api.github.com/repos/psf/requests/issues/812 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/812/labels{/name} | https://api.github.com/repos/psf/requests/issues/812/comments | https://api.github.com/repos/psf/requests/issues/812/events | https://github.com/psf/requests/issues/812 | 6,456,735 | MDU6SXNzdWU2NDU2NzM1 | 812 | Parsing of "Allow" Headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/897351?v=4",
"events_url": "https://api.github.com/users/rhyselsmore/events{/privacy}",
"followers_url": "https://api.github.com/users/rhyselsmore/followers",
"following_url": "https://api.github.com/users/rhyselsmore/following{/other_user}",
"gists_url": "https://api.github.com/users/rhyselsmore/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rhyselsmore",
"id": 897351,
"login": "rhyselsmore",
"node_id": "MDQ6VXNlcjg5NzM1MQ==",
"organizations_url": "https://api.github.com/users/rhyselsmore/orgs",
"received_events_url": "https://api.github.com/users/rhyselsmore/received_events",
"repos_url": "https://api.github.com/users/rhyselsmore/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rhyselsmore/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rhyselsmore/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rhyselsmore",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2012-08-26T05:51:07Z | 2021-09-09T05:30:48Z | 2012-11-24T11:36:49Z | NONE | resolved | As per the RFC (RFC2616), the "OPTIONS" method is used to identify communication options on the request/response chain.
Within a RESTful System, the OPTIONS method can be used to display which methods are allowed for the authenticated user.
Typically they are returned as comma-seperated values within the 'Allow' header.
e.g Allow: GET, POST, PUT
These non-cacheable headers allow for a client to discover the methods available against a resource.
I am proposing that the allow headers are parsed if available, and presented within a pragmatic and pythonic way.
Here are my thoughts so far (note that the github API does not support options for any of the methods I tried, this is all theoretical):
> > > a = requests.options('https://github.com')
> > > a.allow('get')
> > > True
> > > a.allow('post')
> > > False
Some key things to think of:
- Some API will not return allow headers when options is called.
- Should this parsing be available only for the options call. Within a RESTful architecture no other method should return the "Allow" header.
- All comparisons should be completed on lowercase strings.
Can I get your thoughts around introducing this header parsing for the OPTIONS method?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/812/reactions"
} | https://api.github.com/repos/psf/requests/issues/812/timeline | null | completed | null | null | false | [
"If parsing of Allow headers was in any way complicated, I'd be all for this feature. However, Allow headers have got a pretty simple form, so they aren't tough for the end user to parse if they need to. This seems like it would be an addition to the API for no particular gain in simplicity or function.\n"
] |
https://api.github.com/repos/psf/requests/issues/811 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/811/labels{/name} | https://api.github.com/repos/psf/requests/issues/811/comments | https://api.github.com/repos/psf/requests/issues/811/events | https://github.com/psf/requests/pull/811 | 6,451,526 | MDExOlB1bGxSZXF1ZXN0MjE2MTM5Mw== | 811 | Remove exception eating from dispatch_hook. | {
"avatar_url": "https://avatars.githubusercontent.com/u/101894?v=4",
"events_url": "https://api.github.com/users/lucian1900/events{/privacy}",
"followers_url": "https://api.github.com/users/lucian1900/followers",
"following_url": "https://api.github.com/users/lucian1900/following{/other_user}",
"gists_url": "https://api.github.com/users/lucian1900/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lucian1900",
"id": 101894,
"login": "lucian1900",
"node_id": "MDQ6VXNlcjEwMTg5NA==",
"organizations_url": "https://api.github.com/users/lucian1900/orgs",
"received_events_url": "https://api.github.com/users/lucian1900/received_events",
"repos_url": "https://api.github.com/users/lucian1900/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lucian1900/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lucian1900/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lucian1900",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-25T15:02:54Z | 2021-09-08T23:06:09Z | 2012-08-25T15:06:56Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/811/reactions"
} | https://api.github.com/repos/psf/requests/issues/811/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/811.diff",
"html_url": "https://github.com/psf/requests/pull/811",
"merged_at": "2012-08-25T15:06:56Z",
"patch_url": "https://github.com/psf/requests/pull/811.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/811"
} | true | [
"Resolves #782.\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2235143) (merged 57b4d397 into 94869e72).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2235147) (merged 57b4d397 into 94869e72).\n",
":cake:\n"
] | |
https://api.github.com/repos/psf/requests/issues/810 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/810/labels{/name} | https://api.github.com/repos/psf/requests/issues/810/comments | https://api.github.com/repos/psf/requests/issues/810/events | https://github.com/psf/requests/issues/810 | 6,450,034 | MDU6SXNzdWU2NDUwMDM0 | 810 | Certificate verification errors not end-user friendly | {
"avatar_url": "https://avatars.githubusercontent.com/u/975735?v=4",
"events_url": "https://api.github.com/users/Bluehorn/events{/privacy}",
"followers_url": "https://api.github.com/users/Bluehorn/followers",
"following_url": "https://api.github.com/users/Bluehorn/following{/other_user}",
"gists_url": "https://api.github.com/users/Bluehorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Bluehorn",
"id": 975735,
"login": "Bluehorn",
"node_id": "MDQ6VXNlcjk3NTczNQ==",
"organizations_url": "https://api.github.com/users/Bluehorn/orgs",
"received_events_url": "https://api.github.com/users/Bluehorn/received_events",
"repos_url": "https://api.github.com/users/Bluehorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Bluehorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bluehorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Bluehorn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2012-08-25T10:27:25Z | 2021-09-09T06:00:47Z | 2012-08-25T14:30:23Z | NONE | resolved | We are currently using requests in a rich client application (still in development). It is indeed a great improvement over urllib2 and friends! Especially it is great that it does verify the server certificate when using https.
The error reporting though is quite lacking - the API reports a single SSLError for any verification failure:
```
SSLError: [Errno 1] _ssl.c:504: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
```
In this case the host name did not match the name given in the certificate but it is not possible to infer that from the Exception. When accessing the same site from Firefox I get
```
<host.example.com> uses an invalid security certificate.
The certificate is not trusted because it is self-signed.
The certificate is only valid for <otherhost.example.com>
(Error code: sec_error_untrusted_issuer)
```
I think requests should report similar information in the result exception for SSLError.
I know this is asking for much since the underlying SSL modules do not do this yet.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/810/reactions"
} | https://api.github.com/repos/psf/requests/issues/810/timeline | null | completed | null | null | false | [
"I've considered doing this in the past, but due to the complexities of SSL errors (and the fairly hands-off support we have of them), I decided to keep it as transparent as possible. \n\nThis might change in the future though :)\n"
] |
https://api.github.com/repos/psf/requests/issues/809 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/809/labels{/name} | https://api.github.com/repos/psf/requests/issues/809/comments | https://api.github.com/repos/psf/requests/issues/809/events | https://github.com/psf/requests/issues/809 | 6,449,243 | MDU6SXNzdWU2NDQ5MjQz | 809 | Timing of Request | {
"avatar_url": "https://avatars.githubusercontent.com/u/897351?v=4",
"events_url": "https://api.github.com/users/rhyselsmore/events{/privacy}",
"followers_url": "https://api.github.com/users/rhyselsmore/followers",
"following_url": "https://api.github.com/users/rhyselsmore/following{/other_user}",
"gists_url": "https://api.github.com/users/rhyselsmore/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rhyselsmore",
"id": 897351,
"login": "rhyselsmore",
"node_id": "MDQ6VXNlcjg5NzM1MQ==",
"organizations_url": "https://api.github.com/users/rhyselsmore/orgs",
"received_events_url": "https://api.github.com/users/rhyselsmore/received_events",
"repos_url": "https://api.github.com/users/rhyselsmore/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rhyselsmore/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rhyselsmore/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rhyselsmore",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-25T07:39:47Z | 2021-09-09T06:00:46Z | 2012-08-25T14:31:27Z | NONE | resolved | I am not sure if this is out of scope of requests, but I was wondering about the implementation of some sort of request time metric, as in the time it takes from the start to completion of the request.
For example:
> > > resp = requests.get('https://github.com')
> > > resp.time #(or something similar)
> > > 124ms # (Represented as ms/seconds etc, but actually returned as milliseconds within a time object or similar)
I am more then happy to get started on this, I would just like a discussion about the relevance of this feature to the context and purpose of requests as a package.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/809/reactions"
} | https://api.github.com/repos/psf/requests/issues/809/timeline | null | completed | null | null | false | [
"I considered adding this early on, actually, but decided to keep the scope of the library as concise as possible. It's pretty easy to do this now with the existing hooks system, which seems to be what people are doing now.\n\n---\n\nKeep this issues coming though, these are great :)\n",
"Thanks for the response ... |
https://api.github.com/repos/psf/requests/issues/808 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/808/labels{/name} | https://api.github.com/repos/psf/requests/issues/808/comments | https://api.github.com/repos/psf/requests/issues/808/events | https://github.com/psf/requests/issues/808 | 6,443,231 | MDU6SXNzdWU2NDQzMjMx | 808 | updateStatusWithMedia not working | {
"avatar_url": "https://avatars.githubusercontent.com/u/613045?v=4",
"events_url": "https://api.github.com/users/y2rayk/events{/privacy}",
"followers_url": "https://api.github.com/users/y2rayk/followers",
"following_url": "https://api.github.com/users/y2rayk/following{/other_user}",
"gists_url": "https://api.github.com/users/y2rayk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/y2rayk",
"id": 613045,
"login": "y2rayk",
"node_id": "MDQ6VXNlcjYxMzA0NQ==",
"organizations_url": "https://api.github.com/users/y2rayk/orgs",
"received_events_url": "https://api.github.com/users/y2rayk/received_events",
"repos_url": "https://api.github.com/users/y2rayk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/y2rayk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/y2rayk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/y2rayk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-24T20:16:38Z | 2021-09-09T05:30:58Z | 2012-08-25T14:50:25Z | NONE | resolved | i think this could be related to the other issue "Post not working".
i get an error:
twython.twython.TwythonError: u'Unauthorized: Authentication credentials were missing or incorrect. -- Could not authenticate you.'
for a workaround, until this get fixes, i had to generate the headers to work. here is an example workaround:
from twython import Twython
twitter = Twython(
twitter_token = 'XXXXX',
twitter_secret = 'XXXX',
oauth_token = 'XXXX',
oauth_token_secret = 'XXXX',
headers = { "Authorization": 'OAuth oauth_consumer_key="XXXXX", oauth_nonce="XXXXX", oauth_signature="XXXX", oauth_signature_method="HMAC-SHA1", oauth_timestamp="1345442", oauth_token="XXXXXXX", oauth_version="1.0"' }
)
twitter.updateStatusWithMedia('sample.jpg', status='hello!')
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/808/reactions"
} | https://api.github.com/repos/psf/requests/issues/808/timeline | null | completed | null | null | false | [
"This should be better now :)\n",
"still does not work for me ... \n\n``` python\n response = twitterImage.updateStatusWithMedia(\"C:\\\\Users\\\\Desktop\\\\python-twitter-0.8.2\\\\examples\\\\data\\\\1.png\", status='thats me :)')\n File \"build\\bdist.win32\\egg\\twython\\twython.py\", line 445, in updateSt... |
https://api.github.com/repos/psf/requests/issues/807 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/807/labels{/name} | https://api.github.com/repos/psf/requests/issues/807/comments | https://api.github.com/repos/psf/requests/issues/807/events | https://github.com/psf/requests/issues/807 | 6,416,418 | MDU6SXNzdWU2NDE2NDE4 | 807 | Add option to strip headers on redirect | {
"avatar_url": "https://avatars.githubusercontent.com/u/188302?v=4",
"events_url": "https://api.github.com/users/hamstah/events{/privacy}",
"followers_url": "https://api.github.com/users/hamstah/followers",
"following_url": "https://api.github.com/users/hamstah/following{/other_user}",
"gists_url": "https://api.github.com/users/hamstah/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hamstah",
"id": 188302,
"login": "hamstah",
"node_id": "MDQ6VXNlcjE4ODMwMg==",
"organizations_url": "https://api.github.com/users/hamstah/orgs",
"received_events_url": "https://api.github.com/users/hamstah/received_events",
"repos_url": "https://api.github.com/users/hamstah/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hamstah/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hamstah/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hamstah",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2012-08-23T18:54:42Z | 2021-09-09T06:00:48Z | 2012-08-24T01:21:26Z | NONE | resolved | When a request is redirect, most headers are sent to the new location.
This poses a problem with authentication headers and privacy in general.
It would be nice to have an option/setting to decide to strip all headers, or whitelist headers that are ok to carry on redirect.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/807/reactions"
} | https://api.github.com/repos/psf/requests/issues/807/timeline | null | completed | null | null | false | [
"I've considered this in the past, but i'll consider it more in the future. \n\nThanks for the suggestion!\n"
] |
https://api.github.com/repos/psf/requests/issues/806 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/806/labels{/name} | https://api.github.com/repos/psf/requests/issues/806/comments | https://api.github.com/repos/psf/requests/issues/806/events | https://github.com/psf/requests/pull/806 | 6,398,286 | MDExOlB1bGxSZXF1ZXN0MjEzNTYyNA== | 806 | General Housekeeping | {
"avatar_url": "https://avatars.githubusercontent.com/u/897351?v=4",
"events_url": "https://api.github.com/users/rhyselsmore/events{/privacy}",
"followers_url": "https://api.github.com/users/rhyselsmore/followers",
"following_url": "https://api.github.com/users/rhyselsmore/following{/other_user}",
"gists_url": "https://api.github.com/users/rhyselsmore/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rhyselsmore",
"id": 897351,
"login": "rhyselsmore",
"node_id": "MDQ6VXNlcjg5NzM1MQ==",
"organizations_url": "https://api.github.com/users/rhyselsmore/orgs",
"received_events_url": "https://api.github.com/users/rhyselsmore/received_events",
"repos_url": "https://api.github.com/users/rhyselsmore/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rhyselsmore/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rhyselsmore/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rhyselsmore",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-23T06:20:47Z | 2021-09-08T16:00:58Z | 2012-08-25T04:48:30Z | NONE | resolved | os was imported twice.
Not much of a change. Tests worked A-Ok
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/806/reactions"
} | https://api.github.com/repos/psf/requests/issues/806/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/806.diff",
"html_url": "https://github.com/psf/requests/pull/806",
"merged_at": "2012-08-25T04:48:30Z",
"patch_url": "https://github.com/psf/requests/pull/806.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/806"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2209649) (merged 217a9d50 into 4889adce).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2209653) (merged 217a9d50 into 4889adce).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/re... |
https://api.github.com/repos/psf/requests/issues/805 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/805/labels{/name} | https://api.github.com/repos/psf/requests/issues/805/comments | https://api.github.com/repos/psf/requests/issues/805/events | https://github.com/psf/requests/pull/805 | 6,391,525 | MDExOlB1bGxSZXF1ZXN0MjEzMjQwMQ== | 805 | Remove None values from post data. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-22T21:35:59Z | 2021-09-08T16:00:57Z | 2012-08-25T14:35:06Z | MEMBER | resolved | This pull request resolves the discussion in #378 by preventing None values from being posted.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/805/reactions"
} | https://api.github.com/repos/psf/requests/issues/805/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/805.diff",
"html_url": "https://github.com/psf/requests/pull/805",
"merged_at": "2012-08-25T14:35:06Z",
"patch_url": "https://github.com/psf/requests/pull/805.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/805"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2206075) (merged 751e7a0a into 4889adce).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2206079) (merged 751e7a0a into 4889adce).\n",
"Awesome, thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/804 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/804/labels{/name} | https://api.github.com/repos/psf/requests/issues/804/comments | https://api.github.com/repos/psf/requests/issues/804/events | https://github.com/psf/requests/issues/804 | 6,375,435 | MDU6SXNzdWU2Mzc1NDM1 | 804 | Session params ommited in 0.13.8 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1542066?v=4",
"events_url": "https://api.github.com/users/dorvak/events{/privacy}",
"followers_url": "https://api.github.com/users/dorvak/followers",
"following_url": "https://api.github.com/users/dorvak/following{/other_user}",
"gists_url": "https://api.github.com/users/dorvak/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dorvak",
"id": 1542066,
"login": "dorvak",
"node_id": "MDQ6VXNlcjE1NDIwNjY=",
"organizations_url": "https://api.github.com/users/dorvak/orgs",
"received_events_url": "https://api.github.com/users/dorvak/received_events",
"repos_url": "https://api.github.com/users/dorvak/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dorvak/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dorvak/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dorvak",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2012-08-22T12:08:13Z | 2021-09-09T06:00:44Z | 2012-08-25T14:34:31Z | NONE | resolved | Whenn subclassing the Session class like this:
class TubeQuery(Session):
```
def __init__(self):
super(TubeQuery,self).__init__(params={'v':'2','key':devkey,"alt":"json"})
self.server="http://gdata.youtube.com"
self.key=devkey
```
and then using the session in a "with"-statement, the params are not passed anymore, since 0.13.8. Is this supposed to be like that?
with self as req:
reg.get(self.server+"foobar")
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/804/reactions"
} | https://api.github.com/repos/psf/requests/issues/804/timeline | null | completed | null | null | false | [
"This seems to be broken by [1722f289](https://github.com/kennethreitz/requests/commit/1722f289711e3d03b0e00fb548f3e8ea92544775). Since params and proxies are no longer dictionaries and are lists of tuples instead, they no longer have an 'items' function, which is a check in the session#merge_kwargs() function. T... |
https://api.github.com/repos/psf/requests/issues/803 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/803/labels{/name} | https://api.github.com/repos/psf/requests/issues/803/comments | https://api.github.com/repos/psf/requests/issues/803/events | https://github.com/psf/requests/pull/803 | 6,351,979 | MDExOlB1bGxSZXF1ZXN0MjExNDQ4Nw== | 803 | Custom mimetypes for files in multipart request | {
"avatar_url": "https://avatars.githubusercontent.com/u/582622?v=4",
"events_url": "https://api.github.com/users/vasa81/events{/privacy}",
"followers_url": "https://api.github.com/users/vasa81/followers",
"following_url": "https://api.github.com/users/vasa81/following{/other_user}",
"gists_url": "https://api.github.com/users/vasa81/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vasa81",
"id": 582622,
"login": "vasa81",
"node_id": "MDQ6VXNlcjU4MjYyMg==",
"organizations_url": "https://api.github.com/users/vasa81/orgs",
"received_events_url": "https://api.github.com/users/vasa81/received_events",
"repos_url": "https://api.github.com/users/vasa81/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vasa81/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vasa81/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vasa81",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2012-08-21T14:40:05Z | 2021-09-08T23:05:16Z | 2012-08-25T14:35:37Z | NONE | resolved | I added support for custom mimetypes in mutipart request.
Usage:
r = requests.post(url, files={'file': ('file.xml', file_content)})
or
r = requests.post(url, files={'file': ('file.xml', file_content, 'text/xml')})
or
r = requests.post(url, files={'file': ('file.xml', file_content, 'application/xml')})
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 1,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/803/reactions"
} | https://api.github.com/repos/psf/requests/issues/803/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/803.diff",
"html_url": "https://github.com/psf/requests/pull/803",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/803.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/803"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2189646) (merged 2f9b4b41 into 4889adce).\n",
"Part of this should actually be a PR on shazow/urllib3 and the other part would depend on @shazow accepting it unless I'm speaking out of turn.\n",
"This pull request [passes](http://trav... |
https://api.github.com/repos/psf/requests/issues/802 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/802/labels{/name} | https://api.github.com/repos/psf/requests/issues/802/comments | https://api.github.com/repos/psf/requests/issues/802/events | https://github.com/psf/requests/pull/802 | 6,329,076 | MDExOlB1bGxSZXF1ZXN0MjEwMzc2MA== | 802 | Tiny formatting changes in Advanced docs | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-20T16:02:18Z | 2021-09-08T16:00:57Z | 2012-08-20T16:04:45Z | MEMBER | resolved | Just noticed when checking out the documentation for the new [link headers](http://docs.python-requests.org/en/latest/user/advanced/#link-headers) feature (quite the productive sprint you're having in Hobart! Very cool.) that there were quite a few paragraphs ending in ".:", which was ugly. Removed those, and generally made changes with colons.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/802/reactions"
} | https://api.github.com/repos/psf/requests/issues/802/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/802.diff",
"html_url": "https://github.com/psf/requests/pull/802",
"merged_at": "2012-08-20T16:04:45Z",
"patch_url": "https://github.com/psf/requests/pull/802.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/802"
} | true | [
"Excellent, thanks :)\n",
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2178783) (merged b5ce5029 into c323047d).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2178787) (merged b5ce5029 into c323047d).\n"
] |
https://api.github.com/repos/psf/requests/issues/801 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/801/labels{/name} | https://api.github.com/repos/psf/requests/issues/801/comments | https://api.github.com/repos/psf/requests/issues/801/events | https://github.com/psf/requests/pull/801 | 6,327,152 | MDExOlB1bGxSZXF1ZXN0MjEwMjg3OQ== | 801 | Added in a link handler as per issue #711 | {
"avatar_url": "https://avatars.githubusercontent.com/u/897351?v=4",
"events_url": "https://api.github.com/users/rhyselsmore/events{/privacy}",
"followers_url": "https://api.github.com/users/rhyselsmore/followers",
"following_url": "https://api.github.com/users/rhyselsmore/following{/other_user}",
"gists_url": "https://api.github.com/users/rhyselsmore/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rhyselsmore",
"id": 897351,
"login": "rhyselsmore",
"node_id": "MDQ6VXNlcjg5NzM1MQ==",
"organizations_url": "https://api.github.com/users/rhyselsmore/orgs",
"received_events_url": "https://api.github.com/users/rhyselsmore/received_events",
"repos_url": "https://api.github.com/users/rhyselsmore/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rhyselsmore/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rhyselsmore/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rhyselsmore",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-20T14:49:29Z | 2021-09-08T16:00:56Z | 2012-08-20T14:54:48Z | NONE | resolved | Basic Basic handling of links. So far has very basic error handling, and might not cater for some cases. Handles the syntax of link headers that are demonstrated below.
> > > from requests.utils import parse_header_links
> > > parse_header_links('http:/.../front.jpeg; rel=front; type="image/jpeg",http://.../back.jpeg; rel=back;type="image/jpeg"')
> > > [{'url': 'http:/.../front.jpeg', 'type': 'image/jpeg', 'rel': 'front'}, {'url': 'http://.../back.jpeg', 'type': 'image/jpeg', 'rel': 'back'}]
> > > parse_header_links('http:/.../front.jpeg;')
> > > [{'url': 'http:/.../front.jpeg'}]
> > > parse_header_links('http:/.../front.jpeg')
> > > [{'url': 'http:/.../front.jpeg'}]
> > > parse_header_links('http:/.../front.jpeg; a=t')
> > > [{'url': 'http:/.../front.jpeg', 'a': 't'}]
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/801/reactions"
} | https://api.github.com/repos/psf/requests/issues/801/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/801.diff",
"html_url": "https://github.com/psf/requests/pull/801",
"merged_at": "2012-08-20T14:54:48Z",
"patch_url": "https://github.com/psf/requests/pull/801.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/801"
} | true | [
":sparkles: :cake: :sparkles:\n",
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2178021) (merged f3159ed4 into 3514816d).\n"
] |
https://api.github.com/repos/psf/requests/issues/800 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/800/labels{/name} | https://api.github.com/repos/psf/requests/issues/800/comments | https://api.github.com/repos/psf/requests/issues/800/events | https://github.com/psf/requests/pull/800 | 6,321,180 | MDExOlB1bGxSZXF1ZXN0MjEwMDE1Mw== | 800 | Fix kennethreitz/requests#790 | {
"avatar_url": "https://avatars.githubusercontent.com/u/406779?v=4",
"events_url": "https://api.github.com/users/ayanamist/events{/privacy}",
"followers_url": "https://api.github.com/users/ayanamist/followers",
"following_url": "https://api.github.com/users/ayanamist/following{/other_user}",
"gists_url": "https://api.github.com/users/ayanamist/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ayanamist",
"id": 406779,
"login": "ayanamist",
"node_id": "MDQ6VXNlcjQwNjc3OQ==",
"organizations_url": "https://api.github.com/users/ayanamist/orgs",
"received_events_url": "https://api.github.com/users/ayanamist/received_events",
"repos_url": "https://api.github.com/users/ayanamist/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ayanamist/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ayanamist/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ayanamist",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2012-08-20T09:19:04Z | 2021-09-08T16:00:56Z | 2012-08-25T14:41:15Z | CONTRIBUTOR | resolved | Fix kennethreitz/requests#790
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/800/reactions"
} | https://api.github.com/repos/psf/requests/issues/800/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/800.diff",
"html_url": "https://github.com/psf/requests/pull/800",
"merged_at": "2012-08-25T14:41:15Z",
"patch_url": "https://github.com/psf/requests/pull/800.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/800"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2174801) (merged 301d1a83 into 2d5d6f99).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2174805) (merged 301d1a83 into 2d5d6f99).\n",
"Anyone can handle this?\nWhat the bot said is wrong. It is not ... |
https://api.github.com/repos/psf/requests/issues/799 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/799/labels{/name} | https://api.github.com/repos/psf/requests/issues/799/comments | https://api.github.com/repos/psf/requests/issues/799/events | https://github.com/psf/requests/pull/799 | 6,317,398 | MDExOlB1bGxSZXF1ZXN0MjA5ODY1Ng== | 799 | Fix SSL3 error on Ubuntu 12.04 | {
"avatar_url": "https://avatars.githubusercontent.com/u/503584?v=4",
"events_url": "https://api.github.com/users/joequery/events{/privacy}",
"followers_url": "https://api.github.com/users/joequery/followers",
"following_url": "https://api.github.com/users/joequery/following{/other_user}",
"gists_url": "https://api.github.com/users/joequery/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joequery",
"id": 503584,
"login": "joequery",
"node_id": "MDQ6VXNlcjUwMzU4NA==",
"organizations_url": "https://api.github.com/users/joequery/orgs",
"received_events_url": "https://api.github.com/users/joequery/received_events",
"repos_url": "https://api.github.com/users/joequery/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joequery/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joequery/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joequery",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 22 | 2012-08-20T02:53:22Z | 2021-09-09T00:01:23Z | 2012-08-20T05:38:39Z | CONTRIBUTOR | resolved | When attempting to request (get or post) to a resource responding only to SSL version 3, we'd get the following response on Ubuntu 12.04:
```
>>> import requests
>>> requests.post("https://sis-portal-prod.uttyler.edu/psp/TAPPRD/EMPLOYEE/EMPL/?&cmd=login")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "requests/api.py", line 98, in post
return request('post', url, data=data, **kwargs)
File "requests/safe_mode.py", line 39, in wrapped
return function(method, url, **kwargs)
File "requests/api.py", line 51, in request
return session.request(method=method, url=url, **kwargs)
File "requests/sessions.py", line 243, in request
r.send(prefetch=prefetch)
File "requests/models.py", line 630, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
```
There's a [good number of people](http://www.google.com/search?q=python+error%3A1407742E%3ASSL+routines%3ASSL23_GET_SERVER_HELLO%3Atlsv1+alert+protocol+version&sugexp=chrome,mod=8&sourceid=chrome&ie=UTF-8) having the error.
Fix taken from [this thread](http://bugs.python.org/issue11220). Specs pass. Even if you don't accept this into master, hopefully someone will see this pull request on Google.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/799/reactions"
} | https://api.github.com/repos/psf/requests/issues/799/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/799.diff",
"html_url": "https://github.com/psf/requests/pull/799",
"merged_at": "2012-08-20T05:38:39Z",
"patch_url": "https://github.com/psf/requests/pull/799.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/799"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2173252) (merged 413d4b3d into b130b980).\n",
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2173256) (merged 413d4b3d into b130b980).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requ... |
https://api.github.com/repos/psf/requests/issues/798 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/798/labels{/name} | https://api.github.com/repos/psf/requests/issues/798/comments | https://api.github.com/repos/psf/requests/issues/798/events | https://github.com/psf/requests/issues/798 | 6,317,093 | MDU6SXNzdWU2MzE3MDkz | 798 | Support SSL client certificates | {
"avatar_url": "https://avatars.githubusercontent.com/u/236562?v=4",
"events_url": "https://api.github.com/users/nicois/events{/privacy}",
"followers_url": "https://api.github.com/users/nicois/followers",
"following_url": "https://api.github.com/users/nicois/following{/other_user}",
"gists_url": "https://api.github.com/users/nicois/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nicois",
"id": 236562,
"login": "nicois",
"node_id": "MDQ6VXNlcjIzNjU2Mg==",
"organizations_url": "https://api.github.com/users/nicois/orgs",
"received_events_url": "https://api.github.com/users/nicois/received_events",
"repos_url": "https://api.github.com/users/nicois/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nicois/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nicois/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nicois",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-20T02:08:43Z | 2021-09-09T06:00:49Z | 2012-08-20T02:12:49Z | NONE | resolved | It would be handy if we could support HTTP transactions where the server required client-side SSL authentication.
An ugly urllib2/httplib implementation is here: http://stackoverflow.com/a/5899320
I imagine a sample interaction would look something like this:
```
response = requests.get(url, client_cert="/path/to/cert", client_key="/path/to/key")
```
or
```
response = requests.get(url, pem="/path/to/pem")
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/798/reactions"
} | https://api.github.com/repos/psf/requests/issues/798/timeline | null | completed | null | null | false | [
"These are fully supported.\n",
"They just happen to be fully undocumented :)\n",
"Oops, I take that back:\n\nhttp://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification\n"
] |
https://api.github.com/repos/psf/requests/issues/797 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/797/labels{/name} | https://api.github.com/repos/psf/requests/issues/797/comments | https://api.github.com/repos/psf/requests/issues/797/events | https://github.com/psf/requests/pull/797 | 6,314,955 | MDExOlB1bGxSZXF1ZXN0MjA5NzkwNQ== | 797 | Fix order of data+params | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-19T20:40:47Z | 2021-09-08T16:00:56Z | 2012-08-20T07:55:17Z | CONTRIBUTOR | resolved | There's an important fix in the code that I found when Travis ran the tests after the first commit in this PR. It was a mistake I made in not keeping my naming consistent.
Related to #795
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/797/reactions"
} | https://api.github.com/repos/psf/requests/issues/797/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/797.diff",
"html_url": "https://github.com/psf/requests/pull/797",
"merged_at": "2012-08-20T07:55:17Z",
"patch_url": "https://github.com/psf/requests/pull/797.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/797"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2171155) (merged 6d418d91 into b130b980).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2171159) (merged 6d418d91 into b130b980).\n",
"Thanks!\n",
"You're welcome. Thanks for requests.\n"
] |
https://api.github.com/repos/psf/requests/issues/796 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/796/labels{/name} | https://api.github.com/repos/psf/requests/issues/796/comments | https://api.github.com/repos/psf/requests/issues/796/events | https://github.com/psf/requests/pull/796 | 6,314,925 | MDExOlB1bGxSZXF1ZXN0MjA5Nzg5Mw== | 796 | Fix ordering of data + params | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-19T20:37:20Z | 2021-09-08T16:00:55Z | 2012-08-19T20:37:56Z | CONTRIBUTOR | resolved | Also there's an important fix in the code that I found when Travis ran the tests after the first commit. It was a mistake I made in not keeping my naming consistent.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/796/reactions"
} | https://api.github.com/repos/psf/requests/issues/796/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/796.diff",
"html_url": "https://github.com/psf/requests/pull/796",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/796.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/796"
} | true | [
"Actually, I have some bizarre commits here, let me fix that and submit a new pr.\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2171113) (merged 4fdcfe1b into b130b980).\n"
] |
https://api.github.com/repos/psf/requests/issues/795 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/795/labels{/name} | https://api.github.com/repos/psf/requests/issues/795/comments | https://api.github.com/repos/psf/requests/issues/795/events | https://github.com/psf/requests/issues/795 | 6,314,113 | MDU6SXNzdWU2MzE0MTEz | 795 | Order of operations | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-19T18:40:51Z | 2021-09-09T06:00:49Z | 2012-08-20T07:55:18Z | CONTRIBUTOR | resolved | So I realized in changing github3.py's download creation function that when @jkbr changed the encoding of files (`_encode_files`) he inserted the file tuples first. So making a call like:
``` python
from requests import post
r = post('http://httpbin.org/post', data=[('some', 'data'), ('some', 'more data')], files=[('file', open(__file__, 'rb'))])
```
Will actually have the structure (sent to urllib3) of
``` python
[('file', '<data from __file__>'), ('some', 'data'), ('some', 'more data')]
```
Whereas before that it would be:
``` python
[('some', 'data'), ('some', 'more data'), ('file', '<data from __file__>')]
```
And this changes the previously expected/exhibited behavior. I kept that construction assuming it had been approved, but I can't find that and I'm not sure if anyone was aware of this. I can change the ordering very easily, but I was wondering if I should or if this is ok.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/795/reactions"
} | https://api.github.com/repos/psf/requests/issues/795/timeline | null | completed | null | null | false | [
"The ordering change I made wasn't really intentional. I think it's a good idea to switch back to the original ordering for the sake of consistency.\n",
"Ah ok, I'll just wait for word from @kennethreitz before issuing the pull request.\n"
] |
https://api.github.com/repos/psf/requests/issues/794 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/794/labels{/name} | https://api.github.com/repos/psf/requests/issues/794/comments | https://api.github.com/repos/psf/requests/issues/794/events | https://github.com/psf/requests/issues/794 | 6,310,449 | MDU6SXNzdWU2MzEwNDQ5 | 794 | Comma encoding in request params | {
"avatar_url": "https://avatars.githubusercontent.com/u/212338?v=4",
"events_url": "https://api.github.com/users/sweenzor/events{/privacy}",
"followers_url": "https://api.github.com/users/sweenzor/followers",
"following_url": "https://api.github.com/users/sweenzor/following{/other_user}",
"gists_url": "https://api.github.com/users/sweenzor/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sweenzor",
"id": 212338,
"login": "sweenzor",
"node_id": "MDQ6VXNlcjIxMjMzOA==",
"organizations_url": "https://api.github.com/users/sweenzor/orgs",
"received_events_url": "https://api.github.com/users/sweenzor/received_events",
"repos_url": "https://api.github.com/users/sweenzor/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sweenzor/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sweenzor/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sweenzor",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2012-08-19T06:51:38Z | 2021-09-07T00:06:22Z | 2012-08-20T01:51:31Z | CONTRIBUTOR | resolved | I'm making requests against an API which takes comma separated parameter values.
A working request looks like this:
```
curl http://localhost:4444/endpoint?val=555,666
```
When I pass these parameters in with `requests.get()` however, the resulting URL looks like this:
```
>>> r = requests.get('http://localhost:4444/endpoint/', params={'val': '555,666'})
>>> r.url
u'http://localhost:4444/endpoint/?val=555%2C666'
```
I can build the URL myself, but I'm wondering if this is the intended behavior?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/794/reactions"
} | https://api.github.com/repos/psf/requests/issues/794/timeline | null | completed | null | null | false | [
"Ehh...standards are hard.\n\nThe comma (along with some other characters) is defined in [RFC 3986](http://pretty-rfc.herokuapp.com/RFC3986#reserved) as a reserved character. This means the comma has defined meaning at various parts in a URL, and if it is not being used in that context it needs to be percent-encode... |
https://api.github.com/repos/psf/requests/issues/793 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/793/labels{/name} | https://api.github.com/repos/psf/requests/issues/793/comments | https://api.github.com/repos/psf/requests/issues/793/events | https://github.com/psf/requests/pull/793 | 6,307,757 | MDExOlB1bGxSZXF1ZXN0MjA5NTc3OQ== | 793 | Typo fix in tests. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-18T20:24:45Z | 2021-09-08T16:00:55Z | 2012-08-18T21:32:48Z | MEMBER | resolved | Addresses #792.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/793/reactions"
} | https://api.github.com/repos/psf/requests/issues/793/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/793.diff",
"html_url": "https://github.com/psf/requests/pull/793",
"merged_at": "2012-08-18T21:32:48Z",
"patch_url": "https://github.com/psf/requests/pull/793.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/793"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2163928) (merged a04775f8 into cb0fdd80).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2163932) (merged a04775f8 into cb0fdd80).\n",
"thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/792 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/792/labels{/name} | https://api.github.com/repos/psf/requests/issues/792/comments | https://api.github.com/repos/psf/requests/issues/792/events | https://github.com/psf/requests/issues/792 | 6,306,967 | MDU6SXNzdWU2MzA2OTY3 | 792 | Typo in tests/test_requests_ext.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/656294?v=4",
"events_url": "https://api.github.com/users/Arfrever/events{/privacy}",
"followers_url": "https://api.github.com/users/Arfrever/followers",
"following_url": "https://api.github.com/users/Arfrever/following{/other_user}",
"gists_url": "https://api.github.com/users/Arfrever/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Arfrever",
"id": 656294,
"login": "Arfrever",
"node_id": "MDQ6VXNlcjY1NjI5NA==",
"organizations_url": "https://api.github.com/users/Arfrever/orgs",
"received_events_url": "https://api.github.com/users/Arfrever/received_events",
"repos_url": "https://api.github.com/users/Arfrever/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Arfrever/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Arfrever/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Arfrever",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-18T18:12:16Z | 2021-09-09T06:00:50Z | 2012-08-19T10:31:42Z | NONE | resolved | tests/test_requests_ext.py seems to contain a typo in RequestsTestSuite.test_cookies_on_redirects().
The last lines in this function are:
```
# get cookies on another domain
r2 = s.get(url='http://httpbin.org/cookies')
# the cookie is not there
self.assertTrue('preview' not in json.loads(r2.text)['cookies'])
# this redirects to another domain, httpbin.org
# cookies of the first domain should NOT be sent to the next one
r3 = s.get(url='http://tinyurl.com/7zp3jnr')
assert r3.url == 'http://httpbin.org/cookies'
self.assertTrue('preview' not in json.loads(r2.text)['cookies'])
```
r2.text should be r3.text in last line.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/792/reactions"
} | https://api.github.com/repos/psf/requests/issues/792/timeline | null | completed | null | null | false | [
"Fix is in Pull Request #793.\n",
"Nice catch\n"
] |
https://api.github.com/repos/psf/requests/issues/791 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/791/labels{/name} | https://api.github.com/repos/psf/requests/issues/791/comments | https://api.github.com/repos/psf/requests/issues/791/events | https://github.com/psf/requests/pull/791 | 6,306,855 | MDExOlB1bGxSZXF1ZXN0MjA5NTQ3MQ== | 791 | Key val lists | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 11 | 2012-08-18T17:50:27Z | 2021-09-08T16:00:54Z | 2012-08-18T22:54:49Z | CONTRIBUTOR | resolved | Accept lists of `(key, val)` tuples everywhere.
This should close/solve issue #179. Unfortunately @jkbr had duplicated some of the effort so I had to remove his contributions there, but all the tests pass.
Also, I apologize in advance for the likely very ugly history. I wanted to keep up-to-date while working on this so there are a few (possibly unnecessary) merge commits.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/791/reactions"
} | https://api.github.com/repos/psf/requests/issues/791/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/791.diff",
"html_url": "https://github.com/psf/requests/pull/791",
"merged_at": "2012-08-18T22:54:49Z",
"patch_url": "https://github.com/psf/requests/pull/791.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/791"
} | true | [
"Scratch that, python 3 is failing. \n",
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2163101) (merged f01694e2 into cb0fdd80).\n",
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2163113) (merged f01694e2 into cb0fdd80).\n",
"This pull request [pas... |
https://api.github.com/repos/psf/requests/issues/790 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/790/labels{/name} | https://api.github.com/repos/psf/requests/issues/790/comments | https://api.github.com/repos/psf/requests/issues/790/events | https://github.com/psf/requests/issues/790 | 6,305,622 | MDU6SXNzdWU2MzA1NjIy | 790 | oauth post does not work | {
"avatar_url": "https://avatars.githubusercontent.com/u/406779?v=4",
"events_url": "https://api.github.com/users/ayanamist/events{/privacy}",
"followers_url": "https://api.github.com/users/ayanamist/followers",
"following_url": "https://api.github.com/users/ayanamist/following{/other_user}",
"gists_url": "https://api.github.com/users/ayanamist/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ayanamist",
"id": 406779,
"login": "ayanamist",
"node_id": "MDQ6VXNlcjQwNjc3OQ==",
"organizations_url": "https://api.github.com/users/ayanamist/orgs",
"received_events_url": "https://api.github.com/users/ayanamist/received_events",
"repos_url": "https://api.github.com/users/ayanamist/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ayanamist/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ayanamist/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ayanamist",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2012-08-18T14:15:07Z | 2021-09-09T06:00:46Z | 2012-08-25T14:45:54Z | CONTRIBUTOR | resolved | Since requests can be attached with an auth method, and there is oauth files in the package, so we can pass auth method to requests in order to archive auto auth function.
However, the code of oauth is conflicting with current trunk code.
Let's see
https://github.com/kennethreitz/requests/blob/develop/requests/models.py#L535
So if i pass in a dict object as post data, content-type will be set automatically.
Then see here
https://github.com/kennethreitz/requests/blob/develop/requests/auth.py#L81
If content-type is set, oauth won't work! It expects signing will be executed by manual operation!
Let's summarize all things:
Content-Type is set for the existence of non-plain dict object, oauth rejects to work for the existence of content-type.
WTF!
Either cancel automatically adding content-type or always sign the request without thinking about content-type will finally solve the problem.
Plz fix it.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/790/reactions"
} | https://api.github.com/repos/psf/requests/issues/790/timeline | null | completed | null | null | false | [
"So, I know nothing about OAuth, but it looks like we just shouldn't be checking the Content Type header. The OAuth code appears to check for the presence of a file anyway, so it doesn't seem like it matters.\n\nThoughts @kennethreitz?\n",
"So nobody cares?\n@kennethreitz has so many activities today.\n",
"I'm ... |
https://api.github.com/repos/psf/requests/issues/789 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/789/labels{/name} | https://api.github.com/repos/psf/requests/issues/789/comments | https://api.github.com/repos/psf/requests/issues/789/events | https://github.com/psf/requests/pull/789 | 6,303,234 | MDExOlB1bGxSZXF1ZXN0MjA5NDM2NQ== | 789 | HTTPDigestAuth fixes | {
"avatar_url": "https://avatars.githubusercontent.com/u/2172830?v=4",
"events_url": "https://api.github.com/users/zigmonty/events{/privacy}",
"followers_url": "https://api.github.com/users/zigmonty/followers",
"following_url": "https://api.github.com/users/zigmonty/following{/other_user}",
"gists_url": "https://api.github.com/users/zigmonty/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zigmonty",
"id": 2172830,
"login": "zigmonty",
"node_id": "MDQ6VXNlcjIxNzI4MzA=",
"organizations_url": "https://api.github.com/users/zigmonty/orgs",
"received_events_url": "https://api.github.com/users/zigmonty/received_events",
"repos_url": "https://api.github.com/users/zigmonty/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zigmonty/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zigmonty/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zigmonty",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-18T05:41:58Z | 2021-09-08T16:00:55Z | 2012-08-19T00:42:41Z | CONTRIBUTOR | resolved | Fixes issues described in #788.
Also extended the digest test case to do two requests with digest auth and check the history length to confirm the second one is zero (ie no second 401).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/789/reactions"
} | https://api.github.com/repos/psf/requests/issues/789/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/789.diff",
"html_url": "https://github.com/psf/requests/pull/789",
"merged_at": "2012-08-19T00:42:41Z",
"patch_url": "https://github.com/psf/requests/pull/789.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/789"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2158977) (merged 6d020360 into cb0fdd80).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2158981) (merged 6d020360 into cb0fdd80).\n",
"This is beautiful. Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/788 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/788/labels{/name} | https://api.github.com/repos/psf/requests/issues/788/comments | https://api.github.com/repos/psf/requests/issues/788/events | https://github.com/psf/requests/issues/788 | 6,303,030 | MDU6SXNzdWU2MzAzMDMw | 788 | HTTPDigestAuth doesn't retain credentials | {
"avatar_url": "https://avatars.githubusercontent.com/u/2172830?v=4",
"events_url": "https://api.github.com/users/zigmonty/events{/privacy}",
"followers_url": "https://api.github.com/users/zigmonty/followers",
"following_url": "https://api.github.com/users/zigmonty/following{/other_user}",
"gists_url": "https://api.github.com/users/zigmonty/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zigmonty",
"id": 2172830,
"login": "zigmonty",
"node_id": "MDQ6VXNlcjIxNzI4MzA=",
"organizations_url": "https://api.github.com/users/zigmonty/orgs",
"received_events_url": "https://api.github.com/users/zigmonty/received_events",
"repos_url": "https://api.github.com/users/zigmonty/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zigmonty/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zigmonty/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zigmonty",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2012-08-18T04:32:59Z | 2021-09-09T06:00:50Z | 2012-08-19T04:13:41Z | CONTRIBUTOR | resolved | HTTPDigestAuth always tries to make a request first and only responds with an Authorization header when it receives a 401 (and then promptly forgets). This doesn't match my understanding of how it's supposed to work and doesn't match the behaviour of browsers eg Chrome.
The correct behaviour (I believe) is to store the credentials information the server gives you, and send Authorization on all subsequent requests. The old server nonce, etc is reused but the client creates a new cnonce and increments the nonce counter. If the server decides to change its nonce, it will send a new 401.
Draft fix is here: 5017aeb06c3893a1e500ae73d7d343b480a9c8c2
I'm storing the state in the HTTPDigestAuth object itself, which made some sort of sense to me. This means you have to reuse the same HTTPDigestAuth in subsequent requests to reuse the credentials.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/2172830?v=4",
"events_url": "https://api.github.com/users/zigmonty/events{/privacy}",
"followers_url": "https://api.github.com/users/zigmonty/followers",
"following_url": "https://api.github.com/users/zigmonty/following{/other_user}",
"gists_url": "https://api.github.com/users/zigmonty/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zigmonty",
"id": 2172830,
"login": "zigmonty",
"node_id": "MDQ6VXNlcjIxNzI4MzA=",
"organizations_url": "https://api.github.com/users/zigmonty/orgs",
"received_events_url": "https://api.github.com/users/zigmonty/received_events",
"repos_url": "https://api.github.com/users/zigmonty/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zigmonty/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zigmonty/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zigmonty",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/788/reactions"
} | https://api.github.com/repos/psf/requests/issues/788/timeline | null | completed | null | null | false | [
"Sorry, should mention that there are two commits here. The previous one is 53d454c8137e3c4863d7c1ecef8e3664f399f883 on which i based the one above.\n\nThe purpose of that was to get the digest handler to release the connection with the 401 before it reconnects. I was having deadlocks when forcing requests to only ... |
https://api.github.com/repos/psf/requests/issues/787 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/787/labels{/name} | https://api.github.com/repos/psf/requests/issues/787/comments | https://api.github.com/repos/psf/requests/issues/787/events | https://github.com/psf/requests/pull/787 | 6,286,271 | MDExOlB1bGxSZXF1ZXN0MjA4NTk1Nw== | 787 | "There many ..." to "There are many ..." in quickstart | {
"avatar_url": "https://avatars.githubusercontent.com/u/1530877?v=4",
"events_url": "https://api.github.com/users/kayzhu/events{/privacy}",
"followers_url": "https://api.github.com/users/kayzhu/followers",
"following_url": "https://api.github.com/users/kayzhu/following{/other_user}",
"gists_url": "https://api.github.com/users/kayzhu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kayzhu",
"id": 1530877,
"login": "kayzhu",
"node_id": "MDQ6VXNlcjE1MzA4Nzc=",
"organizations_url": "https://api.github.com/users/kayzhu/orgs",
"received_events_url": "https://api.github.com/users/kayzhu/received_events",
"repos_url": "https://api.github.com/users/kayzhu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kayzhu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kayzhu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kayzhu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-17T10:16:02Z | 2021-09-08T16:00:54Z | 2012-08-17T20:47:47Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/787/reactions"
} | https://api.github.com/repos/psf/requests/issues/787/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/787.diff",
"html_url": "https://github.com/psf/requests/pull/787",
"merged_at": "2012-08-17T20:47:47Z",
"patch_url": "https://github.com/psf/requests/pull/787.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/787"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2150797) (merged 76f90054 into 4130cf9b).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2150801) (merged 76f90054 into 4130cf9b).\n",
"Thanks!\n"
] | |
https://api.github.com/repos/psf/requests/issues/786 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/786/labels{/name} | https://api.github.com/repos/psf/requests/issues/786/comments | https://api.github.com/repos/psf/requests/issues/786/events | https://github.com/psf/requests/pull/786 | 6,276,867 | MDExOlB1bGxSZXF1ZXN0MjA4MjE4OQ== | 786 | Lint fixes following PEP8. | {
"avatar_url": "https://avatars.githubusercontent.com/u/542728?v=4",
"events_url": "https://api.github.com/users/dicato/events{/privacy}",
"followers_url": "https://api.github.com/users/dicato/followers",
"following_url": "https://api.github.com/users/dicato/following{/other_user}",
"gists_url": "https://api.github.com/users/dicato/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dicato",
"id": 542728,
"login": "dicato",
"node_id": "MDQ6VXNlcjU0MjcyOA==",
"organizations_url": "https://api.github.com/users/dicato/orgs",
"received_events_url": "https://api.github.com/users/dicato/received_events",
"repos_url": "https://api.github.com/users/dicato/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dicato/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dicato/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dicato",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-16T22:14:11Z | 2021-09-08T16:00:53Z | 2012-08-17T20:57:01Z | CONTRIBUTOR | resolved | These are generally only whitespace fixes. I excluded the `packages` directory for now. Let me know if you want that code cleaned up also.
I can do other PEP8 fixes if interested; unused imports, one import per line for different modules, etc.
=)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/786/reactions"
} | https://api.github.com/repos/psf/requests/issues/786/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/786.diff",
"html_url": "https://github.com/psf/requests/pull/786",
"merged_at": "2012-08-17T20:57:01Z",
"patch_url": "https://github.com/psf/requests/pull/786.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/786"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2146435) (merged 42d0a216 into 4130cf9b).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2146439) (merged 42d0a216 into 4130cf9b).\n",
"Excluding `packages` is correct, those are brought in from thei... |
https://api.github.com/repos/psf/requests/issues/785 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/785/labels{/name} | https://api.github.com/repos/psf/requests/issues/785/comments | https://api.github.com/repos/psf/requests/issues/785/events | https://github.com/psf/requests/issues/785 | 6,276,480 | MDU6SXNzdWU2Mjc2NDgw | 785 | Allow lists in the dict values of the hooks argument | {
"avatar_url": "https://avatars.githubusercontent.com/u/146720?v=4",
"events_url": "https://api.github.com/users/flub/events{/privacy}",
"followers_url": "https://api.github.com/users/flub/followers",
"following_url": "https://api.github.com/users/flub/following{/other_user}",
"gists_url": "https://api.github.com/users/flub/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/flub",
"id": 146720,
"login": "flub",
"node_id": "MDQ6VXNlcjE0NjcyMA==",
"organizations_url": "https://api.github.com/users/flub/orgs",
"received_events_url": "https://api.github.com/users/flub/received_events",
"repos_url": "https://api.github.com/users/flub/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/flub/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/flub/subscriptions",
"type": "User",
"url": "https://api.github.com/users/flub",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
}
] | closed | true | null | [] | null | 5 | 2012-08-16T21:57:19Z | 2021-09-09T06:00:43Z | 2012-09-23T01:49:20Z | NONE | resolved | Currently the Request class has a .register_hook() method but it parses the dictionary it expects from it's hooks argument weirdly: the argument can only specify one hook function per hook. If you pass in a list of hook functions per hook the code in Request.**init**() will wrap the list in a list which then fails when the hooks are consumed (since a list is not callable). This is especially annoying since you can not use multiple hooks from a session. The only way to get multiple hooks now is to create the request object without sending it, then call .register_hook() multiple times and then finally call .send().
This would all be much easier if Request.**init**() parsed the hooks parameter in a way that it accepts lists as it's values.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/785/reactions"
} | https://api.github.com/repos/psf/requests/issues/785/timeline | null | completed | null | null | false | [
"If anyone OKs this feature request, I'd be happy to dig into it.\n",
"@sigmavirus24 :+1:\n",
"Just need to make sure that the current workflow also continues to work with this change.\n",
"Once @kennethreitz has time to review #833, I'll start working on this. I have a feeling opening a branch for this would... |
https://api.github.com/repos/psf/requests/issues/784 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/784/labels{/name} | https://api.github.com/repos/psf/requests/issues/784/comments | https://api.github.com/repos/psf/requests/issues/784/events | https://github.com/psf/requests/pull/784 | 6,274,322 | MDExOlB1bGxSZXF1ZXN0MjA4MDgyNg== | 784 | Change variable '_r' to 'r' for consistency. | {
"avatar_url": "https://avatars.githubusercontent.com/u/542728?v=4",
"events_url": "https://api.github.com/users/dicato/events{/privacy}",
"followers_url": "https://api.github.com/users/dicato/followers",
"following_url": "https://api.github.com/users/dicato/following{/other_user}",
"gists_url": "https://api.github.com/users/dicato/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dicato",
"id": 542728,
"login": "dicato",
"node_id": "MDQ6VXNlcjU0MjcyOA==",
"organizations_url": "https://api.github.com/users/dicato/orgs",
"received_events_url": "https://api.github.com/users/dicato/received_events",
"repos_url": "https://api.github.com/users/dicato/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dicato/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dicato/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dicato",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 13 | 2012-08-16T20:26:44Z | 2021-09-08T23:01:11Z | 2012-08-17T20:59:29Z | CONTRIBUTOR | resolved | I don't think there is a reason for the leading underscore in this section of documentation, but if there is, this pull request can be ignored, or used to clarify the documentation.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/784/reactions"
} | https://api.github.com/repos/psf/requests/issues/784/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/784.diff",
"html_url": "https://github.com/psf/requests/pull/784",
"merged_at": "2012-08-17T20:59:29Z",
"patch_url": "https://github.com/psf/requests/pull/784.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/784"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2145448) (merged ff55d737 into 4130cf9b).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2145452) (merged ff55d737 into 4130cf9b).\n",
"Ooh, this one I can explain!\n\nThe intent is that you can walk... |
https://api.github.com/repos/psf/requests/issues/783 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/783/labels{/name} | https://api.github.com/repos/psf/requests/issues/783/comments | https://api.github.com/repos/psf/requests/issues/783/events | https://github.com/psf/requests/pull/783 | 6,273,185 | MDExOlB1bGxSZXF1ZXN0MjA4MDIwOA== | 783 | add .show() to Response | {
"avatar_url": "https://avatars.githubusercontent.com/u/1636347?v=4",
"events_url": "https://api.github.com/users/doda-zz/events{/privacy}",
"followers_url": "https://api.github.com/users/doda-zz/followers",
"following_url": "https://api.github.com/users/doda-zz/following{/other_user}",
"gists_url": "https://api.github.com/users/doda-zz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/doda-zz",
"id": 1636347,
"login": "doda-zz",
"node_id": "MDQ6VXNlcjE2MzYzNDc=",
"organizations_url": "https://api.github.com/users/doda-zz/orgs",
"received_events_url": "https://api.github.com/users/doda-zz/received_events",
"repos_url": "https://api.github.com/users/doda-zz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/doda-zz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/doda-zz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/doda-zz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-16T19:36:35Z | 2021-09-08T23:07:14Z | 2012-08-16T19:59:20Z | NONE | resolved | i find this very handy while figuring out how to call into an API (especially the ones made for humans). Thoughts on adding something like this into requests?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1636347?v=4",
"events_url": "https://api.github.com/users/doda-zz/events{/privacy}",
"followers_url": "https://api.github.com/users/doda-zz/followers",
"following_url": "https://api.github.com/users/doda-zz/following{/other_user}",
"gists_url": "https://api.github.com/users/doda-zz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/doda-zz",
"id": 1636347,
"login": "doda-zz",
"node_id": "MDQ6VXNlcjE2MzYzNDc=",
"organizations_url": "https://api.github.com/users/doda-zz/orgs",
"received_events_url": "https://api.github.com/users/doda-zz/received_events",
"repos_url": "https://api.github.com/users/doda-zz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/doda-zz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/doda-zz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/doda-zz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/783/reactions"
} | https://api.github.com/repos/psf/requests/issues/783/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/783.diff",
"html_url": "https://github.com/psf/requests/pull/783",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/783.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/783"
} | true | [
"Obviously, whether this gets pulled is up to @kennethreitz, but I would suspect that answer will be that it won't be.\n\nRequests is not intended for formatting or displaying data, but for obtaining it. Even the `Response.json` method only really exists as a courtesy, with any fault-tolerant JSON handling being do... |
https://api.github.com/repos/psf/requests/issues/782 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/782/labels{/name} | https://api.github.com/repos/psf/requests/issues/782/comments | https://api.github.com/repos/psf/requests/issues/782/events | https://github.com/psf/requests/issues/782 | 6,267,825 | MDU6SXNzdWU2MjY3ODI1 | 782 | dispatch_hook eats exceptions | {
"avatar_url": "https://avatars.githubusercontent.com/u/101894?v=4",
"events_url": "https://api.github.com/users/lucian1900/events{/privacy}",
"followers_url": "https://api.github.com/users/lucian1900/followers",
"following_url": "https://api.github.com/users/lucian1900/following{/other_user}",
"gists_url": "https://api.github.com/users/lucian1900/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lucian1900",
"id": 101894,
"login": "lucian1900",
"node_id": "MDQ6VXNlcjEwMTg5NA==",
"organizations_url": "https://api.github.com/users/lucian1900/orgs",
"received_events_url": "https://api.github.com/users/lucian1900/received_events",
"repos_url": "https://api.github.com/users/lucian1900/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lucian1900/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lucian1900/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lucian1900",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2012-08-16T15:47:30Z | 2021-09-09T06:00:45Z | 2012-08-25T15:06:38Z | CONTRIBUTOR | resolved | I tried to signal failures in a hook via exceptions, but all I got was two tracebacks printed. This happens because `dispatch_hook` catches `Exception`.
https://github.com/kennethreitz/requests/blob/develop/requests/hooks.py#L50
It seems to me like that's a bad idea.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/782/reactions"
} | https://api.github.com/repos/psf/requests/issues/782/timeline | null | completed | null | null | false | [
"This is intentional, but is certainly work reconsidering now :)\n",
"Out of interest, what was the reasoning behind the decision?\n",
"I'm trying to recall :)\n\nI believe I was under the impression that people would be writing all kinds of hooks and that if one failed, your request should still go through. Fo... |
https://api.github.com/repos/psf/requests/issues/781 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/781/labels{/name} | https://api.github.com/repos/psf/requests/issues/781/comments | https://api.github.com/repos/psf/requests/issues/781/events | https://github.com/psf/requests/pull/781 | 6,258,140 | MDExOlB1bGxSZXF1ZXN0MjA3Mjk3NQ== | 781 | permissive implementation of iter_content | {
"avatar_url": "https://avatars.githubusercontent.com/u/376448?v=4",
"events_url": "https://api.github.com/users/slingamn/events{/privacy}",
"followers_url": "https://api.github.com/users/slingamn/followers",
"following_url": "https://api.github.com/users/slingamn/following{/other_user}",
"gists_url": "https://api.github.com/users/slingamn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/slingamn",
"id": 376448,
"login": "slingamn",
"node_id": "MDQ6VXNlcjM3NjQ0OA==",
"organizations_url": "https://api.github.com/users/slingamn/orgs",
"received_events_url": "https://api.github.com/users/slingamn/received_events",
"repos_url": "https://api.github.com/users/slingamn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/slingamn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/slingamn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/slingamn",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 19127... | closed | true | null | [] | null | 6 | 2012-08-16T07:11:56Z | 2021-09-08T16:00:53Z | 2012-09-02T08:44:20Z | CONTRIBUTOR | resolved | This allows iter_content and iter_lines to succeed without
crashing even after the response content has been fetched
(iter_content gives you a one-item iterator containing the
content).
It should mitigate the API break I introduced in #760 (as discussed on #775 and #597).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/376448?v=4",
"events_url": "https://api.github.com/users/slingamn/events{/privacy}",
"followers_url": "https://api.github.com/users/slingamn/followers",
"following_url": "https://api.github.com/users/slingamn/following{/other_user}",
"gists_url": "https://api.github.com/users/slingamn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/slingamn",
"id": 376448,
"login": "slingamn",
"node_id": "MDQ6VXNlcjM3NjQ0OA==",
"organizations_url": "https://api.github.com/users/slingamn/orgs",
"received_events_url": "https://api.github.com/users/slingamn/received_events",
"repos_url": "https://api.github.com/users/slingamn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/slingamn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/slingamn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/slingamn",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/781/reactions"
} | https://api.github.com/repos/psf/requests/issues/781/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/781.diff",
"html_url": "https://github.com/psf/requests/pull/781",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/781.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/781"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2139018) (merged 4095a9f3 into 4130cf9b).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2139022) (merged 4095a9f3 into 4130cf9b).\n",
"Hmm, this is an interesting fix. \n\nWhy would we return everyt... |
https://api.github.com/repos/psf/requests/issues/780 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/780/labels{/name} | https://api.github.com/repos/psf/requests/issues/780/comments | https://api.github.com/repos/psf/requests/issues/780/events | https://github.com/psf/requests/pull/780 | 6,253,838 | MDExOlB1bGxSZXF1ZXN0MjA3MTEzOA== | 780 | minor cleanup | {
"avatar_url": "https://avatars.githubusercontent.com/u/97695?v=4",
"events_url": "https://api.github.com/users/jwagenleitner/events{/privacy}",
"followers_url": "https://api.github.com/users/jwagenleitner/followers",
"following_url": "https://api.github.com/users/jwagenleitner/following{/other_user}",
"gists_url": "https://api.github.com/users/jwagenleitner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jwagenleitner",
"id": 97695,
"login": "jwagenleitner",
"node_id": "MDQ6VXNlcjk3Njk1",
"organizations_url": "https://api.github.com/users/jwagenleitner/orgs",
"received_events_url": "https://api.github.com/users/jwagenleitner/received_events",
"repos_url": "https://api.github.com/users/jwagenleitner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jwagenleitner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jwagenleitner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jwagenleitner",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2012-08-15T23:31:56Z | 2021-09-08T16:00:52Z | 2012-09-11T03:07:09Z | NONE | resolved | Very minor change, but thought I'd submit anyway. Figured 3 less LOC might be considered a contribution. :)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/780/reactions"
} | https://api.github.com/repos/psf/requests/issues/780/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/780.diff",
"html_url": "https://github.com/psf/requests/pull/780",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/780.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/780"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2136498) (merged 025d0a73 into 4130cf9b).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2136502) (merged 025d0a73 into 4130cf9b).\n",
"This pull request [fails](http://travis-ci.org/kennethreitz/req... |
https://api.github.com/repos/psf/requests/issues/779 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/779/labels{/name} | https://api.github.com/repos/psf/requests/issues/779/comments | https://api.github.com/repos/psf/requests/issues/779/events | https://github.com/psf/requests/pull/779 | 6,245,500 | MDExOlB1bGxSZXF1ZXN0MjA2NzAwNw== | 779 | Make sure proxy exclusions work properly. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-15T17:20:03Z | 2021-09-08T16:00:53Z | 2012-08-19T00:40:53Z | MEMBER | resolved | This should fix the issue in #776.
Any unit test for this problem requires either the existence of a proxy to test against or the using of some pretty gnarly test hooks. You want it anyway?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/779/reactions"
} | https://api.github.com/repos/psf/requests/issues/779/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/779.diff",
"html_url": "https://github.com/psf/requests/pull/779",
"merged_at": "2012-08-19T00:40:53Z",
"patch_url": "https://github.com/psf/requests/pull/779.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/779"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2132558) (merged 00b4ca3b into 4130cf9b).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2132562) (merged 00b4ca3b into 4130cf9b).\n",
"Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/778 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/778/labels{/name} | https://api.github.com/repos/psf/requests/issues/778/comments | https://api.github.com/repos/psf/requests/issues/778/events | https://github.com/psf/requests/issues/778 | 6,230,442 | MDU6SXNzdWU2MjMwNDQy | 778 | POST file tests fail when run from byte code (.pyc) | {
"avatar_url": "https://avatars.githubusercontent.com/u/447371?v=4",
"events_url": "https://api.github.com/users/randomir/events{/privacy}",
"followers_url": "https://api.github.com/users/randomir/followers",
"following_url": "https://api.github.com/users/randomir/following{/other_user}",
"gists_url": "https://api.github.com/users/randomir/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/randomir",
"id": 447371,
"login": "randomir",
"node_id": "MDQ6VXNlcjQ0NzM3MQ==",
"organizations_url": "https://api.github.com/users/randomir/orgs",
"received_events_url": "https://api.github.com/users/randomir/received_events",
"repos_url": "https://api.github.com/users/randomir/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/randomir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/randomir/subscriptions",
"type": "User",
"url": "https://api.github.com/users/randomir",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-14T23:48:24Z | 2021-09-09T06:00:45Z | 2012-08-25T14:53:47Z | CONTRIBUTOR | resolved | Four test methods in `test_requests.pyc` fail:
```
test_POSTBIN_GET_POST_FILES
test_POSTBIN_GET_POST_FILES_STRINGS
test_POSTBIN_GET_POST_FILES_WITH_HEADERS
test_POSTBIN_GET_POST_FILES_WITH_PARAMS
```
due to http://httpbin.org/post returning 500. All 4 methods, at some point, send the running script (file) as the POST data. Tests pass when `test_requests.py` is run for the first time (and ascii sent), but fail the next and every other time, when python byte code (`test_requests.pyc`) exists and is run (binary file sent).
As it seems, the culprit is `httpbin` itself, which fails when raw binary data is sent to the `/post` endpoint. I submitted the [patch](https://github.com/kennethreitz/httpbin/pull/60) that should fix this issue, but I'm also documenting it here, just in case someone else runs into the same problem.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/778/reactions"
} | https://api.github.com/repos/psf/requests/issues/778/timeline | null | completed | null | null | false | [
"Yeah I'd been seeing this occasionally so I got into the habit of just running `make clean && make travis`\n",
"HTTPbin is fixed for this now. \n\nIn genreal though, I advocate the use of `PYTHONDONTWRITEBYTECODE`\n"
] |
https://api.github.com/repos/psf/requests/issues/777 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/777/labels{/name} | https://api.github.com/repos/psf/requests/issues/777/comments | https://api.github.com/repos/psf/requests/issues/777/events | https://github.com/psf/requests/pull/777 | 6,229,910 | MDExOlB1bGxSZXF1ZXN0MjA2MDA2NQ== | 777 | minor (`make test` fix for second run) | {
"avatar_url": "https://avatars.githubusercontent.com/u/447371?v=4",
"events_url": "https://api.github.com/users/randomir/events{/privacy}",
"followers_url": "https://api.github.com/users/randomir/followers",
"following_url": "https://api.github.com/users/randomir/following{/other_user}",
"gists_url": "https://api.github.com/users/randomir/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/randomir",
"id": 447371,
"login": "randomir",
"node_id": "MDQ6VXNlcjQ0NzM3MQ==",
"organizations_url": "https://api.github.com/users/randomir/orgs",
"received_events_url": "https://api.github.com/users/randomir/received_events",
"repos_url": "https://api.github.com/users/randomir/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/randomir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/randomir/subscriptions",
"type": "User",
"url": "https://api.github.com/users/randomir",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-14T23:13:40Z | 2021-09-08T16:00:52Z | 2012-08-19T00:41:23Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/777/reactions"
} | https://api.github.com/repos/psf/requests/issues/777/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/777.diff",
"html_url": "https://github.com/psf/requests/pull/777",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/777.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/777"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2125110) (merged e797a29a into 4130cf9b).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2125114) (merged e797a29a into 4130cf9b).\n",
"Thanks :)\n"
] | |
https://api.github.com/repos/psf/requests/issues/776 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/776/labels{/name} | https://api.github.com/repos/psf/requests/issues/776/comments | https://api.github.com/repos/psf/requests/issues/776/events | https://github.com/psf/requests/issues/776 | 6,192,782 | MDU6SXNzdWU2MTkyNzgy | 776 | no_proxy handling doesn't account for port in URL | {
"avatar_url": "https://avatars.githubusercontent.com/u/26976?v=4",
"events_url": "https://api.github.com/users/Pewpewarrows/events{/privacy}",
"followers_url": "https://api.github.com/users/Pewpewarrows/followers",
"following_url": "https://api.github.com/users/Pewpewarrows/following{/other_user}",
"gists_url": "https://api.github.com/users/Pewpewarrows/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Pewpewarrows",
"id": 26976,
"login": "Pewpewarrows",
"node_id": "MDQ6VXNlcjI2OTc2",
"organizations_url": "https://api.github.com/users/Pewpewarrows/orgs",
"received_events_url": "https://api.github.com/users/Pewpewarrows/received_events",
"repos_url": "https://api.github.com/users/Pewpewarrows/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Pewpewarrows/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Pewpewarrows/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Pewpewarrows",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-13T15:12:44Z | 2021-09-09T06:00:50Z | 2012-08-19T10:33:11Z | NONE | resolved | On https://github.com/kennethreitz/requests/blob/develop/requests/models.py#L556
``` python
if proxy and not any(map(_p.netloc.endswith, no_proxy)):
```
I don't believe `_p.netloc.endswith` is the correct way to check if the hostname is in the `$no_proxy` ENV variable (or `proxies` dict param). If the URL passed to requests contains a port, then `netloc` will look like `127.0.0.1:8000`, which will incorrectly fail to exempt `127.0.0.1` from the proxy.
I'd submit a pull request, but the test suite doesn't play nicely with the proxy I'm behind to begin with. It should be as simple as replacing:
`_p.netloc.endswith`
with:
`_p.netloc.split(':')[0].endswith`
But I don't know if you want to account for more complex scenarios.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/776/reactions"
} | https://api.github.com/repos/psf/requests/issues/776/timeline | null | completed | null | null | false | [
"Splitting on the colon is an accident waiting to happen: the [relevant RFC](http://pretty-rfc.herokuapp.com/RFC3986) seems to indicate that you are allowed additional colons in the `netloc` section returned by urlparse. It might be better to use the `urlparse(url).hostname` method on the original URL, e.g.:\n\n```... |
https://api.github.com/repos/psf/requests/issues/775 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/775/labels{/name} | https://api.github.com/repos/psf/requests/issues/775/comments | https://api.github.com/repos/psf/requests/issues/775/events | https://github.com/psf/requests/issues/775 | 6,188,800 | MDU6SXNzdWU2MTg4ODAw | 775 | Content marked as consumed in 0.13.6 | {
"avatar_url": "https://avatars.githubusercontent.com/u/208316?v=4",
"events_url": "https://api.github.com/users/davechallis/events{/privacy}",
"followers_url": "https://api.github.com/users/davechallis/followers",
"following_url": "https://api.github.com/users/davechallis/following{/other_user}",
"gists_url": "https://api.github.com/users/davechallis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davechallis",
"id": 208316,
"login": "davechallis",
"node_id": "MDQ6VXNlcjIwODMxNg==",
"organizations_url": "https://api.github.com/users/davechallis/orgs",
"received_events_url": "https://api.github.com/users/davechallis/received_events",
"repos_url": "https://api.github.com/users/davechallis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davechallis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davechallis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davechallis",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-13T12:21:40Z | 2021-09-09T06:00:51Z | 2012-08-13T12:42:29Z | NONE | resolved | Content is immediately marked as consumed in 0.13.6, causing calls to e.g. response.iter_content() to throw an error.
Test code (tested with python 2.6):
```
import requests
r = requests.get('http://docs.python-requests.org/')
if r._content_consumed:
print 'consumed'
else:
print 'not consumed'
```
In 0.13.5 this prints:
not consumed
In 0.13.6 this prints:
consumed
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/775/reactions"
} | https://api.github.com/repos/psf/requests/issues/775/timeline | null | completed | null | null | false | [
"This is a known bug in 0.13.6, and was resolved by #764. If you need immediately to fix the problem you can do one of the following: clone the development branch in its current state, use 0.13.6 with the patch from #764 applied, or wait until the next minor version is released, which will include the fix.\n",
"I... |
https://api.github.com/repos/psf/requests/issues/774 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/774/labels{/name} | https://api.github.com/repos/psf/requests/issues/774/comments | https://api.github.com/repos/psf/requests/issues/774/events | https://github.com/psf/requests/pull/774 | 6,157,081 | MDExOlB1bGxSZXF1ZXN0MjAyOTA4MQ== | 774 | Throw clear exceptions | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2012-08-10T16:49:52Z | 2021-09-08T23:06:12Z | 2012-08-13T21:14:19Z | MEMBER | resolved | I'm not super invested in this: I think the UnicodeError is reasonably clear, but it probably helps to throw a Requests based exception when there is an error in the URL. The InvalidURL exception subclasses ValueError, which means anyone catching this by looking for ValueErrors will still catch this exception.
That said, you might just want to keep throwing the Unicode Error.
(Inspired by me really wanting to close #697.)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/774/reactions"
} | https://api.github.com/repos/psf/requests/issues/774/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/774.diff",
"html_url": "https://github.com/psf/requests/pull/774",
"merged_at": "2012-08-13T21:14:19Z",
"patch_url": "https://github.com/psf/requests/pull/774.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/774"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2087975) (merged 5b5cff77 into 64646182).\n",
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2087975) (merged 5b5cff77 into 64646182).\n",
"@travisbot, you want to try testing this again? /poke\n",
"Oh i... |
https://api.github.com/repos/psf/requests/issues/773 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/773/labels{/name} | https://api.github.com/repos/psf/requests/issues/773/comments | https://api.github.com/repos/psf/requests/issues/773/events | https://github.com/psf/requests/pull/773 | 6,155,818 | MDExOlB1bGxSZXF1ZXN0MjAyODQ0NA== | 773 | Tests: python2.6 compat (`assertIn` new in python2.7) | {
"avatar_url": "https://avatars.githubusercontent.com/u/447371?v=4",
"events_url": "https://api.github.com/users/randomir/events{/privacy}",
"followers_url": "https://api.github.com/users/randomir/followers",
"following_url": "https://api.github.com/users/randomir/following{/other_user}",
"gists_url": "https://api.github.com/users/randomir/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/randomir",
"id": 447371,
"login": "randomir",
"node_id": "MDQ6VXNlcjQ0NzM3MQ==",
"organizations_url": "https://api.github.com/users/randomir/orgs",
"received_events_url": "https://api.github.com/users/randomir/received_events",
"repos_url": "https://api.github.com/users/randomir/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/randomir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/randomir/subscriptions",
"type": "User",
"url": "https://api.github.com/users/randomir",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2012-08-10T15:54:18Z | 2021-09-08T16:00:52Z | 2012-08-10T16:03:09Z | CONTRIBUTOR | resolved | "test_requests_ext.py" should now be python 2.6 compatible (where `unittest.TestCase` does not have `assertIn` and `assertNotIn` methods).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/773/reactions"
} | https://api.github.com/repos/psf/requests/issues/773/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/773.diff",
"html_url": "https://github.com/psf/requests/pull/773",
"merged_at": "2012-08-10T16:03:09Z",
"patch_url": "https://github.com/psf/requests/pull/773.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/773"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2087478) (merged 4da47928 into 40ba6b4e).\n",
"thanks!\n",
"Heh, I thought Travis was covering Python 2.6 --- I wonder how these were passing?\n",
"Dunno, they were passing for me when I ran them with a 2.6 virtualenv too.\n",
"I'... |
https://api.github.com/repos/psf/requests/issues/772 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/772/labels{/name} | https://api.github.com/repos/psf/requests/issues/772/comments | https://api.github.com/repos/psf/requests/issues/772/events | https://github.com/psf/requests/pull/772 | 6,151,050 | MDExOlB1bGxSZXF1ZXN0MjAyNzAyNQ== | 772 | First pass at documenting encodings and RFC compliance. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-10T13:50:12Z | 2021-09-08T16:00:51Z | 2012-08-10T16:05:08Z | MEMBER | resolved | My first run at dealing with #524 and #527. Let me know what you think of the changes and if you want me to take a different approach with some or all of it.
I've set the Compliance section up so that it is easily expanded if/when you want to document other compliance cases.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/772/reactions"
} | https://api.github.com/repos/psf/requests/issues/772/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/772.diff",
"html_url": "https://github.com/psf/requests/pull/772",
"merged_at": "2012-08-10T16:05:08Z",
"patch_url": "https://github.com/psf/requests/pull/772.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/772"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2086391) (merged 7a9419ce into 40ba6b4e).\n",
"Beautiful! I couldn't have written it better myself.\n\nI'm merging now, I like it so much. Keep sending pull requests if you have additional changes ;)\n"
] |
https://api.github.com/repos/psf/requests/issues/771 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/771/labels{/name} | https://api.github.com/repos/psf/requests/issues/771/comments | https://api.github.com/repos/psf/requests/issues/771/events | https://github.com/psf/requests/issues/771 | 6,149,391 | MDU6SXNzdWU2MTQ5Mzkx | 771 | socket leak (suspected due to redirection) | {
"avatar_url": "https://avatars.githubusercontent.com/u/1485066?v=4",
"events_url": "https://api.github.com/users/eranrund/events{/privacy}",
"followers_url": "https://api.github.com/users/eranrund/followers",
"following_url": "https://api.github.com/users/eranrund/following{/other_user}",
"gists_url": "https://api.github.com/users/eranrund/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eranrund",
"id": 1485066,
"login": "eranrund",
"node_id": "MDQ6VXNlcjE0ODUwNjY=",
"organizations_url": "https://api.github.com/users/eranrund/orgs",
"received_events_url": "https://api.github.com/users/eranrund/received_events",
"repos_url": "https://api.github.com/users/eranrund/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eranrund/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eranrund/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eranrund",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
}
] | closed | true | null | [] | null | 47 | 2012-08-10T12:21:29Z | 2021-09-09T05:30:52Z | 2012-11-17T11:17:01Z | NONE | resolved | It seems requests forgets to properly close a socket when a redirection occurs.
See the following gist for the code that causes the issue (at least here..):
https://gist.github.com/3313868
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/771/reactions"
} | https://api.github.com/repos/psf/requests/issues/771/timeline | null | completed | null | null | false | [
"Have you tried the latest release? v0.13.6 fixed a bunch of socket leaking\n",
"`Session.close()` was added in the new release, so it's possible that there's a problem.\n\nHowever I forked the gist to do a `lsof` automatically, as in bluehorn's test, and didn't see any problem under the master or develop branche... |
https://api.github.com/repos/psf/requests/issues/770 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/770/labels{/name} | https://api.github.com/repos/psf/requests/issues/770/comments | https://api.github.com/repos/psf/requests/issues/770/events | https://github.com/psf/requests/issues/770 | 6,131,080 | MDU6SXNzdWU2MTMxMDgw | 770 | requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/2124079?v=4",
"events_url": "https://api.github.com/users/simple-mia/events{/privacy}",
"followers_url": "https://api.github.com/users/simple-mia/followers",
"following_url": "https://api.github.com/users/simple-mia/following{/other_user}",
"gists_url": "https://api.github.com/users/simple-mia/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/simple-mia",
"id": 2124079,
"login": "simple-mia",
"node_id": "MDQ6VXNlcjIxMjQwNzk=",
"organizations_url": "https://api.github.com/users/simple-mia/orgs",
"received_events_url": "https://api.github.com/users/simple-mia/received_events",
"repos_url": "https://api.github.com/users/simple-mia/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/simple-mia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/simple-mia/subscriptions",
"type": "User",
"url": "https://api.github.com/users/simple-mia",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2012-08-09T16:22:48Z | 2021-09-09T06:00:54Z | 2012-08-09T16:42:04Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/770/reactions"
} | https://api.github.com/repos/psf/requests/issues/770/timeline | null | completed | null | null | false | [] | |
https://api.github.com/repos/psf/requests/issues/769 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/769/labels{/name} | https://api.github.com/repos/psf/requests/issues/769/comments | https://api.github.com/repos/psf/requests/issues/769/events | https://github.com/psf/requests/issues/769 | 6,130,036 | MDU6SXNzdWU2MTMwMDM2 | 769 | add request.json | {
"avatar_url": "https://avatars.githubusercontent.com/u/2088?v=4",
"events_url": "https://api.github.com/users/sanga/events{/privacy}",
"followers_url": "https://api.github.com/users/sanga/followers",
"following_url": "https://api.github.com/users/sanga/following{/other_user}",
"gists_url": "https://api.github.com/users/sanga/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sanga",
"id": 2088,
"login": "sanga",
"node_id": "MDQ6VXNlcjIwODg=",
"organizations_url": "https://api.github.com/users/sanga/orgs",
"received_events_url": "https://api.github.com/users/sanga/received_events",
"repos_url": "https://api.github.com/users/sanga/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sanga/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sanga/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sanga",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2012-08-09T15:45:43Z | 2021-09-09T06:00:53Z | 2012-08-09T18:25:32Z | NONE | resolved | I use Requests to test a JSON over HTTP API - which I suppose is a pretty common usecase. Given that, I find the response.json property to be pretty convenient and would find a request.json property to be similarly useful (for put and post requests). A patch to do such a thing would be trivial, which I could provide. Prior to doing that though, I was wondering if you had any objection to such a patch?
So it'd go like:
``` Python
r = requests.post(...., body=json.dumps(....))
=> <response 400>
hmmmm, I wonder what I did wrong
r.request.json
=> {'nmae': 'tim', ....}
```
Actually, it'd be nice to be able to instantiate a request directly with json content i.e.
``` python
req = requests.post(...., json={'name': 'tim'})
as opposed to:
req = requests.post(....., body=json.dumps({'name': 'tim'}))
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/769/reactions"
} | https://api.github.com/repos/psf/requests/issues/769/timeline | null | completed | null | null | false | [
"I've considered this heavily in the past, but decided to draw the line and not support this. Requests is a HTTP library, not anything else :)\n"
] |
https://api.github.com/repos/psf/requests/issues/768 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/768/labels{/name} | https://api.github.com/repos/psf/requests/issues/768/comments | https://api.github.com/repos/psf/requests/issues/768/events | https://github.com/psf/requests/issues/768 | 6,118,644 | MDU6SXNzdWU2MTE4NjQ0 | 768 | Erorr on requests docs site | {
"avatar_url": "https://avatars.githubusercontent.com/u/96469?v=4",
"events_url": "https://api.github.com/users/philipn/events{/privacy}",
"followers_url": "https://api.github.com/users/philipn/followers",
"following_url": "https://api.github.com/users/philipn/following{/other_user}",
"gists_url": "https://api.github.com/users/philipn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/philipn",
"id": 96469,
"login": "philipn",
"node_id": "MDQ6VXNlcjk2NDY5",
"organizations_url": "https://api.github.com/users/philipn/orgs",
"received_events_url": "https://api.github.com/users/philipn/received_events",
"repos_url": "https://api.github.com/users/philipn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/philipn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/philipn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/philipn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-09T02:58:23Z | 2021-09-09T06:00:54Z | 2012-08-09T04:32:41Z | NONE | resolved | "For security reasons, framing is not allowed." JS alert when visiting docs.python-requests.org/
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/768/reactions"
} | https://api.github.com/repos/psf/requests/issues/768/timeline | null | completed | null | null | false | [
"https://github.com/markdotto/github-buttons/issues/23\n",
"all better, thanks for the heads up!\n"
] |
https://api.github.com/repos/psf/requests/issues/767 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/767/labels{/name} | https://api.github.com/repos/psf/requests/issues/767/comments | https://api.github.com/repos/psf/requests/issues/767/events | https://github.com/psf/requests/pull/767 | 6,110,541 | MDExOlB1bGxSZXF1ZXN0MjAwNzU4NQ== | 767 | Wrap socket.error in ConnectionError (+ unit tests) | {
"avatar_url": "https://avatars.githubusercontent.com/u/188869?v=4",
"events_url": "https://api.github.com/users/stfp/events{/privacy}",
"followers_url": "https://api.github.com/users/stfp/followers",
"following_url": "https://api.github.com/users/stfp/following{/other_user}",
"gists_url": "https://api.github.com/users/stfp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stfp",
"id": 188869,
"login": "stfp",
"node_id": "MDQ6VXNlcjE4ODg2OQ==",
"organizations_url": "https://api.github.com/users/stfp/orgs",
"received_events_url": "https://api.github.com/users/stfp/received_events",
"repos_url": "https://api.github.com/users/stfp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stfp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stfp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stfp",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-08T18:58:42Z | 2021-09-08T23:01:14Z | 2012-08-08T20:23:10Z | NONE | resolved | On connection refused, requests recently started throwing lower-level socket.error exceptions instead of ConnectionError, which does not match the API docs and breaks existing code. I reported this here: https://github.com/kennethreitz/requests/issues/748
I believe the following commit introduced this bug: https://github.com/kennethreitz/requests/commit/e02fb2eb6c2acfa67793a2c77a3c7bd47998a024
This pull request simply catches socket.error in Request.send, and re-raises ConnectionError
It also adds two (now passing) unit tests, based on existing ones that are commented out (I left them untouched).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/767/reactions"
} | https://api.github.com/repos/psf/requests/issues/767/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/767.diff",
"html_url": "https://github.com/psf/requests/pull/767",
"merged_at": "2012-08-08T20:23:10Z",
"patch_url": "https://github.com/psf/requests/pull/767.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/767"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2069544) (merged 875c9e18 into bc7b2f9a).\n",
"A recent comment on #748 suggests that the underlying problem actually belongs to `urllib3`.\n",
"Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/766 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/766/labels{/name} | https://api.github.com/repos/psf/requests/issues/766/comments | https://api.github.com/repos/psf/requests/issues/766/events | https://github.com/psf/requests/pull/766 | 6,101,639 | MDExOlB1bGxSZXF1ZXN0MjAwMzM0NA== | 766 | Accept objects with string representations as URLs. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-08T12:40:01Z | 2021-09-08T16:00:51Z | 2012-08-08T20:18:40Z | MEMBER | resolved | This should provide the functionality requested in #423. This does _not_ implement schema-less URLs, and if we want that it should be filed as a separate issue.
I've tested with `furl` on Python 2.7, and this seems to work fine.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/766/reactions"
} | https://api.github.com/repos/psf/requests/issues/766/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/766.diff",
"html_url": "https://github.com/psf/requests/pull/766",
"merged_at": "2012-08-08T20:18:40Z",
"patch_url": "https://github.com/psf/requests/pull/766.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/766"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2066367) (merged 6166ba7e into bc7b2f9a).\n",
"Beautiful.\n"
] |
https://api.github.com/repos/psf/requests/issues/765 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/765/labels{/name} | https://api.github.com/repos/psf/requests/issues/765/comments | https://api.github.com/repos/psf/requests/issues/765/events | https://github.com/psf/requests/issues/765 | 6,072,578 | MDU6SXNzdWU2MDcyNTc4 | 765 | Chardet sometimes fails and force the wrong encoding | {
"avatar_url": "https://avatars.githubusercontent.com/u/1333493?v=4",
"events_url": "https://api.github.com/users/josemariaruiz/events{/privacy}",
"followers_url": "https://api.github.com/users/josemariaruiz/followers",
"following_url": "https://api.github.com/users/josemariaruiz/following{/other_user}",
"gists_url": "https://api.github.com/users/josemariaruiz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/josemariaruiz",
"id": 1333493,
"login": "josemariaruiz",
"node_id": "MDQ6VXNlcjEzMzM0OTM=",
"organizations_url": "https://api.github.com/users/josemariaruiz/orgs",
"received_events_url": "https://api.github.com/users/josemariaruiz/received_events",
"repos_url": "https://api.github.com/users/josemariaruiz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/josemariaruiz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/josemariaruiz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/josemariaruiz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 14 | 2012-08-07T10:07:31Z | 2021-09-09T00:01:04Z | 2012-08-07T18:17:38Z | NONE | resolved | I've a problem that I've traced back to the method/property "text" of Request. Chadet is returning the wrong encoding "ISO-8859-2" when the string is UTF-8! The result are, as you can imagine, nasty strings everywhere you have something that is not ascii. This is happening in production :(
What can I do?
You are shipping chardet with requests :(
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/765/reactions"
} | https://api.github.com/repos/psf/requests/issues/765/timeline | null | completed | null | null | false | [
"@josemariaruiz, do you have sample strings to reproduce the bug?\n",
"I wanted to cancel a comment and closed the bug! sorry. The string contains my personal data... can I send it to someone by email? I don't want to see it published everywhere :-/\n",
"@josemariaruiz, reduce it to the characters that are crea... |
https://api.github.com/repos/psf/requests/issues/764 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/764/labels{/name} | https://api.github.com/repos/psf/requests/issues/764/comments | https://api.github.com/repos/psf/requests/issues/764/events | https://github.com/psf/requests/pull/764 | 6,064,721 | MDExOlB1bGxSZXF1ZXN0MTk4NzEzNQ== | 764 | test and fix regressions from #760 | {
"avatar_url": "https://avatars.githubusercontent.com/u/376448?v=4",
"events_url": "https://api.github.com/users/slingamn/events{/privacy}",
"followers_url": "https://api.github.com/users/slingamn/followers",
"following_url": "https://api.github.com/users/slingamn/following{/other_user}",
"gists_url": "https://api.github.com/users/slingamn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/slingamn",
"id": 376448,
"login": "slingamn",
"node_id": "MDQ6VXNlcjM3NjQ0OA==",
"organizations_url": "https://api.github.com/users/slingamn/orgs",
"received_events_url": "https://api.github.com/users/slingamn/received_events",
"repos_url": "https://api.github.com/users/slingamn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/slingamn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/slingamn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/slingamn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-06T22:57:23Z | 2021-09-08T23:08:13Z | 2012-08-06T23:14:00Z | CONTRIBUTOR | resolved | This adds unit tests corresponding to the issues @dhagrow identified on #760, then fixes them.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/764/reactions"
} | https://api.github.com/repos/psf/requests/issues/764/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/764.diff",
"html_url": "https://github.com/psf/requests/pull/764",
"merged_at": "2012-08-06T23:14:00Z",
"patch_url": "https://github.com/psf/requests/pull/764.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/764"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2052399) (merged 000c1053 into a94fcb87).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2052525) (merged 291859c1 into a94fcb87).\n",
"Thanks :)\n"
] |
https://api.github.com/repos/psf/requests/issues/763 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/763/labels{/name} | https://api.github.com/repos/psf/requests/issues/763/comments | https://api.github.com/repos/psf/requests/issues/763/events | https://github.com/psf/requests/issues/763 | 6,064,301 | MDU6SXNzdWU2MDY0MzAx | 763 | prefetch=False isn't respected for redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/326885?v=4",
"events_url": "https://api.github.com/users/jkbrzt/events{/privacy}",
"followers_url": "https://api.github.com/users/jkbrzt/followers",
"following_url": "https://api.github.com/users/jkbrzt/following{/other_user}",
"gists_url": "https://api.github.com/users/jkbrzt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jkbrzt",
"id": 326885,
"login": "jkbrzt",
"node_id": "MDQ6VXNlcjMyNjg4NQ==",
"organizations_url": "https://api.github.com/users/jkbrzt/orgs",
"received_events_url": "https://api.github.com/users/jkbrzt/received_events",
"repos_url": "https://api.github.com/users/jkbrzt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jkbrzt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jkbrzt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jkbrzt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-06T22:35:36Z | 2021-09-09T06:00:55Z | 2012-08-06T23:14:23Z | CONTRIBUTOR | resolved | ```
import requests
r = requests.get('http://httpbin.org/status/301', prefetch=False, allow_redirects=True)
next(r.iter_lines())
Traceback (most recent call last):
File "<ipython-input-8-a2f7272b22ca>", line 1, in <module>
next(r.iter_lines())
File "python2.7/site-packages/requests/models.py", line 740, in iter_lines
decode_unicode=decode_unicode):
File "python2.7/site-packages/requests/models.py", line 712, in iter_content
'The content for this response was already consumed'
RuntimeError: The content for this response was already consumed
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/763/reactions"
} | https://api.github.com/repos/psf/requests/issues/763/timeline | null | completed | null | null | false | [
"Fixed by #764 !\n",
"Awesome :)\n"
] |
https://api.github.com/repos/psf/requests/issues/762 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/762/labels{/name} | https://api.github.com/repos/psf/requests/issues/762/comments | https://api.github.com/repos/psf/requests/issues/762/events | https://github.com/psf/requests/pull/762 | 6,056,232 | MDExOlB1bGxSZXF1ZXN0MTk4MzI3Ng== | 762 | Correctly handle encoding numbers when POSTing. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-06T16:42:59Z | 2021-09-08T23:06:30Z | 2012-08-06T21:05:22Z | MEMBER | resolved | Resolves #759.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/762/reactions"
} | https://api.github.com/repos/psf/requests/issues/762/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/762.diff",
"html_url": "https://github.com/psf/requests/pull/762",
"merged_at": "2012-08-06T21:05:22Z",
"patch_url": "https://github.com/psf/requests/pull/762.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/762"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2049164) (merged 55bf436f into fc6ddfd7).\n",
"thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/761 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/761/labels{/name} | https://api.github.com/repos/psf/requests/issues/761/comments | https://api.github.com/repos/psf/requests/issues/761/events | https://github.com/psf/requests/issues/761 | 6,050,138 | MDU6SXNzdWU2MDUwMTM4 | 761 | ssl cert problems | {
"avatar_url": "https://avatars.githubusercontent.com/u/275330?v=4",
"events_url": "https://api.github.com/users/geier/events{/privacy}",
"followers_url": "https://api.github.com/users/geier/followers",
"following_url": "https://api.github.com/users/geier/following{/other_user}",
"gists_url": "https://api.github.com/users/geier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/geier",
"id": 275330,
"login": "geier",
"node_id": "MDQ6VXNlcjI3NTMzMA==",
"organizations_url": "https://api.github.com/users/geier/orgs",
"received_events_url": "https://api.github.com/users/geier/received_events",
"repos_url": "https://api.github.com/users/geier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/geier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/geier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/geier",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2012-08-06T13:45:13Z | 2021-09-09T01:22:24Z | 2012-08-07T17:04:14Z | NONE | resolved | I'm having an issue with ssl verification.
```
>>> import requests
>>> requests.get('https://myserver.tld', cert='/home/cg/cacert.pem')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 63, in get
return request('get', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/safe_mode.py", line 38, in wrapped
return function(method, url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 50, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 238, in request
r.send(prefetch=prefetch)
File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 612, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 336265225] _ssl.c:351: error:140B0009:SSL routines:SSL_CTX_use_PrivateKey_file:PEM lib
```
but the cacert.pem file does not seem to be the problem, as it works fine with curl?
% curl --cacert /home/cg/cacert.pem https:/myvserver.tld
<html><body><h1>It works!</h1></body></html>
Does anyone know what the issue here is?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/761/reactions"
} | https://api.github.com/repos/psf/requests/issues/761/timeline | null | completed | null | null | false | [
"the curl command prints html, I'm not sure how to escape it, but you get the picture\n",
"ok, it looks like this is an urllib3 problem, will take it there\n",
"This doesn't seem to be fixed?\n",
"@llama it isn't closed because it was fixed, it was closed because it isn't an issue with requests. It **is** an ... |
https://api.github.com/repos/psf/requests/issues/760 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/760/labels{/name} | https://api.github.com/repos/psf/requests/issues/760/comments | https://api.github.com/repos/psf/requests/issues/760/events | https://github.com/psf/requests/pull/760 | 6,042,350 | MDExOlB1bGxSZXF1ZXN0MTk3ODAwNQ== | 760 | address connection leak issue from #520 | {
"avatar_url": "https://avatars.githubusercontent.com/u/376448?v=4",
"events_url": "https://api.github.com/users/slingamn/events{/privacy}",
"followers_url": "https://api.github.com/users/slingamn/followers",
"following_url": "https://api.github.com/users/slingamn/following{/other_user}",
"gists_url": "https://api.github.com/users/slingamn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/slingamn",
"id": 376448,
"login": "slingamn",
"node_id": "MDQ6VXNlcjM3NjQ0OA==",
"organizations_url": "https://api.github.com/users/slingamn/orgs",
"received_events_url": "https://api.github.com/users/slingamn/received_events",
"repos_url": "https://api.github.com/users/slingamn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/slingamn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/slingamn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/slingamn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2012-08-06T04:03:46Z | 2021-09-08T16:00:50Z | 2012-08-06T04:38:12Z | CONTRIBUTOR | resolved | Piggybacking on the recent upgrade of urllib3 inside Requests, here's my much-delayed shot at a real fix for #520. From the commit message:
- prefetch now defaults to True, ensuring that by default, sockets
are returned to the urllib3 connection pool on request end
- sessions now have a close() method, notifying urllib3 to close pooled
connections
- the module-level API, e.g., `requests.get('http://www.google.com')`,
explicitly closes its session when finished
When prefetch is False, the open socket becomes part of the state of the
Response object, and it's the client's responsibility to read the whole
body, at which point the socket will be returned to the pool.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/760/reactions"
} | https://api.github.com/repos/psf/requests/issues/760/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/760.diff",
"html_url": "https://github.com/psf/requests/pull/760",
"merged_at": "2012-08-06T04:38:12Z",
"patch_url": "https://github.com/psf/requests/pull/760.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/760"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2044485) (merged 0caaf682 into 1898077f).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2044576) (merged 3c0b9404 into 1898077f).\n",
"The first Travis failure was due to a Python 3 issue, which I su... |
https://api.github.com/repos/psf/requests/issues/759 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/759/labels{/name} | https://api.github.com/repos/psf/requests/issues/759/comments | https://api.github.com/repos/psf/requests/issues/759/events | https://github.com/psf/requests/issues/759 | 6,041,789 | MDU6SXNzdWU2MDQxNzg5 | 759 | long type not accepted as a parameter when files provided | {
"avatar_url": "https://avatars.githubusercontent.com/u/2100675?v=4",
"events_url": "https://api.github.com/users/deadbeef404/events{/privacy}",
"followers_url": "https://api.github.com/users/deadbeef404/followers",
"following_url": "https://api.github.com/users/deadbeef404/following{/other_user}",
"gists_url": "https://api.github.com/users/deadbeef404/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/deadbeef404",
"id": 2100675,
"login": "deadbeef404",
"node_id": "MDQ6VXNlcjIxMDA2NzU=",
"organizations_url": "https://api.github.com/users/deadbeef404/orgs",
"received_events_url": "https://api.github.com/users/deadbeef404/received_events",
"repos_url": "https://api.github.com/users/deadbeef404/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/deadbeef404/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deadbeef404/subscriptions",
"type": "User",
"url": "https://api.github.com/users/deadbeef404",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2012-08-06T02:34:40Z | 2021-09-09T06:00:55Z | 2012-08-06T21:06:10Z | NONE | resolved | When we provide a file and a long-type parameter through to the request functions, we get an exception thrown.
urllib3 seems to turn integer types into strings, but doesn't convert python long types.
The exception is raised by urllib3's encode_multipart_formdata function.
Not sure if this is a urllib3 issue as in their function, "# Backwards compatibility" is written next to their int conversion code.
As that might be removed at some point, maybe integer/long conversions should not be relied upon within that library.
``` python
import requests
import tempfile
filename = tempfile.mkstemp()[1]
file1 = open(filename, 'w')
file1.write('test')
file1.close()
file1 = open(filename, 'rb')
response = requests.post(
url='http://www.google.com',
data={'aparam1': 12L},
files={testfile': file1,}
)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/759/reactions"
} | https://api.github.com/repos/psf/requests/issues/759/timeline | null | completed | null | null | false | [
"This _is_ a `urllib3` issue. It's also a stupid Python version problem.\n\nIn Python 2, the correct code would read:\n\n``` python\nif isinstance(data, (int, long)):\n # do type coercion\n```\n\nIn Python 3, that's a NameError because the `long` type was removed. @shazow, does this fix look useful?\n\nWhack thi... |
https://api.github.com/repos/psf/requests/issues/758 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/758/labels{/name} | https://api.github.com/repos/psf/requests/issues/758/comments | https://api.github.com/repos/psf/requests/issues/758/events | https://github.com/psf/requests/pull/758 | 6,027,762 | MDExOlB1bGxSZXF1ZXN0MTk3MzQ2NA== | 758 | Develop | {
"avatar_url": "https://avatars.githubusercontent.com/u/69447?v=4",
"events_url": "https://api.github.com/users/volker48/events{/privacy}",
"followers_url": "https://api.github.com/users/volker48/followers",
"following_url": "https://api.github.com/users/volker48/following{/other_user}",
"gists_url": "https://api.github.com/users/volker48/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/volker48",
"id": 69447,
"login": "volker48",
"node_id": "MDQ6VXNlcjY5NDQ3",
"organizations_url": "https://api.github.com/users/volker48/orgs",
"received_events_url": "https://api.github.com/users/volker48/received_events",
"repos_url": "https://api.github.com/users/volker48/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/volker48/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/volker48/subscriptions",
"type": "User",
"url": "https://api.github.com/users/volker48",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2012-08-04T03:22:06Z | 2021-09-08T23:01:00Z | 2012-08-04T15:39:25Z | CONTRIBUTOR | resolved | Fixes kennethreitz/requests#747.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/758/reactions"
} | https://api.github.com/repos/psf/requests/issues/758/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/758.diff",
"html_url": "https://github.com/psf/requests/pull/758",
"merged_at": "2012-08-04T15:39:25Z",
"patch_url": "https://github.com/psf/requests/pull/758.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/758"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2033776) (merged 2d321b22 into b5ca4b44).\n",
"hmm, looks like this fails on Python 3 because of your str import.\n",
"Sorry about that I thought I tested it on Python 3, but I obviously didn't. Let me try something else.\n",
"This p... |
https://api.github.com/repos/psf/requests/issues/757 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/757/labels{/name} | https://api.github.com/repos/psf/requests/issues/757/comments | https://api.github.com/repos/psf/requests/issues/757/events | https://github.com/psf/requests/pull/757 | 6,022,627 | MDExOlB1bGxSZXF1ZXN0MTk3MTAwMw== | 757 | Adds `quote_plus` option | {
"avatar_url": "https://avatars.githubusercontent.com/u/1032706?v=4",
"events_url": "https://api.github.com/users/dlitvakb/events{/privacy}",
"followers_url": "https://api.github.com/users/dlitvakb/followers",
"following_url": "https://api.github.com/users/dlitvakb/following{/other_user}",
"gists_url": "https://api.github.com/users/dlitvakb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dlitvakb",
"id": 1032706,
"login": "dlitvakb",
"node_id": "MDQ6VXNlcjEwMzI3MDY=",
"organizations_url": "https://api.github.com/users/dlitvakb/orgs",
"received_events_url": "https://api.github.com/users/dlitvakb/received_events",
"repos_url": "https://api.github.com/users/dlitvakb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dlitvakb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dlitvakb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dlitvakb",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 14 | 2012-08-03T20:04:38Z | 2021-09-08T16:00:49Z | 2012-08-08T20:24:03Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/757/reactions"
} | https://api.github.com/repos/psf/requests/issues/757/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/757.diff",
"html_url": "https://github.com/psf/requests/pull/757",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/757.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/757"
} | true | [
"Some sites give a 401 error when encoding url parameters and body data with the default urlencode function, as they send `+` instead of `%20` for encoding spaces.\n\nAn issue for this has been posted to [urllib](http://bugs.python.org/issue13866) but as it doesn't seem to be nowhere near to be accepted. I propose ... | |
https://api.github.com/repos/psf/requests/issues/756 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/756/labels{/name} | https://api.github.com/repos/psf/requests/issues/756/comments | https://api.github.com/repos/psf/requests/issues/756/events | https://github.com/psf/requests/issues/756 | 6,022,610 | MDU6SXNzdWU2MDIyNjEw | 756 | Allow a quote_plus option to the API, some sites give a 401 with default urlencode | {
"avatar_url": "https://avatars.githubusercontent.com/u/1032706?v=4",
"events_url": "https://api.github.com/users/dlitvakb/events{/privacy}",
"followers_url": "https://api.github.com/users/dlitvakb/followers",
"following_url": "https://api.github.com/users/dlitvakb/following{/other_user}",
"gists_url": "https://api.github.com/users/dlitvakb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dlitvakb",
"id": 1032706,
"login": "dlitvakb",
"node_id": "MDQ6VXNlcjEwMzI3MDY=",
"organizations_url": "https://api.github.com/users/dlitvakb/orgs",
"received_events_url": "https://api.github.com/users/dlitvakb/received_events",
"repos_url": "https://api.github.com/users/dlitvakb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dlitvakb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dlitvakb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dlitvakb",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-08-03T20:03:31Z | 2021-09-08T12:00:56Z | 2012-08-03T20:07:42Z | NONE | resolved | Some sites give a 401 error when encoding url parameters and body data with the default urlencode function, as they send `+` instead of `%20` for encoding spaces.
An issue for this has been posted to [urllib](http://bugs.python.org/issue13866) but as it doesn't seem to be nowhere near to be accepted. I propose that an additional parameter can be added to requests API to replicate that feature.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1032706?v=4",
"events_url": "https://api.github.com/users/dlitvakb/events{/privacy}",
"followers_url": "https://api.github.com/users/dlitvakb/followers",
"following_url": "https://api.github.com/users/dlitvakb/following{/other_user}",
"gists_url": "https://api.github.com/users/dlitvakb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dlitvakb",
"id": 1032706,
"login": "dlitvakb",
"node_id": "MDQ6VXNlcjEwMzI3MDY=",
"organizations_url": "https://api.github.com/users/dlitvakb/orgs",
"received_events_url": "https://api.github.com/users/dlitvakb/received_events",
"repos_url": "https://api.github.com/users/dlitvakb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dlitvakb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dlitvakb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dlitvakb",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/756/reactions"
} | https://api.github.com/repos/psf/requests/issues/756/timeline | null | completed | null | null | false | [
"Hi,\r\n\r\nSo how to use it ?\r\n\r\n```\r\nimport requests\r\n\r\nrequests.post(\"https://www.google.fr\", data={'q': 'test 1'}, quote_plus=True)\r\n```\r\n\r\n`\r\nTypeError: request() got an unexpected keyword argument 'quote_plus'\r\n`\r\n INSTALLED: 2.13.0 (latest)\r\n\r\n",
"The option does not exist: thi... |
https://api.github.com/repos/psf/requests/issues/755 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/755/labels{/name} | https://api.github.com/repos/psf/requests/issues/755/comments | https://api.github.com/repos/psf/requests/issues/755/events | https://github.com/psf/requests/pull/755 | 6,018,066 | MDExOlB1bGxSZXF1ZXN0MTk2ODc0Mg== | 755 | Multipart filenames only sent if provided. | {
"avatar_url": "https://avatars.githubusercontent.com/u/62200?v=4",
"events_url": "https://api.github.com/users/enginoid/events{/privacy}",
"followers_url": "https://api.github.com/users/enginoid/followers",
"following_url": "https://api.github.com/users/enginoid/following{/other_user}",
"gists_url": "https://api.github.com/users/enginoid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/enginoid",
"id": 62200,
"login": "enginoid",
"node_id": "MDQ6VXNlcjYyMjAw",
"organizations_url": "https://api.github.com/users/enginoid/orgs",
"received_events_url": "https://api.github.com/users/enginoid/received_events",
"repos_url": "https://api.github.com/users/enginoid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/enginoid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/enginoid/subscriptions",
"type": "User",
"url": "https://api.github.com/users/enginoid",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2012-08-03T16:11:44Z | 2021-09-08T16:00:50Z | 2012-08-03T17:11:34Z | NONE | resolved | Before this change, `filename` parameter (in `Content-Disposition`) was sent
with every subpart in a multipart even if one was not provided. This changes
request semantics, indicating to the server that the part is indeed a file.
This commit fixes #732.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/62200?v=4",
"events_url": "https://api.github.com/users/enginoid/events{/privacy}",
"followers_url": "https://api.github.com/users/enginoid/followers",
"following_url": "https://api.github.com/users/enginoid/following{/other_user}",
"gists_url": "https://api.github.com/users/enginoid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/enginoid",
"id": 62200,
"login": "enginoid",
"node_id": "MDQ6VXNlcjYyMjAw",
"organizations_url": "https://api.github.com/users/enginoid/orgs",
"received_events_url": "https://api.github.com/users/enginoid/received_events",
"repos_url": "https://api.github.com/users/enginoid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/enginoid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/enginoid/subscriptions",
"type": "User",
"url": "https://api.github.com/users/enginoid",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/755/reactions"
} | https://api.github.com/repos/psf/requests/issues/755/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/755.diff",
"html_url": "https://github.com/psf/requests/pull/755",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/755.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/755"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2029683) (merged c50239b2 into 664880db).\n",
"@enginous if you pull develop and merge, your PR should pass unless there's a way to kick @travisbot to merge it against the current head.\n",
"There seem to be errors related to my change... |
https://api.github.com/repos/psf/requests/issues/754 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/754/labels{/name} | https://api.github.com/repos/psf/requests/issues/754/comments | https://api.github.com/repos/psf/requests/issues/754/events | https://github.com/psf/requests/pull/754 | 6,017,434 | MDExOlB1bGxSZXF1ZXN0MTk2ODQzNA== | 754 | Fix raise_for_status() | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-03T15:43:44Z | 2021-09-08T16:00:48Z | 2012-08-03T16:21:28Z | CONTRIBUTOR | resolved | Found by @enginous https://github.com/kennethreitz/requests/commit/204649521bf8d165690b78a349d0f7c10d03bb99#requests/models.py-P27
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/754/reactions"
} | https://api.github.com/repos/psf/requests/issues/754/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/754.diff",
"html_url": "https://github.com/psf/requests/pull/754",
"merged_at": "2012-08-03T16:21:28Z",
"patch_url": "https://github.com/psf/requests/pull/754.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/754"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2029564) (merged b4bc76f8 into 664880db).\n",
"Thank you sir!\n",
"Not a problem.\n"
] |
https://api.github.com/repos/psf/requests/issues/753 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/753/labels{/name} | https://api.github.com/repos/psf/requests/issues/753/comments | https://api.github.com/repos/psf/requests/issues/753/events | https://github.com/psf/requests/pull/753 | 6,001,888 | MDExOlB1bGxSZXF1ZXN0MTk2MDk3OQ== | 753 | Refactoring in |raise_for_status| method. | {
"avatar_url": "https://avatars.githubusercontent.com/u/26338?v=4",
"events_url": "https://api.github.com/users/berkerpeksag/events{/privacy}",
"followers_url": "https://api.github.com/users/berkerpeksag/followers",
"following_url": "https://api.github.com/users/berkerpeksag/following{/other_user}",
"gists_url": "https://api.github.com/users/berkerpeksag/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/berkerpeksag",
"id": 26338,
"login": "berkerpeksag",
"node_id": "MDQ6VXNlcjI2MzM4",
"organizations_url": "https://api.github.com/users/berkerpeksag/orgs",
"received_events_url": "https://api.github.com/users/berkerpeksag/received_events",
"repos_url": "https://api.github.com/users/berkerpeksag/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/berkerpeksag/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/berkerpeksag/subscriptions",
"type": "User",
"url": "https://api.github.com/users/berkerpeksag",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-02T20:50:02Z | 2021-09-08T16:00:49Z | 2012-08-02T20:52:36Z | MEMBER | resolved | - Simplified the if statements.
- Remove duplicate code.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/753/reactions"
} | https://api.github.com/repos/psf/requests/issues/753/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/753.diff",
"html_url": "https://github.com/psf/requests/pull/753",
"merged_at": "2012-08-02T20:52:36Z",
"patch_url": "https://github.com/psf/requests/pull/753.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/753"
} | true | [
"Beautiful. Thanks!\n",
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/2022784) (merged 20464952 into 54842cdc).\n"
] |
https://api.github.com/repos/psf/requests/issues/752 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/752/labels{/name} | https://api.github.com/repos/psf/requests/issues/752/comments | https://api.github.com/repos/psf/requests/issues/752/events | https://github.com/psf/requests/pull/752 | 5,990,446 | MDExOlB1bGxSZXF1ZXN0MTk1NTM4NA== | 752 | file posting example looked wrong | {
"avatar_url": "https://avatars.githubusercontent.com/u/147840?v=4",
"events_url": "https://api.github.com/users/anentropic/events{/privacy}",
"followers_url": "https://api.github.com/users/anentropic/followers",
"following_url": "https://api.github.com/users/anentropic/following{/other_user}",
"gists_url": "https://api.github.com/users/anentropic/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/anentropic",
"id": 147840,
"login": "anentropic",
"node_id": "MDQ6VXNlcjE0Nzg0MA==",
"organizations_url": "https://api.github.com/users/anentropic/orgs",
"received_events_url": "https://api.github.com/users/anentropic/received_events",
"repos_url": "https://api.github.com/users/anentropic/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/anentropic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anentropic/subscriptions",
"type": "User",
"url": "https://api.github.com/users/anentropic",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-08-02T11:58:08Z | 2021-09-08T16:00:49Z | 2012-08-02T11:59:38Z | CONTRIBUTOR | resolved | From what I can tell from the source code (down thru urllib3) the key in the `files` dict is always the 'fieldname', while specifying a custom 'filename' is optional.
So in this example it was confusing to have a `fieldname` of 'report.xls' (the same as the filename) when all the other examples use a fieldname of 'file'.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/752/reactions"
} | https://api.github.com/repos/psf/requests/issues/752/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/752.diff",
"html_url": "https://github.com/psf/requests/pull/752",
"merged_at": "2012-08-02T11:59:38Z",
"patch_url": "https://github.com/psf/requests/pull/752.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/752"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2018277) (merged fdec88de into b4741853).\n",
"Great insight. Thanks. :)\n",
"thank _you_ for the awesome module!\n"
] |
https://api.github.com/repos/psf/requests/issues/751 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/751/labels{/name} | https://api.github.com/repos/psf/requests/issues/751/comments | https://api.github.com/repos/psf/requests/issues/751/events | https://github.com/psf/requests/pull/751 | 5,989,893 | MDExOlB1bGxSZXF1ZXN0MTk1NTEyNw== | 751 | Catch socket.gaierror in safe mode. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-02T11:19:14Z | 2021-09-08T16:00:48Z | 2012-08-02T20:53:06Z | MEMBER | resolved | This should resolve Issue #750. No explicit test in this pull request, let me know if you want one.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/751/reactions"
} | https://api.github.com/repos/psf/requests/issues/751/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/751.diff",
"html_url": "https://github.com/psf/requests/pull/751",
"merged_at": "2012-08-02T20:53:06Z",
"patch_url": "https://github.com/psf/requests/pull/751.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/751"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/2018028) (merged 4f40b3be into b4741853).\n",
"Thank you sir :)\n"
] |
https://api.github.com/repos/psf/requests/issues/750 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/750/labels{/name} | https://api.github.com/repos/psf/requests/issues/750/comments | https://api.github.com/repos/psf/requests/issues/750/events | https://github.com/psf/requests/issues/750 | 5,981,929 | MDU6SXNzdWU1OTgxOTI5 | 750 | safe_mode not catching socket.gaierror | {
"avatar_url": "https://avatars.githubusercontent.com/u/379552?v=4",
"events_url": "https://api.github.com/users/jassinm/events{/privacy}",
"followers_url": "https://api.github.com/users/jassinm/followers",
"following_url": "https://api.github.com/users/jassinm/following{/other_user}",
"gists_url": "https://api.github.com/users/jassinm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jassinm",
"id": 379552,
"login": "jassinm",
"node_id": "MDQ6VXNlcjM3OTU1Mg==",
"organizations_url": "https://api.github.com/users/jassinm/orgs",
"received_events_url": "https://api.github.com/users/jassinm/received_events",
"repos_url": "https://api.github.com/users/jassinm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jassinm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jassinm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jassinm",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-08-01T23:54:30Z | 2021-09-09T06:00:56Z | 2012-08-02T17:33:57Z | NONE | resolved | doing a request to a non existsing server will raise socket.gaierror even if save_mode is set.
``` python
import requests
requests.get('http://x.lala.com', config={'safe_mode':True})
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/750/reactions"
} | https://api.github.com/repos/psf/requests/issues/750/timeline | null | completed | null | null | false | [
"Good catch! Pull Request #751 should resolve this.\n",
"thanks this merge will fix the issue\n"
] |
https://api.github.com/repos/psf/requests/issues/749 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/749/labels{/name} | https://api.github.com/repos/psf/requests/issues/749/comments | https://api.github.com/repos/psf/requests/issues/749/events | https://github.com/psf/requests/issues/749 | 5,979,220 | MDU6SXNzdWU1OTc5MjIw | 749 | TLS SNI Support | {
"avatar_url": "https://avatars.githubusercontent.com/u/1297754?v=4",
"events_url": "https://api.github.com/users/pythonmobile/events{/privacy}",
"followers_url": "https://api.github.com/users/pythonmobile/followers",
"following_url": "https://api.github.com/users/pythonmobile/following{/other_user}",
"gists_url": "https://api.github.com/users/pythonmobile/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pythonmobile",
"id": 1297754,
"login": "pythonmobile",
"node_id": "MDQ6VXNlcjEyOTc3NTQ=",
"organizations_url": "https://api.github.com/users/pythonmobile/orgs",
"received_events_url": "https://api.github.com/users/pythonmobile/received_events",
"repos_url": "https://api.github.com/users/pythonmobile/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pythonmobile/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pythonmobile/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pythonmobile",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 47 | 2012-08-01T21:40:20Z | 2021-02-14T17:04:28Z | 2013-02-10T22:33:58Z | NONE | resolved | It seems I'm having problems using requests with servers that need TLS SNI support. When will requests have this feature? Is this something that is planned?
Thanks,
--Ram
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/749/reactions"
} | https://api.github.com/repos/psf/requests/issues/749/timeline | null | completed | null | null | false | [
"Not posisble in Python 2.x on top of the stdlib's ssl module.\n",
"Twisted has it, right? Perhaps time to depend on pyopenssl or some other ssl module?\n",
"There's a pull request for urllib3 adding SNI support for Py32+, but still needs test coverage. https://github.com/shazow/urllib3/pull/89\n",
"shzow: Th... |
https://api.github.com/repos/psf/requests/issues/748 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/748/labels{/name} | https://api.github.com/repos/psf/requests/issues/748/comments | https://api.github.com/repos/psf/requests/issues/748/events | https://github.com/psf/requests/issues/748 | 5,976,184 | MDU6SXNzdWU1OTc2MTg0 | 748 | On connection refused, socket.error instead of requests.exceptions.ConnectionError | {
"avatar_url": "https://avatars.githubusercontent.com/u/188869?v=4",
"events_url": "https://api.github.com/users/stfp/events{/privacy}",
"followers_url": "https://api.github.com/users/stfp/followers",
"following_url": "https://api.github.com/users/stfp/following{/other_user}",
"gists_url": "https://api.github.com/users/stfp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stfp",
"id": 188869,
"login": "stfp",
"node_id": "MDQ6VXNlcjE4ODg2OQ==",
"organizations_url": "https://api.github.com/users/stfp/orgs",
"received_events_url": "https://api.github.com/users/stfp/received_events",
"repos_url": "https://api.github.com/users/stfp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stfp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stfp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stfp",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2012-08-01T19:23:06Z | 2021-09-09T06:00:54Z | 2012-08-08T20:22:18Z | NONE | resolved | With requests==0.11.1
> > > requests.get('http://127.0.0.1')
> > > Traceback (most recent call last):
> > > File "<stdin>", line 1, in <module>
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/api.py", line 52, in get
> > > return request('get', url, *_kwargs)
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/api.py", line 40, in request
> > > return s.request(method=method, url=url, *_kwargs)
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/sessions.py", line 208, in request
> > > r.send(prefetch=prefetch)
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/models.py", line 580, in send
> > > raise ConnectionError(e)
> > > requests.exceptions.ConnectionError: HTTPConnectionPool(host='127.0.0.1', port=80): Max retries exceeded with url: /
With requests==0.13.5
> > > requests.get('http://127.0.0.1')
> > > Traceback (most recent call last):
> > > File "<stdin>", line 1, in <module>
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/api.py", line 54, in get
> > > return request('get', url, *_kwargs)
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/safe_mode.py", line 37, in wrapped
> > > return function(method, url, *_kwargs)
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/api.py", line 42, in request
> > > return s.request(method=method, url=url, *_kwargs)
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/sessions.py", line 230, in request
> > > r.send(prefetch=prefetch)
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/models.py", line 603, in send
> > > timeout=self.timeout,
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 415, in urlopen
> > > body=body, headers=headers)
> > > File "/var/blah/envs/dev/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 267, in _make_request
> > > conn.request(method, url, *_httplib_request_kw)
> > > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 941, in request
> > > self._send_request(method, url, body, headers)
> > > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 975, in _send_request
> > > self.endheaders(body)
> > > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 937, in endheaders
> > > self._send_output(message_body)
> > > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 797, in _send_output
> > > self.send(msg)
> > > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 759, in send
> > > self.connect()
> > > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 740, in connect
> > > self.timeout, self.source_address)
> > > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 571, in create_connection
> > > raise err
> > > socket.error: [Errno 61] Connection refused
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/748/reactions"
} | https://api.github.com/repos/psf/requests/issues/748/timeline | null | completed | null | null | false | [
"This was fixed a long time ago, please update :)\n",
"I'm confused, isn't 0.13.5 the latest release ?\n",
"Oh, I'm sorry, I only saw the first traceback :)\n",
"Cool! Quick git bisect seems to point to https://github.com/kennethreitz/requests/commit/e02fb2eb6c2acfa67793a2c77a3c7bd47998a024 \n",
"This was c... |
https://api.github.com/repos/psf/requests/issues/747 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/747/labels{/name} | https://api.github.com/repos/psf/requests/issues/747/comments | https://api.github.com/repos/psf/requests/issues/747/events | https://github.com/psf/requests/issues/747 | 5,928,424 | MDU6SXNzdWU1OTI4NDI0 | 747 | requests.{post,patch} set Content-Type to application/x-www-form-urlencoded even when ``data`` arg is a string | {
"avatar_url": "https://avatars.githubusercontent.com/u/576874?v=4",
"events_url": "https://api.github.com/users/nisavid/events{/privacy}",
"followers_url": "https://api.github.com/users/nisavid/followers",
"following_url": "https://api.github.com/users/nisavid/following{/other_user}",
"gists_url": "https://api.github.com/users/nisavid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nisavid",
"id": 576874,
"login": "nisavid",
"node_id": "MDQ6VXNlcjU3Njg3NA==",
"organizations_url": "https://api.github.com/users/nisavid/orgs",
"received_events_url": "https://api.github.com/users/nisavid/received_events",
"repos_url": "https://api.github.com/users/nisavid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nisavid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nisavid/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nisavid",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"... | closed | true | null | [] | null | 3 | 2012-07-30T20:18:22Z | 2021-09-09T06:00:56Z | 2012-08-04T15:39:39Z | NONE | resolved | the Requests documentation [clearly states](http://docs.python-requests.org/en/latest/user/quickstart/#more-complicated-post-requests),
> There are many times that you want to send data that is not form-encoded. If you pass in a `string` instead of a `dict`, that data will be posted directly.
i presume that it's safe to interpret "`string`" here as meaning "`str` or `unicode`" (minor documentation error). i'm not sure what the string being "posted directly" is supposed to mean. i suppose it should mean that the request's `Content-Type` is `text/plain`, since that's a reasonable interpretation of a generic string. in any case, i'm quite sure that it's _not_ supposed to mean that the string is passed in as form-encoded data. that would defeat the stated purpose of passing in a string instead of a `dict`.
unfortunately, passing a `str` as the `data` does in fact cause the request to have `Content-Type` `application/x-www-form-urlencoded`, just as in the `dict` case.
either this behavior is incorrect or the documentation is incorrect. i'd prefer it to be the former. the automatic conversion of a `dict` of parameters as form-encoded data seems to be specific to the case where `data` is a mapping (in fact, i'd prefer this special case to likewise interpret any `collections.Mapping` objects rather than just `dict`s). when `data` is a string, on the other hand, it seems natural to interpret it as a plain-text string (`text/plain`) unless otherwise specified. in other words, the particular media type of the request entity is application-dependent; automatically applying `application/x-www-form-urlencoded` is an act of incorrectly imposing one application's assumptions on another. the current behavior leads to confusing bugs when a user forgets to specify the proper media type, Requests (incorrectly) applies `application/x-www-form-urlencoded`, and the receiving server subsequently parses the entity (incorrectly) as such. `text/plain` has no inherent syntax, so an unsuspecting web server will not mangle it if the user forgets to specify the correct media type.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/747/reactions"
} | https://api.github.com/repos/psf/requests/issues/747/timeline | null | completed | null | null | false | [
"It's intentionally labelled as \"string\" because you can pass either byte strings or unicode. Depends on the version of Python and your use case.\n\nWe should not be setting that content-type header though, nice catch :)\n",
"I started working on this and wrote a regression test that exposes the problem, but I ... |
https://api.github.com/repos/psf/requests/issues/746 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/746/labels{/name} | https://api.github.com/repos/psf/requests/issues/746/comments | https://api.github.com/repos/psf/requests/issues/746/events | https://github.com/psf/requests/pull/746 | 5,878,509 | MDExOlB1bGxSZXF1ZXN0MTkwODk0MQ== | 746 | Fixed encoding of fields with the same name, multipart/form-data fixes. | {
"avatar_url": "https://avatars.githubusercontent.com/u/326885?v=4",
"events_url": "https://api.github.com/users/jkbrzt/events{/privacy}",
"followers_url": "https://api.github.com/users/jkbrzt/followers",
"following_url": "https://api.github.com/users/jkbrzt/following{/other_user}",
"gists_url": "https://api.github.com/users/jkbrzt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jkbrzt",
"id": 326885,
"login": "jkbrzt",
"node_id": "MDQ6VXNlcjMyNjg4NQ==",
"organizations_url": "https://api.github.com/users/jkbrzt/orgs",
"received_events_url": "https://api.github.com/users/jkbrzt/received_events",
"repos_url": "https://api.github.com/users/jkbrzt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jkbrzt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jkbrzt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jkbrzt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 16 | 2012-07-27T15:17:21Z | 2021-09-08T23:11:03Z | 2012-08-11T06:30:21Z | CONTRIBUTOR | resolved | - Properly handle repeated data fields for multipart/form-data requests (#737)
- Allow a list of 2-tuples as the `files` agument.
- Consistently serialize lists a of parameters (#729).
- Use BytesIO for bytes.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/746/reactions"
} | https://api.github.com/repos/psf/requests/issues/746/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/746.diff",
"html_url": "https://github.com/psf/requests/pull/746",
"merged_at": "2012-08-11T06:30:21Z",
"patch_url": "https://github.com/psf/requests/pull/746.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/746"
} | true | [
"This pull request [fails](http://travis-ci.org/kennethreitz/requests/builds/1970172) (merged 1f7aeacb into 02dcc40a).\n",
"Looks good to me. I'm uncomfortable merging pull requests on @kennethreitz 's behalf, so I'll let him do it.\n\nThat TravisCI failure is worrying me, because it seems to come and go, and not... |
https://api.github.com/repos/psf/requests/issues/745 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/745/labels{/name} | https://api.github.com/repos/psf/requests/issues/745/comments | https://api.github.com/repos/psf/requests/issues/745/events | https://github.com/psf/requests/issues/745 | 5,876,640 | MDU6SXNzdWU1ODc2NjQw | 745 | SSL handshake error | {
"avatar_url": "https://avatars.githubusercontent.com/u/106409?v=4",
"events_url": "https://api.github.com/users/dArignac/events{/privacy}",
"followers_url": "https://api.github.com/users/dArignac/followers",
"following_url": "https://api.github.com/users/dArignac/following{/other_user}",
"gists_url": "https://api.github.com/users/dArignac/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dArignac",
"id": 106409,
"login": "dArignac",
"node_id": "MDQ6VXNlcjEwNjQwOQ==",
"organizations_url": "https://api.github.com/users/dArignac/orgs",
"received_events_url": "https://api.github.com/users/dArignac/received_events",
"repos_url": "https://api.github.com/users/dArignac/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dArignac/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dArignac/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dArignac",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2012-07-27T13:51:55Z | 2021-09-09T06:00:57Z | 2012-07-30T10:36:17Z | NONE | resolved | With the current version, 0.13.5, when I try to get from a page with an unsigned ssl certificate the whole request blocks, so the execution of the normal code is blocked. If I cancel the execution, the error below was generated. Using Python 2.7.2. I used version 0.11.2 before, there everything works.
```
>>> import requests
>>> r = requests.get('https://127.0.0.1:8015/', verify=False)
(nothing happens, no return, unable to execute another statement)
```
Error after Ctrl+C:
```
File "<stdin>", line 1, in <module>
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/api.py", line 54, in get
return request('get', url, **kwargs)
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/safe_mode.py", line 37, in wrapped
return function(method, url, **kwargs)
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/api.py", line 42, in request
return s.request(method=method, url=url, **kwargs)
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/sessions.py", line 230, in request
r.send(prefetch=prefetch)
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/models.py", line 603, in send
timeout=self.timeout,
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/packages/urllib3/poolmanager.py", line 153, in urlopen
return self.proxy_pool.urlopen(method, url, **kw)
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 415, in urlopen
body=body, headers=headers)
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 267, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/local/lib/python2.7/httplib.py", line 955, in request
self._send_request(method, url, body, headers)
File "/usr/local/lib/python2.7/httplib.py", line 989, in _send_request
self.endheaders(body)
File "/usr/local/lib/python2.7/httplib.py", line 951, in endheaders
self._send_output(message_body)
File "/usr/local/lib/python2.7/httplib.py", line 811, in _send_output
self.send(msg)
File "/usr/local/lib/python2.7/httplib.py", line 773, in send
self.connect()
File "/home/darignac/ve/tests/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 101, in connect
ca_certs=self.ca_certs)
File "/usr/local/lib/python2.7/ssl.py", line 372, in wrap_socket
ciphers=ciphers)
File "/usr/local/lib/python2.7/ssl.py", line 134, in __init__
self.do_handshake()
File "/usr/local/lib/python2.7/ssl.py", line 296, in do_handshake
self._sslobj.do_handshake()
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/106409?v=4",
"events_url": "https://api.github.com/users/dArignac/events{/privacy}",
"followers_url": "https://api.github.com/users/dArignac/followers",
"following_url": "https://api.github.com/users/dArignac/following{/other_user}",
"gists_url": "https://api.github.com/users/dArignac/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dArignac",
"id": 106409,
"login": "dArignac",
"node_id": "MDQ6VXNlcjEwNjQwOQ==",
"organizations_url": "https://api.github.com/users/dArignac/orgs",
"received_events_url": "https://api.github.com/users/dArignac/received_events",
"repos_url": "https://api.github.com/users/dArignac/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dArignac/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dArignac/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dArignac",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/745/reactions"
} | https://api.github.com/repos/psf/requests/issues/745/timeline | null | completed | null | null | false | [
"Odd, that doesn't seem to be coming from Requests at all.\n\nI don't have the time to spin up a web server and a self-signed cert right now, but if I use https://www.pcwebshop.co.uk/, which is a publicly accessible webpage with a self-signed cert, using Python 2.7.1:\n\n``` python\n>>> import requests\n>>> r = req... |
https://api.github.com/repos/psf/requests/issues/744 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/744/labels{/name} | https://api.github.com/repos/psf/requests/issues/744/comments | https://api.github.com/repos/psf/requests/issues/744/events | https://github.com/psf/requests/pull/744 | 5,874,223 | MDExOlB1bGxSZXF1ZXN0MTkwNjk0Mw== | 744 | Set content type before authentication | {
"avatar_url": "https://avatars.githubusercontent.com/u/97768?v=4",
"events_url": "https://api.github.com/users/tax/events{/privacy}",
"followers_url": "https://api.github.com/users/tax/followers",
"following_url": "https://api.github.com/users/tax/following{/other_user}",
"gists_url": "https://api.github.com/users/tax/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tax",
"id": 97768,
"login": "tax",
"node_id": "MDQ6VXNlcjk3NzY4",
"organizations_url": "https://api.github.com/users/tax/orgs",
"received_events_url": "https://api.github.com/users/tax/received_events",
"repos_url": "https://api.github.com/users/tax/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tax/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tax/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tax",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2012-07-27T11:19:54Z | 2021-09-08T16:00:48Z | 2012-07-31T01:13:17Z | CONTRIBUTOR | resolved | AWS S3 authentication adds content type header (when it exist) to
canonical string that is signed. Since it is set after authentication
is done authentication on S3 fails
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/744/reactions"
} | https://api.github.com/repos/psf/requests/issues/744/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/744.diff",
"html_url": "https://github.com/psf/requests/pull/744",
"merged_at": "2012-07-31T01:13:17Z",
"patch_url": "https://github.com/psf/requests/pull/744.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/744"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1968492) (merged 5e175ef2 into 02dcc40a).\n",
"A little more context: https://github.com/tax/python-requests-aws this is the authentication backend. \n",
"Awesome, thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/743 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/743/labels{/name} | https://api.github.com/repos/psf/requests/issues/743/comments | https://api.github.com/repos/psf/requests/issues/743/events | https://github.com/psf/requests/issues/743 | 5,868,208 | MDU6SXNzdWU1ODY4MjA4 | 743 | Case for OAuth with multipart/form-data signing parameters when files are present | {
"avatar_url": "https://avatars.githubusercontent.com/u/145617?v=4",
"events_url": "https://api.github.com/users/djt/events{/privacy}",
"followers_url": "https://api.github.com/users/djt/followers",
"following_url": "https://api.github.com/users/djt/following{/other_user}",
"gists_url": "https://api.github.com/users/djt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/djt",
"id": 145617,
"login": "djt",
"node_id": "MDQ6VXNlcjE0NTYxNw==",
"organizations_url": "https://api.github.com/users/djt/orgs",
"received_events_url": "https://api.github.com/users/djt/received_events",
"repos_url": "https://api.github.com/users/djt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/djt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/djt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/djt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-07-27T01:27:36Z | 2021-09-09T07:05:19Z | 2012-07-27T06:11:22Z | NONE | resolved | Not 100% sure if there is a wider use case for this, but working with the tumblr API (and I believe others, will investigate further soon) submitting a post request with an attached file, as well as other data, requires that the data dict be included in the signature.
The following code does not sign the data dict at all as it removes it from the request.
``` python
if r.files:
# Omit body data in the signing and since it will always
# be empty (cant add paras to body if multipart) and we wish
# to preserve body.
r.headers['Content-Type'] = 'multipart/form-encoded'
r.url, r.headers, _ = self.client.sign(
unicode(r.full_url), unicode(r.method), None, r.headers)
```
I can confirm that if I bypass the check for files, the signature will include the data dict (but not the attached files), and produce the needed signed request.
Is Tumblr out of spec for this, or could it be that the check for files is not needed?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/743/reactions"
} | https://api.github.com/repos/psf/requests/issues/743/timeline | null | completed | null | null | false | [
"@idan @dgouldin @gulopine?\n",
"Interesting. Dropbox puts their parameters in the QueryString, even for a file PUT. Of course, they also use a plaintext signature, which doesn't take the parameters into account anyway.\n"
] |
https://api.github.com/repos/psf/requests/issues/742 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/742/labels{/name} | https://api.github.com/repos/psf/requests/issues/742/comments | https://api.github.com/repos/psf/requests/issues/742/events | https://github.com/psf/requests/issues/742 | 5,867,546 | MDU6SXNzdWU1ODY3NTQ2 | 742 | SSL certs aren't working with https://graph.facebook.com in Mac OS | {
"avatar_url": "https://avatars.githubusercontent.com/u/464746?v=4",
"events_url": "https://api.github.com/users/yeeland/events{/privacy}",
"followers_url": "https://api.github.com/users/yeeland/followers",
"following_url": "https://api.github.com/users/yeeland/following{/other_user}",
"gists_url": "https://api.github.com/users/yeeland/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yeeland",
"id": 464746,
"login": "yeeland",
"node_id": "MDQ6VXNlcjQ2NDc0Ng==",
"organizations_url": "https://api.github.com/users/yeeland/orgs",
"received_events_url": "https://api.github.com/users/yeeland/received_events",
"repos_url": "https://api.github.com/users/yeeland/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yeeland/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yeeland/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yeeland",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2012-07-27T00:23:42Z | 2021-09-09T04:00:37Z | 2012-07-27T05:42:26Z | NONE | resolved | I hope it's not something I'm doing wrong but...
> import requests
> requests.get('https://graph.facebook.com')
and I get this:
> requests.exceptions.SSLError: [Errno 1] _ssl.c:480: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
in line 604 of requests/models.py
My cert_loc seems to be going with the DEFAULT_CA_BUNDLE_PATH, which is certifi/cacert.pem.
I made sure that I have the latest certifi, too. Anyone have any ideas?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/742/reactions"
} | https://api.github.com/repos/psf/requests/issues/742/timeline | null | completed | null | null | false | [
"Usually an OpenSSL version difference.\n",
"Looks like I was on 0.9.8r. I just upgraded to 1.0.1c and I'm still getting the same error.\n",
"Please make sure you're using the latest version of Requests as well.\n",
"Closing until further reports emerge.\n",
"I'm having exactly this issue on MacOSX 10.8.3 w... |
https://api.github.com/repos/psf/requests/issues/741 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/741/labels{/name} | https://api.github.com/repos/psf/requests/issues/741/comments | https://api.github.com/repos/psf/requests/issues/741/events | https://github.com/psf/requests/issues/741 | 5,865,930 | MDU6SXNzdWU1ODY1OTMw | 741 | Multiple Link: headers in response | {
"avatar_url": "https://avatars.githubusercontent.com/u/505230?v=4",
"events_url": "https://api.github.com/users/karlcow/events{/privacy}",
"followers_url": "https://api.github.com/users/karlcow/followers",
"following_url": "https://api.github.com/users/karlcow/following{/other_user}",
"gists_url": "https://api.github.com/users/karlcow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/karlcow",
"id": 505230,
"login": "karlcow",
"node_id": "MDQ6VXNlcjUwNTIzMA==",
"organizations_url": "https://api.github.com/users/karlcow/orgs",
"received_events_url": "https://api.github.com/users/karlcow/received_events",
"repos_url": "https://api.github.com/users/karlcow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/karlcow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/karlcow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/karlcow",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 15 | 2012-07-26T22:30:16Z | 2021-09-09T05:29:59Z | 2012-07-27T00:08:19Z | CONTRIBUTOR | resolved | Using 0.13.3 requests
So let's see, we have a URI with multiple links
```
curl -I http://www.la-grange.net/2012/07/26/csstests/foo
HTTP/1.1 200 OK
Date: Thu, 26 Jul 2012 22:27:21 GMT
Server: Apache
Content-Location: foo.html
Vary: negotiate,Accept-Encoding
TCN: choice
Last-Modified: Thu, 26 Jul 2012 20:55:56 GMT
Accept-Ranges: bytes
Content-Length: 675
Expires: Thu, 02 Aug 2012 22:27:21 GMT
Link: </2012/07/26/csstests/csshttplink.css>;rel=stylesheet
Link: </>;rel=next
Content-Type: text/html; charset=utf-8
```
Let's use requests to inspect the Link.
```
>>> import requests
>>> r = requests.get('http://www.la-grange.net/2012/07/26/csstests/foo')
>>> r.headers
{'content-length': '375', 'content-location': 'foo.html', 'content-encoding': 'gzip', 'accept-ranges': 'bytes', 'expires': 'Thu, 02 Aug 2012 22:19:41 GMT', 'vary': 'negotiate,Accept-Encoding', 'server': 'Apache', 'tcn': 'choice', 'last-modified': 'Thu, 26 Jul 2012 20:55:56 GMT', 'link': '</2012/07/26/csstests/csshttplink.css>;rel=stylesheet, </>;rel=next', 'date': 'Thu, 26 Jul 2012 22:19:41 GMT', 'content-type': 'text/html; charset=utf-8'}
>>> r.headers['link']
'</2012/07/26/csstests/csshttplink.css>;rel=stylesheet, </>;rel=next'
```
Not right :)
I haven't dig yet in the source code where the parsing of link headers was happening. But putting it here before I forget.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/505230?v=4",
"events_url": "https://api.github.com/users/karlcow/events{/privacy}",
"followers_url": "https://api.github.com/users/karlcow/followers",
"following_url": "https://api.github.com/users/karlcow/following{/other_user}",
"gists_url": "https://api.github.com/users/karlcow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/karlcow",
"id": 505230,
"login": "karlcow",
"node_id": "MDQ6VXNlcjUwNTIzMA==",
"organizations_url": "https://api.github.com/users/karlcow/orgs",
"received_events_url": "https://api.github.com/users/karlcow/received_events",
"repos_url": "https://api.github.com/users/karlcow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/karlcow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/karlcow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/karlcow",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/741/reactions"
} | https://api.github.com/repos/psf/requests/issues/741/timeline | null | completed | null | null | false | [
"This is a side effect of how httplib works, unfortunately.\n",
"So from `utils.py`, requests is using `urllib2.py` to parse the headers: `parse_http_list(s)` but it doesn't seem it is it. \nin `response.py` ?\n",
"It happens before any of that, at the actual httplib level, deep within urllib3.\n",
"ah ok req... |
https://api.github.com/repos/psf/requests/issues/740 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/740/labels{/name} | https://api.github.com/repos/psf/requests/issues/740/comments | https://api.github.com/repos/psf/requests/issues/740/events | https://github.com/psf/requests/pull/740 | 5,847,817 | MDExOlB1bGxSZXF1ZXN0MTg5NDQ1NA== | 740 | do not update the request.url from the OAuth signing call as it results ... | {
"avatar_url": "https://avatars.githubusercontent.com/u/663366?v=4",
"events_url": "https://api.github.com/users/r1chardj0n3s/events{/privacy}",
"followers_url": "https://api.github.com/users/r1chardj0n3s/followers",
"following_url": "https://api.github.com/users/r1chardj0n3s/following{/other_user}",
"gists_url": "https://api.github.com/users/r1chardj0n3s/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/r1chardj0n3s",
"id": 663366,
"login": "r1chardj0n3s",
"node_id": "MDQ6VXNlcjY2MzM2Ng==",
"organizations_url": "https://api.github.com/users/r1chardj0n3s/orgs",
"received_events_url": "https://api.github.com/users/r1chardj0n3s/received_events",
"repos_url": "https://api.github.com/users/r1chardj0n3s/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/r1chardj0n3s/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/r1chardj0n3s/subscriptions",
"type": "User",
"url": "https://api.github.com/users/r1chardj0n3s",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2012-07-26T07:11:58Z | 2021-09-08T23:06:09Z | 2012-07-27T05:28:35Z | CONTRIBUTOR | resolved | ...in the request URL params all being doubled (and the URL doesn't need to be updated based on the signing anyway)
This was noticed when attempting a file upload OAuth1a request to PyPI - the params were all doubled-up when performing POST with URL params (the only way to do OAuth1a file upload AFAIK.)
I don't believe the OAuth signing should ever modify they URL so I believe this modification is safe.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/740/reactions"
} | https://api.github.com/repos/psf/requests/issues/740/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/740.diff",
"html_url": "https://github.com/psf/requests/pull/740",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/740.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/740"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1957207) (merged 6f0a2242 into 52b55ccf).\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1965210) (merged 0b8b859f into 52b55ccf).\n",
"... 80 changed files?\n",
"Closing this, @r1chardj0n3s thanks... |
https://api.github.com/repos/psf/requests/issues/739 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/739/labels{/name} | https://api.github.com/repos/psf/requests/issues/739/comments | https://api.github.com/repos/psf/requests/issues/739/events | https://github.com/psf/requests/pull/739 | 5,834,479 | MDExOlB1bGxSZXF1ZXN0MTg4ODA3OA== | 739 | Appengine workaround | {
"avatar_url": "https://avatars.githubusercontent.com/u/143557?v=4",
"events_url": "https://api.github.com/users/saevarom/events{/privacy}",
"followers_url": "https://api.github.com/users/saevarom/followers",
"following_url": "https://api.github.com/users/saevarom/following{/other_user}",
"gists_url": "https://api.github.com/users/saevarom/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/saevarom",
"id": 143557,
"login": "saevarom",
"node_id": "MDQ6VXNlcjE0MzU1Nw==",
"organizations_url": "https://api.github.com/users/saevarom/orgs",
"received_events_url": "https://api.github.com/users/saevarom/received_events",
"repos_url": "https://api.github.com/users/saevarom/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/saevarom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/saevarom/subscriptions",
"type": "User",
"url": "https://api.github.com/users/saevarom",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-07-25T16:41:39Z | 2021-09-09T00:01:19Z | 2012-07-27T05:29:18Z | NONE | resolved | This commit fixes #498, at least in the Python 2.7 environment on Appengine.
Verified that it works on appengine.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/739/reactions"
} | https://api.github.com/repos/psf/requests/issues/739/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/739.diff",
"html_url": "https://github.com/psf/requests/pull/739",
"merged_at": "2012-07-27T05:29:18Z",
"patch_url": "https://github.com/psf/requests/pull/739.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/739"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1952357) (merged 350be4a5 into 52b55ccf).\n",
"thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/738 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/738/labels{/name} | https://api.github.com/repos/psf/requests/issues/738/comments | https://api.github.com/repos/psf/requests/issues/738/events | https://github.com/psf/requests/issues/738 | 5,823,472 | MDU6SXNzdWU1ODIzNDcy | 738 | pip install error on py3k | {
"avatar_url": "https://avatars.githubusercontent.com/u/220039?v=4",
"events_url": "https://api.github.com/users/clee704/events{/privacy}",
"followers_url": "https://api.github.com/users/clee704/followers",
"following_url": "https://api.github.com/users/clee704/following{/other_user}",
"gists_url": "https://api.github.com/users/clee704/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/clee704",
"id": 220039,
"login": "clee704",
"node_id": "MDQ6VXNlcjIyMDAzOQ==",
"organizations_url": "https://api.github.com/users/clee704/orgs",
"received_events_url": "https://api.github.com/users/clee704/received_events",
"repos_url": "https://api.github.com/users/clee704/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/clee704/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/clee704/subscriptions",
"type": "User",
"url": "https://api.github.com/users/clee704",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"... | closed | true | null | [] | null | 7 | 2012-07-25T05:47:28Z | 2021-09-09T05:31:03Z | 2012-07-27T06:11:43Z | NONE | resolved | With Python 3.2.3 and pip 1.1, `pip install requests` installs Requests 0.13.3 printing scary words like SyntaxError although it seems to work fine after installation. The exact output is below. If further information is needed, please let me know.
```
$ pip-3.2 install requests
Downloading/unpacking requests
Downloading requests-0.13.3.tar.gz (515Kb): 515Kb downloaded
Running setup.py egg_info for package requests
warning: no files found matching 'tests/*.'
Installing collected packages: requests
Running setup.py install for requests
warning: no files found matching 'tests/*.'
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/oauth2/draft25/__init__.py", line 15
AUTH_HEADER = u'auth_header'
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/oauth2/draft25/parameters.py", line 50
params = [((u'response_type', response_type)),
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/oauth2/draft25/tokens.py", line 22
body=None, ext=u'', hash_algorithm=u'hmac-sha-1'):
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/oauth2/draft25/utils.py", line 18
u'HTTP': u'80',
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/oauth1/rfc5849/__init__.py", line 20
SIGNATURE_HMAC = u"HMAC-SHA1"
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/oauth1/rfc5849/parameters.py", line 60
part = u'{0}="{1}"'.format(escaped_name, escaped_value)
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/oauth1/rfc5849/signature.py", line 76
base_string += u'&'
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/oauth1/rfc5849/utils.py", line 36
is_oauth = lambda kv: kv[0].startswith(u"oauth_")
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/oauthlib/common.py", line 22
always_safe = (u'ABCDEFGHIJKLMNOPQRSTUVWXYZ'
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/langgreekmodel.py", line 215
'keepEnglishLetter': constants.False,
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/constants.py", line 46
False = __builtin__.False
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/universaldetector.py", line 51
self.done = constants.False
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/sbcsgroupprober.py", line 59
logicalHebrewProber = SingleByteCharSetProber(Win1255HebrewModel, constants.False, hebrewProber)
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/langcyrillicmodel.py", line 287
'keepEnglishLetter': constants.False,
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/langthaimodel.py", line 198
'keepEnglishLetter': constants.False,
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/langbulgarianmodel.py", line 218
'keepEnglishLetter': constants.False,
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/chardistribution.py", line 48
self._mDone = constants.False # If this flag is set to constants.True, detection is done and conclusion has been made
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/langhebrewmodel.py", line 199
'keepEnglishLetter': constants.False,
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/charsetgroupprober.py", line 44
prober.active = constants.True
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/sbcharsetprober.py", line 42
def __init__(self, model, reversed=constants.False, nameProber=None):
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/escprober.py", line 48
codingSM.active = constants.True
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/jpcntx.py", line 132
self._mDone = constants.False # If this flag is set to constants.True, detection is done and conclusion has been made
^
SyntaxError: invalid syntax
File "/usr/local/lib/python3.2/dist-packages/requests/packages/chardet/langhungarianmodel.py", line 215
'keepEnglishLetter': constants.True,
^
SyntaxError: invalid syntax
Successfully installed requests
Cleaning up...
$ python3.2
>>> import requests
>>> r = requests.get('http://www.google.com')
>>> r.ok
True
>>>
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/738/reactions"
} | https://api.github.com/repos/psf/requests/issues/738/timeline | null | completed | null | null | false | [
"These are all genuine Python 3 Syntax Errors that are in libraries included within `requests`. The errors in `chardet` don't affect functionality, as in Python 3 `chardet2` is imported instead, which does not have these problems. It would be nice if we could somehow exclude the module entirely in Python 3 though.\... |
https://api.github.com/repos/psf/requests/issues/737 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/737/labels{/name} | https://api.github.com/repos/psf/requests/issues/737/comments | https://api.github.com/repos/psf/requests/issues/737/events | https://github.com/psf/requests/issues/737 | 5,803,847 | MDU6SXNzdWU1ODAzODQ3 | 737 | multipart/form-data and multiple fields with the same name | {
"avatar_url": "https://avatars.githubusercontent.com/u/326885?v=4",
"events_url": "https://api.github.com/users/jkbrzt/events{/privacy}",
"followers_url": "https://api.github.com/users/jkbrzt/followers",
"following_url": "https://api.github.com/users/jkbrzt/following{/other_user}",
"gists_url": "https://api.github.com/users/jkbrzt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jkbrzt",
"id": 326885,
"login": "jkbrzt",
"node_id": "MDQ6VXNlcjMyNjg4NQ==",
"organizations_url": "https://api.github.com/users/jkbrzt/orgs",
"received_events_url": "https://api.github.com/users/jkbrzt/received_events",
"repos_url": "https://api.github.com/users/jkbrzt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jkbrzt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jkbrzt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jkbrzt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2012-07-24T14:26:04Z | 2021-09-09T02:11:53Z | 2012-08-11T09:03:58Z | CONTRIBUTOR | resolved | I'm sending a `POST` request with multiple fields with the same name which normally works well when passed in a `dict`:
```
>>> from requests import post
>>> print post('http://httpbin.org/post', data={'field': ['a', 'b']}).content
{
"origin": "[...]",
"files": {},
"form": {
"field": [
"a",
"b"
]
},
"url": "http://httpbin.org/post",
"args": {},
"headers": {
"Content-Length": "15",
"Accept-Encoding": "identity, deflate, compress, gzip",
"Connection": "keep-alive",
"Accept": "*/*",
"User-Agent": "python-requests/0.13.1",
"Host": "httpbin.org",
"Content-Type": "application/x-www-form-urlencoded"
},
"json": null,
"data": ""
}
```
But fails with a `TypeError` when the request is a `multipart/form-data` one:
```
>>> print post('http://httpbin.org/post', data={'field': ['a', 'b']}, files={'file': open('/etc/hosts')}).content
Traceback (most recent call last):
File "<ipython-input-15-4008ff697f5a>", line 1, in <module>
print requests.post('http://httpbin.org/post', data={'field': ['a', 'b']}, files={'file': open('/etc/hosts')}).content
File "python2.7/site-packages/requests/api.py", line 87, in post
return request('post', url, data=data, **kwargs)
File "python2.7/site-packages/requests/safe_mode.py", line 37, in wrapped
return function(method, url, **kwargs)
File "python2.7/site-packages/requests/api.py", line 42, in request
return s.request(method=method, url=url, **kwargs)
File "python2.7/site-packages/requests/sessions.py", line 230, in request
r.send(prefetch=prefetch)
File "python2.7/site-packages/requests/models.py", line 507, in send
(body, content_type) = self._encode_files(self.files)
File "site-packages/requests/models.py", line 366, in _encode_files
(body, content_type) = encode_multipart_formdata(fields)
File "site-packages/requests/packages/urllib3/filepost.py", line 80, in encode_multipart_formdata
body.write(data)
TypeError: 'list' does not have the buffer interface
```
Passing a `list` of `tuple`s doesn't raise an exception but only the last item is included in the request:
```
>>> print requests.post('http://httpbin.org/post', data=[('field', 'a'), ('field', 'b')], files={'file': open('/etc/hosts')}).content
{
"origin": "[...]",
"files": {
"file": "[...]"
},
"form": {
"field": "b"
},
"url": "http://httpbin.org/post",
"args": {},
"headers": {
"Content-Length": "862",
"Accept-Encoding": "identity, deflate, compress, gzip",
"Connection": "keep-alive",
"Accept": "*/*",
"User-Agent": "python-requests/0.13.1",
"Host": "httpbin.org",
"Content-Type": "multipart/form-data; boundary=127.0.0.1.501.73436.1343139319.461.6"
},
"json": null,
"data": ""
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/737/reactions"
} | https://api.github.com/repos/psf/requests/issues/737/timeline | null | completed | null | null | false | [
"I've just started looking into this, and I can explain the behaviour of the second case. The list of tuples you provided to `data` has `dict()` called on it. Dictionaries (obviously) don't allow duplicate keys, but your list of tuples has duplicate keys, so the last item in the iterable takes the value for that ke... |
https://api.github.com/repos/psf/requests/issues/736 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/736/labels{/name} | https://api.github.com/repos/psf/requests/issues/736/comments | https://api.github.com/repos/psf/requests/issues/736/events | https://github.com/psf/requests/pull/736 | 5,754,798 | MDExOlB1bGxSZXF1ZXN0MTg1NjU1Ng== | 736 | Make OAuth path hack platform independent. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-07-21T17:14:04Z | 2021-09-08T23:07:34Z | 2012-07-27T05:29:58Z | MEMBER | resolved | This _should_ resolve issue #735. I'd love it if someone could run a test on a Windows box, as I don't have easy access to one at the minute.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/736/reactions"
} | https://api.github.com/repos/psf/requests/issues/736/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/736.diff",
"html_url": "https://github.com/psf/requests/pull/736",
"merged_at": "2012-07-27T05:29:58Z",
"patch_url": "https://github.com/psf/requests/pull/736.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/736"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1922177) (merged 79aa9edd into 876e1744).\n",
"Thought I'd fix up some typos while I had a pull request open. Can't hurt.\n",
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1950590) (merged 55237ad6 into... |
https://api.github.com/repos/psf/requests/issues/735 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/735/labels{/name} | https://api.github.com/repos/psf/requests/issues/735/comments | https://api.github.com/repos/psf/requests/issues/735/events | https://github.com/psf/requests/issues/735 | 5,750,477 | MDU6SXNzdWU1NzUwNDc3 | 735 | NameError: global name 'Client' is not defined | {
"avatar_url": "https://avatars.githubusercontent.com/u/1452723?v=4",
"events_url": "https://api.github.com/users/linguinee/events{/privacy}",
"followers_url": "https://api.github.com/users/linguinee/followers",
"following_url": "https://api.github.com/users/linguinee/following{/other_user}",
"gists_url": "https://api.github.com/users/linguinee/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/linguinee",
"id": 1452723,
"login": "linguinee",
"node_id": "MDQ6VXNlcjE0NTI3MjM=",
"organizations_url": "https://api.github.com/users/linguinee/orgs",
"received_events_url": "https://api.github.com/users/linguinee/received_events",
"repos_url": "https://api.github.com/users/linguinee/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/linguinee/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linguinee/subscriptions",
"type": "User",
"url": "https://api.github.com/users/linguinee",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-07-21T02:30:30Z | 2021-09-09T07:05:32Z | 2012-07-21T20:48:15Z | NONE | resolved | I ran into trouble running [Twython](https://github.com/ryanmcgrath/twython). It seems to be a problem with `requests`, since my authentication keys are correct (and the script runs on another computer).
```
Traceback (most recent call last):
File "C:\Users\Yi-Yi\Documents\Yi-Yi\Projects\Programs\Twitter Art Bot\foo.py", line 11, in <module>
oauth_token_secret=ACCESS_TOKEN_SECRET)
File "C:\Python27\lib\site-packages\twython-2.3.2-py2.7.egg\twython\twython.py", line 131, in __init__
signature_type='auth_header')
File "C:\Python27\lib\site-packages\requests-0.13.3-py2.7.egg\requests\auth.py", line 57, in __init__
self.client = Client(client_key, client_secret, resource_owner_key,
NameError: global name 'Client' is not defined
```
The code the error is from:
```
from twython import Twython
CONSUMER_KEY = '...'
CONSUMER_SECRET = '...'
ACCESS_TOKEN = '...'
ACCESS_TOKEN_SECRET = '...'
t = Twython(app_key=CONSUMER_KEY,
app_secret=CONSUMER_SECRET,
oauth_token=ACCESS_TOKEN,
oauth_token_secret=ACCESS_TOKEN_SECRET)
print t.getHomeTimeline()
```
I'm running `requests.__version__` 0.13.3. I'm running this on Windows Vista 64-bit, Python 2.7.3.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1452723?v=4",
"events_url": "https://api.github.com/users/linguinee/events{/privacy}",
"followers_url": "https://api.github.com/users/linguinee/followers",
"following_url": "https://api.github.com/users/linguinee/following{/other_user}",
"gists_url": "https://api.github.com/users/linguinee/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/linguinee",
"id": 1452723,
"login": "linguinee",
"node_id": "MDQ6VXNlcjE0NTI3MjM=",
"organizations_url": "https://api.github.com/users/linguinee/orgs",
"received_events_url": "https://api.github.com/users/linguinee/received_events",
"repos_url": "https://api.github.com/users/linguinee/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/linguinee/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linguinee/subscriptions",
"type": "User",
"url": "https://api.github.com/users/linguinee",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/735/reactions"
} | https://api.github.com/repos/psf/requests/issues/735/timeline | null | completed | null | null | false | [
"This is the result of a bug in the OAuth path hack, I think. Specifically, [this path hack](https://github.com/kennethreitz/requests/blob/develop/requests/_oauth.py#L19) works great on *nix where the path separator is /, but does not work on Windows where it is .\n\nIf you want a quick fix, you can install OAuthLi... |
https://api.github.com/repos/psf/requests/issues/734 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/734/labels{/name} | https://api.github.com/repos/psf/requests/issues/734/comments | https://api.github.com/repos/psf/requests/issues/734/events | https://github.com/psf/requests/pull/734 | 5,743,354 | MDExOlB1bGxSZXF1ZXN0MTg1MjA3Nw== | 734 | Include response.reason in raised HTTPErrors | {
"avatar_url": "https://avatars.githubusercontent.com/u/817118?v=4",
"events_url": "https://api.github.com/users/doismellburning/events{/privacy}",
"followers_url": "https://api.github.com/users/doismellburning/followers",
"following_url": "https://api.github.com/users/doismellburning/following{/other_user}",
"gists_url": "https://api.github.com/users/doismellburning/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/doismellburning",
"id": 817118,
"login": "doismellburning",
"node_id": "MDQ6VXNlcjgxNzExOA==",
"organizations_url": "https://api.github.com/users/doismellburning/orgs",
"received_events_url": "https://api.github.com/users/doismellburning/received_events",
"repos_url": "https://api.github.com/users/doismellburning/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/doismellburning/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/doismellburning/subscriptions",
"type": "User",
"url": "https://api.github.com/users/doismellburning",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-07-20T18:35:00Z | 2021-09-08T23:08:22Z | 2012-07-24T13:46:35Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/734/reactions"
} | https://api.github.com/repos/psf/requests/issues/734/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/734.diff",
"html_url": "https://github.com/psf/requests/pull/734",
"merged_at": "2012-07-24T13:46:35Z",
"patch_url": "https://github.com/psf/requests/pull/734.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/734"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1916144) (merged c485928a into 876e1744).\n",
"thanks!\n"
] | |
https://api.github.com/repos/psf/requests/issues/733 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/733/labels{/name} | https://api.github.com/repos/psf/requests/issues/733/comments | https://api.github.com/repos/psf/requests/issues/733/events | https://github.com/psf/requests/pull/733 | 5,742,549 | MDExOlB1bGxSZXF1ZXN0MTg1MTYyMQ== | 733 | Include response.content in raised HTTPErrors | {
"avatar_url": "https://avatars.githubusercontent.com/u/817118?v=4",
"events_url": "https://api.github.com/users/doismellburning/events{/privacy}",
"followers_url": "https://api.github.com/users/doismellburning/followers",
"following_url": "https://api.github.com/users/doismellburning/following{/other_user}",
"gists_url": "https://api.github.com/users/doismellburning/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/doismellburning",
"id": 817118,
"login": "doismellburning",
"node_id": "MDQ6VXNlcjgxNzExOA==",
"organizations_url": "https://api.github.com/users/doismellburning/orgs",
"received_events_url": "https://api.github.com/users/doismellburning/received_events",
"repos_url": "https://api.github.com/users/doismellburning/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/doismellburning/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/doismellburning/subscriptions",
"type": "User",
"url": "https://api.github.com/users/doismellburning",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2012-07-20T17:52:00Z | 2021-09-08T23:08:23Z | 2012-07-20T17:53:28Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/733/reactions"
} | https://api.github.com/repos/psf/requests/issues/733/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/733.diff",
"html_url": "https://github.com/psf/requests/pull/733",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/733.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/733"
} | true | [
"I don't think this is a good idea. I wouldn't be against adding `response.reason` though.\n",
"So, I had a niggling feeling that it might not be, but no idea why; I'd be curious to hear your reasoning...\n",
"Requests doesn't read the response bodies until the user access them.\n\nAlso, many responses are bina... | |
https://api.github.com/repos/psf/requests/issues/732 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/732/labels{/name} | https://api.github.com/repos/psf/requests/issues/732/comments | https://api.github.com/repos/psf/requests/issues/732/events | https://github.com/psf/requests/issues/732 | 5,691,987 | MDU6SXNzdWU1NjkxOTg3 | 732 | `Content-Disposition` in subpart header includes `filename` for non-file multipart fields | {
"avatar_url": "https://avatars.githubusercontent.com/u/62200?v=4",
"events_url": "https://api.github.com/users/enginoid/events{/privacy}",
"followers_url": "https://api.github.com/users/enginoid/followers",
"following_url": "https://api.github.com/users/enginoid/following{/other_user}",
"gists_url": "https://api.github.com/users/enginoid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/enginoid",
"id": 62200,
"login": "enginoid",
"node_id": "MDQ6VXNlcjYyMjAw",
"organizations_url": "https://api.github.com/users/enginoid/orgs",
"received_events_url": "https://api.github.com/users/enginoid/received_events",
"repos_url": "https://api.github.com/users/enginoid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/enginoid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/enginoid/subscriptions",
"type": "User",
"url": "https://api.github.com/users/enginoid",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2012-07-18T15:21:43Z | 2021-09-09T06:00:56Z | 2012-08-03T17:10:08Z | NONE | resolved | The `files` parameter can be used to submit multipart form data. I'm not certain whether `files` is a misnomer (since multipart form data doesn't necessary) or whether the implementation purposefully limits itself to supporting files as multipart data. However, there are valid use cases for multipart forms where some of the fields are not files.
Take for example an API that allows you to POST a file along with a description of that file:
``` python
>>> url = 'http://httpbin.org/post'
>>> files = {
'file': open('report.xls', 'rb'),
'description': 'The PKIs that will drive synergy for the quarterly social'
'media campaign in the cloud.'
}
>>> r = requests.post(url, files=files)
```
In this case, the `description` field is not being used for file data.
The problem is that this field is nevertheless treated as being file data, as `filename` is added to `Content-Disposition` header of the subpart, defaulting to the value of `name` (or using `file.name` if available.)
`urllib3` supports subparts that don't have file names (in `urllib3.filepost.encode_multipart_formdata`), and appropriately omits the `filename` parameter:
``` python
def encode_multipart_formdata(fields, boundary=None):
# ...
for fieldname, value in iter_fields(fields):
# ...
if isinstance(value, tuple):
filename, data = value
writer(body).write('Content-Disposition: form-data; name="%s"; '
'filename="%s"\r\n' % (fieldname, filename))
body.write(b('Content-Type: %s\r\n\r\n' %
(get_content_type(filename))))
else:
data = value
writer(body).write('Content-Disposition: form-data; name="%s"\r\n'
% (fieldname))
body.write(b'Content-Type: text/plain\r\n\r\n')
```
However, `isinstance(value, tuple)` in this function is always true, courtesy of this code in the library:
``` python
class Request(object):
# ...
def _encode_files(self, files):
# ...
for (k, v) in list(files.items()):
# support for explicit filename
if isinstance(v, (tuple, list)):
fn, fp = v
else:
fn = guess_filename(v) or k
fp = v
if isinstance(fp, (bytes, str)):
fp = StringIO(fp)
fields.update({k: (fn, fp.read())})
(body, content_type) = encode_multipart_formdata(fields)
return (body, content_type)
```
I'd like to suggest that if no filename is provided (and it can't be read from `file.name`), the default behavior is to not include the `filename` parameter in the `Content-Disposition` subpart header. This is simply a matter of not passing `encode_multipart_formdata` a filename for a given field if one is not provided in the `Request.files` parameter (instead of providing a default, as is now done.)
I'm posting this because a service I'm interfacing with changes its behavior if the `filename` is provided for a non-file field. After reading through RFC 2388, I determined that the right place to fix this is probably in `requests` instead of the original library. I can elaborate if necessary.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/62200?v=4",
"events_url": "https://api.github.com/users/enginoid/events{/privacy}",
"followers_url": "https://api.github.com/users/enginoid/followers",
"following_url": "https://api.github.com/users/enginoid/following{/other_user}",
"gists_url": "https://api.github.com/users/enginoid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/enginoid",
"id": 62200,
"login": "enginoid",
"node_id": "MDQ6VXNlcjYyMjAw",
"organizations_url": "https://api.github.com/users/enginoid/orgs",
"received_events_url": "https://api.github.com/users/enginoid/received_events",
"repos_url": "https://api.github.com/users/enginoid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/enginoid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/enginoid/subscriptions",
"type": "User",
"url": "https://api.github.com/users/enginoid",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/732/reactions"
} | https://api.github.com/repos/psf/requests/issues/732/timeline | null | completed | null | null | false | [
"You can specify a blank filename if you'd like.\n",
"Also, you can pass both a `data` and `files` parameter, and they will be merged appropriately. \n",
"Yes, that suits my purposes quite nicely. My problem is that even when I specify a blank filename, the `filename` parameter is still passed into `Content-Di... |
https://api.github.com/repos/psf/requests/issues/731 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/731/labels{/name} | https://api.github.com/repos/psf/requests/issues/731/comments | https://api.github.com/repos/psf/requests/issues/731/events | https://github.com/psf/requests/pull/731 | 5,686,152 | MDExOlB1bGxSZXF1ZXN0MTgyNTMwOQ== | 731 | breaks under python 2.7, without the from __future__ import | {
"avatar_url": "https://avatars.githubusercontent.com/u/92518?v=4",
"events_url": "https://api.github.com/users/jorjun/events{/privacy}",
"followers_url": "https://api.github.com/users/jorjun/followers",
"following_url": "https://api.github.com/users/jorjun/following{/other_user}",
"gists_url": "https://api.github.com/users/jorjun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jorjun",
"id": 92518,
"login": "jorjun",
"node_id": "MDQ6VXNlcjkyNTE4",
"organizations_url": "https://api.github.com/users/jorjun/orgs",
"received_events_url": "https://api.github.com/users/jorjun/received_events",
"repos_url": "https://api.github.com/users/jorjun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jorjun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jorjun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jorjun",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2012-07-18T10:59:45Z | 2021-09-08T16:00:47Z | 2012-07-18T14:44:37Z | NONE | resolved | If python support < 2.6 is required, will need to make this import conditional
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/731/reactions"
} | https://api.github.com/repos/psf/requests/issues/731/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/731.diff",
"html_url": "https://github.com/psf/requests/pull/731",
"merged_at": "2012-07-18T14:44:37Z",
"patch_url": "https://github.com/psf/requests/pull/731.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/731"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1893840) (merged 2c241d28 into 73815e2e).\n",
"No need to make the import conditional: [Requests only supports 2.6 and higher](http://docs.python-requests.org/en/latest/community/faq/#python-3-support).\n",
"Ah, thanks. Do I need to d... |
https://api.github.com/repos/psf/requests/issues/730 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/730/labels{/name} | https://api.github.com/repos/psf/requests/issues/730/comments | https://api.github.com/repos/psf/requests/issues/730/events | https://github.com/psf/requests/issues/730 | 5,634,270 | MDU6SXNzdWU1NjM0Mjcw | 730 | HTTPS failing with protocol error / timeout | {
"avatar_url": "https://avatars.githubusercontent.com/u/229943?v=4",
"events_url": "https://api.github.com/users/dpnova/events{/privacy}",
"followers_url": "https://api.github.com/users/dpnova/followers",
"following_url": "https://api.github.com/users/dpnova/following{/other_user}",
"gists_url": "https://api.github.com/users/dpnova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dpnova",
"id": 229943,
"login": "dpnova",
"node_id": "MDQ6VXNlcjIyOTk0Mw==",
"organizations_url": "https://api.github.com/users/dpnova/orgs",
"received_events_url": "https://api.github.com/users/dpnova/received_events",
"repos_url": "https://api.github.com/users/dpnova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dpnova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dpnova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dpnova",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2012-07-16T08:15:52Z | 2021-09-09T07:05:32Z | 2012-07-27T05:46:31Z | NONE | resolved | Connecting to some HTTP sites is failing. It seems to be sites that use TLS and OpenSSL isn't selecting the right SSL protocol to communicate with the server. This seems to be an issue on Ubuntu 12.04 so far..
There is more discussion here: https://bugs.launchpad.net/ubuntu/+source/openssl/+bug/965371
Example to test is below:
```
>>> import requests
>>> requests.get("https://www.acgov.org/alco_ssl_app/rov/voter_info/voter_profile.jsp?formLanguage=E")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/api.py", line 54, in get
return request('get', url, **kwargs)
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/safe_mode.py", line 37, in wrapped
return function(method, url, **kwargs)
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/api.py", line 42, in request
return s.request(method=method, url=url, **kwargs)
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/sessions.py", line 230, in request
r.send(prefetch=prefetch)
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/models.py", line 613, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 8] _ssl.c:504: EOF occurred in violation of protocol
>>> requests.get("https://www.acgov.org/alco_ssl_app/rov/voter_info/voter_profile.jsp?formLanguage=E", verify=False)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/api.py", line 54, in get
return request('get', url, **kwargs)
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/safe_mode.py", line 37, in wrapped
return function(method, url, **kwargs)
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/api.py", line 42, in request
return s.request(method=method, url=url, **kwargs)
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/sessions.py", line 230, in request
r.send(prefetch=prefetch)
File "/home/dpn/.virtualenvs/scrapers/local/lib/python2.7/site-packages/requests/models.py", line 615, in send
raise Timeout('Request timed out.')
requests.exceptions.Timeout: Request timed out.
>>>
```
It seems that manually specifying the SSL version to use may be the best option until the problem is fixed.
It seems the issue of selecting SSL version has come up here before: https://github.com/kennethreitz/requests/issues/606
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/730/reactions"
} | https://api.github.com/repos/psf/requests/issues/730/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/729 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/729/labels{/name} | https://api.github.com/repos/psf/requests/issues/729/comments | https://api.github.com/repos/psf/requests/issues/729/events | https://github.com/psf/requests/pull/729 | 5,623,421 | MDExOlB1bGxSZXF1ZXN0MTc5NzUxNQ== | 729 | Added needed cast for when POSTing data and files (Issue #661) | {
"avatar_url": "https://avatars.githubusercontent.com/u/1755286?v=4",
"events_url": "https://api.github.com/users/vickimo/events{/privacy}",
"followers_url": "https://api.github.com/users/vickimo/followers",
"following_url": "https://api.github.com/users/vickimo/following{/other_user}",
"gists_url": "https://api.github.com/users/vickimo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vickimo",
"id": 1755286,
"login": "vickimo",
"node_id": "MDQ6VXNlcjE3NTUyODY=",
"organizations_url": "https://api.github.com/users/vickimo/orgs",
"received_events_url": "https://api.github.com/users/vickimo/received_events",
"repos_url": "https://api.github.com/users/vickimo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vickimo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vickimo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vickimo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2012-07-14T22:30:26Z | 2021-09-08T23:07:32Z | 2012-07-27T05:33:51Z | CONTRIBUTOR | resolved | Co-Authored By: Timnit Gebru tgebru@gmail.com @tgebru
Co-Authored By: Sarah Gonzalez smar.gonz@gmail.com @smargonz
Co-Authored By: Leila Muhtasib muhtasib@gmail.com @muhtasib
This is a fix for Issue #661.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/729/reactions"
} | https://api.github.com/repos/psf/requests/issues/729/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/729.diff",
"html_url": "https://github.com/psf/requests/pull/729",
"merged_at": "2012-07-27T05:33:51Z",
"patch_url": "https://github.com/psf/requests/pull/729.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/729"
} | true | [
"This pull request [passes](http://travis-ci.org/kennethreitz/requests/builds/1867038) (merged f9c0ddf4 into a97a5133).\n",
"Thanks!\n"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.