diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/project/library/CM/Mail.php b/project/library/CM/Mail.php index <HASH>..<HASH> 100644 --- a/project/library/CM/Mail.php +++ b/project/library/CM/Mail.php @@ -183,7 +183,7 @@ class CM_Mail extends CM_Renderable_Abstract { } list($subject, $html, $text) = CM_Render::getInstance($site)->render($this); ...
mail-queue has no subject; fixed
diff --git a/src/define/build.js b/src/define/build.js index <HASH>..<HASH> 100644 --- a/src/define/build.js +++ b/src/define/build.js @@ -28,11 +28,20 @@ var _gpfDefinedEntities = []; * @since 0.2.4 */ function _gpfDefineGetEntityFromBuilder (instanceBuilder) { - return _gpfArrayForEachFalsy(_gpfDefinedEntitie...
Working on native inheritance (#<I>)
diff --git a/src/gc.js b/src/gc.js index <HASH>..<HASH> 100644 --- a/src/gc.js +++ b/src/gc.js @@ -59,6 +59,7 @@ function GarbageCollector(consumer) { } function registerEvents() { + unregisterEvents(); consumer.on(events.GC_SM_QUEUE, (queue) => { debug(`Inspecting processing qu...
Always call unregisterEvents() before registering new events In case of improper shutdown, this will prevent GC from behaving incorrectly (duplicate listeners) and also from memory leakage (accumulating listeners).
diff --git a/zetta-app.js b/zetta-app.js index <HASH>..<HASH> 100644 --- a/zetta-app.js +++ b/zetta-app.js @@ -173,8 +173,18 @@ function Application(appFolder, appConfig) { if(self.config.caption) zutils.render(self.config.caption); - if(self.config.translator) - self.translator = new Tran...
Fixed some problems with new version of zetta-translator
diff --git a/core/client/fs/src/main/java/alluxio/client/block/stream/NettyPacketWriter.java b/core/client/fs/src/main/java/alluxio/client/block/stream/NettyPacketWriter.java index <HASH>..<HASH> 100644 --- a/core/client/fs/src/main/java/alluxio/client/block/stream/NettyPacketWriter.java +++ b/core/client/fs/src/main/j...
Improve core/client/fs/src/main/java/alluxio/client/block/stream/NettyPacketWriter.java as mBufferNotFullOrFailed can be marked as final.\nChange\n private Condition mBufferNotFullOrFailed = mLock.newCondition();\nto\n private final Condition mBufferNotFullOrFailed = mLock.newCondition();
diff --git a/components/input/__tests__/textarea.test.js b/components/input/__tests__/textarea.test.js index <HASH>..<HASH> 100644 --- a/components/input/__tests__/textarea.test.js +++ b/components/input/__tests__/textarea.test.js @@ -115,6 +115,7 @@ describe('TextArea', () => { }, }, ]); + ...
test: Fix resize related test case
diff --git a/lib/active_admin_import/model.rb b/lib/active_admin_import/model.rb index <HASH>..<HASH> 100644 --- a/lib/active_admin_import/model.rb +++ b/lib/active_admin_import/model.rb @@ -138,8 +138,10 @@ module ActiveAdminImport def encode(data) data = content_encode(data) if force_encoding? - da...
universal_newline - Replaces \rn and \r with \n
diff --git a/client-js/utilities/fetch-json.js b/client-js/utilities/fetch-json.js index <HASH>..<HASH> 100644 --- a/client-js/utilities/fetch-json.js +++ b/client-js/utilities/fetch-json.js @@ -18,7 +18,12 @@ export default function fetchJson(method, url, body) { opts.body = JSON.stringify(body) } - return ...
Fix api/app GET when BASE_URL is defined (#<I>)
diff --git a/core/Tracker/TableLogAction.php b/core/Tracker/TableLogAction.php index <HASH>..<HASH> 100644 --- a/core/Tracker/TableLogAction.php +++ b/core/Tracker/TableLogAction.php @@ -233,6 +233,11 @@ class TableLogAction } /** + * This function will sanitize or not if it's needed for the specified a...
add a comment about perceived inconsistencies
diff --git a/cdn/controllers/blank_avatar.php b/cdn/controllers/blank_avatar.php index <HASH>..<HASH> 100644 --- a/cdn/controllers/blank_avatar.php +++ b/cdn/controllers/blank_avatar.php @@ -53,7 +53,7 @@ class NAILS_Blank_avatar extends NAILS_CDN_Controller // Determine dynamic values $this->_width = $this->uri...
Ignoring case of sex
diff --git a/lib/fluent/plugin/out_file.rb b/lib/fluent/plugin/out_file.rb index <HASH>..<HASH> 100644 --- a/lib/fluent/plugin/out_file.rb +++ b/lib/fluent/plugin/out_file.rb @@ -223,7 +223,12 @@ module Fluent::Plugin def write_without_compression(path, chunk) File.open(path, "ab", @file_perm) do |f| - ...
Make out_file append option work without compression For Ruby <I>.x and <I>.x, out_file append option without compression does not work. The cause is the following Ruby language bug: <URL>
diff --git a/src/Controller/RolesController.php b/src/Controller/RolesController.php index <HASH>..<HASH> 100644 --- a/src/Controller/RolesController.php +++ b/src/Controller/RolesController.php @@ -32,7 +32,7 @@ class RolesController extends AppController public function view($id = null) { $role = $...
passing related capabilities to View (task #<I>)
diff --git a/rapidoid-pages/src/main/java/org/rapidoid/widget/PagerWidget.java b/rapidoid-pages/src/main/java/org/rapidoid/widget/PagerWidget.java index <HASH>..<HASH> 100644 --- a/rapidoid-pages/src/main/java/org/rapidoid/widget/PagerWidget.java +++ b/rapidoid-pages/src/main/java/org/rapidoid/widget/PagerWidget.java @...
Improved pager - display only when more than 1 page is available.
diff --git a/src/yimaTheme/Manager/DefaultListenerAggregate.php b/src/yimaTheme/Manager/DefaultListenerAggregate.php index <HASH>..<HASH> 100644 --- a/src/yimaTheme/Manager/DefaultListenerAggregate.php +++ b/src/yimaTheme/Manager/DefaultListenerAggregate.php @@ -158,7 +158,7 @@ class DefaultListenerAggregate extends Ma...
fix theme manager issue on not detected themes
diff --git a/lib/beaker-vmpooler/version.rb b/lib/beaker-vmpooler/version.rb index <HASH>..<HASH> 100644 --- a/lib/beaker-vmpooler/version.rb +++ b/lib/beaker-vmpooler/version.rb @@ -1,3 +1,3 @@ module BeakerVmpooler - VERSION = '1.3.2' + VERSION = '1.3.3' end
(GEM) update beaker-vmpooler version to <I>
diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php index <HASH>..<HASH> 100644 --- a/lib/db/upgrade.php +++ b/lib/db/upgrade.php @@ -1465,6 +1465,14 @@ function xmldb_main_upgrade($oldversion) { upgrade_main_savepoint(true, 2012111200.00); } + if ($oldversion < 2012111200.01) { + // Force th...
MDL-<I> upgrade: Force courses cache to be rebuilt
diff --git a/src/Illuminate/Support/Arr.php b/src/Illuminate/Support/Arr.php index <HASH>..<HASH> 100755 --- a/src/Illuminate/Support/Arr.php +++ b/src/Illuminate/Support/Arr.php @@ -110,9 +110,10 @@ class Arr { foreach ($array as $value) { - $value = (array) $value; - - $results[] = $value[$segment]; +...
Ensure we can fetch an array with non existing keys
diff --git a/spec/filter_spec.rb b/spec/filter_spec.rb index <HASH>..<HASH> 100644 --- a/spec/filter_spec.rb +++ b/spec/filter_spec.rb @@ -199,7 +199,7 @@ describe Philtre::Filter do end it 'not_blank' do - field = Sequel.expr Faker::Lorem.word + field = Faker::Lorem.word expr = described_c...
don't pass Sequel::Sql::Expression as a field name in specs
diff --git a/src/clappr-dash-shaka-playback.js b/src/clappr-dash-shaka-playback.js index <HASH>..<HASH> 100644 --- a/src/clappr-dash-shaka-playback.js +++ b/src/clappr-dash-shaka-playback.js @@ -121,10 +121,8 @@ class DashShakaPlayback extends HTML5Video { } pause() { - super.pause() - - if (this.dvrEnabl...
refactor: overwrite pause method
diff --git a/sshtunnel.py b/sshtunnel.py index <HASH>..<HASH> 100644 --- a/sshtunnel.py +++ b/sshtunnel.py @@ -610,15 +610,16 @@ class SSHTunnelForwarder(object): .format(ssh_config_file)) if not ssh_password: - ssh_private_key = paramiko.RSAKey.from_private_key_fi...
Support paramiko PKey as ssh_private_key
diff --git a/spec/build_tests_spec.rb b/spec/build_tests_spec.rb index <HASH>..<HASH> 100644 --- a/spec/build_tests_spec.rb +++ b/spec/build_tests_spec.rb @@ -12,10 +12,11 @@ describe Rscons do end def test_dir(build_test_directory) - Dir.chdir("build_tests_run/#{build_test_directory}") + dir = "build_tes...
require rscons when running build test in a ruby subprocess
diff --git a/src/Guzzle/Http/Client.php b/src/Guzzle/Http/Client.php index <HASH>..<HASH> 100644 --- a/src/Guzzle/Http/Client.php +++ b/src/Guzzle/Http/Client.php @@ -478,9 +478,10 @@ class Client extends AbstractHasDispatcher implements ClientInterface } /** - * Copy the cecert.pem file from the phar i...
Updating docblock for preparePharCacert
diff --git a/simple_unit_tests.py b/simple_unit_tests.py index <HASH>..<HASH> 100644 --- a/simple_unit_tests.py +++ b/simple_unit_tests.py @@ -157,4 +157,9 @@ class TestParseAction(PyparsingExpressionTestCase): if __name__ == '__main__': + # we use unittest features that are in Py3 only, bail out if run on ...
simple_unit_tests.py only runs on Py3
diff --git a/lib/logger.js b/lib/logger.js index <HASH>..<HASH> 100644 --- a/lib/logger.js +++ b/lib/logger.js @@ -72,7 +72,8 @@ define( info.push(elemToString(elem)); info.push(component.constructor.describe.split(' ').slice(0,3).join(' ')); console.groupCollapsed && action == 'trigger' && c...
console.info.apply fix for IE9 Logging was breaking in IE9 because console.info.apply is undefined (even when dev tools is open and console.info is defined). See: <URL>
diff --git a/admin/webservice/forms.php b/admin/webservice/forms.php index <HASH>..<HASH> 100644 --- a/admin/webservice/forms.php +++ b/admin/webservice/forms.php @@ -112,7 +112,7 @@ class external_service_form extends moodleform { $mform->setType('id', PARAM_INT); if (!empty($service->id)) { - ...
MDL-<I> rename 'Edit service' to 'Save changes'
diff --git a/src/actions.js b/src/actions.js index <HASH>..<HASH> 100644 --- a/src/actions.js +++ b/src/actions.js @@ -14,7 +14,7 @@ export function dispatchGlobalEvent(eventName, opts, target = window) { if (typeof window.CustomEvent === 'function') { event = new window.CustomEvent(eventName, { detail: o...
Fix for IE<I> custom event
diff --git a/src/test/org/openscience/cdk/tools/diff/tree/IntegerDifferenceTest.java b/src/test/org/openscience/cdk/tools/diff/tree/IntegerDifferenceTest.java index <HASH>..<HASH> 100644 --- a/src/test/org/openscience/cdk/tools/diff/tree/IntegerDifferenceTest.java +++ b/src/test/org/openscience/cdk/tools/diff/tree/Inte...
Added a test to ensure that Integer objects are compared by value rather than reference
diff --git a/beanstalkc.py b/beanstalkc.py index <HASH>..<HASH> 100644 --- a/beanstalkc.py +++ b/beanstalkc.py @@ -53,7 +53,7 @@ class Connection(object): self.socket.close() def _interact(self, command, expected_ok, expected_err=[]): - self.socket.send(command) + self.socket.sendall(comma...
Use socket#sendall to fail faster
diff --git a/src/Env/index.js b/src/Env/index.js index <HASH>..<HASH> 100644 --- a/src/Env/index.js +++ b/src/Env/index.js @@ -75,7 +75,7 @@ class Env { _.each(matches, (match) => { const key = match.replace(/\$|{|}/g, '') const variable = envConfig[key] || process.env[key] || '' - env = env.rep...
fix(env): ensure envConfig is used to interpolate env file (#<I>)
diff --git a/Tone/component/Meter.js b/Tone/component/Meter.js index <HASH>..<HASH> 100644 --- a/Tone/component/Meter.js +++ b/Tone/component/Meter.js @@ -5,7 +5,7 @@ define(["Tone/core/Tone", "Tone/core/Master"], function(Tone){ /** * @class Get the rms of the input signal with some averaging. * can...
removed doc links they were breaking jsdocs.
diff --git a/src/Providers/DashboardServiceProvider.php b/src/Providers/DashboardServiceProvider.php index <HASH>..<HASH> 100644 --- a/src/Providers/DashboardServiceProvider.php +++ b/src/Providers/DashboardServiceProvider.php @@ -51,6 +51,9 @@ class DashboardServiceProvider extends ServiceProvider __DIR__ ....
repaired missing translation include from upstream merge
diff --git a/daemon_windows.go b/daemon_windows.go index <HASH>..<HASH> 100644 --- a/daemon_windows.go +++ b/daemon_windows.go @@ -53,3 +53,8 @@ func (windows *windowsRecord) Status() (string, error) { return "Status could not defined", errors.New("windows daemon is not supported") } + +// Get executable path +fun...
Stub execPath method to compile for windows
diff --git a/src/components/Bootstrap.php b/src/components/Bootstrap.php index <HASH>..<HASH> 100644 --- a/src/components/Bootstrap.php +++ b/src/components/Bootstrap.php @@ -153,6 +153,8 @@ class Bootstrap extends CApplicationComponent * Each array key-value pair represents the initial options for a single plugin c...
Marked `Bootstrap.plugins` as deprecated starting from version <I>
diff --git a/core-bundle/contao/classes/Pagination.php b/core-bundle/contao/classes/Pagination.php index <HASH>..<HASH> 100644 --- a/core-bundle/contao/classes/Pagination.php +++ b/core-bundle/contao/classes/Pagination.php @@ -209,7 +209,7 @@ class Pagination extends \Frontend // Prepare the URL foreach (preg_spl...
[Core] Fixed two remaining issues with the new unique pagination variables (see #<I>)
diff --git a/libnetwork/drivers/macvlan/macvlan_network.go b/libnetwork/drivers/macvlan/macvlan_network.go index <HASH>..<HASH> 100644 --- a/libnetwork/drivers/macvlan/macvlan_network.go +++ b/libnetwork/drivers/macvlan/macvlan_network.go @@ -29,7 +29,6 @@ func (d *driver) CreateNetwork(nid string, option map[string]in...
libnetwork: macvlan: set network ID as part of parseNetworkOptions
diff --git a/parser/parser_test.go b/parser/parser_test.go index <HASH>..<HASH> 100644 --- a/parser/parser_test.go +++ b/parser/parser_test.go @@ -705,6 +705,10 @@ var bashTests = []struct { `1:7: ++ must be followed by a word`, }, { + "let a+\n", + `1:7: + must be followed by an expression`, + }, + { "let ...
parser: fix hang introduced by removing STOPPED
diff --git a/tests/ClientTest.php b/tests/ClientTest.php index <HASH>..<HASH> 100644 --- a/tests/ClientTest.php +++ b/tests/ClientTest.php @@ -164,14 +164,22 @@ class ClientTest extends TestCase protected function createClient() { $client = null; + $exception = null; + self::$factory-...
Throw exception if redis is not running
diff --git a/ykman/cli/info.py b/ykman/cli/info.py index <HASH>..<HASH> 100644 --- a/ykman/cli/info.py +++ b/ykman/cli/info.py @@ -142,7 +142,8 @@ def _check_fips_status(pid, info): @click.option( "-c", "--check-fips", - help="Check if YubiKey is in FIPS Approved mode (YubiKey FIPS only).", + help="Che...
Clarify that --check-fips/-c for info is YK4 only.
diff --git a/tests/test_mypolr.py b/tests/test_mypolr.py index <HASH>..<HASH> 100644 --- a/tests/test_mypolr.py +++ b/tests/test_mypolr.py @@ -1,9 +1,12 @@ import requests import responses import pytest +import sys from mypolr import PolrApi, DEFAULT_API_ROOT, exceptions as polr_errors -from mypolr.__main__ impor...
update CLI-test to only run on Python >=<I>
diff --git a/lib/reqres_rspec.rb b/lib/reqres_rspec.rb index <HASH>..<HASH> 100644 --- a/lib/reqres_rspec.rb +++ b/lib/reqres_rspec.rb @@ -15,19 +15,14 @@ if defined?(RSpec) && ENV['REQRES_RSPEC'] == '1' RSpec.configure do |config| config.after(:each) do |example| - if defined?(Rails) - meta_data ...
fix regression with sinatra rspec
diff --git a/hazelcast/src/test/java/com/hazelcast/cp/internal/CPLiteMemberTest.java b/hazelcast/src/test/java/com/hazelcast/cp/internal/CPLiteMemberTest.java index <HASH>..<HASH> 100644 --- a/hazelcast/src/test/java/com/hazelcast/cp/internal/CPLiteMemberTest.java +++ b/hazelcast/src/test/java/com/hazelcast/cp/internal...
Fix ParallelTest annotation for CPLiteMemberTest
diff --git a/kernel/classes/datatypes/ezuser/ezuser.php b/kernel/classes/datatypes/ezuser/ezuser.php index <HASH>..<HASH> 100644 --- a/kernel/classes/datatypes/ezuser/ezuser.php +++ b/kernel/classes/datatypes/ezuser/ezuser.php @@ -625,18 +625,8 @@ WHERE user_id = '" . $userID . "' AND { $ini = eZINI::inst...
eZUser::hashType() lacks PASSWORD_HASH_MYSQL case Use passwordHashTypeID() instead which has the case, thereby also reducing redundancy.
diff --git a/cmd/syncthing/main.go b/cmd/syncthing/main.go index <HASH>..<HASH> 100644 --- a/cmd/syncthing/main.go +++ b/cmd/syncthing/main.go @@ -712,11 +712,11 @@ func setupUPnP() { l.Warnln("Failed to create UPnP port mapping") } else { l.Infof("Created UPnP port mapping for external port %d on UPnP...
Fix UPnP log spam on networks without UPnP IGDs (see #<I>) We should only run the UPnP port mapping renewal routine if the initial discovery and configuration succeed. This commit applies that logic.
diff --git a/src/SALib/analyze/hdmr.py b/src/SALib/analyze/hdmr.py index <HASH>..<HASH> 100644 --- a/src/SALib/analyze/hdmr.py +++ b/src/SALib/analyze/hdmr.py @@ -352,8 +352,14 @@ def _init(X, Y, settings): def B_spline(X, m, d): - '''Generate cubic B-splines using scipy built-in basis_element - method. Knot...
Added reference to further documentation in docstring
diff --git a/lib/sonos.js b/lib/sonos.js index <HASH>..<HASH> 100644 --- a/lib/sonos.js +++ b/lib/sonos.js @@ -118,7 +118,7 @@ Sonos.prototype.searchMusicLibrary = async function (searchType, searchTerm, req let searches = `${searchTypes[searchType]}${separator}` if (searchTerm && searchTerm !== '') { - sear...
fix: Stop encoding search term for shares. Fixed #<I>
diff --git a/src/Kodeine/Acl/Traits/HasRole.php b/src/Kodeine/Acl/Traits/HasRole.php index <HASH>..<HASH> 100644 --- a/src/Kodeine/Acl/Traits/HasRole.php +++ b/src/Kodeine/Acl/Traits/HasRole.php @@ -1,7 +1,7 @@ <?php namespace Kodeine\Acl\Traits; -trait HasRole +trait HasRoleImplementation { use HasPermissio...
Preserved backwards compatibily for the HasRole trait without branching the codebase.
diff --git a/main.go b/main.go index <HASH>..<HASH> 100644 --- a/main.go +++ b/main.go @@ -274,28 +274,28 @@ func (s *sortedIssues) Less(i, j int) bool { for _, key := range s.order { switch key { case "path": - if l.path < r.path { - return true + if l.path >= r.path { + return false } case "l...
Fix sorting. Smacks forehead.
diff --git a/jquery.maphilight.js b/jquery.maphilight.js index <HASH>..<HASH> 100755 --- a/jquery.maphilight.js +++ b/jquery.maphilight.js @@ -159,7 +159,7 @@ // jquery1.8 + ie7 var $html = $("<div>" + canvas.innerHTML + "</div>"); $html.children('[name=highlighted]').remove(); - canvas.innerHTML = $html...
Bugfix for "unknown runtime error" in IE 7/8
diff --git a/lib/classes/plugin-manager.js b/lib/classes/plugin-manager.js index <HASH>..<HASH> 100644 --- a/lib/classes/plugin-manager.js +++ b/lib/classes/plugin-manager.js @@ -487,10 +487,10 @@ class PluginManager { // Invalid command, can happen only when Framework is used programmatically, // a...
fix: Fix internal unrecognized command error processing
diff --git a/lib/cli.js b/lib/cli.js index <HASH>..<HASH> 100644 --- a/lib/cli.js +++ b/lib/cli.js @@ -14,7 +14,7 @@ module.exports = function (program) { } catch (e) { console.error('Something\'s wrong with the config file.'); - process.exit(1); + return; } lesshint.configure(...
Don't exit (aborts tests), just return
diff --git a/spec/mashify_spec.rb b/spec/mashify_spec.rb index <HASH>..<HASH> 100644 --- a/spec/mashify_spec.rb +++ b/spec/mashify_spec.rb @@ -57,7 +57,7 @@ describe FaradayMiddleware::Mashify do me.class.should == MyMash end - it 'should allow for use of custom Mash subclasses at the instancel evel' d...
Fixes typo in spec description
diff --git a/lib/assets/javascripts/autocomplete-rails-uncompressed.js b/lib/assets/javascripts/autocomplete-rails-uncompressed.js index <HASH>..<HASH> 100644 --- a/lib/assets/javascripts/autocomplete-rails-uncompressed.js +++ b/lib/assets/javascripts/autocomplete-rails-uncompressed.js @@ -81,7 +81,14 @@ ...
* Fixes crowdint/rails3-jquery-autocomplete#<I> Enable setting check boxes when an autocomplete entry is selected
diff --git a/core/src/main/java/jenkins/security/CallableDirectionChecker.java b/core/src/main/java/jenkins/security/CallableDirectionChecker.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/jenkins/security/CallableDirectionChecker.java +++ b/core/src/main/java/jenkins/security/CallableDirectionChecker.java @...
1af<I>e8b7f<I>bca<I>d<I>b<I>e0fd<I>d3cb4e3 incorrectly disabled all logging. When we are allowing all callables through, we want to enable remote class loading (just in case someone is using it legitimately), but continue logging callable issues. Currently there is no remoting flag to allow remote class loading while l...
diff --git a/connection.go b/connection.go index <HASH>..<HASH> 100644 --- a/connection.go +++ b/connection.go @@ -408,7 +408,7 @@ func (cn *connection) writer(keepAliveTimeout time.Duration) { keepAliveTimer := time.NewTimer(keepAliveTimeout) for { cn.mu().Lock() - for cn.outgoingUnbufferedMessages.Len() != 0 ...
Fix crash causing deadlock in connection writer when no messages have been posted yet
diff --git a/spyder/utils/syntaxhighlighters.py b/spyder/utils/syntaxhighlighters.py index <HASH>..<HASH> 100644 --- a/spyder/utils/syntaxhighlighters.py +++ b/spyder/utils/syntaxhighlighters.py @@ -185,7 +185,6 @@ class BaseSH(QSyntaxHighlighter): self.setup_formats(font) self.cell_separators = N...
Editor: Don't request folding when highlighting blocks This is not necessary anymore.
diff --git a/lib/Algorithm/AlgorithmMCF.php b/lib/Algorithm/AlgorithmMCF.php index <HASH>..<HASH> 100644 --- a/lib/Algorithm/AlgorithmMCF.php +++ b/lib/Algorithm/AlgorithmMCF.php @@ -7,7 +7,7 @@ abstract class AlgorithmMCF extends Algorithm { * * @var Graph */ - private $graph; + protected $graph; pub...
change variablen visibility from private to protected
diff --git a/src/Dzangocart/OM/Sale.php b/src/Dzangocart/OM/Sale.php index <HASH>..<HASH> 100644 --- a/src/Dzangocart/OM/Sale.php +++ b/src/Dzangocart/OM/Sale.php @@ -130,6 +130,11 @@ class Sale extends DzangocartObject return sprintf('%s, %s', $this->data['customer']['surname'], $this->data['customer']['given...
getCustomerFullName method added
diff --git a/includes/class-freemius.php b/includes/class-freemius.php index <HASH>..<HASH> 100644 --- a/includes/class-freemius.php +++ b/includes/class-freemius.php @@ -6305,6 +6305,9 @@ 'php_version' => phpversion(), 'language' => get_bloginfo( 'language' ), 'charset' => get_b...
[opt-in] Pass code type and the fact that the module is active on manual opt-in.
diff --git a/upload/catalog/controller/checkout/guest.php b/upload/catalog/controller/checkout/guest.php index <HASH>..<HASH> 100644 --- a/upload/catalog/controller/checkout/guest.php +++ b/upload/catalog/controller/checkout/guest.php @@ -326,7 +326,6 @@ class ControllerCheckoutGuest extends Controller { $this->se...
[guest.php] wrong comment removed a wrong comment
diff --git a/src/you_get/extractors/youtube.py b/src/you_get/extractors/youtube.py index <HASH>..<HASH> 100644 --- a/src/you_get/extractors/youtube.py +++ b/src/you_get/extractors/youtube.py @@ -353,7 +353,10 @@ class YouTube(VideoExtractor): # Prepare caption tracks try: - caption_tracks...
[youtube] fix extraction of caption tracks, close #<I>
diff --git a/lib/togglv8/time_entries.rb b/lib/togglv8/time_entries.rb index <HASH>..<HASH> 100644 --- a/lib/togglv8/time_entries.rb +++ b/lib/togglv8/time_entries.rb @@ -38,7 +38,7 @@ module TogglV8 if !params.has_key?('wid') and !params.has_key?('pid') and !params.has_key?('tid') then raise ArgumentEr...
Make start_time_entry params hash consistent with other methods.
diff --git a/client/allocrunner/taskrunner/task_runner.go b/client/allocrunner/taskrunner/task_runner.go index <HASH>..<HASH> 100644 --- a/client/allocrunner/taskrunner/task_runner.go +++ b/client/allocrunner/taskrunner/task_runner.go @@ -4,6 +4,7 @@ import ( "context" "errors" "fmt" + "strings" "sync" "time"...
Port client portion of #<I> to new taskrunner PR #<I> was merged to master *after* allocrunnerv2 was branched, so the client-specific portions must be ported from master to arv2.
diff --git a/lib/OpenLayers/Control/Panel.js b/lib/OpenLayers/Control/Panel.js index <HASH>..<HASH> 100644 --- a/lib/OpenLayers/Control/Panel.js +++ b/lib/OpenLayers/Control/Panel.js @@ -169,11 +169,11 @@ OpenLayers.Control.Panel = OpenLayers.Class(OpenLayers.Control, { */ draw: function() { Ope...
Check for outsideViewport - we may not have a parentNode yet.
diff --git a/pyemma/_base/serialization/serialization.py b/pyemma/_base/serialization/serialization.py index <HASH>..<HASH> 100644 --- a/pyemma/_base/serialization/serialization.py +++ b/pyemma/_base/serialization/serialization.py @@ -201,9 +201,9 @@ class SerializableMixIn(object): ... self.x = x >>...
disable doctest, because dynamically created classes can not be pickled.
diff --git a/src/lib/subgenerators/generate-swap-contribute/generator.js b/src/lib/subgenerators/generate-swap-contribute/generator.js index <HASH>..<HASH> 100644 --- a/src/lib/subgenerators/generate-swap-contribute/generator.js +++ b/src/lib/subgenerators/generate-swap-contribute/generator.js @@ -23,7 +23,7 @@ export ...
fix typo in path of the contribute template
diff --git a/controllers/auth.php b/controllers/auth.php index <HASH>..<HASH> 100644 --- a/controllers/auth.php +++ b/controllers/auth.php @@ -122,7 +122,7 @@ class FluxBB_Auth_Controller extends Base ); $user = User::create($user_data); - return Redirect::to_action('fluxbb::user@profile', array($user->id)...
Redirect back to index after registering. No point to do otherwise as the user won't be logged in automatically.
diff --git a/resync/sitemap.py b/resync/sitemap.py index <HASH>..<HASH> 100644 --- a/resync/sitemap.py +++ b/resync/sitemap.py @@ -77,13 +77,13 @@ class Sitemap(object): root = Element(root_element, namespaces) if (self.pretty_xml): root.text="\n" - # <rs:md> - if (hasattr(r...
Fix to have rs:ln elements before rs:md to match <I> spec
diff --git a/stream-listener.js b/stream-listener.js index <HASH>..<HASH> 100644 --- a/stream-listener.js +++ b/stream-listener.js @@ -18,7 +18,7 @@ var StreamListener = function() { Events.EventEmitter.call(this); this.subscriptions = {}; - resetStream(); + this.resetStream(); } Util.inherits...
hasSubscriptions() did not exist
diff --git a/src/Utils.php b/src/Utils.php index <HASH>..<HASH> 100644 --- a/src/Utils.php +++ b/src/Utils.php @@ -165,17 +165,7 @@ abstract class Utils */ protected static function saveXML(DOMDocument $dom) { - return preg_replace_callback( - '([\\xF0-\\xF4]...)', - function ($m) - { - $utf8 = $m[0]; -...
Utils: deduplicated code
diff --git a/src/Frozennode/Administrator/AdministratorServiceProvider.php b/src/Frozennode/Administrator/AdministratorServiceProvider.php index <HASH>..<HASH> 100644 --- a/src/Frozennode/Administrator/AdministratorServiceProvider.php +++ b/src/Frozennode/Administrator/AdministratorServiceProvider.php @@ -23,12 +23,6 @...
no need for this config overwrite stuff anymore
diff --git a/test/utils/e2e-utils.js b/test/utils/e2e-utils.js index <HASH>..<HASH> 100644 --- a/test/utils/e2e-utils.js +++ b/test/utils/e2e-utils.js @@ -168,11 +168,6 @@ const freshModeGhostStart = async (options) => { await settingsService.init(); - // Reset the URL service generators - // @TODO: Prob...
Removed unnecessary resetGenerators call no issue - This extra call doesn't seem to be necessary during a fresh boot. It only adds noise in code!
diff --git a/lib/filterlib.php b/lib/filterlib.php index <HASH>..<HASH> 100644 --- a/lib/filterlib.php +++ b/lib/filterlib.php @@ -631,8 +631,7 @@ function filter_get_active_in_context($context) { GROUP BY filter HAVING MAX(f.active * ctx.depth) > -MIN(f.active * ctx.depth) ORD...
filters: MDL-<I> tweak to improve SQL performance
diff --git a/src/java/com/threerings/gwt/ui/Widgets.java b/src/java/com/threerings/gwt/ui/Widgets.java index <HASH>..<HASH> 100644 --- a/src/java/com/threerings/gwt/ui/Widgets.java +++ b/src/java/com/threerings/gwt/ui/Widgets.java @@ -309,9 +309,10 @@ public class Widgets * Creates a PushButton with default(up), ...
Don't require a click handler for our button.
diff --git a/course/format/singleactivity/lib.php b/course/format/singleactivity/lib.php index <HASH>..<HASH> 100644 --- a/course/format/singleactivity/lib.php +++ b/course/format/singleactivity/lib.php @@ -181,7 +181,7 @@ class format_singleactivity extends format_base { ), ); - ...
MDL-<I> format_singleactivity: Make sure available types is not empty
diff --git a/dhooks/client.py b/dhooks/client.py index <HASH>..<HASH> 100644 --- a/dhooks/client.py +++ b/dhooks/client.py @@ -21,7 +21,7 @@ class Webhook: self.avatar_url = options.get('avatar_url') def close(self): - self.session.close() + return self.session.close() def send(self...
Fix session closing for async mode
diff --git a/message.go b/message.go index <HASH>..<HASH> 100644 --- a/message.go +++ b/message.go @@ -22,6 +22,13 @@ const ( // FlagNoAutoStart signals that the message bus should not automatically // start an application when handling this message. FlagNoAutoStart + // FlagAllowInteractiveAuthorization may be s...
Add support for the ALLOW_INTERACTIVE_AUTHORIZATION flag This adds support for the ALLOW_INTERACTIVE_AUTHORIZATION flag in the message parser. It doesn't do anything else with this flag but prevents failures from clients passing this option. Fixes #<I>
diff --git a/DataPanel.py b/DataPanel.py index <HASH>..<HASH> 100644 --- a/DataPanel.py +++ b/DataPanel.py @@ -574,10 +574,8 @@ class DataPanel(Panel.Panel): items_per_row = 4 item_width = int(canvas_bounds.width / items_per_row) - item_rows = int(canvas_bounds.height / item_width...
Removed unused calculation/variable. svn r<I>
diff --git a/callback_query.go b/callback_query.go index <HASH>..<HASH> 100644 --- a/callback_query.go +++ b/callback_query.go @@ -30,7 +30,7 @@ func Query(scope *Scope) { if kind := dest.Kind(); kind == reflect.Slice { isSlice = true destType = dest.Type().Elem() - dest.Set(reflect.Indirect(reflect.New(reflec...
Overwrite initiliazed slices as empty slices
diff --git a/classes/Gems/Default/RespondentExportAction.php b/classes/Gems/Default/RespondentExportAction.php index <HASH>..<HASH> 100644 --- a/classes/Gems/Default/RespondentExportAction.php +++ b/classes/Gems/Default/RespondentExportAction.php @@ -45,8 +45,11 @@ class Gems_Default_RespondentExportAction extends \Gem...
Prevented error by not submitting any respondent number
diff --git a/bokeh/plotting.py b/bokeh/plotting.py index <HASH>..<HASH> 100644 --- a/bokeh/plotting.py +++ b/bokeh/plotting.py @@ -766,6 +766,11 @@ def scatter(*args, **kwargs): markertype = kwargs.get("type", "circle") x_name = names[0] + # TODO this won't be necessary when markers are made uniform + ...
adapt size argmuent to circle scatter
diff --git a/GPy/examples/dimensionality_reduction.py b/GPy/examples/dimensionality_reduction.py index <HASH>..<HASH> 100644 --- a/GPy/examples/dimensionality_reduction.py +++ b/GPy/examples/dimensionality_reduction.py @@ -207,7 +207,7 @@ def bgplvm_simulation(burnin='scg', plot_sim=False, # cstr = 'X_variance' #...
rewritten dim_reduction demo to match new style of getters and setters
diff --git a/rules/order-in-components.js b/rules/order-in-components.js index <HASH>..<HASH> 100644 --- a/rules/order-in-components.js +++ b/rules/order-in-components.js @@ -35,6 +35,10 @@ module.exports = function(context) { return property.key.name === 'actions' && utils.isObjectExpression(property.value); }...
add custom functions to order-in-components rule
diff --git a/lib/Wrapper.js b/lib/Wrapper.js index <HASH>..<HASH> 100644 --- a/lib/Wrapper.js +++ b/lib/Wrapper.js @@ -180,7 +180,7 @@ Wrapper.prototype.getCompiler = function getCompiler(cb) { }.bind(this)); } - if (this.opts.watch && this.opts.hmrRoot) { + if (this.opts.watch && this.opts.hmr && t...
Bug fix for an uncaught exception triggered by certain option combinations
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/LongTaskTimer.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/LongTaskTimer.java index <HASH>..<HASH> 100644 --- a/micrometer-core/src/main/java/io/micrometer/core/instrument/LongTaskTimer.java +++ b/micrometer-core/src/main/jav...
Mark supplier/callable record methods return value as nullable This was missed originally, but the return value is nullable and should be marked as such. Resolves gh-<I>
diff --git a/lib/parse/client.rb b/lib/parse/client.rb index <HASH>..<HASH> 100644 --- a/lib/parse/client.rb +++ b/lib/parse/client.rb @@ -186,10 +186,10 @@ module Parse if body.error? if body.code <= 100 puts "[ParseError] #{body}" - raise Parse::ServerError + raise Parse::...
Return the body in additional exceptions.
diff --git a/stagpy/stagyydata.py b/stagpy/stagyydata.py index <HASH>..<HASH> 100644 --- a/stagpy/stagyydata.py +++ b/stagpy/stagyydata.py @@ -453,7 +453,7 @@ class _EmptyStep(_Step): return False -class _Steps(Mapping): +class _Steps: """Collections of time steps.
_Steps no longer inherits Mapping The mixin methods offered by the Mapping interface aren't relevant to _Steps instances.
diff --git a/boot/logger.js b/boot/logger.js index <HASH>..<HASH> 100644 --- a/boot/logger.js +++ b/boot/logger.js @@ -53,7 +53,7 @@ function errorLogging () { module.exports = function (options) { var logger - var config = { name: 'request', streams: [], level: 'error' } + var config = { name: 'request', strea...
refactor(logger): default level is now at info level, matching bunyan's default
diff --git a/src/Glyph.js b/src/Glyph.js index <HASH>..<HASH> 100644 --- a/src/Glyph.js +++ b/src/Glyph.js @@ -25,8 +25,10 @@ function Glyph( args ) { // each individual glyph must be explicitely made visible this.visible = false; - // required to display the glyph properly in a canvas - this.fillColor = this.str...
Set the stroke color to black by default
diff --git a/src/Model/User.php b/src/Model/User.php index <HASH>..<HASH> 100644 --- a/src/Model/User.php +++ b/src/Model/User.php @@ -1148,7 +1148,7 @@ class User extends Base // If the user's password was updated send them a notification if ($bPasswordUpdated) { - ...
Corrected badly loaded Emailer library
diff --git a/test/unexpectedMitm.js b/test/unexpectedMitm.js index <HASH>..<HASH> 100644 --- a/test/unexpectedMitm.js +++ b/test/unexpectedMitm.js @@ -1780,6 +1780,21 @@ describe('unexpectedMitm', function () { ] ); }); + + it('should output response headers preserving thei...
Add test asserting the preservation of the original casing of headers.
diff --git a/src/Controller/Api/AppController.php b/src/Controller/Api/AppController.php index <HASH>..<HASH> 100644 --- a/src/Controller/Api/AppController.php +++ b/src/Controller/Api/AppController.php @@ -21,16 +21,6 @@ class AppController extends Controller use ControllerTrait; use PanelUtilTrait; - /...
Removing obsolete constants (task #<I>)
diff --git a/src/pycdlib/utils.py b/src/pycdlib/utils.py index <HASH>..<HASH> 100644 --- a/src/pycdlib/utils.py +++ b/src/pycdlib/utils.py @@ -20,10 +20,14 @@ Various utilities for PyIso. import socket +use_sendfile = True try: from sendfile import sendfile except ImportError: - from os import sendfile +...
Allow usage of pycdlib without sendfile installed.
diff --git a/easy_thumbnails/files.py b/easy_thumbnails/files.py index <HASH>..<HASH> 100644 --- a/easy_thumbnails/files.py +++ b/easy_thumbnails/files.py @@ -83,7 +83,11 @@ class ThumbnailFile(ImageFieldFile): """ if not hasattr(self, '_image_cache'): + was_closed = self.closed +...
Ensure the underlying file is open before attempting to read it.
diff --git a/lib/uirusu.rb b/lib/uirusu.rb index <HASH>..<HASH> 100644 --- a/lib/uirusu.rb +++ b/lib/uirusu.rb @@ -31,6 +31,7 @@ module Uirusu VERSION = "0.0.5" CONFIG_FILE = "~/.uirusu" VT_API = "https://www.virustotal.com/vtapi/v2" + RESULT_FIELDS = [ :hash, :scanner, :version, :detected, :result, :md5, :sha1, ...
Maybe this time I'll actually have RESULT_FIELDS in the file.
diff --git a/kubernetes/client/models/v1_projected_volume_source.py b/kubernetes/client/models/v1_projected_volume_source.py index <HASH>..<HASH> 100644 --- a/kubernetes/client/models/v1_projected_volume_source.py +++ b/kubernetes/client/models/v1_projected_volume_source.py @@ -99,9 +99,6 @@ class V1ProjectedVolumeSour...
tolerate null sources on projected volumes See issue <I> Removes the false requirement that sources be a populated list
diff --git a/holoviews/core/spaces.py b/holoviews/core/spaces.py index <HASH>..<HASH> 100644 --- a/holoviews/core/spaces.py +++ b/holoviews/core/spaces.py @@ -808,13 +808,13 @@ class DynamicMap(HoloMap): """ Collation allows collapsing DynamicMaps with invalid nesting hierarchies. This is par...
Updated DynamicMap.collate docstring
diff --git a/gwpy/timeseries/core.py b/gwpy/timeseries/core.py index <HASH>..<HASH> 100644 --- a/gwpy/timeseries/core.py +++ b/gwpy/timeseries/core.py @@ -790,6 +790,14 @@ class TimeSeriesBase(Series): out.name = '{0!s} {1!s} {2!s}'.format(oname, op_, vname) return out + # Quantity overrides ...
gwpy.timeseries: overwrite equality operators astropy overwrites them in a way that breaks the statetimeseries functionality, so we undo that
diff --git a/public_html/profiles/social/modules/contrib/profile/src/ProfileHtmlRouteProvider.php b/public_html/profiles/social/modules/contrib/profile/src/ProfileHtmlRouteProvider.php index <HASH>..<HASH> 100644 --- a/public_html/profiles/social/modules/contrib/profile/src/ProfileHtmlRouteProvider.php +++ b/public_htm...
DS-<I> by ronaldtebrake: faulty patched
diff --git a/src/array/update.js b/src/array/update.js index <HASH>..<HASH> 100644 --- a/src/array/update.js +++ b/src/array/update.js @@ -4,8 +4,12 @@ //------------------------------------------------------------------------------ d3plus.array.update = function( arr , x ) { + if ( !(arr instanceof Array) ) { + ...
array update function now has a catch for undefined arrays
diff --git a/lib/fwapi.js b/lib/fwapi.js index <HASH>..<HASH> 100644 --- a/lib/fwapi.js +++ b/lib/fwapi.js @@ -109,5 +109,29 @@ FWAPI.prototype.deleteRule = function (uuid, params, callback) { }; +/** + * Gets VMs affected by a rule. + * + * @param {String} uuid : the rule UUID. + * @param {Function} callback : of...
FWAPI-<I>: /rules/:uuid/vms endpoint for finding affected VMs