url
stringlengths
50
53
repository_url
stringclasses
1 value
labels_url
stringlengths
64
67
comments_url
stringlengths
59
62
events_url
stringlengths
57
60
html_url
stringlengths
38
43
id
int64
597k
2.65B
node_id
stringlengths
18
32
number
int64
1
6.83k
title
stringlengths
1
296
user
dict
labels
listlengths
0
5
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
4
milestone
dict
comments
int64
0
211
created_at
stringlengths
20
20
updated_at
stringlengths
20
20
closed_at
stringlengths
20
20
author_association
stringclasses
3 values
active_lock_reason
stringclasses
4 values
body
stringlengths
0
65.6k
closed_by
dict
reactions
dict
timeline_url
stringlengths
59
62
performed_via_github_app
null
state_reason
stringclasses
3 values
draft
bool
2 classes
pull_request
dict
is_pull_request
bool
2 classes
issue_comments
listlengths
0
30
https://api.github.com/repos/psf/requests/issues/1328
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1328/labels{/name}
https://api.github.com/repos/psf/requests/issues/1328/comments
https://api.github.com/repos/psf/requests/issues/1328/events
https://github.com/psf/requests/pull/1328
13,671,423
MDExOlB1bGxSZXF1ZXN0NTM4MzYwOQ==
1,328
Session CookieJar fix
{ "avatar_url": "https://avatars.githubusercontent.com/u/187133?v=4", "events_url": "https://api.github.com/users/gazpachoking/events{/privacy}", "followers_url": "https://api.github.com/users/gazpachoking/followers", "following_url": "https://api.github.com/users/gazpachoking/following{/other_user}", "gists_url": "https://api.github.com/users/gazpachoking/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gazpachoking", "id": 187133, "login": "gazpachoking", "node_id": "MDQ6VXNlcjE4NzEzMw==", "organizations_url": "https://api.github.com/users/gazpachoking/orgs", "received_events_url": "https://api.github.com/users/gazpachoking/received_events", "repos_url": "https://api.github.com/users/gazpachoking/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gazpachoking/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gazpachoking/subscriptions", "type": "User", "url": "https://api.github.com/users/gazpachoking", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-04-26T02:40:38Z
2021-09-08T23:00:59Z
2013-04-26T07:02:28Z
CONTRIBUTOR
resolved
Fix for #1324, make any subclass of `cookielib.CookieJar` work as `session.cookies`
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1328/reactions" }
https://api.github.com/repos/psf/requests/issues/1328/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1328.diff", "html_url": "https://github.com/psf/requests/pull/1328", "merged_at": "2013-04-26T07:02:28Z", "patch_url": "https://github.com/psf/requests/pull/1328.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1328" }
true
[ "Whoops, got a small issue to work out still.\n", ":cake: :)\n", "Thanks @gazpachoking you rock! :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1327
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1327/labels{/name}
https://api.github.com/repos/psf/requests/issues/1327/comments
https://api.github.com/repos/psf/requests/issues/1327/events
https://github.com/psf/requests/pull/1327
13,631,059
MDExOlB1bGxSZXF1ZXN0NTM2MzI0Mw==
1,327
Fixes #1320: transport adapters stored in ordered form
{ "avatar_url": "https://avatars.githubusercontent.com/u/55281?v=4", "events_url": "https://api.github.com/users/ambv/events{/privacy}", "followers_url": "https://api.github.com/users/ambv/followers", "following_url": "https://api.github.com/users/ambv/following{/other_user}", "gists_url": "https://api.github.com/users/ambv/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ambv", "id": 55281, "login": "ambv", "node_id": "MDQ6VXNlcjU1Mjgx", "organizations_url": "https://api.github.com/users/ambv/orgs", "received_events_url": "https://api.github.com/users/ambv/received_events", "repos_url": "https://api.github.com/users/ambv/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ambv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ambv/subscriptions", "type": "User", "url": "https://api.github.com/users/ambv", "user_view_type": "public" }
[]
closed
true
null
[]
null
15
2013-04-25T10:01:49Z
2021-09-08T20:01:15Z
2013-05-15T16:43:58Z
CONTRIBUTOR
resolved
As suggested in [this comment](https://github.com/kennethreitz/requests/issues/1320#issuecomment-16992832), I used an OrderedDict. All tests pass on Python 2.6 - 3.3 (provided #1326 is merged for 3.2).
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1327/reactions" }
https://api.github.com/repos/psf/requests/issues/1327/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1327.diff", "html_url": "https://github.com/psf/requests/pull/1327", "merged_at": "2013-05-15T16:43:58Z", "patch_url": "https://github.com/psf/requests/pull/1327.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1327" }
true
[ "There's an easier way to do this with the Ordered Dictionary that doesn't require resorting the keys every time you mount an adapter. \n", "Is there?\n", "After testing it, it is probably not going to be as painless as this.\n\n:+1: Nice work @ambv \n", "Cool. I'm +1 as well. =)\n", "This looks great! I'm ...
https://api.github.com/repos/psf/requests/issues/1326
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1326/labels{/name}
https://api.github.com/repos/psf/requests/issues/1326/comments
https://api.github.com/repos/psf/requests/issues/1326/events
https://github.com/psf/requests/pull/1326
13,626,828
MDExOlB1bGxSZXF1ZXN0NTM2MTA5MA==
1,326
Fixed tests failing on Python 3.2
{ "avatar_url": "https://avatars.githubusercontent.com/u/55281?v=4", "events_url": "https://api.github.com/users/ambv/events{/privacy}", "followers_url": "https://api.github.com/users/ambv/followers", "following_url": "https://api.github.com/users/ambv/following{/other_user}", "gists_url": "https://api.github.com/users/ambv/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ambv", "id": 55281, "login": "ambv", "node_id": "MDQ6VXNlcjU1Mjgx", "organizations_url": "https://api.github.com/users/ambv/orgs", "received_events_url": "https://api.github.com/users/ambv/received_events", "repos_url": "https://api.github.com/users/ambv/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ambv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ambv/subscriptions", "type": "User", "url": "https://api.github.com/users/ambv", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-04-25T07:55:25Z
2021-09-08T20:01:15Z
2013-04-28T23:59:12Z
CONTRIBUTOR
resolved
A test introduced in #1279 used the `u''` literal which is not present on Python 3.2 which made unit tests fail. This PR fixes the bug and introduces a rudimentary "tox.ini" which makes local tests with multiple Python versions trivial: ``` $ pip install tox $ cd requests-sources/ $ tox GLOB sdist-make: setup.py py26 inst-nodeps: .tox/dist/requests-1.2.0.zip py26 runtests: commands[0] ......................................... Ran 41 tests in 24.071s OK py27 inst-nodeps: .tox/dist/requests-1.2.0.zip py27 runtests: commands[0] ......................................... Ran 41 tests in 23.269s OK py32 inst-nodeps: .tox/dist/requests-1.2.0.zip py32 runtests: commands[0] ......................................... Ran 41 tests in 21.836s OK py33 inst-nodeps: .tox/dist/requests-1.2.0.zip py33 runtests: commands[0] ......................................... Ran 41 tests in 22.674s OK ________________ summary ________________ py26: commands succeeded py27: commands succeeded py32: commands succeeded py33: commands succeeded congratulations :) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1326/reactions" }
https://api.github.com/repos/psf/requests/issues/1326/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1326.diff", "html_url": "https://github.com/psf/requests/pull/1326", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1326.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1326" }
true
[ "Nice. =) :+1:\n", "In related news, is the omission of Python 3.2 in `.travis.yml` deliberate? This is the reason the tests show as green while they actually fail under 3.2.\n\n`setup.py` lists this Python version as compatible in the trove classifiers.\n", "Not merging for one reason only: `u''` was added to ...
https://api.github.com/repos/psf/requests/issues/1325
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1325/labels{/name}
https://api.github.com/repos/psf/requests/issues/1325/comments
https://api.github.com/repos/psf/requests/issues/1325/events
https://github.com/psf/requests/issues/1325
13,620,305
MDU6SXNzdWUxMzYyMDMwNQ==
1,325
wtf happened to strict_mode? (POST should remain POST on redirect)
{ "avatar_url": "https://avatars.githubusercontent.com/u/8549?v=4", "events_url": "https://api.github.com/users/jamshid/events{/privacy}", "followers_url": "https://api.github.com/users/jamshid/followers", "following_url": "https://api.github.com/users/jamshid/following{/other_user}", "gists_url": "https://api.github.com/users/jamshid/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jamshid", "id": 8549, "login": "jamshid", "node_id": "MDQ6VXNlcjg1NDk=", "organizations_url": "https://api.github.com/users/jamshid/orgs", "received_events_url": "https://api.github.com/users/jamshid/received_events", "repos_url": "https://api.github.com/users/jamshid/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jamshid/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jamshid/subscriptions", "type": "User", "url": "https://api.github.com/users/jamshid", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2013-04-25T02:04:23Z
2021-09-08T23:10:43Z
2013-04-25T17:36:50Z
NONE
resolved
This is a followup to https://github.com/kennethreitz/requests/issues/996. So I upgraded requests again and again my code broke. I was relying on strict_mode = True. Apparently that config functionality is gone? What's this "despite standards" crap, aren't y'all supposed to be better than that? I'll make a pull request if you'll use it (and once I figure out the new config mechanism). ``` # Do what the browsers do, despite standards... if (resp.status_code in (codes.moved, codes.found) and prepared_request.method == 'POST'): method = 'GET' ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1325/reactions" }
https://api.github.com/repos/psf/requests/issues/1325/timeline
null
completed
null
null
false
[ "First, I'd like to remind you of the general rule for contributing to requests: [Be Cordial or Be On Your Way](http://kennethreitz.org/expressions/be-cordial-or-be-on-your-way). \n\nSecond, you seem to have upgraded from version before 1.0. In 1.0, all configuration was removed, including `strict_mode` so there is...
https://api.github.com/repos/psf/requests/issues/1324
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1324/labels{/name}
https://api.github.com/repos/psf/requests/issues/1324/comments
https://api.github.com/repos/psf/requests/issues/1324/events
https://github.com/psf/requests/issues/1324
13,619,492
MDU6SXNzdWUxMzYxOTQ5Mg==
1,324
Session with CookieJar/LWPCookieJar cause AttributeError
{ "avatar_url": "https://avatars.githubusercontent.com/u/29461?v=4", "events_url": "https://api.github.com/users/falsetru/events{/privacy}", "followers_url": "https://api.github.com/users/falsetru/followers", "following_url": "https://api.github.com/users/falsetru/following{/other_user}", "gists_url": "https://api.github.com/users/falsetru/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/falsetru", "id": 29461, "login": "falsetru", "node_id": "MDQ6VXNlcjI5NDYx", "organizations_url": "https://api.github.com/users/falsetru/orgs", "received_events_url": "https://api.github.com/users/falsetru/received_events", "repos_url": "https://api.github.com/users/falsetru/repos", "site_admin": false, "starred_url": "https://api.github.com/users/falsetru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/falsetru/subscriptions", "type": "User", "url": "https://api.github.com/users/falsetru", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" } ]
closed
true
null
[]
null
3
2013-04-25T01:22:58Z
2021-09-09T04:00:33Z
2013-04-26T10:57:36Z
NONE
resolved
In 1.2.0 , ``` >>> import cookielib >>> import requests >>> jar = cookielib.LWPCookieJar() >>> s = requests.session() >>> s.cookies = jar >>> s.get('http://httpbin.org/') Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 369, in get return self.request('GET', url, **kwargs) File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 297, in request merged_cookies = self.cookies.copy() AttributeError: LWPCookieJar instance has no attribute 'copy' ``` Works in older version. (0.14.2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0)
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1324/reactions" }
https://api.github.com/repos/psf/requests/issues/1324/timeline
null
completed
null
null
false
[ "So the code which causes this break was introduced partially because of Transport Adapters and partially because the re-factor broke the old code. This is a far more elegant way of managing cookies (in my opinion) than we used to use and I'm really not 100% comfortable changing it back. However, this is a major br...
https://api.github.com/repos/psf/requests/issues/1323
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1323/labels{/name}
https://api.github.com/repos/psf/requests/issues/1323/comments
https://api.github.com/repos/psf/requests/issues/1323/events
https://github.com/psf/requests/pull/1323
13,603,310
MDExOlB1bGxSZXF1ZXN0NTM1MDEyMA==
1,323
Actually choose the best adapter match
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-04-24T18:49:22Z
2021-09-08T20:01:16Z
2013-04-25T08:30:44Z
MEMBER
resolved
So it turns out the documentation here has been wrong the whole time! Who knew? This PR follows #1320, and selects the best matching prefix from the dict in a _really stupid_ way. The _right_ way to do this would be to use a trie, but I thought we probably didn't want the cost of a new structure, especially as it's unlikely a user will mount a large number of adapters to any one session. Let me know if you think that's a bad idea, and I'll whip up a quick trie and add it to this PR.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1323/reactions" }
https://api.github.com/repos/psf/requests/issues/1323/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1323.diff", "html_url": "https://github.com/psf/requests/pull/1323", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1323.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1323" }
true
[ "@sigmavirus24: Changes made. =)\n", "Closed based on the discussion in #1320.\n" ]
https://api.github.com/repos/psf/requests/issues/1322
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1322/labels{/name}
https://api.github.com/repos/psf/requests/issues/1322/comments
https://api.github.com/repos/psf/requests/issues/1322/events
https://github.com/psf/requests/issues/1322
13,590,688
MDU6SXNzdWUxMzU5MDY4OA==
1,322
Add note in docs about None not being as data
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "color": "e102d8", "default": false, "description": null, "id": 117745, "name": "Planned", "node_id": "MDU6TGFiZWwxMTc3NDU=", "url": "https://api.github.com/repos/psf/requests/labels/Planned" }, { "color": "0b02e1", "default": false, "description": null, "id": 19127...
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
null
0
2013-04-24T14:35:07Z
2021-09-09T02:11:52Z
2013-07-19T08:19:56Z
CONTRIBUTOR
resolved
See this for more information https://github.com/kennethreitz/requests/commit/751e7a0a66bc9f57923b8ae039bf2f467e106c60#commitcomment-3077752 I'm going to do this in a couple of weeks unless someone beats me to it. I just don't have the time right now.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1322/reactions" }
https://api.github.com/repos/psf/requests/issues/1322/timeline
null
completed
null
null
false
[]
https://api.github.com/repos/psf/requests/issues/1321
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1321/labels{/name}
https://api.github.com/repos/psf/requests/issues/1321/comments
https://api.github.com/repos/psf/requests/issues/1321/events
https://github.com/psf/requests/pull/1321
13,584,315
MDExOlB1bGxSZXF1ZXN0NTM0MTEwMQ==
1,321
Clear preset request headers case-insensitively
{ "avatar_url": "https://avatars.githubusercontent.com/u/368520?v=4", "events_url": "https://api.github.com/users/shaung/events{/privacy}", "followers_url": "https://api.github.com/users/shaung/followers", "following_url": "https://api.github.com/users/shaung/following{/other_user}", "gists_url": "https://api.github.com/users/shaung/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/shaung", "id": 368520, "login": "shaung", "node_id": "MDQ6VXNlcjM2ODUyMA==", "organizations_url": "https://api.github.com/users/shaung/orgs", "received_events_url": "https://api.github.com/users/shaung/received_events", "repos_url": "https://api.github.com/users/shaung/repos", "site_admin": false, "starred_url": "https://api.github.com/users/shaung/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shaung/subscriptions", "type": "User", "url": "https://api.github.com/users/shaung", "user_view_type": "public" }
[]
closed
true
null
[]
null
12
2013-04-24T12:47:13Z
2021-09-08T20:01:14Z
2013-05-21T02:14:55Z
NONE
resolved
While request headers can be removed by setting them to `None`: ``` >>> r = requests.get('http://github.com', headers={'Accept-Encoding': None}) >>> 'Accept-Encoding' in r.request.headers False ``` the following code gives an `KeyError` instead of doing the same job: ``` >>> # Remove preset header >>> r = requests.get('http://github.com', headers={'accept-encoding': None}) Traceback (most recent call last): (...) File "..\requests\sessions.py", line 313, in request headers = merge_kwargs(headers, self.headers) File "..\requests\sessions.py", line 76, in merge_kwargs del kwargs[k] File "..\requests\packages\urllib3\packages\ordered_dict.py", line 59, in __delitem__ dict_delitem(self, key) KeyError: 'accept-encoding' ``` With this patch the key to remove can be specified case-insensitively. ``` >>> r = requests.get('http://github.com', headers={'accept-encoding': None}) >>> 'Accept-Encoding' in r.request.headers False ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1321/reactions" }
https://api.github.com/repos/psf/requests/issues/1321/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1321.diff", "html_url": "https://github.com/psf/requests/pull/1321", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1321.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1321" }
true
[ "Can you fix the test for python 3.3?\n", "@sigmavirus24 Thank you. I will fix it ASAP.\n", "@shaung when you fix it, ping me. GitHub won't tell me when you've added commits so don't be afraid to mention me in the commit message or just add a comment here. :)\n", "@sigmavirus24 Fixed :-)\n", "Well this look...
https://api.github.com/repos/psf/requests/issues/1320
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1320/labels{/name}
https://api.github.com/repos/psf/requests/issues/1320/comments
https://api.github.com/repos/psf/requests/issues/1320/events
https://github.com/psf/requests/issues/1320
13,564,379
MDU6SXNzdWUxMzU2NDM3OQ==
1,320
Transport adapters don't work as advertised
{ "avatar_url": "https://avatars.githubusercontent.com/u/55281?v=4", "events_url": "https://api.github.com/users/ambv/events{/privacy}", "followers_url": "https://api.github.com/users/ambv/followers", "following_url": "https://api.github.com/users/ambv/following{/other_user}", "gists_url": "https://api.github.com/users/ambv/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ambv", "id": 55281, "login": "ambv", "node_id": "MDQ6VXNlcjU1Mjgx", "organizations_url": "https://api.github.com/users/ambv/orgs", "received_events_url": "https://api.github.com/users/ambv/received_events", "repos_url": "https://api.github.com/users/ambv/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ambv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ambv/subscriptions", "type": "User", "url": "https://api.github.com/users/ambv", "user_view_type": "public" }
[]
closed
true
null
[]
null
12
2013-04-24T00:05:19Z
2021-09-09T03:00:39Z
2013-05-15T16:43:59Z
CONTRIBUTOR
resolved
Having: ``` python >>> import requests >>> s = requests.Session() ``` We cannot currently reliably do:: ``` python >>> import requests_testadapter >>> s.mount('http://test.com', requests_testadapter.TestAdapter(b'Mock')) ``` We should, this is documented: http://docs.python-requests.org/en/latest/user/advanced/#transport-adapters Instead, because of [Session.get_adapter()](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L478) the following might or might not work as expected: ``` python >>> s.get('http://test.com') ``` This is because there is already a default adapter for `'http://'` in the form of `requests.adapters.HTTPAdapter`. Depending on the (seemingly random) order of keys in the `s.adapters` dictionary, for some combinations of keys it will work, for others it won't. ## Solutions There are a couple. As usual, a compromise between backwards compatibility, clarity and performance. ### Slow but compatible Change `Session.get_adapter()` so that it sorts the keys every time it fetches an adapter. The advantage is that `session_obj.adapters` is still a vanilla dictionary, if you consider it a public API. ### A custom dictionary type Something like Django's `SortedDict` which would sort the keys on insertion. The advantage is that `session_obj.adapters` is still a mapping and now `Session.get_adapter()` is faster. The disadvantage is the maintenance cost of a custom data structure. Also, mild backwards incompatibility if someone somewhere used the fact that `session_obj.adapters` is exactly of the type `dict` (unlikely, isn't it?). ### A list of tuples Having `Session.mount()` and `Session.get_adapter()` as the public API for adapters, we might just as well implement the sorting while mounting and just maintain `session_obj.adapters` as a list of tuples. The advantage is that it's the fastest solution with no additional maintenance burden. The disadvantage is backwards incompatibility. ## We have to sort... but how exactly? This is another design issue. It appears that sorting first from the longest key to shortest, and then alphabetically (for keys of the same length), is the way. ## You decide What should we do about it? By the way, this test adapter in the example above [is an actual thing](https://pypi.python.org/pypi/requests-testadapter).
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1320/reactions" }
https://api.github.com/repos/psf/requests/issues/1320/timeline
null
completed
null
null
false
[ "> This is because there is already a default adapter for 'http://' in the form of requests.adapters.HTTPAdapter. Depending on the (seemingly random) order of keys in the s.adapters dictionary, for some combinations of keys it will work, for others it won't.\n\n**EDIT** None of the information in this comment is co...
https://api.github.com/repos/psf/requests/issues/1319
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1319/labels{/name}
https://api.github.com/repos/psf/requests/issues/1319/comments
https://api.github.com/repos/psf/requests/issues/1319/events
https://github.com/psf/requests/issues/1319
13,546,825
MDU6SXNzdWUxMzU0NjgyNQ==
1,319
Infinite recursion on 401 response with digest auth
{ "avatar_url": "https://avatars.githubusercontent.com/u/176233?v=4", "events_url": "https://api.github.com/users/jmakeig/events{/privacy}", "followers_url": "https://api.github.com/users/jmakeig/followers", "following_url": "https://api.github.com/users/jmakeig/following{/other_user}", "gists_url": "https://api.github.com/users/jmakeig/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jmakeig", "id": 176233, "login": "jmakeig", "node_id": "MDQ6VXNlcjE3NjIzMw==", "organizations_url": "https://api.github.com/users/jmakeig/orgs", "received_events_url": "https://api.github.com/users/jmakeig/received_events", "repos_url": "https://api.github.com/users/jmakeig/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jmakeig/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jmakeig/subscriptions", "type": "User", "url": "https://api.github.com/users/jmakeig", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2013-04-23T17:30:54Z
2021-09-09T04:00:33Z
2013-04-25T20:21:28Z
NONE
resolved
I’ll try to put together a proper test case, but in the meantime, I’m getting recursion depth errors when authentication fails using digest auth. I’m using v1.1.0 (from pip) with Python 2.7.2 on Mac OS X 10.8.3. My code doesn’t do anything fancy (though I’m an admitted Python noob): ``` class ModulesClient(object): def __init__(self, config): … if self.auth_type == "digest": self.auth = HTTPDigestAuth(self.user, self.password) else: raise Exception("Unsupported auth_type " + self.auth_type) def put(self, uri, body, transaction=None): "Send a file to the remote modules database. URIs are prepended with the root." params = {"uri": self.root + uri, "perm:app-user": "execute"} if transaction is not None: params['txid'] = transaction headers = {} r = requests.put( self.url + "/v1/documents", params=params, headers=headers, auth=self.auth, data=body ) if r.status_code > 299 or r.status_code < 200: raise Exception(r.status_code, r.text) return ("PUT", r.status_code, params['uri']) ``` Everything works fine if authentication succeeds. However, if I give it invalid credentials I get: ``` Traceback (most recent call last): File "/Users/jmakeig/Workspaces/modulesdb/src/local-watcher.py", line 216, in <module> walk(BASEDIR) File "/Users/jmakeig/Workspaces/modulesdb/src/local-watcher.py", line 61, in walk file_path=asb File "/Users/jmakeig/Workspaces/modulesdb/src/modulesclient.py", line 62, in put_file msg = self.put(uri=uri, body=f.read(), transaction=transaction) File "/Users/jmakeig/Workspaces/modulesdb/src/modulesclient.py", line 51, in put data=body File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/api.py", line 98, in put return request('put', url, data=data, **kwargs) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/sessions.py", line 279, in request resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/sessions.py", line 374, in send r = adapter.send(request, **kwargs) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) … _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/auth.py", line 156, in handle_401 _r = r.connection.send(r.request) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 87, in build_response response = Response() File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/models.py", line 457, in __init__ self.cookies = cookiejar_from_dict({}) File "/Users/jmakeig/Library/Python/2.7/lib/python/site-packages/requests/cookies.py", line 368, in cookiejar_from_dict cookiejar = RequestsCookieJar() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/cookielib.py", line 1222, in __init__ self._cookies_lock = _threading.RLock() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 102, in RLock return _RLock(*args, **kwargs) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 107, in __init__ _Verbose.__init__(self, verbose) RuntimeError: maximum recursion depth exceeded in __instancecheck__ ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/176233?v=4", "events_url": "https://api.github.com/users/jmakeig/events{/privacy}", "followers_url": "https://api.github.com/users/jmakeig/followers", "following_url": "https://api.github.com/users/jmakeig/following{/other_user}", "gists_url": "https://api.github.com/users/jmakeig/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jmakeig", "id": 176233, "login": "jmakeig", "node_id": "MDQ6VXNlcjE3NjIzMw==", "organizations_url": "https://api.github.com/users/jmakeig/orgs", "received_events_url": "https://api.github.com/users/jmakeig/received_events", "repos_url": "https://api.github.com/users/jmakeig/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jmakeig/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jmakeig/subscriptions", "type": "User", "url": "https://api.github.com/users/jmakeig", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1319/reactions" }
https://api.github.com/repos/psf/requests/issues/1319/timeline
null
completed
null
null
false
[ "After hacking a local copy of httpbin to constantly ask for Digest Auth, I find I'm unable to reproduce this. What version of Requests are you using?\n", "I’m using v1.1.0 (from pip) with Python 2.7.2 on Mac OS X 10.8.3.\n", "Can you try updating to v1.2.0? I have a feeling we might have fixed this between tho...
https://api.github.com/repos/psf/requests/issues/1318
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1318/labels{/name}
https://api.github.com/repos/psf/requests/issues/1318/comments
https://api.github.com/repos/psf/requests/issues/1318/events
https://github.com/psf/requests/issues/1318
13,512,838
MDU6SXNzdWUxMzUxMjgzOA==
1,318
Issue of sending a HTTPS request use http proxy
{ "avatar_url": "https://avatars.githubusercontent.com/u/1644775?v=4", "events_url": "https://api.github.com/users/howie1013/events{/privacy}", "followers_url": "https://api.github.com/users/howie1013/followers", "following_url": "https://api.github.com/users/howie1013/following{/other_user}", "gists_url": "https://api.github.com/users/howie1013/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/howie1013", "id": 1644775, "login": "howie1013", "node_id": "MDQ6VXNlcjE2NDQ3NzU=", "organizations_url": "https://api.github.com/users/howie1013/orgs", "received_events_url": "https://api.github.com/users/howie1013/received_events", "repos_url": "https://api.github.com/users/howie1013/repos", "site_admin": false, "starred_url": "https://api.github.com/users/howie1013/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/howie1013/subscriptions", "type": "User", "url": "https://api.github.com/users/howie1013", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-04-22T23:47:07Z
2021-09-09T04:00:36Z
2013-04-23T07:21:49Z
NONE
resolved
I try to sending a HTTPS requests by http proxy. the code is like ``` python proxy = 'host:port' proxies = {'https' : proxy} r = requests.post('https://url', proxies=proxies, timeout=10) But it just raises the error below, while I tested it OK when using pycurl. Traceback (most recent call last): File "c:\python32\lib\site-packages\requests-1.2.0-py3.2.egg\requests\packages\urllib3\connectionpool.py", line 421, in urlopen body=body, headers=headers) File "c:\python32\lib\site-packages\requests-1.2.0-py3.2.egg\requests\packages\urllib3\connectionpool.py", line 273, in _make_request conn.request(method, url, **httplib_request_kw) File "c:\python32\lib\http\client.py", line 964, in request self._send_request(method, url, body, headers) File "c:\python32\lib\http\client.py", line 1002, in _send_request self.endheaders(body) File "c:\python32\lib\http\client.py", line 960, in endheaders self._send_output(message_body) File "c:\python32\lib\http\client.py", line 805, in _send_output self.send(msg) File "c:\python32\lib\http\client.py", line 743, in send self.connect() File "c:\python32\lib\site-packages\requests-1.2.0-py3.2.egg\requests\packages\urllib3\connectionpool.py", line 104, in connect ssl_version=resolved_ssl_version) File "c:\python32\lib\site-packages\requests-1.2.0-py3.2.egg\requests\packages\urllib3\util.py", line 329, in ssl_wrap_socket return context.wrap_socket(sock, server_hostname=server_hostname) File "c:\python32\lib\ssl.py", line 181, in wrap_socket _context=self) File "c:\python32\lib\ssl.py", line 268, in __init__ raise x File "c:\python32\lib\ssl.py", line 264, in __init__ self.do_handshake() File "c:\python32\lib\ssl.py", line 443, in do_handshake self._sslobj.do_handshake() socket.timeout: _ssl.c:376: The handshake operation timed out ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1318/reactions" }
https://api.github.com/repos/psf/requests/issues/1318/timeline
null
completed
null
null
false
[ "Unfortunately, Requests is in an awkward place with proxies and HTTPS at the moment. You cannot use the HTTP CONNECT verb, which means the only kind of proxy you can use with HTTPS traffic is an SSL-terminating proxy like mitmproxy.\n\nThe specific bug here is that we're attempting to connect to your proxy and per...
https://api.github.com/repos/psf/requests/issues/1317
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1317/labels{/name}
https://api.github.com/repos/psf/requests/issues/1317/comments
https://api.github.com/repos/psf/requests/issues/1317/events
https://github.com/psf/requests/issues/1317
13,441,667
MDU6SXNzdWUxMzQ0MTY2Nw==
1,317
C Runtime Error R6034 with py2exe
{ "avatar_url": "https://avatars.githubusercontent.com/u/4212668?v=4", "events_url": "https://api.github.com/users/fedeanna/events{/privacy}", "followers_url": "https://api.github.com/users/fedeanna/followers", "following_url": "https://api.github.com/users/fedeanna/following{/other_user}", "gists_url": "https://api.github.com/users/fedeanna/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/fedeanna", "id": 4212668, "login": "fedeanna", "node_id": "MDQ6VXNlcjQyMTI2Njg=", "organizations_url": "https://api.github.com/users/fedeanna/orgs", "received_events_url": "https://api.github.com/users/fedeanna/received_events", "repos_url": "https://api.github.com/users/fedeanna/repos", "site_admin": false, "starred_url": "https://api.github.com/users/fedeanna/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fedeanna/subscriptions", "type": "User", "url": "https://api.github.com/users/fedeanna", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2013-04-20T21:57:03Z
2021-09-09T03:00:29Z
2013-06-08T08:06:19Z
NONE
resolved
I'm working in a Com Server DLL where I use requests to make POST a multipart form along with some XML file. Localy, it works great and with no error. I can call the COM object methods and it returns me what I'm expeting to. Now, when I use py2exe to build a dist version of the app, and try to register the DLL Com Server with regsvr32, I get the following error: "Runtime Error! ... R6034 An application has made an attempt to load the C runtime library incorrecly. ..." Also, I've noticed that if I remove any reference to the requests library in my python code, I don't get this issue (obiously, I've lost the main functionality of the module).
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1317/reactions" }
https://api.github.com/repos/psf/requests/issues/1317/timeline
null
completed
null
null
false
[ "First, do you have the manifest properly set up? I have no experience with py2exe but this [question](http://stackoverflow.com/questions/9793742/py2exe-the-exe-is-created-but-if-you-run-it-you-get-a-runtime-error-r6034) at StackOverflow seems to indicate this can solve your issue.\n\nOn the other hand, what versio...
https://api.github.com/repos/psf/requests/issues/1316
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1316/labels{/name}
https://api.github.com/repos/psf/requests/issues/1316/comments
https://api.github.com/repos/psf/requests/issues/1316/events
https://github.com/psf/requests/pull/1316
13,415,196
MDExOlB1bGxSZXF1ZXN0NTI2Njc5MA==
1,316
MultiDict support for params=, data=, and files=
{ "avatar_url": "https://avatars.githubusercontent.com/u/614430?v=4", "events_url": "https://api.github.com/users/dmckeone/events{/privacy}", "followers_url": "https://api.github.com/users/dmckeone/followers", "following_url": "https://api.github.com/users/dmckeone/following{/other_user}", "gists_url": "https://api.github.com/users/dmckeone/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dmckeone", "id": 614430, "login": "dmckeone", "node_id": "MDQ6VXNlcjYxNDQzMA==", "organizations_url": "https://api.github.com/users/dmckeone/orgs", "received_events_url": "https://api.github.com/users/dmckeone/received_events", "repos_url": "https://api.github.com/users/dmckeone/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dmckeone/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dmckeone/subscriptions", "type": "User", "url": "https://api.github.com/users/dmckeone", "user_view_type": "public" }
[]
closed
true
null
[]
null
26
2013-04-19T18:50:57Z
2021-08-29T00:06:57Z
2013-05-11T19:33:13Z
NONE
resolved
As discussed in [Add MultiDict Support](https://github.com/kennethreitz/requests/issues/1155), this enables `OrderedMultiDict` support in requests by adding the `OrderedMultiDict` and `MultiDict` structures and using them to marshall the `params=`, `data=`, and `files=` keyword arguments.
{ "avatar_url": "https://avatars.githubusercontent.com/u/614430?v=4", "events_url": "https://api.github.com/users/dmckeone/events{/privacy}", "followers_url": "https://api.github.com/users/dmckeone/followers", "following_url": "https://api.github.com/users/dmckeone/following{/other_user}", "gists_url": "https://api.github.com/users/dmckeone/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dmckeone", "id": 614430, "login": "dmckeone", "node_id": "MDQ6VXNlcjYxNDQzMA==", "organizations_url": "https://api.github.com/users/dmckeone/orgs", "received_events_url": "https://api.github.com/users/dmckeone/received_events", "repos_url": "https://api.github.com/users/dmckeone/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dmckeone/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dmckeone/subscriptions", "type": "User", "url": "https://api.github.com/users/dmckeone", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1316/reactions" }
https://api.github.com/repos/psf/requests/issues/1316/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1316.diff", "html_url": "https://github.com/psf/requests/pull/1316", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1316.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1316" }
true
[ "Also, since we're using py.test, use `assert foo > bar`.\n", "I've added a failing test to prevent this from being accepted (for now), because I've realized that this PR doesn't meet all the requirements. (It just got lucky and passed the existing tests)\n", "Hey @dmckeone could you rebase this against curren...
https://api.github.com/repos/psf/requests/issues/1315
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1315/labels{/name}
https://api.github.com/repos/psf/requests/issues/1315/comments
https://api.github.com/repos/psf/requests/issues/1315/events
https://github.com/psf/requests/pull/1315
13,389,150
MDExOlB1bGxSZXF1ZXN0NTI1Mzg0MQ==
1,315
Don't reuse the same prepared request for all redirects
{ "avatar_url": "https://avatars.githubusercontent.com/u/660112?v=4", "events_url": "https://api.github.com/users/reclosedev/events{/privacy}", "followers_url": "https://api.github.com/users/reclosedev/followers", "following_url": "https://api.github.com/users/reclosedev/following{/other_user}", "gists_url": "https://api.github.com/users/reclosedev/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/reclosedev", "id": 660112, "login": "reclosedev", "node_id": "MDQ6VXNlcjY2MDExMg==", "organizations_url": "https://api.github.com/users/reclosedev/orgs", "received_events_url": "https://api.github.com/users/reclosedev/received_events", "repos_url": "https://api.github.com/users/reclosedev/repos", "site_admin": false, "starred_url": "https://api.github.com/users/reclosedev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reclosedev/subscriptions", "type": "User", "url": "https://api.github.com/users/reclosedev", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2013-04-19T06:38:16Z
2021-09-08T20:01:14Z
2013-06-08T10:53:16Z
CONTRIBUTOR
resolved
Updated #1275 Example: ``` python import requests resp = requests.get("http://httpbin.org/redirect/4") for r in resp.history: print("url: {} request.url: {}".format(r.url, r.request.url)) ``` Output: ``` url: http://httpbin.org/redirect/4 request.url: http://httpbin.org/redirect/4 url: http://httpbin.org/redirect/3 request.url: http://httpbin.org/get url: http://httpbin.org/redirect/2 request.url: http://httpbin.org/get url: http://httpbin.org/redirect/1 request.url: http://httpbin.org/get ``` Desired: ``` url: http://httpbin.org/redirect/4 request.url: http://httpbin.org/redirect/4 url: http://httpbin.org/redirect/3 request.url: http://httpbin.org/redirect/3 ... ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1315/reactions" }
https://api.github.com/repos/psf/requests/issues/1315/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1315.diff", "html_url": "https://github.com/psf/requests/pull/1315", "merged_at": "2013-06-08T10:53:16Z", "patch_url": "https://github.com/psf/requests/pull/1315.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1315" }
true
[ ":+1:\n", "Nice! Can you do a rebase so I can merge? \n\nMany thanks :)\n", "@kennethreitz done. \n\nLet me know if something is wrong, I'm doing rebase first time.\n", ":+1: on merging this before a new rebase is necessary\n", "i missed it :(\n", "Did a rebase again.\n", "thanks!\n" ]
https://api.github.com/repos/psf/requests/issues/1314
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1314/labels{/name}
https://api.github.com/repos/psf/requests/issues/1314/comments
https://api.github.com/repos/psf/requests/issues/1314/events
https://github.com/psf/requests/pull/1314
13,380,323
MDExOlB1bGxSZXF1ZXN0NTI1MDM4OA==
1,314
Fix small typo in the Support docs
{ "avatar_url": "https://avatars.githubusercontent.com/u/1574588?v=4", "events_url": "https://api.github.com/users/duailibe/events{/privacy}", "followers_url": "https://api.github.com/users/duailibe/followers", "following_url": "https://api.github.com/users/duailibe/following{/other_user}", "gists_url": "https://api.github.com/users/duailibe/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/duailibe", "id": 1574588, "login": "duailibe", "node_id": "MDQ6VXNlcjE1NzQ1ODg=", "organizations_url": "https://api.github.com/users/duailibe/orgs", "received_events_url": "https://api.github.com/users/duailibe/received_events", "repos_url": "https://api.github.com/users/duailibe/repos", "site_admin": false, "starred_url": "https://api.github.com/users/duailibe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/duailibe/subscriptions", "type": "User", "url": "https://api.github.com/users/duailibe", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-04-18T23:59:45Z
2021-09-08T20:01:13Z
2013-05-01T17:29:41Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1314/reactions" }
https://api.github.com/repos/psf/requests/issues/1314/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1314.diff", "html_url": "https://github.com/psf/requests/pull/1314", "merged_at": "2013-05-01T17:29:40Z", "patch_url": "https://github.com/psf/requests/pull/1314.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1314" }
true
[ ":+1:\n", ":+1:\n", "Thanks!\n" ]
https://api.github.com/repos/psf/requests/issues/1313
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1313/labels{/name}
https://api.github.com/repos/psf/requests/issues/1313/comments
https://api.github.com/repos/psf/requests/issues/1313/events
https://github.com/psf/requests/pull/1313
13,315,304
MDExOlB1bGxSZXF1ZXN0NTIyMDE5Mg==
1,313
Fix max_redirects docs issue #1301
{ "avatar_url": "https://avatars.githubusercontent.com/u/105852?v=4", "events_url": "https://api.github.com/users/iurisilvio/events{/privacy}", "followers_url": "https://api.github.com/users/iurisilvio/followers", "following_url": "https://api.github.com/users/iurisilvio/following{/other_user}", "gists_url": "https://api.github.com/users/iurisilvio/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/iurisilvio", "id": 105852, "login": "iurisilvio", "node_id": "MDQ6VXNlcjEwNTg1Mg==", "organizations_url": "https://api.github.com/users/iurisilvio/orgs", "received_events_url": "https://api.github.com/users/iurisilvio/received_events", "repos_url": "https://api.github.com/users/iurisilvio/repos", "site_admin": false, "starred_url": "https://api.github.com/users/iurisilvio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iurisilvio/subscriptions", "type": "User", "url": "https://api.github.com/users/iurisilvio", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-04-17T19:31:47Z
2021-09-08T20:01:13Z
2013-04-17T19:39:04Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1313/reactions" }
https://api.github.com/repos/psf/requests/issues/1313/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1313.diff", "html_url": "https://github.com/psf/requests/pull/1313", "merged_at": "2013-04-17T19:39:04Z", "patch_url": "https://github.com/psf/requests/pull/1313.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1313" }
true
[ ":+1:\n" ]
https://api.github.com/repos/psf/requests/issues/1312
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1312/labels{/name}
https://api.github.com/repos/psf/requests/issues/1312/comments
https://api.github.com/repos/psf/requests/issues/1312/events
https://github.com/psf/requests/issues/1312
13,176,685
MDU6SXNzdWUxMzE3NjY4NQ==
1,312
AttributeError: 'HTTPResponse' object has no attribute 'fileno'
{ "avatar_url": "https://avatars.githubusercontent.com/u/1676904?v=4", "events_url": "https://api.github.com/users/johnrfrank/events{/privacy}", "followers_url": "https://api.github.com/users/johnrfrank/followers", "following_url": "https://api.github.com/users/johnrfrank/following{/other_user}", "gists_url": "https://api.github.com/users/johnrfrank/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/johnrfrank", "id": 1676904, "login": "johnrfrank", "node_id": "MDQ6VXNlcjE2NzY5MDQ=", "organizations_url": "https://api.github.com/users/johnrfrank/orgs", "received_events_url": "https://api.github.com/users/johnrfrank/received_events", "repos_url": "https://api.github.com/users/johnrfrank/repos", "site_admin": false, "starred_url": "https://api.github.com/users/johnrfrank/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/johnrfrank/subscriptions", "type": "User", "url": "https://api.github.com/users/johnrfrank", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-04-14T18:26:51Z
2021-09-09T04:00:37Z
2013-04-14T18:30:16Z
NONE
resolved
If I pass requests.get(url).raw into something that uses select, like subprocess, then I get AttributeError: 'HTTPResponse' object has no attribute 'fileno' It looks like requests suffers from the problem fixed in urllib2 here: http://bugs.python.org/issue1327971 Is there a simple work around? Thanks!
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1312/reactions" }
https://api.github.com/repos/psf/requests/issues/1312/timeline
null
completed
null
null
false
[ "`HTTPResponse` is actualy from urllib3 in this case, not urllib2. The simple work around would be to check urllib3 for similar issues and if none exist (open or closed) open a new one to see if @shazow likes the idea of making the Responses usable via select. You might be better off (in the interim) looking into t...
https://api.github.com/repos/psf/requests/issues/1311
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1311/labels{/name}
https://api.github.com/repos/psf/requests/issues/1311/comments
https://api.github.com/repos/psf/requests/issues/1311/events
https://github.com/psf/requests/pull/1311
13,158,854
MDExOlB1bGxSZXF1ZXN0NTE0NzE1NQ==
1,311
Change the method when it isn't already GET/HEAD
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-04-13T16:32:50Z
2021-09-08T20:01:13Z
2013-04-13T19:02:29Z
CONTRIBUTOR
resolved
For some reason it was only change the method when a POST was being made. This is almost certainly my fault. Fixes #1303
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1311/reactions" }
https://api.github.com/repos/psf/requests/issues/1311/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1311.diff", "html_url": "https://github.com/psf/requests/pull/1311", "merged_at": "2013-04-13T19:02:29Z", "patch_url": "https://github.com/psf/requests/pull/1311.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1311" }
true
[ "cc @Lukasa for code-review\n", "I pronounce this one line change: REVIEWED. =D\n", "I was going to reflect on this for a while, but someone can always simply do `allow_redirects=False`, so....\n", ":hatched_chick:\n" ]
https://api.github.com/repos/psf/requests/issues/1310
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1310/labels{/name}
https://api.github.com/repos/psf/requests/issues/1310/comments
https://api.github.com/repos/psf/requests/issues/1310/events
https://github.com/psf/requests/pull/1310
13,148,630
MDExOlB1bGxSZXF1ZXN0NTE0NDk0OQ==
1,310
this can solve [Errno 185090050] when built to exe
{ "avatar_url": "https://avatars.githubusercontent.com/u/3929477?v=4", "events_url": "https://api.github.com/users/czjxy881/events{/privacy}", "followers_url": "https://api.github.com/users/czjxy881/followers", "following_url": "https://api.github.com/users/czjxy881/following{/other_user}", "gists_url": "https://api.github.com/users/czjxy881/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/czjxy881", "id": 3929477, "login": "czjxy881", "node_id": "MDQ6VXNlcjM5Mjk0Nzc=", "organizations_url": "https://api.github.com/users/czjxy881/orgs", "received_events_url": "https://api.github.com/users/czjxy881/received_events", "repos_url": "https://api.github.com/users/czjxy881/repos", "site_admin": false, "starred_url": "https://api.github.com/users/czjxy881/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/czjxy881/subscriptions", "type": "User", "url": "https://api.github.com/users/czjxy881", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2013-04-13T04:28:07Z
2021-09-08T20:01:12Z
2013-04-13T19:03:48Z
NONE
resolved
[Errno 185090050] _ssl.c:340: error:0B084002:x509 certificate routines:X509_load _cert_crl_file:system lib
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1310/reactions" }
https://api.github.com/repos/psf/requests/issues/1310/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1310.diff", "html_url": "https://github.com/psf/requests/pull/1310", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1310.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1310" }
true
[ "I'm pretty sure this will break currently existing code, by requiring that cacert.pem be in the working directory. A more complete solution is needed.\n", "just a temporarily solution\n\n2013/4/13 Cory Benfield notifications@github.com\n\n> I'm pretty sure this will break currently existing code, by requiring th...
https://api.github.com/repos/psf/requests/issues/1309
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1309/labels{/name}
https://api.github.com/repos/psf/requests/issues/1309/comments
https://api.github.com/repos/psf/requests/issues/1309/events
https://github.com/psf/requests/pull/1309
13,144,204
MDExOlB1bGxSZXF1ZXN0NTE0MzQ2NA==
1,309
Changed HTTPAdapter to allow max retries to be specified when initializing.
{ "avatar_url": "https://avatars.githubusercontent.com/u/2449?v=4", "events_url": "https://api.github.com/users/toastdriven/events{/privacy}", "followers_url": "https://api.github.com/users/toastdriven/followers", "following_url": "https://api.github.com/users/toastdriven/following{/other_user}", "gists_url": "https://api.github.com/users/toastdriven/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/toastdriven", "id": 2449, "login": "toastdriven", "node_id": "MDQ6VXNlcjI0NDk=", "organizations_url": "https://api.github.com/users/toastdriven/orgs", "received_events_url": "https://api.github.com/users/toastdriven/received_events", "repos_url": "https://api.github.com/users/toastdriven/repos", "site_admin": false, "starred_url": "https://api.github.com/users/toastdriven/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/toastdriven/subscriptions", "type": "User", "url": "https://api.github.com/users/toastdriven", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2013-04-12T23:44:40Z
2021-09-08T23:07:33Z
2013-04-13T19:05:13Z
CONTRIBUTOR
resolved
Currently, to bump the number of `max_retries`, you need to reach into the `HTTPAdapter` instance & manipulate `HTTPAdapter.max_retries`. The other pool options are passed, with sane defaults, to the constructor so it makes sense this should be configurable in the same breath. Passes all tests & updated documentation. Should be 100% backward-compatible, since it's a new parameter that's not being passed anywhere else & is being default to the same constant as before.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1309/reactions" }
https://api.github.com/repos/psf/requests/issues/1309/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1309.diff", "html_url": "https://github.com/psf/requests/pull/1309", "merged_at": "2013-04-13T19:05:13Z", "patch_url": "https://github.com/psf/requests/pull/1309.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1309" }
true
[ "I'm +0 on this. It adds no extra complexity.\n", "I'm also +0 on this.\n", "Well I'm :+1: to this.\n", "There's no toast emoji!\n", "This will have to do...\n\n:bread: :fire:\n", "It's roughly the same. :sake: \n" ]
https://api.github.com/repos/psf/requests/issues/1308
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1308/labels{/name}
https://api.github.com/repos/psf/requests/issues/1308/comments
https://api.github.com/repos/psf/requests/issues/1308/events
https://github.com/psf/requests/issues/1308
13,117,529
MDU6SXNzdWUxMzExNzUyOQ==
1,308
Provide ciphers list for HTTPS requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/4136736?v=4", "events_url": "https://api.github.com/users/damiengermonville/events{/privacy}", "followers_url": "https://api.github.com/users/damiengermonville/followers", "following_url": "https://api.github.com/users/damiengermonville/following{/other_user}", "gists_url": "https://api.github.com/users/damiengermonville/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/damiengermonville", "id": 4136736, "login": "damiengermonville", "node_id": "MDQ6VXNlcjQxMzY3MzY=", "organizations_url": "https://api.github.com/users/damiengermonville/orgs", "received_events_url": "https://api.github.com/users/damiengermonville/received_events", "repos_url": "https://api.github.com/users/damiengermonville/repos", "site_admin": false, "starred_url": "https://api.github.com/users/damiengermonville/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/damiengermonville/subscriptions", "type": "User", "url": "https://api.github.com/users/damiengermonville", "user_view_type": "public" }
[]
closed
true
null
[]
null
19
2013-04-12T12:49:35Z
2021-09-08T04:00:51Z
2013-04-25T18:33:53Z
NONE
resolved
Hi, Since Python 2.7, the ssl module implements a way to provide a list of available ciphers to the SSL object [1]. It would be nice if this feature could be reflected in Requests (and in Urllib3 as well). I know it's not a key feature but some web servers have a Long Handshake intolerance [2] and that makes tools (and Python scripts) based on OpenSSL 1.0.1+ fail at handshake. A workaround is to provide a short list of ciphers instead of all the available ones. I've looked into trough the Requests documentation and googled. I didn't find a way to do it. Maybe there is, if so i would appreciate a bit of help :) Thanks ! [1] http://docs.python.org/2/library/ssl.html?highlight=ssl#ssl.wrap_socket [2] https://github.com/ssllabs/research/wiki/Long-Handshake-Intolerance
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1308/reactions" }
https://api.github.com/repos/psf/requests/issues/1308/timeline
null
completed
null
null
false
[ "Let us pick and choose what version of SSL we use.\n\ncurl https://www.bbva.pt/\nunless\ncurl --sslv3 https://www.bbva.pt/\n", "The accepted way of doing this in Requests is to use the Transport Adapter functionality. You can see an example of doing exactly this [here](https://lukasa.co.uk/2013/01/Choosing_SSL_V...
https://api.github.com/repos/psf/requests/issues/1307
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1307/labels{/name}
https://api.github.com/repos/psf/requests/issues/1307/comments
https://api.github.com/repos/psf/requests/issues/1307/events
https://github.com/psf/requests/issues/1307
13,082,372
MDU6SXNzdWUxMzA4MjM3Mg==
1,307
Python 3 POST multipart/form-data with encode()
{ "avatar_url": "https://avatars.githubusercontent.com/u/3194626?v=4", "events_url": "https://api.github.com/users/yurii-polishchuk/events{/privacy}", "followers_url": "https://api.github.com/users/yurii-polishchuk/followers", "following_url": "https://api.github.com/users/yurii-polishchuk/following{/other_user}", "gists_url": "https://api.github.com/users/yurii-polishchuk/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/yurii-polishchuk", "id": 3194626, "login": "yurii-polishchuk", "node_id": "MDQ6VXNlcjMxOTQ2MjY=", "organizations_url": "https://api.github.com/users/yurii-polishchuk/orgs", "received_events_url": "https://api.github.com/users/yurii-polishchuk/received_events", "repos_url": "https://api.github.com/users/yurii-polishchuk/repos", "site_admin": false, "starred_url": "https://api.github.com/users/yurii-polishchuk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yurii-polishchuk/subscriptions", "type": "User", "url": "https://api.github.com/users/yurii-polishchuk", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2013-04-11T18:37:39Z
2021-09-09T04:00:38Z
2013-04-11T19:07:48Z
NONE
resolved
``` bash server# FreeBSD 8.1-RELEASE server# python3 -V Python 3.3.0 server# python3 -c 'import requests; print(requests.__version__)' 1.2.0 ``` I need to solve one issue by using Python3 and requests. So the main purpose: I have Python script on my PC on the one hand and Web Forum with forms on the other hand. Web forum accept in forms only multipart/form-data, so I POST them to it by: ``` python s = requests.Session() q = s.post('http://siteforum.com/index.php?', headers=headers, data=postdata, files={'':''}) ``` All is ok, data are posted. But the main problem appears when I'm using text encoding in dictionary (cp1251) with .encode() This is my example of the code: ``` python #!/usr/bin/env python3 # -*- coding: utf-8 -*- import requests def main(): s_cp1251 = 'тест'.encode('cp1251') postdata = { "TopicTitle" : s_cp1251, "TopicDesc" : 'тест'.encode('cp1251'), "Post" : 'test' } headers = { 'User-Agent' : 'Mozilla/5.0 (Windows NT 5.1; rv:20.0) Gecko/20100101 Firefox/20.0', 'Accept' : 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8', 'Accept-Language' : 'en-US,en;q=0.5', 'Accept-Encoding' : 'gzip, deflate', 'Connection' : 'keep-alive' } s = requests.Session() q = s.post('http://siteforum.com/index.php?', headers=headers, data=postdata, files={'':''}) print(q.status_code) if __name__ == '__main__': main() ``` 1. 'тест' is a 'test' in cyrillic windows 1251 encoding 2. POST multipart/form-data to Web Forum forms: ` TopicTitle -> b'\xf2\xe5\xf1\xf2' ` ` TopicDesc -> b'\xf2\xe5\xf1\xf2' ` ` Post -> test ` 3. The interesting thing is, that in The Python2 code example works fine, TopicTitle - is 'тест' in Web Forum form, but with Python 3 something like this: b'\xf2\xe5\xf1\xf2' 4. If i send POST form-urlencoded , everything is ok too.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1307/reactions" }
https://api.github.com/repos/psf/requests/issues/1307/timeline
null
completed
null
null
false
[ "Welcome to the exciting world of Python string handling!\n\nThe reason this is happening is that, somewhere in the web stack, someone is calling `str()` on your string. In Python3, calling `str()` on a bytestring returns the exact same thing as calling `repr()`. In this case, that's the byte literal form.\n\nUnfor...
https://api.github.com/repos/psf/requests/issues/1306
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1306/labels{/name}
https://api.github.com/repos/psf/requests/issues/1306/comments
https://api.github.com/repos/psf/requests/issues/1306/events
https://github.com/psf/requests/pull/1306
13,068,895
MDExOlB1bGxSZXF1ZXN0NTEwNzU2Nw==
1,306
Updated NOTICE copyright from 2022 to 2012
{ "avatar_url": "https://avatars.githubusercontent.com/u/675997?v=4", "events_url": "https://api.github.com/users/pombredanne/events{/privacy}", "followers_url": "https://api.github.com/users/pombredanne/followers", "following_url": "https://api.github.com/users/pombredanne/following{/other_user}", "gists_url": "https://api.github.com/users/pombredanne/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pombredanne", "id": 675997, "login": "pombredanne", "node_id": "MDQ6VXNlcjY3NTk5Nw==", "organizations_url": "https://api.github.com/users/pombredanne/orgs", "received_events_url": "https://api.github.com/users/pombredanne/received_events", "repos_url": "https://api.github.com/users/pombredanne/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pombredanne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pombredanne/subscriptions", "type": "User", "url": "https://api.github.com/users/pombredanne", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-04-11T14:09:03Z
2021-09-08T20:01:12Z
2013-04-11T16:04:07Z
CONTRIBUTOR
resolved
Which is likely what you meant, eh?
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1306/reactions" }
https://api.github.com/repos/psf/requests/issues/1306/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1306.diff", "html_url": "https://github.com/psf/requests/pull/1306", "merged_at": "2013-04-11T16:04:07Z", "patch_url": "https://github.com/psf/requests/pull/1306.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1306" }
true
[ "haha, nice catch :)\n" ]
https://api.github.com/repos/psf/requests/issues/1305
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1305/labels{/name}
https://api.github.com/repos/psf/requests/issues/1305/comments
https://api.github.com/repos/psf/requests/issues/1305/events
https://github.com/psf/requests/pull/1305
13,051,459
MDExOlB1bGxSZXF1ZXN0NTA5OTA4MQ==
1,305
Fix Advanced docs Twitter Streaming example
{ "avatar_url": "https://avatars.githubusercontent.com/u/352270?v=4", "events_url": "https://api.github.com/users/michaelhelmick/events{/privacy}", "followers_url": "https://api.github.com/users/michaelhelmick/followers", "following_url": "https://api.github.com/users/michaelhelmick/following{/other_user}", "gists_url": "https://api.github.com/users/michaelhelmick/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/michaelhelmick", "id": 352270, "login": "michaelhelmick", "node_id": "MDQ6VXNlcjM1MjI3MA==", "organizations_url": "https://api.github.com/users/michaelhelmick/orgs", "received_events_url": "https://api.github.com/users/michaelhelmick/received_events", "repos_url": "https://api.github.com/users/michaelhelmick/repos", "site_admin": false, "starred_url": "https://api.github.com/users/michaelhelmick/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/michaelhelmick/subscriptions", "type": "User", "url": "https://api.github.com/users/michaelhelmick", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2013-04-11T03:51:56Z
2021-09-08T20:01:11Z
2013-04-13T19:24:21Z
NONE
resolved
I don't know how you feel about adding the dependency of `requests_oauthlib` in the documentation, but Twitter API v1.1 Streaming now requires OAuth Authentication rather than XAuth. I believe v1 is being blacked out sometime at the beginning of May. (And yeah, I edited this fron the GitHub website... **judge** me :smile:)
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1305/reactions" }
https://api.github.com/repos/psf/requests/issues/1305/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1305.diff", "html_url": "https://github.com/psf/requests/pull/1305", "merged_at": "2013-04-13T19:24:21Z", "patch_url": "https://github.com/psf/requests/pull/1305.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1305" }
true
[ "I think if we're doing this the preamble needs to be updated to explain how to get `requests-oauthlib`.\n", "+1 to this and @Lukasa 's suggestion\n", "@Lukasa Good idea. I'm not too good at copy, I'd probably just confuse the hell out of somebody; so if anybody has suggestions as to what to update the preamble...
https://api.github.com/repos/psf/requests/issues/1304
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1304/labels{/name}
https://api.github.com/repos/psf/requests/issues/1304/comments
https://api.github.com/repos/psf/requests/issues/1304/events
https://github.com/psf/requests/issues/1304
13,040,099
MDU6SXNzdWUxMzA0MDA5OQ==
1,304
Make it possible to attach additional data to request
{ "avatar_url": "https://avatars.githubusercontent.com/u/92239?v=4", "events_url": "https://api.github.com/users/piotr-dobrogost/events{/privacy}", "followers_url": "https://api.github.com/users/piotr-dobrogost/followers", "following_url": "https://api.github.com/users/piotr-dobrogost/following{/other_user}", "gists_url": "https://api.github.com/users/piotr-dobrogost/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/piotr-dobrogost", "id": 92239, "login": "piotr-dobrogost", "node_id": "MDQ6VXNlcjkyMjM5", "organizations_url": "https://api.github.com/users/piotr-dobrogost/orgs", "received_events_url": "https://api.github.com/users/piotr-dobrogost/received_events", "repos_url": "https://api.github.com/users/piotr-dobrogost/repos", "site_admin": false, "starred_url": "https://api.github.com/users/piotr-dobrogost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/piotr-dobrogost/subscriptions", "type": "User", "url": "https://api.github.com/users/piotr-dobrogost", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-04-10T20:46:01Z
2021-09-09T04:00:38Z
2013-04-11T16:04:35Z
NONE
resolved
It would be useful to be able to attach additional data to request by passing these data to `send()` and other api functions like `get()` etc. We can think of these data as a context in which given request was sent so `context` seems like appropriate name for such a parameter. This is especially useful in async scenario but not only. See kennethreitz/grequests/issues/33 The idea is to have request store only these data for later retrieval by user - it wouldn't be used by Requests anywhere in the process of sending request.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1304/reactions" }
https://api.github.com/repos/psf/requests/issues/1304/timeline
null
completed
null
null
false
[ "This isn't necessary, especially given the fact that there's a perfectly good hook in that issue. The parameters to any of the methods (or to `request`) itself should deal solely with the request data sent or the conditions under which it must be sent (`verify`, `allow_redirects`, etc.). With that being the API, c...
https://api.github.com/repos/psf/requests/issues/1303
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1303/labels{/name}
https://api.github.com/repos/psf/requests/issues/1303/comments
https://api.github.com/repos/psf/requests/issues/1303/events
https://github.com/psf/requests/issues/1303
13,025,980
MDU6SXNzdWUxMzAyNTk4MA==
1,303
requests follows a PUT request's 301 and does a PUT request at the end
{ "avatar_url": "https://avatars.githubusercontent.com/u/784229?v=4", "events_url": "https://api.github.com/users/gcbirzan/events{/privacy}", "followers_url": "https://api.github.com/users/gcbirzan/followers", "following_url": "https://api.github.com/users/gcbirzan/following{/other_user}", "gists_url": "https://api.github.com/users/gcbirzan/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gcbirzan", "id": 784229, "login": "gcbirzan", "node_id": "MDQ6VXNlcjc4NDIyOQ==", "organizations_url": "https://api.github.com/users/gcbirzan/orgs", "received_events_url": "https://api.github.com/users/gcbirzan/received_events", "repos_url": "https://api.github.com/users/gcbirzan/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gcbirzan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gcbirzan/subscriptions", "type": "User", "url": "https://api.github.com/users/gcbirzan", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
null
21
2013-04-10T15:55:29Z
2021-09-09T00:10:07Z
2013-04-13T19:02:30Z
NONE
resolved
Not only is that wrong (should behave like POST), but the end request is broken in that it has no content-length and no body.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1303/reactions" }
https://api.github.com/repos/psf/requests/issues/1303/timeline
null
completed
null
null
false
[ "This should only be the case of `allow_redirects` is explicitly set to `True`.\n", "Not only is that false:\n\n```\nIn [4]: requests.put('http://127.0.0.1:5000/', data='a')\nOut[4]: <Response [200]>\n\nIn [5]: requests.put('http://127.0.0.1:5000/', data='a', allow_redirects=False)\nOut[5]: <Response [301]>\n```\...
https://api.github.com/repos/psf/requests/issues/1302
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1302/labels{/name}
https://api.github.com/repos/psf/requests/issues/1302/comments
https://api.github.com/repos/psf/requests/issues/1302/events
https://github.com/psf/requests/pull/1302
13,024,120
MDExOlB1bGxSZXF1ZXN0NTA4NTAyOA==
1,302
Documents the actual logging methods #1297
{ "avatar_url": "https://avatars.githubusercontent.com/u/102495?v=4", "events_url": "https://api.github.com/users/ssbarnea/events{/privacy}", "followers_url": "https://api.github.com/users/ssbarnea/followers", "following_url": "https://api.github.com/users/ssbarnea/following{/other_user}", "gists_url": "https://api.github.com/users/ssbarnea/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ssbarnea", "id": 102495, "login": "ssbarnea", "node_id": "MDQ6VXNlcjEwMjQ5NQ==", "organizations_url": "https://api.github.com/users/ssbarnea/orgs", "received_events_url": "https://api.github.com/users/ssbarnea/received_events", "repos_url": "https://api.github.com/users/ssbarnea/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ssbarnea/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ssbarnea/subscriptions", "type": "User", "url": "https://api.github.com/users/ssbarnea", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-04-10T15:20:30Z
2021-09-09T00:01:25Z
2013-04-14T03:25:47Z
CONTRIBUTOR
resolved
- Documented the logging, requested in #1297 - Added build directory and *.egg to .gitignore - Added sphinx as setup requirement in order to be able to build documentation with `pyhton setup.py build_sphinx` modified: .gitignore modified: docs/api.rst modified: setup.py
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1302/reactions" }
https://api.github.com/repos/psf/requests/issues/1302/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1302.diff", "html_url": "https://github.com/psf/requests/pull/1302", "merged_at": "2013-04-14T03:25:47Z", "patch_url": "https://github.com/psf/requests/pull/1302.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1302" }
true
[ "**Once fixed**, I'm :+1: on this. I was going to work on the docs (including this), this weekend anyway, but this is one less thing I have to do. :)\n", "Thanks!\n" ]
https://api.github.com/repos/psf/requests/issues/1301
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1301/labels{/name}
https://api.github.com/repos/psf/requests/issues/1301/comments
https://api.github.com/repos/psf/requests/issues/1301/events
https://github.com/psf/requests/issues/1301
13,021,597
MDU6SXNzdWUxMzAyMTU5Nw==
1,301
Unexpected behaviour with max_redirects
{ "avatar_url": "https://avatars.githubusercontent.com/u/105852?v=4", "events_url": "https://api.github.com/users/iurisilvio/events{/privacy}", "followers_url": "https://api.github.com/users/iurisilvio/followers", "following_url": "https://api.github.com/users/iurisilvio/following{/other_user}", "gists_url": "https://api.github.com/users/iurisilvio/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/iurisilvio", "id": 105852, "login": "iurisilvio", "node_id": "MDQ6VXNlcjEwNTg1Mg==", "organizations_url": "https://api.github.com/users/iurisilvio/orgs", "received_events_url": "https://api.github.com/users/iurisilvio/received_events", "repos_url": "https://api.github.com/users/iurisilvio/repos", "site_admin": false, "starred_url": "https://api.github.com/users/iurisilvio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iurisilvio/subscriptions", "type": "User", "url": "https://api.github.com/users/iurisilvio", "user_view_type": "public" }
[ { "color": "e102d8", "default": false, "description": null, "id": 117745, "name": "Planned", "node_id": "MDU6TGFiZWwxMTc3NDU=", "url": "https://api.github.com/repos/psf/requests/labels/Planned" }, { "color": "0b02e1", "default": false, "description": null, "id": 19127...
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
null
2
2013-04-10T14:30:56Z
2021-09-09T04:00:34Z
2013-04-25T18:34:16Z
CONTRIBUTOR
resolved
It is probably a documentation issue. Based on docs: > max_redirects: Maximum number of redirects to follow. I expected it just return a response with a 30x status when `max_redirects` is reached, but it raises a `requests.exceptions.TooManyRedirects`.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1301/reactions" }
https://api.github.com/repos/psf/requests/issues/1301/timeline
null
completed
null
null
false
[ "You're right, this is an issue with the docs.\n", "Resolved by #1313.\n" ]
https://api.github.com/repos/psf/requests/issues/1300
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1300/labels{/name}
https://api.github.com/repos/psf/requests/issues/1300/comments
https://api.github.com/repos/psf/requests/issues/1300/events
https://github.com/psf/requests/issues/1300
13,021,414
MDU6SXNzdWUxMzAyMTQxNA==
1,300
Set max_redirects per request
{ "avatar_url": "https://avatars.githubusercontent.com/u/105852?v=4", "events_url": "https://api.github.com/users/iurisilvio/events{/privacy}", "followers_url": "https://api.github.com/users/iurisilvio/followers", "following_url": "https://api.github.com/users/iurisilvio/following{/other_user}", "gists_url": "https://api.github.com/users/iurisilvio/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/iurisilvio", "id": 105852, "login": "iurisilvio", "node_id": "MDQ6VXNlcjEwNTg1Mg==", "organizations_url": "https://api.github.com/users/iurisilvio/orgs", "received_events_url": "https://api.github.com/users/iurisilvio/received_events", "repos_url": "https://api.github.com/users/iurisilvio/repos", "site_admin": false, "starred_url": "https://api.github.com/users/iurisilvio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iurisilvio/subscriptions", "type": "User", "url": "https://api.github.com/users/iurisilvio", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2013-04-10T14:27:41Z
2021-09-09T04:00:39Z
2013-04-10T14:32:30Z
CONTRIBUTOR
resolved
I expected this code works: ``` python >>> import requests >>> requests.__version__ '1.2.0' >>> requests.get('http://www.google.com', max_redirects=1) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "C:\Python27\lib\site-packages\requests\api.py", line 55, in get return request('get', url, **kwargs) File "C:\Python27\lib\site-packages\requests\api.py", line 44, in request return session.request(method=method, url=url, **kwargs) TypeError: request() got an unexpected keyword argument 'max_redirects' ``` To use `max_redirects`, I have to do it: ``` python >>> session = requests.Session() >>> session.max_redirects = 1 >>> session.get('http://www.google.com') <Response [200]> ``` It is not the obvious way.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1300/reactions" }
https://api.github.com/repos/psf/requests/issues/1300/timeline
null
completed
null
null
false
[ "Closing in deference to #1301 \n", "@sigmavirus24 this issue is different than #1301. Here, I just expected the `max_redirects` work per request, because it is the obvious way. I don't want to create a `requests.Session` to be able to set `max_redirects`.\n", "I think it's important to note that 'obvious' vari...
https://api.github.com/repos/psf/requests/issues/1299
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1299/labels{/name}
https://api.github.com/repos/psf/requests/issues/1299/comments
https://api.github.com/repos/psf/requests/issues/1299/events
https://github.com/psf/requests/pull/1299
13,005,217
MDExOlB1bGxSZXF1ZXN0NTA3NTI4MQ==
1,299
Use streaming decompression feature of urllib3.
{ "avatar_url": "https://avatars.githubusercontent.com/u/238652?v=4", "events_url": "https://api.github.com/users/schlamar/events{/privacy}", "followers_url": "https://api.github.com/users/schlamar/followers", "following_url": "https://api.github.com/users/schlamar/following{/other_user}", "gists_url": "https://api.github.com/users/schlamar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/schlamar", "id": 238652, "login": "schlamar", "node_id": "MDQ6VXNlcjIzODY1Mg==", "organizations_url": "https://api.github.com/users/schlamar/orgs", "received_events_url": "https://api.github.com/users/schlamar/received_events", "repos_url": "https://api.github.com/users/schlamar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/schlamar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/schlamar/subscriptions", "type": "User", "url": "https://api.github.com/users/schlamar", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-04-10T06:13:18Z
2021-09-08T23:01:12Z
2013-04-14T03:27:47Z
CONTRIBUTOR
resolved
This will fix #1249. Additionally, the urllib3 upgrade offers a reasonable way to deal with #465, see [this comment](https://github.com/kennethreitz/requests/issues/465#issuecomment-15106811).
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1299/reactions" }
https://api.github.com/repos/psf/requests/issues/1299/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1299.diff", "html_url": "https://github.com/psf/requests/pull/1299", "merged_at": "2013-04-14T03:27:47Z", "patch_url": "https://github.com/psf/requests/pull/1299.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1299" }
true
[ "Nice work!\n", ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1298
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1298/labels{/name}
https://api.github.com/repos/psf/requests/issues/1298/comments
https://api.github.com/repos/psf/requests/issues/1298/events
https://github.com/psf/requests/pull/1298
12,989,432
MDExOlB1bGxSZXF1ZXN0NTA2NjkyMw==
1,298
Transport Adapter Docs
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-04-09T20:03:03Z
2021-09-08T22:01:16Z
2013-04-09T20:17:20Z
MEMBER
resolved
A documentation Pull Request, from @Lukasa? How unexpected! :grin: There comes a point where I should stop writing blog articles about Requests-y things and start actually adding some documentation to Requests. This will add the Transport Adapter to the API documentation and a description of them to the Advanced docs.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1298/reactions" }
https://api.github.com/repos/psf/requests/issues/1298/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1298.diff", "html_url": "https://github.com/psf/requests/pull/1298", "merged_at": "2013-04-09T20:17:20Z", "patch_url": "https://github.com/psf/requests/pull/1298.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1298" }
true
[ ":space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: :space_invader: \n\n:video_game:\n" ]
https://api.github.com/repos/psf/requests/issues/1297
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1297/labels{/name}
https://api.github.com/repos/psf/requests/issues/1297/comments
https://api.github.com/repos/psf/requests/issues/1297/events
https://github.com/psf/requests/issues/1297
12,984,070
MDU6SXNzdWUxMjk4NDA3MA==
1,297
requests logging is not documented, incomplete and works unexpectedly
{ "avatar_url": "https://avatars.githubusercontent.com/u/102495?v=4", "events_url": "https://api.github.com/users/ssbarnea/events{/privacy}", "followers_url": "https://api.github.com/users/ssbarnea/followers", "following_url": "https://api.github.com/users/ssbarnea/following{/other_user}", "gists_url": "https://api.github.com/users/ssbarnea/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ssbarnea", "id": 102495, "login": "ssbarnea", "node_id": "MDQ6VXNlcjEwMjQ5NQ==", "organizations_url": "https://api.github.com/users/ssbarnea/orgs", "received_events_url": "https://api.github.com/users/ssbarnea/received_events", "repos_url": "https://api.github.com/users/ssbarnea/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ssbarnea/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ssbarnea/subscriptions", "type": "User", "url": "https://api.github.com/users/ssbarnea", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
null
10
2013-04-09T18:06:04Z
2021-09-01T00:11:38Z
2013-04-14T16:54:48Z
CONTRIBUTOR
resolved
Currently logging in `requests` library is not properly documented. The _API Changes_ section of the documentation reminds about the removal of the config parameter but contains no code. See http://docs.python-requests.org/en/latest/api/?highlight=logging ``` python import requests import logging # these two lines enable debugging at httplib level (requests->urllib3->httplib) # you will see the REQUEST, including HEADERS and DATA, and RESPONSE with HEADERS but without DATA. # the only thing missing will be the response.body which is not logged. import httplib httplib.HTTPConnection.debuglevel = 1 logging.basicConfig() # you need to initialize logging, otherwise you will not see anything from requests logging.getLogger().setLevel(logging.DEBUG) requests_log = logging.getLogger("requests") requests_log.setLevel(logging.DEBUG) requests_log.propagate = True requests.get('http://httpbin.org/headers') ``` So this means there are a few things to do: #1 add the above piece of code to the documentation (including the API changes section) #2 provide proper response on few stackoverflow questions related to requests logging #3 find a way to allow extensive logging (logging BODY too)
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1297/reactions" }
https://api.github.com/repos/psf/requests/issues/1297/timeline
null
completed
null
null
false
[ "requests does no logging of its own. All logging actually done is done by urllib3 and can be set up similar to your example:\n\n``` python\nimport requests\nimport logging\n\nlogging.getLogger().setLevel(logging.DEBUG)\nrequests_log = logging.getLogger(\"requests.packages.urllib3\")\nrequests_log.setLevel(logging....
https://api.github.com/repos/psf/requests/issues/1296
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1296/labels{/name}
https://api.github.com/repos/psf/requests/issues/1296/comments
https://api.github.com/repos/psf/requests/issues/1296/events
https://github.com/psf/requests/pull/1296
12,930,566
MDExOlB1bGxSZXF1ZXN0NTAzNjU1Mw==
1,296
Add helpful error message to r.json() method
{ "avatar_url": "https://avatars.githubusercontent.com/u/719590?v=4", "events_url": "https://api.github.com/users/sursh/events{/privacy}", "followers_url": "https://api.github.com/users/sursh/followers", "following_url": "https://api.github.com/users/sursh/following{/other_user}", "gists_url": "https://api.github.com/users/sursh/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sursh", "id": 719590, "login": "sursh", "node_id": "MDQ6VXNlcjcxOTU5MA==", "organizations_url": "https://api.github.com/users/sursh/orgs", "received_events_url": "https://api.github.com/users/sursh/received_events", "repos_url": "https://api.github.com/users/sursh/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sursh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sursh/subscriptions", "type": "User", "url": "https://api.github.com/users/sursh", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2013-04-08T16:02:49Z
2021-09-08T20:01:11Z
2013-04-08T18:01:37Z
CONTRIBUTOR
resolved
It took me a while to figure out that this error was coming from the newest version of Requests rather than somewhere in Django. This updates the documentation to be more control-F friendly.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1296/reactions" }
https://api.github.com/repos/psf/requests/issues/1296/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1296.diff", "html_url": "https://github.com/psf/requests/pull/1296", "merged_at": "2013-04-08T18:01:37Z", "patch_url": "https://github.com/psf/requests/pull/1296.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1296" }
true
[ "+1. I'm always in favour of better documentation.\n", "I'm not sure this is the only error the json module raises but I'm generally +1 for this.\n", "Good point @sigmavirus24. Fixed my wording.\n", "Thanks very much. :+1: I was going to look to see if `json.decode` raised more than a ValueError but I'm too b...
https://api.github.com/repos/psf/requests/issues/1295
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1295/labels{/name}
https://api.github.com/repos/psf/requests/issues/1295/comments
https://api.github.com/repos/psf/requests/issues/1295/events
https://github.com/psf/requests/pull/1295
12,879,175
MDExOlB1bGxSZXF1ZXN0NTAxNjYyNw==
1,295
Fix #1293
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-04-06T15:33:15Z
2021-09-08T20:01:11Z
2013-04-07T00:27:23Z
CONTRIBUTOR
resolved
Technically missing a netloc isn't the same as missing a scheme even if it is more convenient the other way. :-P
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1295/reactions" }
https://api.github.com/repos/psf/requests/issues/1295/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1295.diff", "html_url": "https://github.com/psf/requests/pull/1295", "merged_at": "2013-04-07T00:27:23Z", "patch_url": "https://github.com/psf/requests/pull/1295.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1295" }
true
[ "+1\n" ]
https://api.github.com/repos/psf/requests/issues/1294
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1294/labels{/name}
https://api.github.com/repos/psf/requests/issues/1294/comments
https://api.github.com/repos/psf/requests/issues/1294/events
https://github.com/psf/requests/issues/1294
12,878,336
MDU6SXNzdWUxMjg3ODMzNg==
1,294
Getting errno from an SSLError
{ "avatar_url": "https://avatars.githubusercontent.com/u/1440143?v=4", "events_url": "https://api.github.com/users/GP89/events{/privacy}", "followers_url": "https://api.github.com/users/GP89/followers", "following_url": "https://api.github.com/users/GP89/following{/other_user}", "gists_url": "https://api.github.com/users/GP89/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/GP89", "id": 1440143, "login": "GP89", "node_id": "MDQ6VXNlcjE0NDAxNDM=", "organizations_url": "https://api.github.com/users/GP89/orgs", "received_events_url": "https://api.github.com/users/GP89/received_events", "repos_url": "https://api.github.com/users/GP89/repos", "site_admin": false, "starred_url": "https://api.github.com/users/GP89/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GP89/subscriptions", "type": "User", "url": "https://api.github.com/users/GP89", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "0b02e1", "default": false, "description": null...
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
null
29
2013-04-06T14:20:26Z
2021-09-08T23:06:05Z
2015-01-19T09:26:36Z
NONE
resolved
I noticed a couple of issues trying to get the `errno` attribute from an `SSLError`. Firstly the `errno` attribute is accessed via `err.message.message.errno`, which is a little annoying but more annoyingly, for `ConnectionError` the attribute is accessed via `err.message.reason.errno` which is a problem as an except clause catching `ConnectionErrors` will also catch `SSLError` as it's a subclass, so they should really have the same interface. Another issue I noticed is that the `errno` attribute for the an `SSLError` instance returns `None`
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1294/reactions" }
https://api.github.com/repos/psf/requests/issues/1294/timeline
null
completed
null
null
false
[ "This seems reasonable. I'll take a crack at standardizing the exceptions tonight.\n", "Thanks! The bigger issue for me is that the `errno` attribute seems to get lost somehow in the wrapped exception, the differing interface is just a bit of a gotcha.\n", "Yeah. I just figure if we standardize it a bit, I'll f...
https://api.github.com/repos/psf/requests/issues/1293
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1293/labels{/name}
https://api.github.com/repos/psf/requests/issues/1293/comments
https://api.github.com/repos/psf/requests/issues/1293/events
https://github.com/psf/requests/issues/1293
12,872,033
MDU6SXNzdWUxMjg3MjAzMw==
1,293
MissingSchema error raised when schema present
{ "avatar_url": "https://avatars.githubusercontent.com/u/187133?v=4", "events_url": "https://api.github.com/users/gazpachoking/events{/privacy}", "followers_url": "https://api.github.com/users/gazpachoking/followers", "following_url": "https://api.github.com/users/gazpachoking/following{/other_user}", "gists_url": "https://api.github.com/users/gazpachoking/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gazpachoking", "id": 187133, "login": "gazpachoking", "node_id": "MDQ6VXNlcjE4NzEzMw==", "organizations_url": "https://api.github.com/users/gazpachoking/orgs", "received_events_url": "https://api.github.com/users/gazpachoking/received_events", "repos_url": "https://api.github.com/users/gazpachoking/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gazpachoking/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gazpachoking/subscriptions", "type": "User", "url": "https://api.github.com/users/gazpachoking", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
null
1
2013-04-06T04:26:46Z
2021-09-09T04:00:39Z
2013-04-07T00:27:24Z
CONTRIBUTOR
resolved
After [this](https://github.com/kennethreitz/requests/commit/ca85b4ec6ce2428891d2e1ae72dad2b873c87bbe) commit, a `MissingSchema` error can be raised when schema is present, but network location isn't. Seems this should be handled another way.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1293/reactions" }
https://api.github.com/repos/psf/requests/issues/1293/timeline
null
completed
null
null
false
[ "Yeah, I guess `InvalidURL` would be better in this case. Sorry about that.\n" ]
https://api.github.com/repos/psf/requests/issues/1292
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1292/labels{/name}
https://api.github.com/repos/psf/requests/issues/1292/comments
https://api.github.com/repos/psf/requests/issues/1292/events
https://github.com/psf/requests/issues/1292
12,850,034
MDU6SXNzdWUxMjg1MDAzNA==
1,292
HTTP Headers that contains underscore (_) are not transferred to server
{ "avatar_url": "https://avatars.githubusercontent.com/u/3738281?v=4", "events_url": "https://api.github.com/users/spil-bahadir/events{/privacy}", "followers_url": "https://api.github.com/users/spil-bahadir/followers", "following_url": "https://api.github.com/users/spil-bahadir/following{/other_user}", "gists_url": "https://api.github.com/users/spil-bahadir/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/spil-bahadir", "id": 3738281, "login": "spil-bahadir", "node_id": "MDQ6VXNlcjM3MzgyODE=", "organizations_url": "https://api.github.com/users/spil-bahadir/orgs", "received_events_url": "https://api.github.com/users/spil-bahadir/received_events", "repos_url": "https://api.github.com/users/spil-bahadir/repos", "site_admin": false, "starred_url": "https://api.github.com/users/spil-bahadir/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/spil-bahadir/subscriptions", "type": "User", "url": "https://api.github.com/users/spil-bahadir", "user_view_type": "public" }
[]
closed
true
null
[]
null
13
2013-04-05T15:17:17Z
2016-07-15T16:52:17Z
2013-04-05T15:27:46Z
NONE
null
The following could be an HTTP specification, but I'm not sure. I have netcat opened, submitting the following request via httpie[https://github.com/jkbr/httpie] ``` bash http POST http://cas/api/v1/users/ X_SPIL_AUTH_TOKEN:test ``` results as the following ``` POST /api/v1/users/ HTTP/1.0 Host: cas X-Real-IP: 127.0.0.1 Connection: close Content-Length: 0 User-Agent: HTTPie/0.4.1 Accept: */* Accept-Encoding: gzip, deflate, compress ``` and submitting the following request ``` bash http POST http://cas/api/v1/users/ X-SPIL-AUTH-TOKEN:test ``` ends up with the following result ``` POST /api/v1/users/ HTTP/1.0 Host: cas X-Real-IP: 127.0.0.1 Connection: close Content-Length: 0 User-Agent: HTTPie/0.4.1 Accept-Encoding: gzip, deflate, compress Accept: */* X-SPIL-AUTH-TOKEN: test ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1292/reactions" }
https://api.github.com/repos/psf/requests/issues/1292/timeline
null
completed
null
null
false
[ "Here's the [spec](http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2). In case you were unsure, I'm 90% sure (assuming my memory still works... probably need to run an fsck some time soon) that HT is short-hand for hyphen (or hyphen text). In other words, underscores are not allowed in header field names...
https://api.github.com/repos/psf/requests/issues/1291
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1291/labels{/name}
https://api.github.com/repos/psf/requests/issues/1291/comments
https://api.github.com/repos/psf/requests/issues/1291/events
https://github.com/psf/requests/pull/1291
12,831,163
MDExOlB1bGxSZXF1ZXN0NDk5MzU3OQ==
1,291
Don't set all session cookies on response.cookies
{ "avatar_url": "https://avatars.githubusercontent.com/u/187133?v=4", "events_url": "https://api.github.com/users/gazpachoking/events{/privacy}", "followers_url": "https://api.github.com/users/gazpachoking/followers", "following_url": "https://api.github.com/users/gazpachoking/following{/other_user}", "gists_url": "https://api.github.com/users/gazpachoking/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gazpachoking", "id": 187133, "login": "gazpachoking", "node_id": "MDQ6VXNlcjE4NzEzMw==", "organizations_url": "https://api.github.com/users/gazpachoking/orgs", "received_events_url": "https://api.github.com/users/gazpachoking/received_events", "repos_url": "https://api.github.com/users/gazpachoking/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gazpachoking/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gazpachoking/subscriptions", "type": "User", "url": "https://api.github.com/users/gazpachoking", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-04-05T03:37:35Z
2021-09-08T20:01:10Z
2013-04-05T03:41:52Z
CONTRIBUTOR
resolved
This prevents all the session cookies from being set in response.cookies. I believe the old behavior was a workaround due to how session cookies were being updated before #1290 After this, response.cookies will match up with the set-cookies header for the response. As discussed here: https://botbot.me/freenode/python-requests/msg/2568299/
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1291/reactions" }
https://api.github.com/repos/psf/requests/issues/1291/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1291.diff", "html_url": "https://github.com/psf/requests/pull/1291", "merged_at": "2013-04-05T03:41:52Z", "patch_url": "https://github.com/psf/requests/pull/1291.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1291" }
true
[ ":sparkles: :cookie: :sparkles:\n", "Mmm, cookies. :tongue: \n", ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1290
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1290/labels{/name}
https://api.github.com/repos/psf/requests/issues/1290/comments
https://api.github.com/repos/psf/requests/issues/1290/events
https://github.com/psf/requests/pull/1290
12,829,863
MDExOlB1bGxSZXF1ZXN0NDk5Mjk4Ng==
1,290
fix #1287: Make sure expired cookies get removed from session.cookies
{ "avatar_url": "https://avatars.githubusercontent.com/u/187133?v=4", "events_url": "https://api.github.com/users/gazpachoking/events{/privacy}", "followers_url": "https://api.github.com/users/gazpachoking/followers", "following_url": "https://api.github.com/users/gazpachoking/following{/other_user}", "gists_url": "https://api.github.com/users/gazpachoking/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gazpachoking", "id": 187133, "login": "gazpachoking", "node_id": "MDQ6VXNlcjE4NzEzMw==", "organizations_url": "https://api.github.com/users/gazpachoking/orgs", "received_events_url": "https://api.github.com/users/gazpachoking/received_events", "repos_url": "https://api.github.com/users/gazpachoking/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gazpachoking/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gazpachoking/subscriptions", "type": "User", "url": "https://api.github.com/users/gazpachoking", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-04-05T02:19:15Z
2021-09-08T20:01:10Z
2013-04-05T03:22:38Z
CONTRIBUTOR
resolved
This changes sessions to update their cookiejar directly from the headers rather than the cookiejar attached to responses. This way cookies that the server marks as expired are removed from the session cookiejar.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1290/reactions" }
https://api.github.com/repos/psf/requests/issues/1290/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1290.diff", "html_url": "https://github.com/psf/requests/pull/1290", "merged_at": "2013-04-05T03:22:38Z", "patch_url": "https://github.com/psf/requests/pull/1290.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1290" }
true
[ "This is absolutely fantastic and I can confirm it works with [this](https://gist.github.com/sigmavirus24/5314553).\n", "And in case it wasn't obvious, +1000\n", ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1289
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1289/labels{/name}
https://api.github.com/repos/psf/requests/issues/1289/comments
https://api.github.com/repos/psf/requests/issues/1289/events
https://github.com/psf/requests/issues/1289
12,805,686
MDU6SXNzdWUxMjgwNTY4Ng==
1,289
Python 3.3 requests issue
{ "avatar_url": "https://avatars.githubusercontent.com/u/3253989?v=4", "events_url": "https://api.github.com/users/echohack/events{/privacy}", "followers_url": "https://api.github.com/users/echohack/followers", "following_url": "https://api.github.com/users/echohack/following{/other_user}", "gists_url": "https://api.github.com/users/echohack/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/echohack", "id": 3253989, "login": "echohack", "node_id": "MDQ6VXNlcjMyNTM5ODk=", "organizations_url": "https://api.github.com/users/echohack/orgs", "received_events_url": "https://api.github.com/users/echohack/received_events", "repos_url": "https://api.github.com/users/echohack/repos", "site_admin": true, "starred_url": "https://api.github.com/users/echohack/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/echohack/subscriptions", "type": "User", "url": "https://api.github.com/users/echohack", "user_view_type": "public" }
[]
closed
true
null
[]
null
67
2013-04-04T15:34:17Z
2021-09-08T18:00:45Z
2013-04-25T18:41:08Z
NONE
resolved
I'm getting a strange error when using Requests in Python 3.3 (other flavors of Python 3 do not get this error): ``` Traceback (most recent call last): File "C:\Python33\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 421, in urlopen body=body, headers=headers) File "C:\Python33\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 273, in _make_request conn.request(method, url, **httplib_request_kw) File "C:\Python33\lib\http\client.py", line 1049, in request self._send_request(method, url, body, headers) File "C:\Python33\lib\http\client.py", line 1087, in _send_request self.endheaders(body) File "C:\Python33\lib\http\client.py", line 1045, in endheaders self._send_output(message_body) File "C:\Python33\lib\http\client.py", line 890, in _send_output self.send(msg) File "C:\Python33\lib\http\client.py", line 828, in send self.connect() File "C:\Python33\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 104, in connect ssl_version=resolved_ssl_version) File "C:\Python33\lib\site-packages\requests\packages\urllib3\util.py", line 329, in ssl_wrap_socket return context.wrap_socket(sock, server_hostname=server_hostname) File "C:\Python33\lib\ssl.py", line 210, in wrap_socket _context=self) File "C:\Python33\lib\ssl.py", line 310, in __init__ raise x File "C:\Python33\lib\ssl.py", line 306, in __init__ self.do_handshake() File "C:\Python33\lib\ssl.py", line 513, in do_handshake self._sslobj.do_handshake() ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host During handling of the above exception, another exception occurred: Traceback (most recent call last): File "C:\Python33\lib\site-packages\requests\adapters.py", line 211, in send timeout=timeout File "C:\Python33\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 465, in urlopen raise MaxRetryError(self, url, e) requests.packages.urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='analysiscenter.veracode.com', port=443): Max retries exceeded with url: /api/2.0/getappbuilds.do (Caused by <class 'ConnectionResetError'>: [WinError 10054] An existing connection was forcibly closed by the remote host) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "C:\tfs\Vertafore_TFSDev\CQ\python\veracode\pythontestscriptonation.py", line 33, in <module> print(v.get_app_builds()) File "C:\tfs\Vertafore_TFSDev\CQ\python\veracode\apiwrapper.py", line 184, in get_app_builds {} File "C:\tfs\Vertafore_TFSDev\CQ\python\veracode\apiwrapper.py", line 57, in request r = requests.get(URL, params=data, auth=username_password) File "C:\Python33\lib\site-packages\requests\api.py", line 55, in get return request('get', url, **kwargs) File "C:\Python33\lib\site-packages\requests\api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "C:\Python33\lib\site-packages\requests\sessions.py", line 354, in request resp = self.send(prep, **send_kwargs) File "C:\Python33\lib\site-packages\requests\sessions.py", line 460, in send r = adapter.send(request, **kwargs) File "C:\Python33\lib\site-packages\requests\adapters.py", line 246, in send raise ConnectionError(e) requests.exceptions.ConnectionError: HTTPSConnectionPool(host='analysiscenter.veracode.com', port=443): Max retries exceeded with url: /api/2.0/getappbuilds.do (Caused by <class 'ConnectionResetError'>: [WinError 10054] An existing connection was forcibly closed by the remote host) [Finished in 61.0s with exit code 1] ``` This automation has run for months on Python 3.2 and these errors have never occurred. I don't really know enough about requests to investigate this issue, but I'd be happy to help recreate the issue or debug if someone else can. Perhaps there's a bug in how Requests is handling HTTPS requests with Python 3.3? (Did 3.3 change how urllib works?...I don't know offhand...) Again, I'm not getting any of these issues in Python 3.2 or Python 3.1. Please help! :)
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1289/reactions" }
https://api.github.com/repos/psf/requests/issues/1289/timeline
null
completed
null
null
false
[ "Please reply with the following: `python -c 'import requests; print(requests.__version__)'`\n", "Requests version 1.1.0.\n", "@t-8ch can explain this in detail but upgrading to 1.2.0 should fix all of your problems.\n", "Excellent! I'll test it out. Thank you for your quick response. :)\n", "If it doesn't ...
https://api.github.com/repos/psf/requests/issues/1288
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1288/labels{/name}
https://api.github.com/repos/psf/requests/issues/1288/comments
https://api.github.com/repos/psf/requests/issues/1288/events
https://github.com/psf/requests/pull/1288
12,784,976
MDExOlB1bGxSZXF1ZXN0NDk3MDA3OA==
1,288
source_address support (rough)
{ "avatar_url": "https://avatars.githubusercontent.com/u/516893?v=4", "events_url": "https://api.github.com/users/jessesherlock/events{/privacy}", "followers_url": "https://api.github.com/users/jessesherlock/followers", "following_url": "https://api.github.com/users/jessesherlock/following{/other_user}", "gists_url": "https://api.github.com/users/jessesherlock/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jessesherlock", "id": 516893, "login": "jessesherlock", "node_id": "MDQ6VXNlcjUxNjg5Mw==", "organizations_url": "https://api.github.com/users/jessesherlock/orgs", "received_events_url": "https://api.github.com/users/jessesherlock/received_events", "repos_url": "https://api.github.com/users/jessesherlock/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jessesherlock/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jessesherlock/subscriptions", "type": "User", "url": "https://api.github.com/users/jessesherlock", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-04-04T04:14:02Z
2021-09-08T23:08:18Z
2013-04-04T05:11:42Z
NONE
resolved
First pass on source_address support (2.7 only).
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1288/reactions" }
https://api.github.com/repos/psf/requests/issues/1288/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1288.diff", "html_url": "https://github.com/psf/requests/pull/1288", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1288.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1288" }
true
[ "This is what connection adapters are for.\n", "Thanks, I'll have a look at connection adapters\n" ]
https://api.github.com/repos/psf/requests/issues/1287
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1287/labels{/name}
https://api.github.com/repos/psf/requests/issues/1287/comments
https://api.github.com/repos/psf/requests/issues/1287/events
https://github.com/psf/requests/issues/1287
12,753,026
MDU6SXNzdWUxMjc1MzAyNg==
1,287
Cookies won't get deleted after update to 1.X
{ "avatar_url": "https://avatars.githubusercontent.com/u/642195?v=4", "events_url": "https://api.github.com/users/oczkers/events{/privacy}", "followers_url": "https://api.github.com/users/oczkers/followers", "following_url": "https://api.github.com/users/oczkers/following{/other_user}", "gists_url": "https://api.github.com/users/oczkers/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/oczkers", "id": 642195, "login": "oczkers", "node_id": "MDQ6VXNlcjY0MjE5NQ==", "organizations_url": "https://api.github.com/users/oczkers/orgs", "received_events_url": "https://api.github.com/users/oczkers/received_events", "repos_url": "https://api.github.com/users/oczkers/repos", "site_admin": false, "starred_url": "https://api.github.com/users/oczkers/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oczkers/subscriptions", "type": "User", "url": "https://api.github.com/users/oczkers", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2013-04-03T13:48:27Z
2021-09-09T04:00:39Z
2013-04-05T03:22:39Z
CONTRIBUTOR
resolved
Requests ignores `Set-Cookie: cookie_user=deleted; expires=Thu, 01-Jan-1970 00:00:01 GMT; path=/; domain=.netload.in` full log ``` HTTP/1.1 302 Found Set-Cookie: PHPSESSID=2a4eed6c32fdf347d77dd3aa07596766; path=/ Set-Cookie: cookie_user=182018%3A75e5d076a5077cc37cf0822c7e49dbb5; expires=Wed, 10-Apr-2013 13:26:08 GMT; path=/; domain=.netload.in Expires: Thu, 19 Nov 1981 08:52:00 GMT Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0 Pragma: no-cache Location: /index.php Content-type: text/html Content-Length: 0 Date: Wed, 03 Apr 2013 13:26:08 GMT Server: nginx/1.2.4 GET /index.php?id=15 HTTP/1.1 Host: netload.in Accept-Language: en;q=0.8 Accept-Encoding: deflate, gzip, x-gzip, identity, *;q=0 Keep-Alive: 300 Accept: text/html, application/xml;q=0.9, application/xhtml+xml, image/png, image/jpeg, image/gif, image/x-xbitmap, */*;q=0.1 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.43 Safari/537.31 Accept-Charset: utf-8, iso-8859-1, utf-16, *;q=0.1 Connection: Keep-Alive, TE Cookie: cookie_user=182018%3A75e5d076a5077cc37cf0822c7e49dbb5; PHPSESSID=2a4eed6c32fdf347d77dd3aa07596766 TE: deflate, gzip, chunked, identity, trailers HTTP/1.1 302 Found Set-Cookie: cookie_user=deleted; expires=Thu, 01-Jan-1970 00:00:01 GMT; path=/; domain=.netload.in Expires: Thu, 19 Nov 1981 08:52:00 GMT Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0 Pragma: no-cache Location: index.php Content-type: text/html Content-Length: 0 Date: Wed, 03 Apr 2013 13:26:08 GMT Server: nginx/1.2.4 GET /index.php HTTP/1.1 Host: netload.in Accept-Language: en;q=0.8 Accept-Encoding: deflate, gzip, x-gzip, identity, *;q=0 Keep-Alive: 300 Accept: text/html, application/xml;q=0.9, application/xhtml+xml, image/png, image/jpeg, image/gif, image/x-xbitmap, */*;q=0.1 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.43 Safari/537.31 Accept-Charset: utf-8, iso-8859-1, utf-16, *;q=0.1 Connection: Keep-Alive, TE Cookie: cookie_user=182018%3A75e5d076a5077cc37cf0822c7e49dbb5; PHPSESSID=2a4eed6c32fdf347d77dd3aa07596766 TE: deflate, gzip, chunked, identity, trailers ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1287/reactions" }
https://api.github.com/repos/psf/requests/issues/1287/timeline
null
completed
null
null
false
[ "Could you provide the output from the following? `python -c 'import requests; print(requests.__version__)'`\n", "It's latest development version (pulled from git few hours ago).\n\n``` python\n# python -c 'import requests; print(requests.__version__)'\n1.2.0\n```\n\nSteps to reproduce error (requests is sending ...
https://api.github.com/repos/psf/requests/issues/1286
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1286/labels{/name}
https://api.github.com/repos/psf/requests/issues/1286/comments
https://api.github.com/repos/psf/requests/issues/1286/events
https://github.com/psf/requests/pull/1286
12,722,303
MDExOlB1bGxSZXF1ZXN0NDk2MjEwMg==
1,286
Consistent String Encoding
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "color": "e102d8", "default": false, "description": null, "id": 117745, "name": "Planned", "node_id": "MDU6TGFiZWwxMTc3NDU=", "url": "https://api.github.com/repos/psf/requests/labels/Planned" } ]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
14
2013-04-02T19:55:53Z
2021-09-08T23:11:04Z
2013-04-16T19:53:11Z
MEMBER
resolved
Over the last few months there have been multiple issues raised about problems with string encodings. At best Requests is being inconsistent (#1250), and at worst perfectly valid combinations of input are failing (#1279). I think it's time for Requests to enforce a very consistent behaviour when it comes to string encodings. We need to establish what format the data will be in when we pass it to urllib3, and where we're going to transform it. We need to be consistent so that when users inevitably encounter errors, we can make it very clear what they should have passed in. @shazow has said that urllib3 wants the following input: bytes in the body, and native strings everywhere else. This defines our interface to urllib3. To keep in sync with the above, we need to do the following things. - On Python 2, any unicode strings anywhere on a `PreparedRequest` other than the body should be encoded as UTF-8. The body should also be encoded as UTF-8 if it is a unicode string (unlikely, but unless we can guarantee it won't be we should do the right thing). - On Python 3, any bytestrings in a PreparedRequest should be decoded to unicode strings. Because we cannot make any intelligent guess, we will use Python's (stupid, stupid, _stupid_) locale-based decoding. This will almost-certainly throw exceptions if an incorrect encoding has been used, alerting the user. Thoughts?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1286/reactions" }
https://api.github.com/repos/psf/requests/issues/1286/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1286.diff", "html_url": "https://github.com/psf/requests/pull/1286", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1286.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1286" }
true
[ "One thought I have is that I'm glad you didn't assign this to me. ;)\n\nThe only things I can think of are\n- to make this a dumb function that lives in `requests/utils.py` and will do it for you.\n- heavily document this so users might handle the encoding themselves or at least be able to find out why they're get...
https://api.github.com/repos/psf/requests/issues/1285
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1285/labels{/name}
https://api.github.com/repos/psf/requests/issues/1285/comments
https://api.github.com/repos/psf/requests/issues/1285/events
https://github.com/psf/requests/issues/1285
12,719,298
MDU6SXNzdWUxMjcxOTI5OA==
1,285
Fail fast on HTTPS calls with the ssl module unavailable
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" } ]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
null
13
2013-04-02T18:45:56Z
2021-09-09T04:00:33Z
2013-04-25T18:41:58Z
CONTRIBUTOR
resolved
While hanging around the IRC channel today, a user came in with an HTTPS request that was not completing. It turned out that he didn't have ssl configured properly on his python 3 installation (here's looking at you ArchLinux). It would seem to me that failing quickly as opposed to just hanging there would be far more useful. Admittedly you would hope an advanced user would know if they have SSL installed or enabled, but someone just starting out might not. I know urllib3 smothers the Exception they get when importing ssl, but would anyone object to throwing a custom Exception when users try to make HTTPS requests?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1285/reactions" }
https://api.github.com/repos/psf/requests/issues/1285/timeline
null
completed
null
null
false
[ "I'm all for it. =)\n", "@sigmavirus24 \nCould you provide more details/a transcription of the IRC conversation?\nI created a really minimal VM of ArchLinux (base installation + python from the repos + requests from pip and from the repos) and everything worked fine.\n", "@t-8ch\n\nThe following is the start of...
https://api.github.com/repos/psf/requests/issues/1284
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1284/labels{/name}
https://api.github.com/repos/psf/requests/issues/1284/comments
https://api.github.com/repos/psf/requests/issues/1284/events
https://github.com/psf/requests/pull/1284
12,704,757
MDExOlB1bGxSZXF1ZXN0NDkyOTM0Mw==
1,284
Add missing return_response parameter support according to the docstring...
{ "avatar_url": "https://avatars.githubusercontent.com/u/121741?v=4", "events_url": "https://api.github.com/users/KamilSzot/events{/privacy}", "followers_url": "https://api.github.com/users/KamilSzot/followers", "following_url": "https://api.github.com/users/KamilSzot/following{/other_user}", "gists_url": "https://api.github.com/users/KamilSzot/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/KamilSzot", "id": 121741, "login": "KamilSzot", "node_id": "MDQ6VXNlcjEyMTc0MQ==", "organizations_url": "https://api.github.com/users/KamilSzot/orgs", "received_events_url": "https://api.github.com/users/KamilSzot/received_events", "repos_url": "https://api.github.com/users/KamilSzot/repos", "site_admin": false, "starred_url": "https://api.github.com/users/KamilSzot/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KamilSzot/subscriptions", "type": "User", "url": "https://api.github.com/users/KamilSzot", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-04-02T13:26:22Z
2021-09-08T20:01:08Z
2013-04-02T18:42:58Z
CONTRIBUTOR
resolved
.... This time with proper whitespaces.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1284/reactions" }
https://api.github.com/repos/psf/requests/issues/1284/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1284.diff", "html_url": "https://github.com/psf/requests/pull/1284", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1284.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1284" }
true
[ "Sorry for improper indent last time.\n", "@KamilSzot why would you want the unprepared request in the first place? You can do this very easily on your own and that aside, you can not send an unprepared request to `Session#send` or the underlying adapter. The changes don't make any sense from that point of view. ...
https://api.github.com/repos/psf/requests/issues/1283
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1283/labels{/name}
https://api.github.com/repos/psf/requests/issues/1283/comments
https://api.github.com/repos/psf/requests/issues/1283/events
https://github.com/psf/requests/pull/1283
12,704,633
MDExOlB1bGxSZXF1ZXN0NDkyOTI4Mw==
1,283
Closes #1280
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-04-02T13:23:09Z
2021-09-08T20:01:09Z
2013-04-04T01:04:40Z
CONTRIBUTOR
resolved
I'll close #1280 after you merge this by hand. I forgot to include it in the commit message.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1283/reactions" }
https://api.github.com/repos/psf/requests/issues/1283/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1283.diff", "html_url": "https://github.com/psf/requests/pull/1283", "merged_at": "2013-04-04T01:04:40Z", "patch_url": "https://github.com/psf/requests/pull/1283.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1283" }
true
[ "Sorry, had to rebase and whatnot\n", "Also added documentation about using PreparedRequests. I might split that off into a separate pull request if you'd rather.\n", "<3\n" ]
https://api.github.com/repos/psf/requests/issues/1282
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1282/labels{/name}
https://api.github.com/repos/psf/requests/issues/1282/comments
https://api.github.com/repos/psf/requests/issues/1282/events
https://github.com/psf/requests/pull/1282
12,704,348
MDExOlB1bGxSZXF1ZXN0NDkyOTE0Nw==
1,282
Changed tabs to spaces to conform with the style of the file
{ "avatar_url": "https://avatars.githubusercontent.com/u/121741?v=4", "events_url": "https://api.github.com/users/KamilSzot/events{/privacy}", "followers_url": "https://api.github.com/users/KamilSzot/followers", "following_url": "https://api.github.com/users/KamilSzot/following{/other_user}", "gists_url": "https://api.github.com/users/KamilSzot/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/KamilSzot", "id": 121741, "login": "KamilSzot", "node_id": "MDQ6VXNlcjEyMTc0MQ==", "organizations_url": "https://api.github.com/users/KamilSzot/orgs", "received_events_url": "https://api.github.com/users/KamilSzot/received_events", "repos_url": "https://api.github.com/users/KamilSzot/repos", "site_admin": false, "starred_url": "https://api.github.com/users/KamilSzot/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KamilSzot/subscriptions", "type": "User", "url": "https://api.github.com/users/KamilSzot", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2013-04-02T13:16:48Z
2021-09-08T19:01:02Z
2013-04-02T13:20:42Z
CONTRIBUTOR
resolved
Sorry for the wrong white-spaces in my previous pull request.
{ "avatar_url": "https://avatars.githubusercontent.com/u/121741?v=4", "events_url": "https://api.github.com/users/KamilSzot/events{/privacy}", "followers_url": "https://api.github.com/users/KamilSzot/followers", "following_url": "https://api.github.com/users/KamilSzot/following{/other_user}", "gists_url": "https://api.github.com/users/KamilSzot/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/KamilSzot", "id": 121741, "login": "KamilSzot", "node_id": "MDQ6VXNlcjEyMTc0MQ==", "organizations_url": "https://api.github.com/users/KamilSzot/orgs", "received_events_url": "https://api.github.com/users/KamilSzot/received_events", "repos_url": "https://api.github.com/users/KamilSzot/repos", "site_admin": false, "starred_url": "https://api.github.com/users/KamilSzot/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KamilSzot/subscriptions", "type": "User", "url": "https://api.github.com/users/KamilSzot", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1282/reactions" }
https://api.github.com/repos/psf/requests/issues/1282/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1282.diff", "html_url": "https://github.com/psf/requests/pull/1282", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1282.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1282" }
true
[]
https://api.github.com/repos/psf/requests/issues/1281
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1281/labels{/name}
https://api.github.com/repos/psf/requests/issues/1281/comments
https://api.github.com/repos/psf/requests/issues/1281/events
https://github.com/psf/requests/pull/1281
12,701,312
MDExOlB1bGxSZXF1ZXN0NDkyNzU2OA==
1,281
Fix for the issue https://github.com/kennethreitz/requests/issues/1280
{ "avatar_url": "https://avatars.githubusercontent.com/u/121741?v=4", "events_url": "https://api.github.com/users/KamilSzot/events{/privacy}", "followers_url": "https://api.github.com/users/KamilSzot/followers", "following_url": "https://api.github.com/users/KamilSzot/following{/other_user}", "gists_url": "https://api.github.com/users/KamilSzot/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/KamilSzot", "id": 121741, "login": "KamilSzot", "node_id": "MDQ6VXNlcjEyMTc0MQ==", "organizations_url": "https://api.github.com/users/KamilSzot/orgs", "received_events_url": "https://api.github.com/users/KamilSzot/received_events", "repos_url": "https://api.github.com/users/KamilSzot/repos", "site_admin": false, "starred_url": "https://api.github.com/users/KamilSzot/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KamilSzot/subscriptions", "type": "User", "url": "https://api.github.com/users/KamilSzot", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2013-04-02T11:44:04Z
2021-09-08T19:01:02Z
2013-04-02T11:44:59Z
CONTRIBUTOR
resolved
https://github.com/kennethreitz/requests/issues/1280
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1281/reactions" }
https://api.github.com/repos/psf/requests/issues/1281/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1281.diff", "html_url": "https://github.com/psf/requests/pull/1281", "merged_at": "2013-04-02T11:44:59Z", "patch_url": "https://github.com/psf/requests/pull/1281.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1281" }
true
[ ":metal:\n", "@kennethreitz why reintroduce this behaviour? It was a documentation mistake on my part.\n", "Woah why did you open this?\n", "Oh, you guys have the same avatar. :(\n", "Reverted.\n", "So you won't reintroduce this behavior? Could you suggest what should I do instead to achieve same thing?\n...
https://api.github.com/repos/psf/requests/issues/1280
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1280/labels{/name}
https://api.github.com/repos/psf/requests/issues/1280/comments
https://api.github.com/repos/psf/requests/issues/1280/events
https://github.com/psf/requests/issues/1280
12,700,800
MDU6SXNzdWUxMjcwMDgwMA==
1,280
Session.request doesn't have parameter return_response, contrary to what the docs say.
{ "avatar_url": "https://avatars.githubusercontent.com/u/121741?v=4", "events_url": "https://api.github.com/users/KamilSzot/events{/privacy}", "followers_url": "https://api.github.com/users/KamilSzot/followers", "following_url": "https://api.github.com/users/KamilSzot/following{/other_user}", "gists_url": "https://api.github.com/users/KamilSzot/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/KamilSzot", "id": 121741, "login": "KamilSzot", "node_id": "MDQ6VXNlcjEyMTc0MQ==", "organizations_url": "https://api.github.com/users/KamilSzot/orgs", "received_events_url": "https://api.github.com/users/KamilSzot/received_events", "repos_url": "https://api.github.com/users/KamilSzot/repos", "site_admin": false, "starred_url": "https://api.github.com/users/KamilSzot/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KamilSzot/subscriptions", "type": "User", "url": "https://api.github.com/users/KamilSzot", "user_view_type": "public" }
[]
closed
true
null
[]
null
19
2013-04-02T11:24:21Z
2021-09-09T02:11:57Z
2013-04-04T01:04:41Z
CONTRIBUTOR
resolved
``` def request(self, method, url, params=None, data=None, headers=None, cookies=None, files=None, auth=None, timeout=None, allow_redirects=True, proxies=None, hooks=None, stream=None, verify=None, cert=None): """Constructs a :class:`Request <Request>`, prepares it and sends it. Returns :class:`Response <Response>` object. :param method: method for the new :class:`Request` object. :param url: URL for the new :class:`Request` object. :param params: (optional) Dictionary or bytes to be sent in the query string for the :class:`Request`. :param data: (optional) Dictionary or bytes to send in the body of the :class:`Request`. :param headers: (optional) Dictionary of HTTP Headers to send with the :class:`Request`. :param cookies: (optional) Dict or CookieJar object to send with the :class:`Request`. :param files: (optional) Dictionary of 'filename': file-like-objects for multipart encoding upload. :param auth: (optional) Auth tuple or callable to enable Basic/Digest/Custom HTTP Auth. :param timeout: (optional) Float describing the timeout of the request. :param allow_redirects: (optional) Boolean. Set to True by default. :param proxies: (optional) Dictionary mapping protocol to the URL of the proxy. :param return_response: (optional) If False, an un-sent Request object will returned. :param config: (optional) A configuration dictionary. See ``request.defaults`` for allowed keys and their default values. :param prefetch: (optional) whether to immediately download the response content. Defaults to ``True``. :param verify: (optional) if ``True``, the SSL cert will be verified. A CA_BUNDLE path can also be provided. :param cert: (optional) if String, path to ssl client cert file (.pem). If Tuple, ('cert', 'key') pair. """ ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1280/reactions" }
https://api.github.com/repos/psf/requests/issues/1280/timeline
null
completed
null
null
false
[ "Or config and presumably prefetch=> stream also. So basically it seems like the docstring hasn't been updated from pre 1.0 times\n", "This is my fault. I'll fix it \n", "So you won't reintroduce this behavior? Could you suggest what should I do instead to achieve same thing?\n\nNamely, I want to create request...
https://api.github.com/repos/psf/requests/issues/1279
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1279/labels{/name}
https://api.github.com/repos/psf/requests/issues/1279/comments
https://api.github.com/repos/psf/requests/issues/1279/events
https://github.com/psf/requests/pull/1279
12,680,586
MDExOlB1bGxSZXF1ZXN0NDkxODkzNA==
1,279
Unicode strings in multipart post requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/18160?v=4", "events_url": "https://api.github.com/users/jemerick/events{/privacy}", "followers_url": "https://api.github.com/users/jemerick/followers", "following_url": "https://api.github.com/users/jemerick/following{/other_user}", "gists_url": "https://api.github.com/users/jemerick/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jemerick", "id": 18160, "login": "jemerick", "node_id": "MDQ6VXNlcjE4MTYw", "organizations_url": "https://api.github.com/users/jemerick/orgs", "received_events_url": "https://api.github.com/users/jemerick/received_events", "repos_url": "https://api.github.com/users/jemerick/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jemerick/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jemerick/subscriptions", "type": "User", "url": "https://api.github.com/users/jemerick", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2013-04-01T22:53:38Z
2021-09-08T23:05:19Z
2013-04-16T19:55:58Z
CONTRIBUTOR
resolved
When attempting to post a file along with some other data including a unicode string (demonstrated in the added test case) I was running into the following error: UnicodeEncodeError: 'ascii' codec can't encode character u'\xeb' in position 0: ordinal not in range(128) I traced the issue back to `_encode_files` where `compat.builtin_str`, in my case `str`, was being applied to the unicode string causing the above error. I changed it to use `compat.str` which seems to have resolved the issue. ``` bash > python --version Python 2.7.2 ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1279/reactions" }
https://api.github.com/repos/psf/requests/issues/1279/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1279.diff", "html_url": "https://github.com/psf/requests/pull/1279", "merged_at": "2013-04-16T19:55:58Z", "patch_url": "https://github.com/psf/requests/pull/1279.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1279" }
true
[ "Hi, and thanks for the bug report!\n\nUnfortunately, you've run straight into Python 2's implicit string encoding/decoding, and your code changes don't resolve the problem: they simply move it somewhere else. In Requests, `str` is aliased to `unicode` in Requests on Python 2. This means your change will call `unic...
https://api.github.com/repos/psf/requests/issues/1278
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1278/labels{/name}
https://api.github.com/repos/psf/requests/issues/1278/comments
https://api.github.com/repos/psf/requests/issues/1278/events
https://github.com/psf/requests/pull/1278
12,671,281
MDExOlB1bGxSZXF1ZXN0NDkxMzkwNw==
1,278
fix tiny typo in HISTORY.rst
{ "avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4", "events_url": "https://api.github.com/users/t-8ch/events{/privacy}", "followers_url": "https://api.github.com/users/t-8ch/followers", "following_url": "https://api.github.com/users/t-8ch/following{/other_user}", "gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/t-8ch", "id": 717901, "login": "t-8ch", "node_id": "MDQ6VXNlcjcxNzkwMQ==", "organizations_url": "https://api.github.com/users/t-8ch/orgs", "received_events_url": "https://api.github.com/users/t-8ch/received_events", "repos_url": "https://api.github.com/users/t-8ch/repos", "site_admin": false, "starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions", "type": "User", "url": "https://api.github.com/users/t-8ch", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2013-04-01T18:47:39Z
2021-09-08T19:01:01Z
2013-04-02T04:36:49Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1278/reactions" }
https://api.github.com/repos/psf/requests/issues/1278/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1278.diff", "html_url": "https://github.com/psf/requests/pull/1278", "merged_at": "2013-04-02T04:36:49Z", "patch_url": "https://github.com/psf/requests/pull/1278.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1278" }
true
[]
https://api.github.com/repos/psf/requests/issues/1277
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1277/labels{/name}
https://api.github.com/repos/psf/requests/issues/1277/comments
https://api.github.com/repos/psf/requests/issues/1277/events
https://github.com/psf/requests/pull/1277
12,663,395
MDExOlB1bGxSZXF1ZXN0NDkwOTkzNw==
1,277
Fixed typos
{ "avatar_url": "https://avatars.githubusercontent.com/u/77759?v=4", "events_url": "https://api.github.com/users/pborreli/events{/privacy}", "followers_url": "https://api.github.com/users/pborreli/followers", "following_url": "https://api.github.com/users/pborreli/following{/other_user}", "gists_url": "https://api.github.com/users/pborreli/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pborreli", "id": 77759, "login": "pborreli", "node_id": "MDQ6VXNlcjc3NzU5", "organizations_url": "https://api.github.com/users/pborreli/orgs", "received_events_url": "https://api.github.com/users/pborreli/received_events", "repos_url": "https://api.github.com/users/pborreli/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pborreli/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pborreli/subscriptions", "type": "User", "url": "https://api.github.com/users/pborreli", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-04-01T15:03:21Z
2021-09-08T23:01:09Z
2013-04-02T04:36:39Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1277/reactions" }
https://api.github.com/repos/psf/requests/issues/1277/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1277.diff", "html_url": "https://github.com/psf/requests/pull/1277", "merged_at": "2013-04-02T04:36:39Z", "patch_url": "https://github.com/psf/requests/pull/1277.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1277" }
true
[ ":+1:\n", ":+1: \n", ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1276
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1276/labels{/name}
https://api.github.com/repos/psf/requests/issues/1276/comments
https://api.github.com/repos/psf/requests/issues/1276/events
https://github.com/psf/requests/pull/1276
12,653,514
MDExOlB1bGxSZXF1ZXN0NDkwNTQ1MA==
1,276
is should not be used for comparing numbers
{ "avatar_url": "https://avatars.githubusercontent.com/u/772?v=4", "events_url": "https://api.github.com/users/alex/events{/privacy}", "followers_url": "https://api.github.com/users/alex/followers", "following_url": "https://api.github.com/users/alex/following{/other_user}", "gists_url": "https://api.github.com/users/alex/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/alex", "id": 772, "login": "alex", "node_id": "MDQ6VXNlcjc3Mg==", "organizations_url": "https://api.github.com/users/alex/orgs", "received_events_url": "https://api.github.com/users/alex/received_events", "repos_url": "https://api.github.com/users/alex/repos", "site_admin": false, "starred_url": "https://api.github.com/users/alex/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alex/subscriptions", "type": "User", "url": "https://api.github.com/users/alex", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-04-01T06:20:50Z
2023-05-23T23:14:22Z
2013-04-02T03:42:23Z
MEMBER
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1276/reactions" }
https://api.github.com/repos/psf/requests/issues/1276/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1276.diff", "html_url": "https://github.com/psf/requests/pull/1276", "merged_at": "2013-04-02T03:42:23Z", "patch_url": "https://github.com/psf/requests/pull/1276.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1276" }
true
[ "+1.\n", ":+1:\n", "Wow, that's an old line of code.\n" ]
https://api.github.com/repos/psf/requests/issues/1275
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1275/labels{/name}
https://api.github.com/repos/psf/requests/issues/1275/comments
https://api.github.com/repos/psf/requests/issues/1275/events
https://github.com/psf/requests/pull/1275
12,641,373
MDExOlB1bGxSZXF1ZXN0NDkwMTE0MQ==
1,275
Requests in history are overridden on redirect
{ "avatar_url": "https://avatars.githubusercontent.com/u/660112?v=4", "events_url": "https://api.github.com/users/reclosedev/events{/privacy}", "followers_url": "https://api.github.com/users/reclosedev/followers", "following_url": "https://api.github.com/users/reclosedev/following{/other_user}", "gists_url": "https://api.github.com/users/reclosedev/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/reclosedev", "id": 660112, "login": "reclosedev", "node_id": "MDQ6VXNlcjY2MDExMg==", "organizations_url": "https://api.github.com/users/reclosedev/orgs", "received_events_url": "https://api.github.com/users/reclosedev/received_events", "repos_url": "https://api.github.com/users/reclosedev/repos", "site_admin": false, "starred_url": "https://api.github.com/users/reclosedev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reclosedev/subscriptions", "type": "User", "url": "https://api.github.com/users/reclosedev", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-03-31T10:42:56Z
2021-09-08T19:01:00Z
2013-04-19T06:32:31Z
CONTRIBUTOR
resolved
Example: ``` python import requests resp = requests.get("http://httpbin.org/redirect/4") for r in resp.history: print("url: {} request.url: {}".format(r.url, r.request.url)) ``` Output: ``` url: http://httpbin.org/redirect/4 request.url: http://httpbin.org/redirect/4 url: http://httpbin.org/redirect/3 request.url: http://httpbin.org/get url: http://httpbin.org/redirect/2 request.url: http://httpbin.org/get url: http://httpbin.org/redirect/1 request.url: http://httpbin.org/get ``` Simplest solution is to copy `prepared_request` for each redirect. Also `prepared_request` can be created inside the while loop (maybe it's better?).
{ "avatar_url": "https://avatars.githubusercontent.com/u/660112?v=4", "events_url": "https://api.github.com/users/reclosedev/events{/privacy}", "followers_url": "https://api.github.com/users/reclosedev/followers", "following_url": "https://api.github.com/users/reclosedev/following{/other_user}", "gists_url": "https://api.github.com/users/reclosedev/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/reclosedev", "id": 660112, "login": "reclosedev", "node_id": "MDQ6VXNlcjY2MDExMg==", "organizations_url": "https://api.github.com/users/reclosedev/orgs", "received_events_url": "https://api.github.com/users/reclosedev/received_events", "repos_url": "https://api.github.com/users/reclosedev/repos", "site_admin": false, "starred_url": "https://api.github.com/users/reclosedev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reclosedev/subscriptions", "type": "User", "url": "https://api.github.com/users/reclosedev", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1275/reactions" }
https://api.github.com/repos/psf/requests/issues/1275/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1275.diff", "html_url": "https://github.com/psf/requests/pull/1275", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1275.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1275" }
true
[ "My sincere concern with this pull request is that you could have someone making a lot of requests to resources that have at least one redirect each. At that point their memory consumption will grow a lot faster than now.\n\nI would be 100% ok going back to the original 1.x behaviour of only attaching the original ...
https://api.github.com/repos/psf/requests/issues/1274
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1274/labels{/name}
https://api.github.com/repos/psf/requests/issues/1274/comments
https://api.github.com/repos/psf/requests/issues/1274/events
https://github.com/psf/requests/issues/1274
12,624,570
MDU6SXNzdWUxMjYyNDU3MA==
1,274
API ratelimit timer
{ "avatar_url": "https://avatars.githubusercontent.com/u/3277097?v=4", "events_url": "https://api.github.com/users/0xcaff/events{/privacy}", "followers_url": "https://api.github.com/users/0xcaff/followers", "following_url": "https://api.github.com/users/0xcaff/following{/other_user}", "gists_url": "https://api.github.com/users/0xcaff/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/0xcaff", "id": 3277097, "login": "0xcaff", "node_id": "MDQ6VXNlcjMyNzcwOTc=", "organizations_url": "https://api.github.com/users/0xcaff/orgs", "received_events_url": "https://api.github.com/users/0xcaff/received_events", "repos_url": "https://api.github.com/users/0xcaff/repos", "site_admin": false, "starred_url": "https://api.github.com/users/0xcaff/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/0xcaff/subscriptions", "type": "User", "url": "https://api.github.com/users/0xcaff", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-30T01:31:10Z
2021-09-09T04:00:44Z
2013-03-30T03:15:38Z
NONE
resolved
Can you please add a pre-request timer to the session class to comply with certain api ratelimit rules? Requestobj.ratelimit = 1 Requestobj.get(url) # will wait one second before making the request
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 1, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 1, "url": "https://api.github.com/repos/psf/requests/issues/1274/reactions" }
https://api.github.com/repos/psf/requests/issues/1274/timeline
null
completed
null
null
false
[ "We're under a feature freeze (#1165) which means this won't be accepted and on top of that you can do the following:\n\n``` python\nimport time\n\n\nclass MySession(requests.Session):\n def __init__(self):\n super(MySession, self).__init__()\n self.ratelimit = 0\n\n def request(*args):\n ...
https://api.github.com/repos/psf/requests/issues/1273
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1273/labels{/name}
https://api.github.com/repos/psf/requests/issues/1273/comments
https://api.github.com/repos/psf/requests/issues/1273/events
https://github.com/psf/requests/pull/1273
12,623,336
MDExOlB1bGxSZXF1ZXN0NDg5NDYzMw==
1,273
A Session object now maintains a response hook property...
{ "avatar_url": "https://avatars.githubusercontent.com/u/1027771?v=4", "events_url": "https://api.github.com/users/rowedonalde/events{/privacy}", "followers_url": "https://api.github.com/users/rowedonalde/followers", "following_url": "https://api.github.com/users/rowedonalde/following{/other_user}", "gists_url": "https://api.github.com/users/rowedonalde/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rowedonalde", "id": 1027771, "login": "rowedonalde", "node_id": "MDQ6VXNlcjEwMjc3NzE=", "organizations_url": "https://api.github.com/users/rowedonalde/orgs", "received_events_url": "https://api.github.com/users/rowedonalde/received_events", "repos_url": "https://api.github.com/users/rowedonalde/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rowedonalde/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rowedonalde/subscriptions", "type": "User", "url": "https://api.github.com/users/rowedonalde", "user_view_type": "public" }
[]
closed
true
null
[]
null
13
2013-03-30T00:06:40Z
2021-09-08T19:01:00Z
2013-05-01T17:31:56Z
NONE
resolved
...for the most recent request. This pertains to issue at https://github.com/kennethreitz/requests/issues/1271
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1273/reactions" }
https://api.github.com/repos/psf/requests/issues/1273/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1273.diff", "html_url": "https://github.com/psf/requests/pull/1273", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1273.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1273" }
true
[ "You're re-calling the hook. We dispatch hooks elsewhere now. If you want this to be accepted at all, you'll need to set the response attribute in `Session#send`. It would also be nice if you stripped this commit from your repository and force-pushed the new commit with that to the same branch so the Pull Request w...
https://api.github.com/repos/psf/requests/issues/1272
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1272/labels{/name}
https://api.github.com/repos/psf/requests/issues/1272/comments
https://api.github.com/repos/psf/requests/issues/1272/events
https://github.com/psf/requests/issues/1272
12,616,958
MDU6SXNzdWUxMjYxNjk1OA==
1,272
Multipart files are only multipart/form-data
{ "avatar_url": "https://avatars.githubusercontent.com/u/1534574?v=4", "events_url": "https://api.github.com/users/zmelnick/events{/privacy}", "followers_url": "https://api.github.com/users/zmelnick/followers", "following_url": "https://api.github.com/users/zmelnick/following{/other_user}", "gists_url": "https://api.github.com/users/zmelnick/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zmelnick", "id": 1534574, "login": "zmelnick", "node_id": "MDQ6VXNlcjE1MzQ1NzQ=", "organizations_url": "https://api.github.com/users/zmelnick/orgs", "received_events_url": "https://api.github.com/users/zmelnick/received_events", "repos_url": "https://api.github.com/users/zmelnick/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zmelnick/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zmelnick/subscriptions", "type": "User", "url": "https://api.github.com/users/zmelnick", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-29T19:59:30Z
2021-09-09T04:00:45Z
2013-03-30T00:15:15Z
NONE
resolved
Unable to specify multipart/related or application/xop+xml when trying to send files with the file option. If headers are passed in, no additional information is added to them based on the other options used. Request: If header options are passed in, use those for multipart files, and add the boundary information. Currently I see no way to use SOAP with attachments using the multipart
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1272/reactions" }
https://api.github.com/repos/psf/requests/issues/1272/timeline
null
completed
null
null
false
[ "Requests only does the following encodings:\n- multipart/form-data\n- application/x-www-urlencoded\n\nThe rest is done by the user. The former is specified by using the files parameter as you tried here. We also do chunked encodings but for that we set the `Transfer-Encoding` header and not the `Content-Type` head...
https://api.github.com/repos/psf/requests/issues/1271
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1271/labels{/name}
https://api.github.com/repos/psf/requests/issues/1271/comments
https://api.github.com/repos/psf/requests/issues/1271/events
https://github.com/psf/requests/issues/1271
12,616,780
MDU6SXNzdWUxMjYxNjc4MA==
1,271
Response manipulation hook no longer in Session object after request?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1027771?v=4", "events_url": "https://api.github.com/users/rowedonalde/events{/privacy}", "followers_url": "https://api.github.com/users/rowedonalde/followers", "following_url": "https://api.github.com/users/rowedonalde/following{/other_user}", "gists_url": "https://api.github.com/users/rowedonalde/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rowedonalde", "id": 1027771, "login": "rowedonalde", "node_id": "MDQ6VXNlcjEwMjc3NzE=", "organizations_url": "https://api.github.com/users/rowedonalde/orgs", "received_events_url": "https://api.github.com/users/rowedonalde/received_events", "repos_url": "https://api.github.com/users/rowedonalde/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rowedonalde/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rowedonalde/subscriptions", "type": "User", "url": "https://api.github.com/users/rowedonalde", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-03-29T19:54:01Z
2021-09-09T04:00:40Z
2013-04-01T18:35:47Z
NONE
resolved
Commit a721d590b4e13b641b3171a081e7d6a7b3d8b6f2 as applied to request/session.py removes the following (lines 297-299, after request call succeeds): ``` python # Response manipulation hook. self.response = dispatch_hook('response', hooks, resp) ``` At the moment, my code which relies on this response property in the Session object works fine with the current 1.1.0 release from PyPI but breaks with this commit. Is there a reason why this hook was removed? It presents a significant compatibility issue.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1271/reactions" }
https://api.github.com/repos/psf/requests/issues/1271/timeline
null
completed
null
null
false
[ "I've made pull request #1273 if you want to restore this response property to an instance of Session.\n", "We removed it because when we asked if anyone was using it, no one replied in the affirmative.\n", "Closing to centralize discussion on #1273\n" ]
https://api.github.com/repos/psf/requests/issues/1270
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1270/labels{/name}
https://api.github.com/repos/psf/requests/issues/1270/comments
https://api.github.com/repos/psf/requests/issues/1270/events
https://github.com/psf/requests/pull/1270
12,603,922
MDExOlB1bGxSZXF1ZXN0NDg4NDUzNg==
1,270
add 'max_redirects' to Session's __attrs__
{ "avatar_url": "https://avatars.githubusercontent.com/u/1274612?v=4", "events_url": "https://api.github.com/users/makto/events{/privacy}", "followers_url": "https://api.github.com/users/makto/followers", "following_url": "https://api.github.com/users/makto/following{/other_user}", "gists_url": "https://api.github.com/users/makto/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/makto", "id": 1274612, "login": "makto", "node_id": "MDQ6VXNlcjEyNzQ2MTI=", "organizations_url": "https://api.github.com/users/makto/orgs", "received_events_url": "https://api.github.com/users/makto/received_events", "repos_url": "https://api.github.com/users/makto/repos", "site_admin": false, "starred_url": "https://api.github.com/users/makto/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/makto/subscriptions", "type": "User", "url": "https://api.github.com/users/makto", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-03-29T13:10:31Z
2021-09-08T19:00:59Z
2013-03-31T05:20:02Z
CONTRIBUTOR
resolved
This patch is to ensure the **proper serialization** with, like, the standard module _pickle_. See [Issue #1269](https://github.com/kennethreitz/requests/issues/1269) for specific potential error it may produce. Thanks for reviewing ;)
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1270/reactions" }
https://api.github.com/repos/psf/requests/issues/1270/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1270.diff", "html_url": "https://github.com/psf/requests/pull/1270", "merged_at": "2013-03-31T05:20:02Z", "patch_url": "https://github.com/psf/requests/pull/1270.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1270" }
true
[ "Hey, this looks likely! Nice detective work. :+1:\n", "@Lukasa \n\nThanks ;)\nGlad to be helpful.\n", ":+1:\n", ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1269
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1269/labels{/name}
https://api.github.com/repos/psf/requests/issues/1269/comments
https://api.github.com/repos/psf/requests/issues/1269/events
https://github.com/psf/requests/issues/1269
12,598,946
MDU6SXNzdWUxMjU5ODk0Ng==
1,269
'Session' object has no attribute 'max_redirects'
{ "avatar_url": "https://avatars.githubusercontent.com/u/1274612?v=4", "events_url": "https://api.github.com/users/makto/events{/privacy}", "followers_url": "https://api.github.com/users/makto/followers", "following_url": "https://api.github.com/users/makto/following{/other_user}", "gists_url": "https://api.github.com/users/makto/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/makto", "id": 1274612, "login": "makto", "node_id": "MDQ6VXNlcjEyNzQ2MTI=", "organizations_url": "https://api.github.com/users/makto/orgs", "received_events_url": "https://api.github.com/users/makto/received_events", "repos_url": "https://api.github.com/users/makto/repos", "site_admin": false, "starred_url": "https://api.github.com/users/makto/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/makto/subscriptions", "type": "User", "url": "https://api.github.com/users/makto", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-03-29T09:10:42Z
2021-09-09T04:00:44Z
2013-03-30T08:07:55Z
CONTRIBUTOR
resolved
Django: 1.4 Python: 2.7.3 How could this happened ? I didn't manually configure the Session object, nor edit the "max_redirects" attribute. Got no clue…… ``` Traceback: File "/usr/local/sae/python/3rd/django-1.4/django/core/handlers/base.py" in get_response 111. response = callback(request, *callback_args, **callback_kwargs) File "/usr/local/sae/python/3rd/django-1.4/django/contrib/admin/options.py" in wrapper 366. return self.admin_site.admin_view(view)(*args, **kwargs) File "/usr/local/sae/python/3rd/django-1.4/django/utils/decorators.py" in _wrapped_view 91. response = view_func(request, *args, **kwargs) File "/usr/local/sae/python/3rd/django-1.4/django/views/decorators/cache.py" in _wrapped_view_func 89. response = view_func(request, *args, **kwargs) File "/usr/local/sae/python/3rd/django-1.4/django/contrib/admin/sites.py" in inner 196. return view(request, *args, **kwargs) File "/usr/local/sae/python/3rd/django-1.4/django/utils/decorators.py" in _wrapper 25. return bound_func(*args, **kwargs) File "/usr/local/sae/python/3rd/django-1.4/django/utils/decorators.py" in _wrapped_view 91. response = view_func(request, *args, **kwargs) File "/usr/local/sae/python/3rd/django-1.4/django/utils/decorators.py" in bound_func 21. return func(self, *args2, **kwargs2) File "/usr/local/sae/python/3rd/django-1.4/django/contrib/admin/options.py" in changelist_view 1153. response = self.response_action(request, queryset=cl.get_query_set(request)) File "/usr/local/sae/python/3rd/django-1.4/django/contrib/admin/options.py" in response_action 908. response = func(self, request, queryset) File "/data1/www/htdocs/749/codinglabs/2/autosigner/admin.py" in resign 75. newlog = signer(log.user, log.tbname)[0] File "/data1/www/htdocs/749/codinglabs/2/autosigner/views.py" in signer 245. target = ss.get(TB_HOME, params={'kw':tbname}) File "/data1/www/htdocs/749/codinglabs/2/libs/requests/sessions.py" in get 333. return self.request('GET', url, **kwargs) File "/data1/www/htdocs/749/codinglabs/2/libs/requests/sessions.py" in request 318. resp = self.send(prep, **send_kwargs) File "/data1/www/htdocs/749/codinglabs/2/libs/requests/sessions.py" in send 431. history = [resp for resp in gen] if allow_redirects else [] File "/data1/www/htdocs/749/codinglabs/2/libs/requests/sessions.py" in resolve_redirects 100. if i >= self.max_redirects: Exception Type: AttributeError at /admin/autosigner/logger/ Exception Value: 'Session' object has no attribute 'max_redirects' ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1274612?v=4", "events_url": "https://api.github.com/users/makto/events{/privacy}", "followers_url": "https://api.github.com/users/makto/followers", "following_url": "https://api.github.com/users/makto/following{/other_user}", "gists_url": "https://api.github.com/users/makto/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/makto", "id": 1274612, "login": "makto", "node_id": "MDQ6VXNlcjEyNzQ2MTI=", "organizations_url": "https://api.github.com/users/makto/orgs", "received_events_url": "https://api.github.com/users/makto/received_events", "repos_url": "https://api.github.com/users/makto/repos", "site_admin": false, "starred_url": "https://api.github.com/users/makto/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/makto/subscriptions", "type": "User", "url": "https://api.github.com/users/makto", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1269/reactions" }
https://api.github.com/repos/psf/requests/issues/1269/timeline
null
completed
null
null
false
[ "Uh...it can't. If the session was instantiated properly, the `max_redirects` parameter must be set. Can I suggest you reinstall Requests in your environment?\n", "@Lukasa \n\nThank you for your reply :)\nSession object works well most of the time on my machine. This exception occurs only in rare cases.\nI don't ...
https://api.github.com/repos/psf/requests/issues/1268
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1268/labels{/name}
https://api.github.com/repos/psf/requests/issues/1268/comments
https://api.github.com/repos/psf/requests/issues/1268/events
https://github.com/psf/requests/pull/1268
12,563,060
MDExOlB1bGxSZXF1ZXN0NDg2MzM5Nw==
1,268
update vendored urllib3
{ "avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4", "events_url": "https://api.github.com/users/t-8ch/events{/privacy}", "followers_url": "https://api.github.com/users/t-8ch/followers", "following_url": "https://api.github.com/users/t-8ch/following{/other_user}", "gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/t-8ch", "id": 717901, "login": "t-8ch", "node_id": "MDQ6VXNlcjcxNzkwMQ==", "organizations_url": "https://api.github.com/users/t-8ch/orgs", "received_events_url": "https://api.github.com/users/t-8ch/received_events", "repos_url": "https://api.github.com/users/t-8ch/repos", "site_admin": false, "starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions", "type": "User", "url": "https://api.github.com/users/t-8ch", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-03-28T12:53:24Z
2021-09-08T23:08:31Z
2013-03-31T05:27:59Z
CONTRIBUTOR
resolved
Contains a workaround (fingerprint, random hostname verification) and a solution (pyOpenSSL) for SNI on python 2. Intended to be included in 1.2 (#1267)
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1268/reactions" }
https://api.github.com/repos/psf/requests/issues/1268/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1268.diff", "html_url": "https://github.com/psf/requests/pull/1268", "merged_at": "2013-03-31T05:27:59Z", "patch_url": "https://github.com/psf/requests/pull/1268.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1268" }
true
[ "+1\n", ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1267
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1267/labels{/name}
https://api.github.com/repos/psf/requests/issues/1267/comments
https://api.github.com/repos/psf/requests/issues/1267/events
https://github.com/psf/requests/pull/1267
12,547,541
MDExOlB1bGxSZXF1ZXN0NDg1NzM3Nw==
1,267
One last pull request before 1.2 ideally
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}...
null
6
2013-03-28T03:49:17Z
2021-09-08T19:00:59Z
2013-03-31T05:21:52Z
CONTRIBUTOR
resolved
This fixes a few issues once and for all and I updated the HISTORY for the 1.2 release to include all the big changes.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1267/reactions" }
https://api.github.com/repos/psf/requests/issues/1267/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1267.diff", "html_url": "https://github.com/psf/requests/pull/1267", "merged_at": "2013-03-31T05:21:52Z", "patch_url": "https://github.com/psf/requests/pull/1267.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1267" }
true
[ "@Lukasa if you have a chance, some code review would be great. Thanks\n", "Some of your additions split comments from the relevant code. \n", "Comments from the diff, otherwise I'm +1 on this PR. Gotta make sure the tests pass too. =)\n", "repoening for travis test\n", ":metal:\n", "I don't know how I mi...
https://api.github.com/repos/psf/requests/issues/1266
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1266/labels{/name}
https://api.github.com/repos/psf/requests/issues/1266/comments
https://api.github.com/repos/psf/requests/issues/1266/events
https://github.com/psf/requests/issues/1266
12,468,024
MDU6SXNzdWUxMjQ2ODAyNA==
1,266
How to upload binary file using PUT?
{ "avatar_url": "https://avatars.githubusercontent.com/u/742757?v=4", "events_url": "https://api.github.com/users/dabono/events{/privacy}", "followers_url": "https://api.github.com/users/dabono/followers", "following_url": "https://api.github.com/users/dabono/following{/other_user}", "gists_url": "https://api.github.com/users/dabono/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dabono", "id": 742757, "login": "dabono", "node_id": "MDQ6VXNlcjc0Mjc1Nw==", "organizations_url": "https://api.github.com/users/dabono/orgs", "received_events_url": "https://api.github.com/users/dabono/received_events", "repos_url": "https://api.github.com/users/dabono/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dabono/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dabono/subscriptions", "type": "User", "url": "https://api.github.com/users/dabono", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2013-03-26T19:52:09Z
2021-09-09T04:00:41Z
2013-04-01T18:30:34Z
NONE
resolved
Hi, I just started using requests recently - it's a big improvement over the urllib2 library! But I'm having some difficulty with uploading files and I hope somebody can help me figure it out. I'm trying to use a REST API where I need to upload a binary file to the server. The API uses https and Kerberos authentication (I'm also using the requests_kerberos package). With curl, I can do this: ``` curl --negotiate -u : -H "X-Codesigner-security-token: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" --upload-file <pathname> https://myservice.acme.com/api/v1/requests/24449/unsigned ``` Which results in this: ``` => Send header, 282 bytes (0x11a) 0000: PUT /api/v1/requests/24449/unsigned HTTP/1.1 002e: User-Agent: curl/7.21.6 (i386-pc-win32) libcurl/7.21.6 OpenSSL/0 006e: .9.8r zlib/1.2.5 0080: Host: myservice.acme.com 009d: Accept: */* 00aa: X-Codesigner-security-token: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx 00e9: Content-Length: 4560799 0102: Expect: 100-continue 0118: <= Recv header, 23 bytes (0x17) 0000: HTTP/1.1 100 Continue => Send data, 16384 bytes (0x4000) … => Send data, 16384 bytes (0x4000) … ``` With requests, I've tried using both streaming upload and chunked upload, but haven't been able to make them work. I'm using the latest master (commit c63472e328946f464ed9fa24c0fadd2890966c5b). Code snippet using chunked transfer: ``` def filegen(fo): yield fo.read(CHUNK_SIZE) def main(): session = requests.Session() session.auth = HTTPKerberosAuth() upload_headers = {'X-Codesigner-security-token': 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'} with open(pathname, 'rb') as infile: response = session.put(upload_url, headers=upload_headers, data=filegen(infile)) ``` This results in: ``` Request headers: { 'Accept-Encoding': 'gzip, deflate, compress', 'X-Codesigner-security-token': 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx', 'Accept': '*/*', 'User-Agent': 'python-requests/1.1.0 CPython/2.7.1 Windows/7', 'Transfer-Encoding': 'chunked', 'Authorization': 'Negotiate <blah>' } Response headers: { 'status': '500', 'content-length': '441', 'content-encoding': 'gzip', 'x-powered-by': 'Phusion Passenger (mod_rails/mod_rack) 3.0.11', 'vary': 'Accept-Encoding,User-Agent', 'connection': 'close', 'server': 'Server', 'x-runtime': '0.564621', 'date': 'Tue, 26 Mar 2013 18:29:44 GMT', 'content-type': 'text/html', 'www-authenticate': 'Negotiate <blah>' } ``` Using the streaming upload: ``` with open(pathname, 'rb') as infile: response = session.put(upload_url, headers=upload_headers, data=infile) ``` Results in: ``` Request headers:{ 'X-Codesigner-security-token': 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx', 'Content-Length': u'20319', 'Accept-Encoding': 'gzip, deflate, compress', 'Accept': '*/*', 'User-Agent': 'python-requests/1.1.0 CPython/2.7.1 Windows/7' } 2013-03-26 12:16:04,440 DEBUG "PUT /api/v1/requests/24539/unsigned HTTP/1.1" 401 401 Traceback (most recent call last): ... File "C:\Python27\lib\site-packages\requests-1.1.0-py2.7.egg\requests\sessions.py", line 376, in put return self.request('PUT', url, data=data, **kwargs) File "C:\Python27\lib\site-packages\requests-1.1.0-py2.7.egg\requests\sessions.py", line 321, in request resp = self.send(prep, **send_kwargs) File "C:\Python27\lib\site-packages\requests-1.1.0-py2.7.egg\requests\sessions.py", line 426, in send r = dispatch_hook('response', hooks, r, **kwargs) File "C:\Python27\lib\site-packages\requests-1.1.0-py2.7.egg\requests\hooks.py", line 41, in dispatch_hook _hook_data = hook(hook_data, **kwargs) File "build\bdist.win32\egg\requests_kerberos\kerberos_.py", line 236, in handle_response File "build\bdist.win32\egg\requests_kerberos\kerberos_.py", line 158, in handle_401 File "build\bdist.win32\egg\requests_kerberos\kerberos_.py", line 147, in authenticate_user File "C:\Python27\lib\site-packages\requests-1.1.0-py2.7.egg\requests\adapters.py", line 246, in send raise ConnectionError(e) requests.exceptions.ConnectionError: HTTPSConnectionPool(host='myservice.acme.com', port=443): Max retries exceeded with url: /api/v1/requests/24539/unsigned (Caused by <class 'socket.error'>: [Errno 10054] An existing connection was forcibly closed by the remote host) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1266/reactions" }
https://api.github.com/repos/psf/requests/issues/1266/timeline
null
completed
null
null
false
[ "This might actually be an issue with `requests_kerberos`. I completely forgot to push our latest version, which I'm about to do now. If you could upgrade after that and see if this persists, I would appreciate it.\n", "Cool, thanks! I'll pull the latest requests_kerberos after it's been pushed.\n\nI might also ...
https://api.github.com/repos/psf/requests/issues/1265
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1265/labels{/name}
https://api.github.com/repos/psf/requests/issues/1265/comments
https://api.github.com/repos/psf/requests/issues/1265/events
https://github.com/psf/requests/issues/1265
12,457,376
MDU6SXNzdWUxMjQ1NzM3Ng==
1,265
Seeing SSLError: [Errno 185090050] _ssl.c:340: error:0B084002:x509 certificate routines:X509_load_cert_crl_file:system lib
{ "avatar_url": "https://avatars.githubusercontent.com/u/594239?v=4", "events_url": "https://api.github.com/users/zopyx/events{/privacy}", "followers_url": "https://api.github.com/users/zopyx/followers", "following_url": "https://api.github.com/users/zopyx/following{/other_user}", "gists_url": "https://api.github.com/users/zopyx/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zopyx", "id": 594239, "login": "zopyx", "node_id": "MDQ6VXNlcjU5NDIzOQ==", "organizations_url": "https://api.github.com/users/zopyx/orgs", "received_events_url": "https://api.github.com/users/zopyx/received_events", "repos_url": "https://api.github.com/users/zopyx/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zopyx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zopyx/subscriptions", "type": "User", "url": "https://api.github.com/users/zopyx", "user_view_type": "public" }
[]
closed
true
null
[]
null
18
2013-03-26T16:29:28Z
2021-09-09T00:34:23Z
2013-04-26T08:20:58Z
NONE
resolved
I see a similar problem while running bandersnatcher on Ubuntu 10.04 LTS ``` bandersnatch==1.0dev cov-core==1.7 coverage==3.6 distribute==0.6.35 mercurial==2.5.2 mock==1.0.1 py==1.4.13 pytest==2.3.4 pytest-cov==1.6 requests==1.1.0 virtualenv==1.6.1 wsgiref==0.1.2 ``` ``` 2013-03-26 17:25:49,493 ERROR: Error syncing package: OpenCorePaste Traceback (most recent call last): File "/srv/pypi/lib/python2.7/site-packages/bandersnatch-1.0dev-py2.7.egg/bandersnatch/package.py", line 56, in sync self.sync_release_files() File "/srv/pypi/lib/python2.7/site-packages/bandersnatch-1.0dev-py2.7.egg/bandersnatch/package.py", line 74, in sync_release_files self.download_file(release_file['url'], release_file['md5_digest']) File "/srv/pypi/lib/python2.7/site-packages/bandersnatch-1.0dev-py2.7.egg/bandersnatch/package.py", line 137, in download_file r = requests.get(url, stream=True) File "/srv/pypi/lib/python2.7/site-packages/requests-1.1.0-py2.7.egg/requests/api.py", line 55, in get return request('get', url, **kwargs) File "/srv/pypi/lib/python2.7/site-packages/requests-1.1.0-py2.7.egg/requests/api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "/srv/pypi/lib/python2.7/site-packages/requests-1.1.0-py2.7.egg/requests/sessions.py", line 279, in request resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies) File "/srv/pypi/lib/python2.7/site-packages/requests-1.1.0-py2.7.egg/requests/sessions.py", line 374, in send r = adapter.send(request, **kwargs) File "/srv/pypi/lib/python2.7/site-packages/requests-1.1.0-py2.7.egg/requests/adapters.py", line 213, in send raise SSLError(e) SSLError: [Errno 185090050] _ssl.c:340: error:0B084002:x509 certificate routines:X509_load_cert_crl_file:system lib ``` The error happens with https downloads from PyPI.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1265/reactions" }
https://api.github.com/repos/psf/requests/issues/1265/timeline
null
completed
null
null
false
[ "Can you upgrade to 1.2.0 and report if this still happens?\n", "@zopyx could you also report on your version of openssl (`openssl version`).\n", "I'm very tempted to close this since @zopyx is unresponsive.\n", "Sorry but have you heard of the concept \"holiday\"?\n\n> openssl version\n> OpenSSL 0.9.8k 25 Ma...
https://api.github.com/repos/psf/requests/issues/1264
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1264/labels{/name}
https://api.github.com/repos/psf/requests/issues/1264/comments
https://api.github.com/repos/psf/requests/issues/1264/events
https://github.com/psf/requests/issues/1264
12,423,954
MDU6SXNzdWUxMjQyMzk1NA==
1,264
PROPFIND Method
{ "avatar_url": "https://avatars.githubusercontent.com/u/211847?v=4", "events_url": "https://api.github.com/users/randfb/events{/privacy}", "followers_url": "https://api.github.com/users/randfb/followers", "following_url": "https://api.github.com/users/randfb/following{/other_user}", "gists_url": "https://api.github.com/users/randfb/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/randfb", "id": 211847, "login": "randfb", "node_id": "MDQ6VXNlcjIxMTg0Nw==", "organizations_url": "https://api.github.com/users/randfb/orgs", "received_events_url": "https://api.github.com/users/randfb/received_events", "repos_url": "https://api.github.com/users/randfb/repos", "site_admin": false, "starred_url": "https://api.github.com/users/randfb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/randfb/subscriptions", "type": "User", "url": "https://api.github.com/users/randfb", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-25T21:32:26Z
2021-09-09T04:00:47Z
2013-03-25T21:34:23Z
NONE
resolved
How hard would it be to add a PROPFIND method ? I'd like to interface to a webdav server.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1264/reactions" }
https://api.github.com/repos/psf/requests/issues/1264/timeline
null
completed
null
null
false
[ "You'd need to plumb it through from [urllib3](https://github.com/shazow/urllib3). The 'right' thing to do is going to be to build a new Transport Adapter.\n" ]
https://api.github.com/repos/psf/requests/issues/1263
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1263/labels{/name}
https://api.github.com/repos/psf/requests/issues/1263/comments
https://api.github.com/repos/psf/requests/issues/1263/events
https://github.com/psf/requests/pull/1263
12,417,242
MDExOlB1bGxSZXF1ZXN0NDgwMTM1Mg==
1,263
iter_lines documentation for #1260
{ "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ghost", "id": 10137, "login": "ghost", "node_id": "MDQ6VXNlcjEwMTM3", "organizations_url": "https://api.github.com/users/ghost/orgs", "received_events_url": "https://api.github.com/users/ghost/received_events", "repos_url": "https://api.github.com/users/ghost/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "type": "User", "url": "https://api.github.com/users/ghost", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-25T19:25:41Z
2021-09-08T19:00:56Z
2013-03-25T19:48:45Z
NONE
resolved
I added a short note about the stream=True requirement to avoid loading the entire response all at once.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1263/reactions" }
https://api.github.com/repos/psf/requests/issues/1263/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1263.diff", "html_url": "https://github.com/psf/requests/pull/1263", "merged_at": "2013-03-25T19:48:45Z", "patch_url": "https://github.com/psf/requests/pull/1263.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1263" }
true
[ ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1262
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1262/labels{/name}
https://api.github.com/repos/psf/requests/issues/1262/comments
https://api.github.com/repos/psf/requests/issues/1262/events
https://github.com/psf/requests/issues/1262
12,369,198
MDU6SXNzdWUxMjM2OTE5OA==
1,262
Getting cookies doesn't work in some cases
{ "avatar_url": "https://avatars.githubusercontent.com/u/3953504?v=4", "events_url": "https://api.github.com/users/BugReporter2013/events{/privacy}", "followers_url": "https://api.github.com/users/BugReporter2013/followers", "following_url": "https://api.github.com/users/BugReporter2013/following{/other_user}", "gists_url": "https://api.github.com/users/BugReporter2013/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/BugReporter2013", "id": 3953504, "login": "BugReporter2013", "node_id": "MDQ6VXNlcjM5NTM1MDQ=", "organizations_url": "https://api.github.com/users/BugReporter2013/orgs", "received_events_url": "https://api.github.com/users/BugReporter2013/received_events", "repos_url": "https://api.github.com/users/BugReporter2013/repos", "site_admin": false, "starred_url": "https://api.github.com/users/BugReporter2013/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BugReporter2013/subscriptions", "type": "User", "url": "https://api.github.com/users/BugReporter2013", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-03-24T03:50:14Z
2021-09-09T04:00:47Z
2013-03-24T12:37:20Z
NONE
resolved
Steps to reproduce: ``` import requests from pyquery import PyQuery def obtainCookies(username, password): tokenUrl = 'https://news.ycombinator.com/newslogin' loginUrl = 'https://news.ycombinator.com/y' query = PyQuery(requests.get(tokenUrl).content) token = query('input[name="fnid"]').val() payload = { 'fnid' : token, 'u' : username, 'p' : password } return requests.post(loginUrl, data=payload).cookies print len(obtainCookies('some_user', 'some_password')) ``` This code will return 0, yet the cookie is clearly being sent (can be seen in Chrome dev tools) AND the login is successful. Why is this broken?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1262/reactions" }
https://api.github.com/repos/psf/requests/issues/1262/timeline
null
completed
null
null
false
[ "Chrome dev tools can only see requests made from inside Chrome, which means you don't know that the cookie is being returned in this case. Wireshark can tell you that. Could you check with Wireshark to see if the cookie is actually being returned?\n", "How would you suggest to do that, given that the connection ...
https://api.github.com/repos/psf/requests/issues/1261
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1261/labels{/name}
https://api.github.com/repos/psf/requests/issues/1261/comments
https://api.github.com/repos/psf/requests/issues/1261/events
https://github.com/psf/requests/issues/1261
12,347,152
MDU6SXNzdWUxMjM0NzE1Mg==
1,261
Issue arising from #1190
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" } ]
closed
true
null
[]
null
11
2013-03-23T01:21:55Z
2021-09-09T04:00:46Z
2013-03-27T18:31:37Z
CONTRIBUTOR
resolved
The tests caught this purely by coincidence with #1259. The issue is that we're now passing optional keyword arguments and typical hooks don't expect them causing exceptions to be raised. In essence, this is a big breaking change and we will have to make it very clear to users that this is in the next version. requests/requests-kerberos depends on this but this is going to break a good amount of people's code. Admittedly it only rears its head when we try and set the defaults via `kwargs` in `Session.send`. Again that's due to #1259/#1258 but @geoff-kruss is right in asserting that those defaults should be passed. Assuming we keep the addition that causes this, we need a plan how to announce it.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1261/reactions" }
https://api.github.com/repos/psf/requests/issues/1261/timeline
null
completed
null
null
false
[ "So I'm personally in favor of keeping the existing behaviour and trying to make it as clear as possible to users that the behaviour has been changed.\n\nAlso, I forgot to include @mkomitee in on this ticket.\n", "If I understand this correctly, we would have to _at minimum_ move from 1.1.0 to 1.2 to accomodate t...
https://api.github.com/repos/psf/requests/issues/1260
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1260/labels{/name}
https://api.github.com/repos/psf/requests/issues/1260/comments
https://api.github.com/repos/psf/requests/issues/1260/events
https://github.com/psf/requests/issues/1260
12,345,239
MDU6SXNzdWUxMjM0NTIzOQ==
1,260
Documentation for iter_lines doesn't indicate stream=True is required
{ "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ghost", "id": 10137, "login": "ghost", "node_id": "MDQ6VXNlcjEwMTM3", "organizations_url": "https://api.github.com/users/ghost/orgs", "received_events_url": "https://api.github.com/users/ghost/received_events", "repos_url": "https://api.github.com/users/ghost/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "type": "User", "url": "https://api.github.com/users/ghost", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-03-23T00:04:12Z
2021-09-09T04:00:46Z
2013-03-25T21:35:30Z
NONE
resolved
This is the current description of `iter_lines`: > Iterates over the response data, one line at a time. This avoids reading the content at once into memory for large responses. The "avoids reading the content at once into memory" part seems to imply that this has streaming behavior, but that's not currently the case without specifying stream=True on the request. Maybe this is just a reading comprehension fail on my part, but it took longer than I would have liked to get the desired behavior.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1260/reactions" }
https://api.github.com/repos/psf/requests/issues/1260/timeline
null
completed
null
null
false
[ "Feel free to submit a pull request to make it more explicit. We'll be happy to accept it.\n", "Here's the pull request: https://github.com/kennethreitz/requests/pull/1263\n\nThanks for the quick response!\n" ]
https://api.github.com/repos/psf/requests/issues/1259
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1259/labels{/name}
https://api.github.com/repos/psf/requests/issues/1259/comments
https://api.github.com/repos/psf/requests/issues/1259/events
https://github.com/psf/requests/pull/1259
12,339,961
MDExOlB1bGxSZXF1ZXN0NDc3MzMwOA==
1,259
Adding default kwargs in Session.send. Fixes #1258
{ "avatar_url": "https://avatars.githubusercontent.com/u/208034?v=4", "events_url": "https://api.github.com/users/geoff-kruss/events{/privacy}", "followers_url": "https://api.github.com/users/geoff-kruss/followers", "following_url": "https://api.github.com/users/geoff-kruss/following{/other_user}", "gists_url": "https://api.github.com/users/geoff-kruss/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/geoff-kruss", "id": 208034, "login": "geoff-kruss", "node_id": "MDQ6VXNlcjIwODAzNA==", "organizations_url": "https://api.github.com/users/geoff-kruss/orgs", "received_events_url": "https://api.github.com/users/geoff-kruss/received_events", "repos_url": "https://api.github.com/users/geoff-kruss/repos", "site_admin": false, "starred_url": "https://api.github.com/users/geoff-kruss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/geoff-kruss/subscriptions", "type": "User", "url": "https://api.github.com/users/geoff-kruss", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-03-22T21:58:17Z
2021-09-08T19:00:57Z
2013-03-22T22:24:16Z
NONE
resolved
This ensures that the proper defaults are passed along to the associated adapters send() method. As per the related issue - class attributes previously set on the Session object are not being properly passed along to the adapter when calling Session.send()
{ "avatar_url": "https://avatars.githubusercontent.com/u/208034?v=4", "events_url": "https://api.github.com/users/geoff-kruss/events{/privacy}", "followers_url": "https://api.github.com/users/geoff-kruss/followers", "following_url": "https://api.github.com/users/geoff-kruss/following{/other_user}", "gists_url": "https://api.github.com/users/geoff-kruss/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/geoff-kruss", "id": 208034, "login": "geoff-kruss", "node_id": "MDQ6VXNlcjIwODAzNA==", "organizations_url": "https://api.github.com/users/geoff-kruss/orgs", "received_events_url": "https://api.github.com/users/geoff-kruss/received_events", "repos_url": "https://api.github.com/users/geoff-kruss/repos", "site_admin": false, "starred_url": "https://api.github.com/users/geoff-kruss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/geoff-kruss/subscriptions", "type": "User", "url": "https://api.github.com/users/geoff-kruss", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1259/reactions" }
https://api.github.com/repos/psf/requests/issues/1259/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1259.diff", "html_url": "https://github.com/psf/requests/pull/1259", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1259.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1259" }
true
[ "Nope - this doesn't work. On running the unit tests I see now that hook() lands up with an unexpected keyword argument\n", "It gets an unexpected keyword argument unrelated to your change.\n", "Scratch that, thought you'd only added the proxies argument as a default.\n" ]
https://api.github.com/repos/psf/requests/issues/1258
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1258/labels{/name}
https://api.github.com/repos/psf/requests/issues/1258/comments
https://api.github.com/repos/psf/requests/issues/1258/events
https://github.com/psf/requests/issues/1258
12,338,339
MDU6SXNzdWUxMjMzODMzOQ==
1,258
Should Session.send() ignore Session.proxies?
{ "avatar_url": "https://avatars.githubusercontent.com/u/208034?v=4", "events_url": "https://api.github.com/users/geoff-kruss/events{/privacy}", "followers_url": "https://api.github.com/users/geoff-kruss/followers", "following_url": "https://api.github.com/users/geoff-kruss/following{/other_user}", "gists_url": "https://api.github.com/users/geoff-kruss/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/geoff-kruss", "id": 208034, "login": "geoff-kruss", "node_id": "MDQ6VXNlcjIwODAzNA==", "organizations_url": "https://api.github.com/users/geoff-kruss/orgs", "received_events_url": "https://api.github.com/users/geoff-kruss/received_events", "repos_url": "https://api.github.com/users/geoff-kruss/repos", "site_admin": false, "starred_url": "https://api.github.com/users/geoff-kruss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/geoff-kruss/subscriptions", "type": "User", "url": "https://api.github.com/users/geoff-kruss", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2013-03-22T21:21:15Z
2021-09-09T04:00:43Z
2013-03-31T05:21:52Z
NONE
resolved
My test code: ``` python import requests s = requests.Session() s.proxies = {'http': 'myproxy:3128'} r = requests.Request(method='GET', url='http://www.google.com') s.send(r.prepare()) ``` In the above case, the proxy is ignored completely. It looks to me like in Session.request() the following code is run: ``` python proxies = merge_kwargs(proxies, self.proxies) ``` But in the send() function this is not happening. I am not sure if this is a bug - or if always passing proxies to the send() function explicitly is the intended behavior. I am relatively new in using the requests library - my apologies if this has been brought up before or if i'm missing something obvious.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1258/reactions" }
https://api.github.com/repos/psf/requests/issues/1258/timeline
null
completed
null
null
false
[ "That should be a simple one line fix using `setdefault` on the arguments to send\n", "@sigmavirus24 something like the following:\n\n``` python\n def send(self, request, **kwargs):\n \"\"\"Send a given PreparedRequest.\"\"\"\n adapter = self.get_adapter(url=request.url)\n\n kwargs.setdefault...
https://api.github.com/repos/psf/requests/issues/1257
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1257/labels{/name}
https://api.github.com/repos/psf/requests/issues/1257/comments
https://api.github.com/repos/psf/requests/issues/1257/events
https://github.com/psf/requests/issues/1257
12,323,000
MDU6SXNzdWUxMjMyMzAwMA==
1,257
Give hooks a way to retry requests in the same session.
{ "avatar_url": "https://avatars.githubusercontent.com/u/17239?v=4", "events_url": "https://api.github.com/users/avallee/events{/privacy}", "followers_url": "https://api.github.com/users/avallee/followers", "following_url": "https://api.github.com/users/avallee/following{/other_user}", "gists_url": "https://api.github.com/users/avallee/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/avallee", "id": 17239, "login": "avallee", "node_id": "MDQ6VXNlcjE3MjM5", "organizations_url": "https://api.github.com/users/avallee/orgs", "received_events_url": "https://api.github.com/users/avallee/received_events", "repos_url": "https://api.github.com/users/avallee/repos", "site_admin": false, "starred_url": "https://api.github.com/users/avallee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/avallee/subscriptions", "type": "User", "url": "https://api.github.com/users/avallee", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-03-22T15:09:44Z
2021-09-09T04:00:43Z
2013-03-30T00:16:11Z
NONE
resolved
I am talking to an app with a custom auth module that I've written. The auth object installs a hook, and if the response fails and indicates that the auth object is expired, I get a new auth object. I'd like to be able to retry the exact same request with the same settings as the previous request but with a new auth object from my response hook. This means I'd like to be able to make the request as part of the same session (ideally) but to also have access to the initial request parameters such as verify.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1257/reactions" }
https://api.github.com/repos/psf/requests/issues/1257/timeline
null
completed
null
null
false
[ "This is a duplicate of the PR #1190 which was merged. We really have to cut a new release. If that PR suits your needs (which I suspect it does), feel free to close this. I don't want to close it preemptively.\n", "Also related, #1261\n", "Closing due to no response\n", "Yeah, no problem. Looks like #1190 wi...
https://api.github.com/repos/psf/requests/issues/1256
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1256/labels{/name}
https://api.github.com/repos/psf/requests/issues/1256/comments
https://api.github.com/repos/psf/requests/issues/1256/events
https://github.com/psf/requests/pull/1256
12,314,397
MDExOlB1bGxSZXF1ZXN0NDc1OTc3OQ==
1,256
Allowing @ in proxy passwords and usernames.
{ "avatar_url": "https://avatars.githubusercontent.com/u/3275593?v=4", "events_url": "https://api.github.com/users/pradyunsg/events{/privacy}", "followers_url": "https://api.github.com/users/pradyunsg/followers", "following_url": "https://api.github.com/users/pradyunsg/following{/other_user}", "gists_url": "https://api.github.com/users/pradyunsg/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pradyunsg", "id": 3275593, "login": "pradyunsg", "node_id": "MDQ6VXNlcjMyNzU1OTM=", "organizations_url": "https://api.github.com/users/pradyunsg/orgs", "received_events_url": "https://api.github.com/users/pradyunsg/received_events", "repos_url": "https://api.github.com/users/pradyunsg/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pradyunsg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pradyunsg/subscriptions", "type": "User", "url": "https://api.github.com/users/pradyunsg", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-03-22T10:56:34Z
2021-09-08T19:00:56Z
2013-03-22T10:58:49Z
CONTRIBUTOR
resolved
Well, I don't have much to say, except that, the change that I made, is to allow for @ in the passwords when someone is using a proxy (like me!). Someone may change it to be more readable. Test script: ``` python import requests proxy = {'http':'http://test:test@123@myproxy.com:80'} # imaginary proxy, I used a real one in my case print requests.get('http://google.com', proxies=proxy) ``` Before: ``` python Traceback (most recent call last): File "<pyshell#2>", line 1, in <module> requests.get('http://google.com', proxies=proxy) File "C:\Python2.7 For Chintoo\lib\site-packages\requests-1.1.0-py2.7.egg\requests\api.py", line 55, in get return request('get', url, **kwargs) File "C:\Python2.7 For Chintoo\lib\site-packages\requests-1.1.0-py2.7.egg\requests\api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "C:\Python2.7 For Chintoo\lib\site-packages\requests-1.1.0-py2.7.egg\requests\sessions.py", line 279, in request resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies) File "C:\Python2.7 For Chintoo\lib\site-packages\requests-1.1.0-py2.7.egg\requests\sessions.py", line 374, in send r = adapter.send(request, **kwargs) File "C:\Python2.7 For Chintoo\lib\site-packages\requests-1.1.0-py2.7.egg\requests\adapters.py", line 209, in send raise ConnectionError(e) ConnectionError: HTTPConnectionPool(host='123@netmon.iitb.ac.in', port=None): Max retries exceeded with url: http://google.com/ (Caused by <class 'socket.gaierror'>: [Errno 11003] getaddrinfo failed) ``` Now: ``` python <Response [407]> ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1256/reactions" }
https://api.github.com/repos/psf/requests/issues/1256/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1256.diff", "html_url": "https://github.com/psf/requests/pull/1256", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1256.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1256" }
true
[ "This change has been made in urllib3, not in Requests. We vendor in a copy of urllib3 that we keep in sync with the upstream version, so any change in urllib3 should be made [there](https://github.com/shazow/urllib3).\n\nThanks for creating the PR though!\n", "@LukaTes just saw that, I was going to delete this r...
https://api.github.com/repos/psf/requests/issues/1255
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1255/labels{/name}
https://api.github.com/repos/psf/requests/issues/1255/comments
https://api.github.com/repos/psf/requests/issues/1255/events
https://github.com/psf/requests/issues/1255
12,303,936
MDU6SXNzdWUxMjMwMzkzNg==
1,255
"Pushable" streaming upload requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/347571?v=4", "events_url": "https://api.github.com/users/naftulikay/events{/privacy}", "followers_url": "https://api.github.com/users/naftulikay/followers", "following_url": "https://api.github.com/users/naftulikay/following{/other_user}", "gists_url": "https://api.github.com/users/naftulikay/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/naftulikay", "id": 347571, "login": "naftulikay", "node_id": "MDQ6VXNlcjM0NzU3MQ==", "organizations_url": "https://api.github.com/users/naftulikay/orgs", "received_events_url": "https://api.github.com/users/naftulikay/received_events", "repos_url": "https://api.github.com/users/naftulikay/repos", "site_admin": false, "starred_url": "https://api.github.com/users/naftulikay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/naftulikay/subscriptions", "type": "User", "url": "https://api.github.com/users/naftulikay", "user_view_type": "public" }
[]
closed
true
null
[]
null
10
2013-03-22T01:54:12Z
2021-09-09T04:00:45Z
2013-03-28T03:47:39Z
NONE
resolved
I have an interesting situation which doesn't seem to be covered by the `requests` API. For a project I'm working on, I have a server which receives a multipart upload from a user in chunks in a handler which looks and works something like this: ``` class MyUploadHandler(BaseUploadHandler): def on_file_started(self, file_name): pass def on_file_chunk(self, chunk): pass def on_file_finished(self, file_size): pass ``` What I'd like to do is something like this: ``` import requests class MyUploadHandler(BaseUploadHandler): def on_file_started(self, file_name): self.request = requests.put("http://secondary.com/upload/url", stream=True) def on_file_chunk(self, chunk): self.request.raw.write(chunk) def on_file_finished(self, file_size): self.request.finish() ``` It seems that this is currently not possible in the API, though I could be wrong. If I have to rewrite my code to incorporate a [file-like object](http://docs.python-requests.org/en/latest/user/advanced/#streaming-uploads) or a [generator](http://docs.python-requests.org/en/latest/user/advanced/#chunk-encoded-requests), I'd probably have to get my hands dirty with threading and this would make everything 1,000,000 times harder in my application than they should be. Is what I'm talking about currently possible in `requests`, and if not, can the feature be easily added?
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1255/reactions" }
https://api.github.com/repos/psf/requests/issues/1255/timeline
null
completed
null
null
false
[ "**tl;dr** It can not be easily added as far as I know and likely won't be considered by Kenneth given we're in a feature freeze.\n\nSomething about the API you show in the second snippet is oddly attractive but not at all what is within the realm of possibility for requests. I think a generator is your best bet in...
https://api.github.com/repos/psf/requests/issues/1254
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1254/labels{/name}
https://api.github.com/repos/psf/requests/issues/1254/comments
https://api.github.com/repos/psf/requests/issues/1254/events
https://github.com/psf/requests/pull/1254
12,302,508
MDExOlB1bGxSZXF1ZXN0NDc1NDAxMg==
1,254
url-authentication
{ "avatar_url": "https://avatars.githubusercontent.com/u/563398?v=4", "events_url": "https://api.github.com/users/jkakar/events{/privacy}", "followers_url": "https://api.github.com/users/jkakar/followers", "following_url": "https://api.github.com/users/jkakar/following{/other_user}", "gists_url": "https://api.github.com/users/jkakar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jkakar", "id": 563398, "login": "jkakar", "node_id": "MDQ6VXNlcjU2MzM5OA==", "organizations_url": "https://api.github.com/users/jkakar/orgs", "received_events_url": "https://api.github.com/users/jkakar/received_events", "repos_url": "https://api.github.com/users/jkakar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jkakar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jkakar/subscriptions", "type": "User", "url": "https://api.github.com/users/jkakar", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-22T00:57:54Z
2021-09-08T19:00:55Z
2013-03-22T04:06:23Z
CONTRIBUTOR
resolved
- When credentials are included in a URL they are extracted and passed to the server using HTTP Basic Auth. I've tested this by hand and it works. I'm not quite sure how I should test this in `test_requests.py`. I would normally mock this kind of thing, since I don't have a persistent service that requires credentials running to use from a test, which seems to be the existing pattern. I'm reluctant to add a dependency on a mocking library and jump through all those hoops if that technique is not already used.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1254/reactions" }
https://api.github.com/repos/psf/requests/issues/1254/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1254.diff", "html_url": "https://github.com/psf/requests/pull/1254", "merged_at": "2013-03-22T04:06:23Z", "patch_url": "https://github.com/psf/requests/pull/1254.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1254" }
true
[ ":sparkles: :cake: :sparkles:\n" ]
https://api.github.com/repos/psf/requests/issues/1253
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1253/labels{/name}
https://api.github.com/repos/psf/requests/issues/1253/comments
https://api.github.com/repos/psf/requests/issues/1253/events
https://github.com/psf/requests/pull/1253
12,292,052
MDExOlB1bGxSZXF1ZXN0NDc0ODUwMA==
1,253
Attach original Request object to Response object.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1479351?v=4", "events_url": "https://api.github.com/users/markgollnick-wf/events{/privacy}", "followers_url": "https://api.github.com/users/markgollnick-wf/followers", "following_url": "https://api.github.com/users/markgollnick-wf/following{/other_user}", "gists_url": "https://api.github.com/users/markgollnick-wf/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/markgollnick-wf", "id": 1479351, "login": "markgollnick-wf", "node_id": "MDQ6VXNlcjE0NzkzNTE=", "organizations_url": "https://api.github.com/users/markgollnick-wf/orgs", "received_events_url": "https://api.github.com/users/markgollnick-wf/received_events", "repos_url": "https://api.github.com/users/markgollnick-wf/repos", "site_admin": false, "starred_url": "https://api.github.com/users/markgollnick-wf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/markgollnick-wf/subscriptions", "type": "User", "url": "https://api.github.com/users/markgollnick-wf", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-03-21T19:54:26Z
2021-09-08T19:00:56Z
2013-03-21T20:42:40Z
NONE
resolved
Allows for quickly creating Requests similar to those already made, or for examining Request object manipulation by third party hooks or authentication methods. This is particularly useful when using requests with something like oauthlib: https://github.com/requests/requests-oauthlib There appeared to be an instance of the original request object passed along as far as `Session.send()`, but it was never used after that. So, I grabbed it and attached it to the Response object.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1479351?v=4", "events_url": "https://api.github.com/users/markgollnick-wf/events{/privacy}", "followers_url": "https://api.github.com/users/markgollnick-wf/followers", "following_url": "https://api.github.com/users/markgollnick-wf/following{/other_user}", "gists_url": "https://api.github.com/users/markgollnick-wf/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/markgollnick-wf", "id": 1479351, "login": "markgollnick-wf", "node_id": "MDQ6VXNlcjE0NzkzNTE=", "organizations_url": "https://api.github.com/users/markgollnick-wf/orgs", "received_events_url": "https://api.github.com/users/markgollnick-wf/received_events", "repos_url": "https://api.github.com/users/markgollnick-wf/repos", "site_admin": false, "starred_url": "https://api.github.com/users/markgollnick-wf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/markgollnick-wf/subscriptions", "type": "User", "url": "https://api.github.com/users/markgollnick-wf", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1253/reactions" }
https://api.github.com/repos/psf/requests/issues/1253/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1253.diff", "html_url": "https://github.com/psf/requests/pull/1253", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1253.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1253" }
true
[ "First off, thanks for the contribution :)\n\nThat being said: Request objects are only for creating PreparedRequest objects, and shouldn't be used in this way.\n", "That's the idea; use the returned Request object to create a PreparedRequest object, and issue a second request using a new or an existing Session. ...
https://api.github.com/repos/psf/requests/issues/1252
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1252/labels{/name}
https://api.github.com/repos/psf/requests/issues/1252/comments
https://api.github.com/repos/psf/requests/issues/1252/events
https://github.com/psf/requests/issues/1252
12,252,455
MDU6SXNzdWUxMjI1MjQ1NQ==
1,252
UnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 169: ordinal not in range(128)
{ "avatar_url": "https://avatars.githubusercontent.com/u/352270?v=4", "events_url": "https://api.github.com/users/michaelhelmick/events{/privacy}", "followers_url": "https://api.github.com/users/michaelhelmick/followers", "following_url": "https://api.github.com/users/michaelhelmick/following{/other_user}", "gists_url": "https://api.github.com/users/michaelhelmick/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/michaelhelmick", "id": 352270, "login": "michaelhelmick", "node_id": "MDQ6VXNlcjM1MjI3MA==", "organizations_url": "https://api.github.com/users/michaelhelmick/orgs", "received_events_url": "https://api.github.com/users/michaelhelmick/received_events", "repos_url": "https://api.github.com/users/michaelhelmick/repos", "site_admin": false, "starred_url": "https://api.github.com/users/michaelhelmick/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/michaelhelmick/subscriptions", "type": "User", "url": "https://api.github.com/users/michaelhelmick", "user_view_type": "public" }
[]
closed
true
null
[]
null
50
2013-03-20T22:48:10Z
2021-09-08T11:00:35Z
2013-05-29T08:02:53Z
NONE
resolved
Something similar has been posted before: https://github.com/kennethreitz/requests/issues/403 This is using `requests 1.1.0` But this problem is still popping up while trying to post _just_ a file _and_ a file with data. On top of the similar issue, I've posted about this before and in `requests_oauthlib` it has said to been fixed; If you wish, I'll try and find the issue in that lib, just too lazy to open a new tab now ;P Error: ``` Traceback (most recent call last): File "/Users/mikehelmick/.virtualenv/twython/lib/python2.7/site-packages/requests/sessions.py", line 340, in post return self.request('POST', url, data=data, **kwargs) File "/Users/mikehelmick/.virtualenv/twython/lib/python2.7/site-packages/requests/sessions.py", line 279, in request resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies) File "/Users/mikehelmick/.virtualenv/twython/lib/python2.7/site-packages/requests/sessions.py", line 374, in send r = adapter.send(request, **kwargs) File "/Users/mikehelmick/.virtualenv/twython/lib/python2.7/site-packages/requests/adapters.py", line 174, in send timeout=timeout File "/Users/mikehelmick/.virtualenv/twython/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 422, in urlopen body=body, headers=headers) File "/Users/mikehelmick/.virtualenv/twython/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 274, in _make_request conn.request(method, url, **httplib_request_kw) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 955, in request self._send_request(method, url, body, headers) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 989, in _send_request self.endheaders(body) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 951, in endheaders self._send_output(message_body) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 809, in _send_output msg += message_body UnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 169: ordinal not in range(128) ``` I posted a gist with sample code if any of you needed to test it. If you guys are really being lazy, I can post some app/user tokens for you to use (let me know). Gist: https://gist.github.com/michaelhelmick/5199754
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 1, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 1, "url": "https://api.github.com/repos/psf/requests/issues/1252/reactions" }
https://api.github.com/repos/psf/requests/issues/1252/timeline
null
completed
null
null
false
[ "So here's my first guess (but I'll obviously look into this more): I think that OAuth1 might be generating unicode and opening the file in binary form will cause this issue due to how httplib sends the message body. Also this may be related to #1250.\n\n@Lukasa, opinions?\n", "That seems like a reasonable diagno...
https://api.github.com/repos/psf/requests/issues/1251
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1251/labels{/name}
https://api.github.com/repos/psf/requests/issues/1251/comments
https://api.github.com/repos/psf/requests/issues/1251/events
https://github.com/psf/requests/issues/1251
12,250,982
MDU6SXNzdWUxMjI1MDk4Mg==
1,251
Documentation doesn't mention Session.request
{ "avatar_url": "https://avatars.githubusercontent.com/u/1095956?v=4", "events_url": "https://api.github.com/users/lastquestion/events{/privacy}", "followers_url": "https://api.github.com/users/lastquestion/followers", "following_url": "https://api.github.com/users/lastquestion/following{/other_user}", "gists_url": "https://api.github.com/users/lastquestion/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/lastquestion", "id": 1095956, "login": "lastquestion", "node_id": "MDQ6VXNlcjEwOTU5NTY=", "organizations_url": "https://api.github.com/users/lastquestion/orgs", "received_events_url": "https://api.github.com/users/lastquestion/received_events", "repos_url": "https://api.github.com/users/lastquestion/repos", "site_admin": false, "starred_url": "https://api.github.com/users/lastquestion/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lastquestion/subscriptions", "type": "User", "url": "https://api.github.com/users/lastquestion", "user_view_type": "public" }
[ { "color": "0b02e1", "default": false, "description": null, "id": 191274, "name": "Contributor Friendly", "node_id": "MDU6TGFiZWwxOTEyNzQ=", "url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly" } ]
closed
true
null
[]
null
2
2013-03-20T22:07:10Z
2021-09-09T04:00:43Z
2013-03-31T05:21:52Z
NONE
resolved
Neither http://docs.python-requests.org/en/latest/user/advanced/#session-objects or http://docs.python-requests.org/en/latest/api/#request-sessions talks about Session.request - which I only found once I cloned the source locally. Originally I was using session.send(preparedRequest) which wasn't persisting cookies or headers. I thought this was a bug / weird issue so I cloned the source and that's when I saw Session.request. It would be good to clarify the intent of .request versus .send in regards to cookie persistence, headers, etc. etc. Happy to put together a pull request to update the docs.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1251/reactions" }
https://api.github.com/repos/psf/requests/issues/1251/timeline
null
completed
null
null
false
[ "Hm, just noticed https://github.com/kennethreitz/requests/issues/1201\nI'm using the latest sources, maybe the docs haven't been updated? \n", "Cookie persistence is no longer an issue. That has been fixed in master, so if you're still seeing that issue, let us know. I'm, baffled though that Session#request was ...
https://api.github.com/repos/psf/requests/issues/1250
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1250/labels{/name}
https://api.github.com/repos/psf/requests/issues/1250/comments
https://api.github.com/repos/psf/requests/issues/1250/events
https://github.com/psf/requests/issues/1250
12,216,745
MDU6SXNzdWUxMjIxNjc0NQ==
1,250
'PreparedRequest.headers' keys are a mixture of bytes and (unicode) strings in Python 3.x
{ "avatar_url": "https://avatars.githubusercontent.com/u/305618?v=4", "events_url": "https://api.github.com/users/paparomeo/events{/privacy}", "followers_url": "https://api.github.com/users/paparomeo/followers", "following_url": "https://api.github.com/users/paparomeo/following{/other_user}", "gists_url": "https://api.github.com/users/paparomeo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/paparomeo", "id": 305618, "login": "paparomeo", "node_id": "MDQ6VXNlcjMwNTYxOA==", "organizations_url": "https://api.github.com/users/paparomeo/orgs", "received_events_url": "https://api.github.com/users/paparomeo/received_events", "repos_url": "https://api.github.com/users/paparomeo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/paparomeo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paparomeo/subscriptions", "type": "User", "url": "https://api.github.com/users/paparomeo", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-03-20T08:16:20Z
2021-09-09T00:01:01Z
2013-06-08T08:07:33Z
NONE
resolved
In Python 3.x `PreparedRequest.headers` keys end up being a mixture of byte strings and unicode strings, because in [`PreparedRequest.prepared_headers`](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L326) the headers received from the user are byte encoded but later code in the request preparation (e.g. [`PreparedRequest.prepare_body`](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L331)) will add or modify unicode string keys. The problem is visible, for example, when the user tries to create a `PreparedRequest` with a given content type with the `'Content-Type'` key as a unicode string, which then in [`PreparedRequest.prepare_body`](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L383) is ignored and a default `Content-Type` header added because the key already in `headers` is a byte string, but a unicode string literal is being used for the existence test. I tried to use always unicode strings or always byte strings, for the header keys, but that caused unit tests to fail either on Python 2.x or Python 3.x, so clearly a better thought solution is required.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1250/reactions" }
https://api.github.com/repos/psf/requests/issues/1250/timeline
null
completed
null
null
false
[ "Yes, I've wondered about this before. I might work on a PR that has Requests take control of encoding and decoding strings, though it might end up being sufficiently complex that Kenneth won't want to merge it. =)\n", "#1338 is the most recent pull request that should address this issue, I'm going to close this ...
https://api.github.com/repos/psf/requests/issues/1249
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1249/labels{/name}
https://api.github.com/repos/psf/requests/issues/1249/comments
https://api.github.com/repos/psf/requests/issues/1249/events
https://github.com/psf/requests/issues/1249
12,179,200
MDU6SXNzdWUxMjE3OTIwMA==
1,249
stream_decompress corrupts output in case of decompress error
{ "avatar_url": "https://avatars.githubusercontent.com/u/238652?v=4", "events_url": "https://api.github.com/users/schlamar/events{/privacy}", "followers_url": "https://api.github.com/users/schlamar/followers", "following_url": "https://api.github.com/users/schlamar/following{/other_user}", "gists_url": "https://api.github.com/users/schlamar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/schlamar", "id": 238652, "login": "schlamar", "node_id": "MDQ6VXNlcjIzODY1Mg==", "organizations_url": "https://api.github.com/users/schlamar/orgs", "received_events_url": "https://api.github.com/users/schlamar/received_events", "repos_url": "https://api.github.com/users/schlamar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/schlamar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/schlamar/subscriptions", "type": "User", "url": "https://api.github.com/users/schlamar", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-03-19T13:11:24Z
2021-09-09T00:09:55Z
2013-04-14T16:13:03Z
CONTRIBUTOR
resolved
A `zlib.Decompress` object consumes at least one byte without raising an error and without returning any output: ``` >>> zlib_mode = 16 + zlib.MAX_WBITS >>> any(zlib.decompressobj(zlib_mode).decompress(chr(i)) for i in xrange(256)) False ``` So if there is an zlib.error in `stream_decompress`, there will be at least one byte missing in the output string. Additionally, there are two variations of the deflate compression in urllib3, while requests is only handling one of them: https://github.com/shazow/urllib3/blob/master/urllib3/response.py#L25
{ "avatar_url": "https://avatars.githubusercontent.com/u/238652?v=4", "events_url": "https://api.github.com/users/schlamar/events{/privacy}", "followers_url": "https://api.github.com/users/schlamar/followers", "following_url": "https://api.github.com/users/schlamar/following{/other_user}", "gists_url": "https://api.github.com/users/schlamar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/schlamar", "id": 238652, "login": "schlamar", "node_id": "MDQ6VXNlcjIzODY1Mg==", "organizations_url": "https://api.github.com/users/schlamar/orgs", "received_events_url": "https://api.github.com/users/schlamar/received_events", "repos_url": "https://api.github.com/users/schlamar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/schlamar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/schlamar/subscriptions", "type": "User", "url": "https://api.github.com/users/schlamar", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1249/reactions" }
https://api.github.com/repos/psf/requests/issues/1249/timeline
null
completed
null
null
false
[ "[This comment](https://github.com/kennethreitz/requests/issues/465#issuecomment-15106811) is also interesting in this context.\n", "With this https://github.com/shazow/urllib3/pull/159 merged, `stream_decompress` could be dropped entirely.\n", "Fixed with #1299 \n" ]
https://api.github.com/repos/psf/requests/issues/1248
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1248/labels{/name}
https://api.github.com/repos/psf/requests/issues/1248/comments
https://api.github.com/repos/psf/requests/issues/1248/events
https://github.com/psf/requests/issues/1248
12,176,991
MDU6SXNzdWUxMjE3Njk5MQ==
1,248
HTTP Proxy does not handle authentication
{ "avatar_url": "https://avatars.githubusercontent.com/u/472286?v=4", "events_url": "https://api.github.com/users/rjarry/events{/privacy}", "followers_url": "https://api.github.com/users/rjarry/followers", "following_url": "https://api.github.com/users/rjarry/following{/other_user}", "gists_url": "https://api.github.com/users/rjarry/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rjarry", "id": 472286, "login": "rjarry", "node_id": "MDQ6VXNlcjQ3MjI4Ng==", "organizations_url": "https://api.github.com/users/rjarry/orgs", "received_events_url": "https://api.github.com/users/rjarry/received_events", "repos_url": "https://api.github.com/users/rjarry/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rjarry/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rjarry/subscriptions", "type": "User", "url": "https://api.github.com/users/rjarry", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2013-03-19T12:01:11Z
2021-09-09T04:00:48Z
2013-03-19T18:56:24Z
NONE
resolved
Hello, I'm trying to use the **requests** library for making requests through a http proxy that requires authentication. I tried this but it doesn't work: ``` $ python Python 2.7.3 (default, May 4 2012, 19:05:38) [GCC 4.1.2 20080704 (Red Hat 4.1.2-44)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import requests >>> requests.get('http://pypi.python.org/simple/Django/', proxies={'http': 'http://myproxyusername:<secret>@my.proxy.hostname:8000'}) <Response [407]> ``` Apparently, the `Proxy-Authorization` header is not set correctly. I tried the same thing with curl and it works fine: ``` $ curl -v -U 'myproxyusername:<secret>' -x 'my.proxy.hostname:8000' 'http://pypi.python.org/simple/Django/' >/dev/null * About to connect() to proxy my.proxy.hostname port 8000 * Trying 10.33.241.200... connected * Connected to my.proxy.hostname (10.33.241.200) port 8000 * Proxy auth using Basic with user 'myproxyusername' > GET http://pypi.python.org/simple/Django/ HTTP/1.1 > Proxy-Authorization: Basic QVBQVDAwODIzfeDdmFqZSE3MTM0 > User-Agent: curl/7.15.5 (i686-redhat-linux-gnu) libcurl/7.15.5 OpenSSL/0.9.8b zlib/1.2.3 libidn/0.6.5 > Host: pypi.python.org > Pragma: no-cache > Accept: */* > Proxy-Connection: Keep-Alive > < HTTP/1.1 200 OK < Server: nginx/1.1.19 < Date: Tue, 19 Mar 2013 11:42:38 GMT < Content-Type: text/html; charset=utf-8 < Content-Length: 9262 < Proxy-Connection: Keep-Alive < Connection: Keep-Alive < Age: 0 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 9262 100 9262 0 0 37809 0 --:--:-- --:--:-- --:--:-- 1978kConnection #0 to host my.proxy.hostname left intact * Closing connection #0 ``` NB: when the proxy does not require authentication, it works. ``` $ python Python 2.7.3 (default, May 4 2012, 19:05:38) [GCC 4.1.2 20080704 (Red Hat 4.1.2-44)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import requests >>> requests.get('http://pypi.python.org/simple/Django/', proxies={'http': 'http://other.proxy.without.auth:8000'}) <Response [200]> ``` I noticed that there was a pull request that was merged about this problem a short time ago : https://github.com/kennethreitz/requests/pull/309 . I tried to install the latest code from github and it does not work either. Can you help? :) --Robin
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1248/reactions" }
https://api.github.com/repos/psf/requests/issues/1248/timeline
null
completed
null
null
false
[ "Btw, I don't know if that may be a problem, but there is a `!` character in my password.\n", "Hi there, thanks for the report!\n\nBefore we begin, can you tell me what version of Requests you're using? I ask because #309 is quite old, and the code that was added there ended up being removed. The logic was re-add...
https://api.github.com/repos/psf/requests/issues/1247
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1247/labels{/name}
https://api.github.com/repos/psf/requests/issues/1247/comments
https://api.github.com/repos/psf/requests/issues/1247/events
https://github.com/psf/requests/pull/1247
12,097,775
MDExOlB1bGxSZXF1ZXN0NDY1MzkwMg==
1,247
proof of concept async requests via futures
{ "avatar_url": "https://avatars.githubusercontent.com/u/12789?v=4", "events_url": "https://api.github.com/users/ross/events{/privacy}", "followers_url": "https://api.github.com/users/ross/followers", "following_url": "https://api.github.com/users/ross/following{/other_user}", "gists_url": "https://api.github.com/users/ross/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ross", "id": 12789, "login": "ross", "node_id": "MDQ6VXNlcjEyNzg5", "organizations_url": "https://api.github.com/users/ross/orgs", "received_events_url": "https://api.github.com/users/ross/received_events", "repos_url": "https://api.github.com/users/ross/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ross/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ross/subscriptions", "type": "User", "url": "https://api.github.com/users/ross", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2013-03-16T17:28:43Z
2021-09-08T19:00:55Z
2013-03-21T15:39:02Z
NONE
resolved
this is a proposal/proof of concept. by no means is it expected to be merged. it provides a FuturesSession which returns concurrent.futures.Future objects to calls in place of requests.Response. this provides a near seamless async requests api. an example: ``` session = FuturesSession() future = session.get('http://www.foo.com/bar/') ... do other stuff ... # wait for response or return immediately if it's already back response = future.result() ... continue as normal ... ``` as currently implemented it requires no external dependancies and uses the python3 futures, tested with python 3.3.0. if desired support could be added to 2.x releases by either using the backport of futures or without dependancies using methods similar to https://github.com/ross/python-asynchttp. feedback solicited. ## best, -rm
{ "avatar_url": "https://avatars.githubusercontent.com/u/12789?v=4", "events_url": "https://api.github.com/users/ross/events{/privacy}", "followers_url": "https://api.github.com/users/ross/followers", "following_url": "https://api.github.com/users/ross/following{/other_user}", "gists_url": "https://api.github.com/users/ross/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ross", "id": 12789, "login": "ross", "node_id": "MDQ6VXNlcjEyNzg5", "organizations_url": "https://api.github.com/users/ross/orgs", "received_events_url": "https://api.github.com/users/ross/received_events", "repos_url": "https://api.github.com/users/ross/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ross/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ross/subscriptions", "type": "User", "url": "https://api.github.com/users/ross", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1247/reactions" }
https://api.github.com/repos/psf/requests/issues/1247/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1247.diff", "html_url": "https://github.com/psf/requests/pull/1247", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/1247.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1247" }
true
[ "Very cool. I think it's worth you putting this into its own repository, much like Kenneth has with [grequests](https://github.com/kennethreitz/grequests).\n", "+1 to @Lukasa's comment :)\n", "I'll third @Lukasa's comment.\n", "just threw up a new package, i've registered it in pypi, but haven't built and upl...
https://api.github.com/repos/psf/requests/issues/1246
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1246/labels{/name}
https://api.github.com/repos/psf/requests/issues/1246/comments
https://api.github.com/repos/psf/requests/issues/1246/events
https://github.com/psf/requests/issues/1246
12,057,525
MDU6SXNzdWUxMjA1NzUyNQ==
1,246
Please provide a RELEASE tag
{ "avatar_url": "https://avatars.githubusercontent.com/u/102495?v=4", "events_url": "https://api.github.com/users/ssbarnea/events{/privacy}", "followers_url": "https://api.github.com/users/ssbarnea/followers", "following_url": "https://api.github.com/users/ssbarnea/following{/other_user}", "gists_url": "https://api.github.com/users/ssbarnea/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ssbarnea", "id": 102495, "login": "ssbarnea", "node_id": "MDQ6VXNlcjEwMjQ5NQ==", "organizations_url": "https://api.github.com/users/ssbarnea/orgs", "received_events_url": "https://api.github.com/users/ssbarnea/received_events", "repos_url": "https://api.github.com/users/ssbarnea/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ssbarnea/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ssbarnea/subscriptions", "type": "User", "url": "https://api.github.com/users/ssbarnea", "user_view_type": "public" }
[]
closed
true
null
[]
null
8
2013-03-15T10:22:20Z
2021-09-09T04:00:37Z
2013-03-19T11:31:30Z
CONTRIBUTOR
resolved
Please provide a release tag for the repository, so we can clone and use sub-repositories that would use the latest released version. Currently you have tags with versions, but there is no way of getting the latest release using a single command. It think it shoudn't be hard to modify the tagging on a new release, even as a script. Thanks.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1246/reactions" }
https://api.github.com/repos/psf/requests/issues/1246/timeline
null
completed
null
null
false
[ "I'm not sure I follow. You mean you'd like to have two tags point to the latest release, e.g.,\n\n```\n1.1.0 -> fakesha\nRELEASE -> fakesha\n```\n\nThen when Kenneth releases 1.1.1:\n\n```\n1.1.0 -> fakesha0\n1.1.1 -> fakesha1\nRELEASE -> fakesha1\n```\n\nOr am I missing the concept?\n", "We used to do this, but...
https://api.github.com/repos/psf/requests/issues/1245
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1245/labels{/name}
https://api.github.com/repos/psf/requests/issues/1245/comments
https://api.github.com/repos/psf/requests/issues/1245/events
https://github.com/psf/requests/pull/1245
12,023,511
MDExOlB1bGxSZXF1ZXN0NDYxNzY0Mw==
1,245
Remove duplicate comment.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1592927?v=4", "events_url": "https://api.github.com/users/Damgaard/events{/privacy}", "followers_url": "https://api.github.com/users/Damgaard/followers", "following_url": "https://api.github.com/users/Damgaard/following{/other_user}", "gists_url": "https://api.github.com/users/Damgaard/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Damgaard", "id": 1592927, "login": "Damgaard", "node_id": "MDQ6VXNlcjE1OTI5Mjc=", "organizations_url": "https://api.github.com/users/Damgaard/orgs", "received_events_url": "https://api.github.com/users/Damgaard/received_events", "repos_url": "https://api.github.com/users/Damgaard/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Damgaard/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Damgaard/subscriptions", "type": "User", "url": "https://api.github.com/users/Damgaard", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-14T15:28:28Z
2021-09-08T23:08:13Z
2013-03-14T15:29:53Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1245/reactions" }
https://api.github.com/repos/psf/requests/issues/1245/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1245.diff", "html_url": "https://github.com/psf/requests/pull/1245", "merged_at": "2013-03-14T15:29:53Z", "patch_url": "https://github.com/psf/requests/pull/1245.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1245" }
true
[ "Thanks :)\n" ]
https://api.github.com/repos/psf/requests/issues/1244
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1244/labels{/name}
https://api.github.com/repos/psf/requests/issues/1244/comments
https://api.github.com/repos/psf/requests/issues/1244/events
https://github.com/psf/requests/pull/1244
11,929,056
MDExOlB1bGxSZXF1ZXN0NDU3MTAyMg==
1,244
Fixed further pickeling issues in Session and HTTPAdapter
{ "avatar_url": "https://avatars.githubusercontent.com/u/280629?v=4", "events_url": "https://api.github.com/users/jajadinimueter/events{/privacy}", "followers_url": "https://api.github.com/users/jajadinimueter/followers", "following_url": "https://api.github.com/users/jajadinimueter/following{/other_user}", "gists_url": "https://api.github.com/users/jajadinimueter/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jajadinimueter", "id": 280629, "login": "jajadinimueter", "node_id": "MDQ6VXNlcjI4MDYyOQ==", "organizations_url": "https://api.github.com/users/jajadinimueter/orgs", "received_events_url": "https://api.github.com/users/jajadinimueter/received_events", "repos_url": "https://api.github.com/users/jajadinimueter/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jajadinimueter/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jajadinimueter/subscriptions", "type": "User", "url": "https://api.github.com/users/jajadinimueter", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-12T15:22:10Z
2021-09-08T19:00:55Z
2013-03-12T15:23:22Z
NONE
resolved
Added trust_env and stream to Session.**attrs**. Initialize self._pool_connections and self._pool_maxsize in HTTPAdapter.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1244/reactions" }
https://api.github.com/repos/psf/requests/issues/1244/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1244.diff", "html_url": "https://github.com/psf/requests/pull/1244", "merged_at": "2013-03-12T15:23:22Z", "patch_url": "https://github.com/psf/requests/pull/1244.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1244" }
true
[ ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1243
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1243/labels{/name}
https://api.github.com/repos/psf/requests/issues/1243/comments
https://api.github.com/repos/psf/requests/issues/1243/events
https://github.com/psf/requests/pull/1243
11,890,022
MDExOlB1bGxSZXF1ZXN0NDU1MjEzNg==
1,243
Pickling of Session and HTTPAdapter + a test
{ "avatar_url": "https://avatars.githubusercontent.com/u/737634?v=4", "events_url": "https://api.github.com/users/darjus-amzn/events{/privacy}", "followers_url": "https://api.github.com/users/darjus-amzn/followers", "following_url": "https://api.github.com/users/darjus-amzn/following{/other_user}", "gists_url": "https://api.github.com/users/darjus-amzn/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/darjus-amzn", "id": 737634, "login": "darjus-amzn", "node_id": "MDQ6VXNlcjczNzYzNA==", "organizations_url": "https://api.github.com/users/darjus-amzn/orgs", "received_events_url": "https://api.github.com/users/darjus-amzn/received_events", "repos_url": "https://api.github.com/users/darjus-amzn/repos", "site_admin": false, "starred_url": "https://api.github.com/users/darjus-amzn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/darjus-amzn/subscriptions", "type": "User", "url": "https://api.github.com/users/darjus-amzn", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-03-11T18:15:41Z
2021-09-08T23:01:09Z
2013-03-12T14:37:55Z
CONTRIBUTOR
resolved
This is for issue #1088
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1243/reactions" }
https://api.github.com/repos/psf/requests/issues/1243/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1243.diff", "html_url": "https://github.com/psf/requests/pull/1243", "merged_at": "2013-03-12T14:37:55Z", "patch_url": "https://github.com/psf/requests/pull/1243.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1243" }
true
[ "+1, looks good.\n", ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1242
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1242/labels{/name}
https://api.github.com/repos/psf/requests/issues/1242/comments
https://api.github.com/repos/psf/requests/issues/1242/events
https://github.com/psf/requests/pull/1242
11,868,120
MDExOlB1bGxSZXF1ZXN0NDU0MTIzNg==
1,242
HTTP Digest Auth case insensitive replacement of "Digest "
{ "avatar_url": "https://avatars.githubusercontent.com/u/903275?v=4", "events_url": "https://api.github.com/users/oviboy/events{/privacy}", "followers_url": "https://api.github.com/users/oviboy/followers", "following_url": "https://api.github.com/users/oviboy/following{/other_user}", "gists_url": "https://api.github.com/users/oviboy/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/oviboy", "id": 903275, "login": "oviboy", "node_id": "MDQ6VXNlcjkwMzI3NQ==", "organizations_url": "https://api.github.com/users/oviboy/orgs", "received_events_url": "https://api.github.com/users/oviboy/received_events", "repos_url": "https://api.github.com/users/oviboy/repos", "site_admin": false, "starred_url": "https://api.github.com/users/oviboy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oviboy/subscriptions", "type": "User", "url": "https://api.github.com/users/oviboy", "user_view_type": "public" }
[]
closed
true
null
[]
null
15
2013-03-11T08:56:27Z
2021-09-08T23:07:18Z
2013-04-14T03:28:43Z
CONTRIBUTOR
resolved
Hi, I've encountered this error: ``` File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/api.py", line 87, in post return request('post', url, data=data, **kwargs) File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/sessions.py", line 279, in request resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies) File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/sessions.py", line 374, in send r = adapter.send(request, **kwargs) File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/adapters.py", line 219, in send r = self.build_response(request, resp) File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/adapters.py", line 113, in build_response response = dispatch_hook('response', req.hooks, response) File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/hooks.py", line 39, in dispatch_hook _hook_data = hook(hook_data) File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/auth.py", line 155, in handle_401 r.request.headers['Authorization'] = self.build_digest_header(r.request.method, r.request.url) File "/sites/.ro-api/api/local/lib/python2.7/site-packages/requests/auth.py", line 69, in build_digest_header nonce = self.chal['nonce'] KeyError: 'nonce' ``` While investigating i found that the site was sending me the following string: `"WWW-Authenticate: digest nonce="***********************", qop="auth", realm="***************", algorithm="md5", opaque="*******************=""` The parsed key in this case was: "digest nonce" and not "nonce", thus, the error above. So I've modified the s_auth in requests/auth.py (line 154) string to replace "Digest " or "digest " with '' using re module and re.sub function. I've tested the feature and it works. Regards, Ovidiu Negrut
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1242/reactions" }
https://api.github.com/repos/psf/requests/issues/1242/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1242.diff", "html_url": "https://github.com/psf/requests/pull/1242", "merged_at": "2013-04-14T03:28:43Z", "patch_url": "https://github.com/psf/requests/pull/1242.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1242" }
true
[ "I hate web server authors. :angry: \n\nThis is a good patch. =) My only question is whether we need the overhead of a regular expression here? @sigmavirus24?\n", "Thanks for the reply... Yes, I've thought of that also, but I'm thinking that if another \"web server author\" will send a string like 'DiGEst' or ano...
https://api.github.com/repos/psf/requests/issues/1241
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1241/labels{/name}
https://api.github.com/repos/psf/requests/issues/1241/comments
https://api.github.com/repos/psf/requests/issues/1241/events
https://github.com/psf/requests/issues/1241
11,847,097
MDU6SXNzdWUxMTg0NzA5Nw==
1,241
New "proxies" argument option
{ "avatar_url": "https://avatars.githubusercontent.com/u/935203?v=4", "events_url": "https://api.github.com/users/Anorov/events{/privacy}", "followers_url": "https://api.github.com/users/Anorov/followers", "following_url": "https://api.github.com/users/Anorov/following{/other_user}", "gists_url": "https://api.github.com/users/Anorov/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Anorov", "id": 935203, "login": "Anorov", "node_id": "MDQ6VXNlcjkzNTIwMw==", "organizations_url": "https://api.github.com/users/Anorov/orgs", "received_events_url": "https://api.github.com/users/Anorov/received_events", "repos_url": "https://api.github.com/users/Anorov/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Anorov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Anorov/subscriptions", "type": "User", "url": "https://api.github.com/users/Anorov", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2013-03-10T01:59:35Z
2021-09-09T04:00:48Z
2013-03-19T16:55:07Z
NONE
resolved
I'm currently working on integrating SOCKS proxies into urllib3 (see: https://github.com/shazow/urllib3/pull/68#issuecomment-14672574), and this is a minor change that I think could be useful. Idea was obtained from here: https://github.com/kennethreitz/requests/pull/1192#issuecomment-13564585 I feel the `proxies` keyword argument to Session() should accept a plain string URL in addition to the current dict-of-URLs option (`{"http": "...", "https": "..."}`). In the case of a string being passed, that proxy would be used regardless of the destination URL scheme. Original: `requests.get(url, proxies={"http": "http://1.1.1.1:8080"})` (Proxy would only be used for `"http://website.com"`). Proposed: `requests.get(url, proxies="http://1.1.1.1:8080")` (Proxy would be used for `"https://website.com"` and `"http://website.com"`). Both would be permitted. It's very common for users to only specify one proxy. After SOCKS proxies become supported, this will become even more common because SOCKS proxies can handle every kind of connection (an FTP destination, HTTP, HTTPS, etc.). So if a user is using a SOCKS proxy, it doesn't really make sense to specify multiple proxies in a dict. Use of a SOCKS5 proxy would look as follows: `requests.get(url, proxies="socks5://1.1.1.1:1080")` This would not break the old API in any way, just add a new way of setting a proxy. The only disadvantage is that it creates a bit of a naming mismatch, since `proxies` is plural. I think it would be sillier to create a new `proxy` parameter, though (unless `proxy` simply became an alias for `proxies`).
{ "avatar_url": "https://avatars.githubusercontent.com/u/935203?v=4", "events_url": "https://api.github.com/users/Anorov/events{/privacy}", "followers_url": "https://api.github.com/users/Anorov/followers", "following_url": "https://api.github.com/users/Anorov/following{/other_user}", "gists_url": "https://api.github.com/users/Anorov/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Anorov", "id": 935203, "login": "Anorov", "node_id": "MDQ6VXNlcjkzNTIwMw==", "organizations_url": "https://api.github.com/users/Anorov/orgs", "received_events_url": "https://api.github.com/users/Anorov/received_events", "repos_url": "https://api.github.com/users/Anorov/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Anorov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Anorov/subscriptions", "type": "User", "url": "https://api.github.com/users/Anorov", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1241/reactions" }
https://api.github.com/repos/psf/requests/issues/1241/timeline
null
completed
null
null
false
[ "Creating a new `proxy` parameter is right out because of Requests [feature freeze](http://docs.python-requests.org/en/latest/dev/todo/#feature-freeze).\n\nAs for adding a global way of specifying proxies for all schemes, I'm +0 on it. It's not a huge change, and could potentially go into 1.2.0, but it _does_ chang...
https://api.github.com/repos/psf/requests/issues/1240
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1240/labels{/name}
https://api.github.com/repos/psf/requests/issues/1240/comments
https://api.github.com/repos/psf/requests/issues/1240/events
https://github.com/psf/requests/issues/1240
11,845,731
MDU6SXNzdWUxMTg0NTczMQ==
1,240
Cannot install as current user
{ "avatar_url": "https://avatars.githubusercontent.com/u/2991890?v=4", "events_url": "https://api.github.com/users/cipri-tom/events{/privacy}", "followers_url": "https://api.github.com/users/cipri-tom/followers", "following_url": "https://api.github.com/users/cipri-tom/following{/other_user}", "gists_url": "https://api.github.com/users/cipri-tom/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cipri-tom", "id": 2991890, "login": "cipri-tom", "node_id": "MDQ6VXNlcjI5OTE4OTA=", "organizations_url": "https://api.github.com/users/cipri-tom/orgs", "received_events_url": "https://api.github.com/users/cipri-tom/received_events", "repos_url": "https://api.github.com/users/cipri-tom/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cipri-tom/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cipri-tom/subscriptions", "type": "User", "url": "https://api.github.com/users/cipri-tom", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-03-09T23:24:11Z
2021-09-09T04:00:49Z
2013-03-09T23:26:21Z
NONE
resolved
This is a very interesting issue. I need requests on the place I work, and I do not have administration rights. For that reason, I install it using `python setup.py install --user` . Actually, I can log in on two different computers: one is where I actually do my work, and has Python version 2.7, the other is the server from where I need to run my program, which has Python 2.4.3 I managed to install it on the working computer (Python v2.7), but it won't work on the server (Python v2.4.3). The error I get is: `python setup.py install --user Traceback (most recent call last): File "setup.py", line 6, in ? import requests File "/home/S12/tomoiac2/bin/kennethreitz-requests-3e72f23/requests/__init__.py", line 52 from . import utils ^ SyntaxError: invalid syntax` Any ideas on why this happens and how it can be solved? Thank you very much
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1240/reactions" }
https://api.github.com/repos/psf/requests/issues/1240/timeline
null
completed
null
null
false
[ "Requests does not support Python 2.4. In this case, I suspect Python 2.4 does not allow relative imports, on which Requests relies.\n", "Just FYI, Requests only supports 2.6+\n" ]
https://api.github.com/repos/psf/requests/issues/1239
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1239/labels{/name}
https://api.github.com/repos/psf/requests/issues/1239/comments
https://api.github.com/repos/psf/requests/issues/1239/events
https://github.com/psf/requests/pull/1239
11,837,387
MDExOlB1bGxSZXF1ZXN0NDUzMDE5NA==
1,239
Use session cookies when following redirects
{ "avatar_url": "https://avatars.githubusercontent.com/u/34607?v=4", "events_url": "https://api.github.com/users/miikka/events{/privacy}", "followers_url": "https://api.github.com/users/miikka/followers", "following_url": "https://api.github.com/users/miikka/following{/other_user}", "gists_url": "https://api.github.com/users/miikka/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/miikka", "id": 34607, "login": "miikka", "node_id": "MDQ6VXNlcjM0NjA3", "organizations_url": "https://api.github.com/users/miikka/orgs", "received_events_url": "https://api.github.com/users/miikka/received_events", "repos_url": "https://api.github.com/users/miikka/repos", "site_admin": false, "starred_url": "https://api.github.com/users/miikka/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/miikka/subscriptions", "type": "User", "url": "https://api.github.com/users/miikka", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2013-03-09T11:13:26Z
2021-09-08T19:00:54Z
2013-03-20T10:37:25Z
CONTRIBUTOR
resolved
A fix for issue #1228. I have a nagging feeling, that there'd be a better way to do this, but here goes.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1239/reactions" }
https://api.github.com/repos/psf/requests/issues/1239/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1239.diff", "html_url": "https://github.com/psf/requests/pull/1239", "merged_at": "2013-03-20T10:37:25Z", "patch_url": "https://github.com/psf/requests/pull/1239.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1239" }
true
[ "Excited to see this getting fixed!\n\nMy immediate reaction here is perhaps `cookies` shouldn't need to be passed in? `SessionRedirectMixin` is extending `Session`, so we should be able to just reference `self.cookies` directly.\n\nDo you think your code will still work properly if we do that?\n", "Sure - I atta...
https://api.github.com/repos/psf/requests/issues/1238
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1238/labels{/name}
https://api.github.com/repos/psf/requests/issues/1238/comments
https://api.github.com/repos/psf/requests/issues/1238/events
https://github.com/psf/requests/pull/1238
11,799,009
MDExOlB1bGxSZXF1ZXN0NDUxMzAzMg==
1,238
cleanup (remove max_retries test)
{ "avatar_url": "https://avatars.githubusercontent.com/u/642195?v=4", "events_url": "https://api.github.com/users/oczkers/events{/privacy}", "followers_url": "https://api.github.com/users/oczkers/followers", "following_url": "https://api.github.com/users/oczkers/following{/other_user}", "gists_url": "https://api.github.com/users/oczkers/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/oczkers", "id": 642195, "login": "oczkers", "node_id": "MDQ6VXNlcjY0MjE5NQ==", "organizations_url": "https://api.github.com/users/oczkers/orgs", "received_events_url": "https://api.github.com/users/oczkers/received_events", "repos_url": "https://api.github.com/users/oczkers/repos", "site_admin": false, "starred_url": "https://api.github.com/users/oczkers/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oczkers/subscriptions", "type": "User", "url": "https://api.github.com/users/oczkers", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-08T10:21:50Z
2021-09-08T19:00:54Z
2013-03-08T19:51:42Z
CONTRIBUTOR
resolved
It was reverted in b14584f36eca344ed5033d1d2f5a59490fadca56 but again merged in c0d4b23cea430ba1dce407f4325d9362c55d577c
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1238/reactions" }
https://api.github.com/repos/psf/requests/issues/1238/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1238.diff", "html_url": "https://github.com/psf/requests/pull/1238", "merged_at": "2013-03-08T19:51:42Z", "patch_url": "https://github.com/psf/requests/pull/1238.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1238" }
true
[ ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/1237
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1237/labels{/name}
https://api.github.com/repos/psf/requests/issues/1237/comments
https://api.github.com/repos/psf/requests/issues/1237/events
https://github.com/psf/requests/issues/1237
11,774,145
MDU6SXNzdWUxMTc3NDE0NQ==
1,237
FTP possible ?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1226080?v=4", "events_url": "https://api.github.com/users/YAmikep/events{/privacy}", "followers_url": "https://api.github.com/users/YAmikep/followers", "following_url": "https://api.github.com/users/YAmikep/following{/other_user}", "gists_url": "https://api.github.com/users/YAmikep/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/YAmikep", "id": 1226080, "login": "YAmikep", "node_id": "MDQ6VXNlcjEyMjYwODA=", "organizations_url": "https://api.github.com/users/YAmikep/orgs", "received_events_url": "https://api.github.com/users/YAmikep/received_events", "repos_url": "https://api.github.com/users/YAmikep/repos", "site_admin": false, "starred_url": "https://api.github.com/users/YAmikep/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/YAmikep/subscriptions", "type": "User", "url": "https://api.github.com/users/YAmikep", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2013-03-07T19:08:09Z
2021-09-09T04:00:49Z
2013-03-07T19:11:18Z
NONE
resolved
Is it possible to download a file over FTP with requests? I have tried it but it does not work. Thanks.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1237/reactions" }
https://api.github.com/repos/psf/requests/issues/1237/timeline
null
completed
null
null
false
[ "Hey, I have topical knowledge!\n\nThe answer is that, strictly speaking, no. Requests is an HTTP library. However, after the release of v1.0.0, I made a [proof of concept of FTP in Requests](https://github.com/Lukasa/requests-ftp). Feel free to use it. Bear in mind it's barely functional. If you encounter problems...
https://api.github.com/repos/psf/requests/issues/1236
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1236/labels{/name}
https://api.github.com/repos/psf/requests/issues/1236/comments
https://api.github.com/repos/psf/requests/issues/1236/events
https://github.com/psf/requests/issues/1236
11,757,824
MDU6SXNzdWUxMTc1NzgyNA==
1,236
socket.timeout is thrown instead of requests.exceptions.Timeout
{ "avatar_url": "https://avatars.githubusercontent.com/u/3797538?v=4", "events_url": "https://api.github.com/users/dmalenko/events{/privacy}", "followers_url": "https://api.github.com/users/dmalenko/followers", "following_url": "https://api.github.com/users/dmalenko/following{/other_user}", "gists_url": "https://api.github.com/users/dmalenko/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dmalenko", "id": 3797538, "login": "dmalenko", "node_id": "MDQ6VXNlcjM3OTc1Mzg=", "organizations_url": "https://api.github.com/users/dmalenko/orgs", "received_events_url": "https://api.github.com/users/dmalenko/received_events", "repos_url": "https://api.github.com/users/dmalenko/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dmalenko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dmalenko/subscriptions", "type": "User", "url": "https://api.github.com/users/dmalenko", "user_view_type": "public" }
[ { "color": "f7c6c7", "default": false, "description": null, "id": 167537670, "name": "Propose Close", "node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=", "url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close" } ]
closed
true
null
[]
null
26
2013-03-07T12:44:48Z
2021-09-08T20:01:00Z
2015-01-19T09:27:00Z
NONE
resolved
When _timeout_ parameter is used, socket operations can thrown _socket.timeout_ exception, which is not converted into _requests.exceptions.Timeout_. This causes users to handle two different types of exceptions, which essentially represent the same error. Here is corresponding traceback: ``` >>> r=requests.get('http://files.animeblog.ru/manga/Bakuman/Bakuman_vol01.rar', timeout=0.5) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/u/vpython/lib/python2.7/site-packages/requests/api.py", line 55, in get return request('get', url, **kwargs) File "/Users/u/vpython/lib/python2.7/site-packages/requests/api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "/Users/u/vpython/lib/python2.7/site-packages/requests/sessions.py", line 279, in request resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies) File "/Users/u/vpython/lib/python2.7/site-packages/requests/sessions.py", line 374, in send r = adapter.send(request, **kwargs) File "/Users/u/vpython/lib/python2.7/site-packages/requests/adapters.py", line 222, in send r.content File "/Users/u/vpython/lib/python2.7/site-packages/requests/models.py", line 550, in content self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes() File "/Users/u/vpython/lib/python2.7/site-packages/requests/models.py", line 496, in generate chunk = self.raw.read(chunk_size) File "/Users/u/vpython/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 148, in read return self._fp.read(amt) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 561, in read s = self.fp.read(amt) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left) socket.timeout: timed out ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1236/reactions" }
https://api.github.com/repos/psf/requests/issues/1236/timeline
null
completed
null
null
false
[ "Good spot, I'll take a look at this. =)\n", "We don't catch this and urllib3 doesn't try to catch and re-throw this error. If anything, the patch should be submitted upstream to urllib3 and then we won't need changes here.\n", "I believe this creates a leaky abstraction: requests intentionally or unintentional...
https://api.github.com/repos/psf/requests/issues/1235
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1235/labels{/name}
https://api.github.com/repos/psf/requests/issues/1235/comments
https://api.github.com/repos/psf/requests/issues/1235/events
https://github.com/psf/requests/issues/1235
11,684,717
MDU6SXNzdWUxMTY4NDcxNw==
1,235
Removing traling and leading spaces, and newline from headers
{ "avatar_url": "https://avatars.githubusercontent.com/u/505230?v=4", "events_url": "https://api.github.com/users/karlcow/events{/privacy}", "followers_url": "https://api.github.com/users/karlcow/followers", "following_url": "https://api.github.com/users/karlcow/following{/other_user}", "gists_url": "https://api.github.com/users/karlcow/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/karlcow", "id": 505230, "login": "karlcow", "node_id": "MDQ6VXNlcjUwNTIzMA==", "organizations_url": "https://api.github.com/users/karlcow/orgs", "received_events_url": "https://api.github.com/users/karlcow/received_events", "repos_url": "https://api.github.com/users/karlcow/repos", "site_admin": false, "starred_url": "https://api.github.com/users/karlcow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karlcow/subscriptions", "type": "User", "url": "https://api.github.com/users/karlcow", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2013-03-05T20:30:05Z
2021-09-09T04:00:47Z
2013-03-10T03:01:11Z
CONTRIBUTOR
resolved
Hello, currently Requests has the [same issue](http://bugs.python.org/issue17322) (see the full discussion) than the standard library. ``` >>> import requests >>> url = "http://www.w3.org/" >>> headers = {'foo': 'bar', ' fooLead': 'bar', 'fooTrail ': 'bar', 'foo\nlish': 'bar'} >>> r = requests.get(url, headers=headers) >>> r.text u'<html><body><h1>400 Bad request</h1>\nYour browser sent an invalid request.\n</body></html>\n' ``` Quick summary on the constraints on HTTP header `field-name`: - Leading spaces are deprecated and interpreted by conformant servers as continuation line. - Trailing spaces are forbidden and might create security issues - Newline break the full thing. Bonus: Check also if we use only the allowed set of characters. Would you like me to provide a patch and associated tests for fixing it?
{ "avatar_url": "https://avatars.githubusercontent.com/u/505230?v=4", "events_url": "https://api.github.com/users/karlcow/events{/privacy}", "followers_url": "https://api.github.com/users/karlcow/followers", "following_url": "https://api.github.com/users/karlcow/following{/other_user}", "gists_url": "https://api.github.com/users/karlcow/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/karlcow", "id": 505230, "login": "karlcow", "node_id": "MDQ6VXNlcjUwNTIzMA==", "organizations_url": "https://api.github.com/users/karlcow/orgs", "received_events_url": "https://api.github.com/users/karlcow/received_events", "repos_url": "https://api.github.com/users/karlcow/repos", "site_admin": false, "starred_url": "https://api.github.com/users/karlcow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karlcow/subscriptions", "type": "User", "url": "https://api.github.com/users/karlcow", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1235/reactions" }
https://api.github.com/repos/psf/requests/issues/1235/timeline
null
completed
null
null
false
[ "I don't know if policing this is our job. It's not clear to me that we should police that your headers meet the RFCs.\n", "Policing, nope.\nBut giving the chance to have a more predictable behavior, yes. At least, if not removing the forbidden characters, a warning could be raised so people are given the opportu...
https://api.github.com/repos/psf/requests/issues/1234
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1234/labels{/name}
https://api.github.com/repos/psf/requests/issues/1234/comments
https://api.github.com/repos/psf/requests/issues/1234/events
https://github.com/psf/requests/pull/1234
11,670,998
MDExOlB1bGxSZXF1ZXN0NDQ0OTE2MQ==
1,234
Fix issue #1225 (Documentation: response object status/reason)
{ "avatar_url": "https://avatars.githubusercontent.com/u/2497217?v=4", "events_url": "https://api.github.com/users/Vassius/events{/privacy}", "followers_url": "https://api.github.com/users/Vassius/followers", "following_url": "https://api.github.com/users/Vassius/following{/other_user}", "gists_url": "https://api.github.com/users/Vassius/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Vassius", "id": 2497217, "login": "Vassius", "node_id": "MDQ6VXNlcjI0OTcyMTc=", "organizations_url": "https://api.github.com/users/Vassius/orgs", "received_events_url": "https://api.github.com/users/Vassius/received_events", "repos_url": "https://api.github.com/users/Vassius/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Vassius/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Vassius/subscriptions", "type": "User", "url": "https://api.github.com/users/Vassius", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-05T15:25:05Z
2021-09-09T00:01:24Z
2013-03-05T15:31:11Z
CONTRIBUTOR
resolved
Just a small docs fix.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1234/reactions" }
https://api.github.com/repos/psf/requests/issues/1234/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1234.diff", "html_url": "https://github.com/psf/requests/pull/1234", "merged_at": "2013-03-05T15:31:11Z", "patch_url": "https://github.com/psf/requests/pull/1234.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1234" }
true
[ "Thanks!\n" ]
https://api.github.com/repos/psf/requests/issues/1233
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1233/labels{/name}
https://api.github.com/repos/psf/requests/issues/1233/comments
https://api.github.com/repos/psf/requests/issues/1233/events
https://github.com/psf/requests/issues/1233
11,581,758
MDU6SXNzdWUxMTU4MTc1OA==
1,233
Cut a release for v1.2.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[]
closed
true
null
[]
null
13
2013-03-02T21:05:11Z
2021-09-09T04:00:42Z
2013-04-01T18:29:17Z
CONTRIBUTOR
resolved
/cc @sigmavirus24 @slingamn Anything pending for a new release? A ton of stuff has happened. _Note_ I updated the title to reflect what is generally believed to be the correct version we should cut. --Ian
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1233/reactions" }
https://api.github.com/repos/psf/requests/issues/1233/timeline
null
completed
null
null
false
[ "A damn lot has happened. Did you want multidicts ready for this? I'm still trying to think of a good way to handle the merging of keyword arguments. Also, I'm missing one error class from Flask, but my branch isn't really ready for a merge at all.\n\nAlso pinging the jet-lagged @Lukasa \n", "I'm not sitting on a...
https://api.github.com/repos/psf/requests/issues/1232
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1232/labels{/name}
https://api.github.com/repos/psf/requests/issues/1232/comments
https://api.github.com/repos/psf/requests/issues/1232/events
https://github.com/psf/requests/issues/1232
11,581,459
MDU6SXNzdWUxMTU4MTQ1OQ==
1,232
{ "avatar_url": "https://avatars.githubusercontent.com/u/3436230?v=4", "events_url": "https://api.github.com/users/ToruFukui/events{/privacy}", "followers_url": "https://api.github.com/users/ToruFukui/followers", "following_url": "https://api.github.com/users/ToruFukui/following{/other_user}", "gists_url": "https://api.github.com/users/ToruFukui/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ToruFukui", "id": 3436230, "login": "ToruFukui", "node_id": "MDQ6VXNlcjM0MzYyMzA=", "organizations_url": "https://api.github.com/users/ToruFukui/orgs", "received_events_url": "https://api.github.com/users/ToruFukui/received_events", "repos_url": "https://api.github.com/users/ToruFukui/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ToruFukui/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ToruFukui/subscriptions", "type": "User", "url": "https://api.github.com/users/ToruFukui", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2013-03-02T20:43:06Z
2021-09-09T04:00:50Z
2013-03-02T20:43:43Z
NONE
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/3436230?v=4", "events_url": "https://api.github.com/users/ToruFukui/events{/privacy}", "followers_url": "https://api.github.com/users/ToruFukui/followers", "following_url": "https://api.github.com/users/ToruFukui/following{/other_user}", "gists_url": "https://api.github.com/users/ToruFukui/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ToruFukui", "id": 3436230, "login": "ToruFukui", "node_id": "MDQ6VXNlcjM0MzYyMzA=", "organizations_url": "https://api.github.com/users/ToruFukui/orgs", "received_events_url": "https://api.github.com/users/ToruFukui/received_events", "repos_url": "https://api.github.com/users/ToruFukui/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ToruFukui/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ToruFukui/subscriptions", "type": "User", "url": "https://api.github.com/users/ToruFukui", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1232/reactions" }
https://api.github.com/repos/psf/requests/issues/1232/timeline
null
completed
null
null
false
[]
https://api.github.com/repos/psf/requests/issues/1231
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1231/labels{/name}
https://api.github.com/repos/psf/requests/issues/1231/comments
https://api.github.com/repos/psf/requests/issues/1231/events
https://github.com/psf/requests/pull/1231
11,573,007
MDExOlB1bGxSZXF1ZXN0NDQwODQyNg==
1,231
Initial docs patch for migrating from pre 1.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/185043?v=4", "events_url": "https://api.github.com/users/davidfischer/events{/privacy}", "followers_url": "https://api.github.com/users/davidfischer/followers", "following_url": "https://api.github.com/users/davidfischer/following{/other_user}", "gists_url": "https://api.github.com/users/davidfischer/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/davidfischer", "id": 185043, "login": "davidfischer", "node_id": "MDQ6VXNlcjE4NTA0Mw==", "organizations_url": "https://api.github.com/users/davidfischer/orgs", "received_events_url": "https://api.github.com/users/davidfischer/received_events", "repos_url": "https://api.github.com/users/davidfischer/repos", "site_admin": false, "starred_url": "https://api.github.com/users/davidfischer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davidfischer/subscriptions", "type": "User", "url": "https://api.github.com/users/davidfischer", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2013-03-02T07:24:43Z
2021-09-08T19:00:53Z
2013-03-02T20:58:49Z
CONTRIBUTOR
resolved
Hopefully this helps with issues like #1196. I know when 1.0 first dropped I went straight to the docs looking for this and I was surprised it didn't exist.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1231/reactions" }
https://api.github.com/repos/psf/requests/issues/1231/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1231.diff", "html_url": "https://github.com/psf/requests/pull/1231", "merged_at": "2013-03-02T20:58:49Z", "patch_url": "https://github.com/psf/requests/pull/1231.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1231" }
true
[ "Thanks for this. I've been working a little bit on something like this on the side, but it's way better if you do it than me. =D This is a great place to start from. I've made one small note in the diff which is worth doing in this PR. I'm +1 on this or something like it.\n", "I updated the patch based on the fe...
https://api.github.com/repos/psf/requests/issues/1230
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1230/labels{/name}
https://api.github.com/repos/psf/requests/issues/1230/comments
https://api.github.com/repos/psf/requests/issues/1230/events
https://github.com/psf/requests/pull/1230
11,571,709
MDExOlB1bGxSZXF1ZXN0NDQwNzk2MA==
1,230
Github URL fix
{ "avatar_url": "https://avatars.githubusercontent.com/u/185043?v=4", "events_url": "https://api.github.com/users/davidfischer/events{/privacy}", "followers_url": "https://api.github.com/users/davidfischer/followers", "following_url": "https://api.github.com/users/davidfischer/following{/other_user}", "gists_url": "https://api.github.com/users/davidfischer/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/davidfischer", "id": 185043, "login": "davidfischer", "node_id": "MDQ6VXNlcjE4NTA0Mw==", "organizations_url": "https://api.github.com/users/davidfischer/orgs", "received_events_url": "https://api.github.com/users/davidfischer/received_events", "repos_url": "https://api.github.com/users/davidfischer/repos", "site_admin": false, "starred_url": "https://api.github.com/users/davidfischer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davidfischer/subscriptions", "type": "User", "url": "https://api.github.com/users/davidfischer", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2013-03-02T04:40:08Z
2021-09-08T19:00:53Z
2013-03-02T20:59:10Z
CONTRIBUTOR
resolved
Fixed typo.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1230/reactions" }
https://api.github.com/repos/psf/requests/issues/1230/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1230.diff", "html_url": "https://github.com/psf/requests/pull/1230", "merged_at": "2013-03-02T20:59:10Z", "patch_url": "https://github.com/psf/requests/pull/1230.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1230" }
true
[ "Thanks! Keep em coming :)\n" ]
https://api.github.com/repos/psf/requests/issues/1229
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/1229/labels{/name}
https://api.github.com/repos/psf/requests/issues/1229/comments
https://api.github.com/repos/psf/requests/issues/1229/events
https://github.com/psf/requests/pull/1229
11,558,031
MDExOlB1bGxSZXF1ZXN0NDQwMTA2Mw==
1,229
Doc fix: URLError doesn't exist anymore
{ "avatar_url": "https://avatars.githubusercontent.com/u/110295?v=4", "events_url": "https://api.github.com/users/sprt/events{/privacy}", "followers_url": "https://api.github.com/users/sprt/followers", "following_url": "https://api.github.com/users/sprt/following{/other_user}", "gists_url": "https://api.github.com/users/sprt/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sprt", "id": 110295, "login": "sprt", "node_id": "MDQ6VXNlcjExMDI5NQ==", "organizations_url": "https://api.github.com/users/sprt/orgs", "received_events_url": "https://api.github.com/users/sprt/received_events", "repos_url": "https://api.github.com/users/sprt/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sprt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sprt/subscriptions", "type": "User", "url": "https://api.github.com/users/sprt", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2013-03-01T19:23:51Z
2021-09-08T23:06:29Z
2013-03-02T20:59:41Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/1229/reactions" }
https://api.github.com/repos/psf/requests/issues/1229/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/1229.diff", "html_url": "https://github.com/psf/requests/pull/1229", "merged_at": "2013-03-02T20:59:41Z", "patch_url": "https://github.com/psf/requests/pull/1229.patch", "url": "https://api.github.com/repos/psf/requests/pulls/1229" }
true
[ ":+1:\n", "+1\n", ":metal:\n" ]