url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/1228 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1228/labels{/name} | https://api.github.com/repos/psf/requests/issues/1228/comments | https://api.github.com/repos/psf/requests/issues/1228/events | https://github.com/psf/requests/issues/1228 | 11,557,184 | MDU6SXNzdWUxMTU1NzE4NA== | 1,228 | Problem with missing cookies after redirect | {
"avatar_url": "https://avatars.githubusercontent.com/u/3728987?v=4",
"events_url": "https://api.github.com/users/JohnCC330/events{/privacy}",
"followers_url": "https://api.github.com/users/JohnCC330/followers",
"following_url": "https://api.github.com/users/JohnCC330/following{/other_user}",
"gists_url": "https://api.github.com/users/JohnCC330/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JohnCC330",
"id": 3728987,
"login": "JohnCC330",
"node_id": "MDQ6VXNlcjM3Mjg5ODc=",
"organizations_url": "https://api.github.com/users/JohnCC330/orgs",
"received_events_url": "https://api.github.com/users/JohnCC330/received_events",
"repos_url": "https://api.github.com/users/JohnCC330/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JohnCC330/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JohnCC330/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JohnCC330",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2013-03-01T19:01:55Z | 2021-09-09T01:22:20Z | 2013-09-27T08:45:29Z | NONE | resolved | I sent this by e-mail - no response. I think this might be of interest to others:
> I have a problem when connecting to a site. Here's the scenario:
>
> 1) I enter a login page, which has a form
> 2) I send (using Requests) a POST with the username, pw, etc.
> (This POST includes the SESSIONID)
> 3) The webpage with a 302,
> 4) To which requests does automatically a GET to the new address
> 5) In Firefox, this works, In Requests, I get redirected to the
> login - page (with another 302).
>
> The only important difference I can detect is that in point 4),
> Firefox repeats automatically the SESSION ID, which Requests does
> not do. Can I enable this?
I solved the problem by disabling automatic redirects, and creating
a new request manually, with the sessionid cookie. Now the process
runs successfully.
This confirms the necessity of the repeating the cookie in the
request after the 302, but it defeat the 'neatness' of the auto
redirects.
Cheers,
John
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1228/reactions"
} | https://api.github.com/repos/psf/requests/issues/1228/timeline | null | completed | null | null | false | [
"@JohnCC330 how are you passing the `SESSIONID` cookie? Could you give us a snippet so we can attempt to reproduce it?\n",
"On Fri, 01 Mar 2013 15:56:14 -0800\nIan Cordasco notifications@github.com wrote:\n\n> @JohnCC330 how are you passing the `SESSIONID` cookie? Could you give us a snippet so we can attempt to ... |
https://api.github.com/repos/psf/requests/issues/1227 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1227/labels{/name} | https://api.github.com/repos/psf/requests/issues/1227/comments | https://api.github.com/repos/psf/requests/issues/1227/events | https://github.com/psf/requests/pull/1227 | 11,536,342 | MDExOlB1bGxSZXF1ZXN0NDM5MDMyMw== | 1,227 | Add ability to pass `response` to `HTTPError()` | {
"avatar_url": "https://avatars.githubusercontent.com/u/104330?v=4",
"events_url": "https://api.github.com/users/dmedvinsky/events{/privacy}",
"followers_url": "https://api.github.com/users/dmedvinsky/followers",
"following_url": "https://api.github.com/users/dmedvinsky/following{/other_user}",
"gists_url": "https://api.github.com/users/dmedvinsky/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dmedvinsky",
"id": 104330,
"login": "dmedvinsky",
"node_id": "MDQ6VXNlcjEwNDMzMA==",
"organizations_url": "https://api.github.com/users/dmedvinsky/orgs",
"received_events_url": "https://api.github.com/users/dmedvinsky/received_events",
"repos_url": "https://api.github.com/users/dmedvinsky/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dmedvinsky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dmedvinsky/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dmedvinsky",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2013-03-01T09:01:52Z | 2021-09-08T23:06:09Z | 2013-03-04T22:54:32Z | CONTRIBUTOR | resolved | Just a little refactoring, but it seems nicer to me to be able to pass
the response when constructing the `HTTPError` instance instead of
constructing it and then changing the member variable.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1227/reactions"
} | https://api.github.com/repos/psf/requests/issues/1227/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1227.diff",
"html_url": "https://github.com/psf/requests/pull/1227",
"merged_at": "2013-03-04T22:54:32Z",
"patch_url": "https://github.com/psf/requests/pull/1227.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1227"
} | true | [
"Fixed test failing on Python 3 and force-pushed.\n",
"I'm +1 on this. It definitely seems worth adding to allow for extra information and it isn't so much a change in the API although @Lukasa and @kennethreitz may disagree.\n",
"Well, it doesn't really add any extra info as `response` was attached to `HTTPErro... |
https://api.github.com/repos/psf/requests/issues/1226 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1226/labels{/name} | https://api.github.com/repos/psf/requests/issues/1226/comments | https://api.github.com/repos/psf/requests/issues/1226/events | https://github.com/psf/requests/pull/1226 | 11,536,296 | MDExOlB1bGxSZXF1ZXN0NDM5MDI5Nw== | 1,226 | Fix couple of typos in HISTORY.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/104330?v=4",
"events_url": "https://api.github.com/users/dmedvinsky/events{/privacy}",
"followers_url": "https://api.github.com/users/dmedvinsky/followers",
"following_url": "https://api.github.com/users/dmedvinsky/following{/other_user}",
"gists_url": "https://api.github.com/users/dmedvinsky/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dmedvinsky",
"id": 104330,
"login": "dmedvinsky",
"node_id": "MDQ6VXNlcjEwNDMzMA==",
"organizations_url": "https://api.github.com/users/dmedvinsky/orgs",
"received_events_url": "https://api.github.com/users/dmedvinsky/received_events",
"repos_url": "https://api.github.com/users/dmedvinsky/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dmedvinsky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dmedvinsky/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dmedvinsky",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-03-01T09:00:24Z | 2021-09-08T19:00:53Z | 2013-03-02T21:00:48Z | CONTRIBUTOR | resolved | One typo and a couple of auto-completions, I guess.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1226/reactions"
} | https://api.github.com/repos/psf/requests/issues/1226/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1226.diff",
"html_url": "https://github.com/psf/requests/pull/1226",
"merged_at": "2013-03-02T21:00:48Z",
"patch_url": "https://github.com/psf/requests/pull/1226.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1226"
} | true | [
":+1: Thanks :)\n"
] |
https://api.github.com/repos/psf/requests/issues/1225 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1225/labels{/name} | https://api.github.com/repos/psf/requests/issues/1225/comments | https://api.github.com/repos/psf/requests/issues/1225/events | https://github.com/psf/requests/issues/1225 | 11,526,135 | MDU6SXNzdWUxMTUyNjEzNQ== | 1,225 | Documentation: response object status/reason | {
"avatar_url": "https://avatars.githubusercontent.com/u/2817308?v=4",
"events_url": "https://api.github.com/users/JonathanCooper/events{/privacy}",
"followers_url": "https://api.github.com/users/JonathanCooper/followers",
"following_url": "https://api.github.com/users/JonathanCooper/following{/other_user}",
"gists_url": "https://api.github.com/users/JonathanCooper/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JonathanCooper",
"id": 2817308,
"login": "JonathanCooper",
"node_id": "MDQ6VXNlcjI4MTczMDg=",
"organizations_url": "https://api.github.com/users/JonathanCooper/orgs",
"received_events_url": "https://api.github.com/users/JonathanCooper/received_events",
"repos_url": "https://api.github.com/users/JonathanCooper/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JonathanCooper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JonathanCooper/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JonathanCooper",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-03-01T00:09:50Z | 2021-09-09T00:10:09Z | 2013-03-20T09:02:43Z | NONE | resolved | The response header [documentation](http://docs.python-requests.org/en/latest/user/quickstart/#response-headers) claims that the headers dict will contain a 'status' entry, containing both the return status and the reason, for example '200 OK'.
In my tests, no such entry exists in the headers dict, although the same data is available with a combination of (assuming a response object called 'r') r.status_code and r.reason.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1225/reactions"
} | https://api.github.com/repos/psf/requests/issues/1225/timeline | null | completed | null | null | false | [
"Wow. That's not been the case for...a while. Want to submit a docs PR to remove it? I'd do it, but I'm preparing to get on a plane.\n",
"Fixed by #1234. Thanks!\n",
"Note that now the `response.reason` attribute is _entirely undocumented_.\n",
"This change did not cause that situation to arise. You're right ... |
https://api.github.com/repos/psf/requests/issues/1224 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1224/labels{/name} | https://api.github.com/repos/psf/requests/issues/1224/comments | https://api.github.com/repos/psf/requests/issues/1224/events | https://github.com/psf/requests/issues/1224 | 11,522,911 | MDU6SXNzdWUxMTUyMjkxMQ== | 1,224 | IOError when accessing a Response object after socket closes | {
"avatar_url": "https://avatars.githubusercontent.com/u/3731972?v=4",
"events_url": "https://api.github.com/users/j8s0n/events{/privacy}",
"followers_url": "https://api.github.com/users/j8s0n/followers",
"following_url": "https://api.github.com/users/j8s0n/following{/other_user}",
"gists_url": "https://api.github.com/users/j8s0n/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/j8s0n",
"id": 3731972,
"login": "j8s0n",
"node_id": "MDQ6VXNlcjM3MzE5NzI=",
"organizations_url": "https://api.github.com/users/j8s0n/orgs",
"received_events_url": "https://api.github.com/users/j8s0n/received_events",
"repos_url": "https://api.github.com/users/j8s0n/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/j8s0n/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j8s0n/subscriptions",
"type": "User",
"url": "https://api.github.com/users/j8s0n",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-02-28T22:35:08Z | 2021-09-09T05:00:36Z | 2013-03-01T00:58:58Z | NONE | resolved | If the server closes the connection immediately after writing the data, an attempt to use the Response object causes an IOError.
``` python
r = requests.get(url)
# Server closes connection
print(r.content) # Throws IOError
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/3731972?v=4",
"events_url": "https://api.github.com/users/j8s0n/events{/privacy}",
"followers_url": "https://api.github.com/users/j8s0n/followers",
"following_url": "https://api.github.com/users/j8s0n/following{/other_user}",
"gists_url": "https://api.github.com/users/j8s0n/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/j8s0n",
"id": 3731972,
"login": "j8s0n",
"node_id": "MDQ6VXNlcjM3MzE5NzI=",
"organizations_url": "https://api.github.com/users/j8s0n/orgs",
"received_events_url": "https://api.github.com/users/j8s0n/received_events",
"repos_url": "https://api.github.com/users/j8s0n/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/j8s0n/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j8s0n/subscriptions",
"type": "User",
"url": "https://api.github.com/users/j8s0n",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1224/reactions"
} | https://api.github.com/repos/psf/requests/issues/1224/timeline | null | completed | null | null | false | [
"Why is this an issue? We can only tell you exactly what happened, which is exactly an error with IO.\n",
"My assumption is that the get() call sends a GET request and captures the output, storing it in the Response object.\nIf that is the case, then I should be able to access that Response as long as it stays in... |
https://api.github.com/repos/psf/requests/issues/1223 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1223/labels{/name} | https://api.github.com/repos/psf/requests/issues/1223/comments | https://api.github.com/repos/psf/requests/issues/1223/events | https://github.com/psf/requests/pull/1223 | 11,515,637 | MDExOlB1bGxSZXF1ZXN0NDM3OTU5MA== | 1,223 | Fixes __getstate__ for session pickling | {
"avatar_url": "https://avatars.githubusercontent.com/u/575533?v=4",
"events_url": "https://api.github.com/users/andrewjesaitis/events{/privacy}",
"followers_url": "https://api.github.com/users/andrewjesaitis/followers",
"following_url": "https://api.github.com/users/andrewjesaitis/following{/other_user}",
"gists_url": "https://api.github.com/users/andrewjesaitis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/andrewjesaitis",
"id": 575533,
"login": "andrewjesaitis",
"node_id": "MDQ6VXNlcjU3NTUzMw==",
"organizations_url": "https://api.github.com/users/andrewjesaitis/orgs",
"received_events_url": "https://api.github.com/users/andrewjesaitis/received_events",
"repos_url": "https://api.github.com/users/andrewjesaitis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/andrewjesaitis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrewjesaitis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/andrewjesaitis",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-02-28T19:36:00Z | 2021-09-08T23:01:11Z | 2013-03-04T22:52:31Z | CONTRIBUTOR | resolved | As noted in #1088, sessions cannot be pickled currently. I ran into this when implementing some multiprocessing functionality for a project.
Here, I'm just checking for `__attrs__` prior to trying to iterate over it. It does occur to me that if `__attrs__` is removed permanently, maybe the `__getstate__` method should just be stubbed out to preserve pickling functionality.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1223/reactions"
} | https://api.github.com/repos/psf/requests/issues/1223/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1223.diff",
"html_url": "https://github.com/psf/requests/pull/1223",
"merged_at": "2013-03-04T22:52:31Z",
"patch_url": "https://github.com/psf/requests/pull/1223.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1223"
} | true | [
":-1: Why not just add `__attrs__` back to the Session object? You also have the code you describe in the PR commented out.\n\nFix it up please?\n",
"Whoops. I committed while I was testing the later possibility of stubbing out the method. I amended back to the way I originally had it.\n\nI'm fine with adding `__... |
https://api.github.com/repos/psf/requests/issues/1222 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1222/labels{/name} | https://api.github.com/repos/psf/requests/issues/1222/comments | https://api.github.com/repos/psf/requests/issues/1222/events | https://github.com/psf/requests/issues/1222 | 11,504,896 | MDU6SXNzdWUxMTUwNDg5Ng== | 1,222 | NameError in virtualenv | {
"avatar_url": "https://avatars.githubusercontent.com/u/2916591?v=4",
"events_url": "https://api.github.com/users/justbrian/events{/privacy}",
"followers_url": "https://api.github.com/users/justbrian/followers",
"following_url": "https://api.github.com/users/justbrian/following{/other_user}",
"gists_url": "https://api.github.com/users/justbrian/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/justbrian",
"id": 2916591,
"login": "justbrian",
"node_id": "MDQ6VXNlcjI5MTY1OTE=",
"organizations_url": "https://api.github.com/users/justbrian/orgs",
"received_events_url": "https://api.github.com/users/justbrian/received_events",
"repos_url": "https://api.github.com/users/justbrian/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/justbrian/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/justbrian/subscriptions",
"type": "User",
"url": "https://api.github.com/users/justbrian",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-02-28T15:27:17Z | 2021-09-09T04:00:50Z | 2013-02-28T15:34:32Z | NONE | resolved | Hello,
I have just attempted to install requests into a virtualenv environment and am getting the error:
NameError: name 'CERT_NONE' is not defined
The full stacktrace is below. I tried to install requests with the command pip install -U requests in my virtual environment. An admittedly quick Google search didn't turn up anything, but I am assuming its user error. Am I doing it wrong somehow?
This is on Red Hat Enterprise Linux 5 with Python 2.7.3. I have tried virtualenv with and without site packages, same error either way. If there is any more information I can provide, feel free to let me know.
Thanks,
Brian
Full Stack trace from error:
249 File "requests/packages/**init**.py", line 3, in <module>
250
251 from . import urllib3
252
253 File "requests/packages/urllib3/**init**.py", line 16, in <module>
254
255 from .connectionpool import (
256
257 File "requests/packages/urllib3/connectionpool.py", line 45, in <module>
258
259 from .util import get_host, is_connection_dropped, ssl_wrap_socket
260
261 File "requests/packages/urllib3/util.py", line 293, in <module>
262
263 def ssl_wrap_socket(sock, keyfile=None, certfile=None, cert_reqs=CERT_NONE,
264
265 NameError: name 'CERT_NONE' is not defined
266
267 ----------------------------------------
268
269 Command python setup.py egg_info failed with error code 1 in /home/bneal/pyv/build/requests
270
271 Exception information:
272 Traceback (most recent call last):
273 File "/home/bneal/pyv/lib/python2.7/site-packages/pip-1.2.1-py2.7.egg/pip/basecommand.py", line 107, in main
274 status = self.run(options, args)
275 File "/home/bneal/pyv/lib/python2.7/site-packages/pip-1.2.1-py2.7.egg/pip/commands/install.py", line 256, in run
276 requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
277 File "/home/bneal/pyv/lib/python2.7/site-packages/pip-1.2.1-py2.7.egg/pip/req.py", line 1042, in prepare_files
278 req_to_install.run_egg_info()
279 File "/home/bneal/pyv/lib/python2.7/site-packages/pip-1.2.1-py2.7.egg/pip/req.py", line 236, in run_egg_info
280 command_desc='python setup.py egg_info')
281 File "/home/bneal/pyv/lib/python2.7/site-packages/pip-1.2.1-py2.7.egg/pip/util.py", line 612, in call_subprocess
282 % (command_desc, proc.returncode, cwd))
283 InstallationError: Command python setup.py egg_info failed with error code 1 in /home/bneal/pyv/build/requests
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1222/reactions"
} | https://api.github.com/repos/psf/requests/issues/1222/timeline | null | completed | null | null | false | [
"Duplicate of #1221. This seems to be related to your not having SSL installed or properly configured/linked in Python. The fix is being worked out in shazow/urllib3 and will be imported as soon as it's ready.\n",
"The fix has been on requests master for a long time. (#1128)\n",
"Ah @t-8ch sorry for the confusi... |
https://api.github.com/repos/psf/requests/issues/1221 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1221/labels{/name} | https://api.github.com/repos/psf/requests/issues/1221/comments | https://api.github.com/repos/psf/requests/issues/1221/events | https://github.com/psf/requests/pull/1221 | 11,485,378 | MDExOlB1bGxSZXF1ZXN0NDM2NDUxMA== | 1,221 | I do not agree this behavior should be occurring in master branch | {
"avatar_url": "https://avatars.githubusercontent.com/u/52170?v=4",
"events_url": "https://api.github.com/users/rpherrera/events{/privacy}",
"followers_url": "https://api.github.com/users/rpherrera/followers",
"following_url": "https://api.github.com/users/rpherrera/following{/other_user}",
"gists_url": "https://api.github.com/users/rpherrera/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rpherrera",
"id": 52170,
"login": "rpherrera",
"node_id": "MDQ6VXNlcjUyMTcw",
"organizations_url": "https://api.github.com/users/rpherrera/orgs",
"received_events_url": "https://api.github.com/users/rpherrera/received_events",
"repos_url": "https://api.github.com/users/rpherrera/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rpherrera/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rpherrera/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rpherrera",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-28T02:38:06Z | 2021-09-08T19:00:52Z | 2013-02-28T02:42:41Z | NONE | resolved | Installing requests from pip gives me the following error:
```
Unpacking ./requests/requests-1.0.4.zip
Running setup.py egg_info for package from file:///home/fclbot/requests/requests-1.0.4.zip
Traceback (most recent call last):
File "<string>", line 14, in <module>
File "/tmp/pip-a6e6xF-build/setup.py", line 6, in <module>
import requests
File "requests/__init__.py", line 52, in <module>
from . import utils
File "requests/utils.py", line 22, in <module>
from .compat import parse_http_list as _parse_list_header
File "requests/compat.py", line 7, in <module>
from .packages import charade as chardet
File "requests/packages/__init__.py", line 3, in <module>
from . import urllib3
File "requests/packages/urllib3/__init__.py", line 16, in <module>
from .connectionpool import (
File "requests/packages/urllib3/connectionpool.py", line 45, in <module>
from .util import get_host, is_connection_dropped, ssl_wrap_socket
File "requests/packages/urllib3/util.py", line 293, in <module>
def ssl_wrap_socket(sock, keyfile=None, certfile=None, cert_reqs=CERT_NONE,
NameError: name 'CERT_NONE' is not defined
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 14, in <module>
File "/tmp/pip-a6e6xF-build/setup.py", line 6, in <module>
import requests
File "requests/__init__.py", line 52, in <module>
from . import utils
File "requests/utils.py", line 22, in <module>
from .compat import parse_http_list as _parse_list_header
File "requests/compat.py", line 7, in <module>
from .packages import charade as chardet
File "requests/packages/__init__.py", line 3, in <module>
from . import urllib3
File "requests/packages/urllib3/__init__.py", line 16, in <module>
from .connectionpool import (
File "requests/packages/urllib3/connectionpool.py", line 45, in <module>
from .util import get_host, is_connection_dropped, ssl_wrap_socket
File "requests/packages/urllib3/util.py", line 293, in <module>
def ssl_wrap_socket(sock, keyfile=None, certfile=None, cert_reqs=CERT_NONE,
NameError: name 'CERT_NONE' is not defined
```
---
This fix is a simple comment over buggy code, so this error would not happen again until you fix it in a proper way.
It is exactly the same as discussed in: http://stackoverflow.com/questions/14919557/how-to-get-urllib3-and-requests-working-with-jython-2-7-beta-1
Important: It does not applies only to jython users, but python users are being affected by this error too.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1221/reactions"
} | https://api.github.com/repos/psf/requests/issues/1221/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1221.diff",
"html_url": "https://github.com/psf/requests/pull/1221",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1221.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1221"
} | true | [
"You need to take a better look at your problem. The `NameError` caused in your example is not in the code you just commented out: CERT_NONE is not in any of that code. This bug cannot possibly be fixed by this PR.\n",
"Ugh, ignore the above, that was a lousy reason. However, this bug is in urllib3, so we aren't ... |
https://api.github.com/repos/psf/requests/issues/1220 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1220/labels{/name} | https://api.github.com/repos/psf/requests/issues/1220/comments | https://api.github.com/repos/psf/requests/issues/1220/events | https://github.com/psf/requests/issues/1220 | 11,484,506 | MDU6SXNzdWUxMTQ4NDUwNg== | 1,220 | raise_for_status does not raise for redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/252280?v=4",
"events_url": "https://api.github.com/users/mjallday/events{/privacy}",
"followers_url": "https://api.github.com/users/mjallday/followers",
"following_url": "https://api.github.com/users/mjallday/following{/other_user}",
"gists_url": "https://api.github.com/users/mjallday/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mjallday",
"id": 252280,
"login": "mjallday",
"node_id": "MDQ6VXNlcjI1MjI4MA==",
"organizations_url": "https://api.github.com/users/mjallday/orgs",
"received_events_url": "https://api.github.com/users/mjallday/received_events",
"repos_url": "https://api.github.com/users/mjallday/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mjallday/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mjallday/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mjallday",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 15 | 2013-02-28T01:55:11Z | 2021-09-09T04:00:50Z | 2013-03-01T23:59:11Z | NONE | resolved | According [to the code](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L648) it no longer raises for redirects, this used to be an option called `allow_redirects`.
Now it doesn't raise for 3xx responses but [the docs say](http://docs.python-requests.org/en/latest/user/quickstart/#response-status-codes) :
> If we made a bad request (non-200 response), we can raise it with Response.raise_for_status():
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1220/reactions"
} | https://api.github.com/repos/psf/requests/issues/1220/timeline | null | completed | null | null | false | [
"I contend the docs are poorly phrased. Redirects are expected and a natural part of HTTP, and they should not cause exceptions.\n",
"The better doc would be:\n\n> If we made a bad request (4xx response), we can raise it with Response.raise_for_status():\n\nWe might want to include 5xx responses there too, though... |
https://api.github.com/repos/psf/requests/issues/1219 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1219/labels{/name} | https://api.github.com/repos/psf/requests/issues/1219/comments | https://api.github.com/repos/psf/requests/issues/1219/events | https://github.com/psf/requests/pull/1219 | 11,461,537 | MDExOlB1bGxSZXF1ZXN0NDM1MTg1OA== | 1,219 | Adding max_retries as an argument | {
"avatar_url": "https://avatars.githubusercontent.com/u/70800?v=4",
"events_url": "https://api.github.com/users/Wilfred/events{/privacy}",
"followers_url": "https://api.github.com/users/Wilfred/followers",
"following_url": "https://api.github.com/users/Wilfred/following{/other_user}",
"gists_url": "https://api.github.com/users/Wilfred/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Wilfred",
"id": 70800,
"login": "Wilfred",
"node_id": "MDQ6VXNlcjcwODAw",
"organizations_url": "https://api.github.com/users/Wilfred/orgs",
"received_events_url": "https://api.github.com/users/Wilfred/received_events",
"repos_url": "https://api.github.com/users/Wilfred/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Wilfred/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Wilfred/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Wilfred",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-02-27T16:04:34Z | 2021-09-09T00:01:17Z | 2013-03-02T21:02:27Z | CONTRIBUTOR | resolved | Related ticket: #1208
This pull request adds support for `max_retries` as an argument to `requests.request`. I think that since we already support `timeout` as a top-level argument then it makes sense to support `max_retries` too.
I've added a unit test, but this is a very difficult thing to test for. I can't see any easy way to simulate an unreliable connection.
Please let me know what you think.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1219/reactions"
} | https://api.github.com/repos/psf/requests/issues/1219/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1219.diff",
"html_url": "https://github.com/psf/requests/pull/1219",
"merged_at": "2013-03-02T21:02:27Z",
"patch_url": "https://github.com/psf/requests/pull/1219.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1219"
} | true | [
"There is nothing wrong with this PR, but it won't be accepted. Requests is in [feature freeze](http://docs.python-requests.org/en/latest/dev/todo/#feature-freeze), and that goes doubly for changes that affect the API. As @sigmavirus24 pointed out in #1208, there are plenty of ways to specify this value.\n",
"Tha... |
https://api.github.com/repos/psf/requests/issues/1218 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1218/labels{/name} | https://api.github.com/repos/psf/requests/issues/1218/comments | https://api.github.com/repos/psf/requests/issues/1218/events | https://github.com/psf/requests/issues/1218 | 11,418,135 | MDU6SXNzdWUxMTQxODEzNQ== | 1,218 | HTTPS proxy not being used - max retries exceeded | {
"avatar_url": "https://avatars.githubusercontent.com/u/2835900?v=4",
"events_url": "https://api.github.com/users/gfairchild/events{/privacy}",
"followers_url": "https://api.github.com/users/gfairchild/followers",
"following_url": "https://api.github.com/users/gfairchild/following{/other_user}",
"gists_url": "https://api.github.com/users/gfairchild/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gfairchild",
"id": 2835900,
"login": "gfairchild",
"node_id": "MDQ6VXNlcjI4MzU5MDA=",
"organizations_url": "https://api.github.com/users/gfairchild/orgs",
"received_events_url": "https://api.github.com/users/gfairchild/received_events",
"repos_url": "https://api.github.com/users/gfairchild/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gfairchild/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gfairchild/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gfairchild",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-26T17:06:10Z | 2021-09-08T04:00:40Z | 2013-02-26T17:37:41Z | NONE | resolved | I'm behind a proxy at work, and I'm having issues getting requests to use the proxy. urllib2 is able to use it just fine, but requests fails. I've tried both setting an environment variable (both HTTPS_PROXY and https_proxy) and passing in a dict, but neither work.
I'm on OSX 10.7.5 using Python 2.7.3 and requests 1.1.0 installed in a virtualenv via pip.
```
(osx)gfairchild@stueyemac ~> set | grep -i proxy
HTTPS_PROXY=https://proxy.com:8080
https_proxy=https://proxy.com:8080
(osx)gfairchild@stueyemac ~> python
Python 2.7.3 (v2.7.3:70274d53c1dd, Apr 9 2012, 20:52:43)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import urllib2
>>> r = urllib2.urlopen('https://google.com')
>>> print r.read()
<!doctype html><html itemscope="itemscope" itemtype="http://schema.org/WebPage"><head><meta content="Search the world's information, including webpages, images, videos and more. Google has many special features to help you find exactly what you're looking for." name="description"><meta content="noodp" name="robots"><meta itemprop="image" content="/images/google_favicon_128.png"><title>Google</title><script>(function(){
window.google={kEI:"I-gsUdvaLMn-0gHWhIHIAg",getEI:function(a){for(var b;a&&(!a.getAttribute||!(b=a.getAttribute("eid")));)a=a.parentNode;return b||google.kEI},https:function(){return"https:"==window.location.protocol},kEXPI:"17259,18168,39523,4000116,4001569,4001948,4001959,4001975,4002001,4002159,4002562,4002734,4002855,4002858,4003372,4003374,4003387,4003514,4003575,4003638,4003917,4003944,4003982,4004015,4004064,4004074,4004083,4004152,4004181,4004214,4004241,4004276,4004298",kCSI:{e:"17259,18168,39523,4000116,4001569,4001948,4001959,4001975,4002001,4002159,4002562,4002734,4002855,4002858,4003372,4003374,4003387,4003514,4003575,4003638,4003917,4003944,4003982,4004015,4004064,4004074,4004083,4004152,4004181,4004214,4004241,4004276,4004298",ei:"I-gsUdvaLMn-0gHWhIHIAg"},authuser:0,ml:function(){},kHL:"en",time:function(){return(new Date).getTime()},log:function(a,
b,c,k){var d=new Image,f=google.lc,e=google.li,g="";d.onerror=d.onload=d.onabort=function(){delete f[e]};f[e]=d;!c&&-1==b.search("&ei=")&&(g="&ei="+google.getEI(k));c=c||"/gen_204?atyp=i&ct="+a+"&cad="+b+g+"&zx="+google.time();a=/^http:/i;a.test(c)&&google.https()?(google.ml(Error("GLMM"),!1,{src:c}),delete f[e]):(d.src=c,google.li=e+1)},lc:[],li:0,Toolbelt:{},y:{},x:function(a,b){google.y[a.id]=[a,b];return!1},load:function(a,b){google.x({id:"l"+a},function(){google.load(a,b)})}};
})();
(function(){var d=!1;google.sn="webhp";google.timers={};google.startTick=function(a,b){google.timers[a]={t:{start:google.time()},bfr:!!b}};google.tick=function(a,b,h){google.timers[a]||google.startTick(a);google.timers[a].t[b]=h||google.time()};google.startTick("load",!0);
try{}catch(e){}})();
var _gjwl=location;function _gjuc(){var a=_gjwl.href.indexOf("#");if(0<=a&&(a=_gjwl.href.substring(a),0<a.indexOf("&q=")||0<=a.indexOf("#q=")))if(a=a.substring(1),-1==a.indexOf("#")){for(var d=0;d<a.length;){var b=d;"&"==a.charAt(b)&&++b;var c=a.indexOf("&",b);-1==c&&(c=a.length);b=a.substring(b,c);if(0==b.indexOf("fp="))a=a.substring(0,d)+a.substring(c,a.length),c=d;else if("cad=h"==b)return 0;d=c}_gjwl.href="/search?"+a+"&cad=h";return 1}return 0}
function _gjp(){(!window._gjwl.hash||!window._gjuc())&&setTimeout(_gjp,500)};
window._gjp&&_gjp();</script><style>#gbar,#guser{font-size:13px;padding-top:1px !important;}#gbar{height:22px}#guser{padding-bottom:7px !important;text-align:right}.gbh,.gbd{border-top:1px solid #c9d7f1;font-size:1px}.gbh{height:0;position:absolute;top:24px;width:100%}@media all{.gb1{height:22;margin-right:.5em;vertical-align:top}#gbar{float:left}}a.gb1,a.gb4{text-decoration:underline !important}a.gb1,a.gb4{color:#00c !important}.gbi .gb4{color:#dd8e27 !important}.gbf .gb4{color:#900 !important}</style><style>.h{font-family:arial,sans-serif}body{font-family:arial,sans-serif}td{font-family:arial,sans-serif}a{font-family:arial,sans-serif}p{font-family:arial,sans-serif}body{margin:0;overflow-y:scroll}#gog{padding:3px 8px 0}.h{color:#36c}.q{color:#00c}.ts{border-collapse:collapse}td{line-height:.8em}.gac_m td{line-height:17px}form{margin-bottom:20px}.ts td{padding:0}em{font-weight:bold;font-style:normal}.lst{height:25px;width:496px;font:18px arial,sans-serif}.gsfi{font:18px arial,sans-serif}.gsfs{font:17px arial,sans-serif}.ds{display:inline-box;display: inline-block;margin:3px 0 4px;margin-left:4px}input{font-family:inherit}body{background:#fff;color:black}a.gb1{color:#11c !important}a.gb2{color:#11c !important}a.gb3{color:#11c !important}a.gb4{color:#11c !important}.sblc{padding-top:5px}.lsbb{background:#eee;border:solid 1px;border-color:#ccc #999 #999 #ccc;height:30px}a{color:#11c;text-decoration:none}a:hover{text-decoration:underline}a:active{text-decoration:underline}.fl a{color:#36c}a:visited{color:#551a8b}a.gb1{text-decoration:underline}a.gb4{text-decoration:underline}a.gb3:hover{text-decoration:none}.sblc a{display:block;margin:2px 0;margin-left:13px;font-size:11px}#ghead a.gb2:hover{color:#fff !important}.lsbb{display:block}.ftl{display:inline-block;margin:0 12px}.lsb{background:url(/images/srpr/nav_logo80.png) 0 -258px repeat-x;border:none;color:#000;cursor:pointer;height:30px;margin:0;outline:0;font:15px arial,sans-serif;vertical-align:top}#fll a{display:inline-block;margin:0 12px}.lsb:active{background:#ccc}.lst:focus{outline:none}#addlang a{padding:0 3px}</style><script></script> </head><body dir="ltr" bgcolor="#fff"><script>(function(){var src='/images/srpr/nav_logo80.png';var iesg=false;document.body.onload = function(){window.n && window.n();if (document.images){new Image().src=src;}
if (!iesg){document.f&&document.f.q.focus();document.gbqf&&document.gbqf.q.focus();}
}
})();</script><textarea id="csi" style="display:none"></textarea><div id="mngb"><div id=gbar><nobr><b class=gb1>Search</b> <a class=gb1 href="https://www.google.com/imghp?hl=en&tab=wi">Images</a> <a class=gb1 href="https://maps.google.com/maps?hl=en&tab=wl">Maps</a> <a class=gb1 href="https://play.google.com/?hl=en&tab=w8">Play</a> <a class=gb1 href="https://www.youtube.com/?tab=w1">YouTube</a> <a class=gb1 href="https://news.google.com/nwshp?hl=en&tab=wn">News</a> <a class=gb1 href="https://mail.google.com/mail/?tab=wm">Gmail</a> <a class=gb1 href="https://drive.google.com/?tab=wo">Drive</a> <a class=gb1 style="text-decoration:none" href="http://www.google.com/intl/en/options/"><u>More</u> »</a></nobr></div><div id=guser width=100%><nobr><span id=gbn class=gbi></span><span id=gbf class=gbf></span><span id=gbe></span><a href="http://www.google.com/history/optout?hl=en" class=gb4>Web History</a> | <a href="/preferences?hl=en" class=gb4>Settings</a> | <a target=_top id=gb_70 href="https://accounts.google.com/ServiceLogin?hl=en&continue=https://www.google.com/" class=gb4>Sign in</a></nobr></div><div class=gbh style=left:0></div><div class=gbh style=right:0></div></div><iframe name="wgjf" style="display:none"></iframe><center><br clear="all" id="lgpd"><div id="lga"><img alt="Google" height="95" src="/intl/en_ALL/images/srpr/logo1w.png" width="275" id="hplogo" onload="window.lol&&lol()" style="padding:28px 0 14px"><br><br></div><form action="/search" name="f"><table cellpadding="0" cellspacing="0"><tr valign="top"><td width="25%"> </td><td align="center" nowrap="nowrap"><input name="ie" value="ISO-8859-1" type="hidden"><input value="en" name="hl" type="hidden"><input name="source" type="hidden" value="hp"><div class="ds" style="height:32px;margin:4px 0"><input autocomplete="off" class="lst" value="" title="Google Search" maxlength="2048" name="q" size="57" style="color:#000;margin:0;padding:5px 8px 0 6px;vertical-align:top"></div><br style="line-height:0"><span class="ds"><span class="lsbb"><input class="lsb" value="Google Search" name="btnG" type="submit"></span></span><span class="ds"><span class="lsbb"><input class="lsb" value="I'm Feeling Lucky" name="btnI" type="submit" onclick="if(this.form.q.value)this.checked=1; else top.location='/doodles/'"></span></span></td><td class="fl sblc" align="left" nowrap="nowrap" width="25%"><a href="/advanced_search?hl=en&authuser=0">Advanced search</a><a href="/language_tools?hl=en&authuser=0">Language tools</a></td></tr></table><input type="hidden" id="gbv" name="gbv" value="1"></form><div id="gac_scont"></div><div style="font-size:83%;min-height:3.5em"><br></div><span id="footer"><div style="font-size:10pt"><div id="fll" style="margin:19px auto;text-align:center"><a href="/intl/en/ads/">Advertising Programs</a><a href="/services/">Business Solutions</a><a href="https://plus.google.com/116899029375914044550" rel="publisher">+Google</a><a href="/intl/en/about.html">About Google</a></div></div><p style="color:#767676;font-size:8pt">© 2012 - <a href="/intl/en/policies/">Privacy & Terms</a></p></span></center><div id=xjsd></div><div id=xjsi><script>if(google.y)google.y.first=[];(function(){var b;function c(a){window.setTimeout(function(){var d=document.createElement("script");d.src=a;document.getElementById("xjsd").appendChild(d)},0)}google.dljp=function(a){b=a;google.xjsi||(google.xjsu=a,c(b))};google.dlj=c;})();
if(!google.xjs){google.dstr=[];google.rein=[];window._=window._||{};window._._DumpException=function(e){throw e};if(google.timers&&google.timers.load.t){google.timers.load.t.xjsls=new Date().getTime();}google.dljp('/xjs/_/js/hp/sb_he,pcc/rt\x3dj/ver\x3ddUr8sRKOHrQ.en_US./d\x3d1/sv\x3d1/rs\x3dAItRSTMOuVd64TXf59sLZpeyfeaOnqHKgQ');google.xjs=1;}google.pmc={sb:{"agen":false,"cgen":true,"client":"heirloom-hp","dh":true,"ds":"","eqch":true,"fl":true,"host":"google.com","jsonp":true,"msgs":{"lcky":"I\u0026#39;m Feeling Lucky","lml":"Learn more","oskt":"Input tools","psrc":"This search was removed from your \u003Ca href=\"/history\"\u003EWeb History\u003C/a\u003E","psrl":"Remove","sbit":"Search by image","srch":"Google Search"},"ovr":{"l":1,"ms":1},"pq":"","qcpw":false,"scd":10,"sce":5,"stok":"2TLNAUa1t9yVii-aHCy9IeO1J4M"},hp:{},pcc:{}};google.y.first.push(function(){if(google.med){google.med('init');google.initHistory();google.med('history');}google.History&&google.History.initialize('/');google.hs&&google.hs.init&&google.hs.init()});if(google.j&&google.j.en&&google.j.xi){window.setTimeout(google.j.xi,0);}</script></div><script>(function(){var b,c,d,e;function g(a,f){a.removeEventListener?(a.removeEventListener("load",f,!1),a.removeEventListener("error",f,!1)):(a.detachEvent("onload",f),a.detachEvent("onerror",f))}function h(a){e=(new Date).getTime();++c;a=a||window.event;a=a.target||a.srcElement;g(a,h)}var k=document.getElementsByTagName("img");b=k.length;
for(var l=c=0,m;l<b;++l)m=k[l],m.complete||"string"!=typeof m.src||!m.src?++c:m.addEventListener?(m.addEventListener("load",h,!1),m.addEventListener("error",h,!1)):(m.attachEvent("onload",h),m.attachEvent("onerror",h));d=b-c;
function n(){if(google.timers.load.t){google.timers.load.t.ol=(new Date).getTime();google.timers.load.t.iml=e;google.kCSI.imc=c;google.kCSI.imn=b;google.kCSI.imp=d;void 0!==google.stt&&(google.kCSI.stt=google.stt);google.csiReport&&google.csiReport()}}window.addEventListener?window.addEventListener("load",n,!1):window.attachEvent&&window.attachEvent("onload",n);google.timers.load.t.prt=e=(new Date).getTime();})();
</script></body></html>
>>> import requests
>>> r = requests.get('https://google.com')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/adapters.py", line 209, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='proxy.com', port=8080): Max retries exceeded with url: https://google.com/ (Caused by <class 'socket.error'>: [Errno 54] Connection reset by peer)
>>> p = {'https': 'https://proxy.com:8080',}
>>> r = requests.get('https://google.com', proxies=p)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "/Users/gfairchild/Documents/work/compepi/Twitter/lib/osx/lib/python2.7/site-packages/requests/adapters.py", line 209, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='proxy.com', port=8080): Max retries exceeded with url: https://google.com/ (Caused by <class 'socket.error'>: [Errno 54] Connection reset by peer)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1218/reactions"
} | https://api.github.com/repos/psf/requests/issues/1218/timeline | null | completed | null | null | false | [
"I believe this is a duplicate and related to shazow/urllib3#139\n\n@Lukasa thoughts?\n",
"Ah yes, it looks like you may be right. I just looked at the open issues and didn't think to look at the closed issues.\n",
"No worries. We're just waiting for that pull request to land before we can support this. I belie... |
https://api.github.com/repos/psf/requests/issues/1217 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1217/labels{/name} | https://api.github.com/repos/psf/requests/issues/1217/comments | https://api.github.com/repos/psf/requests/issues/1217/events | https://github.com/psf/requests/issues/1217 | 11,387,129 | MDU6SXNzdWUxMTM4NzEyOQ== | 1,217 | Make documentation for old versions of requests available | {
"avatar_url": "https://avatars.githubusercontent.com/u/299979?v=4",
"events_url": "https://api.github.com/users/melinath/events{/privacy}",
"followers_url": "https://api.github.com/users/melinath/followers",
"following_url": "https://api.github.com/users/melinath/following{/other_user}",
"gists_url": "https://api.github.com/users/melinath/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/melinath",
"id": 299979,
"login": "melinath",
"node_id": "MDQ6VXNlcjI5OTk3OQ==",
"organizations_url": "https://api.github.com/users/melinath/orgs",
"received_events_url": "https://api.github.com/users/melinath/received_events",
"repos_url": "https://api.github.com/users/melinath/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/melinath/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/melinath/subscriptions",
"type": "User",
"url": "https://api.github.com/users/melinath",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-02-26T00:01:28Z | 2021-09-09T04:00:41Z | 2013-04-01T18:34:10Z | NONE | resolved | I can't keep up with the progress that requests is making in one of my projects. On the one hand, it's great that requests is constantly being developed. On the other hand, I can no longer find the documentation which applies to the version I'm actually developing with (0.14.2), which is inconvenient.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1217/reactions"
} | https://api.github.com/repos/psf/requests/issues/1217/timeline | null | completed | null | null | false | [
"I know I can view it in the github code viewer; what I'm asking is that old doc versions be included on readthedocs.\n",
"They used to be included, but RTD's version picker got absurd after 10+ versions.\n",
"Yeah, I've run into that issue with their UI as well. You've inspired me to open a ticket on the subje... |
https://api.github.com/repos/psf/requests/issues/1216 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1216/labels{/name} | https://api.github.com/repos/psf/requests/issues/1216/comments | https://api.github.com/repos/psf/requests/issues/1216/events | https://github.com/psf/requests/pull/1216 | 11,343,410 | MDExOlB1bGxSZXF1ZXN0NDI5NjE0Nw== | 1,216 | Not sure if minor spelling mishap | {
"avatar_url": "https://avatars.githubusercontent.com/u/897351?v=4",
"events_url": "https://api.github.com/users/rhyselsmore/events{/privacy}",
"followers_url": "https://api.github.com/users/rhyselsmore/followers",
"following_url": "https://api.github.com/users/rhyselsmore/following{/other_user}",
"gists_url": "https://api.github.com/users/rhyselsmore/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rhyselsmore",
"id": 897351,
"login": "rhyselsmore",
"node_id": "MDQ6VXNlcjg5NzM1MQ==",
"organizations_url": "https://api.github.com/users/rhyselsmore/orgs",
"received_events_url": "https://api.github.com/users/rhyselsmore/received_events",
"repos_url": "https://api.github.com/users/rhyselsmore/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rhyselsmore/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rhyselsmore/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rhyselsmore",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-02-25T00:21:02Z | 2021-09-08T19:00:52Z | 2013-02-25T09:02:43Z | NONE | resolved | Checked it out, couldn't see pycon as a syntax highlighter (not trying to be a smart ass either :sparkles:)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1216/reactions"
} | https://api.github.com/repos/psf/requests/issues/1216/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1216.diff",
"html_url": "https://github.com/psf/requests/pull/1216",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1216.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1216"
} | true | [
"pycon works on GitHub, but not sphinx if I remember correctly... then again \nGitHub uses pygments and so does sphinx... I'm honestly not sure now\nOn Sun, Feb 24, 2013 at 04:21:06PM -0800, Rhys Elsmore wrote:\n\n> Checked it out, couldn't see pycon as a syntax highlighter (not trying to be a smart ass either :spa... |
https://api.github.com/repos/psf/requests/issues/1215 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1215/labels{/name} | https://api.github.com/repos/psf/requests/issues/1215/comments | https://api.github.com/repos/psf/requests/issues/1215/events | https://github.com/psf/requests/issues/1215 | 11,335,111 | MDU6SXNzdWUxMTMzNTExMQ== | 1,215 | Requests doesn't compute Content-Length correctly when transmitting OAuth params in request body. Change for issue #1159 regressed fix for issue #1096. | {
"avatar_url": "https://avatars.githubusercontent.com/u/470362?v=4",
"events_url": "https://api.github.com/users/matthewlmcclure/events{/privacy}",
"followers_url": "https://api.github.com/users/matthewlmcclure/followers",
"following_url": "https://api.github.com/users/matthewlmcclure/following{/other_user}",
"gists_url": "https://api.github.com/users/matthewlmcclure/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/matthewlmcclure",
"id": 470362,
"login": "matthewlmcclure",
"node_id": "MDQ6VXNlcjQ3MDM2Mg==",
"organizations_url": "https://api.github.com/users/matthewlmcclure/orgs",
"received_events_url": "https://api.github.com/users/matthewlmcclure/received_events",
"repos_url": "https://api.github.com/users/matthewlmcclure/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/matthewlmcclure/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/matthewlmcclure/subscriptions",
"type": "User",
"url": "https://api.github.com/users/matthewlmcclure",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-02-24T14:30:55Z | 2021-09-09T05:00:38Z | 2013-02-25T14:34:06Z | CONTRIBUTOR | resolved | The change for #1159 regressed the fix for #1096. Recomputing Content-Length for requests that transmit OAuth params in the request body is broken again. Here's a test case:
```
[mlm@matt-mmf-macbook.local:~]
$ ipython
Python 2.7.3 (default, Sep 15 2012, 19:45:36)
Type "copyright", "credits" or "license" for more information.
IPython 0.13.1 -- An enhanced Interactive Python.
? -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help -> Python's own help system.
object? -> Details about 'object', use 'object??' for extra details.
In [1]: import requests
In [2]: from requests_oauthlib import OAuth1
In [3]: oauth = OAuth1(client_key=u'a-client-id', client_secret=u'a-client-secret', callback_uri=u'http://example.com/oauth_callback', signature_type=u'BODY')
In [4]: req = requests.Request(method='POST', url='http://example.com/request_token', headers={ 'Accept': 'application/x-www-form-urlencoded', 'Content-Type': 'application/x-www-form-urlencoded' }, auth=oauth).prepare()
In [5]: req.__dict__Out[5]:
{'body': u'oauth_nonce=119221505668693451461361716039&oauth_timestamp=1361716039&oauth_version=1.0&oauth_signature_method=HMAC-SHA1&oauth_consumer_key=a-client-id&oauth_callback=http%3A%2F%2Fexample.com%2Foauth_callback&oauth_signature=azH8mCrSMYvEpQ7oonDIoIq38oQ%3D',
'headers': {'Accept': 'application/x-www-form-urlencoded',
'Content-Length': '0',
'Content-Type': u'application/x-www-form-urlencoded'},
'hooks': {'response': []},
'method': 'POST',
'url': u'http://example.com/request_token'}
In [6]: resp = requests.request(method='POST', url='http://example.com/request_token', headers={ 'Accept': 'application/x-www-form-urlencoded', 'Content-Type': 'application/x-www-form-urlencoded' }, allow_redirects=False, auth=oauth)
In [7]: resp.request.__dict__
Out[7]:
{'body': u'oauth_nonce=40755579898176978971361716049&oauth_timestamp=1361716049&oauth_version=1.0&oauth_signature_method=HMAC-SHA1&oauth_consumer_key=a-client-id&oauth_callback=http%3A%2F%2Fexample.com%2Foauth_callback&oauth_signature=Ti910zdRt%2BC5UxLG2dJ5eJ%2BkZ90%3D',
'headers': {'Accept': 'application/x-www-form-urlencoded',
'Accept-Encoding': 'gzip, deflate, compress',
'Content-Length': '0',
'Content-Type': u'application/x-www-form-urlencoded',
'User-Agent': 'python-requests/1.1.0 CPython/2.7.3 Darwin/11.4.2'},
'hooks': {'response': []},
'method': 'POST',
'url': u'http://example.com/request_token'}
In [9]:
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1215/reactions"
} | https://api.github.com/repos/psf/requests/issues/1215/timeline | null | completed | null | null | false | [
"I didn't like that pull request anyway. Like we said on that issue, the user should go way out of their way to break things. @kennethreitz do you mind if I revert and push directly to requests? It's really not much of a difficult fix.\n",
"@sigmavirus24 sure, this once :)\n",
"Or you could revert it yourself ;... |
https://api.github.com/repos/psf/requests/issues/1214 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1214/labels{/name} | https://api.github.com/repos/psf/requests/issues/1214/comments | https://api.github.com/repos/psf/requests/issues/1214/events | https://github.com/psf/requests/pull/1214 | 11,317,741 | MDExOlB1bGxSZXF1ZXN0NDI4ODM3Ng== | 1,214 | Status object | {
"avatar_url": "https://avatars.githubusercontent.com/u/251281?v=4",
"events_url": "https://api.github.com/users/DanielOaks/events{/privacy}",
"followers_url": "https://api.github.com/users/DanielOaks/followers",
"following_url": "https://api.github.com/users/DanielOaks/following{/other_user}",
"gists_url": "https://api.github.com/users/DanielOaks/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DanielOaks",
"id": 251281,
"login": "DanielOaks",
"node_id": "MDQ6VXNlcjI1MTI4MQ==",
"organizations_url": "https://api.github.com/users/DanielOaks/orgs",
"received_events_url": "https://api.github.com/users/DanielOaks/received_events",
"repos_url": "https://api.github.com/users/DanielOaks/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DanielOaks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DanielOaks/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DanielOaks",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2013-02-23T09:03:17Z | 2021-09-08T23:08:30Z | 2013-02-23T09:03:39Z | NONE | resolved | I think this is nicer, in fact
| {
"avatar_url": "https://avatars.githubusercontent.com/u/251281?v=4",
"events_url": "https://api.github.com/users/DanielOaks/events{/privacy}",
"followers_url": "https://api.github.com/users/DanielOaks/followers",
"following_url": "https://api.github.com/users/DanielOaks/following{/other_user}",
"gists_url": "https://api.github.com/users/DanielOaks/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DanielOaks",
"id": 251281,
"login": "DanielOaks",
"node_id": "MDQ6VXNlcjI1MTI4MQ==",
"organizations_url": "https://api.github.com/users/DanielOaks/orgs",
"received_events_url": "https://api.github.com/users/DanielOaks/received_events",
"repos_url": "https://api.github.com/users/DanielOaks/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DanielOaks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DanielOaks/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DanielOaks",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1214/reactions"
} | https://api.github.com/repos/psf/requests/issues/1214/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1214.diff",
"html_url": "https://github.com/psf/requests/pull/1214",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1214.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1214"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/1213 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1213/labels{/name} | https://api.github.com/repos/psf/requests/issues/1213/comments | https://api.github.com/repos/psf/requests/issues/1213/events | https://github.com/psf/requests/pull/1213 | 11,315,080 | MDExOlB1bGxSZXF1ZXN0NDI4NzQ1Mg== | 1,213 | Status Code Names/Descriptions | {
"avatar_url": "https://avatars.githubusercontent.com/u/251281?v=4",
"events_url": "https://api.github.com/users/DanielOaks/events{/privacy}",
"followers_url": "https://api.github.com/users/DanielOaks/followers",
"following_url": "https://api.github.com/users/DanielOaks/following{/other_user}",
"gists_url": "https://api.github.com/users/DanielOaks/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DanielOaks",
"id": 251281,
"login": "DanielOaks",
"node_id": "MDQ6VXNlcjI1MTI4MQ==",
"organizations_url": "https://api.github.com/users/DanielOaks/orgs",
"received_events_url": "https://api.github.com/users/DanielOaks/received_events",
"repos_url": "https://api.github.com/users/DanielOaks/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DanielOaks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DanielOaks/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DanielOaks",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-23T03:25:32Z | 2021-09-08T19:00:52Z | 2013-02-25T10:33:06Z | NONE | resolved | This pull request adds printable names for status codes, as both the `requests.status_codes.name` dictionary, and accessible directly from a Response object as `Response.status_name`.
I think it's quite a useful thing to have, say for printing out a name to go with a given status code (especially in the event of a failure.
And uses cases:
``` python
>>> import requests
>>> r = requests.get('https://github.com/timeline.json')
>>> r.status_code
200
>>> r.status_name
'OK'
>>> r = requests.get('https://github.com/timene.js')
>>> r.status_code
404
>>> r.status_name
'Not Found'
>>> r # I also added the status_name to __repr__'s output, so the below is easier to understand at a glance
<Response [404: Not Found]>
>>> requests.status_codes.name[200]
'OK'
>>> requests.status_codes.name[203]
'Non-Authoritative Info'
>>> requests.status_codes.name[405]
'Method Not Allowed'
```
We may even want to add a `requests.status_codes.description` dict later on, having something like a one sentence description of what the code means. Maybe even create a Status class, with the members `code`, `name`, and `description`, accessible as `Response.status`, so you'd do something like this instead:
``` python
>>> r = requests.get('https://github.com/timene.js')
>>> r.status.code
404
>>> r.status.name
'Not Found'
```
Thanks for the awesome library. I dunno how I ever lived without Requests :smile:
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1213/reactions"
} | https://api.github.com/repos/psf/requests/issues/1213/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1213.diff",
"html_url": "https://github.com/psf/requests/pull/1213",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1213.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1213"
} | true | [
"I'm actually quite interested to see what you guys think about that `Status` object idea, at the end of the description up there.\n\nKeeping a shim so that `Response.status_code` gets/sets the value of Response.status.code would be quite simple, and I think that it's cleaner than adding a `Response.status_name` ob... |
https://api.github.com/repos/psf/requests/issues/1212 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1212/labels{/name} | https://api.github.com/repos/psf/requests/issues/1212/comments | https://api.github.com/repos/psf/requests/issues/1212/events | https://github.com/psf/requests/issues/1212 | 11,314,534 | MDU6SXNzdWUxMTMxNDUzNA== | 1,212 | Status Code Descriptions | {
"avatar_url": "https://avatars.githubusercontent.com/u/251281?v=4",
"events_url": "https://api.github.com/users/DanielOaks/events{/privacy}",
"followers_url": "https://api.github.com/users/DanielOaks/followers",
"following_url": "https://api.github.com/users/DanielOaks/following{/other_user}",
"gists_url": "https://api.github.com/users/DanielOaks/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DanielOaks",
"id": 251281,
"login": "DanielOaks",
"node_id": "MDQ6VXNlcjI1MTI4MQ==",
"organizations_url": "https://api.github.com/users/DanielOaks/orgs",
"received_events_url": "https://api.github.com/users/DanielOaks/received_events",
"repos_url": "https://api.github.com/users/DanielOaks/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DanielOaks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DanielOaks/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DanielOaks",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-02-23T02:30:28Z | 2021-09-09T05:00:39Z | 2013-02-23T03:26:57Z | NONE | resolved | I think being able to return a description for HTTP status codes might be nice. Something you could print out along with the status code, in case you had to.
I'm thinking a use case as something along these lines:
``` python
r = requests.get(url, timeout=20)
if r.status_code != requests.codes.ok:
return 'HTTP {code}: {desc}'.format(code=r.status_code,
desc=requests.status_codes.description[r.status_code])
```
With something like this added to request_codes:
``` python
description = {
# ...
403: 'Access Denied',
404: 'File Not Found',
405: 'Method Not Allowed',
406: 'Not Acceptable'
# ...
}
```
And other descriptions mostly grabbed from [Wikipedia.](https://en.wikipedia.org/wiki/List_of_HTTP_status_codes)
I think it'd be a nice addition, especially if we could roll it into `r`, as `r.status_description` or something similar. I can write up some code and submit a PR, if you think this would go well in Requests.
And thanks for the awesome library. I dunno how I ever lived without Requests :smile:
| {
"avatar_url": "https://avatars.githubusercontent.com/u/251281?v=4",
"events_url": "https://api.github.com/users/DanielOaks/events{/privacy}",
"followers_url": "https://api.github.com/users/DanielOaks/followers",
"following_url": "https://api.github.com/users/DanielOaks/following{/other_user}",
"gists_url": "https://api.github.com/users/DanielOaks/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DanielOaks",
"id": 251281,
"login": "DanielOaks",
"node_id": "MDQ6VXNlcjI1MTI4MQ==",
"organizations_url": "https://api.github.com/users/DanielOaks/orgs",
"received_events_url": "https://api.github.com/users/DanielOaks/received_events",
"repos_url": "https://api.github.com/users/DanielOaks/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DanielOaks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DanielOaks/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DanielOaks",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1212/reactions"
} | https://api.github.com/repos/psf/requests/issues/1212/timeline | null | completed | null | null | false | [
"Sorry, should've written the code right away, rather than duping the issue with the PR. See #1213 \n"
] |
https://api.github.com/repos/psf/requests/issues/1211 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1211/labels{/name} | https://api.github.com/repos/psf/requests/issues/1211/comments | https://api.github.com/repos/psf/requests/issues/1211/events | https://github.com/psf/requests/issues/1211 | 11,297,618 | MDU6SXNzdWUxMTI5NzYxOA== | 1,211 | Ability to dump request content | {
"avatar_url": "https://avatars.githubusercontent.com/u/3127473?v=4",
"events_url": "https://api.github.com/users/jrmoserbaltimore/events{/privacy}",
"followers_url": "https://api.github.com/users/jrmoserbaltimore/followers",
"following_url": "https://api.github.com/users/jrmoserbaltimore/following{/other_user}",
"gists_url": "https://api.github.com/users/jrmoserbaltimore/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jrmoserbaltimore",
"id": 3127473,
"login": "jrmoserbaltimore",
"node_id": "MDQ6VXNlcjMxMjc0NzM=",
"organizations_url": "https://api.github.com/users/jrmoserbaltimore/orgs",
"received_events_url": "https://api.github.com/users/jrmoserbaltimore/received_events",
"repos_url": "https://api.github.com/users/jrmoserbaltimore/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jrmoserbaltimore/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jrmoserbaltimore/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jrmoserbaltimore",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-02-22T18:20:23Z | 2021-09-09T05:00:37Z | 2013-02-27T18:47:00Z | NONE | resolved | There is no way to dump request content. Currently digging with tcpdump and wireshark shows that the requests should be going through fine; r.history shows 302 and 401 for a digest authorization, and r.status_code gives 200.
Running curl with the data I'm giving is making the target Web application (a closed-source Java app) take state-altering actions. Running with Python requests is doing absolutely nothing.
The main problem here is I have absolutely no way to debug why this is happening.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1211/reactions"
} | https://api.github.com/repos/psf/requests/issues/1211/timeline | null | completed | null | null | false | [
"If you're digging with Wireshark, you are seeing exactly what went out on the wire. Requests cannot give you better information than that.\n\nAs it turns out, you can get very close to the information you want by examining the `PreparedRequest` that was created. For instance, the request that triggered the 200 is ... |
https://api.github.com/repos/psf/requests/issues/1210 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1210/labels{/name} | https://api.github.com/repos/psf/requests/issues/1210/comments | https://api.github.com/repos/psf/requests/issues/1210/events | https://github.com/psf/requests/pull/1210 | 11,269,160 | MDExOlB1bGxSZXF1ZXN0NDI2NjM1Ng== | 1,210 | Unquote proxy usernames and passwords. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-02-22T00:39:45Z | 2021-09-08T23:01:15Z | 2013-02-25T10:31:01Z | MEMBER | resolved | Should resolve #1207.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1210/reactions"
} | https://api.github.com/repos/psf/requests/issues/1210/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1210.diff",
"html_url": "https://github.com/psf/requests/pull/1210",
"merged_at": "2013-02-25T10:31:01Z",
"patch_url": "https://github.com/psf/requests/pull/1210.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1210"
} | true | [
":cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1209 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1209/labels{/name} | https://api.github.com/repos/psf/requests/issues/1209/comments | https://api.github.com/repos/psf/requests/issues/1209/events | https://github.com/psf/requests/issues/1209 | 11,255,249 | MDU6SXNzdWUxMTI1NTI0OQ== | 1,209 | SSL verification broken if using a proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/238652?v=4",
"events_url": "https://api.github.com/users/schlamar/events{/privacy}",
"followers_url": "https://api.github.com/users/schlamar/followers",
"following_url": "https://api.github.com/users/schlamar/following{/other_user}",
"gists_url": "https://api.github.com/users/schlamar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/schlamar",
"id": 238652,
"login": "schlamar",
"node_id": "MDQ6VXNlcjIzODY1Mg==",
"organizations_url": "https://api.github.com/users/schlamar/orgs",
"received_events_url": "https://api.github.com/users/schlamar/received_events",
"repos_url": "https://api.github.com/users/schlamar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/schlamar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/schlamar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/schlamar",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2013-02-21T19:26:56Z | 2021-09-09T02:11:53Z | 2013-02-22T00:11:46Z | CONTRIBUTOR | resolved | According to #1204 `requests` should fully support HTTP proxies. However, the SSL verification is broken on my system.
If requesting without a proxy, I'm getting as expected:
```
>>> requests.get('https://kennethreitz.org')
requests.exceptions.SSLError: hostname 'kennethreitz.org' doesn't match either
of '*.herokuapp.com', 'herokuapp.com'
```
However, doing the same request via an HTTP proxy:
```
>>> proxies = {'http': 'http://...', 'https': 'http://...'}
>>> requests.get('https://kennethreitz.org', proxies=proxies)
<Response [200]>
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1209/reactions"
} | https://api.github.com/repos/psf/requests/issues/1209/timeline | null | completed | null | null | false | [
"No it isn't. I mean, there are some proxy bugs, but this isn't one, I don't think.\n\nI've not tested this, but I bet that if you run an HTTPS request over an HTTP connection to a proxy, the proxy does the HTTPS termination and then forwards the request to you in plaintext (you should be able to see this in Wiresh... |
https://api.github.com/repos/psf/requests/issues/1208 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1208/labels{/name} | https://api.github.com/repos/psf/requests/issues/1208/comments | https://api.github.com/repos/psf/requests/issues/1208/events | https://github.com/psf/requests/issues/1208 | 11,253,019 | MDU6SXNzdWUxMTI1MzAxOQ== | 1,208 | Not possible to specify max_retries in v1.X? | {
"avatar_url": "https://avatars.githubusercontent.com/u/70800?v=4",
"events_url": "https://api.github.com/users/Wilfred/events{/privacy}",
"followers_url": "https://api.github.com/users/Wilfred/followers",
"following_url": "https://api.github.com/users/Wilfred/following{/other_user}",
"gists_url": "https://api.github.com/users/Wilfred/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Wilfred",
"id": 70800,
"login": "Wilfred",
"node_id": "MDQ6VXNlcjcwODAw",
"organizations_url": "https://api.github.com/users/Wilfred/orgs",
"received_events_url": "https://api.github.com/users/Wilfred/received_events",
"repos_url": "https://api.github.com/users/Wilfred/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Wilfred/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Wilfred/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Wilfred",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-02-21T18:31:16Z | 2021-09-09T05:00:37Z | 2013-02-27T16:10:29Z | CONTRIBUTOR | resolved | In older versions of requests (pre v1.0), I was able to do:
```
requests.get('http://nonexistentdomainfoobar.com', config={"max_retries":10})
```
as far as I can tell, this isn't possible in v.1.0+. `HTTPAdapter.max_retries` uses `DEFAULT_RETRIES` and there's no way to change this.
Would it be possible to restore this feature? If not, perhaps a note in the FAQ informing users that this isn't possible and they'll have to write a loop themselves?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1208/reactions"
} | https://api.github.com/repos/psf/requests/issues/1208/timeline | null | completed | null | null | false | [
"Why not do this?\n\n``` pycon\n>>> import requests\n>>> from requests.adapters import HTTPAdapter\n>>> s = requests.session()\n>>> h = HTTPAdapter()\n>>> h.max_retries = 10\n>>> h.max_retries\n10\n>>> s.mount('http://', h)\n>>> s.mount('https://', h)\n>>> s.get('http://nonexistentdomainfoobar.com')\n```\n\nIt isn'... |
https://api.github.com/repos/psf/requests/issues/1207 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1207/labels{/name} | https://api.github.com/repos/psf/requests/issues/1207/comments | https://api.github.com/repos/psf/requests/issues/1207/events | https://github.com/psf/requests/issues/1207 | 11,248,312 | MDU6SXNzdWUxMTI0ODMxMg== | 1,207 | URL-encoding not handled for proxy username and password | {
"avatar_url": "https://avatars.githubusercontent.com/u/792504?v=4",
"events_url": "https://api.github.com/users/maxbane/events{/privacy}",
"followers_url": "https://api.github.com/users/maxbane/followers",
"following_url": "https://api.github.com/users/maxbane/following{/other_user}",
"gists_url": "https://api.github.com/users/maxbane/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/maxbane",
"id": 792504,
"login": "maxbane",
"node_id": "MDQ6VXNlcjc5MjUwNA==",
"organizations_url": "https://api.github.com/users/maxbane/orgs",
"received_events_url": "https://api.github.com/users/maxbane/received_events",
"repos_url": "https://api.github.com/users/maxbane/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/maxbane/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxbane/subscriptions",
"type": "User",
"url": "https://api.github.com/users/maxbane",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 4 | 2013-02-21T16:38:09Z | 2021-09-09T05:00:38Z | 2013-02-25T23:36:17Z | NONE | resolved | Proxy authentication information is specified by the `proxies` dictionary passed to `requests.get()` and other methods, like so:
```
requests.get(..., proxies = {'http': 'http://user:pass@myproxy.mydomain.com'})
```
Because the username and password are specified as part of a URL, they _must_ be URL-encoded by the caller; otherwise consider what would happen if the user's password or username contained an `@` or a `:`, etc.
So, for example, if my proxy password is `p@ssword!!!`, I need to write my call like this:
```
requests.get(..., proxies = {'http': 'http://user:p%40ssword%21%21%21@myproxy.mydomain.com'})
```
However, this functionality is currently broken, because `utils.get_auth_from_url` does not _decode_ the URL-encoded username and password. The result is that the raw URL-encoded username and password are sent in the `Proxy-Authorization` header to the proxy, but of course the proxy expects the _actual_, decoded username and password, so authentication fails.
It is a one-line fix to perform URL decoding in `utils.get_auth_from_url`. It would also be a good idea to add this to the `test_get_auth_from_url` test case.
I would submit a pull request myself, but the fix I developed was written on company time, so I would need like 7 signatures to release it you. Argh.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1207/reactions"
} | https://api.github.com/repos/psf/requests/issues/1207/timeline | null | completed | null | null | false | [
"That's ok, I'll work on it. =)\n",
"See #1210 for the PR.\n",
"Fixed. =) Thanks for raising the issue!\n",
"Thanks for fixing :+1: \n"
] |
https://api.github.com/repos/psf/requests/issues/1206 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1206/labels{/name} | https://api.github.com/repos/psf/requests/issues/1206/comments | https://api.github.com/repos/psf/requests/issues/1206/events | https://github.com/psf/requests/issues/1206 | 11,202,617 | MDU6SXNzdWUxMTIwMjYxNw== | 1,206 | Pickling of sessions does not work | {
"avatar_url": "https://avatars.githubusercontent.com/u/482701?v=4",
"events_url": "https://api.github.com/users/nityaoberoi/events{/privacy}",
"followers_url": "https://api.github.com/users/nityaoberoi/followers",
"following_url": "https://api.github.com/users/nityaoberoi/following{/other_user}",
"gists_url": "https://api.github.com/users/nityaoberoi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nityaoberoi",
"id": 482701,
"login": "nityaoberoi",
"node_id": "MDQ6VXNlcjQ4MjcwMQ==",
"organizations_url": "https://api.github.com/users/nityaoberoi/orgs",
"received_events_url": "https://api.github.com/users/nityaoberoi/received_events",
"repos_url": "https://api.github.com/users/nityaoberoi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nityaoberoi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nityaoberoi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nityaoberoi",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-02-20T15:53:57Z | 2021-09-09T05:00:39Z | 2013-02-20T15:55:37Z | NONE | resolved | Referring to these lines: https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L457-L458
**attrs** is not defined and hence pickling of the session fails.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1206/reactions"
} | https://api.github.com/repos/psf/requests/issues/1206/timeline | null | completed | null | null | false | [
"Duplicate of #1088\n"
] |
https://api.github.com/repos/psf/requests/issues/1205 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1205/labels{/name} | https://api.github.com/repos/psf/requests/issues/1205/comments | https://api.github.com/repos/psf/requests/issues/1205/events | https://github.com/psf/requests/pull/1205 | 11,197,867 | MDExOlB1bGxSZXF1ZXN0NDIzMTA1Mg== | 1,205 | Missing line was allowing redirects with HEAD | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-02-20T13:59:50Z | 2021-09-08T19:00:51Z | 2013-02-25T10:31:21Z | CONTRIBUTOR | resolved | Closes #1203
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1205/reactions"
} | https://api.github.com/repos/psf/requests/issues/1205/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1205.diff",
"html_url": "https://github.com/psf/requests/pull/1205",
"merged_at": "2013-02-25T10:31:21Z",
"patch_url": "https://github.com/psf/requests/pull/1205.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1205"
} | true | [
":heart:\n",
"Thanks -- I'm the one who opened #1203 .\n",
"You're welcome! I'm always happy to help.\n"
] |
https://api.github.com/repos/psf/requests/issues/1204 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1204/labels{/name} | https://api.github.com/repos/psf/requests/issues/1204/comments | https://api.github.com/repos/psf/requests/issues/1204/events | https://github.com/psf/requests/issues/1204 | 11,197,038 | MDU6SXNzdWUxMTE5NzAzOA== | 1,204 | SSL error 140770FC with requests behind company proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/219063?v=4",
"events_url": "https://api.github.com/users/eddie-dunn/events{/privacy}",
"followers_url": "https://api.github.com/users/eddie-dunn/followers",
"following_url": "https://api.github.com/users/eddie-dunn/following{/other_user}",
"gists_url": "https://api.github.com/users/eddie-dunn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eddie-dunn",
"id": 219063,
"login": "eddie-dunn",
"node_id": "MDQ6VXNlcjIxOTA2Mw==",
"organizations_url": "https://api.github.com/users/eddie-dunn/orgs",
"received_events_url": "https://api.github.com/users/eddie-dunn/received_events",
"repos_url": "https://api.github.com/users/eddie-dunn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eddie-dunn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eddie-dunn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eddie-dunn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 14 | 2013-02-20T13:34:52Z | 2021-09-09T00:34:22Z | 2013-02-21T09:47:48Z | NONE | resolved | I can't use requests for https requests behind my company proxy. I'm not sure whether the problem is due to requests or my company proxy.
Example output:
```
>>> import requests
>>> requests.get("http://www.google.com")
<Response [200]>
>>> requests.get("https://www.google.com")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/edwardd/.local/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/home/edwardd/.local/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/home/edwardd/.local/lib/python2.7/site-packages/requests/sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "/home/edwardd/.local/lib/python2.7/site-packages/requests/sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "/home/edwardd/.local/lib/python2.7/site-packages/requests/adapters.py", line 213, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1204/reactions"
} | https://api.github.com/repos/psf/requests/issues/1204/timeline | null | completed | null | null | false | [
"This is a known issue. I'm surprised I can't find an already open issue in the tracker for it. We're waiting on one [pull request](https://github.com/shazow/urllib3/pull/139) in shazow/urllib3 and it will then be fixed.\n",
"This looks like #1182.\n\nQuoting myself:\n\nDoes your proxy variable have a `https://` ... |
https://api.github.com/repos/psf/requests/issues/1203 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1203/labels{/name} | https://api.github.com/repos/psf/requests/issues/1203/comments | https://api.github.com/repos/psf/requests/issues/1203/events | https://github.com/psf/requests/issues/1203 | 11,192,965 | MDU6SXNzdWUxMTE5Mjk2NQ== | 1,203 | Default value of allow_redirects in HEAD requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/3646679?v=4",
"events_url": "https://api.github.com/users/krawyoti/events{/privacy}",
"followers_url": "https://api.github.com/users/krawyoti/followers",
"following_url": "https://api.github.com/users/krawyoti/following{/other_user}",
"gists_url": "https://api.github.com/users/krawyoti/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/krawyoti",
"id": 3646679,
"login": "krawyoti",
"node_id": "MDQ6VXNlcjM2NDY2Nzk=",
"organizations_url": "https://api.github.com/users/krawyoti/orgs",
"received_events_url": "https://api.github.com/users/krawyoti/received_events",
"repos_url": "https://api.github.com/users/krawyoti/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/krawyoti/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krawyoti/subscriptions",
"type": "User",
"url": "https://api.github.com/users/krawyoti",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-02-20T11:10:01Z | 2021-09-09T05:00:37Z | 2013-02-25T10:31:22Z | NONE | resolved | In version 1.1.0 allow_redirects for HEAD defaults to True.
According to the docs [1], though, the default should be False.
[1] http://docs.python-requests.org/en/latest/user/quickstart/#redirection-and-history
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1203/reactions"
} | https://api.github.com/repos/psf/requests/issues/1203/timeline | null | completed | null | null | false | [
"Here's the test case:\n\n```\n>>> import requests\n>>> requests.__version__\n'1.1.0'\n>>> requests.head('http://httpbin.org/redirect/2')\n<Response [200]>\n>>> _.history\n(<Response [302]>, <Response [302]>)\n```\n",
"I know what the issue is. Also if you instantiate a Session first, this doesn't happen. Thanks!... |
https://api.github.com/repos/psf/requests/issues/1202 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1202/labels{/name} | https://api.github.com/repos/psf/requests/issues/1202/comments | https://api.github.com/repos/psf/requests/issues/1202/events | https://github.com/psf/requests/issues/1202 | 11,163,316 | MDU6SXNzdWUxMTE2MzMxNg== | 1,202 | requests + gevent dns error | {
"avatar_url": "https://avatars.githubusercontent.com/u/1272836?v=4",
"events_url": "https://api.github.com/users/oargon/events{/privacy}",
"followers_url": "https://api.github.com/users/oargon/followers",
"following_url": "https://api.github.com/users/oargon/following{/other_user}",
"gists_url": "https://api.github.com/users/oargon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/oargon",
"id": 1272836,
"login": "oargon",
"node_id": "MDQ6VXNlcjEyNzI4MzY=",
"organizations_url": "https://api.github.com/users/oargon/orgs",
"received_events_url": "https://api.github.com/users/oargon/received_events",
"repos_url": "https://api.github.com/users/oargon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/oargon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oargon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/oargon",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2013-02-19T17:39:39Z | 2021-09-09T00:34:16Z | 2013-02-26T04:53:07Z | NONE | resolved | I seem to be getting a strange error using requests and gevent with the below code snippet:
running this under gunicorn and hitting this with: ab -n 5 -c 5 http://localhost:8000/
gives this output:
```
2013-02-19 19:32:24 [40251] [INFO] Starting gunicorn 0.17.2
2013-02-19 19:32:24 [40251] [INFO] Listening at: http://127.0.0.1:8000 (40251)
2013-02-19 19:32:24 [40251] [INFO] Using worker: gevent
2013-02-19 19:32:24 [40256] [INFO] Booting worker with pid: 40256
HTTPConnectionPool(host='httpbin.org', port=80): Max retries exceeded with url: /delay/5 (Caused by <class 'gevent.dns.DNSError'>: [Errno 3] name does not exist)
HTTPConnectionPool(host='httpbin.org', port=80): Max retries exceeded with url: /delay/5 (Caused by <class 'gevent.dns.DNSError'>: [Errno 3] name does not exist)
HTTPConnectionPool(host='httpbin.org', port=80): Max retries exceeded with url: /delay/5 (Caused by <class 'gevent.dns.DNSError'>: [Errno 3] name does not exist)
HTTPConnectionPool(host='httpbin.org', port=80): Max retries exceeded with url: /delay/5 (Caused by <class 'gevent.dns.DNSError'>: [Errno 3] name does not exist)
<Response [200]>
```
``` python
from flask import Flask
import requests
app = Flask(__name__)
@app.route('/')
def hello():
try:
r = requests.get('http://httpbin.org/delay/5')
print r
except Exception as e:
print e.message
return 'done'
```
these are the versions I'm using (all from pip install):
```
$ pip freeze
Flask==0.9
Jinja2==2.6
Werkzeug==0.8.3
argparse==1.2.1
distribute==0.6.24
gevent==0.13.8
greenlet==0.4.0
gunicorn==0.17.2
requests==1.1.0
wsgiref==0.1.2
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1202/reactions"
} | https://api.github.com/repos/psf/requests/issues/1202/timeline | null | completed | null | null | false | [
"This looks like you're failing to resolve the domain name. Assuming you're running this on a box you have control over, can you try running `nslookup httpbin.org` from the command prompt?\n",
"```\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\nNon-authoritative answer:\nName: httpbin.org\nAddress: 23.21.1... |
https://api.github.com/repos/psf/requests/issues/1201 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1201/labels{/name} | https://api.github.com/repos/psf/requests/issues/1201/comments | https://api.github.com/repos/psf/requests/issues/1201/events | https://github.com/psf/requests/issues/1201 | 11,071,074 | MDU6SXNzdWUxMTA3MTA3NA== | 1,201 | Should Session.send persist cookies across calls? | {
"avatar_url": "https://avatars.githubusercontent.com/u/74351?v=4",
"events_url": "https://api.github.com/users/maxcountryman/events{/privacy}",
"followers_url": "https://api.github.com/users/maxcountryman/followers",
"following_url": "https://api.github.com/users/maxcountryman/following{/other_user}",
"gists_url": "https://api.github.com/users/maxcountryman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/maxcountryman",
"id": 74351,
"login": "maxcountryman",
"node_id": "MDQ6VXNlcjc0MzUx",
"organizations_url": "https://api.github.com/users/maxcountryman/orgs",
"received_events_url": "https://api.github.com/users/maxcountryman/received_events",
"repos_url": "https://api.github.com/users/maxcountryman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/maxcountryman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxcountryman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/maxcountryman",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 4 | 2013-02-16T16:53:18Z | 2021-09-09T04:00:41Z | 2013-04-01T18:31:24Z | CONTRIBUTOR | resolved | I'm noticing that cookies are not preserved across calls to `Session.send` calls as they would be with `Session.request`. Once again I'm left with the desire for the ability to use my own `Request` object subclass in the scope of `Session.request`; e.g. if it were a key worded arg all my problems would be solved.
Below I've taken an example from the documentation and modified it to demonstrate that using `Session.send` directly eschews some nice functionality that you'd get "for free" using the `Session.request` method. However because I would like to make sure of my own `Request` subclass, without completely overloading `Session.request` on my own `Session` object or monkey patching Requests, I can't make use of `Session.request`.
``` python
>>> req = requests.Request(method='get', url='http://httpbin.org/cookies/set/sessioncookie/123456789')
>>> r = s.send(req.prepare())
>>> r.content
'{\n "cookies": {\n "sessioncookie": "123456789"\n }\n}'
>>> req = requests.Request(method='get', url='http://httpbin.org/cookies')
>>> r = s.send(req.prepare())
>>> r.content
'{\n "cookies": {}\n}'
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1201/reactions"
} | https://api.github.com/repos/psf/requests/issues/1201/timeline | null | completed | null | null | false | [
"@kennethreitz this seems sensible to me. I won't send a Pull Request though until you say so.\n",
"+1\n",
"I'll work on this tomorrow night or Thursday\n",
"Fixed by #1239\n"
] |
https://api.github.com/repos/psf/requests/issues/1200 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1200/labels{/name} | https://api.github.com/repos/psf/requests/issues/1200/comments | https://api.github.com/repos/psf/requests/issues/1200/events | https://github.com/psf/requests/pull/1200 | 11,063,668 | MDExOlB1bGxSZXF1ZXN0NDE3NjU2Ng== | 1,200 | Make sure session cookies do not overwrite explicit request cookies | {
"avatar_url": "https://avatars.githubusercontent.com/u/187133?v=4",
"events_url": "https://api.github.com/users/gazpachoking/events{/privacy}",
"followers_url": "https://api.github.com/users/gazpachoking/followers",
"following_url": "https://api.github.com/users/gazpachoking/following{/other_user}",
"gists_url": "https://api.github.com/users/gazpachoking/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gazpachoking",
"id": 187133,
"login": "gazpachoking",
"node_id": "MDQ6VXNlcjE4NzEzMw==",
"organizations_url": "https://api.github.com/users/gazpachoking/orgs",
"received_events_url": "https://api.github.com/users/gazpachoking/received_events",
"repos_url": "https://api.github.com/users/gazpachoking/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gazpachoking/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gazpachoking/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gazpachoking",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-02-16T06:00:17Z | 2021-09-08T19:00:51Z | 2013-02-20T06:50:10Z | CONTRIBUTOR | resolved | Cookies from a session were overwriting cookies explicitly defined in a request with that session. A couple minor changes as well:
- Implement RequestsCookieJar.copy
- Use RequestsCookieJar.update when merging cookiejars in a couple places
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1200/reactions"
} | https://api.github.com/repos/psf/requests/issues/1200/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1200.diff",
"html_url": "https://github.com/psf/requests/pull/1200",
"merged_at": "2013-02-20T06:50:10Z",
"patch_url": "https://github.com/psf/requests/pull/1200.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1200"
} | true | [
":cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1199 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1199/labels{/name} | https://api.github.com/repos/psf/requests/issues/1199/comments | https://api.github.com/repos/psf/requests/issues/1199/events | https://github.com/psf/requests/pull/1199 | 11,042,455 | MDExOlB1bGxSZXF1ZXN0NDE2Njg2Mw== | 1,199 | Use explicit scheme for proxies in the docs | {
"avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4",
"events_url": "https://api.github.com/users/t-8ch/events{/privacy}",
"followers_url": "https://api.github.com/users/t-8ch/followers",
"following_url": "https://api.github.com/users/t-8ch/following{/other_user}",
"gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/t-8ch",
"id": 717901,
"login": "t-8ch",
"node_id": "MDQ6VXNlcjcxNzkwMQ==",
"organizations_url": "https://api.github.com/users/t-8ch/orgs",
"received_events_url": "https://api.github.com/users/t-8ch/received_events",
"repos_url": "https://api.github.com/users/t-8ch/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions",
"type": "User",
"url": "https://api.github.com/users/t-8ch",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-02-15T16:39:13Z | 2021-09-08T19:00:50Z | 2013-02-19T13:40:15Z | CONTRIBUTOR | resolved | Issue #1192 tried to force users to provide a scheme for proxy urls.
As this would break backwards compability change the docs instead.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1199/reactions"
} | https://api.github.com/repos/psf/requests/issues/1199/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1199.diff",
"html_url": "https://github.com/psf/requests/pull/1199",
"merged_at": "2013-02-19T13:40:15Z",
"patch_url": "https://github.com/psf/requests/pull/1199.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1199"
} | true | [
":+1:\n",
"This should be accepted regardless of whether #1192 is accepted or not. +1 =)\n",
"Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/1198 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1198/labels{/name} | https://api.github.com/repos/psf/requests/issues/1198/comments | https://api.github.com/repos/psf/requests/issues/1198/events | https://github.com/psf/requests/issues/1198 | 11,038,373 | MDU6SXNzdWUxMTAzODM3Mw== | 1,198 | max-retries-exceeded exceptions are confusing | {
"avatar_url": "https://avatars.githubusercontent.com/u/51989?v=4",
"events_url": "https://api.github.com/users/gabor/events{/privacy}",
"followers_url": "https://api.github.com/users/gabor/followers",
"following_url": "https://api.github.com/users/gabor/following{/other_user}",
"gists_url": "https://api.github.com/users/gabor/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gabor",
"id": 51989,
"login": "gabor",
"node_id": "MDQ6VXNlcjUxOTg5",
"organizations_url": "https://api.github.com/users/gabor/orgs",
"received_events_url": "https://api.github.com/users/gabor/received_events",
"repos_url": "https://api.github.com/users/gabor/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gabor/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gabor/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gabor",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 39 | 2013-02-15T14:59:41Z | 2018-12-27T14:25:44Z | 2014-10-11T15:34:25Z | NONE | resolved | hi,
for example:
```
>>> requests.get('http://localhost:1111')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "requests/sessions.py", line 312, in request
resp = self.send(prep, **send_kwargs)
File "requests/sessions.py", line 413, in send
r = adapter.send(request, **kwargs)
File "requests/adapters.py", line 223, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=1111): Max retries exceeded with url: / (Caused by <class 'socket.error'>: [Errno 61] Connection refused)
```
(assuming nothing is listening on port 1111)
the exception says "Max retries exceeded". i found this confusing because i did not specify any retry-related params. in fact, i am unable to find any documentation about specifying the retry-count. after going through the code, it seems that urllib3 is the underlying transport, and it is called with max_retries=0 (so in fact there are no retries). and requests simply wraps the exception. so it is understandable, but it confuses the end-user (end-developer)? i think something better should be done here, especially considering that it is very easy to get this error.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 18,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 18,
"url": "https://api.github.com/repos/psf/requests/issues/1198/reactions"
} | https://api.github.com/repos/psf/requests/issues/1198/timeline | null | completed | null | null | false | [
"Requests wraps the exception for the users convenience. The original exception is part of the message although the Traceback is misleading. I'll think about how to improve this.\n",
"I think need a auto retry to ignore few error\n",
"I agree this is quite confusing. Requests never retries (it sets the retries=... |
https://api.github.com/repos/psf/requests/issues/1197 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1197/labels{/name} | https://api.github.com/repos/psf/requests/issues/1197/comments | https://api.github.com/repos/psf/requests/issues/1197/events | https://github.com/psf/requests/pull/1197 | 11,020,701 | MDExOlB1bGxSZXF1ZXN0NDE1NjgyNw== | 1,197 | add pypy to .travis.yml & setup.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/642195?v=4",
"events_url": "https://api.github.com/users/oczkers/events{/privacy}",
"followers_url": "https://api.github.com/users/oczkers/followers",
"following_url": "https://api.github.com/users/oczkers/following{/other_user}",
"gists_url": "https://api.github.com/users/oczkers/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/oczkers",
"id": 642195,
"login": "oczkers",
"node_id": "MDQ6VXNlcjY0MjE5NQ==",
"organizations_url": "https://api.github.com/users/oczkers/orgs",
"received_events_url": "https://api.github.com/users/oczkers/received_events",
"repos_url": "https://api.github.com/users/oczkers/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/oczkers/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oczkers/subscriptions",
"type": "User",
"url": "https://api.github.com/users/oczkers",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-02-15T00:47:49Z | 2021-09-08T19:00:50Z | 2013-02-15T04:52:04Z | CONTRIBUTOR | resolved | How about this?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1197/reactions"
} | https://api.github.com/repos/psf/requests/issues/1197/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1197.diff",
"html_url": "https://github.com/psf/requests/pull/1197",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1197.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1197"
} | true | [
"pypy has never been an issue :)\n"
] |
https://api.github.com/repos/psf/requests/issues/1196 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1196/labels{/name} | https://api.github.com/repos/psf/requests/issues/1196/comments | https://api.github.com/repos/psf/requests/issues/1196/events | https://github.com/psf/requests/issues/1196 | 11,002,242 | MDU6SXNzdWUxMTAwMjI0Mg== | 1,196 | Ease painful migration to 1.x | {
"avatar_url": "https://avatars.githubusercontent.com/u/464726?v=4",
"events_url": "https://api.github.com/users/millerdev/events{/privacy}",
"followers_url": "https://api.github.com/users/millerdev/followers",
"following_url": "https://api.github.com/users/millerdev/following{/other_user}",
"gists_url": "https://api.github.com/users/millerdev/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/millerdev",
"id": 464726,
"login": "millerdev",
"node_id": "MDQ6VXNlcjQ2NDcyNg==",
"organizations_url": "https://api.github.com/users/millerdev/orgs",
"received_events_url": "https://api.github.com/users/millerdev/received_events",
"repos_url": "https://api.github.com/users/millerdev/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/millerdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/millerdev/subscriptions",
"type": "User",
"url": "https://api.github.com/users/millerdev",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 4 | 2013-02-14T16:06:52Z | 2021-09-09T04:00:44Z | 2013-03-30T00:17:43Z | NONE | resolved | At my company we have recently migrated to 1.1.0, and I have to say it's been much more painful than I expected. Finding what has changed since 0.x has been a nightmare. I have not been able to find good documentation on exactly what has changed, and the commit messages are atrocious. I don't see a clear way to move forward short of reviewing the diff of every single commit, and that's too time consuming.
Please add a CHANGES.txt file to the project and religiously document every single API change, especially the backward-incompatible ones. I love requests, it's much better than the alternatives. But the instability of the API and lack of documentation is making it hard to upgrade. Providing a path forward for existing users is a critical feature.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1196/reactions"
} | https://api.github.com/repos/psf/requests/issues/1196/timeline | null | completed | null | null | false | [
"I'm sorry you found upgrading to v1.0.0 painful. You'll be pleased to know that as of v1.0.0 we have entered a [feature freeze](http://docs.python-requests.org/en/latest/dev/todo/#feature-freeze), which should cause the API to remain unchanged from now on.\n\nAs to having a CHANGES.txt file, I agree that we could ... |
https://api.github.com/repos/psf/requests/issues/1195 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1195/labels{/name} | https://api.github.com/repos/psf/requests/issues/1195/comments | https://api.github.com/repos/psf/requests/issues/1195/events | https://github.com/psf/requests/issues/1195 | 10,992,760 | MDU6SXNzdWUxMDk5Mjc2MA== | 1,195 | Please, do not hold development of requests with feature freeze. | {
"avatar_url": "https://avatars.githubusercontent.com/u/92239?v=4",
"events_url": "https://api.github.com/users/piotr-dobrogost/events{/privacy}",
"followers_url": "https://api.github.com/users/piotr-dobrogost/followers",
"following_url": "https://api.github.com/users/piotr-dobrogost/following{/other_user}",
"gists_url": "https://api.github.com/users/piotr-dobrogost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/piotr-dobrogost",
"id": 92239,
"login": "piotr-dobrogost",
"node_id": "MDQ6VXNlcjkyMjM5",
"organizations_url": "https://api.github.com/users/piotr-dobrogost/orgs",
"received_events_url": "https://api.github.com/users/piotr-dobrogost/received_events",
"repos_url": "https://api.github.com/users/piotr-dobrogost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/piotr-dobrogost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piotr-dobrogost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/piotr-dobrogost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-02-14T11:59:49Z | 2021-09-09T05:00:40Z | 2013-02-14T12:07:32Z | NONE | resolved | I propose to make special branch `freeze` which would only get bug fixes and continue to develop requests in the master branch as always.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1195/reactions"
} | https://api.github.com/repos/psf/requests/issues/1195/timeline | null | completed | null | null | false | [
"The intention is to bring development of new features in Requests to a halt and aim for inclusion in the standard library. This is fundamentally in opposition to the addition of new features, so it simply won't happen. Sorry.\n",
"@Lukasa \n\nWhat's wrong with designating one branch, where development of new fea... |
https://api.github.com/repos/psf/requests/issues/1194 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1194/labels{/name} | https://api.github.com/repos/psf/requests/issues/1194/comments | https://api.github.com/repos/psf/requests/issues/1194/events | https://github.com/psf/requests/pull/1194 | 10,984,979 | MDExOlB1bGxSZXF1ZXN0NDEzODk5OQ== | 1,194 | Allow RequestsCookieJar to be updated with cookies from a CookieJar | {
"avatar_url": "https://avatars.githubusercontent.com/u/187133?v=4",
"events_url": "https://api.github.com/users/gazpachoking/events{/privacy}",
"followers_url": "https://api.github.com/users/gazpachoking/followers",
"following_url": "https://api.github.com/users/gazpachoking/following{/other_user}",
"gists_url": "https://api.github.com/users/gazpachoking/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gazpachoking",
"id": 187133,
"login": "gazpachoking",
"node_id": "MDQ6VXNlcjE4NzEzMw==",
"organizations_url": "https://api.github.com/users/gazpachoking/orgs",
"received_events_url": "https://api.github.com/users/gazpachoking/received_events",
"repos_url": "https://api.github.com/users/gazpachoking/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gazpachoking/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gazpachoking/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gazpachoking",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-02-14T06:07:44Z | 2021-09-08T19:00:50Z | 2013-02-15T06:42:50Z | CONTRIBUTOR | resolved | This would allow cookies from external CookieJars, or other RequestsCookieJars to be merged in with a RequestsCookieJar while preserving all domain and other cookie info.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1194/reactions"
} | https://api.github.com/repos/psf/requests/issues/1194/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1194.diff",
"html_url": "https://github.com/psf/requests/pull/1194",
"merged_at": "2013-02-15T06:42:50Z",
"patch_url": "https://github.com/psf/requests/pull/1194.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1194"
} | true | [
"This would prevent calls like https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L158 (and the one on line 163) from losing domain information on the cookies, as well as let external CookieJars be merged into a requests session's cookies cleanly.\n",
"This is definitely a must have. +10\n... |
https://api.github.com/repos/psf/requests/issues/1193 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1193/labels{/name} | https://api.github.com/repos/psf/requests/issues/1193/comments | https://api.github.com/repos/psf/requests/issues/1193/events | https://github.com/psf/requests/pull/1193 | 10,983,622 | MDExOlB1bGxSZXF1ZXN0NDEzODM0OA== | 1,193 | Throw more informative exceptions. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2013-02-14T04:23:44Z | 2021-09-08T19:00:49Z | 2013-02-20T07:10:45Z | MEMBER | resolved | In #1188 @brandon-rhodes pointed out that we throw some uninformative exceptions when problems arise in urllib3. This would catch the exception and wrap it in a Requests exception, then rethrow it with its original traceback.
I'm on the fence about whether we should do one of the following:
1. Create a new Requests exception for this case (`requests.exceptions.TransportError`?)
2. Import urllib3's exceptions into `requests.exceptions` and export them as our own? (Not great)
Opinions welcome (@sigmavirus24?)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1193/reactions"
} | https://api.github.com/repos/psf/requests/issues/1193/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1193.diff",
"html_url": "https://github.com/psf/requests/pull/1193",
"merged_at": "2013-02-20T07:10:45Z",
"patch_url": "https://github.com/psf/requests/pull/1193.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1193"
} | true | [
"+10\n",
"So I just went ahead and did number 1.\n",
"Ugh, got some compatibility issues here. This will be problematic, give me some time to work on it.\n",
"So it turns out that there is no simple way to get around this Syntax Error. `six` has a good solution, but we currently don't vendor it in. The way I ... |
https://api.github.com/repos/psf/requests/issues/1192 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1192/labels{/name} | https://api.github.com/repos/psf/requests/issues/1192/comments | https://api.github.com/repos/psf/requests/issues/1192/events | https://github.com/psf/requests/pull/1192 | 10,983,138 | MDExOlB1bGxSZXF1ZXN0NDEzODEyNA== | 1,192 | Proxies without schemes might want to except. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 9 | 2013-02-14T03:49:45Z | 2021-09-08T23:06:11Z | 2013-02-25T10:31:40Z | MEMBER | resolved | :warning: **CAUTION**: Breaking change. We may not want to take this. :warning:
This is in relation to #1182. Currently we guess what scheme to use on proxies if that scheme is not provided. This _usually_ works, but sometimes fails in unexpected ways. This would require users to be explicit about what scheme they want to use to contact the proxy.
This **will** break some users' code, without question. I am open to leaving the current behaviour in place, as it's not wrong, just a bit odd.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1192/reactions"
} | https://api.github.com/repos/psf/requests/issues/1192/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1192.diff",
"html_url": "https://github.com/psf/requests/pull/1192",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1192.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1192"
} | true | [
"+0.5 I'm never for breaking user's old code in a minor version, but I am most certainly for providing better exceptions.\n",
"Exactly my view. =) I thought I'd open this PR so we can see what it entails, but I think we'll probably not fix what isn't broken. Just want to see what @kennethreitz thinks.\n",
"Cons... |
https://api.github.com/repos/psf/requests/issues/1191 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1191/labels{/name} | https://api.github.com/repos/psf/requests/issues/1191/comments | https://api.github.com/repos/psf/requests/issues/1191/events | https://github.com/psf/requests/pull/1191 | 10,982,903 | MDExOlB1bGxSZXF1ZXN0NDEzNzk5OA== | 1,191 | Remove the line that likely causes the issue | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-14T03:34:10Z | 2021-09-08T19:00:49Z | 2013-02-17T22:56:41Z | CONTRIBUTOR | resolved | Fixes #1189 as confirmed by @Lukasa
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1191/reactions"
} | https://api.github.com/repos/psf/requests/issues/1191/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1191.diff",
"html_url": "https://github.com/psf/requests/pull/1191",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1191.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1191"
} | true | [
"+1\n",
"+1\n",
"Actually, seems like this breaks persisting cookies across sessions:\n\nUsing the first example in [Session Objects Doc](http://docs.python-requests.org/en/latest/user/advanced/#session-objects):\n\n``` python\nimport requests\n\ns = requests.Session()\n\ns.get('http://httpbin.org/cookies/set?s... |
https://api.github.com/repos/psf/requests/issues/1190 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1190/labels{/name} | https://api.github.com/repos/psf/requests/issues/1190/comments | https://api.github.com/repos/psf/requests/issues/1190/events | https://github.com/psf/requests/pull/1190 | 10,979,394 | MDExOlB1bGxSZXF1ZXN0NDEzNjEzNw== | 1,190 | Pass user options to hooks | {
"avatar_url": "https://avatars.githubusercontent.com/u/826?v=4",
"events_url": "https://api.github.com/users/mkomitee/events{/privacy}",
"followers_url": "https://api.github.com/users/mkomitee/followers",
"following_url": "https://api.github.com/users/mkomitee/following{/other_user}",
"gists_url": "https://api.github.com/users/mkomitee/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mkomitee",
"id": 826,
"login": "mkomitee",
"node_id": "MDQ6VXNlcjgyNg==",
"organizations_url": "https://api.github.com/users/mkomitee/orgs",
"received_events_url": "https://api.github.com/users/mkomitee/received_events",
"repos_url": "https://api.github.com/users/mkomitee/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mkomitee/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mkomitee/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mkomitee",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 20 | 2013-02-14T00:26:08Z | 2021-09-08T19:00:48Z | 2013-03-02T21:04:01Z | CONTRIBUTOR | resolved | Hooks sometimes have to send requests (e.g. when responding to a 401 during
authentication).
All keyword arguments should be passed along when hooks are dispatched so that
if a user wanted to use a timeout, stream, specify a cert location with the
verify flag, etc, their specification can be followed.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1190/reactions"
} | https://api.github.com/repos/psf/requests/issues/1190/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1190.diff",
"html_url": "https://github.com/psf/requests/pull/1190",
"merged_at": "2013-03-02T21:04:01Z",
"patch_url": "https://github.com/psf/requests/pull/1190.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1190"
} | true | [
"The second commit adds a test which tests the previously broken behavior where flags like timeout, stream, verify, etc were lost when we used authentication. It fails without the patch.\n\nif it's not clear, this tests by calling read() with stream turned on and off. If stream is off, then the content is read ahea... |
https://api.github.com/repos/psf/requests/issues/1189 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1189/labels{/name} | https://api.github.com/repos/psf/requests/issues/1189/comments | https://api.github.com/repos/psf/requests/issues/1189/events | https://github.com/psf/requests/issues/1189 | 10,977,015 | MDU6SXNzdWUxMDk3NzAxNQ== | 1,189 | Multiple Cookies on Redirect | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
}
] | closed | true | null | [] | null | 8 | 2013-02-13T23:09:02Z | 2021-09-09T05:00:39Z | 2013-02-17T01:17:07Z | MEMBER | resolved | After updating `master` to f73bda06e9, I find that some requests raise a `CookieConflictError`. Specifically, any page that sets a cookie on a 302 and then redirects to a page that sets the same cookie raises a `CookieConflictError`.
Steps To Reproduce:
1. Update Requests to the version shown above.
2. Make a request to http://www.google.com/ from anywhere outside the US.
Expected Behaviour:
Requests should return a 200 OK with the 302 in the history.
Actual Behaviour:
``` python
>>> import requests
>>> r = requests.get('http://www.google.com/')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "requests/sessions.py", line 312, in request
resp = self.send(prep, **send_kwargs)
File "requests/sessions.py", line 426, in send
history = [resp for resp in gen] if allow_redirects else []
File "requests/sessions.py", line 163, in resolve_redirects
resp.cookies.update(cookiejar)
File "venv/lib/python2.7/_abcoll.py", line 494, in update
self[key] = other[key]
File "requests/cookies.py", line 246, in __getitem__
return self._find_no_duplicates(name)
File "requests/cookies.py", line 285, in _find_no_duplicates
raise CookieConflictError('There are multiple cookies with name, %r' % (name))
requests.cookies.CookieConflictError: There are multiple cookies with name, 'NID'
```
This is very clearly related to the changes made in #1180.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1189/reactions"
} | https://api.github.com/repos/psf/requests/issues/1189/timeline | null | completed | null | null | false | [
"/cc @sigmavirus24 \n",
"Damn. I was worried the last line might cause troubles but I couldn't find websites like this other than GitHub and didn't think to test it. (I thought GitHub may have been an abnormality.)\n\nCan you try removing the last line of the `SessionRedirectMixin.resolve_redirect` method? I can'... |
https://api.github.com/repos/psf/requests/issues/1188 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1188/labels{/name} | https://api.github.com/repos/psf/requests/issues/1188/comments | https://api.github.com/repos/psf/requests/issues/1188/events | https://github.com/psf/requests/issues/1188 | 10,974,150 | MDU6SXNzdWUxMDk3NDE1MA== | 1,188 | ClosedPoolError gets shadowed by a false Timeout error | {
"avatar_url": "https://avatars.githubusercontent.com/u/166162?v=4",
"events_url": "https://api.github.com/users/brandon-rhodes/events{/privacy}",
"followers_url": "https://api.github.com/users/brandon-rhodes/followers",
"following_url": "https://api.github.com/users/brandon-rhodes/following{/other_user}",
"gists_url": "https://api.github.com/users/brandon-rhodes/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/brandon-rhodes",
"id": 166162,
"login": "brandon-rhodes",
"node_id": "MDQ6VXNlcjE2NjE2Mg==",
"organizations_url": "https://api.github.com/users/brandon-rhodes/orgs",
"received_events_url": "https://api.github.com/users/brandon-rhodes/received_events",
"repos_url": "https://api.github.com/users/brandon-rhodes/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/brandon-rhodes/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brandon-rhodes/subscriptions",
"type": "User",
"url": "https://api.github.com/users/brandon-rhodes",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 15 | 2013-02-13T21:58:40Z | 2021-09-08T23:07:57Z | 2013-08-15T07:57:12Z | NONE | resolved | A customer in whose product I used Requests complained that, on Windows, my program would immediately die with a series of `Timeout` exceptions printed to the logs:
```
...
r = session.get(url, headers=headers, stream=True)
File "...\venv\lib\site-packages\requests\sessions.py", line 310, in get
return self.request('GET', url, **kwargs)
File "...\venv\lib\site-packages\requests\sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "...\venv\lib\site-packages\requests\sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "...\venv\lib\site-packages\requests\adapters.py", line 217, in send
raise Timeout('Request timed out.')
Timeout: Request timed out.
```
This seemed odd, since timeouts usually take — well — _time_ to occur, instead of happening immediately when a program starts! So I looked at the code that was raising the `Timeout`, which is in `adapters.py`:
```
except (_SSLError, _HTTPError) as e:
if isinstance(e, _SSLError):
raise SSLError(e)
elif isinstance(e, TimeoutError):
raise Timeout(e)
else:
raise Timeout('Request timed out.')
```
The last line of this stanza struck me as suspicious: is it _really_ the case that all SSL and HTTP errors can be explained as timeouts? So I had my customer change the last line to simply the statement `raise`, so that I could see the exception that was being hidden by the `Timeout` and this is what we saw:
```
r = session.get(url, headers=headers, stream=True)
File "...\venv\lib\site-packages\requests\sessions.py", line 310, in get
return self.request('GET', url, **kwargs)
File "...\venv\lib\site-packages\requests\sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "...\venv\lib\site-packages\requests\sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "...\venv\lib\site-packages\requests\adapters.py", line 174, in send
timeout=timeout
File "...\venv\lib\site-packages\requests\packages\urllib3\connectionpool.py", line
417, in urlopen
conn = self._get_conn(timeout=pool_timeout)
File "...\venv\lib\site-packages\requests\packages\urllib3\connectionpool.py", line
218, in _get_conn
raise ClosedPoolError(self, "Pool is closed.")
```
I have no idea what this error means, but it went away when instead of having several threads share the same `Session` we instead had each thread create its own `Session` for its use alone — I suppose that I should open another ticket about that, reporting that session objects are not, in fact, thread-safe in Python under Windows, but give this pool-is-closed exception instead?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1188/reactions"
} | https://api.github.com/repos/psf/requests/issues/1188/timeline | null | completed | null | null | false | [
"I don't think the Session is thread-safe under any OS.\n\nI do think the blanket 'Timeout' exception is pretty unwise, we can probably handle the urllib3 exceptions better. Let me take a look and see.\n",
"@Lukasa In that case an update to the documentation is warranted—the front page of the project says “thread... |
https://api.github.com/repos/psf/requests/issues/1187 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1187/labels{/name} | https://api.github.com/repos/psf/requests/issues/1187/comments | https://api.github.com/repos/psf/requests/issues/1187/events | https://github.com/psf/requests/pull/1187 | 10,970,636 | MDExOlB1bGxSZXF1ZXN0NDEzMTcwNQ== | 1,187 | Fixed names of exceptions pertaining to url scheme. | {
"avatar_url": "https://avatars.githubusercontent.com/u/92239?v=4",
"events_url": "https://api.github.com/users/piotr-dobrogost/events{/privacy}",
"followers_url": "https://api.github.com/users/piotr-dobrogost/followers",
"following_url": "https://api.github.com/users/piotr-dobrogost/following{/other_user}",
"gists_url": "https://api.github.com/users/piotr-dobrogost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/piotr-dobrogost",
"id": 92239,
"login": "piotr-dobrogost",
"node_id": "MDQ6VXNlcjkyMjM5",
"organizations_url": "https://api.github.com/users/piotr-dobrogost/orgs",
"received_events_url": "https://api.github.com/users/piotr-dobrogost/received_events",
"repos_url": "https://api.github.com/users/piotr-dobrogost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/piotr-dobrogost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piotr-dobrogost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/piotr-dobrogost",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "0b02e1",
"default": false,
"description": null... | closed | true | null | [] | null | 5 | 2013-02-13T20:28:24Z | 2021-09-08T23:06:10Z | 2013-02-14T01:13:13Z | NONE | resolved | MissingSchema -> MissingScheme, InvalidSchema -> InvalidScheme
see t-8ch's comment in issue #1182
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1187/reactions"
} | https://api.github.com/repos/psf/requests/issues/1187/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1187.diff",
"html_url": "https://github.com/psf/requests/pull/1187",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1187.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1187"
} | true | [
"This is a backwards incompatible change.\n",
"@kennethreitz we could maintain backwards compatibility by keeping the old exceptions and sub-classing them for the new ones. It's ugly and I don't like it, but we would be able to raise \"properly\" named exceptions whilst maintaining backwards compatibility.\n",
... |
https://api.github.com/repos/psf/requests/issues/1186 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1186/labels{/name} | https://api.github.com/repos/psf/requests/issues/1186/comments | https://api.github.com/repos/psf/requests/issues/1186/events | https://github.com/psf/requests/issues/1186 | 10,961,299 | MDU6SXNzdWUxMDk2MTI5OQ== | 1,186 | requests.get doesn't allow for repeated URL parameters | {
"avatar_url": "https://avatars.githubusercontent.com/u/1254555?v=4",
"events_url": "https://api.github.com/users/mattboehm/events{/privacy}",
"followers_url": "https://api.github.com/users/mattboehm/followers",
"following_url": "https://api.github.com/users/mattboehm/following{/other_user}",
"gists_url": "https://api.github.com/users/mattboehm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mattboehm",
"id": 1254555,
"login": "mattboehm",
"node_id": "MDQ6VXNlcjEyNTQ1NTU=",
"organizations_url": "https://api.github.com/users/mattboehm/orgs",
"received_events_url": "https://api.github.com/users/mattboehm/received_events",
"repos_url": "https://api.github.com/users/mattboehm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mattboehm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mattboehm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mattboehm",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-02-13T16:48:30Z | 2021-09-09T05:00:40Z | 2013-02-13T20:26:12Z | NONE | resolved | If I prepare a request as follows:
```
req = requests.Request('get', url="http://localhost/", params=[("param1", "value1"), ("param1", "value2")])
prep = req.prepare()
```
prep.url is "http://localhost/?param1=value1¶m1=value2" as expected. However if I call:
```
resp = requests.get(url="http://localhost/", params=[("param1", "value1"), ("param1", "value2")])
```
then resp.url is "http://localhost/?param1=value2"
I would expect requests.get to allow for repeated parameters.
(tested in version 1.1.0 and the revision f73bda0)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1254555?v=4",
"events_url": "https://api.github.com/users/mattboehm/events{/privacy}",
"followers_url": "https://api.github.com/users/mattboehm/followers",
"following_url": "https://api.github.com/users/mattboehm/following{/other_user}",
"gists_url": "https://api.github.com/users/mattboehm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mattboehm",
"id": 1254555,
"login": "mattboehm",
"node_id": "MDQ6VXNlcjEyNTQ1NTU=",
"organizations_url": "https://api.github.com/users/mattboehm/orgs",
"received_events_url": "https://api.github.com/users/mattboehm/received_events",
"repos_url": "https://api.github.com/users/mattboehm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mattboehm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mattboehm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mattboehm",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1186/reactions"
} | https://api.github.com/repos/psf/requests/issues/1186/timeline | null | completed | null | null | false | [
"Hm, this is an issue with calling `merge_kwargs` in `Session.request`. This seems like yet another job for a MultiDict (#1155), i.e., returning a MultiDict in `from_key_val_list`.\n",
"Guess I'll be working on MultiDict support this weekend. I'm going to close this in deference to #1155 though, if that's ok with... |
https://api.github.com/repos/psf/requests/issues/1185 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1185/labels{/name} | https://api.github.com/repos/psf/requests/issues/1185/comments | https://api.github.com/repos/psf/requests/issues/1185/events | https://github.com/psf/requests/pull/1185 | 10,940,062 | MDExOlB1bGxSZXF1ZXN0NDExNzc1Ng== | 1,185 | Dispatch hooks before following redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-02-13T04:05:15Z | 2021-09-08T19:00:48Z | 2013-02-13T10:13:31Z | CONTRIBUTOR | resolved | Fixes #1183
/cc @mkomitee
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1185/reactions"
} | https://api.github.com/repos/psf/requests/issues/1185/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1185.diff",
"html_url": "https://github.com/psf/requests/pull/1185",
"merged_at": "2013-02-13T10:13:31Z",
"patch_url": "https://github.com/psf/requests/pull/1185.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1185"
} | true | [
"+1.\n",
"looks good ;)\n",
":cake:\n",
"Thanks for this. I haven't been able to verify it solves my problem but I should be able to verify in a few days.\n"
] |
https://api.github.com/repos/psf/requests/issues/1184 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1184/labels{/name} | https://api.github.com/repos/psf/requests/issues/1184/comments | https://api.github.com/repos/psf/requests/issues/1184/events | https://github.com/psf/requests/pull/1184 | 10,885,980 | MDExOlB1bGxSZXF1ZXN0NDA5MjUxNg== | 1,184 | small cleanup of redirect codes | {
"avatar_url": "https://avatars.githubusercontent.com/u/92239?v=4",
"events_url": "https://api.github.com/users/piotr-dobrogost/events{/privacy}",
"followers_url": "https://api.github.com/users/piotr-dobrogost/followers",
"following_url": "https://api.github.com/users/piotr-dobrogost/following{/other_user}",
"gists_url": "https://api.github.com/users/piotr-dobrogost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/piotr-dobrogost",
"id": 92239,
"login": "piotr-dobrogost",
"node_id": "MDQ6VXNlcjkyMjM5",
"organizations_url": "https://api.github.com/users/piotr-dobrogost/orgs",
"received_events_url": "https://api.github.com/users/piotr-dobrogost/received_events",
"repos_url": "https://api.github.com/users/piotr-dobrogost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/piotr-dobrogost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piotr-dobrogost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/piotr-dobrogost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-02-11T22:14:45Z | 2021-09-08T19:00:48Z | 2013-02-12T08:27:05Z | NONE | resolved | removed no longer used redirect codes from models
added numeric values of redirect codes in comments
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1184/reactions"
} | https://api.github.com/repos/psf/requests/issues/1184/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1184.diff",
"html_url": "https://github.com/psf/requests/pull/1184",
"merged_at": "2013-02-12T08:27:05Z",
"patch_url": "https://github.com/psf/requests/pull/1184.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1184"
} | true | [
"seems okay :)\n"
] |
https://api.github.com/repos/psf/requests/issues/1183 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1183/labels{/name} | https://api.github.com/repos/psf/requests/issues/1183/comments | https://api.github.com/repos/psf/requests/issues/1183/events | https://github.com/psf/requests/issues/1183 | 10,882,525 | MDU6SXNzdWUxMDg4MjUyNQ== | 1,183 | No means of authenticating redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/826?v=4",
"events_url": "https://api.github.com/users/mkomitee/events{/privacy}",
"followers_url": "https://api.github.com/users/mkomitee/followers",
"following_url": "https://api.github.com/users/mkomitee/following{/other_user}",
"gists_url": "https://api.github.com/users/mkomitee/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mkomitee",
"id": 826,
"login": "mkomitee",
"node_id": "MDQ6VXNlcjgyNg==",
"organizations_url": "https://api.github.com/users/mkomitee/orgs",
"received_events_url": "https://api.github.com/users/mkomitee/received_events",
"repos_url": "https://api.github.com/users/mkomitee/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mkomitee/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mkomitee/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mkomitee",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 15 | 2013-02-11T20:50:17Z | 2021-09-09T05:00:40Z | 2013-02-13T10:13:32Z | CONTRIBUTOR | resolved | In `requests/requests-kerberos` we use GSSAPI to not only authenticate to the server, but also authenticate the server as well. It's called mutual authentication. The way that `Session.send` resolves redirects doesn't allow us to authenticate the redirects.
This is a problem because if a user sends a request to `host_a` which redirects us to `host_b` and we authenticate `host_b` successfully, that really doesn't mean anything to the user if he can't actually trust that the process which issued the redirect was actually `host_a`.
This means that if we want to require mutual authentication, we cannot follow redirects at all, even if the servers are capable of authenticating their redirects.
Would it be possible to either:
1. Dispatch the `response` hook on redirects
2. Create a new kind of hook which authentication mechanisms can install specifically for handling redirects?
I see problems with option 1. If we'd be amenable to option 2, I'll work on a pull request for it. Unless someone says otherwise I'd call the hook `redirect`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1183/reactions"
} | https://api.github.com/repos/psf/requests/issues/1183/timeline | null | completed | null | null | false | [
"Some more details are in the commit message at https://github.com/mkomitee/requests-kerberos/commit/954ae437d7748a61748503bb77ff77a2d662c731\n",
"Have you seen issue #1160? It's kind of similar to this one, isn't it?\n",
"@piotr-dobrogost, this is about not allowing redirects in certain cases. That is about mo... |
https://api.github.com/repos/psf/requests/issues/1182 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1182/labels{/name} | https://api.github.com/repos/psf/requests/issues/1182/comments | https://api.github.com/repos/psf/requests/issues/1182/events | https://github.com/psf/requests/issues/1182 | 10,871,975 | MDU6SXNzdWUxMDg3MTk3NQ== | 1,182 | SSL exception when using any HTTPS proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/153571?v=4",
"events_url": "https://api.github.com/users/Miarevo/events{/privacy}",
"followers_url": "https://api.github.com/users/Miarevo/followers",
"following_url": "https://api.github.com/users/Miarevo/following{/other_user}",
"gists_url": "https://api.github.com/users/Miarevo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Miarevo",
"id": 153571,
"login": "Miarevo",
"node_id": "MDQ6VXNlcjE1MzU3MQ==",
"organizations_url": "https://api.github.com/users/Miarevo/orgs",
"received_events_url": "https://api.github.com/users/Miarevo/received_events",
"repos_url": "https://api.github.com/users/Miarevo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Miarevo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Miarevo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Miarevo",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 12 | 2013-02-11T16:22:10Z | 2021-09-09T00:34:26Z | 2013-02-12T04:12:34Z | NONE | resolved | When I attempt to load a page using an HTTPS proxy, I get an odd SSL exception that I never got before (with the same code). This happens with any valid HTTPS proxy. Unfortunately, I don't know when this began to occur. If I were to guess, I'd say version 1.1 introduced the issue. Here's an example:
```
Python 3.3.0 (default, Dec 22 2012, 21:02:07)
[GCC 4.7.2] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> sess = requests.Session()
>>> r = sess.get('https://google.com/', proxies={'https': proxy})
Traceback (most recent call last):
File "/usr/lib/python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 422, in urlopen
body=body, headers=headers)
File "/usr/lib/python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 274, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/lib/python3.3/http/client.py", line 1049, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python3.3/http/client.py", line 1087, in _send_request
self.endheaders(body)
File "/usr/lib/python3.3/http/client.py", line 1045, in endheaders
self._send_output(message_body)
File "/usr/lib/python3.3/http/client.py", line 890, in _send_output
self.send(msg)
File "/usr/lib/python3.3/http/client.py", line 828, in send
self.connect()
File "/usr/lib/python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 105, in connect
ssl_version=self.ssl_version)
File "/usr/lib/python3.3/site-packages/requests/packages/urllib3/util.py", line 289, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "/usr/lib/python3.3/ssl.py", line 210, in wrap_socket
_context=self)
File "/usr/lib/python3.3/ssl.py", line 310, in __init__
raise x
File "/usr/lib/python3.3/ssl.py", line 306, in __init__
self.do_handshake()
File "/usr/lib/python3.3/ssl.py", line 513, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: UNKNOWN_PROTOCOL] unknown protocol (_ssl.c:547)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.3/site-packages/requests/adapters.py", line 174, in send
timeout=timeout
File "/usr/lib/python3.3/site-packages/requests/packages/urllib3/poolmanager.py", line 158, in urlopen
return self.proxy_pool.urlopen(method, url, **kw)
File "/usr/lib/python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 453, in urlopen
raise SSLError(e)
requests.packages.urllib3.exceptions.SSLError: [SSL: UNKNOWN_PROTOCOL] unknown protocol (_ssl.c:547)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.3/site-packages/requests/sessions.py", line 310, in get
return self.request('GET', url, **kwargs)
File "/usr/lib/python3.3/site-packages/requests/sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "/usr/lib/python3.3/site-packages/requests/sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python3.3/site-packages/requests/adapters.py", line 213, in send
raise SSLError(e)
requests.exceptions.SSLError: [SSL: UNKNOWN_PROTOCOL] unknown protocol (_ssl.c:547)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1182/reactions"
} | https://api.github.com/repos/psf/requests/issues/1182/timeline | null | completed | null | null | false | [
"Which version of requests are you using? Also, can you test out the current HEAD of the master branch in this repository to see if the problem persists?\n",
"Does your proxy variable have a `https://` or `http://` scheme?\nIt should be `http://` if you want to connect by http, regardless if the the proxied conne... |
https://api.github.com/repos/psf/requests/issues/1181 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1181/labels{/name} | https://api.github.com/repos/psf/requests/issues/1181/comments | https://api.github.com/repos/psf/requests/issues/1181/events | https://github.com/psf/requests/pull/1181 | 10,864,715 | MDExOlB1bGxSZXF1ZXN0NDA4MTc2MA== | 1,181 | Fix of UnicodeDecodeError on unicode header name that can be converted to ascii. | {
"avatar_url": "https://avatars.githubusercontent.com/u/855988?v=4",
"events_url": "https://api.github.com/users/denis-ryzhkov/events{/privacy}",
"followers_url": "https://api.github.com/users/denis-ryzhkov/followers",
"following_url": "https://api.github.com/users/denis-ryzhkov/following{/other_user}",
"gists_url": "https://api.github.com/users/denis-ryzhkov/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/denis-ryzhkov",
"id": 855988,
"login": "denis-ryzhkov",
"node_id": "MDQ6VXNlcjg1NTk4OA==",
"organizations_url": "https://api.github.com/users/denis-ryzhkov/orgs",
"received_events_url": "https://api.github.com/users/denis-ryzhkov/received_events",
"repos_url": "https://api.github.com/users/denis-ryzhkov/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/denis-ryzhkov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/denis-ryzhkov/subscriptions",
"type": "User",
"url": "https://api.github.com/users/denis-ryzhkov",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-11T12:44:21Z | 2021-09-08T23:05:19Z | 2013-02-12T16:43:02Z | CONTRIBUTOR | resolved | ## Problem
Please see issue #1082.
## Solution
Let's fix at least Python-2 unicode issues with **header name**,
because its representation as bytes is well defined in HTTP/1.1 spec:
http://tools.ietf.org/html/rfc2616#section-4.2
```
message-header = field-name ":" [ field-value ]
field-name = token
token = 1*<any CHAR except CTLs or separators>
CHAR = <any US-ASCII character (octets 0 - 127)>
```
So header name should always be sent as ascii.
If user provides header name that can be converted to ascii without errors,
then it should be converted, e.g. `u'Content-Type' --> 'Content-Type'`.
Otherwise a helpful error should be raised, indicating that the header name is the reason.
- Created: `test_unicode_header_name`.
- Updated: `prepare_headers`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1181/reactions"
} | https://api.github.com/repos/psf/requests/issues/1181/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1181.diff",
"html_url": "https://github.com/psf/requests/pull/1181",
"merged_at": "2013-02-12T16:43:02Z",
"patch_url": "https://github.com/psf/requests/pull/1181.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1181"
} | true | [
"Why use a side-effect of the `str` function to do this, when you can easily do: `name.encode('ascii')`? Additionally, if you do that you can remove the 'if py2' tests.\n",
"@Lukasa\nThanks! Please check the fix.\n",
"I'm going to close and reopen to get Travis to re-run the tests.\n",
"This fix looks broadly... |
https://api.github.com/repos/psf/requests/issues/1180 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1180/labels{/name} | https://api.github.com/repos/psf/requests/issues/1180/comments | https://api.github.com/repos/psf/requests/issues/1180/events | https://github.com/psf/requests/pull/1180 | 10,834,065 | MDExOlB1bGxSZXF1ZXN0NDA3Njc2NA== | 1,180 | Fix Session level Cookie Handling | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2013-02-11T00:40:52Z | 2021-09-08T19:00:47Z | 2013-02-11T00:43:21Z | CONTRIBUTOR | resolved | Reported by Filefly on IRC and written with help from @gazpachoking.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1180/reactions"
} | https://api.github.com/repos/psf/requests/issues/1180/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1180.diff",
"html_url": "https://github.com/psf/requests/pull/1180",
"merged_at": "2013-02-11T00:43:21Z",
"patch_url": "https://github.com/psf/requests/pull/1180.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1180"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/1179 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1179/labels{/name} | https://api.github.com/repos/psf/requests/issues/1179/comments | https://api.github.com/repos/psf/requests/issues/1179/events | https://github.com/psf/requests/issues/1179 | 10,828,391 | MDU6SXNzdWUxMDgyODM5MQ== | 1,179 | Attach a Certificate for SSL authentication and access. | {
"avatar_url": "https://avatars.githubusercontent.com/u/3526843?v=4",
"events_url": "https://api.github.com/users/tigeryell99/events{/privacy}",
"followers_url": "https://api.github.com/users/tigeryell99/followers",
"following_url": "https://api.github.com/users/tigeryell99/following{/other_user}",
"gists_url": "https://api.github.com/users/tigeryell99/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tigeryell99",
"id": 3526843,
"login": "tigeryell99",
"node_id": "MDQ6VXNlcjM1MjY4NDM=",
"organizations_url": "https://api.github.com/users/tigeryell99/orgs",
"received_events_url": "https://api.github.com/users/tigeryell99/received_events",
"repos_url": "https://api.github.com/users/tigeryell99/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tigeryell99/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tigeryell99/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tigeryell99",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-02-10T19:52:39Z | 2021-09-09T04:00:45Z | 2013-02-10T22:51:43Z | NONE | resolved | Please add the ability to attach a Certificate for SSL authentication to the request, not to verify the cert, but to gain access to an https SSL secured site.
I am submitting this per Kenneth's request.
Thanks,
Brian
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1179/reactions"
} | https://api.github.com/repos/psf/requests/issues/1179/timeline | null | completed | null | null | false | [
"Isn't this, what the `cert` parameter is for?\nFrom the [docs](http://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification):\n\n```\nYou can also specify a local cert to use as client side certificate, as a single file\n(containing the private key and the certificate) or as a tuple of both file’... |
https://api.github.com/repos/psf/requests/issues/1178 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1178/labels{/name} | https://api.github.com/repos/psf/requests/issues/1178/comments | https://api.github.com/repos/psf/requests/issues/1178/events | https://github.com/psf/requests/pull/1178 | 10,820,840 | MDExOlB1bGxSZXF1ZXN0NDA3MzcwNA== | 1,178 | improving `super_len` | {
"avatar_url": "https://avatars.githubusercontent.com/u/690171?v=4",
"events_url": "https://api.github.com/users/shezi/events{/privacy}",
"followers_url": "https://api.github.com/users/shezi/followers",
"following_url": "https://api.github.com/users/shezi/following{/other_user}",
"gists_url": "https://api.github.com/users/shezi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/shezi",
"id": 690171,
"login": "shezi",
"node_id": "MDQ6VXNlcjY5MDE3MQ==",
"organizations_url": "https://api.github.com/users/shezi/orgs",
"received_events_url": "https://api.github.com/users/shezi/received_events",
"repos_url": "https://api.github.com/users/shezi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/shezi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shezi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/shezi",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-02-10T10:26:22Z | 2021-09-08T19:00:47Z | 2013-02-10T22:19:27Z | NONE | resolved | when using `StringIO` in Python 3 oder using `cStringIO` in Python 2, you will have an object that does not have a `len` AND does not have a `.fileno()`
In that case, the best method for finding the length of the backing object is to seek to the end. This assumes that the object is seekable, though.
Since we're going to load the whole object into memory anyway, memory consumption should not be increased by the seeking.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1178/reactions"
} | https://api.github.com/repos/psf/requests/issues/1178/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1178.diff",
"html_url": "https://github.com/psf/requests/pull/1178",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1178.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1178"
} | true | [
"I'd prefer us to do a little magic if possible. What's the use case here?\n",
"Use case:\n\n```\n# python 3.3.0\nimport requests\nimport io\n\nrequests.get('http://example.com/', data=io.StringIO('my data'))\n```\n\nGives me:\n\n```\nTraceback (most recent call last):\n File \"usecase.py\", line 4, in <module>\... |
https://api.github.com/repos/psf/requests/issues/1177 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1177/labels{/name} | https://api.github.com/repos/psf/requests/issues/1177/comments | https://api.github.com/repos/psf/requests/issues/1177/events | https://github.com/psf/requests/pull/1177 | 10,811,856 | MDExOlB1bGxSZXF1ZXN0NDA3MDg4NA== | 1,177 | Forcing path_url to be of type str in Python2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/690171?v=4",
"events_url": "https://api.github.com/users/shezi/events{/privacy}",
"followers_url": "https://api.github.com/users/shezi/followers",
"following_url": "https://api.github.com/users/shezi/following{/other_user}",
"gists_url": "https://api.github.com/users/shezi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/shezi",
"id": 690171,
"login": "shezi",
"node_id": "MDQ6VXNlcjY5MDE3MQ==",
"organizations_url": "https://api.github.com/users/shezi/orgs",
"received_events_url": "https://api.github.com/users/shezi/received_events",
"repos_url": "https://api.github.com/users/shezi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/shezi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shezi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/shezi",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 14 | 2013-02-09T17:45:04Z | 2021-09-08T19:00:46Z | 2013-02-10T22:26:18Z | NONE | resolved | This is important when posting files/binary data in Python2.
Since urlsplit will produce unicode parts, the path_url will also be unicode, and thus the sent body will be converted to unicode during concatenation by urllib, producing a UnicodeDecodeError when sending binary data.
Forcing the path_url to be a native string in Python2 resolves this.
No test cases yet.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1177/reactions"
} | https://api.github.com/repos/psf/requests/issues/1177/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1177.diff",
"html_url": "https://github.com/psf/requests/pull/1177",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1177.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1177"
} | true | [
"Additionally, in lines 392 and 396, the `str` primitive is used to convert the _content_ of the 'Content-Length' header to unicode (in Python2). This does not seem to matter for concatenation, though, it just looks interesting when you inspect your headers and get\n\n```\n'Content-Length': u'2246'\n```\n",
"> Ad... |
https://api.github.com/repos/psf/requests/issues/1176 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1176/labels{/name} | https://api.github.com/repos/psf/requests/issues/1176/comments | https://api.github.com/repos/psf/requests/issues/1176/events | https://github.com/psf/requests/issues/1176 | 10,811,267 | MDU6SXNzdWUxMDgxMTI2Nw== | 1,176 | Requests is not Working on Enigma2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/2682247?v=4",
"events_url": "https://api.github.com/users/athoik/events{/privacy}",
"followers_url": "https://api.github.com/users/athoik/followers",
"following_url": "https://api.github.com/users/athoik/following{/other_user}",
"gists_url": "https://api.github.com/users/athoik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/athoik",
"id": 2682247,
"login": "athoik",
"node_id": "MDQ6VXNlcjI2ODIyNDc=",
"organizations_url": "https://api.github.com/users/athoik/orgs",
"received_events_url": "https://api.github.com/users/athoik/received_events",
"repos_url": "https://api.github.com/users/athoik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/athoik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athoik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/athoik",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-02-09T16:53:47Z | 2021-09-09T05:00:44Z | 2013-02-09T23:52:11Z | NONE | resolved | Hello everybody,
I am trying to use requests on Enigma2 STB (using OpenPLi 3.0), but i am getting the following error:
``` python
# python2.7
Python 2.7.2 (default, Dec 14 2012, 09:28:54)
[GCC 4.6.4 20120303 (prerelease)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.__version__
'1.1.0'
>>> requests.certs.where()
'requests/cacert.pem'
>>> requests.get('https://www.google.com')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "requests/sessions.py", line 289, in request
resp = self.send(prep, **send_kwargs)
File "requests/sessions.py", line 385, in send
r = adapter.send(request, **kwargs)
File "requests/adapters.py", line 227, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:503: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
>>> requests.get('https://www.google.com', verify=False)
<Response [200]>
```
Any idea why verify is not working?
The above steps on my computer working without a problem.
``` python
# python2.7
Python 2.7.3 (default, Aug 1 2012, 05:16:07)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.__version__
'1.1.0'
>>> requests.certs.where()
'requests/cacert.pem'
>>> requests.get('https://www.google.com')
<Response [200]>
```
Thanks.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/2682247?v=4",
"events_url": "https://api.github.com/users/athoik/events{/privacy}",
"followers_url": "https://api.github.com/users/athoik/followers",
"following_url": "https://api.github.com/users/athoik/following{/other_user}",
"gists_url": "https://api.github.com/users/athoik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/athoik",
"id": 2682247,
"login": "athoik",
"node_id": "MDQ6VXNlcjI2ODIyNDc=",
"organizations_url": "https://api.github.com/users/athoik/orgs",
"received_events_url": "https://api.github.com/users/athoik/received_events",
"repos_url": "https://api.github.com/users/athoik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/athoik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athoik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/athoik",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1176/reactions"
} | https://api.github.com/repos/psf/requests/issues/1176/timeline | null | completed | null | null | false | [
"Could you try the commandline version of OpenSSL?\n\n``` sh\n$ openssl s_client -connect google.com:443 -CAfile requests/cacert.pem\n# [..] Some output\nStart Time: 1360430734\nTimeout : 300 (sec)\nVerify return code: 0 (ok)\n```\n",
"```\n# openssl s_client -connect google.com:443 -CAfile requests/cacert.pe... |
https://api.github.com/repos/psf/requests/issues/1175 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1175/labels{/name} | https://api.github.com/repos/psf/requests/issues/1175/comments | https://api.github.com/repos/psf/requests/issues/1175/events | https://github.com/psf/requests/issues/1175 | 10,794,620 | MDU6SXNzdWUxMDc5NDYyMA== | 1,175 | Cannot send multiple headers with the same name | {
"avatar_url": "https://avatars.githubusercontent.com/u/189873?v=4",
"events_url": "https://api.github.com/users/xealot/events{/privacy}",
"followers_url": "https://api.github.com/users/xealot/followers",
"following_url": "https://api.github.com/users/xealot/following{/other_user}",
"gists_url": "https://api.github.com/users/xealot/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xealot",
"id": 189873,
"login": "xealot",
"node_id": "MDQ6VXNlcjE4OTg3Mw==",
"organizations_url": "https://api.github.com/users/xealot/orgs",
"received_events_url": "https://api.github.com/users/xealot/received_events",
"repos_url": "https://api.github.com/users/xealot/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xealot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xealot/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xealot",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-02-08T20:37:26Z | 2021-09-09T05:00:44Z | 2013-02-10T22:27:41Z | NONE | resolved | Internally a dictionary is used, but that doesn't adhere to the http specification. Headers can be specified more than once with the same name.
Checkout werkzeug's Headers() data structure.
http://werkzeug.pocoo.org/docs/datastructures/#http-related
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1175/reactions"
} | https://api.github.com/repos/psf/requests/issues/1175/timeline | null | completed | null | null | false | [
"Related: #1155\n",
"Correct! Closing for #1155\n"
] |
https://api.github.com/repos/psf/requests/issues/1174 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1174/labels{/name} | https://api.github.com/repos/psf/requests/issues/1174/comments | https://api.github.com/repos/psf/requests/issues/1174/events | https://github.com/psf/requests/pull/1174 | 10,790,356 | MDExOlB1bGxSZXF1ZXN0NDA2MTQ1Nw== | 1,174 | Added the ability to track the referer between requests and cleaned up some docstrings | {
"avatar_url": "https://avatars.githubusercontent.com/u/2882?v=4",
"events_url": "https://api.github.com/users/nikolay/events{/privacy}",
"followers_url": "https://api.github.com/users/nikolay/followers",
"following_url": "https://api.github.com/users/nikolay/following{/other_user}",
"gists_url": "https://api.github.com/users/nikolay/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nikolay",
"id": 2882,
"login": "nikolay",
"node_id": "MDQ6VXNlcjI4ODI=",
"organizations_url": "https://api.github.com/users/nikolay/orgs",
"received_events_url": "https://api.github.com/users/nikolay/received_events",
"repos_url": "https://api.github.com/users/nikolay/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nikolay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nikolay/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nikolay",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-08T18:36:22Z | 2021-09-08T19:00:46Z | 2013-02-10T22:01:39Z | NONE | resolved | Added "track_referer" attribute and "last_page" to Session so that the last response's URL can be used as the referer on the next request. The header can still be overwritten globally via Session.headers or on per-request basis.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1174/reactions"
} | https://api.github.com/repos/psf/requests/issues/1174/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1174.diff",
"html_url": "https://github.com/psf/requests/pull/1174",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1174.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1174"
} | true | [
"we aren't really interested in adding new features at this time.\n\nthe other changes looked pretty nice though, could you remove `track_referer` and `last_page` so I can merge?\n",
"I really need this to simulate the browser's behavior and makes my code pretty ugly to get the URL from the previous request and p... |
https://api.github.com/repos/psf/requests/issues/1173 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1173/labels{/name} | https://api.github.com/repos/psf/requests/issues/1173/comments | https://api.github.com/repos/psf/requests/issues/1173/events | https://github.com/psf/requests/pull/1173 | 10,767,562 | MDExOlB1bGxSZXF1ZXN0NDA1MDM5NA== | 1,173 | Use send in resolve redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-02-08T04:11:02Z | 2021-09-08T23:06:06Z | 2013-02-10T22:21:13Z | CONTRIBUTOR | resolved | These three (which I'll happily squash if you'd like) should prevent the problem I mentioned [here](https://github.com/kennethreitz/requests/pull/1151#issuecomment-12905796).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1173/reactions"
} | https://api.github.com/repos/psf/requests/issues/1173/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1173.diff",
"html_url": "https://github.com/psf/requests/pull/1173",
"merged_at": "2013-02-10T22:21:13Z",
"patch_url": "https://github.com/psf/requests/pull/1173.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1173"
} | true | [
"+1\nGenerally speaking I've been thinking about raising issue with architecture for some time now :) The problem I see with current architecture is that redirect logic doesn't reuse standard path of sending requests and this causes all sorts of problems; I'm sure we've had more than few bugs because of this in the... |
https://api.github.com/repos/psf/requests/issues/1172 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1172/labels{/name} | https://api.github.com/repos/psf/requests/issues/1172/comments | https://api.github.com/repos/psf/requests/issues/1172/events | https://github.com/psf/requests/pull/1172 | 10,754,729 | MDExOlB1bGxSZXF1ZXN0NDA0NDExNQ== | 1,172 | #1170 suggestion for the requested refactoring | {
"avatar_url": "https://avatars.githubusercontent.com/u/175126?v=4",
"events_url": "https://api.github.com/users/grzn/events{/privacy}",
"followers_url": "https://api.github.com/users/grzn/followers",
"following_url": "https://api.github.com/users/grzn/following{/other_user}",
"gists_url": "https://api.github.com/users/grzn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/grzn",
"id": 175126,
"login": "grzn",
"node_id": "MDQ6VXNlcjE3NTEyNg==",
"organizations_url": "https://api.github.com/users/grzn/orgs",
"received_events_url": "https://api.github.com/users/grzn/received_events",
"repos_url": "https://api.github.com/users/grzn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/grzn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/grzn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/grzn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-02-07T20:43:38Z | 2021-09-08T19:00:46Z | 2013-02-07T22:09:55Z | NONE | resolved | okay i was too lazy to clone the repository and do this, but with the in-browser its really quick :)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1172/reactions"
} | https://api.github.com/repos/psf/requests/issues/1172/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1172.diff",
"html_url": "https://github.com/psf/requests/pull/1172",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1172.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1172"
} | true | [
"I'm entirely +0 on this.\n",
"This seems entirely pointless.\n\n@grzn sorry if that seems blunt, but I already made my intentions clear in the other conversation we had :)\n"
] |
https://api.github.com/repos/psf/requests/issues/1171 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1171/labels{/name} | https://api.github.com/repos/psf/requests/issues/1171/comments | https://api.github.com/repos/psf/requests/issues/1171/events | https://github.com/psf/requests/issues/1171 | 10,753,198 | MDU6SXNzdWUxMDc1MzE5OA== | 1,171 | ConnectionResetError on Windows 7/Python 3.3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/3504959?v=4",
"events_url": "https://api.github.com/users/norey/events{/privacy}",
"followers_url": "https://api.github.com/users/norey/followers",
"following_url": "https://api.github.com/users/norey/following{/other_user}",
"gists_url": "https://api.github.com/users/norey/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/norey",
"id": 3504959,
"login": "norey",
"node_id": "MDQ6VXNlcjM1MDQ5NTk=",
"organizations_url": "https://api.github.com/users/norey/orgs",
"received_events_url": "https://api.github.com/users/norey/received_events",
"repos_url": "https://api.github.com/users/norey/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/norey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/norey/subscriptions",
"type": "User",
"url": "https://api.github.com/users/norey",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 30 | 2013-02-07T20:02:41Z | 2021-09-09T05:00:45Z | 2013-02-08T23:47:33Z | NONE | resolved | I get this error whenever I use any URL with .get() on Windows 7 x64 and Python3.3
http://bpaste.net/show/cavZW7pfXISmFdNMga4n/
Edit: I forgot to mention that I get the error after waiting a while.. around 5 mins.. just waiting for the command to respond
Stacktrace:
``` python
Traceback (most recent call last):
File "<pyshell#1>", line 1, in <module>
r = requests.get('http://www.wwenews.us/1334995', allow_redirects=True)
File "C:\Python33\lib\site-packages\requests\api.py", line 55, in get
return request('get', url, **kwargs)
File "C:\Python33\lib\site-packages\requests\api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Python33\lib\site-packages\requests\sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "C:\Python33\lib\site-packages\requests\sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "C:\Python33\lib\site-packages\requests\adapters.py", line 222, in send
r.content
File "C:\Python33\lib\site-packages\requests\models.py", line 550, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "C:\Python33\lib\site-packages\requests\models.py", line 496, in generate
chunk = self.raw.read(chunk_size)
File "C:\Python33\lib\site-packages\requests\packages\urllib3\response.py", line 148, in read
return self._fp.read(amt)
File "C:\Python33\lib\http\client.py", line 499, in read
return super(HTTPResponse, self).read(amt)
File "C:\Python33\lib\http\client.py", line 534, in readinto
n = self.fp.readinto(b)
File "C:\Python33\lib\socket.py", line 297, in readinto
return self._sock.recv_into(b)
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/3504959?v=4",
"events_url": "https://api.github.com/users/norey/events{/privacy}",
"followers_url": "https://api.github.com/users/norey/followers",
"following_url": "https://api.github.com/users/norey/following{/other_user}",
"gists_url": "https://api.github.com/users/norey/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/norey",
"id": 3504959,
"login": "norey",
"node_id": "MDQ6VXNlcjM1MDQ5NTk=",
"organizations_url": "https://api.github.com/users/norey/orgs",
"received_events_url": "https://api.github.com/users/norey/received_events",
"repos_url": "https://api.github.com/users/norey/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/norey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/norey/subscriptions",
"type": "User",
"url": "https://api.github.com/users/norey",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1171/reactions"
} | https://api.github.com/repos/psf/requests/issues/1171/timeline | null | completed | null | null | false | [
"@shazow any clues?\n",
"On linux, requests fails to parse the response (It does parse the status code). The first header sent by the server is this one:\n(If I read the RFC correctly spaces in header names aren't allowed)\n\n```\nSecured by Excellent Serv: \n```\n\nIt seems this one breaks the response parsing. ... |
https://api.github.com/repos/psf/requests/issues/1170 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1170/labels{/name} | https://api.github.com/repos/psf/requests/issues/1170/comments | https://api.github.com/repos/psf/requests/issues/1170/events | https://github.com/psf/requests/issues/1170 | 10,753,141 | MDU6SXNzdWUxMDc1MzE0MQ== | 1,170 | Bring back the hooks from 0.x to 1.x | {
"avatar_url": "https://avatars.githubusercontent.com/u/175126?v=4",
"events_url": "https://api.github.com/users/grzn/events{/privacy}",
"followers_url": "https://api.github.com/users/grzn/followers",
"following_url": "https://api.github.com/users/grzn/following{/other_user}",
"gists_url": "https://api.github.com/users/grzn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/grzn",
"id": 175126,
"login": "grzn",
"node_id": "MDQ6VXNlcjE3NTEyNg==",
"organizations_url": "https://api.github.com/users/grzn/orgs",
"received_events_url": "https://api.github.com/users/grzn/received_events",
"repos_url": "https://api.github.com/users/grzn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/grzn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/grzn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/grzn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-07T20:01:11Z | 2021-09-09T05:00:45Z | 2013-02-08T03:19:25Z | NONE | resolved | In the 0.x versions were 5 hooks:
('args', 'pre_request', 'pre_send', 'post_request', 'response')
In 1.x there's only one: response
I've seen quite a few packages that used these hooks to manipulate the requests objects before sending them, and now in v1.x there's not even a single hook that allows them to do so.
This functionality is very much needed, and without it quite a few packages simple cannot adapt to v1.x, and their alternative is to the [sort-of-a-fork requests-transition](https://github.com/LuminosoInsight/python-requests-transition)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1170/reactions"
} | https://api.github.com/repos/psf/requests/issues/1170/timeline | null | completed | null | null | false | [
"We ased for package maintainers and authors that used the hooks extensively to comment on the change and received little feedback. I made use of one as well (args), but adapted with a small bit of work. I find it hard to believe that people can simply not make due without them.\n",
"We should throw together some... |
https://api.github.com/repos/psf/requests/issues/1169 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1169/labels{/name} | https://api.github.com/repos/psf/requests/issues/1169/comments | https://api.github.com/repos/psf/requests/issues/1169/events | https://github.com/psf/requests/pull/1169 | 10,713,352 | MDExOlB1bGxSZXF1ZXN0NDAyNDMxNw== | 1,169 | Fixed get_unicode_from_response() to do what it says in the docstring. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1270393?v=4",
"events_url": "https://api.github.com/users/Mimino666/events{/privacy}",
"followers_url": "https://api.github.com/users/Mimino666/followers",
"following_url": "https://api.github.com/users/Mimino666/following{/other_user}",
"gists_url": "https://api.github.com/users/Mimino666/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Mimino666",
"id": 1270393,
"login": "Mimino666",
"node_id": "MDQ6VXNlcjEyNzAzOTM=",
"organizations_url": "https://api.github.com/users/Mimino666/orgs",
"received_events_url": "https://api.github.com/users/Mimino666/received_events",
"repos_url": "https://api.github.com/users/Mimino666/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Mimino666/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Mimino666/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Mimino666",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2013-02-06T21:53:53Z | 2021-09-08T19:00:45Z | 2013-02-06T22:25:29Z | NONE | resolved | Also added a reasonable encoding in the fall-back case.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1169/reactions"
} | https://api.github.com/repos/psf/requests/issues/1169/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1169.diff",
"html_url": "https://github.com/psf/requests/pull/1169",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1169.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1169"
} | true | [
"The docstring is incorrect then\n",
"Hm, why is that? To me it sounded like a reasonable heuristic.\nAlso, how come this function is nowhere used?\n",
"Because Requests is not an HTML library. =) We used to parse HTML, but now we don't. The function is left over from when we did.\n",
"Oh, I thought you were ... |
https://api.github.com/repos/psf/requests/issues/1168 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1168/labels{/name} | https://api.github.com/repos/psf/requests/issues/1168/comments | https://api.github.com/repos/psf/requests/issues/1168/events | https://github.com/psf/requests/pull/1168 | 10,706,648 | MDExOlB1bGxSZXF1ZXN0NDAyMDYzNw== | 1,168 | Feature freeze. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-02-06T19:04:29Z | 2021-09-08T23:06:21Z | 2013-02-06T19:53:55Z | MEMBER | resolved | See issue #1165.
Not finished yet, gotta do the contributing.md thing.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1168/reactions"
} | https://api.github.com/repos/psf/requests/issues/1168/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1168.diff",
"html_url": "https://github.com/psf/requests/pull/1168",
"merged_at": "2013-02-06T19:53:55Z",
"patch_url": "https://github.com/psf/requests/pull/1168.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1168"
} | true | [
"<3\n"
] |
https://api.github.com/repos/psf/requests/issues/1167 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1167/labels{/name} | https://api.github.com/repos/psf/requests/issues/1167/comments | https://api.github.com/repos/psf/requests/issues/1167/events | https://github.com/psf/requests/issues/1167 | 10,664,386 | MDU6SXNzdWUxMDY2NDM4Ng== | 1,167 | push users to stack overflow first | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
}
] | closed | true | null | [] | null | 2 | 2013-02-05T19:46:58Z | 2021-09-08T23:04:51Z | 2015-05-03T15:09:22Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1167/reactions"
} | https://api.github.com/repos/psf/requests/issues/1167/timeline | null | completed | null | null | false | [
"I already occasionally answer questions tagged with `python-requests` so it wouldn't be a bad place for people to start.\n",
"+1\n"
] | |
https://api.github.com/repos/psf/requests/issues/1166 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1166/labels{/name} | https://api.github.com/repos/psf/requests/issues/1166/comments | https://api.github.com/repos/psf/requests/issues/1166/events | https://github.com/psf/requests/issues/1166 | 10,664,298 | MDU6SXNzdWUxMDY2NDI5OA== | 1,166 | Make test suite totally offline | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
}
] | closed | true | null | [] | null | 10 | 2013-02-05T19:44:33Z | 2021-09-08T23:10:37Z | 2014-09-01T14:38:30Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1166/reactions"
} | https://api.github.com/repos/psf/requests/issues/1166/timeline | null | completed | null | null | false | [
"We could use @kanzure's project which relies on HTTPretty or we could use mock like I do in github3.py. If you chose the latter, I'll be happy to work on the tests.\n",
"In particular, I think he is referring to [kanzure/python-requestions](https://github.com/kanzure/python-requestions). The httpetrified decorat... | |
https://api.github.com/repos/psf/requests/issues/1165 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1165/labels{/name} | https://api.github.com/repos/psf/requests/issues/1165/comments | https://api.github.com/repos/psf/requests/issues/1165/events | https://github.com/psf/requests/issues/1165 | 10,664,127 | MDU6SXNzdWUxMDY2NDEyNw== | 1,165 | Document Intentions/Status | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
}
] | closed | true | null | [] | null | 1 | 2013-02-05T19:39:38Z | 2021-09-09T03:00:33Z | 2013-05-29T07:59:44Z | CONTRIBUTOR | resolved | Document our perpetual "feature freeze".
Add contibuting.md so people see it when submitting a pull request.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1165/reactions"
} | https://api.github.com/repos/psf/requests/issues/1165/timeline | null | completed | null | null | false | [
"@kennethreitz Can you elaborate on what you want contributing.md to be, and how it should relate to the current dev docs?\n"
] |
https://api.github.com/repos/psf/requests/issues/1164 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1164/labels{/name} | https://api.github.com/repos/psf/requests/issues/1164/comments | https://api.github.com/repos/psf/requests/issues/1164/events | https://github.com/psf/requests/issues/1164 | 10,651,363 | MDU6SXNzdWUxMDY1MTM2Mw== | 1,164 | Problem when using PUT in v1.1 | {
"avatar_url": "https://avatars.githubusercontent.com/u/429923?v=4",
"events_url": "https://api.github.com/users/jaimebuelta/events{/privacy}",
"followers_url": "https://api.github.com/users/jaimebuelta/followers",
"following_url": "https://api.github.com/users/jaimebuelta/following{/other_user}",
"gists_url": "https://api.github.com/users/jaimebuelta/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaimebuelta",
"id": 429923,
"login": "jaimebuelta",
"node_id": "MDQ6VXNlcjQyOTkyMw==",
"organizations_url": "https://api.github.com/users/jaimebuelta/orgs",
"received_events_url": "https://api.github.com/users/jaimebuelta/received_events",
"repos_url": "https://api.github.com/users/jaimebuelta/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaimebuelta/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaimebuelta/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaimebuelta",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-02-05T14:18:48Z | 2021-09-09T05:00:46Z | 2013-02-07T14:40:45Z | NONE | resolved | Hi:
I'm having a problem when making PUT requests. This problem is not present on version 0.14.2, but it has arisen when I updated the module.
It seems that the content of the PUT (data), which should be encoded as a POST, is not being properly encoded. At least, I am not able to receive it when checking on the server. It appears as empty. If I try the 'params' parameter, then it is properly encoded as a QueryParam.
The curious thing is that using a POST seems to work fine. I assume that the interface is still the same.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1164/reactions"
} | https://api.github.com/repos/psf/requests/issues/1164/timeline | null | completed | null | null | false | [
"HTTPBin works fine for me with 'PUTs', can you provide some of the code you're using so I can try to reproduce the issue?\n",
"Ups, my mistake. I've been looking at that more carefully, and it turns out to be a problem on redirections...\n\nThe call was being redirected, so the body wasn't being sent again (whic... |
https://api.github.com/repos/psf/requests/issues/1163 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1163/labels{/name} | https://api.github.com/repos/psf/requests/issues/1163/comments | https://api.github.com/repos/psf/requests/issues/1163/events | https://github.com/psf/requests/issues/1163 | 10,637,355 | MDU6SXNzdWUxMDYzNzM1NQ== | 1,163 | What happened to danger_mode? | {
"avatar_url": "https://avatars.githubusercontent.com/u/575602?v=4",
"events_url": "https://api.github.com/users/zwass/events{/privacy}",
"followers_url": "https://api.github.com/users/zwass/followers",
"following_url": "https://api.github.com/users/zwass/following{/other_user}",
"gists_url": "https://api.github.com/users/zwass/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zwass",
"id": 575602,
"login": "zwass",
"node_id": "MDQ6VXNlcjU3NTYwMg==",
"organizations_url": "https://api.github.com/users/zwass/orgs",
"received_events_url": "https://api.github.com/users/zwass/received_events",
"repos_url": "https://api.github.com/users/zwass/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zwass/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zwass/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zwass",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 15 | 2013-02-05T04:29:15Z | 2021-09-08T23:10:48Z | 2013-02-05T17:29:09Z | NONE | resolved | I was just going to suggest this feature when I noticed pull request https://github.com/kennethreitz/requests/pull/333.
Looking in the current code, I can't find any indication of `danger_mode`, or a similar setting. Was there a reason this was removed? I'd be happy to contribute to bringing it back.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/575602?v=4",
"events_url": "https://api.github.com/users/zwass/events{/privacy}",
"followers_url": "https://api.github.com/users/zwass/followers",
"following_url": "https://api.github.com/users/zwass/following{/other_user}",
"gists_url": "https://api.github.com/users/zwass/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zwass",
"id": 575602,
"login": "zwass",
"node_id": "MDQ6VXNlcjU3NTYwMg==",
"organizations_url": "https://api.github.com/users/zwass/orgs",
"received_events_url": "https://api.github.com/users/zwass/received_events",
"repos_url": "https://api.github.com/users/zwass/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zwass/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zwass/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zwass",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/1163/reactions"
} | https://api.github.com/repos/psf/requests/issues/1163/timeline | null | completed | null | null | false | [
"I suspect it got pulled out during the big refactor. I'm not opposed to having it back, depends what @kennethreitz thinks.\n",
"Danger mode is now the default and the only mode. Safe mode was regarded as useless. Now, that's good news for you! :)\n",
"I'm pretty sure it was removed because it was deemed an unn... |
https://api.github.com/repos/psf/requests/issues/1162 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1162/labels{/name} | https://api.github.com/repos/psf/requests/issues/1162/comments | https://api.github.com/repos/psf/requests/issues/1162/events | https://github.com/psf/requests/pull/1162 | 10,557,230 | MDExOlB1bGxSZXF1ZXN0Mzk1MzU2NA== | 1,162 | Proxy Authorization Headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-01T20:10:31Z | 2021-09-09T00:01:20Z | 2013-02-06T21:05:04Z | MEMBER | resolved | This is one half of the pair of open problems from #1053. Please code review this before pulling it.
I concluded that, as this is fundamentally an authentication issue, this belongs in our code, not in urllib3. For the moment, I have it set up so that if the authentication is provided in the URL, we simply grab it out. It might be worth turning this into a separate part of the API though. Let me know what you think.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1162/reactions"
} | https://api.github.com/repos/psf/requests/issues/1162/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1162.diff",
"html_url": "https://github.com/psf/requests/pull/1162",
"merged_at": "2013-02-06T21:05:04Z",
"patch_url": "https://github.com/psf/requests/pull/1162.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1162"
} | true | [
"Goddamn it Travis! =D\n",
"Travis is the child we love when it does what we want and hate when it \ndoesn't... except it isn't our child.\n",
"currently, proxies are only supported in the connection adapter layer, so this shouldn't be surfaced higher up\n\nas always, correct me if i'm wrong :)\n",
"Not sure.... |
https://api.github.com/repos/psf/requests/issues/1161 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1161/labels{/name} | https://api.github.com/repos/psf/requests/issues/1161/comments | https://api.github.com/repos/psf/requests/issues/1161/events | https://github.com/psf/requests/pull/1161 | 10,547,156 | MDExOlB1bGxSZXF1ZXN0Mzk1MDE5NA== | 1,161 | If Content-Length is already set, don't override | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-02-01T17:01:29Z | 2021-09-08T19:00:45Z | 2013-02-10T22:07:08Z | CONTRIBUTOR | resolved | Re: #1159
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1161/reactions"
} | https://api.github.com/repos/psf/requests/issues/1161/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1161.diff",
"html_url": "https://github.com/psf/requests/pull/1161",
"merged_at": "2013-02-10T22:07:08Z",
"patch_url": "https://github.com/psf/requests/pull/1161.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1161"
} | true | [
"Nice. =)\n\nIt should be noted that this will not resolve the issue raised in #1159, as if I set Content Length to anything falsy this will fail (this includes zero). I don't know if we want to allow the forcing of Content-Length to weird values this way, but if we do you'll need to take another look at this.\n",
... |
https://api.github.com/repos/psf/requests/issues/1160 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1160/labels{/name} | https://api.github.com/repos/psf/requests/issues/1160/comments | https://api.github.com/repos/psf/requests/issues/1160/events | https://github.com/psf/requests/issues/1160 | 10,531,354 | MDU6SXNzdWUxMDUzMTM1NA== | 1,160 | Auth handlers are unable to modify query strings/form data sanely | {
"avatar_url": "https://avatars.githubusercontent.com/u/92943?v=4",
"events_url": "https://api.github.com/users/gholms/events{/privacy}",
"followers_url": "https://api.github.com/users/gholms/followers",
"following_url": "https://api.github.com/users/gholms/following{/other_user}",
"gists_url": "https://api.github.com/users/gholms/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gholms",
"id": 92943,
"login": "gholms",
"node_id": "MDQ6VXNlcjkyOTQz",
"organizations_url": "https://api.github.com/users/gholms/orgs",
"received_events_url": "https://api.github.com/users/gholms/received_events",
"repos_url": "https://api.github.com/users/gholms/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gholms/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gholms/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gholms",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-02-01T07:41:21Z | 2021-09-09T05:00:43Z | 2013-02-10T22:27:51Z | NONE | resolved | I'm trying to port the parameter-based authentication scheme that AWS uses to requests 1 from an older version. It uses a request's parameters to generate signature parameters of its own and then augments the request with them. The resulting parameters then go into the request as either a query string or form data. As a result, this handler needs to be able to modify those, but since requests 1 just hands auth handlers PreparedRequests and no references at all to the original Requests, query strings and form data (and in fact everything other than headers) become incredibly inconvenient to modify.
I'm handing the auth handler to a Session and then calling that Session's request method a bunch of times. Is there a way to make that (also?) give the auth handler the original Request whenever it gives it a PreparedRequest without breaking an interface somewhere? Should I be unpacking everything with urlparse and cgi and then re-calling prepare_url and prepare_body? Or is there another fix/workaround that might be better?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1160/reactions"
} | https://api.github.com/repos/psf/requests/issues/1160/timeline | null | completed | null | null | false | [
"Basically, you should just parse those things out of the body. Fairly simple.\n",
"Yeah, it's just more obnoxious than modifying the dict that produced them since it involves unpacking and repacking the body. :-\\ Do I have any hope of getting the info from the original Request to the auth handler as well?\n"
... |
https://api.github.com/repos/psf/requests/issues/1159 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1159/labels{/name} | https://api.github.com/repos/psf/requests/issues/1159/comments | https://api.github.com/repos/psf/requests/issues/1159/events | https://github.com/psf/requests/issues/1159 | 10,524,929 | MDU6SXNzdWUxMDUyNDkyOQ== | 1,159 | Feature: ability to force / remove any header to a request | {
"avatar_url": "https://avatars.githubusercontent.com/u/214840?v=4",
"events_url": "https://api.github.com/users/mtourne/events{/privacy}",
"followers_url": "https://api.github.com/users/mtourne/followers",
"following_url": "https://api.github.com/users/mtourne/following{/other_user}",
"gists_url": "https://api.github.com/users/mtourne/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mtourne",
"id": 214840,
"login": "mtourne",
"node_id": "MDQ6VXNlcjIxNDg0MA==",
"organizations_url": "https://api.github.com/users/mtourne/orgs",
"received_events_url": "https://api.github.com/users/mtourne/received_events",
"repos_url": "https://api.github.com/users/mtourne/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mtourne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mtourne/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mtourne",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-02-01T01:02:45Z | 2021-09-09T05:00:38Z | 2013-02-10T22:36:58Z | NONE | resolved | Hi,
I use requests more and more to test the behavior of my app that runs on Nginx.
I was also planning into using requests to test the behavior when using incorrect HTTP headers, to assert that Nginx does the right thing.
Unfortunately it's impossible to specify Content-Length: '' (I would expect Content-Length: \r\n), or Content-Length: None (or False) (the header shouldn't be in the request at all)
When using the POST interface.
Maybe there is a non obvious way to do that with requests, which I haven't found in the doc ?
For now I will probably end up using a raw socket connection, but it's too bad it's not possible to use requests for those "expected failure" tests.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1159/reactions"
} | https://api.github.com/repos/psf/requests/issues/1159/timeline | null | completed | null | null | false | [
"Couldn't you just modify the headers dictionary when creating a request object?\nhttp://docs.python-requests.org/en/latest/user/advanced/#request-and-response-objects\nhttp://docs.python-requests.org/en/latest/api/#lower-level-classes\n\nNote: For Content-Length, it might be set when you prepare the request (actua... |
https://api.github.com/repos/psf/requests/issues/1158 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1158/labels{/name} | https://api.github.com/repos/psf/requests/issues/1158/comments | https://api.github.com/repos/psf/requests/issues/1158/events | https://github.com/psf/requests/pull/1158 | 10,513,723 | MDExOlB1bGxSZXF1ZXN0MzkzMzIxOA== | 1,158 | Fix check that breaks handling of 303 response in some cases (v2) | {
"avatar_url": "https://avatars.githubusercontent.com/u/1036377?v=4",
"events_url": "https://api.github.com/users/yehudasa/events{/privacy}",
"followers_url": "https://api.github.com/users/yehudasa/followers",
"following_url": "https://api.github.com/users/yehudasa/following{/other_user}",
"gists_url": "https://api.github.com/users/yehudasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yehudasa",
"id": 1036377,
"login": "yehudasa",
"node_id": "MDQ6VXNlcjEwMzYzNzc=",
"organizations_url": "https://api.github.com/users/yehudasa/orgs",
"received_events_url": "https://api.github.com/users/yehudasa/received_events",
"repos_url": "https://api.github.com/users/yehudasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yehudasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yehudasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yehudasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-01-31T19:25:33Z | 2021-09-08T19:00:45Z | 2013-02-01T15:30:47Z | CONTRIBUTOR | resolved | This fixes issue #1156.
Signed-off-by: Yehuda Sadeh yehuda@inktank.com
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1158/reactions"
} | https://api.github.com/repos/psf/requests/issues/1158/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1158.diff",
"html_url": "https://github.com/psf/requests/pull/1158",
"merged_at": "2013-02-01T15:30:47Z",
"patch_url": "https://github.com/psf/requests/pull/1158.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1158"
} | true | [
"The test failure here is not related to the pull request.\n",
"thank you, this is much more proper.\n"
] |
https://api.github.com/repos/psf/requests/issues/1157 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1157/labels{/name} | https://api.github.com/repos/psf/requests/issues/1157/comments | https://api.github.com/repos/psf/requests/issues/1157/events | https://github.com/psf/requests/pull/1157 | 10,511,901 | MDExOlB1bGxSZXF1ZXN0MzkzMjI4MQ== | 1,157 | Fix check that breaks handling of 303 response in some cases | {
"avatar_url": "https://avatars.githubusercontent.com/u/1036377?v=4",
"events_url": "https://api.github.com/users/yehudasa/events{/privacy}",
"followers_url": "https://api.github.com/users/yehudasa/followers",
"following_url": "https://api.github.com/users/yehudasa/following{/other_user}",
"gists_url": "https://api.github.com/users/yehudasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yehudasa",
"id": 1036377,
"login": "yehudasa",
"node_id": "MDQ6VXNlcjEwMzYzNzc=",
"organizations_url": "https://api.github.com/users/yehudasa/orgs",
"received_events_url": "https://api.github.com/users/yehudasa/received_events",
"repos_url": "https://api.github.com/users/yehudasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yehudasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yehudasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yehudasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-01-31T18:37:45Z | 2021-09-08T19:00:44Z | 2013-01-31T19:24:33Z | CONTRIBUTOR | resolved | This fixes issue #1156.
Signed-off-by: Yehuda Sadeh yehuda@inktank.com
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1036377?v=4",
"events_url": "https://api.github.com/users/yehudasa/events{/privacy}",
"followers_url": "https://api.github.com/users/yehudasa/followers",
"following_url": "https://api.github.com/users/yehudasa/following{/other_user}",
"gists_url": "https://api.github.com/users/yehudasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yehudasa",
"id": 1036377,
"login": "yehudasa",
"node_id": "MDQ6VXNlcjEwMzYzNzc=",
"organizations_url": "https://api.github.com/users/yehudasa/orgs",
"received_events_url": "https://api.github.com/users/yehudasa/received_events",
"repos_url": "https://api.github.com/users/yehudasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yehudasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yehudasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yehudasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1157/reactions"
} | https://api.github.com/repos/psf/requests/issues/1157/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1157.diff",
"html_url": "https://github.com/psf/requests/pull/1157",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1157.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1157"
} | true | [
"Thanks for the fix! From a personal perspective, I'd rather you changed the line to:\n\n``` python\nif resp.status_code == codes.see_other and req.method != 'HEAD':\n```\n\nBoth versions (yours and mine) will fail if `codes.see_other` ever returns more than one code, but I'm not keen on creating a single-element t... |
https://api.github.com/repos/psf/requests/issues/1156 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1156/labels{/name} | https://api.github.com/repos/psf/requests/issues/1156/comments | https://api.github.com/repos/psf/requests/issues/1156/events | https://github.com/psf/requests/issues/1156 | 10,511,057 | MDU6SXNzdWUxMDUxMTA1Nw== | 1,156 | POST 303 redirect response mishandling | {
"avatar_url": "https://avatars.githubusercontent.com/u/1036377?v=4",
"events_url": "https://api.github.com/users/yehudasa/events{/privacy}",
"followers_url": "https://api.github.com/users/yehudasa/followers",
"following_url": "https://api.github.com/users/yehudasa/following{/other_user}",
"gists_url": "https://api.github.com/users/yehudasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yehudasa",
"id": 1036377,
"login": "yehudasa",
"node_id": "MDQ6VXNlcjEwMzYzNzc=",
"organizations_url": "https://api.github.com/users/yehudasa/orgs",
"received_events_url": "https://api.github.com/users/yehudasa/received_events",
"repos_url": "https://api.github.com/users/yehudasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yehudasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yehudasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yehudasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2013-01-31T18:20:53Z | 2021-09-09T05:00:43Z | 2013-02-10T22:32:30Z | CONTRIBUTOR | resolved | In 1.1.0 when getting 303 on POST, instead of sending a GET request, it sends POST.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1156/reactions"
} | https://api.github.com/repos/psf/requests/issues/1156/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/1155 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1155/labels{/name} | https://api.github.com/repos/psf/requests/issues/1155/comments | https://api.github.com/repos/psf/requests/issues/1155/events | https://github.com/psf/requests/issues/1155 | 10,510,213 | MDU6SXNzdWUxMDUxMDIxMw== | 1,155 | Add MultiDict Support | {
"avatar_url": "https://avatars.githubusercontent.com/u/614430?v=4",
"events_url": "https://api.github.com/users/dmckeone/events{/privacy}",
"followers_url": "https://api.github.com/users/dmckeone/followers",
"following_url": "https://api.github.com/users/dmckeone/following{/other_user}",
"gists_url": "https://api.github.com/users/dmckeone/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dmckeone",
"id": 614430,
"login": "dmckeone",
"node_id": "MDQ6VXNlcjYxNDQzMA==",
"organizations_url": "https://api.github.com/users/dmckeone/orgs",
"received_events_url": "https://api.github.com/users/dmckeone/received_events",
"repos_url": "https://api.github.com/users/dmckeone/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dmckeone/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dmckeone/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dmckeone",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "f7c6c7",
"default": false,
"description": null... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 79 | 2013-01-31T18:02:52Z | 2021-09-08T17:05:21Z | 2015-03-05T11:19:50Z | NONE | resolved | [Comment by Kenneth Reitz](https://github.com/kennethreitz/requests/pull/1103#issuecomment-12370830):
> We need to support MultiDict. This is long overdue.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1155/reactions"
} | https://api.github.com/repos/psf/requests/issues/1155/timeline | null | completed | null | null | false | [
"+1\n",
"Should the values be ordered or not? I have no preference, I'm just wondering if others do.\n",
"For what? Headers? Query string?\n\nTypically I would say yes either way. Preserving order does not occlude the un-ordered use case whereas the opposite does.\n",
"@xealot yeah, that was my opinion. I hav... |
https://api.github.com/repos/psf/requests/issues/1154 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1154/labels{/name} | https://api.github.com/repos/psf/requests/issues/1154/comments | https://api.github.com/repos/psf/requests/issues/1154/events | https://github.com/psf/requests/pull/1154 | 10,490,869 | MDExOlB1bGxSZXF1ZXN0MzkyMjExMA== | 1,154 | Added r.ppjson() functionality. | {
"avatar_url": "https://avatars.githubusercontent.com/u/545666?v=4",
"events_url": "https://api.github.com/users/joaquincasares/events{/privacy}",
"followers_url": "https://api.github.com/users/joaquincasares/followers",
"following_url": "https://api.github.com/users/joaquincasares/following{/other_user}",
"gists_url": "https://api.github.com/users/joaquincasares/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joaquincasares",
"id": 545666,
"login": "joaquincasares",
"node_id": "MDQ6VXNlcjU0NTY2Ng==",
"organizations_url": "https://api.github.com/users/joaquincasares/orgs",
"received_events_url": "https://api.github.com/users/joaquincasares/received_events",
"repos_url": "https://api.github.com/users/joaquincasares/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joaquincasares/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joaquincasares/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joaquincasares",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-01-31T07:18:46Z | 2021-09-08T19:00:44Z | 2013-01-31T14:32:58Z | NONE | resolved | I find myself continuously making a pretty_print type method when dealing with r.json() commands. Figured it may better placed back inside requests.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1154/reactions"
} | https://api.github.com/repos/psf/requests/issues/1154/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1154.diff",
"html_url": "https://github.com/psf/requests/pull/1154",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1154.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1154"
} | true | [
"I don't really see the need for this to be in Requests. Requests is an HTTP library. We only have a `json()` method because it's a insanely common use-case and it's convenient. Printing the JSON string in a nice way is a less common case and nothing to do with HTTP. =)\n\nI just don't think this is worth clutterin... |
https://api.github.com/repos/psf/requests/issues/1153 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1153/labels{/name} | https://api.github.com/repos/psf/requests/issues/1153/comments | https://api.github.com/repos/psf/requests/issues/1153/events | https://github.com/psf/requests/pull/1153 | 10,482,018 | MDExOlB1bGxSZXF1ZXN0MzkxODA0Nw== | 1,153 | use only base filename in multipart file upload | {
"avatar_url": "https://avatars.githubusercontent.com/u/170360?v=4",
"events_url": "https://api.github.com/users/cbare/events{/privacy}",
"followers_url": "https://api.github.com/users/cbare/followers",
"following_url": "https://api.github.com/users/cbare/following{/other_user}",
"gists_url": "https://api.github.com/users/cbare/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cbare",
"id": 170360,
"login": "cbare",
"node_id": "MDQ6VXNlcjE3MDM2MA==",
"organizations_url": "https://api.github.com/users/cbare/orgs",
"received_events_url": "https://api.github.com/users/cbare/received_events",
"repos_url": "https://api.github.com/users/cbare/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cbare/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cbare/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cbare",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-01-30T23:50:32Z | 2021-09-08T19:00:43Z | 2013-01-30T23:56:21Z | NONE | resolved | I have a tiny patch, which enforces the correct behavior in multipart/form-data file uploads. The function guess_filename in requests/utils.py extracts the filename from the file-like-object from which we stream the file's contents. In the case of a file, this gives the full path on the local filesystem to the given file, which is then propagated to the request headers like this (in urllib3/filepost.py):
'Content-Disposition: form-data; name="%s"; filename="%s"\r\n' % (fieldname, filename)
RFC 2388 says this:
> The original local file name may be supplied as well, either as a
> "filename" parameter either of the "content-disposition: form-data"
> header or, in the case of multiple files, in a "content-disposition:
> file" header of the subpart.
It's my understanding that the correct behavior, implemented in web browsers, is to include the file's _name_ and not its full _path_ on the local filesystem. I added a call to _os.path.basename_ to shorted any paths to the base filename.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1153/reactions"
} | https://api.github.com/repos/psf/requests/issues/1153/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1153.diff",
"html_url": "https://github.com/psf/requests/pull/1153",
"merged_at": "2013-01-30T23:56:21Z",
"patch_url": "https://github.com/psf/requests/pull/1153.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1153"
} | true | [
"seems good to me!\n"
] |
https://api.github.com/repos/psf/requests/issues/1152 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1152/labels{/name} | https://api.github.com/repos/psf/requests/issues/1152/comments | https://api.github.com/repos/psf/requests/issues/1152/events | https://github.com/psf/requests/pull/1152 | 10,474,310 | MDExOlB1bGxSZXF1ZXN0MzkxNDA0OA== | 1,152 | Update docs/user/advanced.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/1141204?v=4",
"events_url": "https://api.github.com/users/ekatsah/events{/privacy}",
"followers_url": "https://api.github.com/users/ekatsah/followers",
"following_url": "https://api.github.com/users/ekatsah/following{/other_user}",
"gists_url": "https://api.github.com/users/ekatsah/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ekatsah",
"id": 1141204,
"login": "ekatsah",
"node_id": "MDQ6VXNlcjExNDEyMDQ=",
"organizations_url": "https://api.github.com/users/ekatsah/orgs",
"received_events_url": "https://api.github.com/users/ekatsah/received_events",
"repos_url": "https://api.github.com/users/ekatsah/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ekatsah/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekatsah/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ekatsah",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-01-30T20:22:50Z | 2021-09-08T19:00:44Z | 2013-01-30T23:54:20Z | CONTRIBUTOR | resolved | Rephrasing a line in the docs, add explicite mention of "client side certificate" (for indexing and clarity)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1152/reactions"
} | https://api.github.com/repos/psf/requests/issues/1152/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1152.diff",
"html_url": "https://github.com/psf/requests/pull/1152",
"merged_at": "2013-01-30T23:54:20Z",
"patch_url": "https://github.com/psf/requests/pull/1152.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1152"
} | true | [
":cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1151 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1151/labels{/name} | https://api.github.com/repos/psf/requests/issues/1151/comments | https://api.github.com/repos/psf/requests/issues/1151/events | https://github.com/psf/requests/pull/1151 | 10,469,342 | MDExOlB1bGxSZXF1ZXN0MzkxMTQ0OQ== | 1,151 | Move redirect handling from Session.request to Session.send | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 6 | 2013-01-30T18:17:08Z | 2021-09-08T23:01:05Z | 2013-02-05T19:42:51Z | CONTRIBUTOR | resolved | This closes #1133 and allows users to use Session.send with a prepared request. The tests pass, but I just thought of a separate instance where this may not work properly, so don't merge right away.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1151/reactions"
} | https://api.github.com/repos/psf/requests/issues/1151/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1151.diff",
"html_url": "https://github.com/psf/requests/pull/1151",
"merged_at": "2013-02-05T19:42:51Z",
"patch_url": "https://github.com/psf/requests/pull/1151.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1151"
} | true | [
"Yeah, my intuition was correct:\n\n``` pycon\n>>> import requests\n>>> r = requests.Request('GET', 'https://httpbin.org/redirect/2')\n>>> p = r.prepare()\n>>> s = requests.Session()\n>>> resp = s.send(p) \nTraceback (most recent call last):\n File \"<stdin>\", line 1, in <module>\n File \"requests/sessions.... |
https://api.github.com/repos/psf/requests/issues/1150 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1150/labels{/name} | https://api.github.com/repos/psf/requests/issues/1150/comments | https://api.github.com/repos/psf/requests/issues/1150/events | https://github.com/psf/requests/issues/1150 | 10,429,834 | MDU6SXNzdWUxMDQyOTgzNA== | 1,150 | On some pages requests detect encoding incorrectly | {
"avatar_url": "https://avatars.githubusercontent.com/u/976661?v=4",
"events_url": "https://api.github.com/users/Euphorbium/events{/privacy}",
"followers_url": "https://api.github.com/users/Euphorbium/followers",
"following_url": "https://api.github.com/users/Euphorbium/following{/other_user}",
"gists_url": "https://api.github.com/users/Euphorbium/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Euphorbium",
"id": 976661,
"login": "Euphorbium",
"node_id": "MDQ6VXNlcjk3NjY2MQ==",
"organizations_url": "https://api.github.com/users/Euphorbium/orgs",
"received_events_url": "https://api.github.com/users/Euphorbium/received_events",
"repos_url": "https://api.github.com/users/Euphorbium/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Euphorbium/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Euphorbium/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Euphorbium",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-01-29T19:18:27Z | 2021-09-09T00:34:21Z | 2013-01-29T19:24:02Z | NONE | resolved | For example it detects http://www.15min.lt encoding as ISO-8859-1, but the encoding is set as utf8 <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1150/reactions"
} | https://api.github.com/repos/psf/requests/issues/1150/timeline | null | completed | null | null | false | [
"This is a duplicate of #1087. You can see there that we don't read the content to determine the encoding. If you want you can use `apparent_encoding()` to get an encoding from [charade](/sigmavirus24/charade). You can also use `from requests.utils import get_encodings_from_content`, but we don't parse the HTML any... |
https://api.github.com/repos/psf/requests/issues/1149 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1149/labels{/name} | https://api.github.com/repos/psf/requests/issues/1149/comments | https://api.github.com/repos/psf/requests/issues/1149/events | https://github.com/psf/requests/pull/1149 | 10,428,655 | MDExOlB1bGxSZXF1ZXN0Mzg5MTQ4Mw== | 1,149 | Update cacert.pem | {
"avatar_url": "https://avatars.githubusercontent.com/u/7321?v=4",
"events_url": "https://api.github.com/users/nacht/events{/privacy}",
"followers_url": "https://api.github.com/users/nacht/followers",
"following_url": "https://api.github.com/users/nacht/following{/other_user}",
"gists_url": "https://api.github.com/users/nacht/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nacht",
"id": 7321,
"login": "nacht",
"node_id": "MDQ6VXNlcjczMjE=",
"organizations_url": "https://api.github.com/users/nacht/orgs",
"received_events_url": "https://api.github.com/users/nacht/received_events",
"repos_url": "https://api.github.com/users/nacht/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nacht/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nacht/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nacht",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2013-01-29T18:47:07Z | 2021-09-08T23:11:10Z | 2013-02-10T22:10:16Z | NONE | resolved | Updated cacert.pem with latest from http://curl.haxx.se/ca/cacert.pem
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1149/reactions"
} | https://api.github.com/repos/psf/requests/issues/1149/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1149.diff",
"html_url": "https://github.com/psf/requests/pull/1149",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1149.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1149"
} | true | [
"so, this cert list is great, however it contains a bunch of blacklisted certs as well.\n\nI've been manually removing them. They need to be removed again. We should maintain a list perhaps.\n",
"Nod nod. Perhaps on the wiki?\n",
"why remove them? to keep the size down?\n",
"@ansel1, why remove blacklisted c... |
https://api.github.com/repos/psf/requests/issues/1148 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1148/labels{/name} | https://api.github.com/repos/psf/requests/issues/1148/comments | https://api.github.com/repos/psf/requests/issues/1148/events | https://github.com/psf/requests/pull/1148 | 10,383,632 | MDExOlB1bGxSZXF1ZXN0Mzg2OTI4OA== | 1,148 | Move the timing work to Session.send | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2013-01-28T17:16:44Z | 2021-09-08T22:01:19Z | 2013-01-28T17:40:11Z | CONTRIBUTOR | resolved | per @kennethreitz's request
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1148/reactions"
} | https://api.github.com/repos/psf/requests/issues/1148/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1148.diff",
"html_url": "https://github.com/psf/requests/pull/1148",
"merged_at": "2013-01-28T17:40:10Z",
"patch_url": "https://github.com/psf/requests/pull/1148.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1148"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/1147 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1147/labels{/name} | https://api.github.com/repos/psf/requests/issues/1147/comments | https://api.github.com/repos/psf/requests/issues/1147/events | https://github.com/psf/requests/issues/1147 | 10,354,426 | MDU6SXNzdWUxMDM1NDQyNg== | 1,147 | Throws errors with socks module | {
"avatar_url": "https://avatars.githubusercontent.com/u/1643864?v=4",
"events_url": "https://api.github.com/users/infodox/events{/privacy}",
"followers_url": "https://api.github.com/users/infodox/followers",
"following_url": "https://api.github.com/users/infodox/following{/other_user}",
"gists_url": "https://api.github.com/users/infodox/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/infodox",
"id": 1643864,
"login": "infodox",
"node_id": "MDQ6VXNlcjE2NDM4NjQ=",
"organizations_url": "https://api.github.com/users/infodox/orgs",
"received_events_url": "https://api.github.com/users/infodox/received_events",
"repos_url": "https://api.github.com/users/infodox/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/infodox/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/infodox/subscriptions",
"type": "User",
"url": "https://api.github.com/users/infodox",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2013-01-27T14:37:49Z | 2021-09-09T05:00:43Z | 2013-02-10T22:30:25Z | NONE | resolved | Hey,
I have been trying to get requests to play nice with the "Socks" module (from http://code.google.com/p/socksipy-branch/). urllib3 and httplib work fine with it, but the requests wrapper does not. Here is an example.
```
Python 2.7.3 (default, Sep 26 2012, 21:51:14)
[GCC 4.7.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import socks
>>> import requests
>>> socks.setdefaultproxy(socks.PROXY_TYPE_SOCKS5, 'localhost', 9050)
>>> socks.wrapmodule(requests)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "socks.py", line 107, in wrapmodule
module.socket.socket = socksocket
AttributeError: 'module' object has no attribute 'socket'
>>>
```
Hopefully there is a workaround for this :) Socks works with almost every other module, so it makes no sense for it to not work with requests.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1147/reactions"
} | https://api.github.com/repos/psf/requests/issues/1147/timeline | null | completed | null | null | false | [
"Very interesting. \n\nI wonder if this is a bug with socks or not.\n",
"It looks like wrapmodule (from the trace back) is trying to monkey patch the socket stdlib. We don't use it directly, so if it isn't expecting our use of urllib3 then it makes sense it would fail.\n",
"Yep. `wrapmodule` is expecting that r... |
https://api.github.com/repos/psf/requests/issues/1146 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1146/labels{/name} | https://api.github.com/repos/psf/requests/issues/1146/comments | https://api.github.com/repos/psf/requests/issues/1146/events | https://github.com/psf/requests/pull/1146 | 10,345,840 | MDExOlB1bGxSZXF1ZXN0Mzg1NTE3MA== | 1,146 | It`s more pep8 now | {
"avatar_url": "https://avatars.githubusercontent.com/u/642195?v=4",
"events_url": "https://api.github.com/users/oczkers/events{/privacy}",
"followers_url": "https://api.github.com/users/oczkers/followers",
"following_url": "https://api.github.com/users/oczkers/following{/other_user}",
"gists_url": "https://api.github.com/users/oczkers/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/oczkers",
"id": 642195,
"login": "oczkers",
"node_id": "MDQ6VXNlcjY0MjE5NQ==",
"organizations_url": "https://api.github.com/users/oczkers/orgs",
"received_events_url": "https://api.github.com/users/oczkers/received_events",
"repos_url": "https://api.github.com/users/oczkers/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/oczkers/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oczkers/subscriptions",
"type": "User",
"url": "https://api.github.com/users/oczkers",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-01-27T01:07:11Z | 2021-09-08T19:00:43Z | 2013-01-28T03:11:15Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1146/reactions"
} | https://api.github.com/repos/psf/requests/issues/1146/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1146.diff",
"html_url": "https://github.com/psf/requests/pull/1146",
"merged_at": "2013-01-28T03:11:15Z",
"patch_url": "https://github.com/psf/requests/pull/1146.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1146"
} | true | [
"I disagree with one of these changes.\n\nWe'll see how long I can stand it :)\n",
"Demanding one blank line (instead of the two) between function definitions is a very bad idea. We should try to create some coding standard for Requests.\n",
"@piotr-dobrogost why is it a bad idea?\n",
"@sigmavirus24 \n\nBecau... | |
https://api.github.com/repos/psf/requests/issues/1145 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1145/labels{/name} | https://api.github.com/repos/psf/requests/issues/1145/comments | https://api.github.com/repos/psf/requests/issues/1145/events | https://github.com/psf/requests/pull/1145 | 10,340,238 | MDExOlB1bGxSZXF1ZXN0Mzg1MzMxNQ== | 1,145 | Mock the links test | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-01-26T17:04:05Z | 2021-09-08T19:00:42Z | 2013-01-26T17:05:19Z | CONTRIBUTOR | resolved | Since Travis hits the GitHub API so frequently, you will sometimes run into issues where GitHub's ratelimit has been exceeded by the IP address being used. This mocks the headers from a good response from the API, and performs the test. It also shaves off about 10s on the test run on my local (horrible) internet.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1145/reactions"
} | https://api.github.com/repos/psf/requests/issues/1145/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1145.diff",
"html_url": "https://github.com/psf/requests/pull/1145",
"merged_at": "2013-01-26T17:05:19Z",
"patch_url": "https://github.com/psf/requests/pull/1145.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1145"
} | true | [
":cake:\n",
"love it!\n"
] |
https://api.github.com/repos/psf/requests/issues/1144 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1144/labels{/name} | https://api.github.com/repos/psf/requests/issues/1144/comments | https://api.github.com/repos/psf/requests/issues/1144/events | https://github.com/psf/requests/issues/1144 | 10,336,188 | MDU6SXNzdWUxMDMzNjE4OA== | 1,144 | Bad Request on some sites | {
"avatar_url": "https://avatars.githubusercontent.com/u/478194?v=4",
"events_url": "https://api.github.com/users/observerss/events{/privacy}",
"followers_url": "https://api.github.com/users/observerss/followers",
"following_url": "https://api.github.com/users/observerss/following{/other_user}",
"gists_url": "https://api.github.com/users/observerss/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/observerss",
"id": 478194,
"login": "observerss",
"node_id": "MDQ6VXNlcjQ3ODE5NA==",
"organizations_url": "https://api.github.com/users/observerss/orgs",
"received_events_url": "https://api.github.com/users/observerss/received_events",
"repos_url": "https://api.github.com/users/observerss/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/observerss/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/observerss/subscriptions",
"type": "User",
"url": "https://api.github.com/users/observerss",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-01-26T08:52:47Z | 2021-09-09T05:00:48Z | 2013-01-26T15:13:29Z | NONE | resolved | ``` python
print requests.get('http://thepiratebay.se/recent').content
```
the code above runs normally in requests 0.14.2
but, tpb returns bad request in requests 1.1.0
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1144/reactions"
} | https://api.github.com/repos/psf/requests/issues/1144/timeline | null | completed | null | null | false | [
"This is hard for me to test [in the UK](http://www.guardian.co.uk/technology/2012/apr/30/british-isps-block-pirate-bay), but my magic mind powers suggest that this might be related to #1051, which was fixed by #1142. I don't think that fix is in PyPI yet, but can you try installing the current repository version i... |
https://api.github.com/repos/psf/requests/issues/1143 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1143/labels{/name} | https://api.github.com/repos/psf/requests/issues/1143/comments | https://api.github.com/repos/psf/requests/issues/1143/events | https://github.com/psf/requests/pull/1143 | 10,305,884 | MDExOlB1bGxSZXF1ZXN0Mzg1Mjk3Nw== | 1,143 | Response as iterator | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 16 | 2013-01-25T10:11:20Z | 2021-09-08T19:00:42Z | 2013-01-29T04:52:18Z | MEMBER | resolved | Either:
``` python
r = requests.get('http://bigsite.com/')
for line in r:
# Do stuff.
```
or:
``` python
r = requests.get('http://bigsite.com/')
for chunk in r:
# Do stuff.
```
See #1141.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1143/reactions"
} | https://api.github.com/repos/psf/requests/issues/1143/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1143.diff",
"html_url": "https://github.com/psf/requests/pull/1143",
"merged_at": "2013-01-29T04:52:18Z",
"patch_url": "https://github.com/psf/requests/pull/1143.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1143"
} | true | [
"This breeds ambiguity I think. On the one hand iterating over the lines would work in the above example, but how should the user expect the following to behave?\n\n``` python\nr = requests.get('https://s3.amazon.com/big_download.tar.gz', stream=True)\n\nfor data in r:\n # Do stuff.\n```\n\nFor this reason alone... |
https://api.github.com/repos/psf/requests/issues/1142 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1142/labels{/name} | https://api.github.com/repos/psf/requests/issues/1142/comments | https://api.github.com/repos/psf/requests/issues/1142/events | https://github.com/psf/requests/pull/1142 | 10,300,677 | MDExOlB1bGxSZXF1ZXN0MzgzNDUyNQ== | 1,142 | Remove default Content-Length from GET requests. | {
"avatar_url": "https://avatars.githubusercontent.com/u/440353?v=4",
"events_url": "https://api.github.com/users/theaeolianmachine/events{/privacy}",
"followers_url": "https://api.github.com/users/theaeolianmachine/followers",
"following_url": "https://api.github.com/users/theaeolianmachine/following{/other_user}",
"gists_url": "https://api.github.com/users/theaeolianmachine/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/theaeolianmachine",
"id": 440353,
"login": "theaeolianmachine",
"node_id": "MDQ6VXNlcjQ0MDM1Mw==",
"organizations_url": "https://api.github.com/users/theaeolianmachine/orgs",
"received_events_url": "https://api.github.com/users/theaeolianmachine/received_events",
"repos_url": "https://api.github.com/users/theaeolianmachine/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/theaeolianmachine/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/theaeolianmachine/subscriptions",
"type": "User",
"url": "https://api.github.com/users/theaeolianmachine",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2013-01-25T05:19:16Z | 2021-09-08T19:00:41Z | 2013-01-26T04:58:20Z | NONE | resolved | Fix #1051.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1142/reactions"
} | https://api.github.com/repos/psf/requests/issues/1142/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1142.diff",
"html_url": "https://github.com/psf/requests/pull/1142",
"merged_at": "2013-01-26T04:58:20Z",
"patch_url": "https://github.com/psf/requests/pull/1142.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1142"
} | true | [
"Great will fix\n",
"We need PATCH in that tuple as well.\n",
"Let's do the opposite:\n\nif not self.method in ('GET', 'HEAD')\n",
"Yeah, I should have done that from the start :).\n",
"Does anyone know if I merge these locally and force push, will the pull request on Github figure it out? Most of these com... |
https://api.github.com/repos/psf/requests/issues/1141 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1141/labels{/name} | https://api.github.com/repos/psf/requests/issues/1141/comments | https://api.github.com/repos/psf/requests/issues/1141/events | https://github.com/psf/requests/issues/1141 | 10,282,937 | MDU6SXNzdWUxMDI4MjkzNw== | 1,141 | [RFC] Response as a string | {
"avatar_url": "https://avatars.githubusercontent.com/u/259697?v=4",
"events_url": "https://api.github.com/users/nfx/events{/privacy}",
"followers_url": "https://api.github.com/users/nfx/followers",
"following_url": "https://api.github.com/users/nfx/following{/other_user}",
"gists_url": "https://api.github.com/users/nfx/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nfx",
"id": 259697,
"login": "nfx",
"node_id": "MDQ6VXNlcjI1OTY5Nw==",
"organizations_url": "https://api.github.com/users/nfx/orgs",
"received_events_url": "https://api.github.com/users/nfx/received_events",
"repos_url": "https://api.github.com/users/nfx/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nfx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nfx/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nfx",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-01-24T18:18:28Z | 2021-09-09T05:00:49Z | 2013-01-25T10:09:56Z | NONE | resolved | In some cases it could be useful, that response would act as a string:
```
>>> response = requests.get('https://api.thing.somewhere/size/blah', auth=('user', 'pass'))
>>> response.status_code
200
>>> "Blah is %d big" % response
Blah is 3242 big
>>> response.headers['content-type']
'text/plain'
```
is it contrary to pythonic ideas?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1141/reactions"
} | https://api.github.com/repos/psf/requests/issues/1141/timeline | null | completed | null | null | false | [
"It's not un-pythonic, but I would argue it violates the principle of least surprise. I would not say that a Response's string representation is its Content Length.\n",
"yeah, i don't think we want to go this route.\n\nA better question is should responses be iterable?\n",
"I will say yes if you can tell me wha... |
https://api.github.com/repos/psf/requests/issues/1140 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1140/labels{/name} | https://api.github.com/repos/psf/requests/issues/1140/comments | https://api.github.com/repos/psf/requests/issues/1140/events | https://github.com/psf/requests/pull/1140 | 10,281,884 | MDExOlB1bGxSZXF1ZXN0MzgyNDcyMQ== | 1,140 | Test for cookie parameters. | {
"avatar_url": "https://avatars.githubusercontent.com/u/331338?v=4",
"events_url": "https://api.github.com/users/ralphbean/events{/privacy}",
"followers_url": "https://api.github.com/users/ralphbean/followers",
"following_url": "https://api.github.com/users/ralphbean/following{/other_user}",
"gists_url": "https://api.github.com/users/ralphbean/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ralphbean",
"id": 331338,
"login": "ralphbean",
"node_id": "MDQ6VXNlcjMzMTMzOA==",
"organizations_url": "https://api.github.com/users/ralphbean/orgs",
"received_events_url": "https://api.github.com/users/ralphbean/received_events",
"repos_url": "https://api.github.com/users/ralphbean/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ralphbean/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ralphbean/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ralphbean",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-01-24T17:49:38Z | 2021-09-08T18:01:27Z | 2013-01-26T04:58:35Z | CONTRIBUTOR | resolved | I wasn't sure if setting some parameters on cookies was working or not, so I wrote a unit test for it.
The test passes; turns out I was just using it wrong in my other module.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1140/reactions"
} | https://api.github.com/repos/psf/requests/issues/1140/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1140.diff",
"html_url": "https://github.com/psf/requests/pull/1140",
"merged_at": "2013-01-26T04:58:35Z",
"patch_url": "https://github.com/psf/requests/pull/1140.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1140"
} | true | [
":+1:\n",
"The test failure lies in unittest in python 2.6 not having the `assertIn` method. I'll work from @ralphbean's pr and add a work around tomorrow.\n",
"Oh.. I can push a fix commit. One moment.\n",
"There. :)\n",
":+1:\n\nLooks good to me.\n",
"yay!\n"
] |
https://api.github.com/repos/psf/requests/issues/1139 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1139/labels{/name} | https://api.github.com/repos/psf/requests/issues/1139/comments | https://api.github.com/repos/psf/requests/issues/1139/events | https://github.com/psf/requests/pull/1139 | 10,274,540 | MDExOlB1bGxSZXF1ZXN0MzgyMjAwNA== | 1,139 | HTTPDigestAuth et al don't preserve stream, proxies etc. | {
"avatar_url": "https://avatars.githubusercontent.com/u/238690?v=4",
"events_url": "https://api.github.com/users/alexdutton/events{/privacy}",
"followers_url": "https://api.github.com/users/alexdutton/followers",
"following_url": "https://api.github.com/users/alexdutton/following{/other_user}",
"gists_url": "https://api.github.com/users/alexdutton/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexdutton",
"id": 238690,
"login": "alexdutton",
"node_id": "MDQ6VXNlcjIzODY5MA==",
"organizations_url": "https://api.github.com/users/alexdutton/orgs",
"received_events_url": "https://api.github.com/users/alexdutton/received_events",
"repos_url": "https://api.github.com/users/alexdutton/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexdutton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexdutton/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexdutton",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-01-24T14:39:32Z | 2021-09-08T23:01:00Z | 2013-01-26T05:03:10Z | NONE | resolved | `HTTPDigestAuth.handle_401()` replaces the original response with another by doing `r.connection.send(r.request)`. This ignores the arguments originally passed to `Session.request()` such as `stream`, `proxies`, `timeout`, `verify` and `cert`.
`HTTPDigestAuth` (and other hooks that behave similarly) need a way to perform additional requests in the same context as the original. This could be done by having `request.Session` set the relevant instance attributes in `__init__()` and then doing `resp.session = self` after `self.send()`.
It's possible that `requests.request()` et al should also pass those arguments to the `Session.__init__()`, not `Session.request()`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1139/reactions"
} | https://api.github.com/repos/psf/requests/issues/1139/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1139.diff",
"html_url": "https://github.com/psf/requests/pull/1139",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1139.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1139"
} | true | [
"Hmm, I don't think this is the right approach currently. We'll have to reevaluate soon.\n"
] |
https://api.github.com/repos/psf/requests/issues/1138 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1138/labels{/name} | https://api.github.com/repos/psf/requests/issues/1138/comments | https://api.github.com/repos/psf/requests/issues/1138/events | https://github.com/psf/requests/pull/1138 | 10,259,344 | MDExOlB1bGxSZXF1ZXN0MzgxMzYwMw== | 1,138 | Time each request | {
"avatar_url": "https://avatars.githubusercontent.com/u/2089?v=4",
"events_url": "https://api.github.com/users/clee/events{/privacy}",
"followers_url": "https://api.github.com/users/clee/followers",
"following_url": "https://api.github.com/users/clee/following{/other_user}",
"gists_url": "https://api.github.com/users/clee/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/clee",
"id": 2089,
"login": "clee",
"node_id": "MDQ6VXNlcjIwODk=",
"organizations_url": "https://api.github.com/users/clee/orgs",
"received_events_url": "https://api.github.com/users/clee/received_events",
"repos_url": "https://api.github.com/users/clee/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/clee/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/clee/subscriptions",
"type": "User",
"url": "https://api.github.com/users/clee",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 11 | 2013-01-24T02:17:33Z | 2021-09-08T18:01:26Z | 2013-01-28T03:10:16Z | CONTRIBUTOR | resolved | Pretty simple - adds calls to time.time() around send() and a new attribute, Response.time_taken, to tell how long the last request took.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1138/reactions"
} | https://api.github.com/repos/psf/requests/issues/1138/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1138.diff",
"html_url": "https://github.com/psf/requests/pull/1138",
"merged_at": "2013-01-28T03:10:16Z",
"patch_url": "https://github.com/psf/requests/pull/1138.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1138"
} | true | [
"I like this, it's cool for simple metrics (needed something like this sometime ago). But wouldn't be better to put the result in the returned `Response` object?\n\nThat way we can use it like the code below and keep track of the request time for every request made.\n\n``` python\nimport requests\nresponse = reques... |
https://api.github.com/repos/psf/requests/issues/1137 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1137/labels{/name} | https://api.github.com/repos/psf/requests/issues/1137/comments | https://api.github.com/repos/psf/requests/issues/1137/events | https://github.com/psf/requests/pull/1137 | 10,258,588 | MDExOlB1bGxSZXF1ZXN0MzgxMzE5NQ== | 1,137 | Remove a test per @kennethreitz in IRC | {
"avatar_url": "https://avatars.githubusercontent.com/u/134455?v=4",
"events_url": "https://api.github.com/users/chadwhitacre/events{/privacy}",
"followers_url": "https://api.github.com/users/chadwhitacre/followers",
"following_url": "https://api.github.com/users/chadwhitacre/following{/other_user}",
"gists_url": "https://api.github.com/users/chadwhitacre/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/chadwhitacre",
"id": 134455,
"login": "chadwhitacre",
"node_id": "MDQ6VXNlcjEzNDQ1NQ==",
"organizations_url": "https://api.github.com/users/chadwhitacre/orgs",
"received_events_url": "https://api.github.com/users/chadwhitacre/received_events",
"repos_url": "https://api.github.com/users/chadwhitacre/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/chadwhitacre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chadwhitacre/subscriptions",
"type": "User",
"url": "https://api.github.com/users/chadwhitacre",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2013-01-24T01:36:17Z | 2021-09-08T18:01:26Z | 2013-01-24T01:37:13Z | CONTRIBUTOR | resolved | The test suite is moving from the httpbin pattern (which hits the network) to depending on the request.prepare method (which doesn't). Here's a start ...
:rocket:
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1137/reactions"
} | https://api.github.com/repos/psf/requests/issues/1137/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1137.diff",
"html_url": "https://github.com/psf/requests/pull/1137",
"merged_at": "2013-01-24T01:37:13Z",
"patch_url": "https://github.com/psf/requests/pull/1137.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1137"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/1136 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1136/labels{/name} | https://api.github.com/repos/psf/requests/issues/1136/comments | https://api.github.com/repos/psf/requests/issues/1136/events | https://github.com/psf/requests/pull/1136 | 10,258,515 | MDExOlB1bGxSZXF1ZXN0MzgxMzE1Ng== | 1,136 | introduce a test for link headers. | {
"avatar_url": "https://avatars.githubusercontent.com/u/27786?v=4",
"events_url": "https://api.github.com/users/steveklabnik/events{/privacy}",
"followers_url": "https://api.github.com/users/steveklabnik/followers",
"following_url": "https://api.github.com/users/steveklabnik/following{/other_user}",
"gists_url": "https://api.github.com/users/steveklabnik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/steveklabnik",
"id": 27786,
"login": "steveklabnik",
"node_id": "MDQ6VXNlcjI3Nzg2",
"organizations_url": "https://api.github.com/users/steveklabnik/orgs",
"received_events_url": "https://api.github.com/users/steveklabnik/received_events",
"repos_url": "https://api.github.com/users/steveklabnik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/steveklabnik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/steveklabnik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/steveklabnik",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-01-24T01:32:54Z | 2021-09-08T18:01:25Z | 2013-01-24T01:34:55Z | CONTRIBUTOR | resolved | This test is kinda bad, submitting for feedback, fixup, and eventual inclusion.
There's currently no test to to check that the `Link` header parsing actually works, so I wrote one.
It pings GitHub, so that's bad, obviously.
You mentioned on IRC that you could use `PreparedRequest`; should that be what I'm doing here?
:heart: :sparkling_heart: :heart:
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1136/reactions"
} | https://api.github.com/repos/psf/requests/issues/1136/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1136.diff",
"html_url": "https://github.com/psf/requests/pull/1136",
"merged_at": "2013-01-24T01:34:55Z",
"patch_url": "https://github.com/psf/requests/pull/1136.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1136"
} | true | [
"Hmm, we need a mocked Response connection adapter.\n\nI'm on it!\n",
"Also, I wanted to use httpbin, but it doesn't have a way to return them. Would that be useful to add to it?\n",
"Well, we're going to remove it completely. Give me a few, I'll give you a mock response which will be awesome.\n",
":metal:\n"... |
https://api.github.com/repos/psf/requests/issues/1135 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1135/labels{/name} | https://api.github.com/repos/psf/requests/issues/1135/comments | https://api.github.com/repos/psf/requests/issues/1135/events | https://github.com/psf/requests/pull/1135 | 10,258,129 | MDExOlB1bGxSZXF1ZXN0MzgxMjk0NQ== | 1,135 | Add OAuth to features | {
"avatar_url": "https://avatars.githubusercontent.com/u/619795?v=4",
"events_url": "https://api.github.com/users/mahmoudhossam/events{/privacy}",
"followers_url": "https://api.github.com/users/mahmoudhossam/followers",
"following_url": "https://api.github.com/users/mahmoudhossam/following{/other_user}",
"gists_url": "https://api.github.com/users/mahmoudhossam/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mahmoudhossam",
"id": 619795,
"login": "mahmoudhossam",
"node_id": "MDQ6VXNlcjYxOTc5NQ==",
"organizations_url": "https://api.github.com/users/mahmoudhossam/orgs",
"received_events_url": "https://api.github.com/users/mahmoudhossam/received_events",
"repos_url": "https://api.github.com/users/mahmoudhossam/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mahmoudhossam/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mahmoudhossam/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mahmoudhossam",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-01-24T01:15:27Z | 2021-09-08T18:01:24Z | 2013-01-24T01:16:30Z | CONTRIBUTOR | resolved | We have OAuth now, right?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1135/reactions"
} | https://api.github.com/repos/psf/requests/issues/1135/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1135.diff",
"html_url": "https://github.com/psf/requests/pull/1135",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1135.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1135"
} | true | [
"Removed from Requests proper actually :)\n"
] |
https://api.github.com/repos/psf/requests/issues/1134 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1134/labels{/name} | https://api.github.com/repos/psf/requests/issues/1134/comments | https://api.github.com/repos/psf/requests/issues/1134/events | https://github.com/psf/requests/pull/1134 | 10,257,930 | MDExOlB1bGxSZXF1ZXN0MzgxMjgzOA== | 1,134 | remove silly assert | {
"avatar_url": "https://avatars.githubusercontent.com/u/27786?v=4",
"events_url": "https://api.github.com/users/steveklabnik/events{/privacy}",
"followers_url": "https://api.github.com/users/steveklabnik/followers",
"following_url": "https://api.github.com/users/steveklabnik/following{/other_user}",
"gists_url": "https://api.github.com/users/steveklabnik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/steveklabnik",
"id": 27786,
"login": "steveklabnik",
"node_id": "MDQ6VXNlcjI3Nzg2",
"organizations_url": "https://api.github.com/users/steveklabnik/orgs",
"received_events_url": "https://api.github.com/users/steveklabnik/received_events",
"repos_url": "https://api.github.com/users/steveklabnik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/steveklabnik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/steveklabnik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/steveklabnik",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-01-24T01:05:10Z | 2021-09-08T23:01:06Z | 2013-01-24T01:06:40Z | CONTRIBUTOR | resolved | C'mon bro. :wink:
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1134/reactions"
} | https://api.github.com/repos/psf/requests/issues/1134/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1134.diff",
"html_url": "https://github.com/psf/requests/pull/1134",
"merged_at": "2013-01-24T01:06:40Z",
"patch_url": "https://github.com/psf/requests/pull/1134.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1134"
} | true | [
"one must question everything\n",
":metal:\n\nIt's true, you never know, someone may have monkey-patched `assert` to always return true!\n\nOh wait, this isn't Ruby. :wink: \n\nHopefully actually meaningful commits coming soon.\n",
"DON'T DO IT :-1: \n",
"```\n>>> True = False\n```\n",
"```\n File \"<stdin... |
https://api.github.com/repos/psf/requests/issues/1133 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1133/labels{/name} | https://api.github.com/repos/psf/requests/issues/1133/comments | https://api.github.com/repos/psf/requests/issues/1133/events | https://github.com/psf/requests/issues/1133 | 10,254,642 | MDU6SXNzdWUxMDI1NDY0Mg== | 1,133 | Pluggable Request objects? | {
"avatar_url": "https://avatars.githubusercontent.com/u/74351?v=4",
"events_url": "https://api.github.com/users/maxcountryman/events{/privacy}",
"followers_url": "https://api.github.com/users/maxcountryman/followers",
"following_url": "https://api.github.com/users/maxcountryman/following{/other_user}",
"gists_url": "https://api.github.com/users/maxcountryman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/maxcountryman",
"id": 74351,
"login": "maxcountryman",
"node_id": "MDQ6VXNlcjc0MzUx",
"organizations_url": "https://api.github.com/users/maxcountryman/orgs",
"received_events_url": "https://api.github.com/users/maxcountryman/received_events",
"repos_url": "https://api.github.com/users/maxcountryman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/maxcountryman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxcountryman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/maxcountryman",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 35 | 2013-01-23T23:04:09Z | 2021-09-09T05:00:46Z | 2013-02-05T19:44:05Z | CONTRIBUTOR | resolved | It would be super cool if it were possible to plug a custom Request object over a Session object. However it looks as though the Request object is hardcoded into the request method, e.g. https://github.com/kennethreitz/requests/blob/1a87f15e6f8d22be6855424b46b80f66d178fe40/requests/sessions.py#L264
Any thoughts on this?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/74351?v=4",
"events_url": "https://api.github.com/users/maxcountryman/events{/privacy}",
"followers_url": "https://api.github.com/users/maxcountryman/followers",
"following_url": "https://api.github.com/users/maxcountryman/following{/other_user}",
"gists_url": "https://api.github.com/users/maxcountryman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/maxcountryman",
"id": 74351,
"login": "maxcountryman",
"node_id": "MDQ6VXNlcjc0MzUx",
"organizations_url": "https://api.github.com/users/maxcountryman/orgs",
"received_events_url": "https://api.github.com/users/maxcountryman/received_events",
"repos_url": "https://api.github.com/users/maxcountryman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/maxcountryman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxcountryman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/maxcountryman",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1133/reactions"
} | https://api.github.com/repos/psf/requests/issues/1133/timeline | null | completed | null | null | false | [
"Like changing the Session class's `__init__(self)` to `__init__(self, req=None)` then in the request method only create a new Request() if self.req is None?\n",
"What would your custom request object do?\n",
"@alanhamlett I think he means customizing the the Request class itself and using that instead of the o... |
https://api.github.com/repos/psf/requests/issues/1132 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1132/labels{/name} | https://api.github.com/repos/psf/requests/issues/1132/comments | https://api.github.com/repos/psf/requests/issues/1132/events | https://github.com/psf/requests/pull/1132 | 10,251,155 | MDExOlB1bGxSZXF1ZXN0MzgwOTEzOQ== | 1,132 | Pass kwargs to json.loads | {
"avatar_url": "https://avatars.githubusercontent.com/u/440820?v=4",
"events_url": "https://api.github.com/users/sburns/events{/privacy}",
"followers_url": "https://api.github.com/users/sburns/followers",
"following_url": "https://api.github.com/users/sburns/following{/other_user}",
"gists_url": "https://api.github.com/users/sburns/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sburns",
"id": 440820,
"login": "sburns",
"node_id": "MDQ6VXNlcjQ0MDgyMA==",
"organizations_url": "https://api.github.com/users/sburns/orgs",
"received_events_url": "https://api.github.com/users/sburns/received_events",
"repos_url": "https://api.github.com/users/sburns/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sburns/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sburns/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sburns",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-01-23T21:28:27Z | 2021-09-08T18:01:25Z | 2013-01-23T22:02:38Z | CONTRIBUTOR | resolved | Not all JSON is created equally. This commit
addresses when users want to take control of the
json decode process.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1132/reactions"
} | https://api.github.com/repos/psf/requests/issues/1132/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1132.diff",
"html_url": "https://github.com/psf/requests/pull/1132",
"merged_at": "2013-01-23T22:02:38Z",
"patch_url": "https://github.com/psf/requests/pull/1132.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1132"
} | true | [
"Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/1131 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1131/labels{/name} | https://api.github.com/repos/psf/requests/issues/1131/comments | https://api.github.com/repos/psf/requests/issues/1131/events | https://github.com/psf/requests/issues/1131 | 10,250,230 | MDU6SXNzdWUxMDI1MDIzMA== | 1,131 | New Session API feels awkward | {
"avatar_url": "https://avatars.githubusercontent.com/u/120601?v=4",
"events_url": "https://api.github.com/users/stevvooe/events{/privacy}",
"followers_url": "https://api.github.com/users/stevvooe/followers",
"following_url": "https://api.github.com/users/stevvooe/following{/other_user}",
"gists_url": "https://api.github.com/users/stevvooe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stevvooe",
"id": 120601,
"login": "stevvooe",
"node_id": "MDQ6VXNlcjEyMDYwMQ==",
"organizations_url": "https://api.github.com/users/stevvooe/orgs",
"received_events_url": "https://api.github.com/users/stevvooe/received_events",
"repos_url": "https://api.github.com/users/stevvooe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stevvooe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevvooe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stevvooe",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-01-23T21:07:58Z | 2021-09-09T04:00:32Z | 2013-01-23T22:06:32Z | NONE | resolved | With the old session api, one could set defaults with kwargs on session instantiation. For example, usage was similar to the following:
```
with requests.session(cookies=mycookiejar, timeout=0.5):
... do some work
```
This allowed one to rollup session parameters for subclasses quite nicely:
```
class MySession(object):
def __init__(self, myparam, *args, **kwargs):
kwargs.setdefault('auth', self)
super(MySession, self).__init__(self, *args, **kwargs)
self.myparam = myparam
def __call__(self, request):
... perform some auth with myparam
```
However, the new api is rather awkward in that it requires these params to be painstakingly broken out:
```
with requests.session() as s:
s.auth = myauth
s.cookies = mycookiejar
... do something with session
```
Now, I wouldn't say this new API type is a bug, but its definitely less flexible in a situation where one wants to consolidate functionality in the session object, which is common for use with APIs. It's also unclear as to why this particular change was made when moving version 1.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/1131/reactions"
} | https://api.github.com/repos/psf/requests/issues/1131/timeline | null | completed | null | null | false | [
":+1: I agree that the new API has left something to be desired...\n",
"I don't see 'less flexible'. I could see 'more verbose' as a complaint, but 'less flexible' doesn't seem right.\n\nThe rationale (as best I understand it) for the new Session API is that it places all aspects of the Session on equal footing. ... |
https://api.github.com/repos/psf/requests/issues/1130 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1130/labels{/name} | https://api.github.com/repos/psf/requests/issues/1130/comments | https://api.github.com/repos/psf/requests/issues/1130/events | https://github.com/psf/requests/issues/1130 | 10,249,817 | MDU6SXNzdWUxMDI0OTgxNw== | 1,130 | `timeout` should be settable on session | {
"avatar_url": "https://avatars.githubusercontent.com/u/120601?v=4",
"events_url": "https://api.github.com/users/stevvooe/events{/privacy}",
"followers_url": "https://api.github.com/users/stevvooe/followers",
"following_url": "https://api.github.com/users/stevvooe/following{/other_user}",
"gists_url": "https://api.github.com/users/stevvooe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stevvooe",
"id": 120601,
"login": "stevvooe",
"node_id": "MDQ6VXNlcjEyMDYwMQ==",
"organizations_url": "https://api.github.com/users/stevvooe/orgs",
"received_events_url": "https://api.github.com/users/stevvooe/received_events",
"repos_url": "https://api.github.com/users/stevvooe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stevvooe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevvooe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stevvooe",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-01-23T20:56:20Z | 2021-09-09T00:01:06Z | 2013-01-23T21:01:01Z | NONE | resolved | It would be nice to have a default timeout for all requests within a session. Currently, this isn't possible because timeout is only taken as an argument to `Session.request`. As a workaround, I am using something similar to the following:
```
class TimeoutSession(requests.Session):
def __init__(self, timeout=None):
self.timeout = timeout
def request(self, *args, **kwargs):
kwargs.setdefault('timeout', self.timeout)
return super(TimeoutSession, self).request(*args, **kwargs)
```
This allows the timeout to be overridden on individual requests, but uses the session timeout if its not specified.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1130/reactions"
} | https://api.github.com/repos/psf/requests/issues/1130/timeline | null | completed | null | null | false | [
"Timeout is a parameter of the act of sending a request now.\n\nBasically, session-level timeouts down't make sense when we have connection adapters.\n",
"What is the suggested method for setting the same timeout for a set of requests? Do you suggest we override the Adapter?\n",
"Also, do you mind letting this ... |
https://api.github.com/repos/psf/requests/issues/1129 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1129/labels{/name} | https://api.github.com/repos/psf/requests/issues/1129/comments | https://api.github.com/repos/psf/requests/issues/1129/events | https://github.com/psf/requests/pull/1129 | 10,227,910 | MDExOlB1bGxSZXF1ZXN0Mzc5NzY0MA== | 1,129 | New download() method on Response model for saving response content to local file... | {
"avatar_url": "https://avatars.githubusercontent.com/u/522344?v=4",
"events_url": "https://api.github.com/users/alanhamlett/events{/privacy}",
"followers_url": "https://api.github.com/users/alanhamlett/followers",
"following_url": "https://api.github.com/users/alanhamlett/following{/other_user}",
"gists_url": "https://api.github.com/users/alanhamlett/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alanhamlett",
"id": 522344,
"login": "alanhamlett",
"node_id": "MDQ6VXNlcjUyMjM0NA==",
"organizations_url": "https://api.github.com/users/alanhamlett/orgs",
"received_events_url": "https://api.github.com/users/alanhamlett/received_events",
"repos_url": "https://api.github.com/users/alanhamlett/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alanhamlett/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alanhamlett/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alanhamlett",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-01-23T10:52:23Z | 2021-09-08T18:01:23Z | 2013-01-23T13:23:14Z | CONTRIBUTOR | resolved | ...without reading whole response content into machine memory.
Includes 1 new test case.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1129/reactions"
} | https://api.github.com/repos/psf/requests/issues/1129/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1129.diff",
"html_url": "https://github.com/psf/requests/pull/1129",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1129.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1129"
} | true | [
"Firstly, thanks for the pull request! It's always great to have contributions. =)\n\nSecondly, and being up-front, I don't think this is likely to get accepted into the library. _Do not close this PR based on that comment_ (some people have done in the past), that decision isn't mine, but I suspect this PR won't g... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.